Repository navigation
perf(agent): avoid redundant subgraph definition reads - #16971
Conversation
|
Warning Review limit reachedNext included review available in 28 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (4)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1908 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.69 MB gzip 🔴 +56 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.6 MB (baseline 3.6 MB) • 🔴 +453 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 559 kB (baseline 559 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 18 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category
Status: 72 added / 72 removed / 224 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-04T13:08:12.907Z",
"gitSha": "44e21fc700b2fd5e5aa91d0468dfa51dc522bfc8",
"branch": "christian-byrne/ev122-3-incremental-definition-reads",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2039.5639999999844,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.203999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 509.0950000000001,
"heapDeltaBytes": 12493276,
"heapUsedBytes": 82393148,
"domNodes": -276,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 10.256999999999998,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2056.527000000017,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.691,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.366,
"heapDeltaBytes": -11866112,
"heapUsedBytes": 57996720,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.920999999999998,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2054.0090000000077,
"styleRecalcs": 79,
"styleRecalcDurationMs": 44.885,
"layouts": 14,
"layoutDurationMs": 4.281999999999999,
"taskDurationMs": 1020.4709999999999,
"heapDeltaBytes": -8239092,
"heapUsedBytes": 62650236,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 174.614,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1853.4859999999753,
"styleRecalcs": 73,
"styleRecalcDurationMs": 38.603,
"layouts": 14,
"layoutDurationMs": 4.546,
"taskDurationMs": 894.671,
"heapDeltaBytes": -8395548,
"heapUsedBytes": 62412808,
"domNodes": -283,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 159.51700000000002,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1665.7240000000115,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.351,
"layouts": 6,
"layoutDurationMs": 0.9600000000000002,
"taskDurationMs": 359.199,
"heapDeltaBytes": 5174804,
"heapUsedBytes": 75759052,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.637,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1751.4469999999847,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.982999999999997,
"layouts": 6,
"layoutDurationMs": 0.9890000000000001,
"taskDurationMs": 367.49,
"heapDeltaBytes": 4789092,
"heapUsedBytes": 75153044,
"domNodes": 76,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 11.456999999999999,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 647.8339999999889,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.956000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.353,
"heapDeltaBytes": 18842328,
"heapUsedBytes": 88549452,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 164.56,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 698.0419999999867,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.819000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.95,
"heapDeltaBytes": -7872904,
"heapUsedBytes": 63062536,
"domNodes": 18,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 168.47899999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2004.8719999999776,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.456999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.8440000000002,
"heapDeltaBytes": 22345820,
"heapUsedBytes": 87637544,
"domNodes": -270,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 39.910000000000004,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2053.3080000000155,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.6430000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 613.5410000000002,
"heapDeltaBytes": -13808740,
"heapUsedBytes": 87464824,
"domNodes": -268,
"jsHeapTotalBytes": 720896,
"scriptDurationMs": 34.827,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2298.6040000000116,
"styleRecalcs": 62,
"styleRecalcDurationMs": 7.753000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1624.509,
"heapDeltaBytes": 21901560,
"heapUsedBytes": 88232612,
"domNodes": 0,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 800.4259999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2309.2920000000277,
"styleRecalcs": 65,
"styleRecalcDurationMs": 9.699000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1663.9429999999998,
"heapDeltaBytes": 18660052,
"heapUsedBytes": 84424976,
"domNodes": -271,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 829.025,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3598.5339999999724,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.762999999999998,
"layouts": 60,
"layoutDurationMs": 11.735000000000001,
"taskDurationMs": 1689.326,
"heapDeltaBytes": 8486396,
"heapUsedBytes": 76092748,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 767.3820000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3434.8889999999983,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.571,
"layouts": 60,
"layoutDurationMs": 11.665,
"taskDurationMs": 1648.742,
"heapDeltaBytes": 12028700,
"heapUsedBytes": 79807964,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 752.0840000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3029.002000000048,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.616000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1911.3069999999998,
"heapDeltaBytes": 21631192,
"heapUsedBytes": 88738244,
"domNodes": -277,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 948.8059999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3062.0460000000094,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.7230000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1893.3719999999998,
"heapDeltaBytes": 22281472,
"heapUsedBytes": 89994772,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 946.4229999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2028.8789999999608,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.5619999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.2120000000001,
"heapDeltaBytes": -15796696,
"heapUsedBytes": 87908900,
"domNodes": -272,
"jsHeapTotalBytes": -1376256,
"scriptDurationMs": 34.136,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2027.9090000000224,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.7230000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 589.673,
"heapDeltaBytes": -15559656,
"heapUsedBytes": 88072728,
"domNodes": -269,
"jsHeapTotalBytes": -1376256,
"scriptDurationMs": 34.57300000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 595.1379999999631,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.485,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.94500000000005,
"heapDeltaBytes": 14825528,
"heapUsedBytes": 87721416,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 144.13500000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 597.1820000000889,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.998999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.98,
"heapDeltaBytes": 14925332,
"heapUsedBytes": 87831272,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 145.758,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2016.5160000000242,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.641000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.961,
"heapDeltaBytes": -8738948,
"heapUsedBytes": 63838244,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.623,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2020.5480000000193,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.808,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.90599999999995,
"heapDeltaBytes": -8693244,
"heapUsedBytes": 64120596,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.856999999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1735.3030000000444,
"styleRecalcs": 77,
"styleRecalcDurationMs": 34.793000000000006,
"layouts": 18,
"layoutDurationMs": 4.659,
"taskDurationMs": 815.446,
"heapDeltaBytes": 2614292,
"heapUsedBytes": 75449320,
"domNodes": -296,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 105.255,
"eventListeners": -228,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1713.7950000000046,
"styleRecalcs": 76,
"styleRecalcDurationMs": 38.798,
"layouts": 18,
"layoutDurationMs": 5.78,
"taskDurationMs": 874.1669999999999,
"heapDeltaBytes": -10488832,
"heapUsedBytes": 62006316,
"domNodes": -297,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 115.848,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.4209999999748,
"styleRecalcs": 20,
"styleRecalcDurationMs": 31.934000000000005,
"layouts": 16,
"layoutDurationMs": 15.281000000000002,
"taskDurationMs": 951.7679999999999,
"heapDeltaBytes": -5534436,
"heapUsedBytes": 90154168,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 32.437000000000005,
"eventListeners": 2385,
"totalBlockingTimeMs": 135,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8549.374,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.805,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5768.958,
"heapDeltaBytes": -12808276,
"heapUsedBytes": 89062728,
"domNodes": -266,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 2623.096,
"eventListeners": -132,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8568.683999999961,
"styleRecalcs": 248,
"styleRecalcDurationMs": 41.811,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5915.351,
"heapDeltaBytes": -16104732,
"heapUsedBytes": 85284700,
"domNodes": -267,
"jsHeapTotalBytes": -102400,
"scriptDurationMs": 2690.744,
"eventListeners": -132,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17030.982999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16580.465,
"heapDeltaBytes": -34833388,
"heapUsedBytes": 175644724,
"domNodes": -6548,
"jsHeapTotalBytes": 3645440,
"scriptDurationMs": 294.149,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17087.631999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16595.728000000003,
"heapDeltaBytes": -40353324,
"heapUsedBytes": 180573432,
"domNodes": -6548,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 319.14300000000003,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20909.467999999946,
"styleRecalcs": 175,
"styleRecalcDurationMs": 17.648000000000053,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20583.014000000003,
"heapDeltaBytes": -22206636,
"heapUsedBytes": 180405604,
"domNodes": -6548,
"jsHeapTotalBytes": 237568,
"scriptDurationMs": 871.3270000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 102,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20995.411000000102,
"styleRecalcs": 168,
"styleRecalcDurationMs": 18.57500000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20706.61,
"heapDeltaBytes": -40286844,
"heapUsedBytes": 163044564,
"domNodes": -6548,
"jsHeapTotalBytes": 1712128,
"scriptDurationMs": 927.9569999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 39,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6244.756999999992,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.10600000000001,
"layouts": 20,
"layoutDurationMs": 22.19700000000001,
"taskDurationMs": 6107.360999999999,
"heapDeltaBytes": -28077800,
"heapUsedBytes": 177289868,
"domNodes": -6548,
"jsHeapTotalBytes": 13647872,
"scriptDurationMs": 110.24400000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 413,
"frameDurationMs": 18.33666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6176.443999999947,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.075,
"layouts": 20,
"layoutDurationMs": 22.847999999999992,
"taskDurationMs": 6070.496999999999,
"heapDeltaBytes": -8540204,
"heapUsedBytes": 196595976,
"domNodes": -6548,
"jsHeapTotalBytes": 17276928,
"scriptDurationMs": 108.906,
"eventListeners": -7469,
"totalBlockingTimeMs": 405,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8595.204999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8371.066,
"heapDeltaBytes": 10587392,
"heapUsedBytes": 177098236,
"domNodes": 0,
"jsHeapTotalBytes": -11010048,
"scriptDurationMs": 154.74599999999998,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8762.789999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8442.190999999997,
"heapDeltaBytes": 20864716,
"heapUsedBytes": 176125652,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 143.53000000000006,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 483.8770000000068,
"styleRecalcs": 11,
"styleRecalcDurationMs": 17.517,
"layouts": 2,
"layoutDurationMs": 0.46799999999999986,
"taskDurationMs": 129.70100000000002,
"heapDeltaBytes": 4814976,
"heapUsedBytes": 73638688,
"domNodes": 118,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.094,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 105.5580000000873,
"styleRecalcs": 9,
"styleRecalcDurationMs": 14.474999999999998,
"layouts": 2,
"layoutDurationMs": 1.308,
"taskDurationMs": 73.879,
"heapDeltaBytes": 2992988,
"heapUsedBytes": 71656564,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.813999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #16971 +/- ##
==========================================
+ Coverage 81.23% 82.80% +1.56%
==========================================
Files 2464 2046 -418
Lines 126966 119514 -7452
Branches 32036 30219 -1817
==========================================
- Hits 103141 98958 -4183
+ Misses 23310 20376 -2934
+ Partials 515 180 -335
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 426 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 5 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 1 |
| 🟢 Low | 2 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
|
|
||
| function collectDefinitionIds(source: unknown, ids: string[]): void { | ||
| const id = readField(source, 'id') | ||
| if (typeof id === 'string') ids.push(id) |
There was a problem hiding this comment.
🟠 High — collectDefinitionIds only accepts an id whose raw slot is already a primitive string, but readSubgraphDefinitions normalizes every slot through plain()/toJSON(), so a UUID that arrived as a Y.Text (the raw-update folding case this module documents and tests) projects to a registerable id yet is invisible here. The new gate then sees nothing missing, skips the full read on every subsequent frame, and nodes typed by that definition stay permanent missing-node placeholders; definitions with an absent or non-string id likewise lose the one-time agent_subgraph_definitions_failed report the always-read path produced via tryCreateSubgraph. Route the value through plain() before the typeof check (readList has the same blind spot for a Y.Map-shaped definitions.subgraphs), or have the gate fall back to the full read when the scan yields fewer ids than the definitions root holds. Raised by 6 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case, kimi-k3-max adversarial, kimi-k3-max edge-case).
| if (typeof id === 'string') ids.push(id) | ||
| const nested = readField(readField(source, 'definitions'), 'subgraphs') | ||
| for (const definition of readList(nested)) { | ||
| collectDefinitionIds(definition, ids) |
There was a problem hiding this comment.
🟡 Medium — collectDefinitionIds recurses through definitions.subgraphs with no depth guard, and unlike the full projector it now runs unconditionally on every applied frame. A document with deeply nested definitions overflows the stack, and the RangeError escapes reconcileLiveGraph into the uncaught onUpdate path, aborting the rest of the frame handler including its bookkeeping — contrary to this module's contract that nothing in the reader may throw during follower reconcile. Cap the depth or walk with an explicit stack. Raised by 4 of 8 reviewers (gemini-3.1-pro adversarial, gpt-5.6-sol-max adversarial, gemini-3.1-pro edge-case, claude-opus-5-thinking-max adversarial).
| graph, | ||
| readSubgraphDefinitions(bridge.follower.doc) | ||
| const definitionIds = readSubgraphDefinitionIds(bridge.follower.doc) | ||
| const hasMissingDefinition = definitionIds.some( |
There was a problem hiding this comment.
🟢 Low — A definition that can never register — a non-UUID id rejected by tryCreateSubgraph, or a body that always throws in configure and is rolled back — never lands in rootGraph.subgraphs, so hasMissingDefinition stays true for the life of the document and every frame pays the full readSubgraphDefinitions deep copy this change exists to avoid. Because reportedDefinitionFailures suppresses telemetry after the first report, the degradation is silent and scales with document size on a high-frequency channel. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, gemini-3.1-pro adversarial).
|
|
||
| function readField(source: unknown, key: string): unknown { | ||
| if (source instanceof Y.Map) return source.get(key) | ||
| if (typeof source !== 'object' || source === null || !(key in source)) { |
There was a problem hiding this comment.
🟢 Low — readField resolves plain-object keys with key in source plus Reflect.get, both of which walk the prototype chain, while readDefinition deliberately drops __proto__ via isReadableKey because Yjs decodes JSON objects by plain assignment (so a wire-supplied __proto__ swaps the object's prototype). A crafted document can therefore hand this scanner an inherited id that the projection path ignores, making the two readers disagree about which definitions exist. Use Object.hasOwn and skip __proto__ to match readDefinition. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
| const hasMissingDefinition = definitionIds.some( | ||
| (id) => !graph.rootGraph.subgraphs.has(id) | ||
| ) | ||
| const definitions = hasMissingDefinition |
There was a problem hiding this comment.
⚪ Nit — This gate duplicates registerSubgraphDefinitions's own !rootGraph.subgraphs.has(definition.id) filter, so the two predicates must now be kept in sync by hand. If registration ever needs the body of an already-registered id — to pick up a changed definition, for example — the follower will silently starve it of input with no local signal; deriving the gate from the same helper the registrar uses would keep them from drifting. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max edge-case, gemini-3.1-pro edge-case, gemini-3.1-pro adversarial).
CodeJuggernaut
left a comment
There was a problem hiding this comment.
Read at eb9285b: the reset path is equivalent to before because registerSubgraphDefinitions already filters to missing ids, and the cheap id scan iterates the definitions root with the same instanceof guard as the full projector. Nothing to add.
… reads (#17871) ## Summary Backports [#16971](#16971) to `core/1.54`, avoiding full subgraph-definition reads on ordinary Agent CRDT frames. ## Changes - **What**: preserves the merged source's ID-only fast path and its definition/follower regressions - **Dependencies**: none; canonical release mapping `relmap-1`, before `relmap-2` / [frontend 17202](#17202) ## Review Focus Target head was `e6dae0ee1c8f0dc490d7f81bbf66fa39988e3608`; source commit `eca7d5601eb217156953fc2b191af7f904c0b41d` was applied with `cherry-pick -x`. Target-tree evidence: - focused Agent definition/follower/materializer Vitest: 100 passed - focused ESLint: passed - `pnpm typecheck`: passed - promoted-widget shared-definition Playwright case: 1 passed on lane port 6201 - `git diff --check`: passed Justification: OSS maintainer-reviewed contribution — @CodeJuggernaut approved source PR #16971 at its exact source head before backport; stable patch IDs match and no code changed in transit.
Backports [Frontend 16971](#16971) to `cloud/1.54`. Patch-identical; cloud pins unchanged. <details><summary>Full context for agent readers</summary> ## Summary - Cherry-picks merged source `eca7d5601eb217156953fc2b191af7f904c0b41d` with `-x` onto exact `cloud/1.54` head `985f3f26c5903b3f6b0b023394968c824ca3077b`. - Avoids full subgraph-definition reads on unrelated Agent CRDT frames while retaining full materialization when a definition is missing. - Stable patch ID matches source: `02c5743052b3d1bdfa17b4c71fc5df819520ca7d`. ## Verification - Agent definition/follower/materializer Vitest: 3 files, 100 tests passed. - ESLint, type-aware Oxlint, Oxfmt, Knip, typecheck, and cloud production build passed. - Browser acceptance on isolated ports 6248/6249: shared-definition sibling host widget edits stayed isolated; cloud production preview passed Agent flag-off and flag-on lifecycle checks. - Frontend remains `1.54.10`; `@comfyorg/comfy-multi-player` remains `0.2.1`; no package or lockfile changed. Justification: exact source head was approved by CodeJuggernaut before merge; this release PR carries the identical stable patch plus target-specific unit, static, production-build, and browser acceptance evidence. </details>
## Summary Make the lightweight subgraph-definition ID scan agree with the full projector's ID normalization and own-key handling while remaining safe on deeply nested documents. ## Changes - **What**: Normalize shared-type IDs, ignore inherited record fields, replace recursive traversal with an explicit stack, and add discriminating regressions for all three boundaries. ## Review Focus The iterative traversal preserves depth-first definition order by pushing children in reverse. The 12,000-level regression distinguishes it from the previous recursive implementation. At exact head `b85749616595edac8d33a5840ad213264c16f000`, human review recorded 30 focused tests passing plus file-scoped ESLint and formatting checks passing; hosted CI is also green. <details><summary>Full context for agent readers</summary> This ports the still-valid high, medium, and low findings left unresolved after merged PR 16971. A `Y.Text` ID now passes through the same `plain()` projection used by the full reader. Plain records use own-key lookup, matching the projector's unsafe-key boundary. No production API or schema changes. Original findings: - Comfy-Org#16971 (comment) - Comfy-Org#16971 (comment) - Comfy-Org#16971 (comment) </details>
## Summary Make the lightweight subgraph-definition ID scan agree with the full projector's ID normalization and own-key handling while remaining safe on deeply nested documents. ## Changes - **What**: Normalize shared-type IDs, ignore inherited record fields, replace recursive traversal with an explicit stack, and add discriminating regressions for all three boundaries. ## Review Focus The iterative traversal preserves depth-first definition order by pushing children in reverse. The 12,000-level regression distinguishes it from the previous recursive implementation. At exact head `b85749616595edac8d33a5840ad213264c16f000`, human review recorded 30 focused tests passing plus file-scoped ESLint and formatting checks passing; hosted CI is also green. <details><summary>Full context for agent readers</summary> This ports the still-valid high, medium, and low findings left unresolved after merged PR 16971. A `Y.Text` ID now passes through the same `plain()` projection used by the full reader. Plain records use own-key lookup, matching the projector's unsafe-key boundary. No production API or schema changes. Original findings: - #16971 (comment) - #16971 (comment) - #16971 (comment) </details> (cherry picked from commit 0ab0c96)
Stops one rejected subgraph definition from forcing full-definition deep copies on every unrelated CRDT frame. <details><summary>Full context for agent readers</summary> ## What changed The ID-only projection now classifies each definition as registered, missing, or previously failed. It reads full bodies only when a genuinely missing definition needs registration. Previously failed IDs remain in the materializer's pending exclusion even when their bodies are skipped, so dependent nodes cannot degrade into missing-node placeholders. Explicit callers that provide a fresh definition body retain the existing retry behavior. A successful retry registers the definition and allows its dependent nodes to materialize normally. ## Regression coverage - Configure failures and invalid non-UUID IDs enter the failed state. - The follower projection skips the full reader for a previously failed definition. - A real projection/materializer regression runs two reconciles, proves the dependent node stays pending while the failed body is skipped, then proves an explicit successful retry materializes it. Browser E2E would add no distinct proof here: the change is entirely inside the document-reader/materializer boundary, with no user interaction or browser-only integration. The real-boundary Vitest regression exercises the production projection, definition reader, materializer, and live graph directly. ## Source Carries the remaining low-severity performance finding from Comfy-Org#16971 (comment) and addresses review findings Comfy-Org#18508 (comment) and Comfy-Org#18508 (comment). ## Verification Local executable checks were intentionally not run because the owner placed this host under an expensive-local-command restriction. Hosted CI is the executable verification source for this PR. `git diff --check` passed before commit. </details> --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Amp <amp@ampcode.com>
Avoids full subgraph-definition deep copies on unrelated CRDT frames. Registered definitions now take an ID-only fast path.
Full context for agent readers
Summary
reconcileLiveGraphfirst projects top-level and nested definition IDs. It materializes full definitions only when at least one ID is absent from the live root graph; ordinary node/widget frames still reconcile adapters with an empty definition list.Addresses item 3 of #16932 and the performance finding in #16922.
Review Focus
Evidence
NODE_OPTIONS="--no-experimental-webstorage" pnpm exec vitest run src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts src/workbench/extensions/agent/crdt/agentSubgraphDefinitions.test.ts— 2 files, 62 tests passedpnpm exec eslint src/workbench/extensions/agent/crdt/agentSubgraphDefinitions.ts src/workbench/extensions/agent/crdt/agentSubgraphDefinitions.test.ts src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts— passedpnpm typecheck— passedgit diff --check— passed