Repository navigation
[backport cloud/1.54] Avoid redundant subgraph definition reads - #17889
christian-byrne merged 1 commit into
Conversation
Avoids full subgraph-definition deep copies on unrelated CRDT frames. Registered definitions now take an ID-only fast path. <details><summary>Full context for agent readers</summary> ## Summary `reconcileLiveGraph` first projects top-level and nested definition IDs. It materializes full definitions only when at least one ID is absent from the live root graph; ordinary node/widget frames still reconcile adapters with an empty definition list. Addresses item 3 of #16932 and the performance finding in #16922. ## Review Focus - ID projection traverses nested definition metadata without reading interior node/link/widget bodies. - Missing definitions retain the existing full-reader and registration path. - A regression proves a widget-style applied frame does not invoke the full reader once definitions are registered. ## Evidence - `NODE_OPTIONS="--no-experimental-webstorage" pnpm exec vitest run src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts src/workbench/extensions/agent/crdt/agentSubgraphDefinitions.test.ts` — 2 files, 62 tests passed - `pnpm exec eslint src/workbench/extensions/agent/crdt/agentSubgraphDefinitions.ts src/workbench/extensions/agent/crdt/agentSubgraphDefinitions.test.ts src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts` — passed - `pnpm typecheck` — passed - `git diff --check` — passed - Commit hooks: oxfmt, type-aware oxlint, ESLint, typecheck — passed - Pre-push hook: knip — passed </details> <!-- authored-by:agent lane-ev122-3-1245 --> (cherry picked from commit eca7d56)
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1920 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-17T02:45:07.845Z",
"gitSha": "e555ad6cc7627edae64d8332095f4ae50e53404a",
"branch": "backport/cloud-1.54-subgraph-definition-read-cache",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2057.608000000016,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.7250000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.8140000000001,
"heapDeltaBytes": 5385484,
"heapUsedBytes": 75423716,
"domNodes": -278,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.327,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2013.351,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.1069999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.13899999999995,
"heapDeltaBytes": -6727220,
"heapUsedBytes": 62512176,
"domNodes": -278,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.705,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1788.9279999999985,
"styleRecalcs": 76,
"styleRecalcDurationMs": 34.812999999999995,
"layouts": 14,
"layoutDurationMs": 4.146000000000001,
"taskDurationMs": 756.618,
"heapDeltaBytes": 3107980,
"heapUsedBytes": 73170052,
"domNodes": -277,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 124.91000000000001,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1736.2449999999967,
"styleRecalcs": 73,
"styleRecalcDurationMs": 30.031000000000002,
"layouts": 14,
"layoutDurationMs": 3.7420000000000004,
"taskDurationMs": 714.2669999999999,
"heapDeltaBytes": 8085656,
"heapUsedBytes": 79059936,
"domNodes": -280,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 119.181,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1671.0489999999822,
"styleRecalcs": 32,
"styleRecalcDurationMs": 13.695,
"layouts": 6,
"layoutDurationMs": 0.9049999999999998,
"taskDurationMs": 297.825,
"heapDeltaBytes": 5099492,
"heapUsedBytes": 75531820,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.226000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1672.0379999999295,
"styleRecalcs": 32,
"styleRecalcDurationMs": 13.533999999999999,
"layouts": 6,
"layoutDurationMs": 0.9360000000000002,
"taskDurationMs": 290.974,
"heapDeltaBytes": 4976712,
"heapUsedBytes": 75929724,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.766,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 534.3610000000467,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.750000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 372.592,
"heapDeltaBytes": -7804920,
"heapUsedBytes": 62788012,
"domNodes": 18,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 129.39899999999997,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 565.8359999999902,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.994999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 377.291,
"heapDeltaBytes": 18126144,
"heapUsedBytes": 88316996,
"domNodes": 20,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 128.52200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2023.7640000000283,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.292999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.595,
"heapDeltaBytes": -14663136,
"heapUsedBytes": 87584928,
"domNodes": -264,
"jsHeapTotalBytes": -1638400,
"scriptDurationMs": 30.95799999999999,
"eventListeners": -140,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2028.7829999999758,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.881,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.82500000000005,
"heapDeltaBytes": -13854176,
"heapUsedBytes": 88414668,
"domNodes": -265,
"jsHeapTotalBytes": -851968,
"scriptDurationMs": 29.009999999999994,
"eventListeners": -140,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2137.5320000000215,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.071000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1247.2069999999999,
"heapDeltaBytes": 22619340,
"heapUsedBytes": 88972572,
"domNodes": -269,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 606.259,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2147.652999999991,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.011,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1275.471,
"heapDeltaBytes": 18159152,
"heapUsedBytes": 84495708,
"domNodes": 6,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 620.965,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3171.5980000000172,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.848,
"layouts": 60,
"layoutDurationMs": 11.334999999999999,
"taskDurationMs": 1366.785,
"heapDeltaBytes": 8203572,
"heapUsedBytes": 75895488,
"domNodes": -273,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 611.67,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3180.853999999954,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.208999999999996,
"layouts": 60,
"layoutDurationMs": 11.921,
"taskDurationMs": 1423.0220000000002,
"heapDeltaBytes": 8334164,
"heapUsedBytes": 75842016,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 633.768,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2258.76999999997,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.2700000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1495.2109999999998,
"heapDeltaBytes": 17762792,
"heapUsedBytes": 85608444,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 740.198,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2237.2040000000197,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.921,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1563.5280000000002,
"heapDeltaBytes": 18360884,
"heapUsedBytes": 85681600,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 761.459,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2031.169000000034,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.399,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 509.478,
"heapDeltaBytes": 9903240,
"heapUsedBytes": 87023804,
"domNodes": -269,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 30.974999999999994,
"eventListeners": -140,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2024.314000000004,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.5829999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.302,
"heapDeltaBytes": 10871084,
"heapUsedBytes": 87830928,
"domNodes": -270,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 29.222000000000005,
"eventListeners": -170,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 496.7690000000289,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.902999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 318.337,
"heapDeltaBytes": 14680200,
"heapUsedBytes": 86320860,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 109.837,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 547.06699999997,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.285,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 351.474,
"heapDeltaBytes": 15182096,
"heapUsedBytes": 87956452,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 116.976,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2035.6160000000045,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.367000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.45199999999994,
"heapDeltaBytes": -9180824,
"heapUsedBytes": 63394856,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 8.903,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2021.0650000000214,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.433000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.70000000000005,
"heapDeltaBytes": -9181820,
"heapUsedBytes": 63664916,
"domNodes": -294,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.915,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1704.0269999999964,
"styleRecalcs": 78,
"styleRecalcDurationMs": 30.225,
"layouts": 18,
"layoutDurationMs": 4.527000000000001,
"taskDurationMs": 662.43,
"heapDeltaBytes": 693128,
"heapUsedBytes": 73535028,
"domNodes": -291,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 85.70899999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1760.3649999999789,
"styleRecalcs": 78,
"styleRecalcDurationMs": 31.958000000000002,
"layouts": 18,
"layoutDurationMs": 4.612,
"taskDurationMs": 693.354,
"heapDeltaBytes": -2271404,
"heapUsedBytes": 70016884,
"domNodes": -295,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 88.06299999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 934.030000000007,
"styleRecalcs": 19,
"styleRecalcDurationMs": 25.253999999999998,
"layouts": 15,
"layoutDurationMs": 11.632,
"taskDurationMs": 735.6949999999999,
"heapDeltaBytes": -7209388,
"heapUsedBytes": 82232836,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 22.50200000000001,
"eventListeners": 2385,
"totalBlockingTimeMs": 93,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8273.851000000035,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.349000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4614.735,
"heapDeltaBytes": 5254868,
"heapUsedBytes": 81329596,
"domNodes": -266,
"jsHeapTotalBytes": 647168,
"scriptDurationMs": 2095.286,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8278.515999999967,
"styleRecalcs": 248,
"styleRecalcDurationMs": 39.262,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4678.106,
"heapDeltaBytes": 13629536,
"heapUsedBytes": 89561776,
"domNodes": -268,
"jsHeapTotalBytes": 1695744,
"scriptDurationMs": 2092.2810000000004,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14707.684000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14227.841999999999,
"heapDeltaBytes": -18927688,
"heapUsedBytes": 191722248,
"domNodes": -6548,
"jsHeapTotalBytes": 3420160,
"scriptDurationMs": 209.35399999999998,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14786.497000000054,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14281.134,
"heapDeltaBytes": -10349284,
"heapUsedBytes": 180268872,
"domNodes": -6548,
"jsHeapTotalBytes": 2400256,
"scriptDurationMs": 223.559,
"eventListeners": -7477,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17328.88499999996,
"styleRecalcs": 145,
"styleRecalcDurationMs": 14.509999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16985.143,
"heapDeltaBytes": -14174084,
"heapUsedBytes": 190839836,
"domNodes": -6548,
"jsHeapTotalBytes": -5709824,
"scriptDurationMs": 719.7679999999999,
"eventListeners": -7475,
"totalBlockingTimeMs": 73,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17458.05299999995,
"styleRecalcs": 146,
"styleRecalcDurationMs": 15.061999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17131.654000000002,
"heapDeltaBytes": -50230828,
"heapUsedBytes": 166683496,
"domNodes": -6548,
"jsHeapTotalBytes": 1826816,
"scriptDurationMs": 725.309,
"eventListeners": -7471,
"totalBlockingTimeMs": 27,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5230.837999999949,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.785000000000004,
"layouts": 20,
"layoutDurationMs": 20.843,
"taskDurationMs": 5103.212,
"heapDeltaBytes": -34269296,
"heapUsedBytes": 169963208,
"domNodes": -6548,
"jsHeapTotalBytes": 14020608,
"scriptDurationMs": 84.60900000000001,
"eventListeners": -7475,
"totalBlockingTimeMs": 226,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5345.901000000026,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.04200000000001,
"layouts": 20,
"layoutDurationMs": 21.090999999999998,
"taskDurationMs": 5243.692,
"heapDeltaBytes": -23426864,
"heapUsedBytes": 181702976,
"domNodes": -6547,
"jsHeapTotalBytes": 7675904,
"scriptDurationMs": 90.16799999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 231,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7309.864000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7146.483,
"heapDeltaBytes": 27025552,
"heapUsedBytes": 194128656,
"domNodes": 0,
"jsHeapTotalBytes": -14680064,
"scriptDurationMs": 107.317,
"eventListeners": 18,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7475.506999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7273.112000000001,
"heapDeltaBytes": 1230724,
"heapUsedBytes": 176038816,
"domNodes": 0,
"jsHeapTotalBytes": -7077888,
"scriptDurationMs": 110.979,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 458.217999999988,
"styleRecalcs": 18,
"styleRecalcDurationMs": 21.605,
"layouts": 3,
"layoutDurationMs": 1.341,
"taskDurationMs": 95.506,
"heapDeltaBytes": 4988316,
"heapUsedBytes": 73429584,
"domNodes": 148,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.924,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 75.83299999998871,
"styleRecalcs": 6,
"styleRecalcDurationMs": 10.685000000000002,
"layouts": 2,
"layoutDurationMs": 1.0430000000000001,
"taskDurationMs": 50.67800000000001,
"heapDeltaBytes": 2992732,
"heapUsedBytes": 72070336,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 3.596,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.54 #17889 +/- ##
=============================================
Coverage ? 82.98%
=============================================
Files ? 2052
Lines ? 119748
Branches ? 32805
=============================================
Hits ? 99375
Misses ? 20193
Partials ? 180
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…) (#17913) Backports [Frontend 17202](#17202) to `cloud/1.54` after dependency [Frontend 17889](#17889). Patch-identical; cloud pins unchanged. <details><summary>Full context for agent readers</summary> ## Summary - Preserves promoted widget edits on existing subgraph hosts. - Resolves Agent-created connections by declared promoted-slot identity. - Carries the source definition, follower, host-slot, graph-mutation, and store regressions unchanged. ## Linear - [FE-2033](https://linear.app/comfyorg/issue/FE-2033/agent-editing-subgraph-human-tech-review-needed) ## Verification - Exact target base: `4270d4e81db31768625a04be1b259fc1c552f7b6`. - Source commit: `d0dc978a1a4cf670b0a992d8c57381bd56fa9dcf`. - Backport head: `04468979520e49ff2331ee6801c5a6b44ffd659c`. - Stable source/backport patch ID: `73b75978da72d485df7cb054bd44045cecc79ccf`. - Six focused graph, store, definition, follower, host-slot, and ECS suites: 113 passed. - Full Agent CRDT suite: 36 files, 532 tests passed. - ESLint, type-aware Oxlint, Oxfmt, Knip, typecheck, browser typecheck, diff check, and production cloud build passed. - Production-preview browser acceptance on isolated port 6200: promoted host materialization, declared slot connection, promoted widget edit, Agent flag-off persistence, and flag-on open/close pressed state all passed (3 Playwright tests). - Frontend remains `1.54.10`; `@comfyorg/comfy-multi-player` remains `0.2.1`; no package or lockfile changed. Justification: DrJKL approved exact source head `8d0a074428264406fae7189053a5806b95dcdf42`; this release PR carries the identical stable patch plus target-specific unit, static, production-build, and browser acceptance evidence. </details> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Amp <amp@ampcode.com>
Backports Frontend 16971 to
cloud/1.54. Patch-identical; cloud pins unchanged.Full context for agent readers
Summary
eca7d5601eb217156953fc2b191af7f904c0b41dwith-xonto exactcloud/1.54head985f3f26c5903b3f6b0b023394968c824ca3077b.02c5743052b3d1bdfa17b4c71fc5df819520ca7d.Verification
1.54.10;@comfyorg/comfy-multi-playerremains0.2.1; no package or lockfile changed.Justification: exact source head was approved by CodeJuggernaut before merge; this release PR carries the identical stable patch plus target-specific unit, static, production-build, and browser acceptance evidence.