Skip to content

[backport cloud/1.54] Avoid redundant subgraph definition reads - #17889

Merged
christian-byrne merged 1 commit into
cloud/1.54from
backport/cloud-1.54-subgraph-definition-read-cache
Sep 17, 2026
Merged

christian-byrne merged 1 commit into
cloud/1.54from
backport/cloud-1.54-subgraph-definition-read-cache

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backports Frontend 16971 to cloud/1.54. Patch-identical; cloud pins unchanged.

Full context for agent readers

Summary

  • Cherry-picks merged source eca7d5601eb217156953fc2b191af7f904c0b41d with -x onto exact cloud/1.54 head 985f3f26c5903b3f6b0b023394968c824ca3077b.
  • Avoids full subgraph-definition reads on unrelated Agent CRDT frames while retaining full materialization when a definition is missing.
  • Stable patch ID matches source: 02c5743052b3d1bdfa17b4c71fc5df819520ca7d.

Verification

  • Agent definition/follower/materializer Vitest: 3 files, 100 tests passed.
  • ESLint, type-aware Oxlint, Oxfmt, Knip, typecheck, and cloud production build passed.
  • Browser acceptance on isolated ports 6248/6249: shared-definition sibling host widget edits stayed isolated; cloud production preview passed Agent flag-off and flag-on lifecycle checks.
  • Frontend remains 1.54.10; @comfyorg/comfy-multi-player remains 0.2.1; no package or lockfile changed.

Justification: exact source head was approved by CodeJuggernaut before merge; this release PR carries the identical stable patch plus target-specific unit, static, production-build, and browser acceptance evidence.

Avoids full subgraph-definition deep copies on unrelated CRDT frames.
Registered definitions now take an ID-only fast path.

<details><summary>Full context for agent readers</summary>

## Summary

`reconcileLiveGraph` first projects top-level and nested definition IDs.
It materializes full definitions only when at least one ID is absent
from the live root graph; ordinary node/widget frames still reconcile
adapters with an empty definition list.

Addresses item 3 of #16932 and the performance finding in #16922.

## Review Focus

- ID projection traverses nested definition metadata without reading
interior node/link/widget bodies.
- Missing definitions retain the existing full-reader and registration
path.
- A regression proves a widget-style applied frame does not invoke the
full reader once definitions are registered.

## Evidence

- `NODE_OPTIONS="--no-experimental-webstorage" pnpm exec vitest run
src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts
src/workbench/extensions/agent/crdt/agentSubgraphDefinitions.test.ts` —
2 files, 62 tests passed
- `pnpm exec eslint
src/workbench/extensions/agent/crdt/agentSubgraphDefinitions.ts
src/workbench/extensions/agent/crdt/agentSubgraphDefinitions.test.ts
src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts
src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts` —
passed
- `pnpm typecheck` — passed
- `git diff --check` — passed
- Commit hooks: oxfmt, type-aware oxlint, ESLint, typecheck — passed
- Pre-push hook: knip — passed

</details>

<!-- authored-by:agent lane-ev122-3-1245 -->

(cherry picked from commit eca7d56)
@vercel

vercel Bot commented Sep 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 17, 2026 2:34am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 87b0bd38-0965-4c0e-9d3f-6d4263a58477

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/17/2026, 02:36:38 AM UTC

Links

🎭 Playwright: ✅ 1920 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1899 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.6 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.2 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.9 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.7 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.4 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.7 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.1 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.6 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.5 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 93ms TBT · 78.4 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.5 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 177.4 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 50ms TBT · 170.5 MB heap
vue-node-resize-workload: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 229ms TBT · 167.7 MB heap
vue-zoom-out-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 176.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 427ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 65.8 MB
canvas-idle: DOM nodes -278
canvas-idle: event listeners -175
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 32ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 75
canvas-mouse-sweep: task duration 735ms
canvas-mouse-sweep: script duration 122ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 72.6 MB
canvas-mouse-sweep: DOM nodes -279
canvas-mouse-sweep: event listeners -160
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 14ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 294ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.2 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 375ms
dom-widget-clipping: script duration 129ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.1 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 492ms
large-graph-idle: script duration 30ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.9 MB
large-graph-idle: DOM nodes -265
large-graph-idle: event listeners -140
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 65
large-graph-pan: task duration 1261ms
large-graph-pan: script duration 614ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 82.7 MB
large-graph-pan: DOM nodes -132
large-graph-pan: event listeners 6
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 63
large-graph-zoom: task duration 1395ms
large-graph-zoom: script duration 623ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.4 MB
large-graph-zoom: DOM nodes -135
large-graph-zoom: event listeners 8
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 42
legacy-node-drag: task duration 1529ms
legacy-node-drag: script duration 751ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 81.7 MB
legacy-node-drag: DOM nodes 4
legacy-node-drag: event listeners 186
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 491ms
minimap-idle: script duration 30ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.4 MB
minimap-idle: DOM nodes -270
minimap-idle: event listeners -155
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 335ms
subgraph-dom-widget-clipping: script duration 113ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.1 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 422ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 60.6 MB
subgraph-idle: DOM nodes -294
subgraph-idle: event listeners -190
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 31ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 678ms
subgraph-mouse-sweep: script duration 87ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 68.5 MB
subgraph-mouse-sweep: DOM nodes -293
subgraph-mouse-sweep: event listeners -220
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 12ms
subgraph-transition-enter: style recalc duration 25ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 736ms
subgraph-transition-enter: script duration 23ms
subgraph-transition-enter: TBT 93ms
subgraph-transition-enter: heap used 78.4 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 38ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 4646ms
viewport-pan-sweep: script duration 2094ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 81.5 MB
viewport-pan-sweep: DOM nodes -267
viewport-pan-sweep: event listeners -155
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 14254ms
vue-large-graph-idle: script duration 216ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 177.4 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7474
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 15ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 146
vue-large-graph-pan: task duration 17058ms
vue-large-graph-pan: script duration 723ms
vue-large-graph-pan: TBT 50ms
vue-large-graph-pan: heap used 170.5 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7473
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 21ms
vue-node-resize-workload: style recalc duration 60ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5173ms
vue-node-resize-workload: script duration 87ms
vue-node-resize-workload: TBT 229ms
vue-node-resize-workload: heap used 167.7 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7472
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 7210ms
vue-zoom-out-idle: script duration 109ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 176.5 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 5
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 16ms
workflow-execution: layout count 3
workflow-execution: style recalc count 12
workflow-execution: task duration 73ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.4 MB
workflow-execution: DOM nodes 136
workflow-execution: event listeners 42
Raw data
{
  "timestamp": "2026-09-17T02:45:07.845Z",
  "gitSha": "e555ad6cc7627edae64d8332095f4ae50e53404a",
  "branch": "backport/cloud-1.54-subgraph-definition-read-cache",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2057.608000000016,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.7250000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 453.8140000000001,
      "heapDeltaBytes": 5385484,
      "heapUsedBytes": 75423716,
      "domNodes": -278,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 8.327,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2013.351,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.1069999999999975,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 400.13899999999995,
      "heapDeltaBytes": -6727220,
      "heapUsedBytes": 62512176,
      "domNodes": -278,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 7.705,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1788.9279999999985,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 34.812999999999995,
      "layouts": 14,
      "layoutDurationMs": 4.146000000000001,
      "taskDurationMs": 756.618,
      "heapDeltaBytes": 3107980,
      "heapUsedBytes": 73170052,
      "domNodes": -277,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 124.91000000000001,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1736.2449999999967,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 30.031000000000002,
      "layouts": 14,
      "layoutDurationMs": 3.7420000000000004,
      "taskDurationMs": 714.2669999999999,
      "heapDeltaBytes": 8085656,
      "heapUsedBytes": 79059936,
      "domNodes": -280,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 119.181,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1671.0489999999822,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 13.695,
      "layouts": 6,
      "layoutDurationMs": 0.9049999999999998,
      "taskDurationMs": 297.825,
      "heapDeltaBytes": 5099492,
      "heapUsedBytes": 75531820,
      "domNodes": 78,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 10.226000000000003,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1672.0379999999295,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 13.533999999999999,
      "layouts": 6,
      "layoutDurationMs": 0.9360000000000002,
      "taskDurationMs": 290.974,
      "heapDeltaBytes": 4976712,
      "heapUsedBytes": 75929724,
      "domNodes": 78,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 9.766,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 534.3610000000467,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.750000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 372.592,
      "heapDeltaBytes": -7804920,
      "heapUsedBytes": 62788012,
      "domNodes": 18,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 129.39899999999997,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 565.8359999999902,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 6.994999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 377.291,
      "heapDeltaBytes": 18126144,
      "heapUsedBytes": 88316996,
      "domNodes": 20,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 128.52200000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2023.7640000000283,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.292999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 501.595,
      "heapDeltaBytes": -14663136,
      "heapUsedBytes": 87584928,
      "domNodes": -264,
      "jsHeapTotalBytes": -1638400,
      "scriptDurationMs": 30.95799999999999,
      "eventListeners": -140,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2028.7829999999758,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 4.881,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 482.82500000000005,
      "heapDeltaBytes": -13854176,
      "heapUsedBytes": 88414668,
      "domNodes": -265,
      "jsHeapTotalBytes": -851968,
      "scriptDurationMs": 29.009999999999994,
      "eventListeners": -140,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2137.5320000000215,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 10.071000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1247.2069999999999,
      "heapDeltaBytes": 22619340,
      "heapUsedBytes": 88972572,
      "domNodes": -269,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 606.259,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2147.652999999991,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 10.011,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1275.471,
      "heapDeltaBytes": 18159152,
      "heapUsedBytes": 84495708,
      "domNodes": 6,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 620.965,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3171.5980000000172,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 11.848,
      "layouts": 60,
      "layoutDurationMs": 11.334999999999999,
      "taskDurationMs": 1366.785,
      "heapDeltaBytes": 8203572,
      "heapUsedBytes": 75895488,
      "domNodes": -273,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 611.67,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3180.853999999954,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 11.208999999999996,
      "layouts": 60,
      "layoutDurationMs": 11.921,
      "taskDurationMs": 1423.0220000000002,
      "heapDeltaBytes": 8334164,
      "heapUsedBytes": 75842016,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 633.768,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2258.76999999997,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.2700000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1495.2109999999998,
      "heapDeltaBytes": 17762792,
      "heapUsedBytes": 85608444,
      "domNodes": 2,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 740.198,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2237.2040000000197,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 6.921,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1563.5280000000002,
      "heapDeltaBytes": 18360884,
      "heapUsedBytes": 85681600,
      "domNodes": 6,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 761.459,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2031.169000000034,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 4.399,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 509.478,
      "heapDeltaBytes": 9903240,
      "heapUsedBytes": 87023804,
      "domNodes": -269,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 30.974999999999994,
      "eventListeners": -140,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2024.314000000004,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 3.5829999999999993,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 472.302,
      "heapDeltaBytes": 10871084,
      "heapUsedBytes": 87830928,
      "domNodes": -270,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 29.222000000000005,
      "eventListeners": -170,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 496.7690000000289,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 8.902999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 318.337,
      "heapDeltaBytes": 14680200,
      "heapUsedBytes": 86320860,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 109.837,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 547.06699999997,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.285,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 351.474,
      "heapDeltaBytes": 15182096,
      "heapUsedBytes": 87956452,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 116.976,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2035.6160000000045,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.367000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 426.45199999999994,
      "heapDeltaBytes": -9180824,
      "heapUsedBytes": 63394856,
      "domNodes": -294,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 8.903,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.0650000000214,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.433000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 416.70000000000005,
      "heapDeltaBytes": -9181820,
      "heapUsedBytes": 63664916,
      "domNodes": -294,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.915,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1704.0269999999964,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 30.225,
      "layouts": 18,
      "layoutDurationMs": 4.527000000000001,
      "taskDurationMs": 662.43,
      "heapDeltaBytes": 693128,
      "heapUsedBytes": 73535028,
      "domNodes": -291,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 85.70899999999999,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1760.3649999999789,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 31.958000000000002,
      "layouts": 18,
      "layoutDurationMs": 4.612,
      "taskDurationMs": 693.354,
      "heapDeltaBytes": -2271404,
      "heapUsedBytes": 70016884,
      "domNodes": -295,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 88.06299999999999,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 934.030000000007,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 25.253999999999998,
      "layouts": 15,
      "layoutDurationMs": 11.632,
      "taskDurationMs": 735.6949999999999,
      "heapDeltaBytes": -7209388,
      "heapUsedBytes": 82232836,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 22.50200000000001,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 93,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8273.851000000035,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 36.349000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4614.735,
      "heapDeltaBytes": 5254868,
      "heapUsedBytes": 81329596,
      "domNodes": -266,
      "jsHeapTotalBytes": 647168,
      "scriptDurationMs": 2095.286,
      "eventListeners": -156,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8278.515999999967,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 39.262,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4678.106,
      "heapDeltaBytes": 13629536,
      "heapUsedBytes": 89561776,
      "domNodes": -268,
      "jsHeapTotalBytes": 1695744,
      "scriptDurationMs": 2092.2810000000004,
      "eventListeners": -154,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14707.684000000028,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14227.841999999999,
      "heapDeltaBytes": -18927688,
      "heapUsedBytes": 191722248,
      "domNodes": -6548,
      "jsHeapTotalBytes": 3420160,
      "scriptDurationMs": 209.35399999999998,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333237,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14786.497000000054,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14281.134,
      "heapDeltaBytes": -10349284,
      "heapUsedBytes": 180268872,
      "domNodes": -6548,
      "jsHeapTotalBytes": 2400256,
      "scriptDurationMs": 223.559,
      "eventListeners": -7477,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17328.88499999996,
      "styleRecalcs": 145,
      "styleRecalcDurationMs": 14.509999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16985.143,
      "heapDeltaBytes": -14174084,
      "heapUsedBytes": 190839836,
      "domNodes": -6548,
      "jsHeapTotalBytes": -5709824,
      "scriptDurationMs": 719.7679999999999,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 73,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17458.05299999995,
      "styleRecalcs": 146,
      "styleRecalcDurationMs": 15.061999999999992,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17131.654000000002,
      "heapDeltaBytes": -50230828,
      "heapUsedBytes": 166683496,
      "domNodes": -6548,
      "jsHeapTotalBytes": 1826816,
      "scriptDurationMs": 725.309,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 27,
      "frameDurationMs": 17.773333333333238,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5230.837999999949,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 60.785000000000004,
      "layouts": 20,
      "layoutDurationMs": 20.843,
      "taskDurationMs": 5103.212,
      "heapDeltaBytes": -34269296,
      "heapUsedBytes": 169963208,
      "domNodes": -6548,
      "jsHeapTotalBytes": 14020608,
      "scriptDurationMs": 84.60900000000001,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 226,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5345.901000000026,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 59.04200000000001,
      "layouts": 20,
      "layoutDurationMs": 21.090999999999998,
      "taskDurationMs": 5243.692,
      "heapDeltaBytes": -23426864,
      "heapUsedBytes": 181702976,
      "domNodes": -6547,
      "jsHeapTotalBytes": 7675904,
      "scriptDurationMs": 90.16799999999999,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 231,
      "frameDurationMs": 17.223333333333297,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7309.864000000005,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7146.483,
      "heapDeltaBytes": 27025552,
      "heapUsedBytes": 194128656,
      "domNodes": 0,
      "jsHeapTotalBytes": -14680064,
      "scriptDurationMs": 107.317,
      "eventListeners": 18,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7475.506999999993,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7273.112000000001,
      "heapDeltaBytes": 1230724,
      "heapUsedBytes": 176038816,
      "domNodes": 0,
      "jsHeapTotalBytes": -7077888,
      "scriptDurationMs": 110.979,
      "eventListeners": -8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 458.217999999988,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 21.605,
      "layouts": 3,
      "layoutDurationMs": 1.341,
      "taskDurationMs": 95.506,
      "heapDeltaBytes": 4988316,
      "heapUsedBytes": 73429584,
      "domNodes": 148,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 7.924,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 75.83299999998871,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 10.685000000000002,
      "layouts": 2,
      "layoutDurationMs": 1.0430000000000001,
      "taskDurationMs": 50.67800000000001,
      "heapDeltaBytes": 2992732,
      "heapUsedBytes": 72070336,
      "domNodes": 124,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 3.596,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 49881 74427 67.0% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.4% 1159
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 8.2% 303
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 78.6% 261
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.8% 251
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 17, 2026
@codecov

codecov Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../extensions/agent/crdt/agentSubgraphDefinitions.ts 95.00% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #17889   +/-   ##
=============================================
  Coverage              ?   82.98%           
=============================================
  Files                 ?     2052           
  Lines                 ?   119748           
  Branches              ?    32805           
=============================================
  Hits                  ?    99375           
  Misses                ?    20193           
  Partials              ?      180           
Flag Coverage Δ
e2e 67.05% <ø> (?)
unit 77.56% <96.29%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ench/extensions/agent/crdt/useAgentCrdtFollower.ts 97.35% <100.00%> (ø)
.../extensions/agent/crdt/agentSubgraphDefinitions.ts 97.14% <95.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne
christian-byrne merged commit 4270d4e into cloud/1.54 Sep 17, 2026
94 checks passed
@christian-byrne
christian-byrne deleted the backport/cloud-1.54-subgraph-definition-read-cache branch September 17, 2026 03:23
DrJKL added a commit that referenced this pull request Sep 17, 2026
…) (#17913)

Backports [Frontend
17202](#17202) to
`cloud/1.54` after dependency [Frontend
17889](#17889).
Patch-identical; cloud pins unchanged.

<details><summary>Full context for agent readers</summary>

## Summary

- Preserves promoted widget edits on existing subgraph hosts.
- Resolves Agent-created connections by declared promoted-slot identity.
- Carries the source definition, follower, host-slot, graph-mutation,
and store regressions unchanged.

## Linear

-
[FE-2033](https://linear.app/comfyorg/issue/FE-2033/agent-editing-subgraph-human-tech-review-needed)

## Verification

- Exact target base: `4270d4e81db31768625a04be1b259fc1c552f7b6`.
- Source commit: `d0dc978a1a4cf670b0a992d8c57381bd56fa9dcf`.
- Backport head: `04468979520e49ff2331ee6801c5a6b44ffd659c`.
- Stable source/backport patch ID:
`73b75978da72d485df7cb054bd44045cecc79ccf`.
- Six focused graph, store, definition, follower, host-slot, and ECS
suites: 113 passed.
- Full Agent CRDT suite: 36 files, 532 tests passed.
- ESLint, type-aware Oxlint, Oxfmt, Knip, typecheck, browser typecheck,
diff check, and production cloud build passed.
- Production-preview browser acceptance on isolated port 6200: promoted
host materialization, declared slot connection, promoted widget edit,
Agent flag-off persistence, and flag-on open/close pressed state all
passed (3 Playwright tests).
- Frontend remains `1.54.10`; `@comfyorg/comfy-multi-player` remains
`0.2.1`; no package or lockfile changed.

Justification: DrJKL approved exact source head
`8d0a074428264406fae7189053a5806b95dcdf42`; this release PR carries the
identical stable patch plus target-specific unit, static,
production-build, and browser acceptance evidence.

</details>

Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Alexander Brown <drjkl@comfy.org>
Co-authored-by: Amp <amp@ampcode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants