Repository navigation
Fix subgraph definition ID scan edge cases - #18453
Conversation
🎭 Playwright: ✅ 2092 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 66db80aa930b84e574931182f04a9924eb943ba8
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.96 MB gzip 🔴 +270 kBDetailsSummary
Category Glance App Entry Points — 3.87 kB (baseline 3.73 kB) • 🔴 +138 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.44 MB (baseline 1.43 MB) • 🔴 +14 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 124 kB) • 🔴 +8.02 kBTop-level views, pages, and routed surfaces
Status: 17 added / 16 removed / 1 unchanged Panels & Settings — 639 kB (baseline 621 kB) • 🔴 +17.6 kBConfiguration panels, inspectors, and settings screens
Status: 28 added / 27 removed User & Accounts — 37.9 kB (baseline 27.8 kB) • 🔴 +10.1 kBAuthentication, profile, and account management bundles
Status: 9 added / 9 removed / 2 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • 🔴 +740 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 123 kB (baseline 117 kB) • 🔴 +6.31 kBReusable component library chunks
Status: 16 added / 15 removed Data & Services — 3.91 MB (baseline 3.6 MB) • 🔴 +314 kBStores, services, APIs, and repositories
Status: 16 added / 16 removed Utilities & Hooks — 577 kB (baseline 559 kB) • 🔴 +18.8 kBHelpers, composables, and utility bundles
Status: 31 added / 29 removed / 7 unchanged Vendor & Third-Party — 17.4 MB (baseline 18.1 MB) • 🟢 -692 kBExternal libraries and shared vendor chunks
Status: 11 added / 11 removed / 7 unchanged Other — 17.8 MB (baseline 16.4 MB) • 🔴 +1.42 MBBundles that do not match a named category
Status: 179 added / 173 removed / 123 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-22T19:47:19.026Z",
"gitSha": "e551743cd4d336a7e9c647006cbd89ebbd3a601b",
"branch": "fix/agent-definition-id-scan",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.7710000000343,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.581,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.568,
"heapDeltaBytes": 4627296,
"heapUsedBytes": 66913940,
"domNodes": -261,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 12.128999999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2006.8299999999226,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.738000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.217,
"heapDeltaBytes": 8141476,
"heapUsedBytes": 75667268,
"domNodes": -260,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 10.668000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1735.9279999999444,
"styleRecalcs": 45,
"styleRecalcDurationMs": 13.937000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 852.7639999999999,
"heapDeltaBytes": 9375812,
"heapUsedBytes": 76869444,
"domNodes": -262,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 170.677,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1775.3940000000057,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.155,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 867.781,
"heapDeltaBytes": 10810004,
"heapUsedBytes": 78124608,
"domNodes": -261,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 168.78199999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.2389999999978,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.253,
"layouts": 6,
"layoutDurationMs": 1.0920000000000003,
"taskDurationMs": 362.05600000000004,
"heapDeltaBytes": 3049484,
"heapUsedBytes": 70592120,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.505000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.0360000000219,
"styleRecalcs": 30,
"styleRecalcDurationMs": 17,
"layouts": 6,
"layoutDurationMs": 1.349,
"taskDurationMs": 296.631,
"heapDeltaBytes": 3153808,
"heapUsedBytes": 70664492,
"domNodes": 78,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 14.510999999999996,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 710.9239999999772,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.780000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.423,
"heapDeltaBytes": 18953920,
"heapUsedBytes": 86254824,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 174.073,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 652.657999999974,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.315999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.2689999999999,
"heapDeltaBytes": 18915312,
"heapUsedBytes": 86371064,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 165.22099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1226.3009999999213,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 896.1080000000001,
"heapDeltaBytes": 38970992,
"heapUsedBytes": 103898692,
"domNodes": -295,
"jsHeapTotalBytes": 19820544,
"scriptDurationMs": 75.40200000000002,
"eventListeners": -195,
"totalBlockingTimeMs": 598,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1204.7209999999495,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 892.6529999999999,
"heapDeltaBytes": 12197892,
"heapUsedBytes": 82997744,
"domNodes": 0,
"jsHeapTotalBytes": 19820544,
"scriptDurationMs": 71.37999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 594,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 875.5380000000059,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.9399999999997,
"heapDeltaBytes": 14831656,
"heapUsedBytes": 90090300,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 179.07299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 245,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 842.8800000000365,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.1939999999999,
"heapDeltaBytes": 14458304,
"heapUsedBytes": 89665644,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 170.40499999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 233,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10711.851000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9759.229,
"heapDeltaBytes": 12204188,
"heapUsedBytes": 94520616,
"domNodes": -16,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 8290.01,
"eventListeners": 0,
"totalBlockingTimeMs": 1484,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10586.21699999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9593.677999999998,
"heapDeltaBytes": -10160296,
"heapUsedBytes": 72228156,
"domNodes": -16,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 8112.399,
"eventListeners": 0,
"totalBlockingTimeMs": 1299,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10870.733999999971,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10010.973,
"heapDeltaBytes": 10471484,
"heapUsedBytes": 86098000,
"domNodes": -6,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 8256.070999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 1526,
"frameDurationMs": 18.889999999999965,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11109.203999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10232.026000000002,
"heapDeltaBytes": -11259556,
"heapUsedBytes": 71129168,
"domNodes": -18,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 8487.774,
"eventListeners": 0,
"totalBlockingTimeMs": 1570,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "large-graph-idle",
"durationMs": 2032.2390000000041,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.373,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 623.06,
"heapDeltaBytes": -3046648,
"heapUsedBytes": 83854988,
"domNodes": -245,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 40.481,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2041.9180000000097,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.5340000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 671.491,
"heapDeltaBytes": -3413608,
"heapUsedBytes": 83137604,
"domNodes": -241,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 41.80700000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2368.5109999998986,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.645,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1703.0310000000002,
"heapDeltaBytes": 20232644,
"heapUsedBytes": 84260000,
"domNodes": -245,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 868.477,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2255.192999999963,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.659000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1563.815,
"heapDeltaBytes": -8363508,
"heapUsedBytes": 79833932,
"domNodes": -255,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 866.015,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3715.076999999951,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.651,
"layouts": 60,
"layoutDurationMs": 13.905,
"taskDurationMs": 1855.084,
"heapDeltaBytes": -16221104,
"heapUsedBytes": 73354004,
"domNodes": -258,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 815.601,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3742.234999999937,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.624999999999998,
"layouts": 60,
"layoutDurationMs": 13.790000000000001,
"taskDurationMs": 1858.893,
"heapDeltaBytes": -16028980,
"heapUsedBytes": 73400560,
"domNodes": -259,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 846.475,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3165.630999999962,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.75,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1988.927,
"heapDeltaBytes": 29998936,
"heapUsedBytes": 96011464,
"domNodes": 6,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 1013.1700000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3164.779000000067,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.380999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2031.6669999999997,
"heapDeltaBytes": 25641116,
"heapUsedBytes": 91681336,
"domNodes": 4,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1033.318,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2010.3599999999915,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.824000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 579.6199999999999,
"heapDeltaBytes": 20092276,
"heapUsedBytes": 84688372,
"domNodes": -251,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.04,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2015.5489999999645,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.850999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 586.315,
"heapDeltaBytes": -5054132,
"heapUsedBytes": 84250080,
"domNodes": -247,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 33.888,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 592.2689999999875,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.552,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.1389999999999,
"heapDeltaBytes": 13660800,
"heapUsedBytes": 83547864,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 145.309,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 607.5070000000551,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.461999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 421.17400000000004,
"heapDeltaBytes": 13718312,
"heapUsedBytes": 83667308,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 150.588,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2023.1039999999894,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.594000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.4069999999999,
"heapDeltaBytes": 8385468,
"heapUsedBytes": 78235804,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.441,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.1100000000215,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.712000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.90999999999997,
"heapDeltaBytes": -4740924,
"heapUsedBytes": 65248480,
"domNodes": -276,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.21,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1743.6420000000226,
"styleRecalcs": 45,
"styleRecalcDurationMs": 17.229000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 792.3130000000001,
"heapDeltaBytes": 5053276,
"heapUsedBytes": 68939468,
"domNodes": -274,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 111.258,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1705.5200000000923,
"styleRecalcs": 45,
"styleRecalcDurationMs": 16.447000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 792.2230000000001,
"heapDeltaBytes": 7878716,
"heapUsedBytes": 77733016,
"domNodes": -278,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 113.373,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.6300000000156,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.052999999999997,
"layouts": 5,
"layoutDurationMs": 14.039,
"taskDurationMs": 984.5210000000002,
"heapDeltaBytes": 20345244,
"heapUsedBytes": 104008924,
"domNodes": 13667,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 32.12200000000001,
"eventListeners": 2383,
"totalBlockingTimeMs": 153,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8643.618999999944,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.211999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6190.826999999999,
"heapDeltaBytes": -10269136,
"heapUsedBytes": 77027668,
"domNodes": -242,
"jsHeapTotalBytes": 483328,
"scriptDurationMs": 2910.084,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8659.160999999927,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.439,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6103.375,
"heapDeltaBytes": 16740020,
"heapUsedBytes": 80481804,
"domNodes": -242,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 2894.0759999999996,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17554.318999999963,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17161.909,
"heapDeltaBytes": -35407656,
"heapUsedBytes": 190154296,
"domNodes": -8061,
"jsHeapTotalBytes": -14426112,
"scriptDurationMs": 279.381,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17268.23400000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16769.889,
"heapDeltaBytes": -16398000,
"heapUsedBytes": 197596700,
"domNodes": -8061,
"jsHeapTotalBytes": -10498048,
"scriptDurationMs": 274.65500000000003,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20609.79300000008,
"styleRecalcs": 151,
"styleRecalcDurationMs": 17.654000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20354.878,
"heapDeltaBytes": -52609348,
"heapUsedBytes": 181665580,
"domNodes": -8061,
"jsHeapTotalBytes": -11284480,
"scriptDurationMs": 880.979,
"eventListeners": -14928,
"totalBlockingTimeMs": 51,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21149.838000000047,
"styleRecalcs": 159,
"styleRecalcDurationMs": 18.79900000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20889.944,
"heapDeltaBytes": -60492808,
"heapUsedBytes": 180553528,
"domNodes": -8061,
"jsHeapTotalBytes": -21172224,
"scriptDurationMs": 915.1420000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 8,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6181.494000000043,
"styleRecalcs": 20,
"styleRecalcDurationMs": 85.20299999999997,
"layouts": 20,
"layoutDurationMs": 26.022000000000002,
"taskDurationMs": 6112.869000000001,
"heapDeltaBytes": -65924660,
"heapUsedBytes": 175206508,
"domNodes": -8061,
"jsHeapTotalBytes": 10022912,
"scriptDurationMs": 110.18900000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 524,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6234.552000000122,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.85000000000001,
"layouts": 20,
"layoutDurationMs": 23.91700000000001,
"taskDurationMs": 6162.421,
"heapDeltaBytes": -65616320,
"heapUsedBytes": 174553388,
"domNodes": -8061,
"jsHeapTotalBytes": 10104832,
"scriptDurationMs": 110.424,
"eventListeners": -14928,
"totalBlockingTimeMs": 406,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6428.089999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6266.207999999999,
"heapDeltaBytes": 18876008,
"heapUsedBytes": 187316580,
"domNodes": 0,
"jsHeapTotalBytes": -18612224,
"scriptDurationMs": 109.01399999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8698.057999999946,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8435.436,
"heapDeltaBytes": -15366664,
"heapUsedBytes": 168951332,
"domNodes": 0,
"jsHeapTotalBytes": -13893632,
"scriptDurationMs": 153.72700000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 461.6119999999455,
"styleRecalcs": 21,
"styleRecalcDurationMs": 23.904999999999994,
"layouts": 3,
"layoutDurationMs": 1.461,
"taskDurationMs": 127.38500000000002,
"heapDeltaBytes": 5101724,
"heapUsedBytes": 70480660,
"domNodes": 151,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.956999999999999,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 451.2290000000121,
"styleRecalcs": 12,
"styleRecalcDurationMs": 23.988999999999997,
"layouts": 4,
"layoutDurationMs": 2.118,
"taskDurationMs": 122.64599999999997,
"heapDeltaBytes": 4773212,
"heapUsedBytes": 66537356,
"domNodes": 117,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 10.543,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe change limits field reads to own, safe properties and replaces recursive subgraph definition scanning with iterative traversal. Tests cover shared-text IDs, inherited IDs, traversal order, and 12,000 nested definitions. ChangesSubgraph definition scanning
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The changed scanner behavior is supported by the inspected contracts and tests; no merge-blocking risk is established. Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The PR title uses the bug-fix signal “Fix.” The PR changes
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: ready to approve
The implementation is correct at b85749616595edac8d33a5840ad213264c16f000. The focused 30-test suite, file-scoped ESLint, and formatting check all pass. I found two minor description issues, neither of which blocks approval.
Findings without an anchorable line
- [P3] PR summary: "agree with the full projector" is broader than this change. The ID reader intentionally does not validate definition bodies, while the full reader applies
isSafeDefinition. Please narrow this to the projector's ID normalization and own-key handling. - [P3] Review Focus: I could not locate the stated "active desktop host-safety restriction." Please link that restriction or replace the sentence with the local verification result so reviewers can tell what prevented those checks.
Existing findings confirmed or contested
- I contest CodeRabbit's request for a browser E2E regression. These are deterministic CRDT projection semantics. The tests exercise the public reader with real
Y.Doc,Y.Map,Y.Text, and the real mint path. Browser wiring adds no relevant observable boundary, and the repository guidance prefers the lowest test level that proves the behavior.
Coverage
Standard-depth correctness, maintainability, idiomaticity, tests, and documentation lanes reviewed both changed files without sampling. The specialist reviews found no production, type-safety, maintainability, or test-quality defects. No Playwright lane was applicable because no browser test changed and the behavior is fully observable at unit level.
Checks run at this head:
vitest run src/workbench/extensions/agent/crdt/agentSubgraphDefinitions.test.ts: 30 passed- ESLint on both changed files: passed
oxfmt --checkon both changed files: passed
CI still had several Playwright jobs in progress when I inspected this head.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18453 +/- ##
==========================================
+ Coverage 83.36% 84.37% +1.00%
==========================================
Files 2984 2282 -702
Lines 147245 130039 -17206
Branches 38050 35128 -2922
==========================================
- Hits 122757 109723 -13034
+ Misses 23206 20020 -3186
+ Partials 1282 296 -986
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 714 files with indirect coverage changes 🚀 New features to boost your workflow:
|
DrJKL
left a comment
There was a problem hiding this comment.
Approved. I found no blocking issue at b85749616595edac8d33a5840ad213264c16f000, and all check runs are complete without failures.
Non-blocking nits:
- [P3] PR summary: "agree with the full projector" is broader than the change because the ID reader intentionally skips body validation. Narrowing this to ID normalization and own-key handling would be more precise.
- [P3] Review Focus: the "active desktop host-safety restriction" is not linked or otherwise locatable. Linking it or stating the local verification result would make the verification note actionable.
I continue to disagree with the automated request for a browser E2E regression. The real Yjs unit tests exercise the public reader at the lowest level that proves these deterministic projection semantics.
Verification at this head: focused Vitest 30/30, file-scoped ESLint, and formatting passed locally; GitHub reports 87 successful and 19 skipped check runs, with none pending or failed.
## Summary Backports six merged `main` Agent fixes to `cloud/1.54` and repairs the `agentCanvasLagsToolCallCompletion` e2e spec that #18586 landed with, which fails `typecheck:browser` on the current branch tip. ## Changes - **What**: `cherry-pick -x` of #17568, #17628, #16491, #18453, #17767 and #18603, in `main` merge order. The spec fix uses `entryButton` and the "Worked for" summary instead of the labels #18622 removed, and adds `HostDoc.graph()` to the conversation host-doc fixture. #18391 itself is already on the line via #18586 and is unchanged here. - **Excluded**: #18066 (Christian's request), #16908 (refactor), #18375 (needs its `src/lib/litegraph/` half). ## Review Focus - #18603 forwards two new onboarding telemetry events for every user, not only Agent users. - `AgentPanelRoot.vue` changes come from #16491 and #17767 on top of #18391's merged code; `useAgentCrdtFollower.ts` is identical to the tip. - Merging the tip resolved two conflicts: the spec (this copy) and `AgentPanelRoot.test.ts` (the tip's #18391 test plus these picks). - Second batch (#16856, #18204, #18229, #17327, #18251, #16985, #18224) follows on this tip. Linear: [PM-1656](https://linear.app/comfyorg/issue/PM-1656) ## Screenshots (if applicable) No new visuals; #17568 and #17767 were reviewed on `main`. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Maanil Verma <vermaMaanil97@gmail.com> Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: Alexander Brown <drjkl@comfy.org>
## Summary Make the lightweight subgraph-definition ID scan agree with the full projector's ID normalization and own-key handling while remaining safe on deeply nested documents. ## Changes - **What**: Normalize shared-type IDs, ignore inherited record fields, replace recursive traversal with an explicit stack, and add discriminating regressions for all three boundaries. ## Review Focus The iterative traversal preserves depth-first definition order by pushing children in reverse. The 12,000-level regression distinguishes it from the previous recursive implementation. At exact head `b85749616595edac8d33a5840ad213264c16f000`, human review recorded 30 focused tests passing plus file-scoped ESLint and formatting checks passing; hosted CI is also green. <details><summary>Full context for agent readers</summary> This ports the still-valid high, medium, and low findings left unresolved after merged PR 16971. A `Y.Text` ID now passes through the same `plain()` projection used by the full reader. Plain records use own-key lookup, matching the projector's unsafe-key boundary. No production API or schema changes. Original findings: - #16971 (comment) - #16971 (comment) - #16971 (comment) </details> (cherry picked from commit 0ab0c96)
## Summary Ports to `core/1.54` every merged `main` Agent fix that `cloud/1.54` carries and core does not (the Agent UI catch-up from #18622, the cloud-only CRDT and workflow fixes, and the round-2 fixes), so both release lines are symmetric ahead of the local-agent rollout. ## Changes - **What**: `cherry-pick -x`, in three groups: - Agent UI, as in #18622: #17339, #17908, #17420, #18348, #18043, #17621 (without its two `src/lib/litegraph/` files; a 5 px HUD offset in `SideToolbar.vue` compensates), #17471, #17690. - Cloud-only fixes: #18063, #18073, #18064, #18033, #18289, #18604, #18616, #18376. - Round 2: #17568, #17628, #16491, #18453, #17767, #18431 (from #18571), #18603. - **Already on `core/1.54`**: #17439 (#18161), #17912 (#18186), #18391 (#18595). - **Excluded**: #17730 (core lacks its three files), #18421 (dead code on core builds), #16917 (conflicts with later core changes), #18066 (Christian's request), #18375 and #18251 (need their litegraph hunks). ## Review Focus - On this line the Agent panel registers only in cloud builds (`src/extensions/core/index.ts:41-44`); the shared chrome from #17621 and #17471 and the host telemetry from #18376 and #18603 ship in every build. - `HostTelemetrySink.ts` and its test equal `main`'s files (#18376, then #18603 on top). - #18064: `agentConversationHostDoc.test.ts` keeps this line's file; #18063's new test uses `main`'s version (multi-player 0.3.x stamps). - Supersedes #18571 and the closed #18637. Linear: [PM-1657](https://linear.app/comfyorg/issue/PM-1657), [PM-1656](https://linear.app/comfyorg/issue/PM-1656) ## Screenshots (if applicable) Visual changes are the ones reviewed on `main` and carried to cloud in #18622. --------- Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: ryan-di <ryan.weihao.di@gmail.com> Co-authored-by: jaeone lee <89377375+jaeone94@users.noreply.github.com> Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Comfy Org PR Bot <snomiao+comfy-pr@gmail.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Hunter <huntcsg@users.noreply.github.com> Co-authored-by: Maanil Verma <vermaMaanil97@gmail.com>
Summary
Make the lightweight subgraph-definition ID scan agree with the full projector's ID normalization and own-key handling while remaining safe on deeply nested documents.
Changes
Review Focus
The iterative traversal preserves depth-first definition order by pushing children in reverse. The 12,000-level regression distinguishes it from the previous recursive implementation. At exact head
b85749616595edac8d33a5840ad213264c16f000, human review recorded 30 focused tests passing plus file-scoped ESLint and formatting checks passing; hosted CI is also green.Full context for agent readers
This ports the still-valid high, medium, and low findings left unresolved after merged PR 16971. A
Y.TextID now passes through the sameplain()projection used by the full reader. Plain records use own-key lookup, matching the projector's unsafe-key boundary. No production API or schema changes.Original findings: