Repository navigation
[backport core/1.54] perf(agent): avoid redundant subgraph definition reads - #17871
Conversation
Avoids full subgraph-definition deep copies on unrelated CRDT frames. Registered definitions now take an ID-only fast path. <details><summary>Full context for agent readers</summary> ## Summary `reconcileLiveGraph` first projects top-level and nested definition IDs. It materializes full definitions only when at least one ID is absent from the live root graph; ordinary node/widget frames still reconcile adapters with an empty definition list. Addresses item 3 of #16932 and the performance finding in #16922. ## Review Focus - ID projection traverses nested definition metadata without reading interior node/link/widget bodies. - Missing definitions retain the existing full-reader and registration path. - A regression proves a widget-style applied frame does not invoke the full reader once definitions are registered. ## Evidence - `NODE_OPTIONS="--no-experimental-webstorage" pnpm exec vitest run src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts src/workbench/extensions/agent/crdt/agentSubgraphDefinitions.test.ts` — 2 files, 62 tests passed - `pnpm exec eslint src/workbench/extensions/agent/crdt/agentSubgraphDefinitions.ts src/workbench/extensions/agent/crdt/agentSubgraphDefinitions.test.ts src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts` — passed - `pnpm typecheck` — passed - `git diff --check` — passed - Commit hooks: oxfmt, type-aware oxlint, ESLint, typecheck — passed - Pre-push hook: knip — passed </details> <!-- authored-by:agent lane-ev122-3-1245 --> (cherry picked from commit eca7d56)
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1920 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-16T22:36:37.066Z",
"gitSha": "55457386812c8e46fcf7f37b9ccad86b231d5d49",
"branch": "christian-byrne/backport-16971-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2033.5640000000126,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.649,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.757,
"heapDeltaBytes": 6629116,
"heapUsedBytes": 76643812,
"domNodes": -279,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.749999999999998,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2037.8320000000372,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.127,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 564.542,
"heapDeltaBytes": -12611204,
"heapUsedBytes": 57291732,
"domNodes": -275,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.628000000000002,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2020.7520000000159,
"styleRecalcs": 81,
"styleRecalcDurationMs": 45.348,
"layouts": 14,
"layoutDurationMs": 4.699999999999999,
"taskDurationMs": 1015.611,
"heapDeltaBytes": 11080108,
"heapUsedBytes": 81733176,
"domNodes": -278,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 177.103,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1923.3969999999658,
"styleRecalcs": 77,
"styleRecalcDurationMs": 41.126,
"layouts": 14,
"layoutDurationMs": 4.696,
"taskDurationMs": 908.9929999999999,
"heapDeltaBytes": 824684,
"heapUsedBytes": 70903704,
"domNodes": -279,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 165.146,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1755.865999999969,
"styleRecalcs": 33,
"styleRecalcDurationMs": 24.086999999999996,
"layouts": 6,
"layoutDurationMs": 1.1879999999999997,
"taskDurationMs": 364.9789999999999,
"heapDeltaBytes": 4652048,
"heapUsedBytes": 75284812,
"domNodes": 78,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 9.963,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.6539999999968,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.958,
"layouts": 6,
"layoutDurationMs": 1.092,
"taskDurationMs": 404.34400000000005,
"heapDeltaBytes": 4753128,
"heapUsedBytes": 74833232,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 14.133999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 649.8339999999985,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.024999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.677,
"heapDeltaBytes": -8146032,
"heapUsedBytes": 62768548,
"domNodes": 22,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 160.053,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 709.0130000000272,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.362,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.912,
"heapDeltaBytes": -7568408,
"heapUsedBytes": 63045548,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 171.262,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2056.5670000000296,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.161,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 600.985,
"heapDeltaBytes": 11441828,
"heapUsedBytes": 86997356,
"domNodes": -267,
"jsHeapTotalBytes": -888832,
"scriptDurationMs": 33.329,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2037.7579999999966,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.7690000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.4029999999999,
"heapDeltaBytes": 11448808,
"heapUsedBytes": 87684420,
"domNodes": -272,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 33.053,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2215.149999999994,
"styleRecalcs": 62,
"styleRecalcDurationMs": 7.699000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1593.077,
"heapDeltaBytes": 18601276,
"heapUsedBytes": 84574696,
"domNodes": -277,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 803.9699999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2240.4109999999946,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.748000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1679.5690000000002,
"heapDeltaBytes": 4265260,
"heapUsedBytes": 80758896,
"domNodes": -273,
"jsHeapTotalBytes": 122880,
"scriptDurationMs": 810.718,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3430.7169999999587,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.37,
"layouts": 60,
"layoutDurationMs": 11.595,
"taskDurationMs": 1625.098,
"heapDeltaBytes": 11748388,
"heapUsedBytes": 79672584,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 747.8290000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3513.9880000000403,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.498999999999997,
"layouts": 60,
"layoutDurationMs": 11.764000000000001,
"taskDurationMs": 1670.6399999999996,
"heapDeltaBytes": 8359200,
"heapUsedBytes": 75837860,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 748.464,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3019.8159999999916,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.047,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1888.5740000000003,
"heapDeltaBytes": 17884880,
"heapUsedBytes": 84951508,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 944.104,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3071.6840000000047,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.735000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1881.3329999999999,
"heapDeltaBytes": 18355824,
"heapUsedBytes": 85654148,
"domNodes": 0,
"jsHeapTotalBytes": 1990656,
"scriptDurationMs": 935.742,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2039.289999999994,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.1899999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.7749999999999,
"heapDeltaBytes": -16345868,
"heapUsedBytes": 88036620,
"domNodes": -271,
"jsHeapTotalBytes": -2162688,
"scriptDurationMs": 31.733999999999998,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 1997.632000000067,
"styleRecalcs": 1,
"styleRecalcDurationMs": 1.0159999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.253,
"heapDeltaBytes": 22215372,
"heapUsedBytes": 88763168,
"domNodes": -275,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.254000000000005,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.0539999999851,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.687,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.09299999999996,
"heapDeltaBytes": 14641908,
"heapUsedBytes": 86881168,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 139.60399999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.3100000000777,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.894999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.2169999999999,
"heapDeltaBytes": 14872828,
"heapUsedBytes": 87679952,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 140.43,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.8640000000405,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.648000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.694,
"heapDeltaBytes": 10968020,
"heapUsedBytes": 83612080,
"domNodes": -292,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.219999999999997,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2013.7760000000071,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.183,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.87000000000006,
"heapDeltaBytes": -10359440,
"heapUsedBytes": 62650196,
"domNodes": -295,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.810000000000002,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1755.8750000000032,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.244,
"layouts": 18,
"layoutDurationMs": 5.5009999999999994,
"taskDurationMs": 861.2040000000001,
"heapDeltaBytes": -12203416,
"heapUsedBytes": 60405432,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 111.17200000000001,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1717.2150000000101,
"styleRecalcs": 77,
"styleRecalcDurationMs": 36.42,
"layouts": 18,
"layoutDurationMs": 5.091,
"taskDurationMs": 834.267,
"heapDeltaBytes": -12262548,
"heapUsedBytes": 60682816,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 107.53999999999999,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.3950000000032,
"styleRecalcs": 20,
"styleRecalcDurationMs": 32.153,
"layouts": 16,
"layoutDurationMs": 15.974000000000002,
"taskDurationMs": 926.8019999999999,
"heapDeltaBytes": -7442960,
"heapUsedBytes": 84938468,
"domNodes": 13751,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 31.037000000000003,
"eventListeners": 2385,
"totalBlockingTimeMs": 147,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8319.904000000008,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.333000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5805.533,
"heapDeltaBytes": 10032040,
"heapUsedBytes": 85646996,
"domNodes": -269,
"jsHeapTotalBytes": -925696,
"scriptDurationMs": 2670.55,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8610.236999999983,
"styleRecalcs": 247,
"styleRecalcDurationMs": 36.528000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5922.211,
"heapDeltaBytes": -13245788,
"heapUsedBytes": 89120668,
"domNodes": -269,
"jsHeapTotalBytes": -102400,
"scriptDurationMs": 2698.3509999999997,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16801.29599999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16132.255000000001,
"heapDeltaBytes": -34034248,
"heapUsedBytes": 177016908,
"domNodes": -6548,
"jsHeapTotalBytes": 1253376,
"scriptDurationMs": 278.12600000000003,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17044.85799999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16639.528,
"heapDeltaBytes": -28993524,
"heapUsedBytes": 174767232,
"domNodes": -6577,
"jsHeapTotalBytes": -5943296,
"scriptDurationMs": 255.81599999999997,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20767.224,
"styleRecalcs": 177,
"styleRecalcDurationMs": 18.019999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20408.752999999997,
"heapDeltaBytes": -40221600,
"heapUsedBytes": 163471012,
"domNodes": -6548,
"jsHeapTotalBytes": 1052672,
"scriptDurationMs": 890.975,
"eventListeners": -7467,
"totalBlockingTimeMs": 36,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21445.412000000033,
"styleRecalcs": 169,
"styleRecalcDurationMs": 20.338999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21083.26,
"heapDeltaBytes": -11769232,
"heapUsedBytes": 190225272,
"domNodes": -6548,
"jsHeapTotalBytes": 4608000,
"scriptDurationMs": 1012.141,
"eventListeners": -7467,
"totalBlockingTimeMs": 207,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6199.0939999999455,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.76699999999998,
"layouts": 20,
"layoutDurationMs": 23.612999999999996,
"taskDurationMs": 6124.286000000001,
"heapDeltaBytes": -21522440,
"heapUsedBytes": 181482880,
"domNodes": -6548,
"jsHeapTotalBytes": 18075648,
"scriptDurationMs": 110.03800000000001,
"eventListeners": -7473,
"totalBlockingTimeMs": 467,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6325.174000000061,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.945,
"layouts": 20,
"layoutDurationMs": 24.415999999999993,
"taskDurationMs": 6226.289,
"heapDeltaBytes": -34699760,
"heapUsedBytes": 169452152,
"domNodes": -6548,
"jsHeapTotalBytes": 11726848,
"scriptDurationMs": 114.165,
"eventListeners": -7471,
"totalBlockingTimeMs": 464,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8698.068000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8439.714999999998,
"heapDeltaBytes": 7918528,
"heapUsedBytes": 177013704,
"domNodes": 0,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 136.50000000000006,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8491.310999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8215.923,
"heapDeltaBytes": 1082204,
"heapUsedBytes": 176348268,
"domNodes": 0,
"jsHeapTotalBytes": -7340032,
"scriptDurationMs": 124.76399999999998,
"eventListeners": -11,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 120.63899999998284,
"styleRecalcs": 8,
"styleRecalcDurationMs": 17.474,
"layouts": 2,
"layoutDurationMs": 1.2649999999999997,
"taskDurationMs": 76.967,
"heapDeltaBytes": 3049800,
"heapUsedBytes": 71997844,
"domNodes": 127,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.870000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 109.87300000010691,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.552,
"layouts": 2,
"layoutDurationMs": 1.467,
"taskDurationMs": 71.102,
"heapDeltaBytes": 3009244,
"heapUsedBytes": 70869004,
"domNodes": 128,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 5.082000000000003,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.54 #17871 +/- ##
=============================================
+ Coverage 82.97% 82.98% +0.01%
=============================================
Files 2053 2052 -1
Lines 119720 119742 +22
Branches 30970 32803 +1833
=============================================
+ Hits 99337 99373 +36
+ Misses 20203 20189 -14
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Exact backport reviewed; no findings.
Full context for agent readers
Authenticated as the PR author, so this is intentionally a COMMENT rather than a self-approval. The backport at ca6c1fdeea3c3005f4a7e9eb184492c994ef4e68 has the same stable patch ID as merged source commit eca7d5601eb217156953fc2b191af7f904c0b41d; only the cherry-pick provenance line differs. Source PR #16971 received @CodeJuggernaut's human approval at its exact source head. The release commit is one commit directly ahead of live core/1.54, with no conflict adaptation.
Target evidence: 100 focused Vitest tests, focused ESLint, typecheck, the promoted-widget shared-definition Playwright acceptance case, and diff check passed locally; all current GitHub checks are terminal green or skipped. No unresolved review threads or human objections were found.
…t connects (#17877) ## Summary Backports [#17202](#17202) to `core/1.54` after dependency [#17871](#17871). ## Changes - preserves promoted widget edits on existing subgraph hosts - resolves promoted input connections by declared slot identity - retains the source definition, follower, host-slot, graph-mutation, and store regressions ## Evidence Target base: `5ad19ef346c247da19a16a42890c23725a1235cd` Source commit: `d0dc978a1a4cf670b0a992d8c57381bd56fa9dcf` Backport head: `97f0b44c94564d7f18a35f8d0fd4dd61d15fafea` - stable source/backport patch ID: `73b75978da72d485df7cb054bd44045cecc79ccf` - focused definition/follower/host-slot/graph/store tests: 113 passed - focused ESLint: passed - `pnpm typecheck`: passed - target-head browser acceptance using the test-only [#17585](#17585) harness: 1 cloud Playwright test passed - `git diff --check`: passed - package and lockfile pins unchanged Justification: OSS maintainer-reviewed contribution — DrJKL approved source change #17202 at exact source head `8d0a074428264406fae7189053a5806b95dcdf42`; the source and backport stable patch IDs match and no production code changed in transit. Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Amp <amp@ampcode.com>
Summary
Backports #16971 to
core/1.54, avoiding full subgraph-definition reads on ordinary Agent CRDT frames.Changes
relmap-1, beforerelmap-2/ frontend 17202Review Focus
Target head was
e6dae0ee1c8f0dc490d7f81bbf66fa39988e3608; source commiteca7d5601eb217156953fc2b191af7f904c0b41dwas applied withcherry-pick -x.Target-tree evidence:
pnpm typecheck: passedgit diff --check: passedJustification: OSS maintainer-reviewed contribution — @CodeJuggernaut approved source PR #16971 at its exact source head before backport; stable patch IDs match and no code changed in transit.