Repository navigation
fix(agent): preserve subscribe retry backoff - #16981
Conversation
Port the bounded status-frame guard from 6d10597 onto current main and add focused regression coverage.
|
Warning Review limit reachedNext included review available in 8 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1908 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.69 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.6 MB (baseline 3.6 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 559 kB (baseline 559 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category Status: 296 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-04T15:30:52.284Z",
"gitSha": "e7b7c940a7deb95d9d852027bef6b0019f99c438",
"branch": "salvage/subscribe-retry-status-guard",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2038.7799999999743,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.933000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.11799999999994,
"heapDeltaBytes": -9840536,
"heapUsedBytes": 60891660,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.559000000000001,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2034.6630000000232,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.915,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.7,
"heapDeltaBytes": -12128084,
"heapUsedBytes": 57803760,
"domNodes": -282,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.17,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2004.148999999984,
"styleRecalcs": 83,
"styleRecalcDurationMs": 40.900000000000006,
"layouts": 14,
"layoutDurationMs": 4.577,
"taskDurationMs": 981.536,
"heapDeltaBytes": -8546136,
"heapUsedBytes": 61364252,
"domNodes": -280,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 156.858,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1783.029000000056,
"styleRecalcs": 75,
"styleRecalcDurationMs": 34.096,
"layouts": 14,
"layoutDurationMs": 4.234,
"taskDurationMs": 854.5429999999999,
"heapDeltaBytes": -8251840,
"heapUsedBytes": 62404136,
"domNodes": -280,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 146.776,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1728.3180000000016,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.535000000000004,
"layouts": 6,
"layoutDurationMs": 1.4070000000000003,
"taskDurationMs": 370.27000000000004,
"heapDeltaBytes": 4975416,
"heapUsedBytes": 75753348,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.648000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1686.9479999999157,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.046,
"layouts": 6,
"layoutDurationMs": 1.175,
"taskDurationMs": 360.21999999999997,
"heapDeltaBytes": 5088736,
"heapUsedBytes": 75903816,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.768,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 647.7390000000014,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.411,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.00000000000006,
"heapDeltaBytes": -7454752,
"heapUsedBytes": 62861976,
"domNodes": 20,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 156.544,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 656.7750000000387,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.428000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.922,
"heapDeltaBytes": 18219544,
"heapUsedBytes": 88308504,
"domNodes": 16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 151.282,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2005.6150000000343,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.4979999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 559.257,
"heapDeltaBytes": 21972500,
"heapUsedBytes": 87264168,
"domNodes": -269,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.647,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2040.5250000000024,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.985999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 597.476,
"heapDeltaBytes": -13959008,
"heapUsedBytes": 87033456,
"domNodes": -265,
"jsHeapTotalBytes": -1376256,
"scriptDurationMs": 31.703000000000003,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2174.33299999999,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.074000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1500.762,
"heapDeltaBytes": 21565180,
"heapUsedBytes": 87733232,
"domNodes": -274,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 740.898,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2186.959999999999,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.847999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1606.2810000000002,
"heapDeltaBytes": 11751880,
"heapUsedBytes": 88739044,
"domNodes": -266,
"jsHeapTotalBytes": 122880,
"scriptDurationMs": 788.168,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3428.959999999961,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.380000000000004,
"layouts": 60,
"layoutDurationMs": 12.553999999999998,
"taskDurationMs": 1631.7520000000002,
"heapDeltaBytes": 7737080,
"heapUsedBytes": 75761836,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 742.255,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3486.0180000000582,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.485000000000001,
"layouts": 60,
"layoutDurationMs": 12.720000000000002,
"taskDurationMs": 1639.8050000000003,
"heapDeltaBytes": 9454636,
"heapUsedBytes": 76586036,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 736.531,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2974.104999999952,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.096999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1866.572,
"heapDeltaBytes": 22474076,
"heapUsedBytes": 90175856,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 929.211,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 3036.566999999991,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.261000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1835.7559999999999,
"heapDeltaBytes": 17795552,
"heapUsedBytes": 85291796,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 911.7760000000002,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2007.3970000000259,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.0540000000001,
"heapDeltaBytes": 21719368,
"heapUsedBytes": 87854808,
"domNodes": -276,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.409,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2008.195999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 531.781,
"heapDeltaBytes": 22206404,
"heapUsedBytes": 88049596,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.85,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 573.8680000000045,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.183,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.394,
"heapDeltaBytes": 15175388,
"heapUsedBytes": 88111420,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 136.698,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 591.1929999999757,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.815000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.06399999999996,
"heapDeltaBytes": 15206500,
"heapUsedBytes": 87981472,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 138.22799999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2056.7100000000096,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.78,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.97999999999996,
"heapDeltaBytes": -7739512,
"heapUsedBytes": 64720144,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 8.128999999999998,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2016.7099999999891,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.841,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.718,
"heapDeltaBytes": 3534828,
"heapUsedBytes": 76262640,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.896,
"eventListeners": -226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1748.2889999999998,
"styleRecalcs": 78,
"styleRecalcDurationMs": 34.867999999999995,
"layouts": 18,
"layoutDurationMs": 5.289000000000001,
"taskDurationMs": 798.2779999999999,
"heapDeltaBytes": 230556,
"heapUsedBytes": 72273492,
"domNodes": -297,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 99.728,
"eventListeners": -228,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1780.5549999999357,
"styleRecalcs": 79,
"styleRecalcDurationMs": 36.301,
"layouts": 18,
"layoutDurationMs": 5.625,
"taskDurationMs": 819.976,
"heapDeltaBytes": -9984448,
"heapUsedBytes": 63012564,
"domNodes": -297,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 98.06300000000002,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.2819999999847,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.982000000000003,
"layouts": 14,
"layoutDurationMs": 14.130999999999998,
"taskDurationMs": 938.0620000000001,
"heapDeltaBytes": 21037788,
"heapUsedBytes": 110354768,
"domNodes": 13751,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 29.303000000000004,
"eventListeners": 2387,
"totalBlockingTimeMs": 127,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8387.233999999979,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.629999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5723.819,
"heapDeltaBytes": -9856656,
"heapUsedBytes": 91987912,
"domNodes": -266,
"jsHeapTotalBytes": -102400,
"scriptDurationMs": 2640.648,
"eventListeners": -134,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8423.288999999953,
"styleRecalcs": 247,
"styleRecalcDurationMs": 37.44,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5533.3820000000005,
"heapDeltaBytes": -8144492,
"heapUsedBytes": 93345684,
"domNodes": -267,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 2509.1820000000002,
"eventListeners": -134,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18172.218999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17216.546000000002,
"heapDeltaBytes": -32288048,
"heapUsedBytes": 181804940,
"domNodes": -6577,
"jsHeapTotalBytes": -3354624,
"scriptDurationMs": 292.38,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17935.88999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16990.970999999998,
"heapDeltaBytes": -27917424,
"heapUsedBytes": 177167852,
"domNodes": -6548,
"jsHeapTotalBytes": -5156864,
"scriptDurationMs": 286.863,
"eventListeners": -7477,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21982.18800000001,
"styleRecalcs": 172,
"styleRecalcDurationMs": 20.187999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21675.146,
"heapDeltaBytes": -22390536,
"heapUsedBytes": 180373152,
"domNodes": -6548,
"jsHeapTotalBytes": 2592768,
"scriptDurationMs": 914.1140000000001,
"eventListeners": -7467,
"totalBlockingTimeMs": 163,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22255.718999999997,
"styleRecalcs": 174,
"styleRecalcDurationMs": 20.156999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21935.589,
"heapDeltaBytes": -47059372,
"heapUsedBytes": 166861604,
"domNodes": -6548,
"jsHeapTotalBytes": -9478144,
"scriptDurationMs": 928.133,
"eventListeners": -7469,
"totalBlockingTimeMs": 57,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6319.117000000006,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.38,
"layouts": 20,
"layoutDurationMs": 23.165000000000006,
"taskDurationMs": 6212.334,
"heapDeltaBytes": -28115348,
"heapUsedBytes": 182687588,
"domNodes": -6548,
"jsHeapTotalBytes": 7909376,
"scriptDurationMs": 114.85400000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 459,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6360.431999999946,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.835,
"layouts": 20,
"layoutDurationMs": 24.266999999999996,
"taskDurationMs": 6258.097,
"heapDeltaBytes": -35060036,
"heapUsedBytes": 174239268,
"domNodes": -6548,
"jsHeapTotalBytes": 3432448,
"scriptDurationMs": 144.46300000000002,
"eventListeners": -7471,
"totalBlockingTimeMs": 450,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9070.103000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8641.993,
"heapDeltaBytes": 17331356,
"heapUsedBytes": 175698000,
"domNodes": 0,
"jsHeapTotalBytes": -1572864,
"scriptDurationMs": 137.034,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8908.402000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8530.724000000002,
"heapDeltaBytes": 18986188,
"heapUsedBytes": 176021332,
"domNodes": 0,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 145.567,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 103.60400000001846,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.531,
"layouts": 2,
"layoutDurationMs": 0.5350000000000001,
"taskDurationMs": 72.22899999999998,
"heapDeltaBytes": 3126772,
"heapUsedBytes": 72007356,
"domNodes": 109,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.498,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 476.6460000000734,
"styleRecalcs": 17,
"styleRecalcDurationMs": 18.264,
"layouts": 2,
"layoutDurationMs": 1.241,
"taskDurationMs": 102.38799999999999,
"heapDeltaBytes": 4911720,
"heapUsedBytes": 73623208,
"domNodes": 142,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.613999999999999,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16981 +/- ##
==========================================
+ Coverage 81.23% 82.79% +1.55%
==========================================
Files 2464 2046 -418
Lines 126966 119489 -7477
Branches 32036 30210 -1826
==========================================
- Hits 103141 98930 -4211
+ Misses 23310 20379 -2931
+ Partials 515 180 -335
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 425 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 4 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 1 |
| 🟢 Low | 3 |
Panel: 8/8 reviewers contributed findings.
| * the retry timer owns the next attempt and its backoff. | ||
| */ | ||
| const onSocketActivity: EventListener = () => { | ||
| if (subscribeRetryTimer !== null) return |
There was a problem hiding this comment.
🟡 Medium — This guard only holds while a timer is pending, so it disengages exactly when throttling matters most: scheduleSubscribeRetry() no-ops once subscribeRetryAttempt >= SUBSCRIBE_RETRY_MAX_ATTEMPTS, leaving subscribeRetryTimer permanently null after the 6th refusal, and the counter is only reset by clearSubscribeRetry() (confirmed subscribe, retarget, unmount). Every subsequent status frame then calls reconcile(), which re-sends doc_subscribe because the refusal cleared sentWorkflowId, so a persistently refusing doc host gets an un-backed-off subscribe per queue transition (and one per second under the _pollQueue fallback) — the exact spam this change exists to stop. Consider keeping the timer armed at the max delay once the attempt budget is spent.
Raised by 7 of 8 reviewers (gpt-5.6-sol-max adversarial + edge-case, claude-opus-5-thinking-max adversarial + edge-case, kimi-k3-max adversarial + edge-case, gemini-3.1-pro edge-case).
| * the retry timer owns the next attempt and its backoff. | ||
| */ | ||
| const onSocketActivity: EventListener = () => { | ||
| if (subscribeRetryTimer !== null) return |
There was a problem hiding this comment.
🟢 Low — The "retry timer owns the next attempt" invariant is enforced only on the status path; onReconnected still calls bridge.resubscribe() unconditionally, so a socket flap during a backoff window sends an immediate subscribe and the still-pending timer sends a duplicate later. Since each resubscribe() resets the bridge's lastSeq/ackSeq/catchUpPending, the second ack re-arms a catch-up frame that can re-dispatch a doc_update the adapter already applied. Clearing the retry in onReconnected would keep both paths consistent.
Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, kimi-k3-max edge-case).
| * the retry timer owns the next attempt and its backoff. | ||
| */ | ||
| const onSocketActivity: EventListener = () => { | ||
| if (subscribeRetryTimer !== null) return |
There was a problem hiding this comment.
🟢 Low — The guard conflates two failure modes: reconcile() repairs a subscribe frame that never left a closed socket, while the retry timer addresses a server refusal — and a pending backoff now suppresses the transport-repair path across a socket outage. The retry is itself best-effort (reconcile()/resubscribe() swallow send failure via trySend, and only a received doc_subscribed{ok:false} arms a new retry), so a timer that fires while the socket is down sends nothing and arms nothing, leaving the follower unsubscribed until the next status/reconnected. Gating on a pending-subscribe check, or clearing the retry when the socket reconnects, would preserve the repair path.
Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
| unmount() | ||
| }) | ||
|
|
||
| it('does not bypass refused-subscribe backoff on status frames', () => { |
There was a problem hiding this comment.
🟢 Low — The new test only covers the first backoff window and never exhausts SUBSCRIBE_RETRY_MAX_ATTEMPTS, which is why the post-exhaustion bypass goes undetected. Extending it to drive six refusals and then assert that a status frame still does not call reconcile() would lock in the fix.
Raised by 1 of 8 reviewers (gemini-3.1-pro edge-case).
|
Two independent landing chains: #16842 → #16981, and #16973 → #16971. Rebase the second PR in each chain and re-read the shared follower block. Full context for agent readersThese are interior-line overlaps in
#16981's one-file change set is also a strict subset of eight open PR file sets: #16973, #16971, #16957, #16926, #16902, #16861, #16849, and #16842. File-set containment does not prove semantic duplication, so do not drop it automatically; after each related merge, rebase, inspect the resulting diff, and close rather than merge only if its changed-file count reaches zero. |
CodeJuggernaut
left a comment
There was a problem hiding this comment.
Read at 5c56a8c: the backoff survives the re-subscribe and the test covers it; the four bot comments are the only threads and none is an objection. Nothing to add.
Prevents socket status frames from bypassing a refused subscription's bounded retry timer and backoff. Adds focused coverage proving status activity stays inert until the scheduled retry runs. This is the current-main-compatible residual from `6d1059776475`; the predecessor behavior remains carried by #16637. ## Evidence - `pnpm test:unit src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts` — 49/49 passed - `pnpm exec eslint src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts` — passed - `pnpm exec oxfmt --check ...` — passed - `pnpm typecheck` — passed - `pnpm knip` — passed - `git diff --check` — passed <!-- authored-by:agent lane-salvbatch-8-residuals-1510 --> (cherry picked from commit a81ed59)
Prevents socket status frames from bypassing a refused subscription's bounded retry timer and backoff. Adds focused coverage proving status activity stays inert until the scheduled retry runs. This is the current-main-compatible residual from `6d1059776475`; the predecessor behavior remains carried by #16637. ## Evidence - `pnpm test:unit src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts` — 49/49 passed - `pnpm exec eslint src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts` — passed - `pnpm exec oxfmt --check ...` — passed - `pnpm typecheck` — passed - `pnpm knip` — passed - `git diff --check` — passed <!-- authored-by:agent lane-salvbatch-8-residuals-1510 --> (cherry picked from commit a81ed59)
Prevents socket status frames from bypassing a refused subscription's bounded retry timer and backoff. Adds focused coverage proving status activity stays inert until the scheduled retry runs.
This is the current-main-compatible residual from
6d1059776475; the predecessor behavior remains carried by #16637.Evidence
pnpm test:unit src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts— 49/49 passedpnpm exec eslint src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts— passedpnpm exec oxfmt --check ...— passedpnpm typecheck— passedpnpm knip— passedgit diff --check— passed