Repository navigation
fix: keep edited dynamic-combo child values across option toggles - #16508
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughDynamic combo widgets now cache removed widget values per option and restore compatible values when options are revisited. Regression tests cover deserialization, same-name child isolation, option recreation, and restoration cleanup. ChangesDynamic widget restoration
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Severity of issue fixed: Medium Merge Risk: 🔵 Low · up to Dynamic-combo child values are now retained across option changes, including nested widgets. A low remaining risk concerns the test fixture’s unsupported graph-geometry mutation path. Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 warning, 2 inconclusive)
✅ Passed checks (4 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The changed files are available and show changes under Full details: Adr Compliance For Entity/Litegraph ChangesExplanation The check applies because the PR changes Resolution Provide the PR diff relative to its base revision, especially the changes in
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 1938 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.88 MB gzip 🔴 +235 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 128 kB (baseline 128 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 622 kB (baseline 622 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 28.9 kB (baseline 28.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 118 kB (baseline 118 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.64 MB (baseline 3.64 MB) • 🔴 +1.37 kBStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 558 kB (baseline 558 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 18 unchanged Vendor & Third-Party — 18.2 MB (baseline 18.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17 MB (baseline 17 MB) • ⚪ 0 BBundles that do not match a named category
Status: 72 added / 72 removed / 225 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-09T20:19:52.587Z",
"gitSha": "0985ceb52fb4aa0ab4e8b30a6594594f3b10cae3",
"branch": "test/coverage-litegraph-core",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.7159999999594,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.946,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.554,
"heapDeltaBytes": 6373972,
"heapUsedBytes": 68394468,
"domNodes": -261,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.508000000000001,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2014.9030000000039,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 347.73299999999995,
"heapDeltaBytes": -6339864,
"heapUsedBytes": 54917896,
"domNodes": -262,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.664000000000001,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1984.8329999999805,
"styleRecalcs": 76,
"styleRecalcDurationMs": 28.571999999999996,
"layouts": 14,
"layoutDurationMs": 4.499,
"taskDurationMs": 935.213,
"heapDeltaBytes": 1930444,
"heapUsedBytes": 62648252,
"domNodes": -264,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 177.98600000000002,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1731.839999999977,
"styleRecalcs": 74,
"styleRecalcDurationMs": 24.732000000000003,
"layouts": 14,
"layoutDurationMs": 4.087999999999999,
"taskDurationMs": 799.293,
"heapDeltaBytes": -362868,
"heapUsedBytes": 61536328,
"domNodes": -260,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 159.726,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.9380000000128,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.249999999999998,
"layouts": 6,
"layoutDurationMs": 1.033,
"taskDurationMs": 330.23800000000006,
"heapDeltaBytes": 2145084,
"heapUsedBytes": 64174416,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.633,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.257999999987,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.626,
"layouts": 6,
"layoutDurationMs": 0.9850000000000002,
"taskDurationMs": 321.32000000000005,
"heapDeltaBytes": 2084216,
"heapUsedBytes": 64005076,
"domNodes": 76,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 10.341000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 650.5930000000149,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.982999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.79699999999997,
"heapDeltaBytes": 17831572,
"heapUsedBytes": 79918068,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 169.949,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 614.9360000000001,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.826,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.165,
"heapDeltaBytes": 17131944,
"heapUsedBytes": 77771396,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 163.482,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2039.1280000000052,
"styleRecalcs": 7,
"styleRecalcDurationMs": 9.556,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.8919999999999,
"heapDeltaBytes": -358208,
"heapUsedBytes": 79135240,
"domNodes": -254,
"jsHeapTotalBytes": -532480,
"scriptDurationMs": 29.421000000000003,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2037.0419999999285,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.103999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 582.2919999999999,
"heapDeltaBytes": 2151588,
"heapUsedBytes": 81213628,
"domNodes": -247,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 31.160999999999994,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2322.2000000000094,
"styleRecalcs": 64,
"styleRecalcDurationMs": 8.331999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1569.28,
"heapDeltaBytes": 14773176,
"heapUsedBytes": 79105764,
"domNodes": 4,
"jsHeapTotalBytes": 1798144,
"scriptDurationMs": 837.736,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2279.5340000000124,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.219999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1704.4740000000002,
"heapDeltaBytes": -4225120,
"heapUsedBytes": 76272816,
"domNodes": -227,
"jsHeapTotalBytes": 1003520,
"scriptDurationMs": 905.157,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3399.8960000000125,
"styleRecalcs": 61,
"styleRecalcDurationMs": 9.463000000000003,
"layouts": 60,
"layoutDurationMs": 10.729000000000001,
"taskDurationMs": 1591.327,
"heapDeltaBytes": 9798492,
"heapUsedBytes": 74330820,
"domNodes": -258,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 750.14,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3452.3609999999962,
"styleRecalcs": 61,
"styleRecalcDurationMs": 9.749999999999998,
"layouts": 60,
"layoutDurationMs": 11.099999999999998,
"taskDurationMs": 1626.925,
"heapDeltaBytes": 11614696,
"heapUsedBytes": 77535532,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 758.241,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2961.733000000038,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.146000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1859.938,
"heapDeltaBytes": 13372704,
"heapUsedBytes": 79576924,
"domNodes": 2,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 960.4619999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3031.831000000011,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.278999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1863.946,
"heapDeltaBytes": 21267064,
"heapUsedBytes": 86657424,
"domNodes": 2,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 977.415,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2017.3189999999863,
"styleRecalcs": 4,
"styleRecalcDurationMs": 2.895000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 509.0220000000001,
"heapDeltaBytes": 19757056,
"heapUsedBytes": 83833272,
"domNodes": -251,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 25.172,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2067.937999999913,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.980000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 568.166,
"heapDeltaBytes": -5971288,
"heapUsedBytes": 81332196,
"domNodes": -255,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 29.12200000000001,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 564.002999999957,
"styleRecalcs": 46,
"styleRecalcDurationMs": 8.793,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.698,
"heapDeltaBytes": 13372264,
"heapUsedBytes": 76519024,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 137.90099999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 573.2319999999618,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.109000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.96700000000004,
"heapDeltaBytes": 14265892,
"heapUsedBytes": 77581308,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 138.265,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1989.5139999999856,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.749,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.61000000000007,
"heapDeltaBytes": -1265548,
"heapUsedBytes": 62063136,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.595,
"eventListeners": -230,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.3609999999658,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.502,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.051,
"heapDeltaBytes": -8441896,
"heapUsedBytes": 54596140,
"domNodes": -276,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 6.953999999999998,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.4370000000076,
"styleRecalcs": 77,
"styleRecalcDurationMs": 25.27,
"layouts": 18,
"layoutDurationMs": 4.59,
"taskDurationMs": 742.46,
"heapDeltaBytes": 11383148,
"heapUsedBytes": 74416484,
"domNodes": -276,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 106.093,
"eventListeners": -202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1756.511000000046,
"styleRecalcs": 77,
"styleRecalcDurationMs": 25.118000000000002,
"layouts": 18,
"layoutDurationMs": 4.709,
"taskDurationMs": 759.6400000000001,
"heapDeltaBytes": 17910348,
"heapUsedBytes": 80833884,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 101.839,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1367.084000000034,
"styleRecalcs": 16,
"styleRecalcDurationMs": 28.46,
"layouts": 5,
"layoutDurationMs": 13.075,
"taskDurationMs": 871.1569999999999,
"heapDeltaBytes": 19693832,
"heapUsedBytes": 101321236,
"domNodes": 13587,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 29.241000000000003,
"eventListeners": 2387,
"totalBlockingTimeMs": 156,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8279.911000000027,
"styleRecalcs": 247,
"styleRecalcDurationMs": 32.080999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5526.098,
"heapDeltaBytes": -3369856,
"heapUsedBytes": 75301160,
"domNodes": -248,
"jsHeapTotalBytes": -45056,
"scriptDurationMs": 2692.1719999999996,
"eventListeners": -138,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8393.40900000002,
"styleRecalcs": 245,
"styleRecalcDurationMs": 30.717,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5711.398,
"heapDeltaBytes": 13511108,
"heapUsedBytes": 77133164,
"domNodes": -253,
"jsHeapTotalBytes": 454656,
"scriptDurationMs": 2831.2299999999996,
"eventListeners": 20,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16020.52500000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15143.552,
"heapDeltaBytes": -25658640,
"heapUsedBytes": 174655248,
"domNodes": -6542,
"jsHeapTotalBytes": 2859008,
"scriptDurationMs": 226.825,
"eventListeners": -7476,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15877.696000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15061.596000000001,
"heapDeltaBytes": -6664924,
"heapUsedBytes": 188296188,
"domNodes": -6542,
"jsHeapTotalBytes": 897024,
"scriptDurationMs": 249.78700000000003,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 19891.93,
"styleRecalcs": 157,
"styleRecalcDurationMs": 14.676999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19511.406000000003,
"heapDeltaBytes": -16051924,
"heapUsedBytes": 176328276,
"domNodes": -6542,
"jsHeapTotalBytes": 1548288,
"scriptDurationMs": 900.951,
"eventListeners": -7472,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 19741.243000000053,
"styleRecalcs": 171,
"styleRecalcDurationMs": 16.72600000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19391.086000000003,
"heapDeltaBytes": -37136432,
"heapUsedBytes": 164906472,
"domNodes": -6542,
"jsHeapTotalBytes": -28672,
"scriptDurationMs": 910.2860000000001,
"eventListeners": -7472,
"totalBlockingTimeMs": 23,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 5774.927999999989,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.63000000000001,
"layouts": 20,
"layoutDurationMs": 21.38699999999999,
"taskDurationMs": 5643.39,
"heapDeltaBytes": -23448012,
"heapUsedBytes": 176849452,
"domNodes": -6542,
"jsHeapTotalBytes": 8019968,
"scriptDurationMs": 102.155,
"eventListeners": -7474,
"totalBlockingTimeMs": 433,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5793.912999999975,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.55000000000001,
"layouts": 20,
"layoutDurationMs": 21.364000000000008,
"taskDurationMs": 5673.130999999999,
"heapDeltaBytes": -30639848,
"heapUsedBytes": 170629496,
"domNodes": -6542,
"jsHeapTotalBytes": 10117120,
"scriptDurationMs": 100.115,
"eventListeners": -7476,
"totalBlockingTimeMs": 347,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8184.097999999949,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7701.324000000001,
"heapDeltaBytes": 31407504,
"heapUsedBytes": 190924556,
"domNodes": 0,
"jsHeapTotalBytes": -5242880,
"scriptDurationMs": 141.613,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6082.442000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5471.223000000002,
"heapDeltaBytes": -17667108,
"heapUsedBytes": 176518460,
"domNodes": 0,
"jsHeapTotalBytes": -16777216,
"scriptDurationMs": 110.20399999999997,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 472.3019999999565,
"styleRecalcs": 20,
"styleRecalcDurationMs": 23.714,
"layouts": 3,
"layoutDurationMs": 1.5010000000000001,
"taskDurationMs": 121.59800000000001,
"heapDeltaBytes": 5078188,
"heapUsedBytes": 66798448,
"domNodes": 147,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.993,
"eventListeners": 83,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 471.9559999999774,
"styleRecalcs": 20,
"styleRecalcDurationMs": 23.889000000000003,
"layouts": 4,
"layoutDurationMs": 1.6710000000000003,
"taskDurationMs": 113.838,
"heapDeltaBytes": 4961640,
"heapUsedBytes": 66652484,
"domNodes": 148,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.347999999999999,
"eventListeners": 83,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
getNodeOnPos already resolves nodesInRenderOrder rather than raw insertion order, but had no direct regression test. Pin the contract: reordering z-index via setNodeOrder (the mechanism bringToFront and sendToBack delegate to) without touching _nodes' insertion order must still change which overlapping node getNodeOnPos resolves to. Addresses part of #15973.
LGraph.removeNode ran clearNodeOwnedStoreState (which unconditionally wiped widget state) before detachNodeFromStores' own keep-values/ discard-values distinction ever got a chance to matter, making WidgetDetachMode: 'keep-values' dead code — releaseNodeWidgets found no order entry left to act on. clearNodeOwnedStoreState now takes the same mode and skips the widget value wipe on 'keep-values', so an ordinary node removal (as opposed to a whole-graph clear, subgraph-definition teardown, or node replacement, which still discard values) leaves its widget values recoverable. Updates four pre-existing tests that asserted the bug's symptom (widget/promoted-widget values cleared immediately on an ordinary remove) as if it were the intended contract. Addresses part of #15973.
extensionConfigureView Object.assign'd the extensions-namespaced/legacy payload directly onto the caller's live serialized node/graph object and handed that same object to onConfigure — an extension mutating its argument, or simply the namespaced payload being promoted onto it, polluted the caller's workflow JSON in place. That could desync ChangeTracker's modified-state diff right after opening a workflow, and re-promote a namespaced key to a top-level legacy field on a missing- node placeholder's next serialize. Shallow-clone the canonical object before assigning onto it, so the hook gets an isolated view and the caller's object is untouched. Updates a pre-existing test that asserted onConfigure receives the exact same object reference as the caller's serialized data. Addresses part of #15973. See discussion: #15924 (comment)
Reload's widgets_values restoration is already scoped to the configure() pass — LGraphNode.configure clears the node's widgetValueStore restoration record in a finally block before it returns, so a later widget re-add (e.g. toggling a dynamic combo away and back) can no longer resurrect a stale workflow-file value. Add a regression test covering the exact user-reachable path: load a workflow, edit a dynamic-combo widget's nested value, toggle the combo away and back, and assert the edited value survives rather than snapping back to the loaded value. Fixes #16006.
PrimitiveNode's widgets_values restore loop was deleted from onAfterGraphConfigured, and the replacement — the positional restore inside LGraphNode.addCustomWidget — runs before _createWidget copies theirWidget.value onto the new widget, so the copy always won: a primitive whose serialized value differs from its target's silently adopted the target's value on load. That's the norm under control_after_generate: randomize, since applyToGraph copies primitive -> target at queue time and the primitive then randomizes, so the two values differ by one generation at save time — seeds silently reverted on reload. The store-based fix suggested in review doesn't work as-is: LGraphNode .configure clears its widget-restoration record in a finally block before it returns, and PrimitiveNode's widget isn't created until onAfterGraphConfigured runs afterward, by which point the store record is already gone. Capture the node's own widgets_values directly on onConfigure instead, and read from that captured snapshot in _createWidget after the theirWidget copy (control/filter widgets have the same gap and get the same fix). The existing primitive_node.json E2E fixture can't catch this since both values are equal; added a unit-level round-trip regression instead: connect a primitive to a target, diverge their values (as control_after_generate would), serialize, reload, and assert the primitive's own value wins. Fixes #16007.
e9fc5bd to
34c4db0
Compare
|
Assignment stage complete.
Full context for agent readersAdvanced the no-assignee lifecycle stage for At the assignment checkpoint, 76 checks passed, 10 were skipped, and three remained in progress. The same exact head has now settled at 85 successful and 10 skipped checks, with zero pending or failed. This status correction does not advance another lifecycle stage. Assignment evidence: Next stage: route a high-tier exact-head review through the standing review queue. |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #16508 +/- ##
==========================================
+ Coverage 81.79% 83.20% +1.41%
==========================================
Files 2519 2064 -455
Lines 128615 120406 -8209
Branches 33242 34252 +1010
==========================================
- Hits 105202 100187 -5015
+ Misses 22880 20040 -2840
+ Partials 533 179 -354
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 463 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Review — 3 takeaways:
- F1 (Medium):
_configuredWidgetsValuesnever cleared → post-load disconnect/reconnect resurrects the workflow-file value. Same bug class as #16006 this PR fixes for dynamic combos. - F2 (Low):
extensionConfigureViewshallow-clones — nested objects still shared with caller. - Ran all 9 test files locally: 187/187 green. Test quality is excellent.
Full context for agent readers
What was reviewed
Head 34c4db0, full diff (13 files, +350/−37): clearNodeOwnedStoreState keep/discard mode split, extensionConfigureView clone isolation, PrimitiveNode serialized-value restore (#16007), widget snap-back (#16006), getNodeOnPos z-order tests.
Verified
- Keep/discard split is coherent:
fireNodeRemovalLifecycles(discard) covers graph clear/teardown + released-subgraph interiors — permanent destruction;removeNodekeeps values for undo;useNodeReplacementdiscards intentionally. ThenodesBeingRemovedWeakSet prevents double-fire, and the removed host node never appears in its released subgraph's interior list, so no keep-then-discard race. - Both
extensionConfigureViewcallers (LGraphNode.ts:1192,LGraph.ts:3037) pass the return value straight intoonConfigure— nothing relied on the old in-place mutation. recreateWidget→_onFirstConnection(true)correctly skips serialized restore and re-applies live values positionally.- Ran the PR's 9 test files locally on the head commit: 187/187 pass.
Findings
F1 (Medium) — see inline comment on widgetInputs.ts.
F2 (Low) — see inline comment on extensionPersistence.ts.
Positive
The red-before/green-after discipline documented per assertion in the PR body is exactly what makes test-only PRs reviewable, and the getNodeOnPos z-order tests pin the #15924 discussion regression precisely.
Diagram
load workflow ──▶ onConfigure ──▶ _configuredWidgetsValues = [7,'fixed']
│
onAfterGraphConfigured ──▶ _createWidget(recreating=false) ──▶ value = 7 ✓
│ (never cleared)
user edits → disconnect → reconnect ──▶ _createWidget(recreating=false) ──▶ value = 7 ✗ stale
Glossary
- #16006: widget snap-back bug (dynamic combo re-add resurrects workflow-file value)
- #16007: PrimitiveNode ignores own serialized value on reload
- WidgetDetachMode:
'keep-values' | 'discard-values'param added toclearNodeOwnedStoreState _configuredWidgetsValues: PrimitiveNode's private copy of serializedwidgets_values, bridging configure→onAfterGraphConfigured- #15924: prior PR whose review discussions motivated the z-order and clone-isolation tests
The serialized widgets_values captured in onConfigure were kept for the node's lifetime, so a post-load disconnect -> reconnect rebuilt the widget with the workflow-file value instead of the live target widget's value — the same snap-back class as #16006. Clear the captured values after the first non-recreating build so the restore only applies to the initial post-configure widget creation. Red-before/green-after: the new reconnect test fails with 7 (stale workflow-file value) before this fix and passes with 9 (live target value) after.
|
|
|
@coderabbitai review |
|
DrJKL
left a comment
There was a problem hiding this comment.
The PrimitiveNode restoration overlaps #16459 but omits cases that its red-tested implementation covers, including asset widgets, declared controls, explicit undefined, type drift, range clamping, and removed combo options. Please remove this competing implementation and let #16459 own #16007. The detach and configure-isolation production fixes are independent changes and should be split from the coverage-only work. Local typecheck, changed-file format/ESLint, knip, and 188 focused tests pass; replacing the production files with main makes 6 of the new regressions fail as expected.
…ph-core Amp-Thread-ID: https://ampcode.com/threads/T-01a082a5-9d04-718a-97e2-910f969770a4 # Conflicts: # src/core/graph/widgets/dynamicWidgets.test.ts
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
DrJKL
left a comment
There was a problem hiding this comment.
Re-reviewed after merging current main. The conflict resolution preserves main's global Pinia setup, the nested dynamic-combo restoration now covers children absent from the default option, and the focused suite, typecheck, lint, formatting, and diff audit pass. No blocking findings.
|
|
|
|
…oss option toggles (#17297) Backport of #16508 to `cloud/1.53`. - Fix: edited dynamic-combo child values now survive option toggles - Automated backport failed on a test-file conflict; resolved manually, tests green locally - Only `custom_nodes_e2e` expected red (known upstream source outage, unrelated) <details><summary>Full context for agent readers</summary> Cherry-pick of merge commit 3e43e3e (#16508, merged by DrJKL 2026-09-09) onto `cloud/1.53`, with `-x` trailer. Conflict was limited to `src/core/graph/widgets/dynamicWidgets.test.ts`: the release branch has `setActivePinia`/`createTestingPinia` setup in `beforeEach` that main no longer has. Resolution keeps the 1.53 Pinia setup and adds #16508's `afterEach` restore of `LiteGraph.namedValuesRestore` (present on 1.53 at `LiteGraphGlobal.ts`). `dynamicWidgets.ts` applied cleanly. Local verification on this branch: `pnpm install --frozen-lockfile` ok, `pnpm typecheck` ok, `pnpm vitest run src/core/graph/widgets/dynamicWidgets.test.ts` 23/23 passed. The `custom_nodes_e2e` job fails on every branch because the pinned `ComfyUI-Prompt-Combinator` commit no longer exists upstream; #17269 quarantines it on main and has not been backported. <!-- authored-by:agent w3-520-ingest --> </details> Co-authored-by: Amp <amp@ampcode.com>
…ss option toggles (#17296) Backport of #16508 to `core/1.53`. - Fix: edited dynamic-combo child values now survive option toggles - Automated backport failed on a test-file conflict; resolved manually, tests green locally - Only `custom_nodes_e2e` expected red (known upstream source outage, unrelated) <details><summary>Full context for agent readers</summary> Cherry-pick of merge commit 3e43e3e (#16508, merged by DrJKL 2026-09-09) onto `core/1.53`, with `-x` trailer. Conflict was limited to `src/core/graph/widgets/dynamicWidgets.test.ts`: the release branch has `setActivePinia`/`createTestingPinia` setup in `beforeEach` that main no longer has. Resolution keeps the 1.53 Pinia setup and adds #16508's `afterEach` restore of `LiteGraph.namedValuesRestore` (present on 1.53 at `LiteGraphGlobal.ts`). `dynamicWidgets.ts` applied cleanly. Local verification on this branch: `pnpm install --frozen-lockfile` ok, `pnpm typecheck` ok, `pnpm vitest run src/core/graph/widgets/dynamicWidgets.test.ts` 23/23 passed. The `custom_nodes_e2e` job fails on every branch because the pinned `ComfyUI-Prompt-Combinator` commit no longer exists upstream; #17269 quarantines it on main and has not been backported. <!-- authored-by:agent w3-520-ingest --> </details> Co-authored-by: Amp <amp@ampcode.com>
…oss option toggles (#17306) Backport of merged fix #16508 to the `cloud/1.54` release branch. - Keeps user-edited dynamic-combo child values when the parent option is toggled away and back. - One test-file conflict in the imports/setup header (both sides added setup helpers); resolved by keeping both. Typecheck and `dynamicWidgets.test.ts` (23 passed) are green locally. - Fix merged to main after the 1.54 branches were cut; 1.53 backports already merged. <details><summary>Full context for agent readers</summary> Source: #16508 (merge commit `3e43e3e7a51e77c93185feb6a499f45fb939b7f8`). 1.53 backports: #17296 and #17297 (merged). Manual cherry-pick opened under Christian's standing backport authorization (bbc #520 answer 2). Files: `src/core/graph/widgets/dynamicWidgets.ts`, `src/core/graph/widgets/dynamicWidgets.test.ts`. Conflict detail: `dynamicWidgets.test.ts` header. Branch HEAD had pinia imports plus `setActivePinia` in `beforeEach`; the cherry-picked commit added an `afterEach` import and an `afterEach` that restores `LiteGraph.namedValuesRestore`. Both hunks were kept; no test logic was altered. Local verification: `CI=true pnpm install --frozen-lockfile`, pre-commit (oxfmt/oxlint/eslint + `pnpm typecheck`) passed, `pnpm vitest run src/core/graph/widgets/dynamicWidgets.test.ts` = 23 passed. <!-- authored-by:agent w3-520-followup --> </details> Co-authored-by: Amp <amp@ampcode.com>
…ss option toggles (#17305) Backport of merged fix #16508 to the `core/1.54` release branch. - Keeps user-edited dynamic-combo child values when the parent option is toggled away and back. - One test-file conflict in the imports/setup header (both sides added setup helpers); resolved by keeping both. Typecheck and `dynamicWidgets.test.ts` (23 passed) are green locally. - Fix merged to main after the 1.54 branches were cut; 1.53 backports already merged. <details><summary>Full context for agent readers</summary> Source: #16508 (merge commit `3e43e3e7a51e77c93185feb6a499f45fb939b7f8`). 1.53 backports: #17296 and #17297 (merged). Manual cherry-pick opened under Christian's standing backport authorization (bbc #520 answer 2). Files: `src/core/graph/widgets/dynamicWidgets.ts`, `src/core/graph/widgets/dynamicWidgets.test.ts`. Conflict detail: `dynamicWidgets.test.ts` header. Branch HEAD had pinia imports plus `setActivePinia` in `beforeEach`; the cherry-picked commit added an `afterEach` import and an `afterEach` that restores `LiteGraph.namedValuesRestore`. Both hunks were kept; no test logic was altered. Local verification: `CI=true pnpm install --frozen-lockfile`, pre-commit (oxfmt/oxlint/eslint + `pnpm typecheck`) passed, `pnpm vitest run src/core/graph/widgets/dynamicWidgets.test.ts` = 23 passed. <!-- authored-by:agent w3-520-followup --> </details> Co-authored-by: Amp <amp@ampcode.com>
|
|
|
|
Summary
Dynamic-combo child widgets keep their edited values when their option is toggled away and back. Values remain isolated per option, including an active nested combo rebuilt by its parent.
The restore now runs after the input-layout transaction commits and resolves each current widget by name before assigning its cached value. This avoids writing to detached descendants when restoring a nested combo synchronously recreates its children.
The redundant
getNodeOnPostest was removed becausearrangeForLegacyRender.test.tsalready covers default hit testing against authoritative z-order. The load regression also restoresLiteGraph.namedValuesRestoreafter each test.Test plan
pnpm test:unit src/core/graph/widgets/dynamicWidgets.test.ts src/renderer/core/canvas/litegraph/arrangeForLegacyRender.test.tspnpm typecheckFixes #16006.