Skip to content

[backport cloud/1.54] fix: keep edited dynamic-combo child values across option toggles - #17306

Merged
DrJKL merged 1 commit into
cloud/1.54from
christian-byrne/backport-16508-cloud-1.54
Sep 9, 2026
Merged

DrJKL merged 1 commit into
cloud/1.54from
christian-byrne/backport-16508-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backport of merged fix #16508 to the cloud/1.54 release branch.

  • Keeps user-edited dynamic-combo child values when the parent option is toggled away and back.
  • One test-file conflict in the imports/setup header (both sides added setup helpers); resolved by keeping both. Typecheck and dynamicWidgets.test.ts (23 passed) are green locally.
  • Fix merged to main after the 1.54 branches were cut; 1.53 backports already merged.
Full context for agent readers

Source: #16508 (merge commit 3e43e3e7a51e77c93185feb6a499f45fb939b7f8). 1.53 backports: #17296 and #17297 (merged). Manual cherry-pick opened under Christian's standing backport authorization (bbc #520 answer 2).

Files: src/core/graph/widgets/dynamicWidgets.ts, src/core/graph/widgets/dynamicWidgets.test.ts.

Conflict detail: dynamicWidgets.test.ts header. Branch HEAD had pinia imports plus setActivePinia in beforeEach; the cherry-picked commit added an afterEach import and an afterEach that restores LiteGraph.namedValuesRestore. Both hunks were kept; no test logic was altered.

Local verification: CI=true pnpm install --frozen-lockfile, pre-commit (oxfmt/oxlint/eslint + pnpm typecheck) passed, pnpm vitest run src/core/graph/widgets/dynamicWidgets.test.ts = 23 passed.

…6508)

Dynamic-combo child widgets keep their edited values when their option
is toggled away and back. Values remain isolated per option, including
an active nested combo rebuilt by its parent.

The restore now runs after the input-layout transaction commits and
resolves each current widget by name before assigning its cached value.
This avoids writing to detached descendants when restoring a nested
combo synchronously recreates its children.

The redundant `getNodeOnPos` test was removed because
`arrangeForLegacyRender.test.ts` already covers default hit testing
against authoritative z-order. The load regression also restores
`LiteGraph.namedValuesRestore` after each test.

- `pnpm test:unit src/core/graph/widgets/dynamicWidgets.test.ts
src/renderer/core/canvas/litegraph/arrangeForLegacyRender.test.ts`
- `pnpm typecheck`
- Changed-file ESLint and oxfmt
- Diff-scoped Fallow audit

Fixes #16006.

---------

Co-authored-by: Amp <amp@ampcode.com>
(cherry picked from commit 3e43e3e)
@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned) labels Sep 9, 2026
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 3ec52d48-1695-43e5-8e54-29c48416101d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1920 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1899 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/09/2026, 11:16:41 PM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.4 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.4 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.5 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.1 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.3 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 89.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.7 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.4 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.6 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 150ms TBT · 82.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.7 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.8 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 55ms TBT · 168.8 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 426ms TBT · 173.7 MB heap
vue-zoom-out-idle: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 176.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.7 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 565ms
canvas-idle: script duration 11ms
canvas-idle: TBT 0ms
canvas-idle: heap used 67.4 MB
canvas-idle: DOM nodes -280
canvas-idle: event listeners -159
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 42ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 77
canvas-mouse-sweep: task duration 923ms
canvas-mouse-sweep: script duration 167ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 65.4 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -161
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 386ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.5 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 20
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 459ms
dom-widget-clipping: script duration 163ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.3 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 621ms
large-graph-idle: script duration 34ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.1 MB
large-graph-idle: DOM nodes -270
large-graph-idle: event listeners -142
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 9ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 63
large-graph-pan: task duration 1676ms
large-graph-pan: script duration 824ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 83.9 MB
large-graph-pan: DOM nodes -138
large-graph-pan: event listeners 6
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1779ms
large-graph-zoom: script duration 799ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 74.3 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1993ms
legacy-node-drag: script duration 969ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 89.1 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 617ms
minimap-idle: script duration 36ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.7 MB
minimap-idle: DOM nodes -270
minimap-idle: event listeners -158
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 12ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 423ms
subgraph-dom-widget-clipping: script duration 145ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 82.4 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 7
subgraph-idle: task duration 511ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 69.4 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -205
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 41ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 79
subgraph-mouse-sweep: task duration 881ms
subgraph-mouse-sweep: script duration 118ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 67.6 MB
subgraph-mouse-sweep: DOM nodes -293
subgraph-mouse-sweep: event listeners -190
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 996ms
subgraph-transition-enter: script duration 31ms
subgraph-transition-enter: TBT 150ms
subgraph-transition-enter: heap used 82.6 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 35ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 246
viewport-pan-sweep: task duration 6032ms
viewport-pan-sweep: script duration 2764ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 83.7 MB
viewport-pan-sweep: DOM nodes -268
viewport-pan-sweep: event listeners -126
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17037ms
vue-large-graph-idle: script duration 293ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 171.8 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7475
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 20ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 168
vue-large-graph-pan: task duration 21008ms
vue-large-graph-pan: script duration 953ms
vue-large-graph-pan: TBT 55ms
vue-large-graph-pan: heap used 168.8 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7470
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 80ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6200ms
vue-node-resize-workload: script duration 118ms
vue-node-resize-workload: TBT 426ms
vue-node-resize-workload: heap used 173.7 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7471
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8639ms
vue-zoom-out-idle: script duration 165ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 176.1 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -12
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 18ms
workflow-execution: layout count 3
workflow-execution: style recalc count 8
workflow-execution: task duration 85ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.7 MB
workflow-execution: DOM nodes 163
workflow-execution: event listeners 44
Raw data
{
  "timestamp": "2026-09-09T23:26:14.127Z",
  "gitSha": "b76d02ef161813bfb91b289f2e1c12c3a2444e4a",
  "branch": "christian-byrne/backport-16508-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2028.634000000011,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.422,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 586.816,
      "heapDeltaBytes": 6698812,
      "heapUsedBytes": 75872656,
      "domNodes": -281,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 10.839000000000002,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2037.3400000000856,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.66,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 543.3430000000001,
      "heapDeltaBytes": -4702632,
      "heapUsedBytes": 65409464,
      "domNodes": -279,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 10.266,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1903.2809999999927,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 40.964,
      "layouts": 14,
      "layoutDurationMs": 4.209,
      "taskDurationMs": 920.8,
      "heapDeltaBytes": 3591136,
      "heapUsedBytes": 74601340,
      "domNodes": -282,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 167.78500000000003,
      "eventListeners": -178,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1883.3190000000286,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 43.107,
      "layouts": 14,
      "layoutDurationMs": 4.798,
      "taskDurationMs": 925.4,
      "heapDeltaBytes": -8343028,
      "heapUsedBytes": 62526996,
      "domNodes": -278,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 166.624,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1755.2459999999428,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 20.152000000000005,
      "layouts": 6,
      "layoutDurationMs": 1.31,
      "taskDurationMs": 397.4529999999999,
      "heapDeltaBytes": 4492568,
      "heapUsedBytes": 74565360,
      "domNodes": 78,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 12.354999999999999,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1756.9130000000541,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.121999999999996,
      "layouts": 6,
      "layoutDurationMs": 1.013,
      "taskDurationMs": 373.673,
      "heapDeltaBytes": 4716092,
      "heapUsedBytes": 75312944,
      "domNodes": 77,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 11.885,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 709.337000000005,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.9,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 459.281,
      "heapDeltaBytes": -7933228,
      "heapUsedBytes": 62985636,
      "domNodes": 16,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 165.002,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 708.9569999999412,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 459.125,
      "heapDeltaBytes": 18768400,
      "heapUsedBytes": 88602344,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 161.8,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2038.7920000000577,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.5069999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 614.931,
      "heapDeltaBytes": -14663744,
      "heapUsedBytes": 87679500,
      "domNodes": -269,
      "jsHeapTotalBytes": -2162688,
      "scriptDurationMs": 34.895999999999994,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2054.3819999999187,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.295,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 627.4789999999999,
      "heapDeltaBytes": 9928876,
      "heapUsedBytes": 86558256,
      "domNodes": -270,
      "jsHeapTotalBytes": -2985984,
      "scriptDurationMs": 33.736000000000004,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2377.8259999999136,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 7.944999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1684.2630000000001,
      "heapDeltaBytes": 22043068,
      "heapUsedBytes": 88287620,
      "domNodes": -279,
      "jsHeapTotalBytes": 487424,
      "scriptDurationMs": 818.604,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2333.6270000000923,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 9.836,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1666.8120000000001,
      "heapDeltaBytes": 21478520,
      "heapUsedBytes": 87766732,
      "domNodes": 4,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 828.8520000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3604.83499999998,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.319999999999999,
      "layouts": 60,
      "layoutDurationMs": 12.395,
      "taskDurationMs": 1765.792,
      "heapDeltaBytes": 8203696,
      "heapUsedBytes": 75874580,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 801.557,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3722.075000000018,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.367999999999999,
      "layouts": 60,
      "layoutDurationMs": 12.629999999999999,
      "taskDurationMs": 1792.376,
      "heapDeltaBytes": 11771036,
      "heapUsedBytes": 80047424,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 795.8140000000001,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3119.384000000082,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.6599999999999975,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1956.4850000000001,
      "heapDeltaBytes": 25935432,
      "heapUsedBytes": 93646304,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 953.7249999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3184.712999999988,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.693,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2029.1609999999998,
      "heapDeltaBytes": 25435280,
      "heapUsedBytes": 93187756,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 983.8560000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2039.9019999999837,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.699,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 613.142,
      "heapDeltaBytes": 11291208,
      "heapUsedBytes": 88376744,
      "domNodes": -272,
      "jsHeapTotalBytes": -2461696,
      "scriptDurationMs": 34.8,
      "eventListeners": -172,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2037.8860000000714,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.8050000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 620.5980000000001,
      "heapDeltaBytes": 10512372,
      "heapUsedBytes": 87199996,
      "domNodes": -267,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 36.271,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 619.8400000000674,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.982,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 426.658,
      "heapDeltaBytes": 13912772,
      "heapUsedBytes": 86195984,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 146.788,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 595.5940000000055,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.369,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 419.856,
      "heapDeltaBytes": 14283312,
      "heapUsedBytes": 86577708,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 143.30499999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2020.3860000000304,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.976,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 509.591,
      "heapDeltaBytes": 1896816,
      "heapUsedBytes": 67666932,
      "domNodes": -295,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 9.149000000000001,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2008.5450000000264,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.053,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 512.247,
      "heapDeltaBytes": 4799824,
      "heapUsedBytes": 77905140,
      "domNodes": -298,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 8.44,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1742.9200000000264,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 40.37800000000001,
      "layouts": 18,
      "layoutDurationMs": 6.182,
      "taskDurationMs": 883.645,
      "heapDeltaBytes": -12291728,
      "heapUsedBytes": 60651688,
      "domNodes": -292,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 118.90299999999999,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1789.9990000000798,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 40.791,
      "layouts": 18,
      "layoutDurationMs": 5.935,
      "taskDurationMs": 878.4169999999999,
      "heapDeltaBytes": 9247972,
      "heapUsedBytes": 81170972,
      "domNodes": -294,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 116.55399999999999,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1417.6410000000033,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 31.901,
      "layouts": 14,
      "layoutDurationMs": 15.990999999999998,
      "taskDurationMs": 995.63,
      "heapDeltaBytes": -7472808,
      "heapUsedBytes": 86563076,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 31.486,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 150,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8651.045999999951,
      "styleRecalcs": 244,
      "styleRecalcDurationMs": 33.455,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5999.4439999999995,
      "heapDeltaBytes": 23971196,
      "heapUsedBytes": 89481776,
      "domNodes": -270,
      "jsHeapTotalBytes": 192512,
      "scriptDurationMs": 2761.103,
      "eventListeners": -126,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8737.570000000005,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 35.596000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6064.392000000001,
      "heapDeltaBytes": -15966524,
      "heapUsedBytes": 86019124,
      "domNodes": -266,
      "jsHeapTotalBytes": 946176,
      "scriptDurationMs": 2766.365,
      "eventListeners": -126,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17947.94999999999,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17158.451,
      "heapDeltaBytes": -29985500,
      "heapUsedBytes": 180158956,
      "domNodes": -6548,
      "jsHeapTotalBytes": 9687040,
      "scriptDurationMs": 301.651,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17508.125999999946,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16915.558,
      "heapDeltaBytes": -30392360,
      "heapUsedBytes": 180112696,
      "domNodes": -6548,
      "jsHeapTotalBytes": 7589888,
      "scriptDurationMs": 285.303,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21248.769000000037,
      "styleRecalcs": 163,
      "styleRecalcDurationMs": 20.87599999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20970.399999999998,
      "heapDeltaBytes": -16582260,
      "heapUsedBytes": 186990784,
      "domNodes": -6548,
      "jsHeapTotalBytes": 593920,
      "scriptDurationMs": 992.611,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 76,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21324.381000000132,
      "styleRecalcs": 172,
      "styleRecalcDurationMs": 19.618999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21045.859,
      "heapDeltaBytes": -43658468,
      "heapUsedBytes": 166948976,
      "domNodes": -6548,
      "jsHeapTotalBytes": -6991872,
      "scriptDurationMs": 912.4590000000001,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 34,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6236.515999999938,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 80.41599999999998,
      "layouts": 20,
      "layoutDurationMs": 23.01,
      "taskDurationMs": 6146.53,
      "heapDeltaBytes": -21387324,
      "heapUsedBytes": 181887328,
      "domNodes": -6548,
      "jsHeapTotalBytes": 19386368,
      "scriptDurationMs": 117.337,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 388,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6344.395999999961,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 79.66499999999999,
      "layouts": 20,
      "layoutDurationMs": 23.869,
      "taskDurationMs": 6253.29,
      "heapDeltaBytes": -38162308,
      "heapUsedBytes": 182475808,
      "domNodes": -6548,
      "jsHeapTotalBytes": 10227712,
      "scriptDurationMs": 117.75999999999999,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 463,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8961.780999999974,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8607.036,
      "heapDeltaBytes": 23687492,
      "heapUsedBytes": 179831524,
      "domNodes": 0,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 151.49199999999996,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9087.9809999999,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8671.565,
      "heapDeltaBytes": 2920456,
      "heapUsedBytes": 189471356,
      "domNodes": 0,
      "jsHeapTotalBytes": -6029312,
      "scriptDurationMs": 178.00399999999993,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 126.02700000002187,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 21.128999999999998,
      "layouts": 4,
      "layoutDurationMs": 2.164,
      "taskDurationMs": 95.32499999999999,
      "heapDeltaBytes": 3547740,
      "heapUsedBytes": 72051896,
      "domNodes": 220,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 8.193,
      "eventListeners": 55,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 104.25299999997151,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 14.831000000000001,
      "layouts": 2,
      "layoutDurationMs": 1.003,
      "taskDurationMs": 75.459,
      "heapDeltaBytes": 3039236,
      "heapUsedBytes": 72019512,
      "domNodes": 106,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 5.824000000000001,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 49907 74442 67.0% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.4% 1159
src/LGraphNode.ts 69.4% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 8.2% 303
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/LGraph.ts 78.9% 257
src/scripts/app.ts 71.8% 251
src/scripts/pnginfo.ts 21.4% 221

@github-actions
github-actions Bot requested a review from dante01yoon September 9, 2026 23:15
@codecov

codecov Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/core/graph/widgets/dynamicWidgets.ts 96.55% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #17306   +/-   ##
=============================================
  Coverage              ?   82.99%           
=============================================
  Files                 ?     2053           
  Lines                 ?   119708           
  Branches              ?    32785           
=============================================
  Hits                  ?    99346           
  Misses                ?    20182           
  Partials              ?      180           
Flag Coverage Δ
e2e 67.03% <95.83%> (?)
unit 77.55% <96.42%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/core/graph/widgets/dynamicWidgets.ts 89.97% <96.55%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DrJKL
DrJKL enabled auto-merge (squash) September 9, 2026 23:32
@DrJKL
DrJKL merged commit 5ad148c into cloud/1.54 Sep 9, 2026
117 of 120 checks passed
@DrJKL
DrJKL deleted the christian-byrne/backport-16508-cloud-1.54 branch September 9, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants