Skip to content

[backport cloud/1.53] fix: keep edited dynamic-combo child values across option toggles - #17297

Merged
DrJKL merged 1 commit into
cloud/1.53from
christian-byrne/backport-16508-cloud-1.53
Sep 9, 2026
Merged

DrJKL merged 1 commit into
cloud/1.53from
christian-byrne/backport-16508-cloud-1.53

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backport of #16508 to cloud/1.53.

  • Fix: edited dynamic-combo child values now survive option toggles
  • Automated backport failed on a test-file conflict; resolved manually, tests green locally
  • Only custom_nodes_e2e expected red (known upstream source outage, unrelated)
Full context for agent readers

Cherry-pick of merge commit 3e43e3e (#16508, merged by DrJKL 2026-09-09) onto cloud/1.53, with -x trailer.

Conflict was limited to src/core/graph/widgets/dynamicWidgets.test.ts: the release branch has setActivePinia/createTestingPinia setup in beforeEach that main no longer has. Resolution keeps the 1.53 Pinia setup and adds #16508's afterEach restore of LiteGraph.namedValuesRestore (present on 1.53 at LiteGraphGlobal.ts). dynamicWidgets.ts applied cleanly.

Local verification on this branch: pnpm install --frozen-lockfile ok, pnpm typecheck ok, pnpm vitest run src/core/graph/widgets/dynamicWidgets.test.ts 23/23 passed.

The custom_nodes_e2e job fails on every branch because the pinned ComfyUI-Prompt-Combinator commit no longer exists upstream; #17269 quarantines it on main and has not been backported.

…6508)

Dynamic-combo child widgets keep their edited values when their option
is toggled away and back. Values remain isolated per option, including
an active nested combo rebuilt by its parent.

The restore now runs after the input-layout transaction commits and
resolves each current widget by name before assigning its cached value.
This avoids writing to detached descendants when restoring a nested
combo synchronously recreates its children.

The redundant `getNodeOnPos` test was removed because
`arrangeForLegacyRender.test.ts` already covers default hit testing
against authoritative z-order. The load regression also restores
`LiteGraph.namedValuesRestore` after each test.

- `pnpm test:unit src/core/graph/widgets/dynamicWidgets.test.ts
src/renderer/core/canvas/litegraph/arrangeForLegacyRender.test.ts`
- `pnpm typecheck`
- Changed-file ESLint and oxfmt
- Diff-scoped Fallow audit

Fixes #16006.

---------

Co-authored-by: Amp <amp@ampcode.com>
(cherry picked from commit 3e43e3e)
@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned) labels Sep 9, 2026
@github-actions

github-actions Bot commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1892 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1871 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/09/2026, 10:03:48 PM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.4 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.0 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.4 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.5 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.2 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.9 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.9 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 121ms TBT · 82.8 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.3 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.7 MB heap
vue-large-graph-pan: · 54.5 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 202ms TBT · 174.7 MB heap
vue-node-resize-workload: · 54.6 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 395ms TBT · 162.4 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.1 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 513ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 74.2 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -170
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 44ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 80
canvas-mouse-sweep: task duration 944ms
canvas-mouse-sweep: script duration 159ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 59.4 MB
canvas-mouse-sweep: DOM nodes -279
canvas-mouse-sweep: event listeners -155
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 358ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.3 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 455ms
dom-widget-clipping: script duration 161ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.0 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 614ms
large-graph-idle: script duration 35ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.4 MB
large-graph-idle: DOM nodes -269
large-graph-idle: event listeners -169
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 9ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 62
large-graph-pan: task duration 1564ms
large-graph-pan: script duration 766ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 81.6 MB
large-graph-pan: DOM nodes -140
large-graph-pan: event listeners 6
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 14ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 61
large-graph-zoom: task duration 1704ms
large-graph-zoom: script duration 769ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.5 MB
large-graph-zoom: DOM nodes -139
large-graph-zoom: event listeners 8
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 1916ms
legacy-node-drag: script duration 952ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 87.0 MB
legacy-node-drag: DOM nodes 1
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 586ms
minimap-idle: script duration 37ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.2 MB
minimap-idle: DOM nodes -273
minimap-idle: event listeners -76
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 412ms
subgraph-dom-widget-clipping: script duration 142ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.4 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 492ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 59.9 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -200
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 39ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 841ms
subgraph-mouse-sweep: script duration 107ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 65.9 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -217
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 30ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 917ms
subgraph-transition-enter: script duration 29ms
subgraph-transition-enter: TBT 121ms
subgraph-transition-enter: heap used 82.8 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 40ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 5724ms
viewport-pan-sweep: script duration 2634ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 83.3 MB
viewport-pan-sweep: DOM nodes -269
viewport-pan-sweep: event listeners -139
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17988ms
vue-large-graph-idle: script duration 323ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 171.7 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7474
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 24ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 177
vue-large-graph-pan: task duration 23080ms
vue-large-graph-pan: script duration 988ms
vue-large-graph-pan: TBT 202ms
vue-large-graph-pan: heap used 174.7 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7467
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 74ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6477ms
vue-node-resize-workload: script duration 131ms
vue-node-resize-workload: TBT 395ms
vue-node-resize-workload: heap used 162.4 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7469
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 19ms
workflow-execution: layout count 3
workflow-execution: style recalc count 11
workflow-execution: task duration 98ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.1 MB
workflow-execution: DOM nodes 126
workflow-execution: event listeners 62
Raw data
{
  "timestamp": "2026-09-09T22:15:46.565Z",
  "gitSha": "bbe981cb8c5137dca6026004f48c02a5d5583e46",
  "branch": "christian-byrne/backport-16508-cloud-1.53",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2038.012999999978,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.187000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 496.9819999999999,
      "heapDeltaBytes": 2353208,
      "heapUsedBytes": 72738952,
      "domNodes": -282,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 8.453999999999999,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2056.607999999983,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.347000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 528.1779999999999,
      "heapDeltaBytes": 13045508,
      "heapUsedBytes": 82773396,
      "domNodes": -280,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 8.911,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2005.3819999999973,
      "styleRecalcs": 81,
      "styleRecalcDurationMs": 48.493,
      "layouts": 14,
      "layoutDurationMs": 4.809,
      "taskDurationMs": 1001.6239999999998,
      "heapDeltaBytes": -7219404,
      "heapUsedBytes": 62787864,
      "domNodes": -277,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 167.903,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1890.6709999999975,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 39.272,
      "layouts": 14,
      "layoutDurationMs": 4.802,
      "taskDurationMs": 885.388,
      "heapDeltaBytes": -8791408,
      "heapUsedBytes": 61700408,
      "domNodes": -281,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 149.908,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1721.556000000021,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 18.193,
      "layouts": 6,
      "layoutDurationMs": 1.207,
      "taskDurationMs": 363.677,
      "heapDeltaBytes": 4421396,
      "heapUsedBytes": 74943168,
      "domNodes": 78,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 12.041,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1721.3010000000395,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.471,
      "layouts": 6,
      "layoutDurationMs": 1.2019999999999997,
      "taskDurationMs": 352.61299999999994,
      "heapDeltaBytes": 4463024,
      "heapUsedBytes": 74648128,
      "domNodes": 78,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 11.360999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 666.0479999999893,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.920000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 458.1649999999999,
      "heapDeltaBytes": 18191012,
      "heapUsedBytes": 88481376,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 165.76000000000002,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 688.8440000000173,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.017,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 452.31300000000005,
      "heapDeltaBytes": -8121952,
      "heapUsedBytes": 62431904,
      "domNodes": 18,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 157.072,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2041.0959999999818,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.775000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 616.3369999999999,
      "heapDeltaBytes": 10606680,
      "heapUsedBytes": 86305400,
      "domNodes": -271,
      "jsHeapTotalBytes": -1916928,
      "scriptDurationMs": 32.236999999999995,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2044.5700000000215,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 4.835000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 612.475,
      "heapDeltaBytes": -13645236,
      "heapUsedBytes": 86459484,
      "domNodes": -266,
      "jsHeapTotalBytes": -1093632,
      "scriptDurationMs": 37.079,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2168.098999999984,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 9.146,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1554.5079999999998,
      "heapDeltaBytes": 17994700,
      "heapUsedBytes": 84114292,
      "domNodes": 0,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 765.9390000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2213.3179999999584,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 9.324999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1572.973,
      "heapDeltaBytes": 20841528,
      "heapUsedBytes": 87019136,
      "domNodes": -279,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 765.102,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3594.6119999999837,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 11.26,
      "layouts": 60,
      "layoutDurationMs": 13.584000000000003,
      "taskDurationMs": 1718.5590000000002,
      "heapDeltaBytes": 8495096,
      "heapUsedBytes": 75469468,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 769.401,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3525.0100000000657,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 11.819999999999997,
      "layouts": 60,
      "layoutDurationMs": 13.558999999999997,
      "taskDurationMs": 1689.2959999999998,
      "heapDeltaBytes": 9571752,
      "heapUsedBytes": 76547476,
      "domNodes": -277,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 769.473,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3079.750000000047,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.315999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1911.406,
      "heapDeltaBytes": 26076316,
      "heapUsedBytes": 93018656,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 936.831,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3103.024000000005,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 6.391000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1920.9239999999998,
      "heapDeltaBytes": 21916904,
      "heapUsedBytes": 89506860,
      "domNodes": 2,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 967.588,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2019.869999999969,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.8509999999999984,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 559.1379999999999,
      "heapDeltaBytes": 21845768,
      "heapUsedBytes": 87487488,
      "domNodes": -276,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 37.562999999999995,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2042.092000000025,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.583,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 613.7669999999999,
      "heapDeltaBytes": -15520276,
      "heapUsedBytes": 87072608,
      "domNodes": -270,
      "jsHeapTotalBytes": -1617920,
      "scriptDurationMs": 36.767,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 590.7889999999725,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.831999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 414.064,
      "heapDeltaBytes": 14794908,
      "heapUsedBytes": 87530716,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 141.918,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 618.5440000000426,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.322999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 409.51099999999997,
      "heapDeltaBytes": 14867484,
      "heapUsedBytes": 87466124,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 141.224,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.5240000000326,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.232,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 487.46900000000005,
      "heapDeltaBytes": -11093640,
      "heapUsedBytes": 61130192,
      "domNodes": -296,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 7.861999999999999,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2039.749000000029,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.577,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 496.57099999999997,
      "heapDeltaBytes": -8133672,
      "heapUsedBytes": 64493060,
      "domNodes": -296,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 8.273,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1766.2690000000225,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 38.538,
      "layouts": 18,
      "layoutDurationMs": 5.332999999999999,
      "taskDurationMs": 821.16,
      "heapDeltaBytes": -9892428,
      "heapUsedBytes": 62645304,
      "domNodes": -295,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 103.61,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1774.3619999999964,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 39.975,
      "layouts": 18,
      "layoutDurationMs": 6.241,
      "taskDurationMs": 861.06,
      "heapDeltaBytes": 2853776,
      "heapUsedBytes": 75504132,
      "domNodes": -295,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 110.816,
      "eventListeners": -233,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1384.1770000000224,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 30.141000000000002,
      "layouts": 14,
      "layoutDurationMs": 14.105000000000002,
      "taskDurationMs": 917.0600000000002,
      "heapDeltaBytes": -5540340,
      "heapUsedBytes": 86851620,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 29.130000000000003,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 121,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8399.282999999969,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 41.309,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5871.0380000000005,
      "heapDeltaBytes": -14780124,
      "heapUsedBytes": 86160612,
      "domNodes": -266,
      "jsHeapTotalBytes": -1130496,
      "scriptDurationMs": 2682.4220000000005,
      "eventListeners": -139,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8217.085999999996,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 38.29900000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5576.544,
      "heapDeltaBytes": 23562192,
      "heapUsedBytes": 88594036,
      "domNodes": -271,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 2586.0879999999997,
      "eventListeners": -139,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18494.165000000008,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17975.333,
      "heapDeltaBytes": -19200108,
      "heapUsedBytes": 190447264,
      "domNodes": -6548,
      "jsHeapTotalBytes": -3571712,
      "scriptDurationMs": 311.964,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18474.339999999982,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18000.874,
      "heapDeltaBytes": -34572936,
      "heapUsedBytes": 169683160,
      "domNodes": -6548,
      "jsHeapTotalBytes": -7016448,
      "scriptDurationMs": 334.65500000000003,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 23075.09399999998,
      "styleRecalcs": 173,
      "styleRecalcDurationMs": 24.43899999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22840.061999999998,
      "heapDeltaBytes": -23564448,
      "heapUsedBytes": 176130060,
      "domNodes": -6548,
      "jsHeapTotalBytes": -8146944,
      "scriptDurationMs": 985.777,
      "eventListeners": -7467,
      "totalBlockingTimeMs": 230,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.700000000004366
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 23707.08000000002,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 22.62000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 23319.101,
      "heapDeltaBytes": -19620124,
      "heapUsedBytes": 190194796,
      "domNodes": -6548,
      "jsHeapTotalBytes": -5963776,
      "scriptDurationMs": 989.918,
      "eventListeners": -7467,
      "totalBlockingTimeMs": 173,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.700000000004366
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6633.4659999999985,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 73.888,
      "layouts": 20,
      "layoutDurationMs": 24.482000000000003,
      "taskDurationMs": 6555.5599999999995,
      "heapDeltaBytes": -32476948,
      "heapUsedBytes": 177611348,
      "domNodes": -6548,
      "jsHeapTotalBytes": 6164480,
      "scriptDurationMs": 121.57600000000001,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 374,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6493.296999999984,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 74.23199999999997,
      "layouts": 20,
      "layoutDurationMs": 24.498000000000005,
      "taskDurationMs": 6399.177,
      "heapDeltaBytes": -40254816,
      "heapUsedBytes": 163064440,
      "domNodes": -6548,
      "jsHeapTotalBytes": 9957376,
      "scriptDurationMs": 140.981,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 416,
      "frameDurationMs": 18.886666666666617,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "workflow-execution",
      "durationMs": 112.34600000000228,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 15.796000000000001,
      "layouts": 2,
      "layoutDurationMs": 1.4420000000000002,
      "taskDurationMs": 81.56600000000002,
      "heapDeltaBytes": 3128372,
      "heapUsedBytes": 71486296,
      "domNodes": 129,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.642000000000002,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 472.4469999999883,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 22.194000000000006,
      "layouts": 3,
      "layoutDurationMs": 1.0030000000000001,
      "taskDurationMs": 114.63499999999999,
      "heapDeltaBytes": 5058316,
      "heapUsedBytes": 73397868,
      "domNodes": 123,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.949,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 48153 70697 68.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.4% 396
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.2% 303
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/LGraph.ts 78.8% 255
src/scripts/app.ts 71.7% 247
src/scripts/pnginfo.ts 21.4% 221
src/stores/assetsStore.ts 44.7% 204

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 33b2a81e-7aa9-4495-9732-b42f1e3617ce

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions
github-actions Bot requested a review from dante01yoon September 9, 2026 22:02
@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 9, 2026
@DrJKL
DrJKL enabled auto-merge (squash) September 9, 2026 22:18
@codecov

codecov Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/core/graph/widgets/dynamicWidgets.ts 96.55% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.53   #17297   +/-   ##
=============================================
  Coverage              ?   83.35%           
=============================================
  Files                 ?     2025           
  Lines                 ?   117297           
  Branches              ?    33408           
=============================================
  Hits                  ?    97775           
  Misses                ?    19164           
  Partials              ?      358           
Flag Coverage Δ
e2e 66.61% <96.00%> (?)
unit 76.71% <96.42%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/core/graph/widgets/dynamicWidgets.ts 92.03% <96.55%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DrJKL
DrJKL merged commit a337052 into cloud/1.53 Sep 9, 2026
124 checks passed
@DrJKL
DrJKL deleted the christian-byrne/backport-16508-cloud-1.53 branch September 9, 2026 22:20
DrJKL pushed a commit that referenced this pull request Sep 9, 2026
…oss option toggles (#17306)

Backport of merged fix
#16508 to the
`cloud/1.54` release branch.

- Keeps user-edited dynamic-combo child values when the parent option is
toggled away and back.
- One test-file conflict in the imports/setup header (both sides added
setup helpers); resolved by keeping both. Typecheck and
`dynamicWidgets.test.ts` (23 passed) are green locally.
- Fix merged to main after the 1.54 branches were cut; 1.53 backports
already merged.

<details><summary>Full context for agent readers</summary>

Source: #16508 (merge
commit `3e43e3e7a51e77c93185feb6a499f45fb939b7f8`). 1.53 backports:
#17296 and
#17297 (merged).
Manual cherry-pick opened under Christian's standing backport
authorization (bbc #520 answer 2).

Files: `src/core/graph/widgets/dynamicWidgets.ts`,
`src/core/graph/widgets/dynamicWidgets.test.ts`.

Conflict detail: `dynamicWidgets.test.ts` header. Branch HEAD had pinia
imports plus `setActivePinia` in `beforeEach`; the cherry-picked commit
added an `afterEach` import and an `afterEach` that restores
`LiteGraph.namedValuesRestore`. Both hunks were kept; no test logic was
altered.

Local verification: `CI=true pnpm install --frozen-lockfile`, pre-commit
(oxfmt/oxlint/eslint + `pnpm typecheck`) passed, `pnpm vitest run
src/core/graph/widgets/dynamicWidgets.test.ts` = 23 passed.

<!-- authored-by:agent w3-520-followup -->
</details>

Co-authored-by: Amp <amp@ampcode.com>
DrJKL pushed a commit that referenced this pull request Sep 9, 2026
…ss option toggles (#17305)

Backport of merged fix
#16508 to the
`core/1.54` release branch.

- Keeps user-edited dynamic-combo child values when the parent option is
toggled away and back.
- One test-file conflict in the imports/setup header (both sides added
setup helpers); resolved by keeping both. Typecheck and
`dynamicWidgets.test.ts` (23 passed) are green locally.
- Fix merged to main after the 1.54 branches were cut; 1.53 backports
already merged.

<details><summary>Full context for agent readers</summary>

Source: #16508 (merge
commit `3e43e3e7a51e77c93185feb6a499f45fb939b7f8`). 1.53 backports:
#17296 and
#17297 (merged).
Manual cherry-pick opened under Christian's standing backport
authorization (bbc #520 answer 2).

Files: `src/core/graph/widgets/dynamicWidgets.ts`,
`src/core/graph/widgets/dynamicWidgets.test.ts`.

Conflict detail: `dynamicWidgets.test.ts` header. Branch HEAD had pinia
imports plus `setActivePinia` in `beforeEach`; the cherry-picked commit
added an `afterEach` import and an `afterEach` that restores
`LiteGraph.namedValuesRestore`. Both hunks were kept; no test logic was
altered.

Local verification: `CI=true pnpm install --frozen-lockfile`, pre-commit
(oxfmt/oxlint/eslint + `pnpm typecheck`) passed, `pnpm vitest run
src/core/graph/widgets/dynamicWidgets.test.ts` = 23 passed.

<!-- authored-by:agent w3-520-followup -->
</details>

Co-authored-by: Amp <amp@ampcode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned) risk:R2 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants