Repository navigation
[backport core/1.53] fix: keep edited dynamic-combo child values across option toggles - #17296
Conversation
…6508) Dynamic-combo child widgets keep their edited values when their option is toggled away and back. Values remain isolated per option, including an active nested combo rebuilt by its parent. The restore now runs after the input-layout transaction commits and resolves each current widget by name before assigning its cached value. This avoids writing to detached descendants when restoring a nested combo synchronously recreates its children. The redundant `getNodeOnPos` test was removed because `arrangeForLegacyRender.test.ts` already covers default hit testing against authoritative z-order. The load regression also restores `LiteGraph.namedValuesRestore` after each test. - `pnpm test:unit src/core/graph/widgets/dynamicWidgets.test.ts src/renderer/core/canvas/litegraph/arrangeForLegacyRender.test.ts` - `pnpm typecheck` - Changed-file ESLint and oxfmt - Diff-scoped Fallow audit Fixes #16006. --------- Co-authored-by: Amp <amp@ampcode.com> (cherry picked from commit 3e43e3e)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1890 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-09T22:14:23.228Z",
"gitSha": "125f2e4f577c9568b5591b03fbd23c30c629085d",
"branch": "christian-byrne/backport-16508-core-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2020.934000000011,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.836,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.747,
"heapDeltaBytes": -216244,
"heapUsedBytes": 68453776,
"domNodes": -279,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.866999999999999,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2016.5399999999636,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.6099999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.15999999999997,
"heapDeltaBytes": -10241580,
"heapUsedBytes": 59831324,
"domNodes": -283,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.640999999999998,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1758.925999999974,
"styleRecalcs": 76,
"styleRecalcDurationMs": 29.671,
"layouts": 14,
"layoutDurationMs": 4.093,
"taskDurationMs": 775.987,
"heapDeltaBytes": 1271096,
"heapUsedBytes": 70853796,
"domNodes": -280,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 129.327,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1760.263000000009,
"styleRecalcs": 76,
"styleRecalcDurationMs": 31.715,
"layouts": 14,
"layoutDurationMs": 4.3839999999999995,
"taskDurationMs": 719.2389999999999,
"heapDeltaBytes": 1222304,
"heapUsedBytes": 70139480,
"domNodes": -280,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 122.47300000000001,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1658.202000000017,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.555000000000001,
"layouts": 6,
"layoutDurationMs": 0.935,
"taskDurationMs": 295.331,
"heapDeltaBytes": 4415476,
"heapUsedBytes": 74922084,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.924999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1689.3390000000181,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.689999999999998,
"layouts": 6,
"layoutDurationMs": 1.029,
"taskDurationMs": 324.347,
"heapDeltaBytes": 4497832,
"heapUsedBytes": 74955364,
"domNodes": 78,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 11.541,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 550.9690000000091,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.595999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.81600000000003,
"heapDeltaBytes": -8081616,
"heapUsedBytes": 62417116,
"domNodes": 20,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 136.22600000000003,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 559.9869999999783,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.156999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 377.397,
"heapDeltaBytes": 17525608,
"heapUsedBytes": 87839916,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 126.784,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2031.893000000025,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.980999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.768,
"heapDeltaBytes": -13519716,
"heapUsedBytes": 87146780,
"domNodes": -265,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 31.269,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2039.0199999999368,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.493000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.36,
"heapDeltaBytes": -14134000,
"heapUsedBytes": 86502904,
"domNodes": -267,
"jsHeapTotalBytes": -1093632,
"scriptDurationMs": 29.316000000000003,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2137.0600000000195,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.386,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1260.176,
"heapDeltaBytes": 18590864,
"heapUsedBytes": 84488612,
"domNodes": -274,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 608.065,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2126.0750000000144,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.314,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1320.309,
"heapDeltaBytes": -16510684,
"heapUsedBytes": 84594056,
"domNodes": -265,
"jsHeapTotalBytes": -868352,
"scriptDurationMs": 609.896,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3116.9229999999857,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.432,
"layouts": 60,
"layoutDurationMs": 11.484000000000002,
"taskDurationMs": 1361.777,
"heapDeltaBytes": 8197228,
"heapUsedBytes": 75509328,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 598.19,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3194.8059999999714,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.121999999999998,
"layouts": 60,
"layoutDurationMs": 11.874,
"taskDurationMs": 1418.369,
"heapDeltaBytes": 9883940,
"heapUsedBytes": 76622752,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 621.6039999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2291.0210000000006,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.3309999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1533.8350000000003,
"heapDeltaBytes": 13902960,
"heapUsedBytes": 80857980,
"domNodes": 4,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 753.425,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2375.177000000008,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.7700000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1621.7379999999996,
"heapDeltaBytes": 13604804,
"heapUsedBytes": 81286276,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 787.344,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2002.439000000038,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.341000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.338,
"heapDeltaBytes": 22128044,
"heapUsedBytes": 87259348,
"domNodes": -270,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.602000000000004,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2026.632999999947,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.6109999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 522.769,
"heapDeltaBytes": 10534952,
"heapUsedBytes": 87062360,
"domNodes": -273,
"jsHeapTotalBytes": -2179072,
"scriptDurationMs": 29.189,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 571.2429999999813,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.389999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.186,
"heapDeltaBytes": 14802552,
"heapUsedBytes": 87482396,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 120.636,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 514.7230000000036,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.554,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 325.91,
"heapDeltaBytes": 15048628,
"heapUsedBytes": 86898748,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 111.93499999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2002.4030000000153,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.441999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.293,
"heapDeltaBytes": -9901096,
"heapUsedBytes": 62460680,
"domNodes": -293,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.384999999999999,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.7590000000546,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.7010000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.73299999999995,
"heapDeltaBytes": 2926780,
"heapUsedBytes": 75785252,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.028000000000001,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.3360000000034,
"styleRecalcs": 77,
"styleRecalcDurationMs": 29.989,
"layouts": 18,
"layoutDurationMs": 4.35,
"taskDurationMs": 704.148,
"heapDeltaBytes": 2691652,
"heapUsedBytes": 75503836,
"domNodes": -297,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 92.45700000000001,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.7840000000742,
"styleRecalcs": 78,
"styleRecalcDurationMs": 31.319,
"layouts": 18,
"layoutDurationMs": 4.590000000000001,
"taskDurationMs": 693.2,
"heapDeltaBytes": 1198696,
"heapUsedBytes": 73963368,
"domNodes": -295,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 88.825,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 949.8310000000174,
"styleRecalcs": 20,
"styleRecalcDurationMs": 25.522000000000002,
"layouts": 16,
"layoutDurationMs": 11.823000000000002,
"taskDurationMs": 735.859,
"heapDeltaBytes": -7357444,
"heapUsedBytes": 85987132,
"domNodes": 13751,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 23.946,
"eventListeners": 2381,
"totalBlockingTimeMs": 92,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8313.607999999987,
"styleRecalcs": 248,
"styleRecalcDurationMs": 36.818,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4686.637,
"heapDeltaBytes": 9048628,
"heapUsedBytes": 84448460,
"domNodes": -270,
"jsHeapTotalBytes": 667648,
"scriptDurationMs": 2093.204,
"eventListeners": -165,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8400.164000000019,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.580000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4774.98,
"heapDeltaBytes": 23657076,
"heapUsedBytes": 88504620,
"domNodes": -265,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 2119.199,
"eventListeners": -135,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 15173.113000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14750.238,
"heapDeltaBytes": -39279752,
"heapUsedBytes": 176801032,
"domNodes": -6548,
"jsHeapTotalBytes": -2789376,
"scriptDurationMs": 233.67700000000002,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15380.113000000052,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14764.341999999999,
"heapDeltaBytes": -33648964,
"heapUsedBytes": 176296244,
"domNodes": -6548,
"jsHeapTotalBytes": 278528,
"scriptDurationMs": 229.957,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 17569.676000000072,
"styleRecalcs": 133,
"styleRecalcDurationMs": 15.60599999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17256.751,
"heapDeltaBytes": -22185612,
"heapUsedBytes": 179983076,
"domNodes": -6548,
"jsHeapTotalBytes": 1875968,
"scriptDurationMs": 742.278,
"eventListeners": -7471,
"totalBlockingTimeMs": 14,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 18056.76100000005,
"styleRecalcs": 129,
"styleRecalcDurationMs": 17.955,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17839.163000000004,
"heapDeltaBytes": -23099848,
"heapUsedBytes": 183807764,
"domNodes": -6548,
"jsHeapTotalBytes": 1789952,
"scriptDurationMs": 800.846,
"eventListeners": -7471,
"totalBlockingTimeMs": 44,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5327.307000000019,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.45300000000003,
"layouts": 20,
"layoutDurationMs": 21.002999999999993,
"taskDurationMs": 5265.553000000001,
"heapDeltaBytes": -28391220,
"heapUsedBytes": 181824660,
"domNodes": -6548,
"jsHeapTotalBytes": 12943360,
"scriptDurationMs": 90.775,
"eventListeners": -7471,
"totalBlockingTimeMs": 245,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5538.635999999997,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.102,
"layouts": 20,
"layoutDurationMs": 36.367999999999995,
"taskDurationMs": 5513.962,
"heapDeltaBytes": -34390276,
"heapUsedBytes": 174771736,
"domNodes": -6548,
"jsHeapTotalBytes": 6057984,
"scriptDurationMs": 133.589,
"eventListeners": -7471,
"totalBlockingTimeMs": 376,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "workflow-execution",
"durationMs": 89.7139999999581,
"styleRecalcs": 7,
"styleRecalcDurationMs": 16.604,
"layouts": 2,
"layoutDurationMs": 1.016,
"taskDurationMs": 67.987,
"heapDeltaBytes": 3163960,
"heapUsedBytes": 70511336,
"domNodes": 126,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 7.777000000000001,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 96.3289999999688,
"styleRecalcs": 6,
"styleRecalcDurationMs": 13.561,
"layouts": 3,
"layoutDurationMs": 1.542,
"taskDurationMs": 61.76100000000001,
"heapDeltaBytes": 3027788,
"heapUsedBytes": 70785088,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 3.9569999999999985,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.53 #17296 +/- ##
==========================================
Coverage 83.33% 83.34%
==========================================
Files 2025 2025
Lines 117215 117301 +86
Branches 32524 32548 +24
==========================================
+ Hits 97683 97761 +78
- Misses 19172 19182 +10
+ Partials 360 358 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 33 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…oss option toggles (#17306) Backport of merged fix #16508 to the `cloud/1.54` release branch. - Keeps user-edited dynamic-combo child values when the parent option is toggled away and back. - One test-file conflict in the imports/setup header (both sides added setup helpers); resolved by keeping both. Typecheck and `dynamicWidgets.test.ts` (23 passed) are green locally. - Fix merged to main after the 1.54 branches were cut; 1.53 backports already merged. <details><summary>Full context for agent readers</summary> Source: #16508 (merge commit `3e43e3e7a51e77c93185feb6a499f45fb939b7f8`). 1.53 backports: #17296 and #17297 (merged). Manual cherry-pick opened under Christian's standing backport authorization (bbc #520 answer 2). Files: `src/core/graph/widgets/dynamicWidgets.ts`, `src/core/graph/widgets/dynamicWidgets.test.ts`. Conflict detail: `dynamicWidgets.test.ts` header. Branch HEAD had pinia imports plus `setActivePinia` in `beforeEach`; the cherry-picked commit added an `afterEach` import and an `afterEach` that restores `LiteGraph.namedValuesRestore`. Both hunks were kept; no test logic was altered. Local verification: `CI=true pnpm install --frozen-lockfile`, pre-commit (oxfmt/oxlint/eslint + `pnpm typecheck`) passed, `pnpm vitest run src/core/graph/widgets/dynamicWidgets.test.ts` = 23 passed. <!-- authored-by:agent w3-520-followup --> </details> Co-authored-by: Amp <amp@ampcode.com>
…ss option toggles (#17305) Backport of merged fix #16508 to the `core/1.54` release branch. - Keeps user-edited dynamic-combo child values when the parent option is toggled away and back. - One test-file conflict in the imports/setup header (both sides added setup helpers); resolved by keeping both. Typecheck and `dynamicWidgets.test.ts` (23 passed) are green locally. - Fix merged to main after the 1.54 branches were cut; 1.53 backports already merged. <details><summary>Full context for agent readers</summary> Source: #16508 (merge commit `3e43e3e7a51e77c93185feb6a499f45fb939b7f8`). 1.53 backports: #17296 and #17297 (merged). Manual cherry-pick opened under Christian's standing backport authorization (bbc #520 answer 2). Files: `src/core/graph/widgets/dynamicWidgets.ts`, `src/core/graph/widgets/dynamicWidgets.test.ts`. Conflict detail: `dynamicWidgets.test.ts` header. Branch HEAD had pinia imports plus `setActivePinia` in `beforeEach`; the cherry-picked commit added an `afterEach` import and an `afterEach` that restores `LiteGraph.namedValuesRestore`. Both hunks were kept; no test logic was altered. Local verification: `CI=true pnpm install --frozen-lockfile`, pre-commit (oxfmt/oxlint/eslint + `pnpm typecheck`) passed, `pnpm vitest run src/core/graph/widgets/dynamicWidgets.test.ts` = 23 passed. <!-- authored-by:agent w3-520-followup --> </details> Co-authored-by: Amp <amp@ampcode.com>
Backport of #16508 to
core/1.53.custom_nodes_e2eexpected red (known upstream source outage, unrelated)Full context for agent readers
Cherry-pick of merge commit 3e43e3e (#16508, merged by DrJKL 2026-09-09) onto
core/1.53, with-xtrailer.Conflict was limited to
src/core/graph/widgets/dynamicWidgets.test.ts: the release branch hassetActivePinia/createTestingPiniasetup inbeforeEachthat main no longer has. Resolution keeps the 1.53 Pinia setup and adds #16508'safterEachrestore ofLiteGraph.namedValuesRestore(present on 1.53 atLiteGraphGlobal.ts).dynamicWidgets.tsapplied cleanly.Local verification on this branch:
pnpm install --frozen-lockfileok,pnpm typecheckok,pnpm vitest run src/core/graph/widgets/dynamicWidgets.test.ts23/23 passed.The
custom_nodes_e2ejob fails on every branch because the pinnedComfyUI-Prompt-Combinatorcommit no longer exists upstream; #17269 quarantines it on main and has not been backported.