Repository navigation
[backport core/1.54] fix: keep edited dynamic-combo child values across option toggles - #17305
Conversation
…6508) Dynamic-combo child widgets keep their edited values when their option is toggled away and back. Values remain isolated per option, including an active nested combo rebuilt by its parent. The restore now runs after the input-layout transaction commits and resolves each current widget by name before assigning its cached value. This avoids writing to detached descendants when restoring a nested combo synchronously recreates its children. The redundant `getNodeOnPos` test was removed because `arrangeForLegacyRender.test.ts` already covers default hit testing against authoritative z-order. The load regression also restores `LiteGraph.namedValuesRestore` after each test. - `pnpm test:unit src/core/graph/widgets/dynamicWidgets.test.ts src/renderer/core/canvas/litegraph/arrangeForLegacyRender.test.ts` - `pnpm typecheck` - Changed-file ESLint and oxfmt - Diff-scoped Fallow audit Fixes #16006. --------- Co-authored-by: Amp <amp@ampcode.com> (cherry picked from commit 3e43e3e)
🎭 Playwright: ✅ 1920 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-09T23:26:17.429Z",
"gitSha": "4c440715a2f63c25ca30a4cf8e2e256e5cc7f85f",
"branch": "christian-byrne/backport-16508-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2110.783000000083,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.383999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 681.025,
"heapDeltaBytes": -5757632,
"heapUsedBytes": 63134600,
"domNodes": -277,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 17.486,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2035.1020000000517,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.827,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.8069999999999,
"heapDeltaBytes": -12159356,
"heapUsedBytes": 58336612,
"domNodes": -282,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 11.551000000000002,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1909.4010000000026,
"styleRecalcs": 79,
"styleRecalcDurationMs": 43.919,
"layouts": 14,
"layoutDurationMs": 4.931,
"taskDurationMs": 976.4999999999999,
"heapDeltaBytes": -8822080,
"heapUsedBytes": 61638360,
"domNodes": -279,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 163.595,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1872.7930000000015,
"styleRecalcs": 77,
"styleRecalcDurationMs": 42.125,
"layouts": 14,
"layoutDurationMs": 4.926,
"taskDurationMs": 880.992,
"heapDeltaBytes": 24519228,
"heapUsedBytes": 89507652,
"domNodes": 61,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 157.26100000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.9059999999527,
"styleRecalcs": 33,
"styleRecalcDurationMs": 21.17,
"layouts": 6,
"layoutDurationMs": 1.372,
"taskDurationMs": 417.86600000000004,
"heapDeltaBytes": 5053892,
"heapUsedBytes": 75945236,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 15.421999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1750.6100000000515,
"styleRecalcs": 32,
"styleRecalcDurationMs": 20.32,
"layouts": 6,
"layoutDurationMs": 1.2339999999999998,
"taskDurationMs": 388.50600000000003,
"heapDeltaBytes": 5051104,
"heapUsedBytes": 75648616,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.447,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 711.6530000000694,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.956000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.77000000000004,
"heapDeltaBytes": -7849684,
"heapUsedBytes": 63049864,
"domNodes": 16,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 158.218,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 725.5609999999706,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.327,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.021,
"heapDeltaBytes": 18738728,
"heapUsedBytes": 88702272,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 163.493,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2046.3749999998981,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.733000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 802.792,
"heapDeltaBytes": 9961596,
"heapUsedBytes": 85300672,
"domNodes": -269,
"jsHeapTotalBytes": -364544,
"scriptDurationMs": 45.362,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2060.564999999997,
"styleRecalcs": 3,
"styleRecalcDurationMs": 4.122999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 738.188,
"heapDeltaBytes": 10884216,
"heapUsedBytes": 86844428,
"domNodes": -276,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 40.641,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2405.1560000000336,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.184,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1766.0249999999999,
"heapDeltaBytes": 12407756,
"heapUsedBytes": 89262660,
"domNodes": -271,
"jsHeapTotalBytes": -663552,
"scriptDurationMs": 817.1740000000001,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2314.928000000009,
"styleRecalcs": 64,
"styleRecalcDurationMs": 11.791000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1692.1760000000002,
"heapDeltaBytes": 19399872,
"heapUsedBytes": 85040220,
"domNodes": -277,
"jsHeapTotalBytes": 2060288,
"scriptDurationMs": 804.506,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3699.032000000102,
"styleRecalcs": 60,
"styleRecalcDurationMs": 12.284999999999997,
"layouts": 60,
"layoutDurationMs": 14.773000000000001,
"taskDurationMs": 1844.45,
"heapDeltaBytes": 8478264,
"heapUsedBytes": 75978784,
"domNodes": -276,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 800.0899999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3747.702000000004,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.917000000000003,
"layouts": 60,
"layoutDurationMs": 14.209,
"taskDurationMs": 1813.3939999999998,
"heapDeltaBytes": 12335776,
"heapUsedBytes": 79962320,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 796.775,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3199.3019999999888,
"styleRecalcs": 40,
"styleRecalcDurationMs": 6.119,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2051.622,
"heapDeltaBytes": 22121316,
"heapUsedBytes": 90232176,
"domNodes": -277,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 990.801,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3277.796999999964,
"styleRecalcs": 43,
"styleRecalcDurationMs": 11.795,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2153.078,
"heapDeltaBytes": 2590248,
"heapUsedBytes": 82989156,
"domNodes": -288,
"jsHeapTotalBytes": 6082560,
"scriptDurationMs": 1034.0130000000001,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2006.3639999999623,
"styleRecalcs": 1,
"styleRecalcDurationMs": 1.7319999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 675.624,
"heapDeltaBytes": 22511404,
"heapUsedBytes": 89004524,
"domNodes": -272,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 38.80099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2037.682000000018,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.7590000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 665.2269999999999,
"heapDeltaBytes": -15707528,
"heapUsedBytes": 87551560,
"domNodes": -273,
"jsHeapTotalBytes": -589824,
"scriptDurationMs": 38.526,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 705.5179999999837,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.839999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.61300000000006,
"heapDeltaBytes": 15074428,
"heapUsedBytes": 88021356,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 163.031,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 625.4389999999148,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.547,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.1189999999999,
"heapDeltaBytes": 14386332,
"heapUsedBytes": 86328116,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 151.15699999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2038.3679999999913,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.400999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.034,
"heapDeltaBytes": 899356,
"heapUsedBytes": 73947196,
"domNodes": -292,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 11.135,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2015.5899999999747,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.688999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 549.745,
"heapDeltaBytes": -8650112,
"heapUsedBytes": 64207344,
"domNodes": -291,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9.815000000000001,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1772.6859999999078,
"styleRecalcs": 78,
"styleRecalcDurationMs": 43.82599999999999,
"layouts": 18,
"layoutDurationMs": 6.747000000000001,
"taskDurationMs": 912.6080000000001,
"heapDeltaBytes": 1191112,
"heapUsedBytes": 74152740,
"domNodes": -294,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 119.513,
"eventListeners": -222,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1774.3739999999661,
"styleRecalcs": 77,
"styleRecalcDurationMs": 41.015,
"layouts": 18,
"layoutDurationMs": 6.061000000000001,
"taskDurationMs": 933.636,
"heapDeltaBytes": -12617172,
"heapUsedBytes": 60448876,
"domNodes": -294,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 117.99099999999999,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1435.137999999938,
"styleRecalcs": 17,
"styleRecalcDurationMs": 33.474000000000004,
"layouts": 13,
"layoutDurationMs": 15.491000000000001,
"taskDurationMs": 1042.248,
"heapDeltaBytes": 21893644,
"heapUsedBytes": 106569220,
"domNodes": 13751,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 33.711,
"eventListeners": 2385,
"totalBlockingTimeMs": 135,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9913.803000000029,
"styleRecalcs": 247,
"styleRecalcDurationMs": 45.81399999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6565.476000000001,
"heapDeltaBytes": -7773136,
"heapUsedBytes": 67647576,
"domNodes": -267,
"jsHeapTotalBytes": 684032,
"scriptDurationMs": 2832.841,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8623.075000000084,
"styleRecalcs": 246,
"styleRecalcDurationMs": 43.56699999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6163.081999999999,
"heapDeltaBytes": 13343836,
"heapUsedBytes": 88747036,
"domNodes": -270,
"jsHeapTotalBytes": -663552,
"scriptDurationMs": 2703.1530000000002,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 19038.821999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18763.644,
"heapDeltaBytes": -49129308,
"heapUsedBytes": 162418036,
"domNodes": -6548,
"jsHeapTotalBytes": 1777664,
"scriptDurationMs": 329.121,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18857.34200000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18638.185,
"heapDeltaBytes": -30424740,
"heapUsedBytes": 180398568,
"domNodes": -6548,
"jsHeapTotalBytes": 7806976,
"scriptDurationMs": 351.478,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 24434.45699999995,
"styleRecalcs": 181,
"styleRecalcDurationMs": 30.20700000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24345.601000000002,
"heapDeltaBytes": -9589820,
"heapUsedBytes": 190701580,
"domNodes": -6548,
"jsHeapTotalBytes": 1753088,
"scriptDurationMs": 1033.493,
"eventListeners": -7469,
"totalBlockingTimeMs": 230,
"frameDurationMs": 18.33666666666662,
"p95FrameDurationMs": 16.799999999995634
},
{
"name": "vue-large-graph-pan",
"durationMs": 24106.488000000012,
"styleRecalcs": 180,
"styleRecalcDurationMs": 26.840000000000032,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23964.627999999997,
"heapDeltaBytes": -31038328,
"heapUsedBytes": 191207340,
"domNodes": -6548,
"jsHeapTotalBytes": -3489792,
"scriptDurationMs": 975.963,
"eventListeners": -7467,
"totalBlockingTimeMs": 246,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "vue-node-resize-workload",
"durationMs": 6900.843000000009,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.26800000000001,
"layouts": 20,
"layoutDurationMs": 29.24199999999999,
"taskDurationMs": 6852.880999999999,
"heapDeltaBytes": -6332664,
"heapUsedBytes": 195682484,
"domNodes": -6548,
"jsHeapTotalBytes": 17276928,
"scriptDurationMs": 136.42300000000003,
"eventListeners": -7469,
"totalBlockingTimeMs": 745,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6802.337999999963,
"styleRecalcs": 20,
"styleRecalcDurationMs": 86.02199999999999,
"layouts": 20,
"layoutDurationMs": 27.56799999999998,
"taskDurationMs": 6713.434,
"heapDeltaBytes": -28899900,
"heapUsedBytes": 181618220,
"domNodes": -6548,
"jsHeapTotalBytes": 12972032,
"scriptDurationMs": 131.92100000000002,
"eventListeners": -7471,
"totalBlockingTimeMs": 413,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9388.071999999966,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9264.984,
"heapDeltaBytes": 7435308,
"heapUsedBytes": 176967904,
"domNodes": 0,
"jsHeapTotalBytes": -1835008,
"scriptDurationMs": 174.06299999999996,
"eventListeners": -16,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9442.615000000045,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9308.622000000001,
"heapDeltaBytes": 2648536,
"heapUsedBytes": 177877292,
"domNodes": 0,
"jsHeapTotalBytes": -7602176,
"scriptDurationMs": 163.42099999999994,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 121.44999999998163,
"styleRecalcs": 9,
"styleRecalcDurationMs": 19.241,
"layouts": 2,
"layoutDurationMs": 1.449,
"taskDurationMs": 82.57799999999999,
"heapDeltaBytes": 3032280,
"heapUsedBytes": 71180616,
"domNodes": 133,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.6080000000000005,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 118.68800000002011,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.659,
"layouts": 2,
"layoutDurationMs": 0.9109999999999999,
"taskDurationMs": 77.951,
"heapDeltaBytes": 3035552,
"heapUsedBytes": 71822320,
"domNodes": 108,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.199000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.54 #17305 +/- ##
=============================================
- Coverage 82.98% 82.98% -0.01%
=============================================
Files 2053 2053
Lines 119680 119707 +27
Branches 30955 32785 +1830
=============================================
+ Hits 99315 99333 +18
- Misses 20185 20194 +9
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 12 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of merged fix #16508 to the
core/1.54release branch.dynamicWidgets.test.ts(23 passed) are green locally.Full context for agent readers
Source: #16508 (merge commit
3e43e3e7a51e77c93185feb6a499f45fb939b7f8). 1.53 backports: #17296 and #17297 (merged). Manual cherry-pick opened under Christian's standing backport authorization (bbc #520 answer 2).Files:
src/core/graph/widgets/dynamicWidgets.ts,src/core/graph/widgets/dynamicWidgets.test.ts.Conflict detail:
dynamicWidgets.test.tsheader. Branch HEAD had pinia imports plussetActivePiniainbeforeEach; the cherry-picked commit added anafterEachimport and anafterEachthat restoresLiteGraph.namedValuesRestore. Both hunks were kept; no test logic was altered.Local verification:
CI=true pnpm install --frozen-lockfile, pre-commit (oxfmt/oxlint/eslint +pnpm typecheck) passed,pnpm vitest run src/core/graph/widgets/dynamicWidgets.test.ts= 23 passed.