Repository navigation
[Phase 6a] Replace PrimeVue Toast with design-system toast - #16313
Conversation
|
Important Review skippedToo many files! This PR contains 378 files, which is 78 over the limit of 300. To get a review, reduce the PR to 300 files or fewer by splitting it into smaller PRs or changing its base branch. Usage-priced reviews support at most 300 files. ⚙️ Run configuration
⛔ Files ignored due to path filters (2)
📒 Files selected for processing (378)
You can disable this status message by setting the
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2246 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 9.36 MB gzip 🟢 -1.63 kBDetailsSummary
Category Glance App Entry Points — 4.53 kB (baseline 4.44 kB) • 🔴 +89 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.15 MB (baseline 2.16 MB) • 🟢 -3.74 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 154 kB (baseline 154 kB) • 🟢 -239 BTop-level views, pages, and routed surfaces
Status: 16 added / 16 removed / 3 unchanged Panels & Settings — 671 kB (baseline 671 kB) • 🟢 -205 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 19 unchanged User & Accounts — 54.6 kB (baseline 54.5 kB) • 🔴 +35 BAuthentication, profile, and account management bundles
Status: 9 added / 9 removed / 6 unchanged Editors & Dialogs — 339 kB (baseline 340 kB) • 🟢 -394 BModals, dialogs, drawers, and in-app editors
Status: 12 added / 12 removed / 1 unchanged UI Components — 201 kB (baseline 201 kB) • 🟢 -411 BReusable component library chunks
Status: 20 added / 20 removed / 4 unchanged Data & Services — 3.06 MB (baseline 3.07 MB) • 🟢 -4.59 kBStores, services, APIs, and repositories
Status: 20 added / 20 removed / 2 unchanged Utilities & Hooks — 819 kB (baseline 814 kB) • 🔴 +4.83 kBHelpers, composables, and utility bundles
Status: 28 added / 26 removed / 25 unchanged Vendor & Third-Party — 14.2 MB (baseline 14.2 MB) • 🟢 -8.45 kBExternal libraries and shared vendor chunks
Status: 2 added / 2 removed / 16 unchanged Other — 18.8 MB (baseline 18.7 MB) • 🔴 +4.76 kBBundles that do not match a named category
Status: 137 added / 136 removed / 211 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-09T01:38:19.826Z",
"gitSha": "140297ef53ced4cf55040627dbb65d60ea23191f",
"branch": "primevue-removal/phase-6-toast",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2026.3760000000275,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.7599999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.35,
"heapDeltaBytes": 5507744,
"heapUsedBytes": 62075572,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.721,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2031.3129999999546,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.4619999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.455,
"heapDeltaBytes": -37419344,
"heapUsedBytes": 60774260,
"domNodes": -217,
"jsHeapTotalBytes": -3407872,
"scriptDurationMs": 8.697,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1740.7940000000508,
"styleRecalcs": 52,
"styleRecalcDurationMs": 14.078000000000001,
"layouts": 12,
"layoutDurationMs": 3.3679999999999994,
"taskDurationMs": 810.106,
"heapDeltaBytes": 1031616,
"heapUsedBytes": 57719704,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 154.60500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1807.5579999999718,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.87,
"layouts": 12,
"layoutDurationMs": 3.504,
"taskDurationMs": 834.468,
"heapDeltaBytes": 5877188,
"heapUsedBytes": 76334632,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 164.78699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1701.4439999999809,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.719,
"layouts": 3,
"layoutDurationMs": 0.7009999999999998,
"taskDurationMs": 372.119,
"heapDeltaBytes": 7306784,
"heapUsedBytes": 70355592,
"domNodes": 45,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 10.461999999999996,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.598000000009,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.977000000000001,
"layouts": 3,
"layoutDurationMs": 0.719,
"taskDurationMs": 277.327,
"heapDeltaBytes": 6418240,
"heapUsedBytes": 62820248,
"domNodes": 45,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.928,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 615.0439999999548,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.8080000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.76300000000003,
"heapDeltaBytes": 18523840,
"heapUsedBytes": 75462244,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 170.50799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 623.3670000000302,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.398999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.68600000000004,
"heapDeltaBytes": 17805344,
"heapUsedBytes": 73865672,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 168.292,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66486486486485,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1148.9419999999768,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 765.787,
"heapDeltaBytes": 13995616,
"heapUsedBytes": 97557016,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 64.532,
"eventListeners": 0,
"totalBlockingTimeMs": 514,
"frameDurationMs": 33.8235294117647,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1164.5919999999705,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 826.511,
"heapDeltaBytes": 13993024,
"heapUsedBytes": 97505216,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 67.802,
"eventListeners": 0,
"totalBlockingTimeMs": 530,
"frameDurationMs": 34.31176470588236,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 872.6159999999936,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.8039999999999,
"heapDeltaBytes": 19114076,
"heapUsedBytes": 97385976,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 176.80799999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 239,
"frameDurationMs": 25.491176470588258,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.0100000000257,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.5419999999996,
"heapDeltaBytes": 19113484,
"heapUsedBytes": 97364964,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 169.31099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 223,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11122.762999999963,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10204.603000000001,
"heapDeltaBytes": 10520396,
"heapUsedBytes": 83774920,
"domNodes": -141,
"jsHeapTotalBytes": -12193792,
"scriptDurationMs": 8429.280999999999,
"eventListeners": -65,
"totalBlockingTimeMs": 1372,
"frameDurationMs": 32.88816568047338,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9300.62799999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8407.437999999998,
"heapDeltaBytes": 10433524,
"heapUsedBytes": 94175448,
"domNodes": 0,
"jsHeapTotalBytes": -19660800,
"scriptDurationMs": 6824.976000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 584,
"frameDurationMs": 31.311784511784506,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9765.10300000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8979.722,
"heapDeltaBytes": 11446248,
"heapUsedBytes": 94910892,
"domNodes": 0,
"jsHeapTotalBytes": -20971520,
"scriptDurationMs": 7345.141,
"eventListeners": 0,
"totalBlockingTimeMs": 781,
"frameDurationMs": 31.402893890675244,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9895.210000000021,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9044.601,
"heapDeltaBytes": -5451924,
"heapUsedBytes": 77986564,
"domNodes": 0,
"jsHeapTotalBytes": -16252928,
"scriptDurationMs": 7409.612,
"eventListeners": 0,
"totalBlockingTimeMs": 857,
"frameDurationMs": 31.033228840125393,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 187.68200000005208,
"styleRecalcs": 23,
"styleRecalcDurationMs": 16.427999999999997,
"layouts": 5,
"layoutDurationMs": 1.6840000000000002,
"taskDurationMs": 145.93599999999998,
"heapDeltaBytes": 12084128,
"heapUsedBytes": 78574180,
"domNodes": 918,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.017000000000001,
"eventListeners": 202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.233333333333373,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 216.9770000000426,
"styleRecalcs": 24,
"styleRecalcDurationMs": 19.067,
"layouts": 5,
"layoutDurationMs": 1.7950000000000002,
"taskDurationMs": 164.842,
"heapDeltaBytes": 12111248,
"heapUsedBytes": 77454164,
"domNodes": 918,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.735999999999999,
"eventListeners": 202,
"totalBlockingTimeMs": 2,
"frameDurationMs": 24.077777777777857,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-graph-idle",
"durationMs": 2041.4519999999925,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.6449999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 622.0699999999999,
"heapDeltaBytes": -39401004,
"heapUsedBytes": 85329516,
"domNodes": -313,
"jsHeapTotalBytes": -2719744,
"scriptDurationMs": 35.821999999999996,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2044.5310000000063,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.6690000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 558.2210000000001,
"heapDeltaBytes": -39075488,
"heapUsedBytes": 86064600,
"domNodes": -313,
"jsHeapTotalBytes": -3506176,
"scriptDurationMs": 32.84799999999999,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2480.9079999999994,
"styleRecalcs": 65,
"styleRecalcDurationMs": 6.043,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1650.382,
"heapDeltaBytes": 17943568,
"heapUsedBytes": 84436380,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 826.8069999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66644295302014,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2236.660000000029,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.864999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1446.866,
"heapDeltaBytes": -49705840,
"heapUsedBytes": 82355072,
"domNodes": -313,
"jsHeapTotalBytes": -2232320,
"scriptDurationMs": 813.841,
"eventListeners": -124,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.79097744360902,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3871.559999999988,
"styleRecalcs": 72,
"styleRecalcDurationMs": 9.921,
"layouts": 60,
"layoutDurationMs": 11.683,
"taskDurationMs": 1861.3059999999998,
"heapDeltaBytes": -14662948,
"heapUsedBytes": 69921512,
"domNodes": 24,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 859.752,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665948275862064,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3488.195000000019,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.057,
"layouts": 60,
"layoutDurationMs": 9.766,
"taskDurationMs": 1490.6290000000001,
"heapDeltaBytes": 7808676,
"heapUsedBytes": 74899324,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 768.0550000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66602870813397,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3121.9580000000065,
"styleRecalcs": 41,
"styleRecalcDurationMs": 4.663,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1973.746,
"heapDeltaBytes": 26109040,
"heapUsedBytes": 93524380,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 988.7729999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.846739130434784,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2933.347000000026,
"styleRecalcs": 42,
"styleRecalcDurationMs": 4.371999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1888.827,
"heapDeltaBytes": 24266892,
"heapUsedBytes": 91768988,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 958.8019999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.85747126436781,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2041.3609999999949,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.7490000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 569.8639999999999,
"heapDeltaBytes": -40537508,
"heapUsedBytes": 85795776,
"domNodes": -313,
"jsHeapTotalBytes": -5079040,
"scriptDurationMs": 34.059,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622944,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.7260000000579,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.8469999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 552.88,
"heapDeltaBytes": 20693172,
"heapUsedBytes": 86231576,
"domNodes": -313,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.723,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 646.9290000000001,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.126999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.62000000000006,
"heapDeltaBytes": 12712952,
"heapUsedBytes": 68892788,
"domNodes": -235,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 149.16800000000003,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668421052631594,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 576.1719999999286,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.8839999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.076,
"heapDeltaBytes": 12815016,
"heapUsedBytes": 70085820,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 142.149,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2018.2459999999764,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.561,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 333.08700000000005,
"heapDeltaBytes": 5558728,
"heapUsedBytes": 62449544,
"domNodes": -233,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 8.324000000000002,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.8159999999207,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.945,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.106,
"heapDeltaBytes": 5484504,
"heapUsedBytes": 62327040,
"domNodes": -232,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 7.612000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.9280000000049,
"styleRecalcs": 78,
"styleRecalcDurationMs": 15.581,
"layouts": 16,
"layoutDurationMs": 4.805000000000001,
"taskDurationMs": 783.692,
"heapDeltaBytes": 23826232,
"heapUsedBytes": 80543872,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 107.433,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.7840000000897,
"styleRecalcs": 78,
"styleRecalcDurationMs": 15.186,
"layouts": 16,
"layoutDurationMs": 4.0169999999999995,
"taskDurationMs": 669.91,
"heapDeltaBytes": -27617308,
"heapUsedBytes": 79947976,
"domNodes": -233,
"jsHeapTotalBytes": -3145728,
"scriptDurationMs": 105.419,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1436.30399999995,
"styleRecalcs": 19,
"styleRecalcDurationMs": 29.262999999999998,
"layouts": 5,
"layoutDurationMs": 14.303999999999997,
"taskDurationMs": 991.2080000000001,
"heapDeltaBytes": 34374984,
"heapUsedBytes": 113963364,
"domNodes": 14650,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 32.415,
"eventListeners": 2456,
"totalBlockingTimeMs": 134,
"frameDurationMs": 19.59324324324325,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8652.525999999965,
"styleRecalcs": 250,
"styleRecalcDurationMs": 19.953,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5729.910999999999,
"heapDeltaBytes": -34726920,
"heapUsedBytes": 90157816,
"domNodes": -313,
"jsHeapTotalBytes": -3837952,
"scriptDurationMs": 2684.516,
"eventListeners": -124,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665895953757225,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8288.038999999913,
"styleRecalcs": 250,
"styleRecalcDurationMs": 20.567,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5053.906000000001,
"heapDeltaBytes": -47942552,
"heapUsedBytes": 81859860,
"domNodes": -313,
"jsHeapTotalBytes": -4100096,
"scriptDurationMs": 2682.9419999999996,
"eventListeners": -124,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666330645161292,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 19275.491999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18627.985,
"heapDeltaBytes": -33152408,
"heapUsedBytes": 183305812,
"domNodes": -3046,
"jsHeapTotalBytes": 7884800,
"scriptDurationMs": 348.055,
"eventListeners": -14915,
"totalBlockingTimeMs": 4,
"frameDurationMs": 33.10258175559381,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-idle",
"durationMs": 18728.01700000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18153.653,
"heapDeltaBytes": -32229248,
"heapUsedBytes": 183809912,
"domNodes": -3046,
"jsHeapTotalBytes": 7098368,
"scriptDurationMs": 282.344,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.04777397260274,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 24102.603999999985,
"styleRecalcs": 181,
"styleRecalcDurationMs": 16.121999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23754.178,
"heapDeltaBytes": -25763720,
"heapUsedBytes": 190422280,
"domNodes": -3046,
"jsHeapTotalBytes": 2379776,
"scriptDurationMs": 873.6679999999999,
"eventListeners": -14913,
"totalBlockingTimeMs": 14,
"frameDurationMs": 44.545286506469495,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 23604.75599999995,
"styleRecalcs": 180,
"styleRecalcDurationMs": 16.166999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23209.969999999998,
"heapDeltaBytes": -27038396,
"heapUsedBytes": 189767712,
"domNodes": -3046,
"jsHeapTotalBytes": 7622656,
"scriptDurationMs": 924.6289999999999,
"eventListeners": -14913,
"totalBlockingTimeMs": 8,
"frameDurationMs": 43.30110091743119,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 5206.439000000046,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.18000000000004,
"layouts": 20,
"layoutDurationMs": 24.256,
"taskDurationMs": 5017.853999999999,
"heapDeltaBytes": 3527060,
"heapUsedBytes": 223573584,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 97.35600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.04916201117318,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 6975.479999999948,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.25000000000001,
"layouts": 20,
"layoutDurationMs": 23.472999999999995,
"taskDurationMs": 6822.104,
"heapDeltaBytes": 953592,
"heapUsedBytes": 221574832,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 119.85399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.95108695652174,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7109.081999999944,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6689.846999999999,
"heapDeltaBytes": -26706608,
"heapUsedBytes": 188656708,
"domNodes": -3046,
"jsHeapTotalBytes": 13422592,
"scriptDurationMs": 116.189,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.824161073825497,
"p95FrameDurationMs": 33.5
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9556.146000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9170.529000000002,
"heapDeltaBytes": -35648600,
"heapUsedBytes": 185019212,
"domNodes": -3046,
"jsHeapTotalBytes": 4915200,
"scriptDurationMs": 142.86300000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.5924914675768,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "workflow-execution",
"durationMs": 151.9980000000487,
"styleRecalcs": 8,
"styleRecalcDurationMs": 15.344,
"layouts": 4,
"layoutDurationMs": 2.1029999999999998,
"taskDurationMs": 130.56699999999998,
"heapDeltaBytes": 4293368,
"heapUsedBytes": 101203080,
"domNodes": 127,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.975000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.414285714285793,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "workflow-execution",
"durationMs": 124.14200000000619,
"styleRecalcs": 6,
"styleRecalcDurationMs": 10.498999999999999,
"layouts": 3,
"layoutDurationMs": 1.306,
"taskDurationMs": 80.102,
"heapDeltaBytes": 4190204,
"heapUsedBytes": 60465392,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.151000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 947.7109999999129,
"styleRecalcs": 77,
"styleRecalcDurationMs": 91.134,
"layouts": 76,
"layoutDurationMs": 18.996,
"taskDurationMs": 916.823,
"heapDeltaBytes": 18691792,
"heapUsedBytes": 93495556,
"domNodes": 77,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 383.249,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.964285714285715,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 910.0690000000213,
"styleRecalcs": 77,
"styleRecalcDurationMs": 89.365,
"layouts": 76,
"layoutDurationMs": 18.889,
"taskDurationMs": 875.367,
"heapDeltaBytes": 18431388,
"heapUsedBytes": 91981112,
"domNodes": 77,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 366.03200000000004,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664814814814825,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1400.5779999999959,
"styleRecalcs": 77,
"styleRecalcDurationMs": 249.723,
"layouts": 76,
"layoutDurationMs": 20.224,
"taskDurationMs": 1379.3500000000001,
"heapDeltaBytes": 10038108,
"heapUsedBytes": 125259624,
"domNodes": 77,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 486.043,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.947435897435916,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1444.7940000000017,
"styleRecalcs": 77,
"styleRecalcDurationMs": 248.42000000000002,
"layouts": 76,
"layoutDurationMs": 19.980999999999998,
"taskDurationMs": 1417.4640000000002,
"heapDeltaBytes": 13946304,
"heapUsedBytes": 136668536,
"domNodes": 77,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 505.66900000000004,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.884146341463413,
"p95FrameDurationMs": 33.399999999999636
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (384 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e2f3d6f9ac4a51640de301614b35c4c16784c081
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-16313.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-ee434vjiv-comfyui.vercel.app Last updated: 2026-10-09T01:11:05Z for |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #16313 +/- ##
==========================================
+ Coverage 85.85% 85.89% +0.03%
==========================================
Files 3594 3599 +5
Lines 172365 172421 +56
Branches 47299 44986 -2313
==========================================
+ Hits 147990 148104 +114
+ Misses 22357 22299 -58
Partials 2018 2018
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 46 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Updating Playwright Expectations |
|
/update-playwright |
9e1faf8 to
eca0387
Compare
04b431e to
190084e
Compare
eca0387 to
3858e7a
Compare
190084e to
4e71384
Compare
|
Severity: Major What: Eight negative assertions still match the old PrimeVue argument shape on spies now called with Why this is an issue: Each guarded a live rule; all now pass under any regression. Proposed Fix: Rewrite to the new shape, e.g. |
4e71384 to
bebb4be
Compare
8dafae2 to
611bb9c
Compare
c48c1f7 to
e00fa60
Compare
7e21945 to
de88c32
Compare
Main now spies on console in shared Vitest setup and lints against new spies. Amp-Thread-ID: https://ampcode.com/threads/T-01a10ae8-fc3e-75a8-8da1-907005697afa
…design-system toast Amp-Thread-ID: https://ampcode.com/threads/T-01a10ae8-fc3e-75a8-8da1-907005697afa
ToastPanel keeps a polite status region mounted and fills it while the panel is visible. Model import, asset export and the manager queue pass a fixed start label while work runs and the outcome their footer shows afterwards, so screen readers hear when work starts and how it ended without per-tick chatter (WCAG 4.1.3, technique ARIA25). Specs that read panel copy page-wide now scope it through ToastHelper.panels. Amp-Thread-ID: https://ampcode.com/threads/T-01a10ae8-fc3e-75a8-8da1-907005697afa
uploadTempFile hand-declared the POST /upload/image response with a required name, while @comfyorg/ingest-types exports UploadImageResponse, where name is optional. Use the generated type.
addAlert(message) and add({ detail }) without a summary now put the
message in the title. On main it went into PrimeVue's detail, which kept
line breaks, so the title preserves them like the description.
Custom nodes pass severity 'warning' to the deprecated toast.add (for example ComfyUI-Lora-Manager), which this PR had started dropping. Map it to the warning kind so those messages stay visible, and report the first use per session through reportError so its callers can be tracked and migrated to 'warn' or toast.warning().
Each add gets a fresh render identity, so replacing a toast through its id remounts it with a timer for the new duration. Amp-Thread-ID: https://ampcode.com/threads/T-01a10ae8-fc3e-75a8-8da1-907005697afa
Main now puts the dark theme on the document root while these layouts are mounted, so the Toaster no longer needs to sit inside the layout's theme scope. Amp-Thread-ID: https://ampcode.com/threads/T-01a10ae8-fc3e-75a8-8da1-907005697afa
dante01yoon
left a comment
There was a problem hiding this comment.
[P2] The toast-before-dialog action regression still blocks this migration at 2b4a18be1c5d7cd531c60421af2f027ea269bae2. This is the existing ToastViewport.vue:26 finding in review 5463443293; I am linking that inline finding instead of duplicating it.
In this head's actual Cloud production build, create an action toast, open the real Settings dialog, then click its retry button normally. Settings intercepts the click and dims the toast behind the dialog. The viewport/directive are unchanged: the viewport registers in the shared later-wins modal counter, and opening a dialog afterwards covers it. Fetched current main keeps GlobalToast at z-10000. Please preserve this existing action ordering here, or narrow the migration so it does not ship the regression. Tracking the fix in #16352 leaves this changed interaction broken in the meantime.
The latest Cloud/OAuth sibling placement and SSO-required handling were independently checked. Own frozen install; 332 relevant unit PASS across 12 files; app/browser/scripts types, Cloud production build, changed type-aware oxlint, production/browser ESLint, format and Knip PASS. Real production Chromium plus an isolated local backend: 20 PASS / 1 FAIL across login errors, SSO on/off (including unified-auth on), OAuth consent/theme/notification regions, normal timeout, both replacement lifetimes, and the failing Settings/action ordering. Auth, customer/session/SSO responses are controlled fixtures; no live account, identity-provider or payment claim.
Removing the SSO production increment gives 3 unit FAIL / 213 PASS; restoring gives 228 PASS. Removing just the refusal guard while retaining its error class gives 1 FAIL / 52 PASS; restoring gives 53 PASS. The response classifiers use shared generated ErrorResponse schemas and the server's organization id; no new inferred server state. The timer fix remains effective: independent real-Toaster probes give 23 PASS, old render key gives 4 FAIL / 19 PASS, restoring gives 23 PASS.
Latest matching Tests/E2E and website E2E runs are still in progress. Raw required-context failures point to earlier cancelled runs on this SHA; I do not count those as current product failures. New website build/published gate, unrelated full suites, other OS/browser, live Cloud/payment and broad performance/a11y NOT_RUN: this increment changes app auth/layout code; website and shared toast code are unchanged. Earlier website/top-layer diagnostic evidence remains historical. All mutations/probes removed, 380 PR files byte-exact, checkout clean, owned backend stopped.
|
Answers to @dante01yoon's review of 2b4a18b (5464675989):
No commits pushed this round. |
Summary
Replaces PrimeVue's toast (
GlobalToast, theplatform/updatestoast store,HoneyToastand the custom toast bodies) with one Reka-based design-system toast insrc/components/ui/toast, and migrates every caller, including the comfy.org auth toast (FE-2731).useToast()withsuccess/error/info/warning/loading(title, { action, closable, description, duration })and id-baseddismiss;Toasteris the only renderer.ToastPanels in one scrollingToastDockinstead of overlappingHoneyToasts.app.extensionManager.toastkeeps the deprecatedadd({ severity, summary, detail, life })andaddAlertfor custom nodes (FE-3214).ToastHelper(comfyPage.toastor thetoastfixture).Design details
useToast()Pinia store withsuccess/error/info/warning/loading(title, { action, closable, description, duration }), which returns a brandedToastId; a caller-owned id fromcreateToastId()passed asidreplaces that toast in place, anddismiss(id)reports whether it removed one;dismissAll(). No barrel. An optionalaction: { label, onClick }renders the sharedButtonand does not dismiss by itself.Toasteris the only toast renderer. It sits top right, aligned with CSS anchors to the graph canvas panel, so toasts clear the right side panel, the docked agent panel and the graph toolbar; browsers without anchor positioning offset it by--workspace-inset-right. The cloud and OAuth layouts render it where main renderedGlobalToast; main'suseDocumentDarkThemegives it the dark theme there. EachToasterdismisses its toasts before it unmounts, as main's per-layoutGlobalToastdid. It mounts Reka's provider only while toasts are showing, disables swipe (so non-closable toasts stay put and text stays selectable), keeps toasts open on an Escape meant for a dialog, and owns one polite and one assertive live region (aria-atomic="false", action labels included). Model import, asset export and manager progress panels render asToastPanels insideToastDockinGraphView, on a fixed top layer above later dialogs (asHoneyToastwas).canvasStore.isPickingNodes, which replaced main'sagentNodeSelectionStore) sets the toast store'sheldflag: held toasts are hidden and their timers restart when shown. Docked panels stay visible.app.extensionManager.toast, built inworkspaceStore): the new methods plus deprecatedadd({ severity, summary, detail, life, closable })andaddAlert(message), which public custom nodes call.addAlert(message)now shows the message as the warning title.remove(message)/removeAll()are removed: no public extension calls them (only the docs pages). The README keeps its historic entries and adds one for the new API. Migration tracking: FE-3214.addAlertshape ("Alert" title, message below) is gone; those callers pass the message as the title. Raw English and HTTP-status titles use i18n keys, and unknown errors reach toast text throughgetErrorMessage. Renamed en keys (workspace.addedToNamedWorkspace,mediaAsset.assetDelete.warning,g.versionMismatchUpdateInstructions,toastMessages.notifications*) fall back to English until the release i18n run.SignInContent) use the new API.rekaPrimeVueBridgeno longer treats Select, ColorPicker, Popover or AutoComplete overlays as inside a Reka dialog, because the app no longer renders them;.p-dialog/.p-overlay-maskstay until [Phase 6c] Replace PrimeVue Dialog and remaining simple components #16352 removes PrimeVue Dialog.apps/website): main's hand-copied PrimeVue toast (severity/summary/detail/life,warn, own timer, PrimeVue icons, Aura colours) is replaced.authToast.error/success/warning(title, { description, duration })uses the same API shape as the app, and Reka'sToastProvider/ToastRoot/ToastViewportrender it directly, with Reka owning the timer, Escape and swipe. It has its own polite and assertive live regions, because Reka 2.6's built-in announcer isaria-hidden.@comfyorg/account-core'sseverityForAuthErrornow returns'warning'(published alpha; the version bump goes in a separate PR), which removes the app's'warn'→'warning'mapping. Website e2e locates toasts through anAuthToastspage object.ToastHelper:comfyPage.toast(withText, kind locators), or thetoastfixture (defined onnetworkIsolationFixture) in tests withoutcomfyPage(cloudAppFixture,agentTest, page-only tests). Docked panels go throughTestIds.toast.panel. NevergetByText/getByRole('alert'|'status')on toast copy, because the live regions repeat it, and never rawgetByTestId('toast'). Lint allows specs to importToastHelperonly as a type (rule also inbrowser_tests/README.mdand the Playwright checklist).Follow-ups:
durationstay open (PrimeVue's sticky default, about 266 of 371 calls); Reka and shadcn-vue auto-close after about 5 s. Revisit an auto-close default, likely keeping errors, loading and action toasts persistent.GlobalToastsat at a fixedz-10000, so an action toast's button cannot be clicked until the dialog closes. A toast raised while a dialog is open still sits above it. [Phase 6c] Replace PrimeVue Dialog and remaining simple components #16352 owns modal stacking and handles both orderings.Verification
Gates, full unit (1865 files, 27,771 tests), the website suites and the touched Playwright specs pass locally.
Commands, specs and goldens
pnpm typecheck,typecheck:browser,lint,knip,format:checkpass; fullpnpm test:unitpasses (1865 files, 27,771 tests). Website:typecheck:website, eslint, format:check,test:unit(588 files, 11,347 tests), and the auth e2e specs (auth-live,auth-live-errors,auth-sign-in, 19 tests) pass locally.toastNotifications,uploadWidgets,versionMismatchWarnings,modelImportProgressDialog(one 4-pixel golden diff locally),assets,sidebarSplitterWidth,errorSurfaces,topUpNoPaymentMethod. Cloud-only specs touched (authAccountSwitch,cloudWorkspaceDeepLink,agentPanel*,agentRunModePopover,billingProgressToastParity) run in CI.91d6f90008) refreshed onlynode-badge-unknown-color-palette(close button now the sharedButton).publish-dialog-lgandmodel-import-progress-toast-recovered-completedmatch CI's render, so they are unchanged.368d25f5aarefreshednode-badge-unknown-color-paletteandpublish-dialog-lg, the two goldens that capture a top-right toast.Screenshots
Main
fd5a5c2cccagainst this PR with the same triggers, 1280×720 at 2×. The HoneyToast → ToastPanel images predate the rebase; neitherToastPanel/ToastDocknor main's HoneyToast has changed since they were taken.Toast kinds
Toast kinds (identical legacy
toast.addcalls):Action toasts (reroute, invite, payment retry, former addAlert)
Action toasts: reroute migration, invite accepted, payment popup blocked, and the former
addAlert. On main each PrimeVue group has its own top-right container, so these overlap; they are shown one per frame here.Each toast is a grid: the icon, the first title line and the close button share one row centre, and the action button sits under the description, ending under the close button, in the
secondarystyle of the design-system error toast.Billing progress toasts
Billing progress (processing spinner, verification prompt):
HoneyToast → ToastPanel + ToastDock
ToastPanelis HoneyToast's markup (same classes,v-model:expanded,footerslot withtoggle); the three consumers only swap the wrapper. No consumer read the droppedisExpandedslot prop. What moved:fixedat bottom centre, teleported tobodyfixeddock at bottom centre inGraphView; panels stack with a gapoverlayZIndexKeyOne expanded panel is pixel-identical on both builds; mobile (390×844) and the panel over an open dialog match too.
All three panels expanded:
Short viewport (1280×560), before and after
54d12bcf22: without the cap, the stack ran off the top and flex shrinking clipped each footer.Panel over the Settings dialog, main vs this PR:
Mobile, main vs this PR:
Collapsed panels, main vs this PR:
Toast over an open dialog
Over an open dialog (Settings). As on main, the toast can cover the dialog's close button. Unlike main, a dialog opened after a toast covers that toast. Both orderings are deferred to the dialog migration in #16352.
Toast with the right side panel open
With the right side panel open (toasts stay left of the panel, as on main):
Cloud login page
Cloud login page (
CloudLayoutView;OAuthLayoutViewmounts the Toaster the same way):comfy.org sign-in page
comfy.org sign-in, disabled-account error toast (website e2e build):