Repository navigation
[backport core/1.56] fix(workspace): separate roster viewing from member management (#20674) - #20715
Conversation
This PR updates the Ingest API TypeScript types and Zod schemas from the latest cloud OpenAPI specification. - Cloud commit: 469d54e - Generated using @hey-api/openapi-ts with Zod plugin These types cover the FE-facing ingest API (workspaces, billing, secrets, assets, tasks, etc.). Cloud's internal / machine-to-machine surface — `x-internal` operations and the `/admin/`, `/api/internal/`, `/api/webhooks/` rails — is stripped before generation (BE-2669), so it is not code-generated into this public package. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: dante01yoon <bunggl@naver.com> (cherry picked from commit 0ab5b7b)
Cloud member-management controls combined server permissions with seat and subscription state, allowing the UI to disagree with the capabilities response. Use `can_manage_members` for member menus and pending-invite loading, visibility, revoke and resend. Invitation creation follows `can_invite_members`. Roster viewing is separate: a successful scoped members response shows the returned rows, role column and search for ordinary members too. Single-member personal layout and desktop behavior are preserved. Member and invite reads independently ignore superseded responses. Permission revocation hides loaded invitations; roster viewing is not filtered by management permission. Generated API types are already on main and excluded from this diff. Read-only production checks on 2026-10-09 confirmed `can_manage_members` support on v0.453.0 (8/8 ingest and 4/4 billing-api pods updated and ready). Capability decoding uses the strict generated contract. Effective invitation capacity is a separate backend rollout; verify the combined behavior in test/staging before that rollout. Validation: 339 focused component/store tests with coverage, 36 capability-reader tests, and nine Cloud browser tests pass. Normal formatting, lint, typechecks and unused-code checks pass. The Fallow audit also passes with clean-runner inputs and estimated coverage, matching CI. CI and human re-review remain pending. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit cb72d45)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-10T20:22:48.841Z",
"gitSha": "9afcb6e63330d65ac59b03bf4abdcaeefd9aa164",
"branch": "backport-20674-to-core-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2001.0070000000155,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.542,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.339,
"heapDeltaBytes": 618224,
"heapUsedBytes": 68360348,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.608000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2019.5819999999003,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.5619999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.25700000000006,
"heapDeltaBytes": 957772,
"heapUsedBytes": 68711852,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.838999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1740.8449999999789,
"styleRecalcs": 74,
"styleRecalcDurationMs": 15.499999999999998,
"layouts": 12,
"layoutDurationMs": 3.7810000000000006,
"taskDurationMs": 736.423,
"heapDeltaBytes": -2263820,
"heapUsedBytes": 65145576,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 154.024,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1744.6320000000242,
"styleRecalcs": 74,
"styleRecalcDurationMs": 15.735,
"layouts": 12,
"layoutDurationMs": 3.692,
"taskDurationMs": 746.53,
"heapDeltaBytes": -2176252,
"heapUsedBytes": 65110452,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 154.40499999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1713.9060000000654,
"styleRecalcs": 31,
"styleRecalcDurationMs": 8.09,
"layouts": 6,
"layoutDurationMs": 0.969,
"taskDurationMs": 310.34000000000003,
"heapDeltaBytes": 161448,
"heapUsedBytes": 62029776,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.741000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1698.451000000091,
"styleRecalcs": 29,
"styleRecalcDurationMs": 8.193999999999999,
"layouts": 6,
"layoutDurationMs": 1.1349999999999998,
"taskDurationMs": 313.659,
"heapDeltaBytes": 4090924,
"heapUsedBytes": 72200312,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.880999999999993,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 654.2479999999955,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.4210000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.77199999999993,
"heapDeltaBytes": -6762728,
"heapUsedBytes": 61057220,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 159.265,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 634.3229999999949,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.5569999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 432.47299999999996,
"heapDeltaBytes": -8444388,
"heapUsedBytes": 59598052,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 164.188,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1087.6200000000154,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 742.7,
"heapDeltaBytes": 39108636,
"heapUsedBytes": 108877716,
"domNodes": 0,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 59.905000000000015,
"eventListeners": 0,
"totalBlockingTimeMs": 471,
"frameDurationMs": 32.827272727272735,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1095.8739999999807,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 750.261,
"heapDeltaBytes": 15430384,
"heapUsedBytes": 85087340,
"domNodes": 0,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 59.36599999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 479,
"frameDurationMs": 33.333333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.9070000000206,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.66200000000015,
"heapDeltaBytes": 17633900,
"heapUsedBytes": 105925628,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 154.01199999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 216,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 862.7620000000888,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.4560000000001,
"heapDeltaBytes": 18361544,
"heapUsedBytes": 100835960,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 156.70899999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 202,
"frameDurationMs": 24.072222222222234,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8545.423000000028,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.03500000000000031,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7759.952,
"heapDeltaBytes": -6352580,
"heapUsedBytes": 71654288,
"domNodes": -142,
"jsHeapTotalBytes": -10358784,
"scriptDurationMs": 6609.618,
"eventListeners": -74,
"totalBlockingTimeMs": 561,
"frameDurationMs": 33.792885375494066,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8334.609999999997,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.4580000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7640.561,
"heapDeltaBytes": 198012,
"heapUsedBytes": 85390924,
"domNodes": -142,
"jsHeapTotalBytes": -8785920,
"scriptDurationMs": 6514.966,
"eventListeners": -78,
"totalBlockingTimeMs": 640,
"frameDurationMs": 34.152049180327865,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9082.874000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8398.225,
"heapDeltaBytes": -11237788,
"heapUsedBytes": 73369980,
"domNodes": -142,
"jsHeapTotalBytes": -9572352,
"scriptDurationMs": 6959.441,
"eventListeners": -78,
"totalBlockingTimeMs": 597,
"frameDurationMs": 32.90905797101449,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8726.423999999952,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8900000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8012.758,
"heapDeltaBytes": -355740,
"heapUsedBytes": 67753356,
"domNodes": -142,
"jsHeapTotalBytes": -10096640,
"scriptDurationMs": 6583.725,
"eventListeners": -70,
"totalBlockingTimeMs": 467,
"frameDurationMs": 32.22509225092251,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2023.0390000000398,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.3750000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.741,
"heapDeltaBytes": -9613624,
"heapUsedBytes": 78378200,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 29.438999999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2019.6260000000166,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.297000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.5899999999999,
"heapDeltaBytes": 15068088,
"heapUsedBytes": 91834496,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 28.032999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2209.6950000000106,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.253,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1525.896,
"heapDeltaBytes": -18969956,
"heapUsedBytes": 70224396,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 833.81,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2249.869999999987,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.513,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1518.2189999999998,
"heapDeltaBytes": -18588148,
"heapUsedBytes": 71158924,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 825.547,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666417910447755,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3533.4910000000264,
"styleRecalcs": 73,
"styleRecalcDurationMs": 13.324999999999998,
"layouts": 60,
"layoutDurationMs": 13.493,
"taskDurationMs": 1571.5540000000003,
"heapDeltaBytes": 1539500,
"heapUsedBytes": 69394036,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 769.653,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666350710900474,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3537.6529999999775,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.914000000000001,
"layouts": 60,
"layoutDurationMs": 13.861,
"taskDurationMs": 1595.993,
"heapDeltaBytes": 1388532,
"heapUsedBytes": 70410596,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 792.283,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666509433962265,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2949.473000000012,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.442,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1808.128,
"heapDeltaBytes": 8345200,
"heapUsedBytes": 77143840,
"domNodes": 0,
"jsHeapTotalBytes": 1241088,
"scriptDurationMs": 960.4739999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.760795454545452,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3007.310000000075,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.338000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1803.4560000000001,
"heapDeltaBytes": 4771444,
"heapUsedBytes": 74481604,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 958.7370000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75921787709497,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2012.687000000028,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.244,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.09000000000015,
"heapDeltaBytes": -8734140,
"heapUsedBytes": 81644004,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 27.555999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2009.141999999997,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.883,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.23499999999996,
"heapDeltaBytes": 13399292,
"heapUsedBytes": 81556304,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 27.508000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.114999999978,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.9559999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 384.37100000000004,
"heapDeltaBytes": -11711072,
"heapUsedBytes": 58126608,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 142.75900000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 607.0549999999457,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.731,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 384.609,
"heapDeltaBytes": -11720828,
"heapUsedBytes": 57757096,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 139.66899999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2010.2990000000318,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.8800000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 389.86,
"heapDeltaBytes": 1076708,
"heapUsedBytes": 70888544,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.962999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.2199999999712,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.318999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 384.954,
"heapDeltaBytes": 778636,
"heapUsedBytes": 68137916,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.996000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1713.3840000000191,
"styleRecalcs": 58,
"styleRecalcDurationMs": 16.085,
"layouts": 16,
"layoutDurationMs": 5.836000000000001,
"taskDurationMs": 717.417,
"heapDeltaBytes": -41104088,
"heapUsedBytes": 68673984,
"domNodes": -270,
"jsHeapTotalBytes": -2883584,
"scriptDurationMs": 99.548,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.118999999987,
"styleRecalcs": 77,
"styleRecalcDurationMs": 16.486,
"layouts": 16,
"layoutDurationMs": 5.284,
"taskDurationMs": 695.814,
"heapDeltaBytes": -6004952,
"heapUsedBytes": 63529132,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 102.388,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1351.385999999934,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.043999999999993,
"layouts": 5,
"layoutDurationMs": 14.477000000000004,
"taskDurationMs": 845.4079999999999,
"heapDeltaBytes": 3194804,
"heapUsedBytes": 98916404,
"domNodes": 14227,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 26.994000000000003,
"eventListeners": 2463,
"totalBlockingTimeMs": 123,
"frameDurationMs": 19.24788732394367,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8280.015000000049,
"styleRecalcs": 250,
"styleRecalcDurationMs": 33.266,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4976.383,
"heapDeltaBytes": -9603884,
"heapUsedBytes": 79208652,
"domNodes": 0,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 2932.711,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699798387096774,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8289.59400000008,
"styleRecalcs": 250,
"styleRecalcDurationMs": 33.637,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5216.364,
"heapDeltaBytes": -19044452,
"heapUsedBytes": 69373380,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2682.0460000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66599597585513,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15622.809999999958,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14850.675999999998,
"heapDeltaBytes": -35551452,
"heapUsedBytes": 177209628,
"domNodes": -3045,
"jsHeapTotalBytes": 3166208,
"scriptDurationMs": 208.177,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.51290322580645,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 15977.05099999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14957.639000000001,
"heapDeltaBytes": -13869776,
"heapUsedBytes": 185388392,
"domNodes": -3045,
"jsHeapTotalBytes": 13651968,
"scriptDurationMs": 216.28400000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.153061224489797,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 20366.484000000015,
"styleRecalcs": 175,
"styleRecalcDurationMs": 17.13299999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19868.364,
"heapDeltaBytes": -25520620,
"heapUsedBytes": 187611076,
"domNodes": -3045,
"jsHeapTotalBytes": 6766592,
"scriptDurationMs": 853.7439999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 22,
"frameDurationMs": 37.43731617647059,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 20549.72500000008,
"styleRecalcs": 175,
"styleRecalcDurationMs": 17.117000000000022,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20112.734,
"heapDeltaBytes": -51408912,
"heapUsedBytes": 175438868,
"domNodes": -3045,
"jsHeapTotalBytes": 6836224,
"scriptDurationMs": 856.205,
"eventListeners": -14915,
"totalBlockingTimeMs": 14,
"frameDurationMs": 37.18951175406872,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 5865.218000000027,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.82600000000001,
"layouts": 20,
"layoutDurationMs": 21.991999999999997,
"taskDurationMs": 5705.678,
"heapDeltaBytes": 1074760,
"heapUsedBytes": 223169896,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 93.64099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.81964285714286,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5869.197999999983,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.84500000000003,
"layouts": 20,
"layoutDurationMs": 21.70599999999999,
"taskDurationMs": 5713.98,
"heapDeltaBytes": 1128904,
"heapUsedBytes": 214368764,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 91.77300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.553939393939395,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8263.677000000029,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7760.575999999998,
"heapDeltaBytes": -42517820,
"heapUsedBytes": 179584156,
"domNodes": -3045,
"jsHeapTotalBytes": 1679360,
"scriptDurationMs": 111.844,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.87027027027028,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7986.998999999969,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7596.064,
"heapDeltaBytes": -22919372,
"heapUsedBytes": 180138308,
"domNodes": -3046,
"jsHeapTotalBytes": 6049792,
"scriptDurationMs": 116.98399999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.698996655518396,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 454.7259999999369,
"styleRecalcs": 17,
"styleRecalcDurationMs": 16.729,
"layouts": 4,
"layoutDurationMs": 1.704,
"taskDurationMs": 120.19800000000002,
"heapDeltaBytes": 5796124,
"heapUsedBytes": 63520100,
"domNodes": 104,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.989999999999998,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 444.59199999994325,
"styleRecalcs": 15,
"styleRecalcDurationMs": 13.576999999999998,
"layouts": 3,
"layoutDurationMs": 0.8360000000000002,
"taskDurationMs": 97.84100000000001,
"heapDeltaBytes": 5518256,
"heapUsedBytes": 72158048,
"domNodes": 99,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.431,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66296296296295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 781.900999999948,
"styleRecalcs": 78,
"styleRecalcDurationMs": 98.82000000000001,
"layouts": 76,
"layoutDurationMs": 23.535,
"taskDurationMs": 760.5740000000001,
"heapDeltaBytes": -8926296,
"heapUsedBytes": 80789652,
"domNodes": 76,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 310.438,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664583333333344,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 808.3390000000463,
"styleRecalcs": 78,
"styleRecalcDurationMs": 97.75,
"layouts": 76,
"layoutDurationMs": 23.384999999999998,
"taskDurationMs": 769.913,
"heapDeltaBytes": -8891660,
"heapUsedBytes": 80570560,
"domNodes": 76,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 312.59999999999997,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1289.4559999999728,
"styleRecalcs": 78,
"styleRecalcDurationMs": 251.99300000000002,
"layouts": 76,
"layoutDurationMs": 26.55,
"taskDurationMs": 1261.258,
"heapDeltaBytes": 8163024,
"heapUsedBytes": 113934016,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 414.269,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.8818181818182,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1354.0249999999787,
"styleRecalcs": 78,
"styleRecalcDurationMs": 267.122,
"layouts": 76,
"layoutDurationMs": 27.16,
"taskDurationMs": 1326.4689999999998,
"heapDeltaBytes": 8436448,
"heapUsedBytes": 114390628,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 440.02799999999996,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.306410256410253,
"p95FrameDurationMs": 16.80000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2202 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 897dcd8fe2f93072e699745486b0833cf913a455
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ETip All tests passed.
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.56 #20715 +/- ##
=============================================
- Coverage 85.86% 85.10% -0.76%
=============================================
Files 2471 3513 +1042
Lines 141059 168923 +27864
Branches 38387 46330 +7943
=============================================
+ Hits 121114 143766 +22652
- Misses 19562 23167 +3605
- Partials 383 1990 +1607
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1051 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
On 1.56 PendingInvitesList renders Resend and Cancel as Buttons inside the MoreButton popover, not Reka menu items.
christian-byrne
left a comment
There was a problem hiding this comment.
Manual backport of "separate roster viewing from member management" (PR 20674) onto core/1.56, after the automated backport hit a conflict.
- Three commits: a prerequisite cherry-pick syncing the
can_manage_membersfield into the generated ingest types, an exact cherry-pick of PR 20674's merge commit, and a small fixup adapting one new browser test to a pre-existingcore/1.56-only component quirk. - Diffed the core logic files (the members panel composable, both panel components, the team workspace store) against what PR 20674 produced on
main: byte-identical. The roster-viewing/member-management split is correctly present -- a non-manager still gets the read-only roster, not a full block. - Every test-file difference traces to the older base rather than drift: the browser spec uses
core/1.56's pre-existing local test helpers because the page object PR 20674 used doesn't exist there yet, and the one popover-selector fixup matches how that component already renders on this branch. - No
package.jsonor other manifest is touched anywhere in this backport, so the removed-exportsfailure mode this program watches for doesn't apply here.
Zero open review threads, CI green. Approved.
…mber management (#20674) (#20716) ## Why Manual backport of #20674 (`cb72d4536a`) to `cloud/1.56`. The auto-backport failed on conflicts. #20674 makes member menus and pending-invite management follow `can_manage_members`, invitation creation follow `can_invite_members`, and lets ordinary members view and search the returned roster. ## How - `ec50e35cb8` cherry-picks #20674. The ingest-types sync #20666 is not included: `cloud/1.56` already has `can_manage_members` in `packages/ingest-types/src/types.gen.ts` and `zod.gen.ts`. - Same resolution as the `core/1.56` backport #20715; the spec and both settings test files are identical on the two release branches. ## Conflict resolution - `browser_tests/tests/dialogs/memberRoleChange.spec.ts`. Main uses the `MembersSettingsPanel` page object; `cloud/1.56` uses local helpers (`openMembersTab`, `memberRow`, `menuButton`, `openChangeRoleSubmenu`). The page object is not pulled in. The three test changes from #20674 are ported to the local helpers with the same mocked capabilities, invites and assertions: full workspace keeps member and pending-invite management, team member views and searches the roster without management controls, and the personal workspace test shows its pending invite. `cloud/1.56` has no `toast` test fixture, so `toast.withText('Invite resent')` becomes `page.getByText('Invite resent')`, matching the existing `Role updated` assertion in this spec. - `WorkspaceMembersPanelContent.test.ts` and `WorkspaceSettingsPanelContent.test.ts` merged cleanly but failed with `No PrimeVue Toast provided!`. After #20674 these tests mount the real `useMembersPanel`, which still uses `primevue/usetoast` on `cloud/1.56` (the design-system toast swap #16313 is main-only). Both files now mock `primevue/usetoast` the same way `useMembersPanel.test.ts` already does on this branch. ## Verification - `pnpm exec vitest run src/platform/workspace/composables/useMembersPanel.test.ts src/platform/workspace/components/dialogs/settings src/platform/workspace/composables/useBillingCapabilities.test.ts packages/account-core/src/core/billing/capabilities.test.ts`: 14 files, 366 tests passed. - `pnpm exec vitest run src/platform/workspace/stores/teamWorkspaceStore.test.ts`: 119 tests passed. - `pnpm typecheck:browser`: clean. - `oxfmt --check` and `oxlint --type-aware` on the touched files: clean. - The pre-commit hook (lint-staged, `typecheck:browser`, `typecheck:account-core`) and pre-push hook passed. - Playwright was not run against a backend; the `@cloud` spec runs in CI. ## AS IS / TO BE Same as #20674; this PR carries its behavior unchanged. No new screenshots for the backport. --------- Co-authored-by: Wei Hai <hai.vincent@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Why
Manual backport of #20674 (
cb72d4536a) tocore/1.56. The auto-backport failed on conflicts. #20674 makes member menus and pending-invite management followcan_manage_members, invitation creation followcan_invite_members, and lets ordinary members view and search the returned roster.How
753b105320cherry-picks the ingest-types sync [chore] Update Ingest API types from cloud@469d54e #20666 (0ab5b7bc87, cloud@469d54e). fix(workspace): separate roster viewing from member management #20674 readscan_manage_members, whichcore/1.56did not have inpackages/ingest-types. On main it arrived through [chore] Update Ingest API types from cloud@469d54e #20666, not through fix(workspace): separate roster viewing from member management #20674. The only conflict was a doc comment onAgentMessage.contentintypes.gen.ts; it keeps thecore/1.56text because that branch does not typeattachment_refs.BillingCapabilities.can_manage_membersandzBillingCapabilities.can_manage_membersmatch main.c065c20bb9cherry-picks fix(workspace): separate roster viewing from member management #20674.Conflict resolution
browser_tests/tests/dialogs/memberRoleChange.spec.ts. Main uses theMembersSettingsPanelpage object;core/1.56uses local helpers (openMembersTab,memberRow,menuButton,openChangeRoleSubmenu). The page object is not pulled in. The three test changes from fix(workspace): separate roster viewing from member management #20674 are ported to the local helpers with the same mocked capabilities, invites and assertions: full workspace keeps member and pending-invite management, team member views and searches the roster without management controls, and the personal workspace test shows its pending invite.core/1.56has notoasttest fixture, sotoast.withText('Invite resent')becomespage.getByText('Invite resent'), matching the existingRole updatedassertion in this spec.WorkspaceMembersPanelContent.test.tsandWorkspaceSettingsPanelContent.test.tsmerged cleanly but failed withNo PrimeVue Toast provided!. After fix(workspace): separate roster viewing from member management #20674 these tests mount the realuseMembersPanel, which still usesprimevue/usetoastoncore/1.56(the design-system toast swap [Phase 6a] Replace PrimeVue Toast with design-system toast #16313 is main-only). Both files now mockprimevue/usetoastthe same wayuseMembersPanel.test.tsalready does on this branch.Verification
pnpm exec vitest run src/platform/workspace/composables/useMembersPanel.test.ts src/platform/workspace/components/dialogs/settings src/platform/workspace/composables/useBillingCapabilities.test.ts packages/account-core/src/core/billing/capabilities.test.ts: 14 files, 366 tests passed.pnpm exec vitest run src/platform/workspace/stores/teamWorkspaceStore.test.ts packages/account-core/src/core/billing src/platform/workspace/billing/sdk src/platform/workspace/api/workspaceApi.test.ts src/platform/auth/webSessionFlagOn.test.ts: 13 files, 606 tests passed.pnpm typecheck:browser: clean.oxfmt --checkandoxlint --type-awareon the touched files: clean.typecheck:browser,typecheck:account-core) and pre-push hook passed.@cloudspec runs in CI.AS IS / TO BE
Same as #20674; this PR carries its behavior unchanged. No new screenshots for the backport.