Repository navigation
[backport cloud/1.56] fix(workspace): separate roster viewing from member management (#20674) - #20716
Conversation
Cloud member-management controls combined server permissions with seat and subscription state, allowing the UI to disagree with the capabilities response. Use `can_manage_members` for member menus and pending-invite loading, visibility, revoke and resend. Invitation creation follows `can_invite_members`. Roster viewing is separate: a successful scoped members response shows the returned rows, role column and search for ordinary members too. Single-member personal layout and desktop behavior are preserved. Member and invite reads independently ignore superseded responses. Permission revocation hides loaded invitations; roster viewing is not filtered by management permission. Generated API types are already on main and excluded from this diff. Read-only production checks on 2026-10-09 confirmed `can_manage_members` support on v0.453.0 (8/8 ingest and 4/4 billing-api pods updated and ready). Capability decoding uses the strict generated contract. Effective invitation capacity is a separate backend rollout; verify the combined behavior in test/staging before that rollout. Validation: 339 focused component/store tests with coverage, 36 capability-reader tests, and nine Cloud browser tests pass. Normal formatting, lint, typechecks and unused-code checks pass. The Fallow audit also passes with clean-runner inputs and estimated coverage, matching CI. CI and human re-review remain pending. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit cb72d45)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-10T20:24:55.341Z",
"gitSha": "56782920380524a3cc1e1cf1312d270106c5a3e5",
"branch": "backport-20674-to-cloud-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2017.3999999999523,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.8190000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.997,
"heapDeltaBytes": 527740,
"heapUsedBytes": 68607720,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.844999999999992,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2023.565000000076,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.254000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.93600000000004,
"heapDeltaBytes": 578316,
"heapUsedBytes": 67746840,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.894000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1875.4229999999552,
"styleRecalcs": 78,
"styleRecalcDurationMs": 21.91,
"layouts": 12,
"layoutDurationMs": 5.442000000000001,
"taskDurationMs": 865.562,
"heapDeltaBytes": -2128928,
"heapUsedBytes": 66257164,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 164.31799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66607142857143,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1871.2449999999308,
"styleRecalcs": 78,
"styleRecalcDurationMs": 20.733,
"layouts": 12,
"layoutDurationMs": 5.082000000000001,
"taskDurationMs": 880.9200000000001,
"heapDeltaBytes": -2197088,
"heapUsedBytes": 66009740,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 162.916,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571424,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.7949999999955,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.419999999999998,
"layouts": 6,
"layoutDurationMs": 1.226,
"taskDurationMs": 364.7699999999999,
"heapDeltaBytes": 4107612,
"heapUsedBytes": 72121072,
"domNodes": 53,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 14.454999999999995,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66699029126214,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1677.6439999999866,
"styleRecalcs": 33,
"styleRecalcDurationMs": 10.461,
"layouts": 6,
"layoutDurationMs": 1.316,
"taskDurationMs": 346.344,
"heapDeltaBytes": 4041952,
"heapUsedBytes": 72112924,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.993000000000004,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653473,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 695.6860000000233,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.199,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.90600000000006,
"heapDeltaBytes": -7388968,
"heapUsedBytes": 61625680,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.287,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668292682926822,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 733.449999999948,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.765000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.49299999999994,
"heapDeltaBytes": -6775436,
"heapUsedBytes": 61334224,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 172.62800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1179.4229999999857,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 906.9999999999999,
"heapDeltaBytes": 15479412,
"heapUsedBytes": 84099728,
"domNodes": 0,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 59.592000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 552,
"frameDurationMs": 34.80588235294117,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1163.6529999999539,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 838.3349999999999,
"heapDeltaBytes": 38629772,
"heapUsedBytes": 108421972,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 63.78800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 538,
"frameDurationMs": 34.31176470588234,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 809.2470000000276,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.09600000000006,
"heapDeltaBytes": 17370732,
"heapUsedBytes": 104620888,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 149.74699999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 184,
"frameDurationMs": 24.020588235294138,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 869.9430000000348,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.1460000000002,
"heapDeltaBytes": -7757764,
"heapUsedBytes": 79043244,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 172.79100000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 212,
"frameDurationMs": 24.76000000000001,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10121.469999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9140.806,
"heapDeltaBytes": 774424,
"heapUsedBytes": 86015284,
"domNodes": -172,
"jsHeapTotalBytes": -2494464,
"scriptDurationMs": 7438.927,
"eventListeners": -82,
"totalBlockingTimeMs": 820,
"frameDurationMs": 31.319504643962844,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10306.007000000023,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.07900000000000094,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9346.499,
"heapDeltaBytes": -9095304,
"heapUsedBytes": 76478728,
"domNodes": -142,
"jsHeapTotalBytes": 126976,
"scriptDurationMs": 7644.3859999999995,
"eventListeners": -78,
"totalBlockingTimeMs": 781,
"frameDurationMs": 31.356534954407298,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9323.219999999992,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.47900000000000026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8477.027,
"heapDeltaBytes": -1706532,
"heapUsedBytes": 83881100,
"domNodes": -143,
"jsHeapTotalBytes": -9572352,
"scriptDurationMs": 6852.790000000001,
"eventListeners": -82,
"totalBlockingTimeMs": 444,
"frameDurationMs": 30.545573770491806,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9264.233999999988,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5529999999999979,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8407.651,
"heapDeltaBytes": 8335512,
"heapUsedBytes": 93558092,
"domNodes": -142,
"jsHeapTotalBytes": -11669504,
"scriptDurationMs": 6767.261,
"eventListeners": -74,
"totalBlockingTimeMs": 383,
"frameDurationMs": 30.346254071661235,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2037.7859999999828,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.6100000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.0559999999999,
"heapDeltaBytes": -11904916,
"heapUsedBytes": 67480256,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 43.132000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2011.5129999999226,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.897000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.2629999999999,
"heapDeltaBytes": -8548960,
"heapUsedBytes": 76778580,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 45.52100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2552.4359999999433,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.083,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1642.1870000000004,
"heapDeltaBytes": -20352940,
"heapUsedBytes": 68763092,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 876.3689999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66578947368421,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2719.462999999905,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.955,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1720.3429999999998,
"heapDeltaBytes": -18812336,
"heapUsedBytes": 70654200,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 892.336,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666049382716047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3810.141000000044,
"styleRecalcs": 70,
"styleRecalcDurationMs": 16.259999999999998,
"layouts": 60,
"layoutDurationMs": 17.588,
"taskDurationMs": 1784.5259999999998,
"heapDeltaBytes": 6383324,
"heapUsedBytes": 88524392,
"domNodes": 24,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 858.0649999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665938864628824,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3712.1779999999944,
"styleRecalcs": 68,
"styleRecalcDurationMs": 15.192999999999998,
"layouts": 60,
"layoutDurationMs": 17.155,
"taskDurationMs": 1780.779,
"heapDeltaBytes": -18893556,
"heapUsedBytes": 68489248,
"domNodes": 24,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 861.6740000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66591928251121,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3133.1860000000233,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.620000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2026.3629999999998,
"heapDeltaBytes": 17574388,
"heapUsedBytes": 86280404,
"domNodes": 0,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 1084.4019999999998,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75537634408602,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3161.367000000041,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.226999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2035.3880000000001,
"heapDeltaBytes": 8518788,
"heapUsedBytes": 77676932,
"domNodes": 0,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 1069.235,
"eventListeners": 180,
"totalBlockingTimeMs": 1,
"frameDurationMs": 16.843850267379676,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2017.3449999999775,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.042000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 557.5590000000001,
"heapDeltaBytes": -9449520,
"heapUsedBytes": 80433732,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 41.32799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2014.1069999999672,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.2309999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.93700000000007,
"heapDeltaBytes": -11005604,
"heapUsedBytes": 70488292,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 38.897,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 626.4740000000302,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.796999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.904,
"heapDeltaBytes": -11994484,
"heapUsedBytes": 58100212,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 146.893,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 645.8740000000489,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.759,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.17799999999994,
"heapDeltaBytes": -11772652,
"heapUsedBytes": 57830808,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 144.663,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.9140000000143,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.344,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.138,
"heapDeltaBytes": 1062484,
"heapUsedBytes": 71733532,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.644,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.9819999999327,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.056999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.88100000000003,
"heapDeltaBytes": 1085004,
"heapUsedBytes": 70593344,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.062999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1753.9610000000039,
"styleRecalcs": 77,
"styleRecalcDurationMs": 21.035999999999998,
"layouts": 16,
"layoutDurationMs": 6.482000000000001,
"taskDurationMs": 845.048,
"heapDeltaBytes": -5948280,
"heapUsedBytes": 64053772,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 122.90400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1719.13799999993,
"styleRecalcs": 78,
"styleRecalcDurationMs": 20.013999999999996,
"layouts": 16,
"layoutDurationMs": 6.111999999999999,
"taskDurationMs": 815.1740000000001,
"heapDeltaBytes": -5999388,
"heapUsedBytes": 63794740,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 116.539,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1390.792000000033,
"styleRecalcs": 17,
"styleRecalcDurationMs": 30.25599999999999,
"layouts": 5,
"layoutDurationMs": 14.406999999999996,
"taskDurationMs": 1074.395,
"heapDeltaBytes": 1369152,
"heapUsedBytes": 94553180,
"domNodes": 14227,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 33.098,
"eventListeners": 2463,
"totalBlockingTimeMs": 139,
"frameDurationMs": 19.718309859154928,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9786.304999999971,
"styleRecalcs": 250,
"styleRecalcDurationMs": 46.892,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6044.1720000000005,
"heapDeltaBytes": -18011012,
"heapUsedBytes": 70854992,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 3003.184,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665928449744463,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9931.990000000042,
"styleRecalcs": 250,
"styleRecalcDurationMs": 46.843999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6157.9839999999995,
"heapDeltaBytes": -16040932,
"heapUsedBytes": 72401288,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 3123.628,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66605042016807,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 20063.64199999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19635.306999999997,
"heapDeltaBytes": -14427744,
"heapUsedBytes": 198732408,
"domNodes": -3045,
"jsHeapTotalBytes": 8409088,
"scriptDurationMs": 372.88599999999997,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.44736842105262,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 20121.01700000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19525.357,
"heapDeltaBytes": -34913844,
"heapUsedBytes": 181665068,
"domNodes": -3045,
"jsHeapTotalBytes": 11325440,
"scriptDurationMs": 353.105,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.99032258064516,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 26344.94799999993,
"styleRecalcs": 182,
"styleRecalcDurationMs": 32.70000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 26145.711000000003,
"heapDeltaBytes": -24230852,
"heapUsedBytes": 185841860,
"domNodes": -3045,
"jsHeapTotalBytes": 892928,
"scriptDurationMs": 1057.0739999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 36,
"frameDurationMs": 52.07312252964427,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 25722.645999999942,
"styleRecalcs": 182,
"styleRecalcDurationMs": 25.01300000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 25446.415,
"heapDeltaBytes": -46158592,
"heapUsedBytes": 166964664,
"domNodes": -3045,
"jsHeapTotalBytes": 6983680,
"scriptDurationMs": 1021.9209999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 92,
"frameDurationMs": 49.07557251908398,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 7498.470999999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.34200000000003,
"layouts": 20,
"layoutDurationMs": 30.23200000000001,
"taskDurationMs": 7427.7480000000005,
"heapDeltaBytes": 993192,
"heapUsedBytes": 214625628,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 149.324,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.60348837209302,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 7394.2369999999755,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.668,
"layouts": 20,
"layoutDurationMs": 27.245000000000005,
"taskDurationMs": 7291.49,
"heapDeltaBytes": 909964,
"heapUsedBytes": 215901976,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 143.72500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 31,
"frameDurationMs": 43.27309941520468,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10599.824000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10457.946999999998,
"heapDeltaBytes": -34324344,
"heapUsedBytes": 179784748,
"domNodes": -3045,
"jsHeapTotalBytes": 6574080,
"scriptDurationMs": 191.93400000000005,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.21287878787879,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10571.970000000078,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10432.413999999999,
"heapDeltaBytes": -16482384,
"heapUsedBytes": 196304616,
"domNodes": -3045,
"jsHeapTotalBytes": 7348224,
"scriptDurationMs": 179.55699999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.785714285714285,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 989.5389999999225,
"styleRecalcs": 14,
"styleRecalcDurationMs": 22.406000000000002,
"layouts": 3,
"layoutDurationMs": 1.01,
"taskDurationMs": 147.61900000000003,
"heapDeltaBytes": 6450176,
"heapUsedBytes": 72119184,
"domNodes": 104,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 15.810999999999998,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.953448275862073,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 521.9740000000002,
"styleRecalcs": 16,
"styleRecalcDurationMs": 19.068,
"layouts": 5,
"layoutDurationMs": 2.2950000000000004,
"taskDurationMs": 144.36100000000002,
"heapDeltaBytes": 5682156,
"heapUsedBytes": 70846492,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.024000000000008,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1089.082999999846,
"styleRecalcs": 78,
"styleRecalcDurationMs": 126.805,
"layouts": 76,
"layoutDurationMs": 33.446999999999996,
"taskDurationMs": 1057.5220000000002,
"heapDeltaBytes": 19858168,
"heapUsedBytes": 85971812,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 405.255,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66615384615385,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1020.2409999999418,
"styleRecalcs": 78,
"styleRecalcDurationMs": 124.613,
"layouts": 76,
"layoutDurationMs": 33.09,
"taskDurationMs": 1000.517,
"heapDeltaBytes": 18944572,
"heapUsedBytes": 86472448,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 382.424,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664516129032254,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1629.2170000001533,
"styleRecalcs": 78,
"styleRecalcDurationMs": 367.089,
"layouts": 76,
"layoutDurationMs": 35.473,
"taskDurationMs": 1600.223,
"heapDeltaBytes": 8720416,
"heapUsedBytes": 114134832,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 479.45799999999997,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.16419753086421,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1660.3460000001178,
"styleRecalcs": 78,
"styleRecalcDurationMs": 365.02299999999997,
"layouts": 76,
"layoutDurationMs": 35.739,
"taskDurationMs": 1630.423,
"heapDeltaBytes": 8450176,
"heapUsedBytes": 115699952,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 489.962,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.57530864197531,
"p95FrameDurationMs": 33.399999999999636
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2200 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 56bbd9bac09144458f69f206858398c3db325bb5
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ETip All tests passed.
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.56 #20716 +/- ##
=============================================
Coverage ? 85.14%
=============================================
Files ? 3522
Lines ? 169287
Branches ? 46129
=============================================
Hits ? 144132
Misses ? 23165
Partials ? 1990
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
christian-byrne
left a comment
There was a problem hiding this comment.
Production code matches #20674 exactly and fits the cloud/1.56 code around it.
Blocking: the ported e2e test full workspace keeps member and pending-invite management fails on this branch on every retry. Pending-invite actions on cloud/1.56 are plain buttons in a popover, not menu items, so the two locators below need to change.
#20715 (the core/1.56 backport) has the identical spec and fails the same way.
| const inviteRow = memberRow(content, invites[0].email) | ||
| await expect(inviteRow).toBeVisible() | ||
| await menuButton(inviteRow).click() | ||
| await page.getByRole('menuitem', { name: 'Resend invite' }).click() |
There was a problem hiding this comment.
issue: This click times out on every retry in CI (cloud Playwright shard 3, and the new-tests video job fails the same way). On cloud/1.56, PendingInvitesList.vue renders Resend and Cancel as plain Buttons inside MoreButton (a PrimeVue popover). Main uses the Reka Menu there, so nothing on this branch has the menuitem role. Scope to the popover and use the button role:
| await page.getByRole('menuitem', { name: 'Resend invite' }).click() | |
| await page | |
| .getByTestId(TestIds.menu.moreMenuContent) | |
| .getByRole('button', { name: 'Resend invite' }) | |
| .click() |
Needs import { TestIds } from '@e2e/fixtures/selectors'. TestIds.menu.moreMenuContent is the popover's existing test id.
| await page.getByRole('menuitem', { name: 'Resend invite' }).click() | ||
| await expect(page.getByText('Invite resent')).toBeVisible() | ||
| await menuButton(inviteRow).click() | ||
| await page.getByRole('menuitem', { name: 'Cancel invite' }).click() |
There was a problem hiding this comment.
issue: Same mismatch for Cancel invite. CI never reaches this line, so it fails next once line 115 is fixed.
| await page.getByRole('menuitem', { name: 'Cancel invite' }).click() | |
| await page | |
| .getByTestId(TestIds.menu.moreMenuContent) | |
| .getByRole('button', { name: 'Cancel invite' }) | |
| .click() |
On 1.56 PendingInvitesList renders Resend and Cancel as Buttons inside the MoreButton popover, not Reka menu items.
christian-byrne
left a comment
There was a problem hiding this comment.
Re-reviewed after the fix for both findings from the earlier changes-requested pass on this PR (the same roster-viewing backport as PR 20715, here onto cloud/1.56).
- Both flagged lines (
memberRoleChange.spec.ts's Resend-invite and Cancel-invite clicks, which timed out in CI because they weren't scoped to the right menu content) now readpage.getByTestId(TestIds.menu.moreMenuContent).getByRole('button', ...), matching the exact suggestion from the original findings -- verified directly against the file content at this head, not just the author's reply claiming it. - Both threads are now outdated (the flagged lines changed) rather than resolved-without-a-fix.
- CI is now fully green where it previously failed at the same two spots.
Approved.
Why
Manual backport of #20674 (
cb72d4536a) tocloud/1.56. The auto-backport failed on conflicts. #20674 makes member menus and pending-invite management followcan_manage_members, invitation creation followcan_invite_members, and lets ordinary members view and search the returned roster.How
ec50e35cb8cherry-picks fix(workspace): separate roster viewing from member management #20674. The ingest-types sync [chore] Update Ingest API types from cloud@469d54e #20666 is not included:cloud/1.56already hascan_manage_membersinpackages/ingest-types/src/types.gen.tsandzod.gen.ts.core/1.56backport [backport core/1.56] fix(workspace): separate roster viewing from member management (#20674) #20715; the spec and both settings test files are identical on the two release branches.Conflict resolution
browser_tests/tests/dialogs/memberRoleChange.spec.ts. Main uses theMembersSettingsPanelpage object;cloud/1.56uses local helpers (openMembersTab,memberRow,menuButton,openChangeRoleSubmenu). The page object is not pulled in. The three test changes from fix(workspace): separate roster viewing from member management #20674 are ported to the local helpers with the same mocked capabilities, invites and assertions: full workspace keeps member and pending-invite management, team member views and searches the roster without management controls, and the personal workspace test shows its pending invite.cloud/1.56has notoasttest fixture, sotoast.withText('Invite resent')becomespage.getByText('Invite resent'), matching the existingRole updatedassertion in this spec.WorkspaceMembersPanelContent.test.tsandWorkspaceSettingsPanelContent.test.tsmerged cleanly but failed withNo PrimeVue Toast provided!. After fix(workspace): separate roster viewing from member management #20674 these tests mount the realuseMembersPanel, which still usesprimevue/usetoastoncloud/1.56(the design-system toast swap [Phase 6a] Replace PrimeVue Toast with design-system toast #16313 is main-only). Both files now mockprimevue/usetoastthe same wayuseMembersPanel.test.tsalready does on this branch.Verification
pnpm exec vitest run src/platform/workspace/composables/useMembersPanel.test.ts src/platform/workspace/components/dialogs/settings src/platform/workspace/composables/useBillingCapabilities.test.ts packages/account-core/src/core/billing/capabilities.test.ts: 14 files, 366 tests passed.pnpm exec vitest run src/platform/workspace/stores/teamWorkspaceStore.test.ts: 119 tests passed.pnpm typecheck:browser: clean.oxfmt --checkandoxlint --type-awareon the touched files: clean.typecheck:browser,typecheck:account-core) and pre-push hook passed.@cloudspec runs in CI.AS IS / TO BE
Same as #20674; this PR carries its behavior unchanged. No new screenshots for the backport.