Skip to content

fix: use createUuidv4 fallback for insecure-context origins - #16269

Merged
christian-byrne merged 2 commits into
christian-byrne/integration-candidate-v2-ci-fixfrom
christian-byrne/fix-insecure-context-uuid
Aug 30, 2026
Merged

christian-byrne merged 2 commits into
christian-byrne/integration-candidate-v2-ci-fixfrom
christian-byrne/fix-insecure-context-uuid

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Agent panel empty on plain-HTTP origins. Root cause: crypto.randomUUID missing outside secure contexts. Fix: existing createUuidv4 util.

Full context for agent readers

Symptom (bbc #103): dev1 QA server at http://100.88.77.62:5173 renders an empty agent panel. Console: crypto.randomUUID is not a function thrown from useAgentCrdtFollower.ts:119 during AgentPanelRoot.vue setup.

Root cause: crypto.randomUUID is only available in secure contexts (https/localhost). Plain-HTTP LAN/tailnet origins lack it, so the CRDT follower composable throws at setup and the panel renders empty. Same failure family affects local ComfyUI on HTTP LAN origins — a real product bug, not just a QA-rig artifact (Christian ruled agent must work local + cloud).

Fix: replace direct crypto.randomUUID() calls with the repo-convention createUuidv4() (src/utils/uuid.ts, secure-context fallback chain via getRandomValues):

  • src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts — tabId mint
  • src/workbench/extensions/agent/crdt/opEnvelope.ts — mintOpId() (dashes stripped, format preserved)
  • src/views/GraphView.vue — tab-count tracking id

Validation: pnpm typecheck green; vitest run src/workbench/extensions/agent/crdt 157/157 pass; eslint clean on touched files (one pre-existing unrelated warning in GraphView.vue).

Workaround until deployed: use the tailscale-serve HTTPS URL (secure context).

Base = christian-byrne/integration-candidate-v2-ci-fix @ ea59931 (dev1 serving branch; 120s ff-only auto-pull picks this up on merge).

crypto.randomUUID is only available in secure contexts. On plain-HTTP
LAN/tailnet origins (e.g. http://100.88.77.62:5173) the agent CRDT
follower threw at setup, leaving the agent panel empty, and mintOpId /
tab-count tracking hit the same failure.

Replace direct crypto.randomUUID calls in useAgentCrdtFollower,
opEnvelope, and GraphView with the existing createUuidv4 util, which
falls back to getRandomValues when randomUUID is unavailable.
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 30, 2026
@coderabbitai

coderabbitai Bot commented Aug 30, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ea943e8d-771b-4e4e-8016-236087507246

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 30, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/30/2026, 02:07:02 AM UTC

Links

🎭 Playwright: ❌ 1793 passed, 47 failed · 1 flaky

❌ Failed Tests

📊 Browser Reports
  • chromium: View Report (✅ 1782 / ❌ 42 / ⚠️ 1 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 8 / ❌ 5 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.7 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.1 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.3 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.7 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.8 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.5 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.1 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.7 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.0 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.9 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 124ms TBT · 99.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.3 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 168.2 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 142ms TBT · 172.3 MB heap
vue-node-resize-workload: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 489ms TBT · 177.2 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.7 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 504ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 67.7 MB
canvas-idle: DOM nodes -280
canvas-idle: event listeners -170
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 42ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 79
canvas-mouse-sweep: task duration 938ms
canvas-mouse-sweep: script duration 152ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 72.1 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -171
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 15ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 29
canvas-zoom-sweep: task duration 349ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.4 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 454ms
dom-widget-clipping: script duration 156ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 84.3 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 577ms
large-graph-idle: script duration 37ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.7 MB
large-graph-idle: DOM nodes -268
large-graph-idle: event listeners -154
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 64
large-graph-pan: task duration 1518ms
large-graph-pan: script duration 731ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 80.8 MB
large-graph-pan: DOM nodes -137
large-graph-pan: event listeners -76
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1629ms
large-graph-zoom: script duration 730ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 73.5 MB
large-graph-zoom: DOM nodes -140
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1876ms
legacy-node-drag: script duration 934ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 83.9 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 7ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 631ms
minimap-idle: script duration 39ms
minimap-idle: TBT 0ms
minimap-idle: heap used 78.1 MB
minimap-idle: DOM nodes -280
minimap-idle: event listeners -185
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 404ms
subgraph-dom-widget-clipping: script duration 140ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 82.7 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 487ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 60.0 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -216
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 35ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 75
subgraph-mouse-sweep: task duration 800ms
subgraph-mouse-sweep: script duration 103ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 68.9 MB
subgraph-mouse-sweep: DOM nodes -300
subgraph-mouse-sweep: event listeners -217
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 30ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 903ms
subgraph-transition-enter: script duration 29ms
subgraph-transition-enter: TBT 124ms
subgraph-transition-enter: heap used 99.3 MB
subgraph-transition-enter: DOM nodes 13671
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 39ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5471ms
viewport-pan-sweep: script duration 2444ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 87.3 MB
viewport-pan-sweep: DOM nodes -265
viewport-pan-sweep: event listeners -131
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17037ms
vue-large-graph-idle: script duration 287ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 168.2 MB
vue-large-graph-idle: DOM nodes -6551
vue-large-graph-idle: event listeners -7479
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 20ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 178
vue-large-graph-pan: task duration 21776ms
vue-large-graph-pan: script duration 890ms
vue-large-graph-pan: TBT 142ms
vue-large-graph-pan: heap used 172.3 MB
vue-large-graph-pan: DOM nodes -6551
vue-large-graph-pan: event listeners -7475
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 74ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6276ms
vue-node-resize-workload: script duration 114ms
vue-node-resize-workload: TBT 489ms
vue-node-resize-workload: heap used 177.2 MB
vue-node-resize-workload: DOM nodes -6555
vue-node-resize-workload: event listeners -7476
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 15ms
workflow-execution: layout count 3
workflow-execution: style recalc count 8
workflow-execution: task duration 86ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.7 MB
workflow-execution: DOM nodes 113
workflow-execution: event listeners 74
Raw data
{
  "timestamp": "2026-08-30T02:24:11.404Z",
  "gitSha": "fdf77c08deac61dd7a87fb1808abd9b679988e22",
  "branch": "christian-byrne/fix-insecure-context-uuid",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2027.0599999998922,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.121,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 508.15600000000006,
      "heapDeltaBytes": -6070584,
      "heapUsedBytes": 64248340,
      "domNodes": -280,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 9.138999999999998,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2033.0050000000028,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.793000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 500.73900000000003,
      "heapDeltaBytes": 7736712,
      "heapUsedBytes": 77660628,
      "domNodes": -280,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 8.543999999999999,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2091.0780000001523,
      "styleRecalcs": 84,
      "styleRecalcDurationMs": 48.296,
      "layouts": 14,
      "layoutDurationMs": 5.258,
      "taskDurationMs": 1027.3980000000001,
      "heapDeltaBytes": -2320324,
      "heapUsedBytes": 67125960,
      "domNodes": -280,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 163.102,
      "eventListeners": -187,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1768.7590000000455,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 36.317,
      "layouts": 14,
      "layoutDurationMs": 4.382000000000001,
      "taskDurationMs": 848.1840000000001,
      "heapDeltaBytes": 14142344,
      "heapUsedBytes": 83999912,
      "domNodes": -281,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 140.23499999999999,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1668.1929999999738,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 15.15,
      "layouts": 6,
      "layoutDurationMs": 1.05,
      "taskDurationMs": 350.20099999999996,
      "heapDeltaBytes": 4763796,
      "heapUsedBytes": 74927548,
      "domNodes": 76,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 10.052999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1666.6689999999562,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 15.341999999999999,
      "layouts": 6,
      "layoutDurationMs": 0.9820000000000002,
      "taskDurationMs": 348.71999999999997,
      "heapDeltaBytes": 4430064,
      "heapUsedBytes": 74907560,
      "domNodes": 76,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 9.936999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 675.7280000001629,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.981999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 446.967,
      "heapDeltaBytes": 18172320,
      "heapUsedBytes": 88329080,
      "domNodes": 18,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 152.15400000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 646.0849999998572,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.328999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 461.744,
      "heapDeltaBytes": 18158244,
      "heapUsedBytes": 88470496,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 160.49,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2002.1150000000034,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.554999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 556.071,
      "heapDeltaBytes": 21898196,
      "heapUsedBytes": 87483236,
      "domNodes": -268,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 36.962999999999994,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2041.5040000000317,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.215,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 598.9,
      "heapDeltaBytes": -12279112,
      "heapUsedBytes": 88017196,
      "domNodes": -268,
      "jsHeapTotalBytes": -1609728,
      "scriptDurationMs": 37.103,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2106.1489999999594,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 8.520999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1472.9450000000002,
      "heapDeltaBytes": 22262540,
      "heapUsedBytes": 88439896,
      "domNodes": 0,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 717.6179999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2204.529000000093,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.810999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1562.977,
      "heapDeltaBytes": -20317948,
      "heapUsedBytes": 81057372,
      "domNodes": -273,
      "jsHeapTotalBytes": -1122304,
      "scriptDurationMs": 744.173,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3423.755999999912,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.435,
      "layouts": 60,
      "layoutDurationMs": 12.735,
      "taskDurationMs": 1636.861,
      "heapDeltaBytes": 9942368,
      "heapUsedBytes": 77224488,
      "domNodes": -280,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 731.5780000000001,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3438.3950000001278,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.486999999999997,
      "layouts": 60,
      "layoutDurationMs": 12.547,
      "taskDurationMs": 1621.2530000000002,
      "heapDeltaBytes": 8804488,
      "heapUsedBytes": 76873956,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 727.89,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2988.760000000184,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.469999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1850.559,
      "heapDeltaBytes": 17015044,
      "heapUsedBytes": 85502312,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 926.768,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3028.2589999999345,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.398000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1900.6759999999997,
      "heapDeltaBytes": 22042548,
      "heapUsedBytes": 90491212,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 940.606,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2059.5190000001367,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 6.239999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 632.612,
      "heapDeltaBytes": 3681216,
      "heapUsedBytes": 80730084,
      "domNodes": -283,
      "jsHeapTotalBytes": -598016,
      "scriptDurationMs": 39.583000000000006,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2054.139999999961,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 8.342000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 629.5450000000002,
      "heapDeltaBytes": 6289364,
      "heapUsedBytes": 83098348,
      "domNodes": -277,
      "jsHeapTotalBytes": -1384448,
      "scriptDurationMs": 39.234,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 592.4130000000787,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.71,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 404.503,
      "heapDeltaBytes": 14005772,
      "heapUsedBytes": 86448192,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 138.649,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 589.2499999999927,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.219999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 402.95500000000004,
      "heapDeltaBytes": 14685684,
      "heapUsedBytes": 86895272,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 140.86300000000003,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.6340000001528,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.183999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 484.24100000000004,
      "heapDeltaBytes": -15217060,
      "heapUsedBytes": 57307280,
      "domNodes": -297,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 7.002000000000002,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2006.5899999999601,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.885000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 490.291,
      "heapDeltaBytes": -3917676,
      "heapUsedBytes": 68580984,
      "domNodes": -297,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 7.148999999999999,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1741.5399999999863,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 35.136,
      "layouts": 18,
      "layoutDurationMs": 5.612,
      "taskDurationMs": 805.108,
      "heapDeltaBytes": -2276904,
      "heapUsedBytes": 63409792,
      "domNodes": -300,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 102.664,
      "eventListeners": -233,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1714.1269999999622,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 34.40599999999999,
      "layouts": 18,
      "layoutDurationMs": 5.927,
      "taskDurationMs": 795.2660000000001,
      "heapDeltaBytes": 8551996,
      "heapUsedBytes": 80990388,
      "domNodes": -299,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 102.46200000000002,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1367.5869999999577,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 29.565,
      "layouts": 14,
      "layoutDurationMs": 14.078,
      "taskDurationMs": 903.0540000000002,
      "heapDeltaBytes": 20736748,
      "heapUsedBytes": 104092344,
      "domNodes": 13671,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 28.938000000000006,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 124,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8335.202999999865,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 39.419999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5460.08,
      "heapDeltaBytes": -10732140,
      "heapUsedBytes": 89514056,
      "domNodes": -265,
      "jsHeapTotalBytes": -598016,
      "scriptDurationMs": 2433.7660000000005,
      "eventListeners": -131,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8260.205999999926,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 38.303,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5482.146,
      "heapDeltaBytes": -6932272,
      "heapUsedBytes": 93546216,
      "domNodes": -265,
      "jsHeapTotalBytes": -860160,
      "scriptDurationMs": 2454.246,
      "eventListeners": -131,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17836.056999999983,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17075.662,
      "heapDeltaBytes": -28431396,
      "heapUsedBytes": 176131200,
      "domNodes": -6551,
      "jsHeapTotalBytes": -4907008,
      "scriptDurationMs": 289.922,
      "eventListeners": -7478,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17753.131999999823,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16998.414999999997,
      "heapDeltaBytes": -30274748,
      "heapUsedBytes": 176678492,
      "domNodes": -6551,
      "jsHeapTotalBytes": -360448,
      "scriptDurationMs": 284.05100000000004,
      "eventListeners": -7480,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22178.975000000035,
      "styleRecalcs": 179,
      "styleRecalcDurationMs": 20.535999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21752.392,
      "heapDeltaBytes": -25815812,
      "heapUsedBytes": 176476436,
      "domNodes": -6551,
      "jsHeapTotalBytes": 2609152,
      "scriptDurationMs": 910.934,
      "eventListeners": -7474,
      "totalBlockingTimeMs": 157,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22153.188000000002,
      "styleRecalcs": 177,
      "styleRecalcDurationMs": 19.806999999999963,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21799.368000000002,
      "heapDeltaBytes": -24898708,
      "heapUsedBytes": 184783380,
      "domNodes": -6551,
      "jsHeapTotalBytes": -3940352,
      "scriptDurationMs": 868.27,
      "eventListeners": -7476,
      "totalBlockingTimeMs": 127,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6411.333000000013,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 72.42900000000002,
      "layouts": 20,
      "layoutDurationMs": 23.255,
      "taskDurationMs": 6305.459999999999,
      "heapDeltaBytes": -31173884,
      "heapUsedBytes": 174929300,
      "domNodes": -6551,
      "jsHeapTotalBytes": 10690560,
      "scriptDurationMs": 113.21700000000001,
      "eventListeners": -7476,
      "totalBlockingTimeMs": 479,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6368.34900000008,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 75.01600000000003,
      "layouts": 20,
      "layoutDurationMs": 24.147000000000002,
      "taskDurationMs": 6246.977999999999,
      "heapDeltaBytes": -5616464,
      "heapUsedBytes": 196675028,
      "domNodes": -6559,
      "jsHeapTotalBytes": 18075648,
      "scriptDurationMs": 115.471,
      "eventListeners": -7476,
      "totalBlockingTimeMs": 498,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 102.86300000007031,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 12.788999999999998,
      "layouts": 3,
      "layoutDurationMs": 0.9,
      "taskDurationMs": 70.16699999999997,
      "heapDeltaBytes": 3251768,
      "heapUsedBytes": 71505420,
      "domNodes": 109,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 5.86,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "workflow-execution",
      "durationMs": 457.31399999999667,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 17.34,
      "layouts": 3,
      "layoutDurationMs": 0.9189999999999999,
      "taskDurationMs": 102.61600000000001,
      "heapDeltaBytes": 5121496,
      "heapUsedBytes": 72583040,
      "domNodes": 117,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 8.876000000000001,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

Pre-existing typecheck:browser failure on the base branch:
team_workspaces_enabled is not a key of RemoteConfig and nothing in
src/ reads it (team workspaces gate on the workspace's own type — see
the note in browser_tests/fixtures/data/workspaceAuthFixtures.ts).
@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Aug 30, 2026
@codecov

codecov Bot commented Aug 30, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/views/GraphView.vue 0.00% 1 Missing ⚠️
@@                                Coverage Diff                                 @@
##             christian-byrne/integration-candidate-v2-ci-fix   #16269   +/-   ##
==================================================================================
  Coverage                                                   ?   83.22%           
==================================================================================
  Files                                                      ?     2021           
  Lines                                                      ?   116734           
  Branches                                                   ?    32967           
==================================================================================
  Hits                                                       ?    97152           
  Misses                                                     ?    19233           
  Partials                                                   ?      349           
Flag Coverage Δ
e2e 66.65% <ø> (?)
unit 76.32% <66.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/workbench/extensions/agent/crdt/opEnvelope.ts 100.00% <100.00%> (ø)
...ench/extensions/agent/crdt/useAgentCrdtFollower.ts 94.47% <100.00%> (ø)
src/views/GraphView.vue 71.42% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Merging: all change-relevant checks green; 15 E2E fails = pre-existing base screenshot set, not from this PR.

Full context for agent readers

CI at b47247f: 69 pass / 15 fail / 10 skip.

Green (everything this change touches): test (unit, 18m34s), lint-and-format (7m05s — previous run's browser-typecheck failure fixed by dropping stale team_workspaces_enabled mock key), typecheck, storybook-build, binary-size, licenses, telemetry scan, CLA, AI-co-author check.

Failing (15): playwright-tests (cloud), (mobile-chrome), e2e-status, 12 × playwright-tests-chromium-sharded. This is byte-identical to the failure profile documented as PRE-EXISTING on the base branch stack:

Root cause of those diffs: base branch (integration-candidate-v2-ci-fix) adds the agent toolbar button and diverges from main's committed screenshot baselines; fixing baselines is the base-branch owner's item, out of scope here.

Merge authorization: Christian's standing grant — FE merge allowed for PRs targeting christian-byrne/* branches. This PR targets christian-byrne/integration-candidate-v2-ci-fix. Fix unblocks bbc #103 (empty agent panel on insecure-context HTTP origins, Christian's live dev1 QA surface at 100.88.77.62:5173); dev1's 120s ff-only auto-pull serves it automatically post-merge.

@christian-byrne
christian-byrne merged commit e04d292 into christian-byrne/integration-candidate-v2-ci-fix Aug 30, 2026
79 of 94 checks passed
@christian-byrne
christian-byrne deleted the christian-byrne/fix-insecure-context-uuid branch August 30, 2026 02:25
@huang47 huang47 added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-ui Agent panel, composer, transcript or other user-interface components labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-ui Agent panel, composer, transcript or other user-interface components risk:high PR risk grade (advisory shadow check; grader-owned) size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants