Repository navigation
fix(missing-model): improve gated access accessibility - #14984
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe change adds custom tooltip triggers, count-aware gated-model guidance, live-region announcements, trusted Hugging Face repository links, desktop access fallbacks, and related localization and test coverage. ChangesGated model accessibility
Estimated code review effort: 3 (Moderate) | ~25 minutes Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright: ✅ 1800 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 8.69 MB gzip 🔴 +180 BDetailsSummary
Category Glance App Entry Points — 3.67 kB (baseline 3.67 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.36 MB (baseline 1.36 MB) • 🔴 +1.28 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 565 kB (baseline 565 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 16 unchanged User & Accounts — 27 kB (baseline 27 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 4 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 8 unchanged Data & Services — 3.5 MB (baseline 3.5 MB) • 🔴 +188 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 550 kB (baseline 550 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 21 added / 21 removed / 17 unchanged Vendor & Third-Party — 16.3 MB (baseline 16.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 14 MB (baseline 14 MB) • 🔴 +325 BBundles that do not match a named category
Status: 76 added / 76 removed / 210 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-11T04:33:00.705Z",
"gitSha": "a0a9664a599582f74b1f1ee5c4c402964749b4b4",
"branch": "jaeone94/gated-model-accessibility",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2170.018999999968,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.133000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 557.193,
"heapDeltaBytes": 5889148,
"heapUsedBytes": 70314556,
"domNodes": 20,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 21.393,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2012.599000000023,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.941,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.378,
"heapDeltaBytes": 5877076,
"heapUsedBytes": 70191768,
"domNodes": 16,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 25.018,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2125.4809999999793,
"styleRecalcs": 77,
"styleRecalcDurationMs": 45.987,
"layouts": 12,
"layoutDurationMs": 4.031,
"taskDurationMs": 1123.594,
"heapDeltaBytes": -12798496,
"heapUsedBytes": 51577148,
"domNodes": -282,
"jsHeapTotalBytes": 23044096,
"scriptDurationMs": 151.513,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1870.8970000000136,
"styleRecalcs": 77,
"styleRecalcDurationMs": 44.568999999999996,
"layouts": 12,
"layoutDurationMs": 3.757,
"taskDurationMs": 966.338,
"heapDeltaBytes": 189904,
"heapUsedBytes": 64547648,
"domNodes": 59,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 137.19899999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.6009999999642,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.467000000000002,
"layouts": 6,
"layoutDurationMs": 0.649,
"taskDurationMs": 407.59299999999996,
"heapDeltaBytes": 8517868,
"heapUsedBytes": 72986468,
"domNodes": 79,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 22.578,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.7040000000216,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.182000000000002,
"layouts": 6,
"layoutDurationMs": 0.6329999999999999,
"taskDurationMs": 370.18899999999996,
"heapDeltaBytes": 8712680,
"heapUsedBytes": 72990996,
"domNodes": 77,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 18.269000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 606.2049999999886,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.808,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.17199999999997,
"heapDeltaBytes": -11173252,
"heapUsedBytes": 53217252,
"domNodes": 20,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 62.181,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 706.5650000000687,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.919,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.4649999999999,
"heapDeltaBytes": -11143908,
"heapUsedBytes": 53124888,
"domNodes": 20,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 68.03,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2055.786000000012,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.682999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 735.9339999999999,
"heapDeltaBytes": 7475896,
"heapUsedBytes": 67343420,
"domNodes": -281,
"jsHeapTotalBytes": 3772416,
"scriptDurationMs": 119.947,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2039.9489999999787,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.593,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 817.4010000000001,
"heapDeltaBytes": 7367924,
"heapUsedBytes": 67283940,
"domNodes": -281,
"jsHeapTotalBytes": 3248128,
"scriptDurationMs": 131.351,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2349.4850000000156,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.905000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1426.778,
"heapDeltaBytes": -5001128,
"heapUsedBytes": 55549336,
"domNodes": -286,
"jsHeapTotalBytes": 4820992,
"scriptDurationMs": 476.178,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2181.1119999999846,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.664999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1301.734,
"heapDeltaBytes": -5142464,
"heapUsedBytes": 55403496,
"domNodes": -284,
"jsHeapTotalBytes": 4820992,
"scriptDurationMs": 436.614,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3374.5210000000156,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.515999999999998,
"layouts": 60,
"layoutDurationMs": 7.816,
"taskDurationMs": 1637.0160000000003,
"heapDeltaBytes": 6889616,
"heapUsedBytes": 69466276,
"domNodes": -287,
"jsHeapTotalBytes": 6131712,
"scriptDurationMs": 578.4599999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3516.7040000000043,
"styleRecalcs": 65,
"styleRecalcDurationMs": 16.095,
"layouts": 60,
"layoutDurationMs": 7.418000000000001,
"taskDurationMs": 1694.348,
"heapDeltaBytes": 15244356,
"heapUsedBytes": 77544336,
"domNodes": -286,
"jsHeapTotalBytes": 6131712,
"scriptDurationMs": 594.1769999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2036.6800000000467,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.4,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 827.155,
"heapDeltaBytes": 6743788,
"heapUsedBytes": 67201952,
"domNodes": -283,
"jsHeapTotalBytes": 3772416,
"scriptDurationMs": 129.114,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2041.4389999999685,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.177000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 763.5289999999999,
"heapDeltaBytes": 7088216,
"heapUsedBytes": 67574340,
"domNodes": -285,
"jsHeapTotalBytes": 4034560,
"scriptDurationMs": 124.87100000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 636.6310000000226,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.934999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.659,
"heapDeltaBytes": -10974140,
"heapUsedBytes": 53564208,
"domNodes": 18,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 125.06,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 625.9990000000926,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.958,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 421.61600000000004,
"heapDeltaBytes": -10778548,
"heapUsedBytes": 53629100,
"domNodes": 18,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 123.45499999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2011.1799999999675,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.558,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.548,
"heapDeltaBytes": 5878856,
"heapUsedBytes": 70473948,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 15.158,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2001.7310000000634,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.531,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 566.2009999999999,
"heapDeltaBytes": 5683180,
"heapUsedBytes": 70106728,
"domNodes": 16,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 22.223,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1760.388999999975,
"styleRecalcs": 77,
"styleRecalcDurationMs": 35.888999999999996,
"layouts": 16,
"layoutDurationMs": 4.267,
"taskDurationMs": 878.601,
"heapDeltaBytes": -16404684,
"heapUsedBytes": 47946004,
"domNodes": -279,
"jsHeapTotalBytes": 24354816,
"scriptDurationMs": 95.17399999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1765.0320000000193,
"styleRecalcs": 76,
"styleRecalcDurationMs": 40.775999999999996,
"layouts": 16,
"layoutDurationMs": 4.821000000000001,
"taskDurationMs": 877.87,
"heapDeltaBytes": -3384464,
"heapUsedBytes": 60981140,
"domNodes": 62,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 102.552,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.8679999999986,
"styleRecalcs": 18,
"styleRecalcDurationMs": 34.135,
"layouts": 14,
"layoutDurationMs": 13.456000000000003,
"taskDurationMs": 1039.648,
"heapDeltaBytes": 30650088,
"heapUsedBytes": 98635760,
"domNodes": 13673,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 40.771000000000015,
"eventListeners": 2375,
"totalBlockingTimeMs": 140,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8545.661000000053,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.763999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4776.981999999999,
"heapDeltaBytes": 11795144,
"heapUsedBytes": 71454188,
"domNodes": -283,
"jsHeapTotalBytes": 6062080,
"scriptDurationMs": 1467.18,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8296.111999999994,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.623,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4679.983,
"heapDeltaBytes": 9013556,
"heapUsedBytes": 68363128,
"domNodes": -281,
"jsHeapTotalBytes": 5799936,
"scriptDurationMs": 1442.357,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17609.921000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17573.934,
"heapDeltaBytes": -66844200,
"heapUsedBytes": 156590228,
"domNodes": -8316,
"jsHeapTotalBytes": -6492160,
"scriptDurationMs": 620.145,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17664.320999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17611.594999999998,
"heapDeltaBytes": -55909376,
"heapUsedBytes": 170865196,
"domNodes": -8340,
"jsHeapTotalBytes": -12263424,
"scriptDurationMs": 605.391,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21560.190000000035,
"styleRecalcs": 146,
"styleRecalcDurationMs": 20.116999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21521.741,
"heapDeltaBytes": -33907996,
"heapUsedBytes": 181819664,
"domNodes": -8312,
"jsHeapTotalBytes": -8069120,
"scriptDurationMs": 971.066,
"eventListeners": -16383,
"totalBlockingTimeMs": 278,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20878.647,
"styleRecalcs": 145,
"styleRecalcDurationMs": 17.517000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20840.661999999997,
"heapDeltaBytes": -40202932,
"heapUsedBytes": 177779384,
"domNodes": -8312,
"jsHeapTotalBytes": -9445376,
"scriptDurationMs": 900.687,
"eventListeners": -16383,
"totalBlockingTimeMs": 254,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 466.0780000000386,
"styleRecalcs": 14,
"styleRecalcDurationMs": 21.470999999999997,
"layouts": 2,
"layoutDurationMs": 0.413,
"taskDurationMs": 116.61799999999998,
"heapDeltaBytes": 5061484,
"heapUsedBytes": 68592168,
"domNodes": 126,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 10.445,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 451.86599999999544,
"styleRecalcs": 12,
"styleRecalcDurationMs": 17.606,
"layouts": 3,
"layoutDurationMs": 0.7010000000000002,
"taskDurationMs": 103.525,
"heapDeltaBytes": 5038828,
"heapUsedBytes": 68497408,
"domNodes": 121,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 8.437,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14984 +/- ##
==========================================
+ Coverage 81.22% 81.31% +0.09%
==========================================
Files 1872 1872
Lines 126246 106429 -19817
Branches 39585 32670 -6915
==========================================
- Hits 102541 86544 -15997
+ Misses 23140 19525 -3615
+ Partials 565 360 -205
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 372 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
|
…ibility (#15103) ## ELI5 This carries the already merged gated-model accessibility fix into cloud/1.49. It is the same repair, fitted to the older branch by keeping that branch's test cleanup while adding the new locale reset. ## Motivation The automatic backport of #14984 — fix(missing-model): improve gated access accessibility could not merge one test file because main and cloud/1.49 clean up Vitest mocks differently. The prerequisite missing-model refactor is already present on the target branch, so a separate dependency backport is unnecessary. Resolving the small test-fixture conflict manually lets the 1.49 release line receive the already reviewed accessibility behavior without importing main's unrelated test-infrastructure changes. ## Provenance - **Authored by:** interactive session - **Verified:** focused `pnpm test:unit` run: 6 files and 69 tests passed; `pnpm typecheck`: passed; `pnpm lint`: passed with 0 errors and 59 pre-existing warnings outside the changed files; `pnpm format:check`: 4,516 files passed; `pnpm knip`: passed; `git diff origin/cloud/1.49...HEAD --check`: passed - **Deviations:** None ## Reviewer context - **Type:** bug-fix backport with one mechanical test-fixture conflict resolution - **Slots into:** #14984 — fix(missing-model): improve gated access accessibility ## Summary - Backports the six accessibility, copy, and focused-test changes from #14984 — fix(missing-model): improve gated access accessibility. - Preserves cloud/1.49's explicit `vi.clearAllMocks()` calls while also restoring the English locale before each affected card test. - Does not backport unrelated main-branch test infrastructure. ## Changes - **What:** Updates gated-model announcements, keyboard-accessible guidance, trusted navigation semantics, accessible descriptions, pluralized copy, and their tests. - **Dependencies:** None; the prerequisite refactor is already on cloud/1.49. ## Review Focus Please verify the two resolved `beforeEach` blocks in `MissingModelCard.test.ts` retain both mock cleanup and locale reset; all other files applied cleanly from the merged PR. ## Test plan - [x] Run the six focused unit/component test files on cloud/1.49. - [x] Run typecheck, lint, formatting, and unused-code checks. - [ ] Confirm target-branch CI is green. - [ ] Spot-check the gated-model hint with keyboard and screen-reader navigation if manual release validation is required. No feature flag is added; this backports an accessibility correction already merged on main. ## Screenshots (if applicable) Not included; this backport preserves the visual behavior of the merged PR.
…bility (#15102) ## ELI5 This carries the already merged gated-model accessibility fix into core/1.49. It is the same repair, fitted to the older branch by keeping that branch's test cleanup while adding the new locale reset. ## Motivation The automatic backport of #14984 — fix(missing-model): improve gated access accessibility could not merge one test file because main and core/1.49 clean up Vitest mocks differently. The prerequisite missing-model refactor is already present on the target branch, so a separate dependency backport is unnecessary. Resolving the small test-fixture conflict manually lets the 1.49 release line receive the already reviewed accessibility behavior without importing main's unrelated test-infrastructure changes. ## Provenance - **Authored by:** interactive session - **Verified:** focused `pnpm test:unit` run: 6 files and 69 tests passed; `pnpm typecheck`: passed; `pnpm lint`: passed with 0 errors and 59 pre-existing warnings outside the changed files; `pnpm format:check`: 4,518 files passed; `pnpm knip`: passed; `git diff origin/core/1.49...HEAD --check`: passed - **Deviations:** None ## Reviewer context - **Type:** bug-fix backport with one mechanical test-fixture conflict resolution - **Slots into:** #14984 — fix(missing-model): improve gated access accessibility ## Summary - Backports the six accessibility, copy, and focused-test changes from #14984 — fix(missing-model): improve gated access accessibility. - Preserves core/1.49's explicit `vi.clearAllMocks()` calls while also restoring the English locale before each affected card test. - Does not backport unrelated main-branch test infrastructure. ## Changes - **What:** Updates gated-model announcements, keyboard-accessible guidance, trusted navigation semantics, accessible descriptions, pluralized copy, and their tests. - **Dependencies:** None; the prerequisite refactor is already on core/1.49. ## Review Focus Please verify the two resolved `beforeEach` blocks in `MissingModelCard.test.ts` retain both mock cleanup and locale reset; all other files applied cleanly from the merged PR. ## Test plan - [x] Run the six focused unit/component test files on core/1.49. - [x] Run typecheck, lint, formatting, and unused-code checks. - [ ] Confirm target-branch CI is green. - [ ] Spot-check the gated-model hint with keyboard and screen-reader navigation if manual release validation is required. No feature flag is added; this backports an accessibility correction already merged on main. ## Screenshots (if applicable) Not included; this backport preserves the visual behavior of the merged PR.
## The workflow does not catch the branches it exists for `pr-label-backport.yaml`'s header states its purpose plainly — *"Guarantees that every backport PR carries the `backport` label, **whoever opened it**"* — and explains that manual backports are the case that matters, because `pr-backport.yaml` only labels the PRs it creates itself, and hands off to a human when the cherry-pick conflicts. But `isBackportBranchForBase` matched only the exact branch the workflow generates: ```ts const BACKPORT_BRANCH_PATTERN = /^backport-\d+-to-(.+)$/ ``` A human finishing a conflicted cherry-pick does not produce that. They produce `<user>/backport-<pr>-to-<target>` — what `gh` and most local branch conventions give you. ## This week's worked example **Comfy-Org#15102** and **Comfy-Org#15103** (`jaeone94/backport-14984-to-core-1.49` and `…-cloud-1.49`) were opened by hand after `pr-backport.yaml` failed on Comfy-Org#14984's cherry-pick, and carry the `backport` label **only because someone applied it manually**. That matters because an unlabelled backport is invisible to `backport-auto-merge.yaml` and `pr-assign-release-sheriff.yaml` — both sweep `gh pr list --label backport` — so it sits open until somebody notices. Which is exactly what Comfy-Org#14018–Comfy-Org#14021 are cited for in the workflow's own header. Surveying every backport-titled PR in the repo: the bot's `backport-<n>-to-<target>` branches are all labelled, and the only user-prefixed pair is the one that needed a human. ## Only the prefix widens ```diff -const BACKPORT_BRANCH_PATTERN = /^backport-\d+-to-(.+)$/ +const BACKPORT_BRANCH_PATTERN = /^(?:.*\/)?backport-\d+-to-(.+)$/ ``` The `\d+-to-` core and the existing base check still decide what counts as a backport, so this does **not** loosen the definition: | branch | base | before | after | | --- | --- | --- | --- | | `backport-14979-to-core-1.49` | `core/1.49` | ✅ | ✅ | | `jaeone94/backport-14984-to-core-1.49` | `core/1.49` | ❌ | ✅ | | `jaeone94/backport-14984-to-core-1.49` | `cloud/1.49` | ❌ | ❌ *(target ≠ base)* | | `glary/backport-resilient-partial-failure` | `core/1.49` | ❌ | ❌ | | `deepme987/infra/backport-assign-author` | `main` | ❌ | ❌ | The last two are real branches in this repo — *about* backporting rather than backports. A prefix must not turn them into one, and it doesn't: they have no `<digits>-to-` segment. ## Verification `backport-label.test.ts` **16/16**, with three new cases covering the prefixed form, the prefixed-but-wrong-base rejection, and the two real non-backport branches above. Mutation-checked rather than asserted green — reverting the regex to `^backport-` fails exactly one test (the new prefixed case) and leaves the other 15 passing. ## Disclosure I hit this myself from the other direction. My manual backports Comfy-Org#15095/Comfy-Org#15096 used `backport/<pr>-to-<target>` — a **slash** where the convention uses a hyphen. That one is genuinely off-convention rather than a gap in the rule, so this PR deliberately does **not** widen the pattern to bless it; I fixed those branches' labels by hand instead. Co-authored-by: t <t@t.t>
|
|
|
|
|
|
|
|
ELI5
Think of gated model access like a locked door with one clear sign: everyone should learn why it is locked, and the control should honestly say where it leads. This change makes that sign work for screen readers and keyboards, keeps unsafe destinations from appearing, and uses clear singular or plural wording without changing the visual design.
Motivation
Five public follow-up issues identified gaps that remained after gated metadata was centralized: asynchronously discovered gating could be missed by screen readers, explanation text was hover-dependent for sighted keyboard users, external navigation exposed the wrong role, Download could repeat the same description, and the copy hardcoded a plural. Without this follow-up, people could receive incomplete or misleading guidance depending on input method and runtime. Publishing it after the parent refactor merged keeps the patch focused on accessibility and wording while preserving the existing visual design.
Provenance
Reviewer context
Summary
Changes
Review Focus
Please focus on live-region transition behavior, the trusted URL boundary, link-versus-button semantics across runtimes, and the single-description behavior for Download.
Test plan
Screenshots (if applicable)
Not included; visual design is preserved.
Fixes #14360
Fixes #14361
Fixes #14362
Fixes #14363
Fixes #14368