Repository navigation
feat(errors): distinguish missing-resource severity from blocking errors - #14439
Conversation
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2001 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.34 MB gzip 🔴 +2.11 kBDetailsSummary
Category Glance App Entry Points — 3.71 kB (baseline 3.71 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.39 MB (baseline 1.38 MB) • 🔴 +8.96 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 591 kB (baseline 591 kB) • 🔴 +17 BConfiguration panels, inspectors, and settings screens
Status: 13 added / 13 removed / 14 unchanged User & Accounts — 27.5 kB (baseline 27.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 112 kB (baseline 112 kB) • 🔴 +7 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.46 MB (baseline 3.46 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 551 kB (baseline 551 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 21 added / 21 removed / 16 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 15.1 MB (baseline 15.1 MB) • 🔴 +878 BBundles that do not match a named category
Status: 78 added / 78 removed / 212 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-25T15:26:30.779Z",
"gitSha": "75940a841d73d14c03eb319e1584e32b494862a1",
"branch": "jaeone94/errors-panel-severity-presentation",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2085.3720000000067,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.038000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 603.3219999999999,
"heapDeltaBytes": 12438828,
"heapUsedBytes": 81326052,
"domNodes": -282,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 10.45,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2037.8499999999349,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.299999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 535.879,
"heapDeltaBytes": 11790588,
"heapUsedBytes": 80699528,
"domNodes": -281,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.962000000000002,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2235.5160000000183,
"styleRecalcs": 78,
"styleRecalcDurationMs": 42.06999999999999,
"layouts": 12,
"layoutDurationMs": 2.9819999999999998,
"taskDurationMs": 1247.139,
"heapDeltaBytes": 7001840,
"heapUsedBytes": 76318820,
"domNodes": -279,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 161.78500000000003,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2203.5230000000183,
"styleRecalcs": 78,
"styleRecalcDurationMs": 41.513999999999996,
"layouts": 12,
"layoutDurationMs": 3.5480000000000005,
"taskDurationMs": 1271.4150000000002,
"heapDeltaBytes": 4260376,
"heapUsedBytes": 73143680,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 168.30999999999997,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1741.4590000000203,
"styleRecalcs": 32,
"styleRecalcDurationMs": 20.019000000000002,
"layouts": 6,
"layoutDurationMs": 0.796,
"taskDurationMs": 421.354,
"heapDeltaBytes": 4065792,
"heapUsedBytes": 73001360,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 15.305000000000001,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1719.8110000000497,
"styleRecalcs": 31,
"styleRecalcDurationMs": 19.128999999999998,
"layouts": 6,
"layoutDurationMs": 0.71,
"taskDurationMs": 404.67199999999997,
"heapDeltaBytes": 4107104,
"heapUsedBytes": 73392840,
"domNodes": 75,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 13.664,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 717.2210000000518,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.741000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.579,
"heapDeltaBytes": -7052904,
"heapUsedBytes": 62585620,
"domNodes": 14,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 33.148,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 742.7570000000969,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.1129999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.403,
"heapDeltaBytes": -6864512,
"heapUsedBytes": 62123348,
"domNodes": 16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 35.813,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2053.4509999999955,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.02,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 579.22,
"heapDeltaBytes": -17960808,
"heapUsedBytes": 72440240,
"domNodes": -271,
"jsHeapTotalBytes": -2101248,
"scriptDurationMs": 40.61899999999999,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2056.1629999999695,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.168999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 638.0939999999999,
"heapDeltaBytes": -20280432,
"heapUsedBytes": 70510064,
"domNodes": -273,
"jsHeapTotalBytes": 520192,
"scriptDurationMs": 40.152,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3563.660000000027,
"styleRecalcs": 65,
"styleRecalcDurationMs": 16.192999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2875.371,
"heapDeltaBytes": -14019840,
"heapUsedBytes": 77416552,
"domNodes": -286,
"jsHeapTotalBytes": 5201920,
"scriptDurationMs": 1034.884,
"eventListeners": -151,
"totalBlockingTimeMs": 64,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-pan",
"durationMs": 4120.951999999988,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.532,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3038.1839999999997,
"heapDeltaBytes": -3149568,
"heapUsedBytes": 88534084,
"domNodes": -275,
"jsHeapTotalBytes": 745472,
"scriptDurationMs": 1112.4230000000002,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4483.8399999999865,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.519000000000002,
"layouts": 60,
"layoutDurationMs": 7.662999999999999,
"taskDurationMs": 2645.639,
"heapDeltaBytes": 8311752,
"heapUsedBytes": 74721656,
"domNodes": 24,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 919.633,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 4523.0790000000525,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.581999999999999,
"layouts": 60,
"layoutDurationMs": 7.473,
"taskDurationMs": 2711.064,
"heapDeltaBytes": 16781772,
"heapUsedBytes": 88832480,
"domNodes": -236,
"jsHeapTotalBytes": 221184,
"scriptDurationMs": 918.701,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3204.3409999999994,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.024999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2165.409,
"heapDeltaBytes": 13155492,
"heapUsedBytes": 80451016,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 212.36799999999997,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3223.0440000000726,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.085000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2068.7799999999997,
"heapDeltaBytes": 13130252,
"heapUsedBytes": 79797012,
"domNodes": 0,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 199.90200000000002,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2043.057000000033,
"styleRecalcs": 4,
"styleRecalcDurationMs": 5.140000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 704.858,
"heapDeltaBytes": -22496136,
"heapUsedBytes": 69952028,
"domNodes": -277,
"jsHeapTotalBytes": 3928064,
"scriptDurationMs": 45.138000000000005,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2045.6530000000157,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.8759999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 634.8679999999999,
"heapDeltaBytes": -19348172,
"heapUsedBytes": 73087628,
"domNodes": -278,
"jsHeapTotalBytes": -1576960,
"scriptDurationMs": 48.357,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 776.7699999999991,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.105,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 556.7449999999999,
"heapDeltaBytes": 18182844,
"heapUsedBytes": 87740048,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 142.101,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 764.8560000000089,
"styleRecalcs": 45,
"styleRecalcDurationMs": 10.555,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 556.4820000000001,
"heapDeltaBytes": 18221708,
"heapUsedBytes": 87805728,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 140.68,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.7620000000043,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.140000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.228,
"heapDeltaBytes": -13206436,
"heapUsedBytes": 56482260,
"domNodes": -295,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.411,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2016.5620000000217,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.32,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.5729999999999,
"heapDeltaBytes": 13398016,
"heapUsedBytes": 82978600,
"domNodes": -298,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.58,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1879.4859999999858,
"styleRecalcs": 77,
"styleRecalcDurationMs": 40.334,
"layouts": 16,
"layoutDurationMs": 4.892,
"taskDurationMs": 1184.7679999999998,
"heapDeltaBytes": -10621936,
"heapUsedBytes": 59181728,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 121.84399999999998,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1892.2619999999597,
"styleRecalcs": 76,
"styleRecalcDurationMs": 39.24900000000001,
"layouts": 16,
"layoutDurationMs": 4.463,
"taskDurationMs": 1154.167,
"heapDeltaBytes": 13374368,
"heapUsedBytes": 76759432,
"domNodes": -298,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 123.283,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.679999999942,
"styleRecalcs": 20,
"styleRecalcDurationMs": 32.74,
"layouts": 15,
"layoutDurationMs": 16.523999999999997,
"taskDurationMs": 959.1100000000001,
"heapDeltaBytes": -7414328,
"heapUsedBytes": 84774724,
"domNodes": 13671,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 32.334999999999994,
"eventListeners": 2381,
"totalBlockingTimeMs": 138,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 12844.890000000021,
"styleRecalcs": 246,
"styleRecalcDurationMs": 37.888,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10028.829,
"heapDeltaBytes": -22060244,
"heapUsedBytes": 68285756,
"domNodes": -273,
"jsHeapTotalBytes": 4714496,
"scriptDurationMs": 3425.6420000000003,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 13511.473999999907,
"styleRecalcs": 246,
"styleRecalcDurationMs": 37.74,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10251.258,
"heapDeltaBytes": -3673864,
"heapUsedBytes": 86258380,
"domNodes": -273,
"jsHeapTotalBytes": 3596288,
"scriptDurationMs": 3486.927,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18033.365000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17330.898999999998,
"heapDeltaBytes": -25522096,
"heapUsedBytes": 180755580,
"domNodes": -6548,
"jsHeapTotalBytes": 4136960,
"scriptDurationMs": 368.99399999999997,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17653.140000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16961.956000000002,
"heapDeltaBytes": -36889728,
"heapUsedBytes": 175125740,
"domNodes": -6548,
"jsHeapTotalBytes": -8040448,
"scriptDurationMs": 343.43,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 22050.44400000003,
"styleRecalcs": 172,
"styleRecalcDurationMs": 21.66699999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21682.956,
"heapDeltaBytes": -21355024,
"heapUsedBytes": 188480072,
"domNodes": -6548,
"jsHeapTotalBytes": -4100096,
"scriptDurationMs": 964.1359999999999,
"eventListeners": -7471,
"totalBlockingTimeMs": 232,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20992.519000000015,
"styleRecalcs": 176,
"styleRecalcDurationMs": 18.213000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20646.4,
"heapDeltaBytes": -43727084,
"heapUsedBytes": 167707192,
"domNodes": -6548,
"jsHeapTotalBytes": -7475200,
"scriptDurationMs": 936.1360000000001,
"eventListeners": -7467,
"totalBlockingTimeMs": 131,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 484.00500000002467,
"styleRecalcs": 19,
"styleRecalcDurationMs": 21.999000000000002,
"layouts": 3,
"layoutDurationMs": 1.1229999999999998,
"taskDurationMs": 132.81199999999998,
"heapDeltaBytes": 5838472,
"heapUsedBytes": 72177772,
"domNodes": 150,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.685000000000002,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 112.56500000001779,
"styleRecalcs": 7,
"styleRecalcDurationMs": 16.907000000000004,
"layouts": 3,
"layoutDurationMs": 1.1079999999999999,
"taskDurationMs": 85.57000000000001,
"heapDeltaBytes": 3123560,
"heapUsedBytes": 65683868,
"domNodes": 127,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 3.9219999999999984,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
}
]
}🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-14439.vercel.app This commit: https://website-frontend-acz8h5o5z-comfyui.vercel.app Last updated: 2026-08-25T15:14:23Z for |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughError groups now carry explicit ChangesError severity flow
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant ErrorStores
participant useErrorGroups
participant useHasBlockingError
participant RightSidePanel
participant ErrorGroupList
ErrorStores->>useErrorGroups: Provide execution and missing-resource errors
useErrorGroups->>useErrorGroups: Assign severity and order groups
ErrorStores->>useHasBlockingError: Provide prompt and execution error state
useHasBlockingError->>RightSidePanel: Return blocking-error status
RightSidePanel->>ErrorGroupList: Render severity-aware error panel
ErrorGroupList->>ErrorGroupList: Filter groups and separate error/setup summaries
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/actionbar/ComfyRunButton/ComfyQueueButton.test.ts`:
- Around line 195-196: Update the queue button lookup in the test to use its
accessible button role and user-facing name, such as a case-insensitive “run”
matcher, instead of the `queue-button` test ID. Keep the existing enabled-state
assertion unchanged.
In `@src/components/rightSidePanel/errors/ErrorGroupList.vue`:
- Around line 32-84: Update the outer errors-summary-hero container in
ErrorGroupList.vue to expose the dynamic error and missing-count changes as a
status update, using role="status" or an equivalent polite live-region behavior.
Keep the existing split hero rows and conditional rendering unchanged.
In `@src/components/rightSidePanel/errors/useHasBlockingError.ts`:
- Around line 6-24: The blocking-error checks in useHasBlockingError duplicate
the execution-severity conditions from useErrorGroups and can diverge. Extract
shared predicates for prompt, execution, and node blocking errors, then reuse
them in both useHasBlockingError and useErrorGroups so the tab indicator and
displayed group severities stay aligned.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: a6619903-83c3-4458-8200-1b688db19503
📒 Files selected for processing (12)
src/components/actionbar/ComfyRunButton/ComfyQueueButton.test.tssrc/components/error/ErrorOverlay.test.tssrc/components/error/useErrorOverlayState.test.tssrc/components/rightSidePanel/RightSidePanel.vuesrc/components/rightSidePanel/errors/ErrorCardSection.vuesrc/components/rightSidePanel/errors/ErrorGroupList.vuesrc/components/rightSidePanel/errors/TabErrors.test.tssrc/components/rightSidePanel/errors/types.tssrc/components/rightSidePanel/errors/useErrorGroups.test.tssrc/components/rightSidePanel/errors/useErrorGroups.tssrc/components/rightSidePanel/errors/useHasBlockingError.tssrc/locales/en/main.json
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #14439 +/- ##
==========================================
- Coverage 82.11% 80.08% -2.03%
==========================================
Files 1882 2279 +397
Lines 120655 115286 -5369
Branches 36514 33050 -3464
==========================================
- Hits 99079 92330 -6749
- Misses 21096 22462 +1366
- Partials 480 494 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 745 files with indirect coverage changes 🚀 New features to boost your workflow:
|
eb69f49 to
e54f7fa
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@browser_tests/tests/propertiesPanel/PropertiesPanelHelper.ts`:
- Line 87: Update the errorsTabIcon locator in PropertiesPanelHelper to query
panel-tab-icon within this.errorsTab instead of this.root, ensuring it resolves
only the Errors tab icon.
In `@src/components/rightSidePanel/errors/ErrorCardSection.vue`:
- Around line 12-21: Update the severity badge styling in ErrorCardSection using
theme-aware semantic foreground/background pairs that provide at least 4.5:1
contrast for the small text. Replace the unconditional text-white class while
preserving the existing error and warning severity branching and badge layout
classes.
In `@src/components/rightSidePanel/errors/ErrorGroupList.vue`:
- Around line 57-61: Update the chip-row visibility condition in
ErrorGroupList.vue to use a computed based on workflow-wide severityTotals, such
as hasMixedSeverityTotals, rather than search-scoped hasMixedSeverity. Define it
alongside activeSeverityFilter and require both error and missing totals to be
positive, keeping the filter controls mounted whenever the active workflow
contains mixed severities.
In `@src/components/rightSidePanel/errors/TabErrors.test.ts`:
- Around line 799-801: Update the getNodeByExecutionId mock fixture to construct
the `{ title: 'Node' }` value with the existing fromAny helper, matching the
sibling tests in TabErrors.test.ts, and remove the direct ReturnType assertion.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: d03b18a6-4799-44bd-8a03-c8dbcc5093fd
📒 Files selected for processing (15)
browser_tests/tests/propertiesPanel/PropertiesPanelHelper.tsbrowser_tests/tests/propertiesPanel/errorsTab.spec.tsbrowser_tests/tests/propertiesPanel/errorsTabModeAware.spec.tssrc/components/actionbar/ComfyRunButton/ComfyQueueButton.test.tssrc/components/error/ErrorOverlay.test.tssrc/components/error/useErrorOverlayState.test.tssrc/components/rightSidePanel/RightSidePanel.vuesrc/components/rightSidePanel/errors/ErrorCardSection.vuesrc/components/rightSidePanel/errors/ErrorGroupList.vuesrc/components/rightSidePanel/errors/TabErrors.test.tssrc/components/rightSidePanel/errors/types.tssrc/components/rightSidePanel/errors/useErrorGroups.test.tssrc/components/rightSidePanel/errors/useErrorGroups.tssrc/components/rightSidePanel/errors/useHasBlockingError.tssrc/locales/en/main.json
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/components/rightSidePanel/errors/ErrorGroupList.vue (1)
62-85: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse the shared
Buttoncomponent for severity filters.The new severity chips use a raw
<button>.Buttonis already imported inErrorGroupList.vue. Use it for consistent button behavior and styling, while retaining the chip-specific classes andaria-pressedstate.Based on learnings, “replace raw
<button>HTML elements with the shared Button component” across Vue components.Proposed fix
- <button + <Button v-for="chip in severityChips" :key="chip.severity" type="button" ... - </button> + </Button>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/rightSidePanel/errors/ErrorGroupList.vue` around lines 62 - 85, Replace the raw button in the severityChips v-for with the imported shared Button component. Preserve the existing click handler, key and test identifiers, aria-pressed state, active icon, and chip-specific class composition, while supplying any required Button prop for the current button behavior.Source: Learnings
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/components/rightSidePanel/errors/ErrorGroupList.vue`:
- Around line 62-85: Replace the raw button in the severityChips v-for with the
imported shared Button component. Preserve the existing click handler, key and
test identifiers, aria-pressed state, active icon, and chip-specific class
composition, while supplying any required Button prop for the current button
behavior.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: c90b6ca8-442e-488b-b669-f12878149ad4
📒 Files selected for processing (3)
browser_tests/tests/propertiesPanel/PropertiesPanelHelper.tssrc/components/rightSidePanel/errors/ErrorGroupList.vuesrc/components/rightSidePanel/errors/TabErrors.test.ts
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/locales/en/main.json (1)
4214-4226: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winAdd singular and plural forms to
setupFilter.ErrorGroupList.vuepassesmissingCount, but the locale message has only one form.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/locales/en/main.json` around lines 4214 - 4226, Update the setupFilter locale message to include distinct singular and plural forms, using the existing {count} placeholder and pipe-separated localization format. Keep the ErrorGroupList.vue missingCount interpolation compatible with the updated message.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/locales/en/main.json`:
- Around line 4214-4226: Update the setupFilter locale message to include
distinct singular and plural forms, using the existing {count} placeholder and
pipe-separated localization format. Keep the ErrorGroupList.vue missingCount
interpolation compatible with the updated message.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 7dad64f7-b41b-4f48-a709-70959e740d11
📒 Files selected for processing (4)
src/components/actionbar/ComfyRunButton/ComfyQueueButton.test.tssrc/components/actionbar/ComfyRunButton/ComfyQueueButton.vuesrc/components/rightSidePanel/errors/ErrorGroupList.vuesrc/locales/en/main.json
|
Re the outside-diff finding on |
| import { useExecutionErrorStore } from '@/stores/executionErrorStore' | ||
| import { tryNormalizeNodeExecutionId } from '@/types/nodeIdentification' | ||
|
|
||
| export function useHasBlockingError() { |
There was a problem hiding this comment.
suggestion: (non-blocking) Could blocking state use the same severity policy as useErrorGroups? This composable independently treats prompt, execution, and surfaced node errors as blocking, so adding or reclassifying a group can make the tab icon disagree with the panel.
There was a problem hiding this comment.
Agreed — the stacked #14440 resolves this structurally: useHasBlockingError is rewritten there to delegate to a shared useErrorClassification/classifyPanelErrors, so the tab icon and the panel derive from one classifier. Left as-is in this PR to avoid pulling the classification module forward.
| const active = severityFilter.value | ||
| if (!active) return | ||
| const hidden = HIDDEN_BY_FILTER[active] | ||
| if (next[hidden] > prev[hidden] || next[active] === 0) { |
There was a problem hiding this comment.
issue: This only detects count increases. If hidden issue A is replaced by issue B in the same store update, the total is unchanged and B remains filtered out. Could filter release compare hidden issue membership instead of only totals?
There was a problem hiding this comment.
Fixed in 7f6666b — release now watches per-severity issue identity sets (severityIssueKeys) instead of totals, so a hidden issue replaced by another in the same update releases the filter. Pinned by a same-count replacement test, mutation-proven against a size-comparison implementation.
There was a problem hiding this comment.
Correction to the above: the first membership implementation keyed issues by name, which a fresh-eyes pass caught as coarser than the counts it replaced — a hidden file gaining a second referencing node changed no key and stayed filtered. f367d9c resolves identities to occurrences (referencing node + widget for models/media, per-node for packs/swaps, error index for execution cards), pinned by a duplicate-reference release test and mutation-proven against the name-level keys.
| const hasMissingSeverity = computed(() => severityTotals.value.missing > 0) | ||
|
|
||
| const strip = computed(() => { | ||
| const strip = computed<ContextStrip>(() => { |
There was a problem hiding this comment.
issue: selectionErrorCount includes selected missing-resource groups, but this selected-emphasis branch always uses the “selected node errors” copy. A node with only a missing model or media item is therefore relabeled as an error when selected. Could the keypath follow the selected groups’ severities?
There was a problem hiding this comment.
| :data-severity="severity" | ||
| :class=" | ||
| cn( | ||
| 'flex h-4 min-w-4 shrink-0 items-center justify-center rounded-full px-1 text-2xs/none font-semibold text-white tabular-nums', |
There was a problem hiding this comment.
issue: In the light theme, white text on warning-background (#fcbf64) has a 1.64:1 contrast ratio. This 10px badge text needs at least 4.5:1, so could it use a darker semantic foreground or background?
There was a problem hiding this comment.
Fixed in 7f6666b via a warning-on-background semantic pair: charcoal-800 on gold-400 in light (~9:1), white on gold-600 in dark per the Figma badge spec. (Dark white-on-gold is 2.16:1 — below AA for 10px — but that is the shipped spec; flagged to design alongside DES-588.)
| 'border-destructive-background-hover/50 text-destructive-background-hover' | ||
| }, | ||
| missing: { | ||
| idle: 'border-interface-stroke text-warning-background', |
There was a problem hiding this comment.
issue: warning-background resolves to #fcbf64 in the light theme, giving the setup chip text and setup-only hero count about 1.49:1 to 1.64:1 contrast against their light surfaces. Could these text uses switch to a darker semantic warning foreground?
There was a problem hiding this comment.
Fixed in 7f6666b with the designer-specified value: gold-800 #8c6a38 (4.93:1 on white, from Mariana's AA options in DES-588) behind a new warning-foreground semantic — light resolves to gold-800, dark to gold-600, so dark renders identically. Chip text, the setup-only hero count, and the tab icon all moved onto it. Token naming can follow DES-588 if it lands different names.
| </span> | ||
| </div> | ||
| </div> | ||
| <div |
There was a problem hiding this comment.
suggestion: (non-blocking) Could severity-count changes have their own polite status announcement? When blocking and setup counts change but the total stays constant, the current role="status" content is unchanged and the updated chip counts are not announced.
There was a problem hiding this comment.
Added in 7f6666b — a visually hidden span inside the status row announces "{errors} blocking, {setup} setup required" in the mixed state, so per-severity movement that keeps the total constant is still read out.
The tab now lists blocking errors and missing-resource setup items side by side, so 'Errors' names only half of what it shows. Rename the tab and its empty state, and update the copy that pointed at the old name - including the st() fallback strings in source, which would otherwise drift from the locale values. The selection-emphasis counts change from 'error' to 'issue' for a reason beyond naming: selectionErrorCount reduces over selectionScopedGroups, which includes the missing-severity groups, so selecting a node whose only problem was a missing model rendered 'MyNode - 1 error'. Strings that genuinely name the error severity - errorsDetected, errorsSummary and friends - keep saying 'error'. The Comfy.RightSidePanel.ShowErrorsTab setting id is unchanged so existing user settings are preserved.
…ments Release the severity filter on hidden-issue membership changes instead of count increases, so an issue replaced by another in the same store update still surfaces. Add the designer-specified AA amber for light theme (gold-800 #8c6a38) behind warning-foreground and a warning-on-background pair for the count badge, moving the chip, hero, badge, and tab-icon amber uses onto them; dark theme renders identically. Announce per-severity counts through a visually hidden status span so mixed-state changes that keep the total constant are still read out.
A hidden file gaining another referencing node, a duplicate validation message on one card, or a selection moving between nodes of the same catalog group all changed what the panel shows without changing the coarse identities the release watchers compared. Key issues per occurrence (referencing node and widget, error index) and fold the matched card and asset ids into the selection signature. Drop the severity icon while the Issues tab is only retained by a pending scan, where neither severity exists for it to describe.
christian-byrne
left a comment
There was a problem hiding this comment.
Dark setup-badge contrast blocks approval.
Full context for agent readers
Reviewed exact head f367d9ccbac3ffe8df9927ecbefa58b9edc9b34b. The new 10px setup badge uses warning-on-background over warning-background; in dark mode those tokens resolve to white on gold-600 (#fd9903), which is 2.16:1 rather than the 4.5:1 required for normal text. Light mode now passes, but dark mode still needs an accessible semantic pair (charcoal-800 on gold-600 is 6.74:1) or another pair meeting 4.5:1. Matching the Figma value does not remove the product accessibility requirement; the existing contrast discussion is #14439 (comment).
All exact-head checks are green/skipped, current-main integration is clean, and I found no other current-head blocker. Keep the direct stack ordered #14439 → #14440.
|
@christian-byrne The dark setup-badge contrast blocker is addressed in commit 176f212. The dark-theme warning-on-background token now uses charcoal-800 over gold-600, matching the accessible 6.74:1 semantic pair identified in the review. All required CI checks on the updated head are green. Re-review is ready. Created by Codex |
christian-byrne
left a comment
There was a problem hiding this comment.
Contrast fixed. Exact-head CI green. Approve.
Full context for agent readers
Re-reviewed exact head 176f212f27804b82c950ec716d04f00989557b76 against the prior R3 packet and blocker. Dark warning-on-background now resolves to charcoal-800 (#171718) over gold-600 (#fd9903), an 8.30:1 contrast ratio; the previous white foreground was 2.16:1. Repository search finds one product consumer, the intended 10px setup badge. Light mode remains compliant at 10.90:1.
All 87 exact-head Check Runs are terminal (79 success, eight skipped), git diff --check passes, and rerere-disabled current-main integration is conflict-free. No other current-head blocker survived review. Existing human threads remain untouched.
Keep the stack ordered #14439 → #14440. The successor still branches from prior parent f367d9ccbac3 and would restore the old white token, so it must rebase onto this head or updated main, rerun CI, and receive exact-new-head review before landing.
…e cards (Comfy-Org#14440) Builds on Comfy-Org#14439, which introduced the severity distinction. This PR removes the duplicate reporting that severity alone only reclassified. When a resource already tracked as missing also fails backend validation, the panel can show the same problem twice. This absorbs the validation failure into the existing missing-resource warning. - Absorption for missing models and media, matched on node identity and input name, including every active consumer of inputs promoted across a subgraph boundary - Prompt-level `missing_node_type` errors absorb into the missing-node warning, including replaceable nodes - "Blocked last run" marker so an amber card still says the run was blocked - Severity classification extracted so the panel body and the tab icon cannot disagree; the old aggregate totalErrorCount and constituent counters are removed - Missing-node state survives submission, and the resolved prompt error is cleared through a single store transition rather than hand-placed call sites Model and media verification retire their previously absorbed validation errors independently. A pending or failed verification preserves that resource kind's errors while another kind can finish. Deferred confirmations update the panel without waiting for another workflow reload. Only confirmed missing resources absorb matching validation errors; uncertain matches stay blocking. Candidates whose widget was removed or whose selection changed during verification are discarded. Promoted models retain their stored owner's metadata while tracking all active consumers for matching and scope checks. Errors with unnormalisable node IDs remain visible and count toward affected nodes, without exposing an invalid navigation target. The Blocked last run marker remains per resource kind. Finer attribution to individual cards or mixed swap-node/missing-pack groups, and consolidation of the two media consumer traversals, are follow-ups. - Part of the errors-tab severity work split out of Comfy-Org#14252 ## Screenshots Before <img width="618" height="497" alt="스크린샷 2026-08-12 오전 9 59 51" src="https://github.com/user-attachments/assets/16832e31-6e9f-4e5c-860f-5a1ac67add8a" /> After <img width="519" height="400" alt="스크린샷 2026-08-12 오전 11 35 21" src="https://github.com/user-attachments/assets/fee8addc-f290-43af-9049-3902807df6b6" />
Missing resources (node packs, models, media) currently render as blocking errors, identical in weight to a runtime failure. They are not the same thing: a missing model is resolved by installing it, a failed sampler is not.
This PR introduces the severity distinction and its presentation, following the updated Figma spec (
Errors-ComfyUI, node3052-8805). It does not change which error cards are produced.ErrorGroupSeverityonErrorGroupBase, assigned at each group buildertriangle-alerttab icon (with an accessible label) when nothing is blocking#8c6a38behind awarning-foregroundsemantic for chip/hero/icon text, andwarning-on-background(charcoal-800) for badge text on gold; dark theme renders unchangedmainalready renders both the missing-resource card and the duplicate validation card under one red hero, so this PR classifies an existing duplicate rather than creating one. The duplicate itself is removed in the follow-up.Follow-up: #14440 absorbs the duplicate validation errors into the missing-resource cards, adds the "Blocked last run" marker, and restyles it to the new spec.
Notes for reviewers:
TabErrors.test.tsretains the test nameuses error severity for an unabsorbed node validation error. Absorption does not exist yet in this PR — the name is kept so the follow-up does not have to churn it back.Light-theme amber text follows the DES-588 value; the dark-theme badge keeps the Figma-specified white-on-gold (2.16:1 — flagged to design).
Part of the errors-tab severity work split out of feat: compose warning-level missing diagnostics with blocking errors #14252
Screenshots