Repository navigation
Conversation
Think of gated model access like a locked door with one clear sign: everyone should learn why it is locked, and the control should honestly say where it leads. This change makes that sign work for screen readers and keyboards, keeps unsafe destinations from appearing, and uses clear singular or plural wording without changing the visual design. Five public follow-up issues identified gaps that remained after gated metadata was centralized: asynchronously discovered gating could be missed by screen readers, explanation text was hover-dependent for sighted keyboard users, external navigation exposed the wrong role, Download could repeat the same description, and the copy hardcoded a plural. Without this follow-up, people could receive incomplete or misleading guidance depending on input method and runtime. Publishing it after the parent refactor merged keeps the patch focused on accessibility and wording while preserving the existing visual design. - **Authored by:** agent-work loop - **From:** #14360 — Gated-model hint appears asynchronously with no screen-reader announcement; #14361 — Gated-model explanation reaches sighted keyboard-only users through title only; #14362 — Gated-repo lock control navigates externally but is announced as a button; #14363 — Gated Download button carries the same description via both title and aria-describedby; #14368 — Gated-model copy uses three phrasings of one action, and hardcodes the plural - **Verified:** pnpm test:unit on AccessibleTooltip, MissingModelCard, MissingModelRow, and useMissingModelDownload: 57 passed; pnpm test:unit on PaidTemplateBadge and LogoOverlay: 12 passed; pnpm typecheck: passed; pnpm lint: passed; pnpm format:check: 4,616 files passed; pnpm knip: passed; git diff origin/main...HEAD --check: passed - **Deviations:** None - **Type:** bug fix, covering gated-model accessibility semantics, trusted navigation, and copy - **Slots into:** Follow-up to #14982 — refactor(missing-model): centralize metadata state. Because it merged before publication, this PR targets main and contains only follow-up accessibility and copy work. - Politely announce gated guidance only when metadata transitions from not gated to gated, keep warm-cache mounts silent, and clear the live region so a later appearance can announce again. - Reveal the gated explanation on keyboard focus, expose browser and legacy Electron navigation as safe links with a new-tab warning, and keep Desktop2 navigation as a button with honest fallback labeling. - Require a trusted Hugging Face URL before showing gated controls or descriptions, and give Download one accessible description instead of duplicating title and aria-describedby. - Use consistent sign-in wording and pluralize guidance from the gated model count. - **What:** Updates the shared accessible-tooltip trigger pattern, missing-model card and row behavior, English locale copy, and focused behavioral tests. Please focus on live-region transition behavior, the trusted URL boundary, link-versus-button semantics across runtimes, and the single-description behavior for Download. - [ ] Discover gating after mount and verify one polite announcement; hide and re-show it to verify the status clears and the same guidance can announce again. - [ ] Mount with warm cached gating and verify the visible pluralized note does not trigger the live region. - [ ] Focus the gated access control and verify its explanation is available without hover. - [ ] Verify browser and legacy Electron use trusted new-tab links, Desktop2 uses a fallback-labeled button, and untrusted URLs produce no gated UI or Download description. - [ ] Verify singular and plural sign-in wording and confirm Download receives exactly one gated explanation. - [ ] Confirm the accessibility fixes are active without a feature flag; they correct the existing gated-model flow and preserve its visual design. Not included; visual design is preserved. Fixes #14360 Fixes #14361 Fixes #14362 Fixes #14363 Fixes #14368
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright: ✅ 1798 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-21T02:09:06.852Z",
"gitSha": "f5377312b19f2265b0381590c3ccf64d02675788",
"branch": "backport-14984-to-core-1.50",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2020.0339999999528,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.927000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.55800000000005,
"heapDeltaBytes": 5929636,
"heapUsedBytes": 70201812,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 15.235,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2012.7449999999953,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.213999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.37300000000005,
"heapDeltaBytes": 5730628,
"heapUsedBytes": 70323940,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 15.205,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2032.933000000014,
"styleRecalcs": 78,
"styleRecalcDurationMs": 46.166,
"layouts": 12,
"layoutDurationMs": 3.603,
"taskDurationMs": 1031.469,
"heapDeltaBytes": 621948,
"heapUsedBytes": 64900536,
"domNodes": 60,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 138.77100000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1925.2660000000787,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.207,
"layouts": 12,
"layoutDurationMs": 3.4819999999999998,
"taskDurationMs": 902.3380000000001,
"heapDeltaBytes": -12017544,
"heapUsedBytes": 52441208,
"domNodes": -280,
"jsHeapTotalBytes": 24354816,
"scriptDurationMs": 121.84800000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1713.9669999999683,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.420999999999998,
"layouts": 6,
"layoutDurationMs": 0.644,
"taskDurationMs": 359.726,
"heapDeltaBytes": 8696452,
"heapUsedBytes": 72881444,
"domNodes": 75,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 17.787999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.4530000000632,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.941999999999998,
"layouts": 6,
"layoutDurationMs": 0.5900000000000001,
"taskDurationMs": 368.808,
"heapDeltaBytes": 8580680,
"heapUsedBytes": 72972604,
"domNodes": 78,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 18.096,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 598.1709999999794,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.777,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.16900000000004,
"heapDeltaBytes": -11002100,
"heapUsedBytes": 53220340,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 54.997,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 561.4399999999478,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.356999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 359.17,
"heapDeltaBytes": -11144460,
"heapUsedBytes": 53159888,
"domNodes": 18,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 54.65,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2040.659000000005,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.169999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 661.149,
"heapDeltaBytes": 7037820,
"heapUsedBytes": 67510732,
"domNodes": -281,
"jsHeapTotalBytes": 3772416,
"scriptDurationMs": 89.588,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2029.6099999999342,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.4069999999999965,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 537.3140000000001,
"heapDeltaBytes": 5038548,
"heapUsedBytes": 65337720,
"domNodes": -281,
"jsHeapTotalBytes": 3248128,
"scriptDurationMs": 91.503,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2147.688999999957,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.948999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1194.979,
"heapDeltaBytes": 4229304,
"heapUsedBytes": 65368052,
"domNodes": -287,
"jsHeapTotalBytes": 3178496,
"scriptDurationMs": 390.221,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2157.6639999999543,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.433000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1223.879,
"heapDeltaBytes": 5233560,
"heapUsedBytes": 66089632,
"domNodes": -286,
"jsHeapTotalBytes": 3440640,
"scriptDurationMs": 415.63800000000003,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3184.113000000025,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.780999999999995,
"layouts": 60,
"layoutDurationMs": 7.847999999999999,
"taskDurationMs": 1454.329,
"heapDeltaBytes": -5692616,
"heapUsedBytes": 56638876,
"domNodes": -288,
"jsHeapTotalBytes": 6393856,
"scriptDurationMs": 506.50000000000006,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3213.9549999999417,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.555000000000001,
"layouts": 60,
"layoutDurationMs": 7.752999999999999,
"taskDurationMs": 1451.727,
"heapDeltaBytes": -2019100,
"heapUsedBytes": 60119540,
"domNodes": -288,
"jsHeapTotalBytes": 6656000,
"scriptDurationMs": 506.668,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.873999999992,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.248,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 662.6970000000001,
"heapDeltaBytes": 6530452,
"heapUsedBytes": 66821568,
"domNodes": -284,
"jsHeapTotalBytes": 3772416,
"scriptDurationMs": 90.062,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2033.5389999999052,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.3999999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 665.716,
"heapDeltaBytes": 6600496,
"heapUsedBytes": 67273308,
"domNodes": -283,
"jsHeapTotalBytes": 3772416,
"scriptDurationMs": 88.74600000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 573.1020000000058,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.363000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.031,
"heapDeltaBytes": -10961904,
"heapUsedBytes": 53478036,
"domNodes": 18,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 124.026,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 574.2690000000721,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.053999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.71,
"heapDeltaBytes": -10796340,
"heapUsedBytes": 53705608,
"domNodes": 18,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 120.19800000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2020.2540000000226,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.943999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.77400000000006,
"heapDeltaBytes": -17324976,
"heapUsedBytes": 47074464,
"domNodes": -280,
"jsHeapTotalBytes": 23830528,
"scriptDurationMs": 13.254999999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2027.949000000035,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.411000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.517,
"heapDeltaBytes": 5931816,
"heapUsedBytes": 70404868,
"domNodes": 18,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 13.073999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1739.972000000023,
"styleRecalcs": 79,
"styleRecalcDurationMs": 33.115,
"layouts": 16,
"layoutDurationMs": 4.457,
"taskDurationMs": 781.9659999999999,
"heapDeltaBytes": -18430264,
"heapUsedBytes": 46106244,
"domNodes": 0,
"jsHeapTotalBytes": 23306240,
"scriptDurationMs": 86.862,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1751.0730000000194,
"styleRecalcs": 78,
"styleRecalcDurationMs": 33.899,
"layouts": 16,
"layoutDurationMs": 4.181,
"taskDurationMs": 769.2199999999999,
"heapDeltaBytes": -18366584,
"heapUsedBytes": 46109756,
"domNodes": -283,
"jsHeapTotalBytes": 23044096,
"scriptDurationMs": 83.033,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1399.8490000000174,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.589999999999996,
"layouts": 14,
"layoutDurationMs": 11.293000000000001,
"taskDurationMs": 903.378,
"heapDeltaBytes": 31122656,
"heapUsedBytes": 98054488,
"domNodes": 13673,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 34.25399999999999,
"eventListeners": 2375,
"totalBlockingTimeMs": 116,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8205.618000000015,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.58599999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4162.486999999999,
"heapDeltaBytes": 5318408,
"heapUsedBytes": 65081036,
"domNodes": -284,
"jsHeapTotalBytes": 5537792,
"scriptDurationMs": 1258.4030000000002,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8223.199000000022,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.657000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4198.553000000001,
"heapDeltaBytes": 11808452,
"heapUsedBytes": 71483180,
"domNodes": -283,
"jsHeapTotalBytes": 5537792,
"scriptDurationMs": 1259.808,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17055.003999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17042.059,
"heapDeltaBytes": -36632048,
"heapUsedBytes": 167728156,
"domNodes": -8312,
"jsHeapTotalBytes": -9379840,
"scriptDurationMs": 507.578,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17314.00800000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17275.259,
"heapDeltaBytes": -43630176,
"heapUsedBytes": 166896180,
"domNodes": -3314,
"jsHeapTotalBytes": -9641984,
"scriptDurationMs": 535.663,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20699.206000000006,
"styleRecalcs": 138,
"styleRecalcDurationMs": 16.761,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20665.632999999998,
"heapDeltaBytes": -50457808,
"heapUsedBytes": 179010652,
"domNodes": -8312,
"jsHeapTotalBytes": -8663040,
"scriptDurationMs": 823.1360000000001,
"eventListeners": -16383,
"totalBlockingTimeMs": 177,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21345.852000000035,
"styleRecalcs": 151,
"styleRecalcDurationMs": 18.39000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21302.112,
"heapDeltaBytes": -27827568,
"heapUsedBytes": 177946168,
"domNodes": -8312,
"jsHeapTotalBytes": -7352320,
"scriptDurationMs": 875.4119999999999,
"eventListeners": -16381,
"totalBlockingTimeMs": 287,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 446.30099999994854,
"styleRecalcs": 13,
"styleRecalcDurationMs": 17.106,
"layouts": 3,
"layoutDurationMs": 0.58,
"taskDurationMs": 103.499,
"heapDeltaBytes": 5081016,
"heapUsedBytes": 68476424,
"domNodes": 126,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8.92,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 488.22900000004665,
"styleRecalcs": 18,
"styleRecalcDurationMs": 21.386000000000003,
"layouts": 10,
"layoutDurationMs": 2.3160000000000003,
"taskDurationMs": 125.82799999999999,
"heapDeltaBytes": 5205372,
"heapUsedBytes": 68599300,
"domNodes": 145,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.62,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
🎨 Storybook: 🚧 Building... |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.50 #15517 +/- ##
==========================================
Coverage 81.34% 81.34%
==========================================
Files 1872 1872
Lines 106289 106303 +14
Branches 32304 32310 +6
==========================================
+ Hits 86456 86471 +15
+ Misses 19478 19477 -1
Partials 355 355
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #14984 to core/1.50.
Conflict note:
MissingModelCard.test.ts— main's #14836 (automatic Vitest mock cleanup, test-infra, not backported) removedvi.clearAllMocks()where #14984 addedi18n.global.setLocaleMessage('en', enMessages). Resolution keeps both lines, since 1.50 has no automatic mock cleanup.Validation:
src/platform/missingModel/suite 238/238, typecheck clean on the branch.