Skip to content

[backport core/1.49] fix(missing-model): improve gated access accessibility - #15102

Merged
comfy-pr-bot merged 1 commit into
core/1.49from
jaeone94/backport-14984-to-core-1.49
Aug 12, 2026
Merged

comfy-pr-bot merged 1 commit into
core/1.49from
jaeone94/backport-14984-to-core-1.49

Conversation

@jaeone94

Copy link
Copy Markdown
Collaborator

ELI5

This carries the already merged gated-model accessibility fix into core/1.49. It is the same repair, fitted to the older branch by keeping that branch's test cleanup while adding the new locale reset.

Motivation

The automatic backport of #14984 — fix(missing-model): improve gated access accessibility could not merge one test file because main and core/1.49 clean up Vitest mocks differently. The prerequisite missing-model refactor is already present on the target branch, so a separate dependency backport is unnecessary. Resolving the small test-fixture conflict manually lets the 1.49 release line receive the already reviewed accessibility behavior without importing main's unrelated test-infrastructure changes.

Provenance

  • Authored by: interactive session
  • Verified: focused pnpm test:unit run: 6 files and 69 tests passed; pnpm typecheck: passed; pnpm lint: passed with 0 errors and 59 pre-existing warnings outside the changed files; pnpm format:check: 4,518 files passed; pnpm knip: passed; git diff origin/core/1.49...HEAD --check: passed
  • Deviations: None

Reviewer context

Summary

  • Backports the six accessibility, copy, and focused-test changes from fix(missing-model): improve gated access accessibility #14984 — fix(missing-model): improve gated access accessibility.
  • Preserves core/1.49's explicit vi.clearAllMocks() calls while also restoring the English locale before each affected card test.
  • Does not backport unrelated main-branch test infrastructure.

Changes

  • What: Updates gated-model announcements, keyboard-accessible guidance, trusted navigation semantics, accessible descriptions, pluralized copy, and their tests.
  • Dependencies: None; the prerequisite refactor is already on core/1.49.

Review Focus

Please verify the two resolved beforeEach blocks in MissingModelCard.test.ts retain both mock cleanup and locale reset; all other files applied cleanly from the merged PR.

Test plan

  • Run the six focused unit/component test files on core/1.49.
  • Run typecheck, lint, formatting, and unused-code checks.
  • Confirm target-branch CI is green.
  • Spot-check the gated-model hint with keyboard and screen-reader navigation if manual release validation is required.

No feature flag is added; this backports an accessibility correction already merged on main.

Screenshots (if applicable)

Not included; this backport preserves the visual behavior of the merged PR.

Think of gated model access like a locked door with one clear sign:
everyone should learn why it is locked, and the control should honestly
say where it leads. This change makes that sign work for screen readers
and keyboards, keeps unsafe destinations from appearing, and uses clear
singular or plural wording without changing the visual design.

Five public follow-up issues identified gaps that remained after gated
metadata was centralized: asynchronously discovered gating could be
missed by screen readers, explanation text was hover-dependent for
sighted keyboard users, external navigation exposed the wrong role,
Download could repeat the same description, and the copy hardcoded a
plural. Without this follow-up, people could receive incomplete or
misleading guidance depending on input method and runtime. Publishing it
after the parent refactor merged keeps the patch focused on
accessibility and wording while preserving the existing visual design.

- **Authored by:** agent-work loop
- **From:** #14360 — Gated-model hint appears asynchronously with no
screen-reader announcement; #14361 — Gated-model explanation reaches
sighted keyboard-only users through title only; #14362 — Gated-repo lock
control navigates externally but is announced as a button; #14363 —
Gated Download button carries the same description via both title and
aria-describedby; #14368 — Gated-model copy uses three phrasings of one
action, and hardcodes the plural
- **Verified:** pnpm test:unit on AccessibleTooltip, MissingModelCard,
MissingModelRow, and useMissingModelDownload: 57 passed; pnpm test:unit
on PaidTemplateBadge and LogoOverlay: 12 passed; pnpm typecheck: passed;
pnpm lint: passed; pnpm format:check: 4,616 files passed; pnpm knip:
passed; git diff origin/main...HEAD --check: passed
- **Deviations:** None

- **Type:** bug fix, covering gated-model accessibility semantics,
trusted navigation, and copy
- **Slots into:** Follow-up to #14982 — refactor(missing-model):
centralize metadata state. Because it merged before publication, this PR
targets main and contains only follow-up accessibility and copy work.

- Politely announce gated guidance only when metadata transitions from
not gated to gated, keep warm-cache mounts silent, and clear the live
region so a later appearance can announce again.
- Reveal the gated explanation on keyboard focus, expose browser and
legacy Electron navigation as safe links with a new-tab warning, and
keep Desktop2 navigation as a button with honest fallback labeling.
- Require a trusted Hugging Face URL before showing gated controls or
descriptions, and give Download one accessible description instead of
duplicating title and aria-describedby.
- Use consistent sign-in wording and pluralize guidance from the gated
model count.

- **What:** Updates the shared accessible-tooltip trigger pattern,
missing-model card and row behavior, English locale copy, and focused
behavioral tests.

Please focus on live-region transition behavior, the trusted URL
boundary, link-versus-button semantics across runtimes, and the
single-description behavior for Download.

- [ ] Discover gating after mount and verify one polite announcement;
hide and re-show it to verify the status clears and the same guidance
can announce again.
- [ ] Mount with warm cached gating and verify the visible pluralized
note does not trigger the live region.
- [ ] Focus the gated access control and verify its explanation is
available without hover.
- [ ] Verify browser and legacy Electron use trusted new-tab links,
Desktop2 uses a fallback-labeled button, and untrusted URLs produce no
gated UI or Download description.
- [ ] Verify singular and plural sign-in wording and confirm Download
receives exactly one gated explanation.
- [ ] Confirm the accessibility fixes are active without a feature flag;
they correct the existing gated-model flow and preserve its visual
design.

Not included; visual design is preserved.

Fixes #14360
Fixes #14361
Fixes #14362
Fixes #14363
Fixes #14368
@jaeone94 jaeone94 added the backport Backporting a PR onto a release candidate label Aug 12, 2026
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 12, 2026
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 87d0f520-5681-4292-8f89-7b0d5fb08edb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 12, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/12/2026, 01:16:42 AM UTC

Links

🎭 Playwright: ✅ 1791 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1770 / ❌ 0 / ⚠️ 2 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.4 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 48.6 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.1 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.5 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.7 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.4 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.7 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.5 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.6 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 152ms TBT · 71.7 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.6 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 159.5 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 243ms TBT · 164.0 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 49.3 MB heap

⚠️ 12 regressions detected

Show regressions
Metric Baseline PR (median) Δ Sig
canvas-idle: task duration 251ms 524ms +109% ⚠️ z=4.2
canvas-mouse-sweep: layout duration 3ms 5ms +65% ⚠️ z=5.3
canvas-mouse-sweep: task duration 480ms 1039ms +116% ⚠️ z=3.0
canvas-zoom-sweep: task duration 211ms 408ms +93% ⚠️ z=3.5
dom-widget-clipping: task duration 216ms 399ms +84% ⚠️ z=2.1
large-graph-idle: task duration 361ms 740ms +105% ⚠️ z=3.6
large-graph-pan: task duration 709ms 1363ms +92% ⚠️ z=6.5
minimap-idle: task duration 355ms 733ms +106% ⚠️ z=4.3
minimap-idle: script duration 45ms 122ms +173% ⚠️ z=2.4
subgraph-dom-widget-clipping: task duration 237ms 420ms +77% ⚠️ z=2.3
subgraph-idle: task duration 274ms 497ms +81% ⚠️ z=4.0
workflow-execution: event listeners 73 98 +34% ⚠️ z=10.6
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms +0% z=-0.5
canvas-idle: p95 frame time 17ms 17ms -0% —
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 5ms 9ms +62% z=-2.4
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 11 8 -24% z=-5.6
canvas-idle: task duration 251ms 524ms +109% ⚠️ z=4.2
canvas-idle: script duration 9ms 22ms +159% z=-1.4
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 70.5 MB 70.4 MB -0% —
canvas-idle: DOM nodes 21 16 -24% z=-5.2
canvas-idle: event listeners 4 6 +50% z=-1.2
canvas-mouse-sweep: avg frame time 17ms 17ms +0% z=-0.4
canvas-mouse-sweep: p95 frame time 17ms 17ms +0% —
canvas-mouse-sweep: layout duration 3ms 5ms +65% ⚠️ z=5.3
canvas-mouse-sweep: style recalc duration 23ms 43ms +91% z=0.2
canvas-mouse-sweep: layout count 12 12 +0% —
canvas-mouse-sweep: style recalc count 72 76 +6% z=-1.4
canvas-mouse-sweep: task duration 480ms 1039ms +116% ⚠️ z=3.0
canvas-mouse-sweep: script duration 68ms 136ms +100% z=0.1
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 56.5 MB 48.6 MB -14% —
canvas-mouse-sweep: DOM nodes -112 -282 +152% z=-132.9
canvas-mouse-sweep: event listeners -74 -152 +107% z=-38.5
canvas-zoom-sweep: avg frame time 17ms 17ms +0% z=1.4
canvas-zoom-sweep: p95 frame time 17ms 17ms +0% —
canvas-zoom-sweep: layout duration 0ms 1ms +22% z=-0.9
canvas-zoom-sweep: style recalc duration 12ms 18ms +44% z=-0.8
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 31 31 -2% z=-1.7
canvas-zoom-sweep: task duration 211ms 408ms +93% ⚠️ z=3.5
canvas-zoom-sweep: script duration 11ms 24ms +121% z=-1.1
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 73.3 MB 73.1 MB -0% —
canvas-zoom-sweep: DOM nodes 79 76 -4% z=-4.7
canvas-zoom-sweep: event listeners 19 19 +0% z=-0.9
dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.1
dom-widget-clipping: p95 frame time 17ms 17ms +0% —
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 6ms 8ms +37% z=-1.8
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 13 11 -19% z=-5.2
dom-widget-clipping: task duration 216ms 399ms +84% ⚠️ z=2.1
dom-widget-clipping: script duration 33ms 61ms +87% z=-2.0
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 53.8 MB 54.5 MB +1% —
dom-widget-clipping: DOM nodes 22 17 -23% z=-3.6
dom-widget-clipping: event listeners 0 2 — variance too high
large-graph-idle: avg frame time 17ms 17ms -0% z=-0.6
large-graph-idle: p95 frame time 17ms 17ms +0% —
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 5ms 8ms +42% z=-4.5
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 11 8 -24% z=-11.5
large-graph-idle: task duration 361ms 740ms +105% ⚠️ z=3.6
large-graph-idle: script duration 45ms 120ms +167% z=1.6
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 64.3 MB 64.7 MB +1% —
large-graph-idle: DOM nodes -279 -282 +1% z=-339.3
large-graph-idle: event listeners -162 -148 -9% z=-28.6
large-graph-pan: avg frame time 17ms 17ms +0% z=-0.2
large-graph-pan: p95 frame time 17ms 17ms +0% —
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 13ms 14ms +6% z=-4.3
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 68 69 +1% z=-1.7
large-graph-pan: task duration 709ms 1363ms +92% ⚠️ z=6.5
large-graph-pan: script duration 236ms 447ms +89% z=2.0
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 70.1 MB 63.4 MB -10% —
large-graph-pan: DOM nodes -282 -285 +1% z=-184.0
large-graph-pan: event listeners -161 -149 -7% z=-185.9
large-graph-zoom: avg frame time 17ms 17ms +0% —
large-graph-zoom: p95 frame time 17ms 17ms +1% —
large-graph-zoom: layout duration 8ms 8ms +1% —
large-graph-zoom: style recalc duration 14ms 15ms +9% —
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 66 65 -2% —
large-graph-zoom: task duration 828ms 1619ms +95% —
large-graph-zoom: script duration 292ms 561ms +92% —
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 81.6 MB 66.1 MB -19% —
large-graph-zoom: DOM nodes 18 -289 -1703% —
large-graph-zoom: event listeners 8 -153 -2013% —
minimap-idle: avg frame time 17ms 17ms +0% z=0.1
minimap-idle: p95 frame time 17ms 17ms -0% —
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 5ms 8ms +78% z=-1.6
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 10 8 -16% z=-2.3
minimap-idle: task duration 355ms 733ms +106% ⚠️ z=4.3
minimap-idle: script duration 45ms 122ms +173% ⚠️ z=2.4
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 67.3 MB 67.4 MB +0% —
minimap-idle: DOM nodes -281 -283 +1% z=-220.9
minimap-idle: event listeners -147 -150 +2% z=-234.1
subgraph-dom-widget-clipping: avg frame time 17ms 17ms -0% z=-0.9
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms +1% —
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 8ms 10ms +27% z=-2.7
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 48 46 -4% z=-4.2
subgraph-dom-widget-clipping: task duration 237ms 420ms +77% ⚠️ z=2.3
subgraph-dom-widget-clipping: script duration 69ms 121ms +75% z=-1.2
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 53.4 MB 54.7 MB +2% —
subgraph-dom-widget-clipping: DOM nodes 21 17 -19% z=-4.6
subgraph-dom-widget-clipping: event listeners 6 8 +33% z=-1.4
subgraph-idle: avg frame time 17ms 17ms +0% z=1.5
subgraph-idle: p95 frame time 17ms 17ms -0% —
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 6ms 9ms +57% z=-2.2
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 11 9 -18% z=-2.9
subgraph-idle: task duration 274ms 497ms +81% ⚠️ z=4.0
subgraph-idle: script duration 8ms 18ms +129% z=-0.7
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 70.4 MB 70.5 MB +0% —
subgraph-idle: DOM nodes 22 18 -18% z=-2.5
subgraph-idle: event listeners 5 4 -20% variance too high
subgraph-mouse-sweep: avg frame time 17ms 17ms +0% z=-0.1
subgraph-mouse-sweep: p95 frame time 17ms 17ms -0% —
subgraph-mouse-sweep: layout duration 4ms 4ms +27% z=-0.8
subgraph-mouse-sweep: style recalc duration 24ms 40ms +69% z=-0.6
subgraph-mouse-sweep: layout count 16 16 +0% —
subgraph-mouse-sweep: style recalc count 77 77 +1% z=-1.6
subgraph-mouse-sweep: task duration 446ms 841ms +89% z=1.1
subgraph-mouse-sweep: script duration 59ms 100ms +69% z=-0.1
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 61.6 MB 61.6 MB -0% —
subgraph-mouse-sweep: DOM nodes 65 63 -2% z=-1.8
subgraph-mouse-sweep: event listeners 4 4 +0% variance too high
subgraph-transition-enter: avg frame time 17ms 17ms +0% —
subgraph-transition-enter: p95 frame time 17ms 17ms +0% —
subgraph-transition-enter: layout duration 8ms 14ms +77% —
subgraph-transition-enter: style recalc duration 19ms 32ms +69% —
subgraph-transition-enter: layout count 15 14 -7% —
subgraph-transition-enter: style recalc count 19 18 -5% —
subgraph-transition-enter: task duration 516ms 1010ms +96% —
subgraph-transition-enter: script duration 16ms 41ms +157% —
subgraph-transition-enter: TBT 48ms 152ms +217% —
subgraph-transition-enter: heap used 94.2 MB 71.7 MB -24% —
subgraph-transition-enter: DOM nodes 13673 13673 +0% —
subgraph-transition-enter: event listeners 2373 2375 +0% —
viewport-pan-sweep: avg frame time 17ms 17ms +0% —
viewport-pan-sweep: p95 frame time 17ms 17ms +0% —
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 38ms 38ms +1% —
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 249 250 +0% —
viewport-pan-sweep: task duration 2470ms 4927ms +100% —
viewport-pan-sweep: script duration 791ms 1555ms +97% —
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 74.6 MB 78.6 MB +5% —
viewport-pan-sweep: DOM nodes -279 -285 +2% —
viewport-pan-sweep: event listeners -146 -132 -10% —
vue-large-graph-idle: avg frame time 17ms 18ms +7% —
vue-large-graph-idle: p95 frame time 17ms 17ms +0% —
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 9363ms 17583ms +88% —
vue-large-graph-idle: script duration 277ms 592ms +114% —
vue-large-graph-idle: TBT 0ms 0ms +0% —
vue-large-graph-idle: heap used 161.2 MB 159.5 MB -1% —
vue-large-graph-idle: DOM nodes -8312 -8312 +0% —
vue-large-graph-idle: event listeners -16391 -16387 -0% —
vue-large-graph-pan: avg frame time 17ms 18ms +5% —
vue-large-graph-pan: p95 frame time 17ms 17ms +0% —
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 11ms 19ms +75% —
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 65 146 +125% —
vue-large-graph-pan: task duration 12707ms 21250ms +67% —
vue-large-graph-pan: script duration 534ms 924ms +73% —
vue-large-graph-pan: TBT 0ms 243ms — —
vue-large-graph-pan: heap used 168.1 MB 164.0 MB -2% —
vue-large-graph-pan: DOM nodes -8312 -8327 +0% —
vue-large-graph-pan: event listeners -16390 -16383 -0% —
workflow-execution: avg frame time 17ms 17ms +0% z=0.1
workflow-execution: p95 frame time 17ms 17ms -0% —
workflow-execution: layout duration 1ms 1ms +140% z=-1.2
workflow-execution: style recalc duration 12ms 25ms +103% z=0.2
workflow-execution: layout count 3 4 +17% z=-2.7
workflow-execution: style recalc count 11 16 +45% z=-0.9
workflow-execution: task duration 66ms 133ms +101% z=0.9
workflow-execution: script duration 6ms 11ms +87% z=-6.2
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 58.5 MB 49.3 MB -16% —
workflow-execution: DOM nodes 120 140 +17% z=-2.9
workflow-execution: event listeners 73 98 +34% ⚠️ z=10.6
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 11ms 1ms 8.2%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 11 1 5.0%
canvas-idle: task duration 395ms 31ms 7.9%
canvas-idle: script duration 25ms 2ms 8.8%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: DOM nodes 23 1 5.6%
canvas-idle: event listeners 12 5 40.9%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: layout duration 4ms 0ms 5.4%
canvas-mouse-sweep: style recalc duration 43ms 3ms 7.4%
canvas-mouse-sweep: layout count 12 0 0.0%
canvas-mouse-sweep: style recalc count 79 2 3.0%
canvas-mouse-sweep: task duration 865ms 58ms 6.7%
canvas-mouse-sweep: script duration 136ms 6ms 4.8%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: DOM nodes 62 3 4.2%
canvas-mouse-sweep: event listeners 8 4 49.4%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: layout duration 1ms 0ms 7.0%
canvas-zoom-sweep: style recalc duration 19ms 2ms 8.0%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 0 1.5%
canvas-zoom-sweep: task duration 327ms 23ms 7.1%
canvas-zoom-sweep: script duration 27ms 3ms 11.1%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: DOM nodes 79 1 1.0%
canvas-zoom-sweep: event listeners 24 5 21.8%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 10ms 1ms 8.0%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 13 0 3.8%
dom-widget-clipping: task duration 365ms 16ms 4.5%
dom-widget-clipping: script duration 68ms 3ms 4.8%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: DOM nodes 22 1 6.4%
dom-widget-clipping: event listeners 8 6 81.2%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 12ms 1ms 8.6%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 12 0 2.7%
large-graph-idle: task duration 542ms 54ms 10.0%
large-graph-idle: script duration 102ms 11ms 10.3%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: DOM nodes 25 1 3.7%
large-graph-idle: event listeners 26 6 23.2%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 17ms 1ms 4.6%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 70 1 0.9%
large-graph-pan: task duration 1082ms 43ms 4.0%
large-graph-pan: script duration 408ms 20ms 4.8%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: DOM nodes 19 2 8.7%
large-graph-pan: event listeners 5 1 16.8%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 10ms 1ms 8.6%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 10 1 7.1%
minimap-idle: task duration 527ms 47ms 9.0%
minimap-idle: script duration 98ms 10ms 10.1%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: DOM nodes 19 1 7.1%
minimap-idle: event listeners 5 1 14.4%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 13ms 1ms 7.4%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 48 1 1.2%
subgraph-dom-widget-clipping: task duration 378ms 18ms 4.9%
subgraph-dom-widget-clipping: script duration 128ms 6ms 4.9%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: DOM nodes 22 1 5.0%
subgraph-dom-widget-clipping: event listeners 16 6 36.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 10ms 1ms 7.5%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 11 1 6.0%
subgraph-idle: task duration 370ms 31ms 8.5%
subgraph-idle: script duration 20ms 3ms 13.2%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: DOM nodes 22 1 6.9%
subgraph-idle: event listeners 10 7 64.5%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: layout duration 5ms 0ms 6.8%
subgraph-mouse-sweep: style recalc duration 42ms 3ms 7.8%
subgraph-mouse-sweep: layout count 16 0 0.0%
subgraph-mouse-sweep: style recalc count 80 2 2.4%
subgraph-mouse-sweep: task duration 766ms 69ms 9.0%
subgraph-mouse-sweep: script duration 101ms 7ms 6.5%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: DOM nodes 67 2 3.3%
subgraph-mouse-sweep: event listeners 8 4 52.6%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: layout duration 2ms 0ms 9.4%
workflow-execution: style recalc duration 24ms 2ms 9.1%
workflow-execution: layout count 5 1 11.0%
workflow-execution: style recalc count 18 2 11.5%
workflow-execution: task duration 123ms 11ms 8.8%
workflow-execution: script duration 29ms 3ms 10.2%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: DOM nodes 161 7 4.4%
workflow-execution: event listeners 52 4 8.4%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▆▃▆▁▆▃▆█▆▆▄▃▃▄▃ ➡️ 17ms
canvas-idle: p95 frame time ➡️ NaNms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▇▇▆▆▃█▄▃▄▃▇▄▁▆▇ ➡️ 11ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count █▃▅▂▅▆▃▁▂▁▂▅▆▅▆ ➡️ 12
canvas-idle: task duration ▃▃▃▆▂▃▃▅▆▂█▃▁▃▃ ➡️ 391ms
canvas-idle: script duration ▄▃▅▇▂▅▃▆▇▅█▄▁▅▆ ➡️ 27ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ➡️ NaN MB
canvas-idle: DOM nodes █▇▆▅▃▇▃▁▂▂▅▆▆▆▇ ➡️ 24
canvas-idle: event listeners ▅█▅▄▁▅▁▁▁▄▅▅▁▅▄ 📉 11
canvas-mouse-sweep: avg frame time ▆█▆▃▁▃▁▆▆▁▃▆▆▃▃ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ➡️ NaNms
canvas-mouse-sweep: layout duration ▁▃▂▄▁▂▁▃▆▂█▇▆▄▃ ➡️ 4ms
canvas-mouse-sweep: style recalc duration ▄▄▂▄▁▂▃▃▅▄█▆▂▄▄ ➡️ 43ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: style recalc count █▅▄▃▂▂▁▄▄▅▆▅▂▇▄ ➡️ 79
canvas-mouse-sweep: task duration █▆▄▂▂▃▂▄▄▅█▆▁▆▄ ➡️ 868ms
canvas-mouse-sweep: script duration ▄▅▄▆▄▆▆▆▅▅█▆▁▅▆ ➡️ 139ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ➡️ NaN MB
canvas-mouse-sweep: DOM nodes █▅▃▃▁▂▂▃▂▄▆▅▃▅▅ ➡️ 64
canvas-mouse-sweep: event listeners █▁▁▁▁▁▇▁▁▁██▇▁█ 📈 13
canvas-zoom-sweep: avg frame time ▅▅█▄▅▁▁▁▅▁▁▅▄▅▁ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ➡️ NaNms
canvas-zoom-sweep: layout duration ▆▅▅▄▁▁█▅▃▅▇▆▁▂▆ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▆▅▄▆▅▃█▆▇▅▇▄▁▃▅ ➡️ 20ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▁▁▃▄▆▃▆█▄▄▆▁▆▁▆ ➡️ 32
canvas-zoom-sweep: task duration ▄▂▁▇▂▂▄▅▆▃█▄▁▁▅ ➡️ 338ms
canvas-zoom-sweep: script duration ▃▃▂▇▂▂▅▇▆▅█▄▁▂▆ ➡️ 30ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ➡️ NaN MB
canvas-zoom-sweep: DOM nodes ▄▃▁▅█▁▃▆▄▅▅▃▃▄▃ ➡️ 79
canvas-zoom-sweep: event listeners ▁▁▂▅█▂▁▅▁▅▅▄▁▅▁ ➡️ 19
dom-widget-clipping: avg frame time ▂▄▅▅▂▄█▇▅▇▇▅▅▁▇ ➡️ 17ms
dom-widget-clipping: p95 frame time ➡️ NaNms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▆▆▂▆▄▃██▄▁▆▇▆▃▅ ➡️ 10ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▇█▅█▅▄█▇▇▁▇▄▇▂▅ ➡️ 13
dom-widget-clipping: task duration ▃▃▁▅▄▃▅▆▅▂▇█▁▅▅ ➡️ 371ms
dom-widget-clipping: script duration ▅▄▄▆▆▅▇▇▆▃█▇▁▇▇ ➡️ 71ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ➡️ NaN MB
dom-widget-clipping: DOM nodes ▇▇▄▇▅▄█▇▅▁▅▄▇▃▄ ➡️ 21
dom-widget-clipping: event listeners ▅▅▅▅▁▅██▁▁▁▁█▁▁ 📉 2
large-graph-idle: avg frame time ▅▅▅▅▅▂▁▂▄▅▄▂▂▅█ ➡️ 17ms
large-graph-idle: p95 frame time ➡️ NaNms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▅▅▅▆▄▅▃▄▅▅▆█▁▄▆ ➡️ 13ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count █▆█▃▃▁▃▆▃▆▆▃▆██ ➡️ 12
large-graph-idle: task duration ▂▃▂▆▂▃▃▇▅▃██▁▂▅ ➡️ 569ms
large-graph-idle: script duration ▄▅▄▆▄▅▅▇▆▅█▆▁▃▆ ➡️ 110ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ➡️ NaN MB
large-graph-idle: DOM nodes ▆█▅▂▅▃▁▂▃▅▅▆▂▆▅ ➡️ 25
large-graph-idle: event listeners ███▇██▄▁▄▇▇█▂█▇ ➡️ 29
large-graph-pan: avg frame time ▆▃▃▆█▃▁█▆▆▆▆█▁▆ ➡️ 17ms
large-graph-pan: p95 frame time ➡️ NaNms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▂▄▄▁▅▂▂▁▄▄█▃▁▂ ➡️ 17ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▆▃█▂▃▂▂▂▁▇▅▃█▆▃ ➡️ 69
large-graph-pan: task duration ▄▃▄▆▄▄▄▆▄▄█▆▁▂▅ ➡️ 1100ms
large-graph-pan: script duration ▅▄▅▆▆▅▄▆▄▅█▄▁▄▅ ➡️ 413ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ➡️ NaN MB
large-graph-pan: DOM nodes ▅▃▆▂▄▁▃▁▁▅▁▂█▅▂ ➡️ 18
large-graph-pan: event listeners █▆█▁▁▆▁▁▃▆▁▃██▃ ➡️ 5
minimap-idle: avg frame time ▃▆▆▃█▁█▆▆▃▃▆█▆█ ➡️ 17ms
minimap-idle: p95 frame time ➡️ NaNms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▄█▁█▅▅█▅▅▃▅▁▁▄▆ ➡️ 10ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 9
minimap-idle: task duration ▃▄▁▅▁▃▄▅▇▃█▅▁▁▅ ➡️ 547ms
minimap-idle: script duration ▄▆▃▇▃▅▆▆▇▅█▅▁▃▆ ➡️ 106ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ➡️ NaN MB
minimap-idle: DOM nodes ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 19
minimap-idle: event listeners ▃▃▆▁▁▁▃▁▁▆▁▃█▆▁ ➡️ 4
subgraph-dom-widget-clipping: avg frame time ▅▄▄▄▄▄█▄▄▄▃▁▆▃▃ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ➡️ NaNms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▂▄▃▅▅▃▂▅▇▃▄█▁▄▆ ➡️ 14ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▇█▆▃▆▃▁▆█▇▃▆▇█▅ ➡️ 48
subgraph-dom-widget-clipping: task duration ▂▃▃▆▅▅▂▅█▂▆█▁▂▇ ➡️ 398ms
subgraph-dom-widget-clipping: script duration ▃▃▃▄▅▅▂▄█▂▅▇▁▂▅ ➡️ 131ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ➡️ NaN MB
subgraph-dom-widget-clipping: DOM nodes ▅▇▅▂▅▂▁▅▅▅▁▇▅█▄ ➡️ 22
subgraph-dom-widget-clipping: event listeners ▅▅▅▂▅▁▅██▁▁█▅█▅ 📈 16
subgraph-idle: avg frame time ▆▆█▁▆▃▆▆▆▃▆▁▃▆█ ➡️ 17ms
subgraph-idle: p95 frame time ➡️ NaNms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▁▇▃▆▂▄▂▃▃▆▆▄▃▇█ ➡️ 12ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▃▆▃▃▂▅▁▂▁▆▃▃██▇ ➡️ 12
subgraph-idle: task duration ▁▃▁▇▁▁▃▆▅▂█▅▁▁▄ ➡️ 378ms
subgraph-idle: script duration ▁▃▂▇▁▂▃▇▆▂█▅▂▁▅ ➡️ 22ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ➡️ NaN MB
subgraph-idle: DOM nodes ▃▅▃▂▁▄▁▂▁▅▃▂▇█▇ ➡️ 24
subgraph-idle: event listeners ▁▅▁▁▁▁▁▁▁▅▄▁███ 📈 21
subgraph-mouse-sweep: avg frame time ▅▄▁▃▃▄▆▄▆▃▃█▁▃▃ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ➡️ NaNms
subgraph-mouse-sweep: layout duration ▁▄▄▄▃▃▅▅▅▂█▇▂▃▆ ➡️ 5ms
subgraph-mouse-sweep: style recalc duration ▃▂▄▅▂▃▄▅█▃█▆▁▂▅ ➡️ 43ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: style recalc count ▅▂▅▅▁▄▃▅█▅▆▄▂▄▅ ➡️ 81
subgraph-mouse-sweep: task duration ▃▂▄▅▂▄▄▅▇▄█▆▁▃▅ ➡️ 785ms
subgraph-mouse-sweep: script duration ▄▅▄▇▅▅▆▇▆▅██▁▄▆ ➡️ 105ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ➡️ NaN MB
subgraph-mouse-sweep: DOM nodes ▅▁▄▅▁▄▃▃█▅▅▄▂▅▃ ➡️ 66
subgraph-mouse-sweep: event listeners ▇▁▂▇▁▂▂▂█▇▂▂▇▇▂ 📈 5
workflow-execution: avg frame time ▆▆▆▄▆▆▃▄▁▄█▆▅▄▆ ➡️ 17ms
workflow-execution: p95 frame time ➡️ NaNms
workflow-execution: layout duration ▁▆▁▃▂▄▃▂▃▃▅█▄▂▅ ➡️ 2ms
workflow-execution: style recalc duration ▃▇▅▇▁▅▆▇█▁██▂▄▆ ➡️ 25ms
workflow-execution: layout count ▁█▂▃▂▃▃▁▃▃▄▃▂▃▂ ➡️ 5
workflow-execution: style recalc count ▃█▅▇▁▄▅▆▅▅▅▅▄▄▂ ➡️ 15
workflow-execution: task duration ▂▅▄▅▁▄▆▆▆▁▇█▁▃▃ ➡️ 120ms
workflow-execution: script duration ▄▃▄▄▃▅▄▅▆▂▇█▁▃▄ ➡️ 29ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ➡️ NaN MB
workflow-execution: DOM nodes ▂█▃▆▁▄▃▅▃█▃▃▄▃▁ ➡️ 152
workflow-execution: event listeners ▅███▁▅███▁██▅█▅ ➡️ 49
Raw data
{
  "timestamp": "2026-08-12T01:27:35.498Z",
  "gitSha": "9ec1882d2dca3d0e61779b290f1c0f62dfd667b6",
  "branch": "jaeone94/backport-14984-to-core-1.49",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2132.126000000028,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.578999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 535.831,
      "heapDeltaBytes": 5135308,
      "heapUsedBytes": 73820520,
      "domNodes": 14,
      "jsHeapTotalBytes": 20041728,
      "scriptDurationMs": 21.530000000000005,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2037.8110000000333,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.714000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 512.598,
      "heapDeltaBytes": 5361456,
      "heapUsedBytes": 73771160,
      "domNodes": 18,
      "jsHeapTotalBytes": 19779584,
      "scriptDurationMs": 22.883999999999997,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2065.0119999999674,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 47.937,
      "layouts": 12,
      "layoutDurationMs": 5.742,
      "taskDurationMs": 1109.74,
      "heapDeltaBytes": -15962320,
      "heapUsedBytes": 52442628,
      "domNodes": -281,
      "jsHeapTotalBytes": 20692992,
      "scriptDurationMs": 140.277,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1911.0640000000103,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 38.38700000000001,
      "layouts": 12,
      "layoutDurationMs": 3.557,
      "taskDurationMs": 969.036,
      "heapDeltaBytes": -19013928,
      "heapUsedBytes": 49550724,
      "domNodes": -282,
      "jsHeapTotalBytes": 21217280,
      "scriptDurationMs": 131.64100000000002,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1717.9419999999936,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.696000000000005,
      "layouts": 6,
      "layoutDurationMs": 0.5220000000000001,
      "taskDurationMs": 413.22800000000007,
      "heapDeltaBytes": 8172568,
      "heapUsedBytes": 76841692,
      "domNodes": 76,
      "jsHeapTotalBytes": 19517440,
      "scriptDurationMs": 24.184,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1717.8940000000011,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 18.21,
      "layouts": 6,
      "layoutDurationMs": 0.68,
      "taskDurationMs": 403.092,
      "heapDeltaBytes": 7975720,
      "heapUsedBytes": 76420336,
      "domNodes": 75,
      "jsHeapTotalBytes": 20041728,
      "scriptDurationMs": 23.251999999999995,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 606.8279999999504,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.413000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 396.959,
      "heapDeltaBytes": -11481612,
      "heapUsedBytes": 57184200,
      "domNodes": 16,
      "jsHeapTotalBytes": 20828160,
      "scriptDurationMs": 60.814,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 596.023999999943,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.488999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 400.58199999999994,
      "heapDeltaBytes": -11263664,
      "heapUsedBytes": 57179844,
      "domNodes": 18,
      "jsHeapTotalBytes": 20041728,
      "scriptDurationMs": 61.929,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2041.371999999967,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.661000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 714.391,
      "heapDeltaBytes": 7853976,
      "heapUsedBytes": 67714860,
      "domNodes": -281,
      "jsHeapTotalBytes": 5300224,
      "scriptDurationMs": 116.35299999999998,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2037.5950000000103,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.350000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 765.2489999999998,
      "heapDeltaBytes": 8293256,
      "heapUsedBytes": 68017288,
      "domNodes": -283,
      "jsHeapTotalBytes": 6086656,
      "scriptDurationMs": 122.98499999999999,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2213.0129999999895,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 14.089999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1352.423,
      "heapDeltaBytes": 5313272,
      "heapUsedBytes": 66007076,
      "domNodes": -283,
      "jsHeapTotalBytes": 5263360,
      "scriptDurationMs": 444.52799999999996,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2261.7139999999836,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.617,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1374.341,
      "heapDeltaBytes": 6174156,
      "heapUsedBytes": 66966820,
      "domNodes": -286,
      "jsHeapTotalBytes": 5001216,
      "scriptDurationMs": 450.157,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3347.4689999999896,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 14.889999999999997,
      "layouts": 60,
      "layoutDurationMs": 7.691,
      "taskDurationMs": 1608.3649999999998,
      "heapDeltaBytes": 5813712,
      "heapUsedBytes": 68083092,
      "domNodes": -287,
      "jsHeapTotalBytes": 7659520,
      "scriptDurationMs": 559.287,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3378.089999999929,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 14.658999999999999,
      "layouts": 60,
      "layoutDurationMs": 7.6049999999999995,
      "taskDurationMs": 1629.129,
      "heapDeltaBytes": 8046192,
      "heapUsedBytes": 70475612,
      "domNodes": -290,
      "jsHeapTotalBytes": 7135232,
      "scriptDurationMs": 563.434,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2074.928,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.033,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 739.1160000000001,
      "heapDeltaBytes": 9484352,
      "heapUsedBytes": 70751660,
      "domNodes": -282,
      "jsHeapTotalBytes": 3989504,
      "scriptDurationMs": 122.295,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2074.9250000000075,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.526000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 727.3199999999999,
      "heapDeltaBytes": 9170216,
      "heapUsedBytes": 70697112,
      "domNodes": -284,
      "jsHeapTotalBytes": 4251648,
      "scriptDurationMs": 121.23,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 614.5660000000248,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.426,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 413.307,
      "heapDeltaBytes": -11311140,
      "heapUsedBytes": 57277068,
      "domNodes": 20,
      "jsHeapTotalBytes": 22138880,
      "scriptDurationMs": 120.55699999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 624.7010000000728,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 8.864999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 426.447,
      "heapDeltaBytes": -11368392,
      "heapUsedBytes": 57402792,
      "domNodes": 14,
      "jsHeapTotalBytes": 21876736,
      "scriptDurationMs": 121.093,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2003.7159999999972,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.37,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 478.545,
      "heapDeltaBytes": 5359048,
      "heapUsedBytes": 73957004,
      "domNodes": 18,
      "jsHeapTotalBytes": 20041728,
      "scriptDurationMs": 17.249,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2001.117000000022,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.059,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 514.732,
      "heapDeltaBytes": 5208272,
      "heapUsedBytes": 73950628,
      "domNodes": 18,
      "jsHeapTotalBytes": 20041728,
      "scriptDurationMs": 19.558,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1753.4890000000019,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 41.541000000000004,
      "layouts": 16,
      "layoutDurationMs": 4.409,
      "taskDurationMs": 837.901,
      "heapDeltaBytes": -4124648,
      "heapUsedBytes": 64362576,
      "domNodes": 64,
      "jsHeapTotalBytes": 20041728,
      "scriptDurationMs": 98.617,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1738.7540000000854,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 39.202,
      "layouts": 16,
      "layoutDurationMs": 4.484999999999999,
      "taskDurationMs": 844.361,
      "heapDeltaBytes": -3835572,
      "heapUsedBytes": 64729324,
      "domNodes": 62,
      "jsHeapTotalBytes": 20041728,
      "scriptDurationMs": 101.783,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1437.0720000000574,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 32.03399999999999,
      "layouts": 14,
      "layoutDurationMs": 13.734,
      "taskDurationMs": 1010.2829999999998,
      "heapDeltaBytes": 3441544,
      "heapUsedBytes": 75144456,
      "domNodes": 13673,
      "jsHeapTotalBytes": 15466496,
      "scriptDurationMs": 40.67499999999999,
      "eventListeners": 2375,
      "totalBlockingTimeMs": 152,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8533.772999999997,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 37.513000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4736.883,
      "heapDeltaBytes": 20893192,
      "heapUsedBytes": 80656596,
      "domNodes": -284,
      "jsHeapTotalBytes": 7065600,
      "scriptDurationMs": 1450.658,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9088.139000000068,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 38.486,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5117.657999999999,
      "heapDeltaBytes": 23994212,
      "heapUsedBytes": 84125172,
      "domNodes": -285,
      "jsHeapTotalBytes": 10211328,
      "scriptDurationMs": 1659.9170000000001,
      "eventListeners": -131,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17634.638000000054,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17599.951,
      "heapDeltaBytes": -46538768,
      "heapUsedBytes": 167064648,
      "domNodes": -8312,
      "jsHeapTotalBytes": -10657792,
      "scriptDurationMs": 584.3240000000001,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17601.118000000042,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17566.558,
      "heapDeltaBytes": -59618004,
      "heapUsedBytes": 167476560,
      "domNodes": -8312,
      "jsHeapTotalBytes": -9379840,
      "scriptDurationMs": 599.955,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21170.511000000035,
      "styleRecalcs": 143,
      "styleRecalcDurationMs": 19.00099999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21122.783,
      "heapDeltaBytes": -46465560,
      "heapUsedBytes": 177457520,
      "domNodes": -8312,
      "jsHeapTotalBytes": -10760192,
      "scriptDurationMs": 899.3899999999999,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 128,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21418.047000000002,
      "styleRecalcs": 149,
      "styleRecalcDurationMs": 19.770999999999983,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21376.313,
      "heapDeltaBytes": -43649476,
      "heapUsedBytes": 166407584,
      "domNodes": -8341,
      "jsHeapTotalBytes": -12263424,
      "scriptDurationMs": 947.671,
      "eventListeners": -16381,
      "totalBlockingTimeMs": 357,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 472.8529999999864,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 26.200999999999993,
      "layouts": 3,
      "layoutDurationMs": 1.374,
      "taskDurationMs": 141.63,
      "heapDeltaBytes": -15628592,
      "heapUsedBytes": 51849100,
      "domNodes": 157,
      "jsHeapTotalBytes": 7196672,
      "scriptDurationMs": 11.199999999999998,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "workflow-execution",
      "durationMs": 453.3410000000231,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 23.082000000000004,
      "layouts": 4,
      "layoutDurationMs": 1.383,
      "taskDurationMs": 124.43700000000001,
      "heapDeltaBytes": -16136712,
      "heapUsedBytes": 51633740,
      "domNodes": 123,
      "jsHeapTotalBytes": 7458816,
      "scriptDurationMs": 10.441,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@             Coverage Diff             @@
##           core/1.49   #15102    +/-   ##
===========================================
  Coverage      79.20%   79.20%            
===========================================
  Files           1854     1854            
  Lines         108629   108643    +14     
  Branches       33159    34089   +930     
===========================================
+ Hits           86035    86050    +15     
+ Misses         22159    22158     -1     
  Partials         435      435            
Flag Coverage Δ
unit 71.89% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/components/ui/tooltip/AccessibleTooltip.vue 100.00% <100.00%> (ø)
...tform/missingModel/components/MissingModelCard.vue 97.40% <100.00%> (+0.38%) ⬆️
...atform/missingModel/components/MissingModelRow.vue 94.76% <100.00%> (+0.64%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot merged commit cf11f37 into core/1.49 Aug 12, 2026
78 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the jaeone94/backport-14984-to-core-1.49 branch August 12, 2026 05:36
balpreetgrowthnatives pushed a commit to balpreetgrowthnatives/ComfyUI_frontend that referenced this pull request Aug 14, 2026
## The workflow does not catch the branches it exists for

`pr-label-backport.yaml`'s header states its purpose plainly —
*"Guarantees that
every backport PR carries the `backport` label, **whoever opened it**"*
— and
explains that manual backports are the case that matters, because
`pr-backport.yaml` only labels the PRs it creates itself, and hands off
to a
human when the cherry-pick conflicts.

But `isBackportBranchForBase` matched only the exact branch the workflow
generates:

```ts
const BACKPORT_BRANCH_PATTERN = /^backport-\d+-to-(.+)$/
```

A human finishing a conflicted cherry-pick does not produce that. They
produce
`<user>/backport-<pr>-to-<target>` — what `gh` and most local branch
conventions give you.

## This week's worked example

**Comfy-Org#15102** and **Comfy-Org#15103** (`jaeone94/backport-14984-to-core-1.49` and
`…-cloud-1.49`) were opened by hand after `pr-backport.yaml` failed on
Comfy-Org#14984's cherry-pick, and carry the `backport` label **only because
someone
applied it manually**.

That matters because an unlabelled backport is invisible to
`backport-auto-merge.yaml` and `pr-assign-release-sheriff.yaml` — both
sweep
`gh pr list --label backport` — so it sits open until somebody notices.
Which
is exactly what Comfy-Org#14018–Comfy-Org#14021 are cited for in the workflow's own
header.

Surveying every backport-titled PR in the repo: the bot's
`backport-<n>-to-<target>` branches are all labelled, and the only
user-prefixed pair is the one that needed a human.

## Only the prefix widens

```diff
-const BACKPORT_BRANCH_PATTERN = /^backport-\d+-to-(.+)$/
+const BACKPORT_BRANCH_PATTERN = /^(?:.*\/)?backport-\d+-to-(.+)$/
```

The `\d+-to-` core and the existing base check still decide what counts
as a
backport, so this does **not** loosen the definition:

| branch | base | before | after |
| --- | --- | --- | --- |
| `backport-14979-to-core-1.49` | `core/1.49` | ✅ | ✅ |
| `jaeone94/backport-14984-to-core-1.49` | `core/1.49` | ❌ | ✅ |
| `jaeone94/backport-14984-to-core-1.49` | `cloud/1.49` | ❌ | ❌ *(target
≠ base)* |
| `glary/backport-resilient-partial-failure` | `core/1.49` | ❌ | ❌ |
| `deepme987/infra/backport-assign-author` | `main` | ❌ | ❌ |

The last two are real branches in this repo — *about* backporting rather
than
backports. A prefix must not turn them into one, and it doesn't: they
have no
`<digits>-to-` segment.

## Verification

`backport-label.test.ts` **16/16**, with three new cases covering the
prefixed
form, the prefixed-but-wrong-base rejection, and the two real
non-backport
branches above.

Mutation-checked rather than asserted green — reverting the regex to
`^backport-`
fails exactly one test (the new prefixed case) and leaves the other 15
passing.

## Disclosure

I hit this myself from the other direction. My manual backports
Comfy-Org#15095/Comfy-Org#15096
used `backport/<pr>-to-<target>` — a **slash** where the convention uses
a
hyphen. That one is genuinely off-convention rather than a gap in the
rule, so
this PR deliberately does **not** widen the pattern to bless it; I fixed
those
branches' labels by hand instead.

Co-authored-by: t <t@t.t>
claude Bot pushed a commit that referenced this pull request Aug 24, 2026
…padding on subgraph configure

Legacy/imported subgraph instances can serialize widgets_values with an
extra slot for the control_after_generate companion widget (mirroring
the underlying node's own widget layout), even though the companion is
never itself a promoted input. SubgraphNode._applyPromotedWidgetValues
walks widgets_values positionally without accounting for this, so
values after the control slot land on the wrong promoted widget.

Fixes #15102
claude Bot pushed a commit that referenced this pull request Aug 24, 2026
SubgraphNode._applyPromotedWidgetValues walked widgets_values
positionally, one slot per promoted widget-input, with no allowance
for the control_after_generate companion widget some promoted widgets
carry. Legacy/imported subgraph instances that still serialize an
extra widgets_values slot for that companion (mirroring the underlying
node's own widget layout) caused every promoted value after it to land
on the wrong widget.

Only compensate when widgets_values is longer than the number of
promoted inputs, so current-format instances (exactly one value per
promoted input) are unaffected.

Fixes #15102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants