Repository navigation
[backport cloud/1.49] fix(missing-model): improve gated access accessibility - #15103
Conversation
Think of gated model access like a locked door with one clear sign: everyone should learn why it is locked, and the control should honestly say where it leads. This change makes that sign work for screen readers and keyboards, keeps unsafe destinations from appearing, and uses clear singular or plural wording without changing the visual design. Five public follow-up issues identified gaps that remained after gated metadata was centralized: asynchronously discovered gating could be missed by screen readers, explanation text was hover-dependent for sighted keyboard users, external navigation exposed the wrong role, Download could repeat the same description, and the copy hardcoded a plural. Without this follow-up, people could receive incomplete or misleading guidance depending on input method and runtime. Publishing it after the parent refactor merged keeps the patch focused on accessibility and wording while preserving the existing visual design. - **Authored by:** agent-work loop - **From:** #14360 — Gated-model hint appears asynchronously with no screen-reader announcement; #14361 — Gated-model explanation reaches sighted keyboard-only users through title only; #14362 — Gated-repo lock control navigates externally but is announced as a button; #14363 — Gated Download button carries the same description via both title and aria-describedby; #14368 — Gated-model copy uses three phrasings of one action, and hardcodes the plural - **Verified:** pnpm test:unit on AccessibleTooltip, MissingModelCard, MissingModelRow, and useMissingModelDownload: 57 passed; pnpm test:unit on PaidTemplateBadge and LogoOverlay: 12 passed; pnpm typecheck: passed; pnpm lint: passed; pnpm format:check: 4,616 files passed; pnpm knip: passed; git diff origin/main...HEAD --check: passed - **Deviations:** None - **Type:** bug fix, covering gated-model accessibility semantics, trusted navigation, and copy - **Slots into:** Follow-up to #14982 — refactor(missing-model): centralize metadata state. Because it merged before publication, this PR targets main and contains only follow-up accessibility and copy work. - Politely announce gated guidance only when metadata transitions from not gated to gated, keep warm-cache mounts silent, and clear the live region so a later appearance can announce again. - Reveal the gated explanation on keyboard focus, expose browser and legacy Electron navigation as safe links with a new-tab warning, and keep Desktop2 navigation as a button with honest fallback labeling. - Require a trusted Hugging Face URL before showing gated controls or descriptions, and give Download one accessible description instead of duplicating title and aria-describedby. - Use consistent sign-in wording and pluralize guidance from the gated model count. - **What:** Updates the shared accessible-tooltip trigger pattern, missing-model card and row behavior, English locale copy, and focused behavioral tests. Please focus on live-region transition behavior, the trusted URL boundary, link-versus-button semantics across runtimes, and the single-description behavior for Download. - [ ] Discover gating after mount and verify one polite announcement; hide and re-show it to verify the status clears and the same guidance can announce again. - [ ] Mount with warm cached gating and verify the visible pluralized note does not trigger the live region. - [ ] Focus the gated access control and verify its explanation is available without hover. - [ ] Verify browser and legacy Electron use trusted new-tab links, Desktop2 uses a fallback-labeled button, and untrusted URLs produce no gated UI or Download description. - [ ] Verify singular and plural sign-in wording and confirm Download receives exactly one gated explanation. - [ ] Confirm the accessibility fixes are active without a feature flag; they correct the existing gated-model flow and preserve its visual design. Not included; visual design is preserved. Fixes #14360 Fixes #14361 Fixes #14362 Fixes #14363 Fixes #14368
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1788 passed, 0 failed · 3 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-12T01:26:16.311Z",
"gitSha": "77023d081a01dbec957f1b53b70402f74c8ad8bf",
"branch": "jaeone94/backport-14984-to-cloud-1.49",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1992.381999999992,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.05,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.638,
"heapDeltaBytes": 5167632,
"heapUsedBytes": 73808112,
"domNodes": 20,
"jsHeapTotalBytes": 19775488,
"scriptDurationMs": 12.854000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 1997.1009999999865,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.053000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.487,
"heapDeltaBytes": 5368176,
"heapUsedBytes": 74180928,
"domNodes": 20,
"jsHeapTotalBytes": 20299776,
"scriptDurationMs": 13.863,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1795.8590000000072,
"styleRecalcs": 73,
"styleRecalcDurationMs": 31.045,
"layouts": 12,
"layoutDurationMs": 3.111,
"taskDurationMs": 784.1790000000001,
"heapDeltaBytes": -458232,
"heapUsedBytes": 68268916,
"domNodes": 56,
"jsHeapTotalBytes": 20561920,
"scriptDurationMs": 100.92099999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1721.2499999999977,
"styleRecalcs": 74,
"styleRecalcDurationMs": 25.332,
"layouts": 12,
"layoutDurationMs": 2.492,
"taskDurationMs": 685.5070000000001,
"heapDeltaBytes": -18804752,
"heapUsedBytes": 49736040,
"domNodes": -278,
"jsHeapTotalBytes": 20426752,
"scriptDurationMs": 80.781,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1682.3870000000056,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.022000000000002,
"layouts": 6,
"layoutDurationMs": 0.5999999999999999,
"taskDurationMs": 313.176,
"heapDeltaBytes": 8355168,
"heapUsedBytes": 76793892,
"domNodes": 79,
"jsHeapTotalBytes": 20037632,
"scriptDurationMs": 14.914,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1682.7650000000176,
"styleRecalcs": 30,
"styleRecalcDurationMs": 12.517000000000001,
"layouts": 6,
"layoutDurationMs": 0.5269999999999999,
"taskDurationMs": 314.097,
"heapDeltaBytes": 8100344,
"heapUsedBytes": 76510948,
"domNodes": 79,
"jsHeapTotalBytes": 20299776,
"scriptDurationMs": 15.005999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 499.4360000000029,
"styleRecalcs": 13,
"styleRecalcDurationMs": 5.865000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 293.572,
"heapDeltaBytes": -12839024,
"heapUsedBytes": 55772568,
"domNodes": 22,
"jsHeapTotalBytes": 22134784,
"scriptDurationMs": 42.173,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 545.9089999999946,
"styleRecalcs": 13,
"styleRecalcDurationMs": 5.761,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 297.485,
"heapDeltaBytes": -11154064,
"heapUsedBytes": 57581268,
"domNodes": 22,
"jsHeapTotalBytes": 20037632,
"scriptDurationMs": 40.193000000000005,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2024.0109999999731,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.274000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 557.8799999999999,
"heapDeltaBytes": 3164440,
"heapUsedBytes": 64632448,
"domNodes": -280,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 67.732,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2012.535000000014,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.565,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.9839999999999,
"heapDeltaBytes": 7850420,
"heapUsedBytes": 67401232,
"domNodes": -282,
"jsHeapTotalBytes": 3989504,
"scriptDurationMs": 69.652,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2101.7889999999966,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.854000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 955.23,
"heapDeltaBytes": 25297936,
"heapUsedBytes": 85752708,
"domNodes": -283,
"jsHeapTotalBytes": 5525504,
"scriptDurationMs": 293.771,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2096.9570000000317,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.794,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 997.8610000000001,
"heapDeltaBytes": 7147344,
"heapUsedBytes": 67906220,
"domNodes": -284,
"jsHeapTotalBytes": 5001216,
"scriptDurationMs": 309.953,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3109.2740000000276,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.485999999999997,
"layouts": 60,
"layoutDurationMs": 6.297000000000001,
"taskDurationMs": 1144.455,
"heapDeltaBytes": -8810412,
"heapUsedBytes": 54523652,
"domNodes": 20,
"jsHeapTotalBytes": 7135232,
"scriptDurationMs": 365.584,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3075.3200000000334,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.315,
"layouts": 60,
"layoutDurationMs": 5.974,
"taskDurationMs": 1162.4180000000001,
"heapDeltaBytes": 23043932,
"heapUsedBytes": 85399184,
"domNodes": 16,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 382.859,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2037.5660000000266,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.771999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 558.0110000000001,
"heapDeltaBytes": 8549584,
"heapUsedBytes": 70056440,
"domNodes": -282,
"jsHeapTotalBytes": 5300224,
"scriptDurationMs": 69.49900000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2024.597999999969,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.823000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.176,
"heapDeltaBytes": 6695728,
"heapUsedBytes": 68274132,
"domNodes": -282,
"jsHeapTotalBytes": 5038080,
"scriptDurationMs": 72.00999999999999,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 518.224000000032,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.673000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 315.71299999999997,
"heapDeltaBytes": -12528720,
"heapUsedBytes": 56037136,
"domNodes": 22,
"jsHeapTotalBytes": 22659072,
"scriptDurationMs": 88.82900000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 535.8660000000555,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.972000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 328.185,
"heapDeltaBytes": -11033884,
"heapUsedBytes": 57657556,
"domNodes": 20,
"jsHeapTotalBytes": 21086208,
"scriptDurationMs": 94.941,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2016.3050000000453,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.546,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 384.358,
"heapDeltaBytes": 5237848,
"heapUsedBytes": 73876840,
"domNodes": 20,
"jsHeapTotalBytes": 20299776,
"scriptDurationMs": 11.929,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1994.8630000000094,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.938000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.19100000000003,
"heapDeltaBytes": 5346116,
"heapUsedBytes": 74010384,
"domNodes": 20,
"jsHeapTotalBytes": 20299776,
"scriptDurationMs": 12.114999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.014999999983,
"styleRecalcs": 76,
"styleRecalcDurationMs": 28.595000000000002,
"layouts": 16,
"layoutDurationMs": 3.4250000000000003,
"taskDurationMs": 602.0219999999999,
"heapDeltaBytes": -3880224,
"heapUsedBytes": 64678060,
"domNodes": 62,
"jsHeapTotalBytes": 20299776,
"scriptDurationMs": 62.54900000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.9980000000355,
"styleRecalcs": 75,
"styleRecalcDurationMs": 26.889999999999997,
"layouts": 16,
"layoutDurationMs": 3.2809999999999997,
"taskDurationMs": 608.391,
"heapDeltaBytes": -4069004,
"heapUsedBytes": 64799684,
"domNodes": 61,
"jsHeapTotalBytes": 20299776,
"scriptDurationMs": 62.821000000000005,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 915.7989999999927,
"styleRecalcs": 20,
"styleRecalcDurationMs": 23.891000000000002,
"layouts": 16,
"layoutDurationMs": 8.609,
"taskDurationMs": 748.7429999999999,
"heapDeltaBytes": 30514500,
"heapUsedBytes": 97709552,
"domNodes": 13673,
"jsHeapTotalBytes": 14417920,
"scriptDurationMs": 21.229,
"eventListeners": 2373,
"totalBlockingTimeMs": 112,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8093.4839999999895,
"styleRecalcs": 249,
"styleRecalcDurationMs": 28.399,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3318.439,
"heapDeltaBytes": 11873576,
"heapUsedBytes": 71617432,
"domNodes": -282,
"jsHeapTotalBytes": 6049792,
"scriptDurationMs": 938.63,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8106.816999999978,
"styleRecalcs": 250,
"styleRecalcDurationMs": 26.169,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3431.526,
"heapDeltaBytes": 27841736,
"heapUsedBytes": 88870444,
"domNodes": -280,
"jsHeapTotalBytes": 7884800,
"scriptDurationMs": 958.017,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12310.308999999961,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12293.452000000001,
"heapDeltaBytes": -60871420,
"heapUsedBytes": 166711752,
"domNodes": -8316,
"jsHeapTotalBytes": -12525568,
"scriptDurationMs": 455.83399999999995,
"eventListeners": -16393,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12126.035000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12109.419,
"heapDeltaBytes": -47013500,
"heapUsedBytes": 166383080,
"domNodes": -8312,
"jsHeapTotalBytes": -13574144,
"scriptDurationMs": 458.47100000000006,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 15411.833999999999,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.199000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15391.519999999999,
"heapDeltaBytes": -66274920,
"heapUsedBytes": 157394216,
"domNodes": -8312,
"jsHeapTotalBytes": -11739136,
"scriptDurationMs": 725.013,
"eventListeners": -16388,
"totalBlockingTimeMs": 65,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15182.951000000003,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.048000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15143.006,
"heapDeltaBytes": -35406984,
"heapUsedBytes": 177841328,
"domNodes": -8312,
"jsHeapTotalBytes": -10235904,
"scriptDurationMs": 748.1549999999999,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 84.39400000003161,
"styleRecalcs": 7,
"styleRecalcDurationMs": 10.616,
"layouts": 5,
"layoutDurationMs": 1.713,
"taskDurationMs": 61.080999999999996,
"heapDeltaBytes": 3076528,
"heapUsedBytes": 70739664,
"domNodes": 132,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 4.0280000000000005,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 447.77800000008483,
"styleRecalcs": 13,
"styleRecalcDurationMs": 15.061,
"layouts": 3,
"layoutDurationMs": 0.654,
"taskDurationMs": 99.62199999999999,
"heapDeltaBytes": -16130780,
"heapUsedBytes": 51737412,
"domNodes": 123,
"jsHeapTotalBytes": 7192576,
"scriptDurationMs": 7.195999999999999,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.49 #15103 +/- ##
=============================================
Coverage ? 71.91%
=============================================
Files ? 1767
Lines ? 92444
Branches ? 26802
=============================================
Hits ? 66482
Misses ? 25843
Partials ? 119
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
## The workflow does not catch the branches it exists for `pr-label-backport.yaml`'s header states its purpose plainly — *"Guarantees that every backport PR carries the `backport` label, **whoever opened it**"* — and explains that manual backports are the case that matters, because `pr-backport.yaml` only labels the PRs it creates itself, and hands off to a human when the cherry-pick conflicts. But `isBackportBranchForBase` matched only the exact branch the workflow generates: ```ts const BACKPORT_BRANCH_PATTERN = /^backport-\d+-to-(.+)$/ ``` A human finishing a conflicted cherry-pick does not produce that. They produce `<user>/backport-<pr>-to-<target>` — what `gh` and most local branch conventions give you. ## This week's worked example **Comfy-Org#15102** and **Comfy-Org#15103** (`jaeone94/backport-14984-to-core-1.49` and `…-cloud-1.49`) were opened by hand after `pr-backport.yaml` failed on Comfy-Org#14984's cherry-pick, and carry the `backport` label **only because someone applied it manually**. That matters because an unlabelled backport is invisible to `backport-auto-merge.yaml` and `pr-assign-release-sheriff.yaml` — both sweep `gh pr list --label backport` — so it sits open until somebody notices. Which is exactly what Comfy-Org#14018–Comfy-Org#14021 are cited for in the workflow's own header. Surveying every backport-titled PR in the repo: the bot's `backport-<n>-to-<target>` branches are all labelled, and the only user-prefixed pair is the one that needed a human. ## Only the prefix widens ```diff -const BACKPORT_BRANCH_PATTERN = /^backport-\d+-to-(.+)$/ +const BACKPORT_BRANCH_PATTERN = /^(?:.*\/)?backport-\d+-to-(.+)$/ ``` The `\d+-to-` core and the existing base check still decide what counts as a backport, so this does **not** loosen the definition: | branch | base | before | after | | --- | --- | --- | --- | | `backport-14979-to-core-1.49` | `core/1.49` | ✅ | ✅ | | `jaeone94/backport-14984-to-core-1.49` | `core/1.49` | ❌ | ✅ | | `jaeone94/backport-14984-to-core-1.49` | `cloud/1.49` | ❌ | ❌ *(target ≠ base)* | | `glary/backport-resilient-partial-failure` | `core/1.49` | ❌ | ❌ | | `deepme987/infra/backport-assign-author` | `main` | ❌ | ❌ | The last two are real branches in this repo — *about* backporting rather than backports. A prefix must not turn them into one, and it doesn't: they have no `<digits>-to-` segment. ## Verification `backport-label.test.ts` **16/16**, with three new cases covering the prefixed form, the prefixed-but-wrong-base rejection, and the two real non-backport branches above. Mutation-checked rather than asserted green — reverting the regex to `^backport-` fails exactly one test (the new prefixed case) and leaves the other 15 passing. ## Disclosure I hit this myself from the other direction. My manual backports Comfy-Org#15095/Comfy-Org#15096 used `backport/<pr>-to-<target>` — a **slash** where the convention uses a hyphen. That one is genuinely off-convention rather than a gap in the rule, so this PR deliberately does **not** widen the pattern to bless it; I fixed those branches' labels by hand instead. Co-authored-by: t <t@t.t>
ELI5
This carries the already merged gated-model accessibility fix into cloud/1.49. It is the same repair, fitted to the older branch by keeping that branch's test cleanup while adding the new locale reset.
Motivation
The automatic backport of #14984 — fix(missing-model): improve gated access accessibility could not merge one test file because main and cloud/1.49 clean up Vitest mocks differently. The prerequisite missing-model refactor is already present on the target branch, so a separate dependency backport is unnecessary. Resolving the small test-fixture conflict manually lets the 1.49 release line receive the already reviewed accessibility behavior without importing main's unrelated test-infrastructure changes.
Provenance
pnpm test:unitrun: 6 files and 69 tests passed;pnpm typecheck: passed;pnpm lint: passed with 0 errors and 59 pre-existing warnings outside the changed files;pnpm format:check: 4,516 files passed;pnpm knip: passed;git diff origin/cloud/1.49...HEAD --check: passedReviewer context
Summary
vi.clearAllMocks()calls while also restoring the English locale before each affected card test.Changes
Review Focus
Please verify the two resolved
beforeEachblocks inMissingModelCard.test.tsretain both mock cleanup and locale reset; all other files applied cleanly from the merged PR.Test plan
No feature flag is added; this backports an accessibility correction already merged on main.
Screenshots (if applicable)
Not included; this backport preserves the visual behavior of the merged PR.