Skip to content

[backport cloud/1.49] fix(missing-model): improve gated access accessibility - #15103

Merged
comfy-pr-bot merged 1 commit into
cloud/1.49from
jaeone94/backport-14984-to-cloud-1.49
Aug 12, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.49from
jaeone94/backport-14984-to-cloud-1.49

Conversation

@jaeone94

Copy link
Copy Markdown
Collaborator

ELI5

This carries the already merged gated-model accessibility fix into cloud/1.49. It is the same repair, fitted to the older branch by keeping that branch's test cleanup while adding the new locale reset.

Motivation

The automatic backport of #14984 — fix(missing-model): improve gated access accessibility could not merge one test file because main and cloud/1.49 clean up Vitest mocks differently. The prerequisite missing-model refactor is already present on the target branch, so a separate dependency backport is unnecessary. Resolving the small test-fixture conflict manually lets the 1.49 release line receive the already reviewed accessibility behavior without importing main's unrelated test-infrastructure changes.

Provenance

  • Authored by: interactive session
  • Verified: focused pnpm test:unit run: 6 files and 69 tests passed; pnpm typecheck: passed; pnpm lint: passed with 0 errors and 59 pre-existing warnings outside the changed files; pnpm format:check: 4,516 files passed; pnpm knip: passed; git diff origin/cloud/1.49...HEAD --check: passed
  • Deviations: None

Reviewer context

Summary

  • Backports the six accessibility, copy, and focused-test changes from fix(missing-model): improve gated access accessibility #14984 — fix(missing-model): improve gated access accessibility.
  • Preserves cloud/1.49's explicit vi.clearAllMocks() calls while also restoring the English locale before each affected card test.
  • Does not backport unrelated main-branch test infrastructure.

Changes

  • What: Updates gated-model announcements, keyboard-accessible guidance, trusted navigation semantics, accessible descriptions, pluralized copy, and their tests.
  • Dependencies: None; the prerequisite refactor is already on cloud/1.49.

Review Focus

Please verify the two resolved beforeEach blocks in MissingModelCard.test.ts retain both mock cleanup and locale reset; all other files applied cleanly from the merged PR.

Test plan

  • Run the six focused unit/component test files on cloud/1.49.
  • Run typecheck, lint, formatting, and unused-code checks.
  • Confirm target-branch CI is green.
  • Spot-check the gated-model hint with keyboard and screen-reader navigation if manual release validation is required.

No feature flag is added; this backports an accessibility correction already merged on main.

Screenshots (if applicable)

Not included; this backport preserves the visual behavior of the merged PR.

Think of gated model access like a locked door with one clear sign:
everyone should learn why it is locked, and the control should honestly
say where it leads. This change makes that sign work for screen readers
and keyboards, keeps unsafe destinations from appearing, and uses clear
singular or plural wording without changing the visual design.

Five public follow-up issues identified gaps that remained after gated
metadata was centralized: asynchronously discovered gating could be
missed by screen readers, explanation text was hover-dependent for
sighted keyboard users, external navigation exposed the wrong role,
Download could repeat the same description, and the copy hardcoded a
plural. Without this follow-up, people could receive incomplete or
misleading guidance depending on input method and runtime. Publishing it
after the parent refactor merged keeps the patch focused on
accessibility and wording while preserving the existing visual design.

- **Authored by:** agent-work loop
- **From:** #14360 — Gated-model hint appears asynchronously with no
screen-reader announcement; #14361 — Gated-model explanation reaches
sighted keyboard-only users through title only; #14362 — Gated-repo lock
control navigates externally but is announced as a button; #14363 —
Gated Download button carries the same description via both title and
aria-describedby; #14368 — Gated-model copy uses three phrasings of one
action, and hardcodes the plural
- **Verified:** pnpm test:unit on AccessibleTooltip, MissingModelCard,
MissingModelRow, and useMissingModelDownload: 57 passed; pnpm test:unit
on PaidTemplateBadge and LogoOverlay: 12 passed; pnpm typecheck: passed;
pnpm lint: passed; pnpm format:check: 4,616 files passed; pnpm knip:
passed; git diff origin/main...HEAD --check: passed
- **Deviations:** None

- **Type:** bug fix, covering gated-model accessibility semantics,
trusted navigation, and copy
- **Slots into:** Follow-up to #14982 — refactor(missing-model):
centralize metadata state. Because it merged before publication, this PR
targets main and contains only follow-up accessibility and copy work.

- Politely announce gated guidance only when metadata transitions from
not gated to gated, keep warm-cache mounts silent, and clear the live
region so a later appearance can announce again.
- Reveal the gated explanation on keyboard focus, expose browser and
legacy Electron navigation as safe links with a new-tab warning, and
keep Desktop2 navigation as a button with honest fallback labeling.
- Require a trusted Hugging Face URL before showing gated controls or
descriptions, and give Download one accessible description instead of
duplicating title and aria-describedby.
- Use consistent sign-in wording and pluralize guidance from the gated
model count.

- **What:** Updates the shared accessible-tooltip trigger pattern,
missing-model card and row behavior, English locale copy, and focused
behavioral tests.

Please focus on live-region transition behavior, the trusted URL
boundary, link-versus-button semantics across runtimes, and the
single-description behavior for Download.

- [ ] Discover gating after mount and verify one polite announcement;
hide and re-show it to verify the status clears and the same guidance
can announce again.
- [ ] Mount with warm cached gating and verify the visible pluralized
note does not trigger the live region.
- [ ] Focus the gated access control and verify its explanation is
available without hover.
- [ ] Verify browser and legacy Electron use trusted new-tab links,
Desktop2 uses a fallback-labeled button, and untrusted URLs produce no
gated UI or Download description.
- [ ] Verify singular and plural sign-in wording and confirm Download
receives exactly one gated explanation.
- [ ] Confirm the accessibility fixes are active without a feature flag;
they correct the existing gated-model flow and preserve its visual
design.

Not included; visual design is preserved.

Fixes #14360
Fixes #14361
Fixes #14362
Fixes #14363
Fixes #14368
@jaeone94 jaeone94 added the backport Backporting a PR onto a release candidate label Aug 12, 2026
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 12, 2026
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a928dff8-3596-483f-9a23-eafbd7300804

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 12, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/12/2026, 01:16:59 AM UTC

Links

🎭 Playwright: ✅ 1788 passed, 0 failed · 3 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1767 / ❌ 0 / ⚠️ 3 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.3 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.1 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.0 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.3 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.7 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.5 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.7 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 112ms TBT · 93.2 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.5 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 158.8 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 33ms TBT · 159.9 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 6ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 399ms
canvas-idle: script duration 13ms
canvas-idle: TBT 0ms
canvas-idle: heap used 70.6 MB
canvas-idle: DOM nodes 20
canvas-idle: event listeners 6
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 28ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 735ms
canvas-mouse-sweep: script duration 91ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 56.3 MB
canvas-mouse-sweep: DOM nodes -111
canvas-mouse-sweep: event listeners -73
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 13ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 30
canvas-zoom-sweep: task duration 314ms
canvas-zoom-sweep: script duration 15ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 73.1 MB
canvas-zoom-sweep: DOM nodes 79
canvas-zoom-sweep: event listeners 20
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 6ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 296ms
dom-widget-clipping: script duration 41ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 54.1 MB
dom-widget-clipping: DOM nodes 22
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 10
large-graph-idle: task duration 568ms
large-graph-idle: script duration 69ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 63.0 MB
large-graph-idle: DOM nodes -281
large-graph-idle: event listeners -164
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 977ms
large-graph-pan: script duration 302ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 73.3 MB
large-graph-pan: DOM nodes -284
large-graph-pan: event listeners -163
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 6ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 67
large-graph-zoom: task duration 1153ms
large-graph-zoom: script duration 374ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 66.7 MB
large-graph-zoom: DOM nodes 18
large-graph-zoom: event listeners -72
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 6ms
minimap-idle: layout count 0
minimap-idle: style recalc count 9
minimap-idle: task duration 568ms
minimap-idle: script duration 71ms
minimap-idle: TBT 0ms
minimap-idle: heap used 66.0 MB
minimap-idle: DOM nodes -282
minimap-idle: event listeners -164
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 8ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 322ms
subgraph-dom-widget-clipping: script duration 92ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 54.2 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 6ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 392ms
subgraph-idle: script duration 12ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 70.5 MB
subgraph-idle: DOM nodes 20
subgraph-idle: event listeners 5
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 3ms
subgraph-mouse-sweep: style recalc duration 28ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 605ms
subgraph-mouse-sweep: script duration 63ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 61.7 MB
subgraph-mouse-sweep: DOM nodes 62
subgraph-mouse-sweep: event listeners 6
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 9ms
subgraph-transition-enter: style recalc duration 24ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 749ms
subgraph-transition-enter: script duration 21ms
subgraph-transition-enter: TBT 112ms
subgraph-transition-enter: heap used 93.2 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2373
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 27ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 3375ms
viewport-pan-sweep: script duration 948ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 76.5 MB
viewport-pan-sweep: DOM nodes -281
viewport-pan-sweep: event listeners -148
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 12201ms
vue-large-graph-idle: script duration 457ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 158.8 MB
vue-large-graph-idle: DOM nodes -8314
vue-large-graph-idle: event listeners -16391
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 13ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 71
vue-large-graph-pan: task duration 15267ms
vue-large-graph-pan: script duration 737ms
vue-large-graph-pan: TBT 33ms
vue-large-graph-pan: heap used 159.9 MB
vue-large-graph-pan: DOM nodes -8312
vue-large-graph-pan: event listeners -16387
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 13ms
workflow-execution: layout count 4
workflow-execution: style recalc count 10
workflow-execution: task duration 80ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 58.4 MB
workflow-execution: DOM nodes 128
workflow-execution: event listeners 62
Raw data
{
  "timestamp": "2026-08-12T01:26:16.311Z",
  "gitSha": "77023d081a01dbec957f1b53b70402f74c8ad8bf",
  "branch": "jaeone94/backport-14984-to-cloud-1.49",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 1992.381999999992,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.05,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 394.638,
      "heapDeltaBytes": 5167632,
      "heapUsedBytes": 73808112,
      "domNodes": 20,
      "jsHeapTotalBytes": 19775488,
      "scriptDurationMs": 12.854000000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 1997.1009999999865,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.053000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 403.487,
      "heapDeltaBytes": 5368176,
      "heapUsedBytes": 74180928,
      "domNodes": 20,
      "jsHeapTotalBytes": 20299776,
      "scriptDurationMs": 13.863,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1795.8590000000072,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 31.045,
      "layouts": 12,
      "layoutDurationMs": 3.111,
      "taskDurationMs": 784.1790000000001,
      "heapDeltaBytes": -458232,
      "heapUsedBytes": 68268916,
      "domNodes": 56,
      "jsHeapTotalBytes": 20561920,
      "scriptDurationMs": 100.92099999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1721.2499999999977,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 25.332,
      "layouts": 12,
      "layoutDurationMs": 2.492,
      "taskDurationMs": 685.5070000000001,
      "heapDeltaBytes": -18804752,
      "heapUsedBytes": 49736040,
      "domNodes": -278,
      "jsHeapTotalBytes": 20426752,
      "scriptDurationMs": 80.781,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1682.3870000000056,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 14.022000000000002,
      "layouts": 6,
      "layoutDurationMs": 0.5999999999999999,
      "taskDurationMs": 313.176,
      "heapDeltaBytes": 8355168,
      "heapUsedBytes": 76793892,
      "domNodes": 79,
      "jsHeapTotalBytes": 20037632,
      "scriptDurationMs": 14.914,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1682.7650000000176,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 12.517000000000001,
      "layouts": 6,
      "layoutDurationMs": 0.5269999999999999,
      "taskDurationMs": 314.097,
      "heapDeltaBytes": 8100344,
      "heapUsedBytes": 76510948,
      "domNodes": 79,
      "jsHeapTotalBytes": 20299776,
      "scriptDurationMs": 15.005999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 499.4360000000029,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 5.865000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 293.572,
      "heapDeltaBytes": -12839024,
      "heapUsedBytes": 55772568,
      "domNodes": 22,
      "jsHeapTotalBytes": 22134784,
      "scriptDurationMs": 42.173,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 545.9089999999946,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 5.761,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 297.485,
      "heapDeltaBytes": -11154064,
      "heapUsedBytes": 57581268,
      "domNodes": 22,
      "jsHeapTotalBytes": 20037632,
      "scriptDurationMs": 40.193000000000005,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2024.0109999999731,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.274000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 557.8799999999999,
      "heapDeltaBytes": 3164440,
      "heapUsedBytes": 64632448,
      "domNodes": -280,
      "jsHeapTotalBytes": 4513792,
      "scriptDurationMs": 67.732,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2012.535000000014,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.565,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 578.9839999999999,
      "heapDeltaBytes": 7850420,
      "heapUsedBytes": 67401232,
      "domNodes": -282,
      "jsHeapTotalBytes": 3989504,
      "scriptDurationMs": 69.652,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2101.7889999999966,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 10.854000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 955.23,
      "heapDeltaBytes": 25297936,
      "heapUsedBytes": 85752708,
      "domNodes": -283,
      "jsHeapTotalBytes": 5525504,
      "scriptDurationMs": 293.771,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2096.9570000000317,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 9.794,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 997.8610000000001,
      "heapDeltaBytes": 7147344,
      "heapUsedBytes": 67906220,
      "domNodes": -284,
      "jsHeapTotalBytes": 5001216,
      "scriptDurationMs": 309.953,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3109.2740000000276,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.485999999999997,
      "layouts": 60,
      "layoutDurationMs": 6.297000000000001,
      "taskDurationMs": 1144.455,
      "heapDeltaBytes": -8810412,
      "heapUsedBytes": 54523652,
      "domNodes": 20,
      "jsHeapTotalBytes": 7135232,
      "scriptDurationMs": 365.584,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3075.3200000000334,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.315,
      "layouts": 60,
      "layoutDurationMs": 5.974,
      "taskDurationMs": 1162.4180000000001,
      "heapDeltaBytes": 23043932,
      "heapUsedBytes": 85399184,
      "domNodes": 16,
      "jsHeapTotalBytes": 8650752,
      "scriptDurationMs": 382.859,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2037.5660000000266,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.771999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 558.0110000000001,
      "heapDeltaBytes": 8549584,
      "heapUsedBytes": 70056440,
      "domNodes": -282,
      "jsHeapTotalBytes": 5300224,
      "scriptDurationMs": 69.49900000000001,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2024.597999999969,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.823000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 578.176,
      "heapDeltaBytes": 6695728,
      "heapUsedBytes": 68274132,
      "domNodes": -282,
      "jsHeapTotalBytes": 5038080,
      "scriptDurationMs": 72.00999999999999,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 518.224000000032,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 7.673000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 315.71299999999997,
      "heapDeltaBytes": -12528720,
      "heapUsedBytes": 56037136,
      "domNodes": 22,
      "jsHeapTotalBytes": 22659072,
      "scriptDurationMs": 88.82900000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 535.8660000000555,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 7.972000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 328.185,
      "heapDeltaBytes": -11033884,
      "heapUsedBytes": 57657556,
      "domNodes": 20,
      "jsHeapTotalBytes": 21086208,
      "scriptDurationMs": 94.941,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2016.3050000000453,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.546,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 384.358,
      "heapDeltaBytes": 5237848,
      "heapUsedBytes": 73876840,
      "domNodes": 20,
      "jsHeapTotalBytes": 20299776,
      "scriptDurationMs": 11.929,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1994.8630000000094,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.938000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 400.19100000000003,
      "heapDeltaBytes": 5346116,
      "heapUsedBytes": 74010384,
      "domNodes": 20,
      "jsHeapTotalBytes": 20299776,
      "scriptDurationMs": 12.114999999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1677.014999999983,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 28.595000000000002,
      "layouts": 16,
      "layoutDurationMs": 3.4250000000000003,
      "taskDurationMs": 602.0219999999999,
      "heapDeltaBytes": -3880224,
      "heapUsedBytes": 64678060,
      "domNodes": 62,
      "jsHeapTotalBytes": 20299776,
      "scriptDurationMs": 62.54900000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1678.9980000000355,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 26.889999999999997,
      "layouts": 16,
      "layoutDurationMs": 3.2809999999999997,
      "taskDurationMs": 608.391,
      "heapDeltaBytes": -4069004,
      "heapUsedBytes": 64799684,
      "domNodes": 61,
      "jsHeapTotalBytes": 20299776,
      "scriptDurationMs": 62.821000000000005,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 915.7989999999927,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 23.891000000000002,
      "layouts": 16,
      "layoutDurationMs": 8.609,
      "taskDurationMs": 748.7429999999999,
      "heapDeltaBytes": 30514500,
      "heapUsedBytes": 97709552,
      "domNodes": 13673,
      "jsHeapTotalBytes": 14417920,
      "scriptDurationMs": 21.229,
      "eventListeners": 2373,
      "totalBlockingTimeMs": 112,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8093.4839999999895,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 28.399,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3318.439,
      "heapDeltaBytes": 11873576,
      "heapUsedBytes": 71617432,
      "domNodes": -282,
      "jsHeapTotalBytes": 6049792,
      "scriptDurationMs": 938.63,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8106.816999999978,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 26.169,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3431.526,
      "heapDeltaBytes": 27841736,
      "heapUsedBytes": 88870444,
      "domNodes": -280,
      "jsHeapTotalBytes": 7884800,
      "scriptDurationMs": 958.017,
      "eventListeners": -163,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12310.308999999961,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12293.452000000001,
      "heapDeltaBytes": -60871420,
      "heapUsedBytes": 166711752,
      "domNodes": -8316,
      "jsHeapTotalBytes": -12525568,
      "scriptDurationMs": 455.83399999999995,
      "eventListeners": -16393,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12126.035000000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12109.419,
      "heapDeltaBytes": -47013500,
      "heapUsedBytes": 166383080,
      "domNodes": -8312,
      "jsHeapTotalBytes": -13574144,
      "scriptDurationMs": 458.47100000000006,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 15411.833999999999,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 13.199000000000016,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15391.519999999999,
      "heapDeltaBytes": -66274920,
      "heapUsedBytes": 157394216,
      "domNodes": -8312,
      "jsHeapTotalBytes": -11739136,
      "scriptDurationMs": 725.013,
      "eventListeners": -16388,
      "totalBlockingTimeMs": 65,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 15182.951000000003,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 13.048000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15143.006,
      "heapDeltaBytes": -35406984,
      "heapUsedBytes": 177841328,
      "domNodes": -8312,
      "jsHeapTotalBytes": -10235904,
      "scriptDurationMs": 748.1549999999999,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 84.39400000003161,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 10.616,
      "layouts": 5,
      "layoutDurationMs": 1.713,
      "taskDurationMs": 61.080999999999996,
      "heapDeltaBytes": 3076528,
      "heapUsedBytes": 70739664,
      "domNodes": 132,
      "jsHeapTotalBytes": 2883584,
      "scriptDurationMs": 4.0280000000000005,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 447.77800000008483,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 15.061,
      "layouts": 3,
      "layoutDurationMs": 0.654,
      "taskDurationMs": 99.62199999999999,
      "heapDeltaBytes": -16130780,
      "heapUsedBytes": 51737412,
      "domNodes": 123,
      "jsHeapTotalBytes": 7192576,
      "scriptDurationMs": 7.195999999999999,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.799999999999727
    }
  ]
}

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.49   #15103   +/-   ##
=============================================
  Coverage              ?   71.91%           
=============================================
  Files                 ?     1767           
  Lines                 ?    92444           
  Branches              ?    26802           
=============================================
  Hits                  ?    66482           
  Misses                ?    25843           
  Partials              ?      119           
Flag Coverage Δ
unit 71.91% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/components/ui/tooltip/AccessibleTooltip.vue 100.00% <100.00%> (ø)
...tform/missingModel/components/MissingModelCard.vue 97.33% <100.00%> (ø)
...atform/missingModel/components/MissingModelRow.vue 92.94% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot merged commit b2aa747 into cloud/1.49 Aug 12, 2026
78 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the jaeone94/backport-14984-to-cloud-1.49 branch August 12, 2026 05:36
balpreetgrowthnatives pushed a commit to balpreetgrowthnatives/ComfyUI_frontend that referenced this pull request Aug 14, 2026
## The workflow does not catch the branches it exists for

`pr-label-backport.yaml`'s header states its purpose plainly —
*"Guarantees that
every backport PR carries the `backport` label, **whoever opened it**"*
— and
explains that manual backports are the case that matters, because
`pr-backport.yaml` only labels the PRs it creates itself, and hands off
to a
human when the cherry-pick conflicts.

But `isBackportBranchForBase` matched only the exact branch the workflow
generates:

```ts
const BACKPORT_BRANCH_PATTERN = /^backport-\d+-to-(.+)$/
```

A human finishing a conflicted cherry-pick does not produce that. They
produce
`<user>/backport-<pr>-to-<target>` — what `gh` and most local branch
conventions give you.

## This week's worked example

**Comfy-Org#15102** and **Comfy-Org#15103** (`jaeone94/backport-14984-to-core-1.49` and
`…-cloud-1.49`) were opened by hand after `pr-backport.yaml` failed on
Comfy-Org#14984's cherry-pick, and carry the `backport` label **only because
someone
applied it manually**.

That matters because an unlabelled backport is invisible to
`backport-auto-merge.yaml` and `pr-assign-release-sheriff.yaml` — both
sweep
`gh pr list --label backport` — so it sits open until somebody notices.
Which
is exactly what Comfy-Org#14018–Comfy-Org#14021 are cited for in the workflow's own
header.

Surveying every backport-titled PR in the repo: the bot's
`backport-<n>-to-<target>` branches are all labelled, and the only
user-prefixed pair is the one that needed a human.

## Only the prefix widens

```diff
-const BACKPORT_BRANCH_PATTERN = /^backport-\d+-to-(.+)$/
+const BACKPORT_BRANCH_PATTERN = /^(?:.*\/)?backport-\d+-to-(.+)$/
```

The `\d+-to-` core and the existing base check still decide what counts
as a
backport, so this does **not** loosen the definition:

| branch | base | before | after |
| --- | --- | --- | --- |
| `backport-14979-to-core-1.49` | `core/1.49` | ✅ | ✅ |
| `jaeone94/backport-14984-to-core-1.49` | `core/1.49` | ❌ | ✅ |
| `jaeone94/backport-14984-to-core-1.49` | `cloud/1.49` | ❌ | ❌ *(target
≠ base)* |
| `glary/backport-resilient-partial-failure` | `core/1.49` | ❌ | ❌ |
| `deepme987/infra/backport-assign-author` | `main` | ❌ | ❌ |

The last two are real branches in this repo — *about* backporting rather
than
backports. A prefix must not turn them into one, and it doesn't: they
have no
`<digits>-to-` segment.

## Verification

`backport-label.test.ts` **16/16**, with three new cases covering the
prefixed
form, the prefixed-but-wrong-base rejection, and the two real
non-backport
branches above.

Mutation-checked rather than asserted green — reverting the regex to
`^backport-`
fails exactly one test (the new prefixed case) and leaves the other 15
passing.

## Disclosure

I hit this myself from the other direction. My manual backports
Comfy-Org#15095/Comfy-Org#15096
used `backport/<pr>-to-<target>` — a **slash** where the convention uses
a
hyphen. That one is genuinely off-convention rather than a gap in the
rule, so
this PR deliberately does **not** widen the pattern to bless it; I fixed
those
branches' labels by hand instead.

Co-authored-by: t <t@t.t>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants