Repository navigation
revert: back out five i18n PRs merged without review - #14791
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 17 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (16)
Comment |
🎭 Playwright: ✅ 1786 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 8.26 MB gzip 🟢 -805 BDetailsSummary
Category Glance App Entry Points — 3.64 kB (baseline 3.64 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.35 MB (baseline 1.35 MB) • 🔴 +56 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 1 unchanged Views & Navigation — 114 kB (baseline 114 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 552 kB (baseline 552 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 16 unchanged User & Accounts — 27 kB (baseline 27 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 4 unchanged Editors & Dialogs — 124 kB (baseline 124 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 6 added / 6 removed / 1 unchanged UI Components — 72.1 kB (baseline 72.1 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 9 unchanged Data & Services — 3.48 MB (baseline 3.48 MB) • 🟢 -836 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 387 kB (baseline 387 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 17 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 12.8 MB (baseline 12.8 MB) • 🟢 -1.29 kBBundles that do not match a named category
Status: 76 added / 76 removed / 208 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-05T11:51:54.399Z",
"gitSha": "9bc811c31921317ba4edc539668b00d42e2b9def",
"branch": "revert/unreviewed-i18n-merges",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.0899999999915,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.682999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.92699999999996,
"heapDeltaBytes": 5616328,
"heapUsedBytes": 69598368,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 19.998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2001.2800000000652,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.344000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.28999999999996,
"heapDeltaBytes": 5289284,
"heapUsedBytes": 69401744,
"domNodes": 18,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 17.172000000000004,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2084.2930000000024,
"styleRecalcs": 80,
"styleRecalcDurationMs": 49.42100000000001,
"layouts": 12,
"layoutDurationMs": 4.001,
"taskDurationMs": 1102.5770000000002,
"heapDeltaBytes": -10807768,
"heapUsedBytes": 53187688,
"domNodes": -279,
"jsHeapTotalBytes": 24621056,
"scriptDurationMs": 138.003,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1875.193999999965,
"styleRecalcs": 75,
"styleRecalcDurationMs": 40.663,
"layouts": 12,
"layoutDurationMs": 3.6349999999999993,
"taskDurationMs": 881.2800000000001,
"heapDeltaBytes": -641504,
"heapUsedBytes": 63478372,
"domNodes": 58,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 128.841,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1783.7339999999813,
"styleRecalcs": 31,
"styleRecalcDurationMs": 20.089000000000002,
"layouts": 6,
"layoutDurationMs": 0.8350000000000002,
"taskDurationMs": 475.526,
"heapDeltaBytes": 8699864,
"heapUsedBytes": 72653300,
"domNodes": 76,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 29.909000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1765.1260000000093,
"styleRecalcs": 31,
"styleRecalcDurationMs": 21.081000000000003,
"layouts": 6,
"layoutDurationMs": 0.7290000000000003,
"taskDurationMs": 460.41400000000004,
"heapDeltaBytes": 8209752,
"heapUsedBytes": 72163600,
"domNodes": 75,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 27.826,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 626.1389999999665,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.644999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.14,
"heapDeltaBytes": -10927512,
"heapUsedBytes": 53089164,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 64.714,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 605.9030000000121,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.974999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.353,
"heapDeltaBytes": -10972504,
"heapUsedBytes": 53112560,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 62.26400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2035.699999999963,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.4590000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 741.6089999999999,
"heapDeltaBytes": 3277816,
"heapUsedBytes": 65415580,
"domNodes": -281,
"jsHeapTotalBytes": 3514368,
"scriptDurationMs": 122.83499999999998,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2010.94599999999,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.668,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 751.579,
"heapDeltaBytes": 6301572,
"heapUsedBytes": 65755680,
"domNodes": -281,
"jsHeapTotalBytes": 2203648,
"scriptDurationMs": 125.67899999999999,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2338.6749999999665,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.100999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1448.601,
"heapDeltaBytes": 6244328,
"heapUsedBytes": 66832788,
"domNodes": -285,
"jsHeapTotalBytes": 3444736,
"scriptDurationMs": 514.2860000000001,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2270.2010000000428,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.221000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1362.262,
"heapDeltaBytes": 5143824,
"heapUsedBytes": 65673252,
"domNodes": -283,
"jsHeapTotalBytes": 3969024,
"scriptDurationMs": 458.28599999999994,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3310.2360000000317,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.751,
"layouts": 60,
"layoutDurationMs": 8.064,
"taskDurationMs": 1623.895,
"heapDeltaBytes": 2417496,
"heapUsedBytes": 64422372,
"domNodes": -289,
"jsHeapTotalBytes": 6660096,
"scriptDurationMs": 567.329,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3282.0460000000367,
"styleRecalcs": 65,
"styleRecalcDurationMs": 16.104,
"layouts": 60,
"layoutDurationMs": 7.724000000000001,
"taskDurationMs": 1601.184,
"heapDeltaBytes": 1270768,
"heapUsedBytes": 63415016,
"domNodes": -287,
"jsHeapTotalBytes": 6660096,
"scriptDurationMs": 559.945,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2049.3549999999914,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.786999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 964.076,
"heapDeltaBytes": 6342768,
"heapUsedBytes": 66825968,
"domNodes": -284,
"jsHeapTotalBytes": 3514368,
"scriptDurationMs": 164.654,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2042.9400000000442,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.908999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 732.995,
"heapDeltaBytes": 6992076,
"heapUsedBytes": 67361536,
"domNodes": -283,
"jsHeapTotalBytes": 3776512,
"scriptDurationMs": 119.81,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 653.2009999999673,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.024999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.95300000000003,
"heapDeltaBytes": -10472860,
"heapUsedBytes": 53796988,
"domNodes": 18,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 126.668,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 662.6690000000508,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.849999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.14,
"heapDeltaBytes": -10389428,
"heapUsedBytes": 53775880,
"domNodes": 20,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 128.014,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2001.9629999999893,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.981000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.119,
"heapDeltaBytes": 5138720,
"heapUsedBytes": 69207832,
"domNodes": 20,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 15.802999999999997,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2006.5450000000737,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.355999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 522.846,
"heapDeltaBytes": 5092952,
"heapUsedBytes": 69241672,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 17.874000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1716.113000000007,
"styleRecalcs": 75,
"styleRecalcDurationMs": 38.538,
"layouts": 16,
"layoutDurationMs": 4.8149999999999995,
"taskDurationMs": 818.247,
"heapDeltaBytes": -4111800,
"heapUsedBytes": 59849280,
"domNodes": 61,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 102.55199999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1762.61199999999,
"styleRecalcs": 79,
"styleRecalcDurationMs": 40.565,
"layouts": 16,
"layoutDurationMs": 4.436,
"taskDurationMs": 868.185,
"heapDeltaBytes": -18642424,
"heapUsedBytes": 45665224,
"domNodes": 18,
"jsHeapTotalBytes": 22786048,
"scriptDurationMs": 98.30499999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1405.5109999999331,
"styleRecalcs": 18,
"styleRecalcDurationMs": 32.150999999999996,
"layouts": 14,
"layoutDurationMs": 13.333000000000002,
"taskDurationMs": 993.225,
"heapDeltaBytes": 30686140,
"heapUsedBytes": 98906276,
"domNodes": 13673,
"jsHeapTotalBytes": 16252928,
"scriptDurationMs": 38.63300000000002,
"eventListeners": 2375,
"totalBlockingTimeMs": 150,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8575.411000000031,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.757,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4972.306,
"heapDeltaBytes": 13564656,
"heapUsedBytes": 72934992,
"domNodes": -283,
"jsHeapTotalBytes": 4231168,
"scriptDurationMs": 1523.126,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8594.862000000034,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.591,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4756.608,
"heapDeltaBytes": 14236740,
"heapUsedBytes": 74206664,
"domNodes": -281,
"jsHeapTotalBytes": 5541888,
"scriptDurationMs": 1475.633,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17764.560999999958,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17737.489,
"heapDeltaBytes": -46322672,
"heapUsedBytes": 171032008,
"domNodes": -8312,
"jsHeapTotalBytes": -7278592,
"scriptDurationMs": 627.0279999999999,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17518.083000000046,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17498.432,
"heapDeltaBytes": -59944648,
"heapUsedBytes": 167125728,
"domNodes": -8312,
"jsHeapTotalBytes": -8069120,
"scriptDurationMs": 586.414,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21764.039999999964,
"styleRecalcs": 153,
"styleRecalcDurationMs": 21.16000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21737.718,
"heapDeltaBytes": -49540180,
"heapUsedBytes": 156042328,
"domNodes": -8312,
"jsHeapTotalBytes": -9641984,
"scriptDurationMs": 949.3269999999999,
"eventListeners": -16381,
"totalBlockingTimeMs": 393,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21266.05100000006,
"styleRecalcs": 146,
"styleRecalcDurationMs": 18.133999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21192.401,
"heapDeltaBytes": -60377224,
"heapUsedBytes": 153859060,
"domNodes": -8312,
"jsHeapTotalBytes": -9900032,
"scriptDurationMs": 936.054,
"eventListeners": -16387,
"totalBlockingTimeMs": 349,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 456.91099999999096,
"styleRecalcs": 15,
"styleRecalcDurationMs": 21.639000000000006,
"layouts": 2,
"layoutDurationMs": 0.399,
"taskDurationMs": 120.36099999999999,
"heapDeltaBytes": 5310412,
"heapUsedBytes": 68681324,
"domNodes": 134,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.411,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 465.46999999998206,
"styleRecalcs": 12,
"styleRecalcDurationMs": 18.627000000000002,
"layouts": 3,
"layoutDurationMs": 0.7310000000000001,
"taskDurationMs": 110.921,
"heapDeltaBytes": 5077044,
"heapUsedBytes": 68526480,
"domNodes": 121,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.262999999999998,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #14791 +/- ##
==========================================
- Coverage 78.69% 78.63% -0.06%
==========================================
Files 1797 1797
Lines 106766 106723 -43
Branches 29719 29705 -14
==========================================
- Hits 84020 83926 -94
- Misses 22286 22339 +53
+ Partials 460 458 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…fy-Org#14798) `ComfyApp.getNodeDefs()` baked resolved text into the def at fetch time, so `nodeDefStore` held translated values and the raw backend strings were discarded. Locale switching therefore needed a full refetch. Converts `ComfyNodeDefImpl.display_name` and `description` to getters delegating to `resolveNodeDefText`, holding the raw backend value in instance fields. `translateNodeDef` stops resolving those two (still does `category`). Property-access shape is preserved, so the ~96 files reading `display_name` are untouched. ## Review focus Three hazards were checked empirically rather than assumed, and one is load-bearing: - **`#private` fields throw through a Proxy.** Vue wraps store instances in one, so the raw values use TypeScript `private` (plain own properties). Using `#private` would have made every store read throw. - **`Object.assign(this, obj)` throws on setter-less accessors** — defused by destructuring `display_name`/`description` out. - **Spread, `JSON.stringify`, `structuredClone` and `Object.keys` all drop prototype getters.** Every `ComfyNodeDefImpl` consumer was swept; exactly one structurally copies (`nodeBookmarkStore.buildBookmarkTree`, via es-toolkit `clone`, which preserves the prototype). A regression test covers it, since swapping that for a spread would silently blank every bookmark label. Perf measured at +0.28µs per read, ~1.5ms across 5000 defs. Known remainders are tracked in Comfy-Org#14777: `node.title` is still baked at registration, and `nodeDefsByDisplayName` still snapshots its keys. Fixes Comfy-Org#14629 --- Previously merged without review and backed out by Comfy-Org#14791. Re-submitting for normal review. Rebased onto post-revert `main`; content unchanged. --------- Co-authored-by: Connor Byrne <c.byrne@comfy.org>
#14797) #14541 made English `display_name` and `description` come from the backend. Widget labels, output names and tooltips were still read from the stale bundled snapshot, so a renamed node showed a new title beside old labels. Adds `resolveNodeDefInputText` / `resolveNodeDefOutputText` and extracts `resolveNodeDefPath`, so the per-locale precedence table now lives in exactly one place and `resolveNodeDefText` delegates to it. Applied in `litegraphService` (widget labels, socket and output `localized_name`), `NodeTooltip.vue`, and `useNodeTooltips.ts`. Also fixes `getNodeDescription`, which wrapped an already-resolved value in `st()` and let the stale bundle win. ## Review focus **Tooltips must never be escaped or compiled.** They are read through `stRaw`/`tm()`, which returns the message uncompiled, so a literal `{'@'}` would render to the user. One function decides it: ```ts return field === 'tooltip' ? stRaw : st ``` Backend values short-circuit before any reader runs, so a tooltip reaches the compiler by no path. No runtime escaping added; `escapeI18nMessage` stays build-time-only. Coverage was verified by mutation rather than inspection, which matters here: `st()` swallows a vue-i18n `SyntaxError` and returns the raw stored message, so a fixture containing a throwing character passes whether or not the code is correct. The raw/compiled fixture (`50{'%'} {'@'}`) compiles cleanly so that escape hatch cannot mask a defect. Forcing the reader to always-`st` or always-`stRaw` each fails the suite. ## Migration guidance (`node.widgets`) `widget.label` now resolves through the node-def text pipeline (custom-node translations, then the live backend value, then the bundled snapshot) instead of taking the node definition's `display_name` verbatim. The resolved string therefore varies by active locale and by what `/object_info` sends. Extensions must use `widget.name` for widget identity. `widget.label` is display text and was never stable across locales. No type or API shape changed. Fixes #14631 --- Previously merged without review and backed out by #14791. Re-submitting for normal review. Rebased onto post-revert `main`; content unchanged. --------- Co-authored-by: Connor Byrne <c.byrne@comfy.org> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: DrJKL <DrJKL0424@gmail.com>
#14797) #14541 made English `display_name` and `description` come from the backend. Widget labels, output names and tooltips were still read from the stale bundled snapshot, so a renamed node showed a new title beside old labels. Adds `resolveNodeDefInputText` / `resolveNodeDefOutputText` and extracts `resolveNodeDefPath`, so the per-locale precedence table now lives in exactly one place and `resolveNodeDefText` delegates to it. Applied in `litegraphService` (widget labels, socket and output `localized_name`), `NodeTooltip.vue`, and `useNodeTooltips.ts`. Also fixes `getNodeDescription`, which wrapped an already-resolved value in `st()` and let the stale bundle win. ## Review focus **Tooltips must never be escaped or compiled.** They are read through `stRaw`/`tm()`, which returns the message uncompiled, so a literal `{'@'}` would render to the user. One function decides it: ```ts return field === 'tooltip' ? stRaw : st ``` Backend values short-circuit before any reader runs, so a tooltip reaches the compiler by no path. No runtime escaping added; `escapeI18nMessage` stays build-time-only. Coverage was verified by mutation rather than inspection, which matters here: `st()` swallows a vue-i18n `SyntaxError` and returns the raw stored message, so a fixture containing a throwing character passes whether or not the code is correct. The raw/compiled fixture (`50{'%'} {'@'}`) compiles cleanly so that escape hatch cannot mask a defect. Forcing the reader to always-`st` or always-`stRaw` each fails the suite. ## Migration guidance (`node.widgets`) `widget.label` now resolves through the node-def text pipeline (custom-node translations, then the live backend value, then the bundled snapshot) instead of taking the node definition's `display_name` verbatim. The resolved string therefore varies by active locale and by what `/object_info` sends. Extensions must use `widget.name` for widget identity. `widget.label` is display text and was never stable across locales. No type or API shape changed. Fixes #14631 --- Previously merged without review and backed out by #14791. Re-submitting for normal review. Rebased onto post-revert `main`; content unchanged. --------- Co-authored-by: Connor Byrne <c.byrne@comfy.org> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: DrJKL <DrJKL0424@gmail.com>
Reverts five PRs that were merged to
mainwithout independent review, which is not our process. Backing them out so they can go through review properly.Reverted, newest first:
Not reverted: #14541. It was authored by @bigcat88 and carried a genuine approval before merge, so it followed process. The five above were authored and merged under the same account, and GitHub blocks self-approval, so none of them could receive one. Three had no approval of any kind at merge time.
mainis not branch-protected here, so nothing blocked the merges. That is the gap that let this happen.State after this revert
All five reverts applied without conflict. The tree returns to the post-14541 state:
resolveNodeDefTextandsetBackendNodeTextremain,translateNodeDefresolvesdisplay_name/descriptioninline again, and the slot resolvers, getters, dropped-defwarning and golden stubbing are all removed.
Verified locally:
pnpm typecheckclean,pnpm knipclean, 156 unit tests pass acrossthe four affected suites.
Follow-up
Each reverted change will be re-opened as its own PR from its original branch, which
still exists, for normal review. Nothing is lost.