Repository navigation
fix: name the malformed node definitions dropped from object_info - #14796
christian-byrne wants to merge 2 commits into
Conversation
🎭 Playwright: ✅ 1818 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 8.85 MB gzip 🔴 +28 BDetailsSummary
Category Glance App Entry Points — 3.71 kB (baseline 3.71 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.37 MB (baseline 1.37 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 566 kB (baseline 566 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 16 unchanged User & Accounts — 27.7 kB (baseline 27.7 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 8 unchanged Data & Services — 3.52 MB (baseline 3.52 MB) • 🔴 +249 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 550 kB (baseline 550 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 20 unchanged Vendor & Third-Party — 16.8 MB (baseline 16.8 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 14.2 MB (baseline 14.2 MB) • ⚪ 0 BBundles that do not match a named category
Status: 68 added / 68 removed / 217 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-17T01:32:54.842Z",
"gitSha": "6f60b8ba8709fa11a7f8a3965d52a737cf2d7261",
"branch": "fix/warn-on-dropped-node-defs",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2128.3469999999625,
"styleRecalcs": 7,
"styleRecalcDurationMs": 10.040999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 728.056,
"heapDeltaBytes": 4923336,
"heapUsedBytes": 69249768,
"domNodes": 14,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 13.200999999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2034.108999999944,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.124000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 599.186,
"heapDeltaBytes": 5074360,
"heapUsedBytes": 69715104,
"domNodes": 14,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 12.289000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1955.5589999999938,
"styleRecalcs": 76,
"styleRecalcDurationMs": 45.97999999999999,
"layouts": 12,
"layoutDurationMs": 3.95,
"taskDurationMs": 1044.637,
"heapDeltaBytes": -450840,
"heapUsedBytes": 64018256,
"domNodes": 58,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 130.766,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1937.255999999934,
"styleRecalcs": 77,
"styleRecalcDurationMs": 48.006,
"layouts": 12,
"layoutDurationMs": 3.858,
"taskDurationMs": 1010.5489999999999,
"heapDeltaBytes": -572352,
"heapUsedBytes": 63877288,
"domNodes": 58,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 127.00800000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1751.4419999999973,
"styleRecalcs": 31,
"styleRecalcDurationMs": 19.631,
"layouts": 6,
"layoutDurationMs": 0.7569999999999999,
"taskDurationMs": 477.28999999999996,
"heapDeltaBytes": 8169296,
"heapUsedBytes": 72623532,
"domNodes": 76,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 15.204,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1755.506999999966,
"styleRecalcs": 32,
"styleRecalcDurationMs": 21.276999999999997,
"layouts": 6,
"layoutDurationMs": 0.8529999999999998,
"taskDurationMs": 479.51000000000005,
"heapDeltaBytes": 7990284,
"heapUsedBytes": 72628220,
"domNodes": 78,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 15.552999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 720.7930000000147,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.809999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.616,
"heapDeltaBytes": -10952584,
"heapUsedBytes": 53431956,
"domNodes": 20,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 63.234,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 676.1279999999488,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.583999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.469,
"heapDeltaBytes": -10850580,
"heapUsedBytes": 53717264,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 63.605,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2068.0000000000405,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.787999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 817.0959999999999,
"heapDeltaBytes": 12079800,
"heapUsedBytes": 72286764,
"domNodes": -284,
"jsHeapTotalBytes": 2195456,
"scriptDurationMs": 20.883,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2036.467000000016,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.957,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 775.987,
"heapDeltaBytes": 12682676,
"heapUsedBytes": 73837200,
"domNodes": -284,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 21.773,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2656.06600000001,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.703000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1411.05,
"heapDeltaBytes": 11909024,
"heapUsedBytes": 73318172,
"domNodes": -285,
"jsHeapTotalBytes": 2912256,
"scriptDurationMs": 373.28,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2567.790999999943,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.604999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1399.766,
"heapDeltaBytes": 7110348,
"heapUsedBytes": 69020956,
"domNodes": -286,
"jsHeapTotalBytes": 5009408,
"scriptDurationMs": 364.56300000000005,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3628.586999999982,
"styleRecalcs": 64,
"styleRecalcDurationMs": 16.072999999999997,
"layouts": 60,
"layoutDurationMs": 7.993,
"taskDurationMs": 1610.288,
"heapDeltaBytes": 15116104,
"heapUsedBytes": 78012804,
"domNodes": -289,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 430.33,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3694.3519999999808,
"styleRecalcs": 63,
"styleRecalcDurationMs": 14.893000000000004,
"layouts": 60,
"layoutDurationMs": 8.589999999999998,
"taskDurationMs": 1602.816,
"heapDeltaBytes": 16541900,
"heapUsedBytes": 78925384,
"domNodes": -289,
"jsHeapTotalBytes": 4030464,
"scriptDurationMs": 429.653,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2036.4620000000286,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.739999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 824.296,
"heapDeltaBytes": 8995704,
"heapUsedBytes": 69846052,
"domNodes": -286,
"jsHeapTotalBytes": 2719744,
"scriptDurationMs": 21.266999999999996,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2035.9509999999545,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.576000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 780.4980000000002,
"heapDeltaBytes": 12361360,
"heapUsedBytes": 73097884,
"domNodes": -285,
"jsHeapTotalBytes": 2719744,
"scriptDurationMs": 21.067000000000004,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 656.4649999999688,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.064,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.575,
"heapDeltaBytes": -10567064,
"heapUsedBytes": 54048616,
"domNodes": 18,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 127.90499999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 707.6170000000275,
"styleRecalcs": 45,
"styleRecalcDurationMs": 11.195,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.908,
"heapDeltaBytes": -10360616,
"heapUsedBytes": 54356216,
"domNodes": 16,
"jsHeapTotalBytes": 26476544,
"scriptDurationMs": 124.551,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2007.169000000033,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.004000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 605.5889999999999,
"heapDeltaBytes": 4948584,
"heapUsedBytes": 69366736,
"domNodes": 16,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 12.331000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2017.898999999943,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.465,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 591.173,
"heapDeltaBytes": 5175296,
"heapUsedBytes": 69640556,
"domNodes": 16,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 11.655999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1739.0520000000151,
"styleRecalcs": 77,
"styleRecalcDurationMs": 45.741,
"layouts": 16,
"layoutDurationMs": 5.513,
"taskDurationMs": 928.278,
"heapDeltaBytes": -4269880,
"heapUsedBytes": 60355252,
"domNodes": 64,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 100.642,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1775.480000000016,
"styleRecalcs": 77,
"styleRecalcDurationMs": 46.595000000000006,
"layouts": 16,
"layoutDurationMs": 5.513,
"taskDurationMs": 917.617,
"heapDeltaBytes": -3636648,
"heapUsedBytes": 60993736,
"domNodes": 65,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 100.327,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1450.9749999999713,
"styleRecalcs": 19,
"styleRecalcDurationMs": 33.447,
"layouts": 14,
"layoutDurationMs": 13.509,
"taskDurationMs": 1093.4479999999999,
"heapDeltaBytes": -5904728,
"heapUsedBytes": 76765856,
"domNodes": 13673,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 20.737000000000005,
"eventListeners": 2373,
"totalBlockingTimeMs": 161,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9484.847000000002,
"styleRecalcs": 249,
"styleRecalcDurationMs": 42.38700000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4963.14,
"heapDeltaBytes": 1074380,
"heapUsedBytes": 61218840,
"domNodes": -280,
"jsHeapTotalBytes": 3174400,
"scriptDurationMs": 1180.9689999999998,
"eventListeners": -161,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9999.051000000009,
"styleRecalcs": 249,
"styleRecalcDurationMs": 41.672,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4964.625,
"heapDeltaBytes": 14320828,
"heapUsedBytes": 74411288,
"domNodes": -282,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 1167.9330000000002,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18906.90599999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18102.338,
"heapDeltaBytes": -44680884,
"heapUsedBytes": 165711640,
"domNodes": -8316,
"jsHeapTotalBytes": -13799424,
"scriptDurationMs": 141.983,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 18904.39099999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18025.748,
"heapDeltaBytes": -40358960,
"heapUsedBytes": 170353744,
"domNodes": -8312,
"jsHeapTotalBytes": -12259328,
"scriptDurationMs": 140.94600000000003,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 23331.222999999965,
"styleRecalcs": 181,
"styleRecalcDurationMs": 26.75799999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22606.817,
"heapDeltaBytes": -22060928,
"heapUsedBytes": 183778988,
"domNodes": -8312,
"jsHeapTotalBytes": -14688256,
"scriptDurationMs": 498.475,
"eventListeners": -16381,
"totalBlockingTimeMs": 211,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "vue-large-graph-pan",
"durationMs": 23190.27300000005,
"styleRecalcs": 181,
"styleRecalcDurationMs": 27.293999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22549.231,
"heapDeltaBytes": -28256276,
"heapUsedBytes": 182730540,
"domNodes": -8312,
"jsHeapTotalBytes": -16261120,
"scriptDurationMs": 502.718,
"eventListeners": -16381,
"totalBlockingTimeMs": 205,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "workflow-execution",
"durationMs": 464.0860000000657,
"styleRecalcs": 11,
"styleRecalcDurationMs": 19.838999999999995,
"layouts": 3,
"layoutDurationMs": 0.6390000000000002,
"taskDurationMs": 121.302,
"heapDeltaBytes": 4944660,
"heapUsedBytes": 68661076,
"domNodes": 124,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 8.466999999999999,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 474.7389999999996,
"styleRecalcs": 10,
"styleRecalcDurationMs": 23.738,
"layouts": 3,
"layoutDurationMs": 0.707,
"taskDurationMs": 121.92,
"heapDeltaBytes": 4925552,
"heapUsedBytes": 68705292,
"domNodes": 119,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8.12,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 27 minutes Limit details: You’ve used all 4 included reviews currently available under your plan. You completed 64 included PR reviews in the past 7 days; at that activity level, included reviews refill at 4 reviews per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough
ChangesNode definition validation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14796 +/- ##
==========================================
+ Coverage 79.02% 81.39% +2.36%
==========================================
Files 2209 1882 -327
Lines 122800 117861 -4939
Branches 36772 35142 -1630
==========================================
- Hits 97045 95930 -1115
+ Misses 25186 21462 -3724
+ Partials 569 469 -100
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 337 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…this default for non-cloud (Comfy-Org#13464) ## Summary Backs the model library sidebar with the assets API: one walk of the `models` tag bucketed by `model_type:` tags, `loader_path` as the widget value, and refresh triggering a backend rescan with live updates. This restores the models sidebar for non-cloud when assets mode is enabled (and makes enabling it a hidden setting on cloud). The intent is to deliver an almost unchanged UX when assets mode is enabled. ## Changes - **What**: `Comfy.ModelLibrary.UseAssetBrowser` (hidden) routes the model-library tab to the asset browser (cloud default) or the sidebar tree (core default). Sidebar contents come from a single asset walk with `loader_path` widget values (null = orphan, dropped; bare-tag backends fall back to filename metadata like the asset browser). Refresh seeds a rescan and the sidebar live-updates on `assets.seed.fast_complete`; asset mode eager-loads on open and drops the load-all button; folders are display-filtered by their registered `extensions` (empty allowlist = match-all, which takes an FE default list); search results stay live across reloads; `viewMetadata`/preview reads gated `!isCloud`. - Also: `rekaPrimeVueBridge` now treats PrimeVue toasts as inside non-modal Reka dialogs, so focus landing on a toast close button mid-action (e.g. a confirm disabling itself) no longer dismisses the dialog underneath; two reload races closed (a scan-complete reload during an in-flight eager load no longer strands folders unloaded, and same-folder concurrent refreshes carry a per-folder generation so a stale response cannot overwrite a fresher commit). ## Review Focus - Bucket cache lifecycle in `assetService` (request-id guard vs in-flight walks; invalidation on refresh). - `supports_model_type_tags` doubles as the loader_path-contract capability proxy. - [x] Merge precondition: Comfy-Org/ComfyUI#14511 (absorbed Comfy-Org#14796) - [x] Soft precondition: Comfy-Org/ComfyUI#14797: provides the registered allowlists. Without it every folder is post-filtered by the default list from 5 (old-sidebar parity; folders with exotic allowlists like .gguf stay hidden, as they always were). With it, registered allowlists apply verbatim so those folders surface their actual models, and only match-all folders keep the default list (e.g. fonts were hidden before and stay hidden). Residual risk: the FE copy of the default list can go stale against custom nodes that extend supported_pt_extensions at runtime. - Related, not blocking: cloud `loader_path` emission (must precede cloud advertising `supports_model_type_tags`) ### Noted UX/behaviour changes Comparing an identical `models/` folder structure the following changes between non-assets and assets backed sidebar. 1. Models are eager-loaded on sidebar open rather than requiring "Load all folders" (video 1) 2. "Refresh" button triggers an asset scan. The FE listens for the scan's fast-phase completion (`assets.seed.fast_complete`, emitted for the refresh button, `r` key, or any other scan trigger) and re-loads the sidebar with whatever the scan discovered. Filtering supported. 3. Ordering becomes defined - folders then files, each sorted alphabetically (screenshot 1). Non-assets behaviour was arbitrary (disk scan order). 4. Clearly invalid files are filtered (screenshot 1) - byproduct of the assets system: e.g. 0-byte files do not create assets, so no longer display 5. The non-assets-backed sidebar uses a fixed filter of _allowed extensions_ (`'.ckpt', '.pt', '.pt2', '.bin', '.pth', '.safetensors', '.pkl', '.sft'`). All files in a registered model folder with these extension are displayed. The new assets-backed sidebar relies on the assets system (with some presentation logic on top to prevent UX regression - see 6) to determine what assets belong to a folder. Specifically: if a custom node registers a model folder `my-custom-models` with extensions `.xyz` the original sidebar would not show `.xyz` files, and would show `.pt` files under `my-custom-models`'s source folder e.g. `models/my-custom-models/foo.pt`. This is incorrect, since loaders loading models via `my-custom-models` key would only allow loading `.xyz`. The assets-backed sidebar resolves this. _Screenshot 2_ 6. Some folder types are registered with _no extension allowlist_ (match-all: e.g. `LLM`) and the assets system deliberately tracks every file in them - including READMEs, configs, and entire git repositories that some custom nodes install into their model folder. Displaying that verbatim would clutter the sidebar, so the FE post-filters match-all folders (and all folders on older backends that don't report allowlists) with a frontend copy of the fixed allowlist from 5. This reproduces what the old sidebar displayed for these folders: nothing previously hidden starts showing (e.g. font files were not visible before and stay not visible) and nothing previously visible disappears. Known trade-off: the frontend copy can go stale if a custom node extends `supported_pt_extensions` at runtime - such files appeared in the old sidebar but won't here until the list is updated. Accepted, since this surface is expected to be short-lived. 7. Known limitation on multi-root categories (`extra_model_paths.yaml`): asset records carry no root identity, so every model reports path index 0. Preview reads target root 0 (wrong file or 404 for secondary-root files) and same-relative-path files in different roots collapse onto one sidebar row; metadata is only affected when relative paths collide (`/view_metadata` searches roots in order without an index). Loader widget values are unaffected (the backend resolves category-relative paths across roots at execution). Accepted for this surface; lifting it needs the backend to carry root identity on assets (backend ticket to follow). An alternate approach to 5+6 would be to more closely match the old assets behaviour: prevent custom-node-registered extension sets from rendering at all. We _could_ only show models that are _both_ matching the registered folders **and** matching the fixed allowlist - this was deemed similar complexity for no benefit. ## Screenshots **Screenshot 1: non-assets (unchanged by this PR) | assets mode (what this PR adds)** <img width="982" height="1033" alt="image" src="https://github.com/user-attachments/assets/8e8ec136-a348-4f7a-8f16-763cb7d38783" /> **Screenshot 2** <img width="889" height="1227" alt="image" src="https://github.com/user-attachments/assets/53546b3e-0533-47b9-958e-996b17a942a6" /> **Video 1:** https://github.com/user-attachments/assets/e45d0891-a42e-4d45-afbc-132b5733171f
Risk analysis: zero user-facing side effectsVerdict: safe to merge. This is a pure additive logging change — the filter ( EvidenceWhat changes: Dynamically-created / extension nodes — not affected. The Hot-reload path ( Other locales — Log spam — guarded by The two new tests correctly cover both branches (warn fires with named keys, stays silent when all entries are valid). No concerns. |
christian-byrne
left a comment
There was a problem hiding this comment.
This is not necessary. We don't want the overhead of structurally type checking every node at startup.
`getNodeDefs` discards entries that are not objects with a string `name`, so one malformed def cannot abort registration for every node. It did so silently, which makes a node vanishing from the UI undiagnosable. Warn once per fetch, naming the discarded keys. This keeps the permissive posture the project chose in #1190 and #4038 while making the data loss visible, which is the cheapest way to learn whether real `/object_info` payloads ever hit this path. Verified by mutation: removing the warning fails the suite.
Match each discarded name independently and pin that the warning fires once and never names a well-formed entry.
08db3a5 to
0975a15
Compare
|
Rebased onto current Context: this was merged without review on 2026-08-05 and backed out by #14791, so it needs a real approval this time. Small diff — it just names the malformed entries that |
|
Closing — not worth the surface it costs.
typeof value === 'object' && value !== null && typeof value.name === 'string'It exists as a crash guard, added by #14541 so that This PR only adds a So it logs an almost-always-empty set, and in exchange we carry nine lines in a hot path plus a test to keep green, and spend a reviewer's time. That is the wrong trade, and it is the same instinct that got startup node validation removed (#1190, #4038): adding machinery that reports on ecosystem input rather than just tolerating it. If silent node disappearance ever becomes a real support burden, the fix is a diagnostic that reports what the backend rejected, not a frontend log of a guard that never trips. |
ComfyApp.getNodeDefs()discards/object_infoentries that are not objects with a stringname, so a single malformed def cannot abort node registration for every node. It did so silently, which makes a node vanishing from the UI undiagnosable. Warn once per fetch, naming the discarded keys.This is the decision half of #14644: keep the permissive posture (#1190 disabled node-def validation by default, #4038 removed it), because tightening the contract risks silently dropping custom nodes users have installed. What was wrong was the silence, not the permissiveness. It also generates the evidence to revisit #14644 with data rather than speculation.
Related: #14644
Previously merged without review and backed out by #14791. Re-submitting for normal review. Rebased onto post-revert
main; content unchanged.