Repository navigation
fix: resolve widget labels, output names and tooltips from the backend - #14797
Conversation
Extends the `resolveNodeDefText` precedence introduced in #14541 to the remaining node text still read from the bundled `en/nodeDefs.json` snapshot: widget labels, input/output socket labels, output names, node descriptions and tooltips. `resolveNodeDefInputText` / `resolveNodeDefOutputText` own the `nodeDefs.*.inputs|outputs.*` key construction and apply the same per-locale order: custom-node `/api/i18n`, then the live `/object_info` value for `en` (bundled snapshot for other locales), then the caller's fallback. The raw/compiled split the serializer encodes is preserved: `name` is escaped at build time and read back through `st()`, `tooltip` is stored verbatim and read through `stRaw()`, so an escaped `{'@'}` can never reach a tooltip. No runtime escaping and no backend data in the vue-i18n message tree. `useNodeTooltips` no longer re-resolves the node description against the snapshot; `getNodeDefs()` has already resolved it.
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1832 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 8.86 MB gzip 🔴 +330 BDetailsSummary
Category Glance App Entry Points — 3.71 kB (baseline 3.71 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.37 MB (baseline 1.37 MB) • 🟢 -47 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 566 kB (baseline 566 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 16 unchanged User & Accounts — 27.7 kB (baseline 27.7 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 8 unchanged Data & Services — 3.52 MB (baseline 3.52 MB) • 🟢 -249 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 550 kB (baseline 550 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 21 added / 21 removed / 17 unchanged Vendor & Third-Party — 16.8 MB (baseline 16.8 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 14.2 MB (baseline 14.2 MB) • 🔴 +787 BBundles that do not match a named category
Status: 76 added / 76 removed / 209 unchanged ⚡ Performance Report
✅ No regressions detected. All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-18T21:25:53.729Z",
"gitSha": "c9477735d7e575081dddb942dc699b6ecce512b8",
"branch": "fix/backend-text-for-widget-labels-and-tooltips",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1997.8530000000205,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.115999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.87700000000007,
"heapDeltaBytes": -1817616,
"heapUsedBytes": 58265296,
"domNodes": -282,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 5.434999999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2020.9939999999733,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.687999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.515,
"heapDeltaBytes": 9893808,
"heapUsedBytes": 70141564,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 5.3210000000000015,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1761.3450000000057,
"styleRecalcs": 71,
"styleRecalcDurationMs": 23.979,
"layouts": 12,
"layoutDurationMs": 2.7030000000000003,
"taskDurationMs": 751.644,
"heapDeltaBytes": 1462352,
"heapUsedBytes": 62261768,
"domNodes": -279,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 79.888,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1700.1719999999523,
"styleRecalcs": 72,
"styleRecalcDurationMs": 20.621000000000002,
"layouts": 12,
"layoutDurationMs": 2.079,
"taskDurationMs": 608.764,
"heapDeltaBytes": -4993700,
"heapUsedBytes": 55796804,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 65.041,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.364999999968,
"styleRecalcs": 33,
"styleRecalcDurationMs": 12.450000000000001,
"layouts": 6,
"layoutDurationMs": 0.544,
"taskDurationMs": 286.265,
"heapDeltaBytes": 2714864,
"heapUsedBytes": 63705184,
"domNodes": 79,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7.757,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1665.928000000008,
"styleRecalcs": 31,
"styleRecalcDurationMs": 11.41,
"layouts": 6,
"layoutDurationMs": 0.44299999999999995,
"taskDurationMs": 274.124,
"heapDeltaBytes": 3061124,
"heapUsedBytes": 63922504,
"domNodes": 78,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 6.737000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 449.33599999995977,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.972,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 267.65500000000003,
"heapDeltaBytes": 9994148,
"heapUsedBytes": 70869448,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 35.23,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 428.4420000000182,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.128000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 256.236,
"heapDeltaBytes": 9617868,
"heapUsedBytes": 70681940,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 34.404,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2022.3600000000488,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.191000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.705,
"heapDeltaBytes": -10178756,
"heapUsedBytes": 63656856,
"domNodes": -281,
"jsHeapTotalBytes": -1839104,
"scriptDurationMs": 9.750000000000002,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2018.1519999999864,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.128,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.40299999999996,
"heapDeltaBytes": -3455796,
"heapUsedBytes": 71065316,
"domNodes": -270,
"jsHeapTotalBytes": -1314816,
"scriptDurationMs": 8.834999999999999,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2068.0869999999913,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.030000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 868.5269999999999,
"heapDeltaBytes": 10903348,
"heapUsedBytes": 86743212,
"domNodes": -282,
"jsHeapTotalBytes": 5201920,
"scriptDurationMs": 226.775,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2102.277000000072,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.521,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 867.285,
"heapDeltaBytes": 776064,
"heapUsedBytes": 76426156,
"domNodes": -262,
"jsHeapTotalBytes": -1875968,
"scriptDurationMs": 232.39899999999997,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3041.033000000027,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.526,
"layouts": 60,
"layoutDurationMs": 5.5409999999999995,
"taskDurationMs": 968.653,
"heapDeltaBytes": 15556152,
"heapUsedBytes": 77154036,
"domNodes": -265,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 254.99699999999999,
"eventListeners": -145,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3073.8470000000007,
"styleRecalcs": 67,
"styleRecalcDurationMs": 10.421999999999999,
"layouts": 60,
"layoutDurationMs": 4.989000000000001,
"taskDurationMs": 949.2510000000001,
"heapDeltaBytes": 18527100,
"heapUsedBytes": 95258008,
"domNodes": 18,
"jsHeapTotalBytes": 7376896,
"scriptDurationMs": 241.27800000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2127.6189999999815,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.227999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1044.255,
"heapDeltaBytes": -19720864,
"heapUsedBytes": 63311620,
"domNodes": -253,
"jsHeapTotalBytes": 8454144,
"scriptDurationMs": 315.65999999999997,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2109.079999999949,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.706,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 982.609,
"heapDeltaBytes": 9566020,
"heapUsedBytes": 86916332,
"domNodes": 16,
"jsHeapTotalBytes": 6746112,
"scriptDurationMs": 294.357,
"eventListeners": 184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2028.8639999999987,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.601000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.501,
"heapDeltaBytes": -12622308,
"heapUsedBytes": 68378528,
"domNodes": -276,
"jsHeapTotalBytes": 3473408,
"scriptDurationMs": 8.553999999999998,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2033.5819999999103,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.704000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.124,
"heapDeltaBytes": -11060656,
"heapUsedBytes": 70071200,
"domNodes": -278,
"jsHeapTotalBytes": 3997696,
"scriptDurationMs": 9.790000000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 469.61399999997866,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.128000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 285.806,
"heapDeltaBytes": 11516896,
"heapUsedBytes": 73122688,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 80.524,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 457.4000000000069,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.603999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 280.92,
"heapDeltaBytes": 11567412,
"heapUsedBytes": 72644960,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 78.89,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.7979999999798,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.05,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.67300000000006,
"heapDeltaBytes": 172524,
"heapUsedBytes": 60429972,
"domNodes": -281,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 5.5969999999999995,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 1993.1730000000698,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.502999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.416,
"heapDeltaBytes": -5653100,
"heapUsedBytes": 55335188,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 5.426,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1685.5539999999678,
"styleRecalcs": 75,
"styleRecalcDurationMs": 26.012000000000004,
"layouts": 16,
"layoutDurationMs": 3.169,
"taskDurationMs": 618.7629999999999,
"heapDeltaBytes": 8593056,
"heapUsedBytes": 69238948,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 61.45400000000001,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.005999999984,
"styleRecalcs": 76,
"styleRecalcDurationMs": 32.362,
"layouts": 16,
"layoutDurationMs": 3.0309999999999997,
"taskDurationMs": 611.656,
"heapDeltaBytes": 10499532,
"heapUsedBytes": 71423992,
"domNodes": -281,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 55.384,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 898.9520000000084,
"styleRecalcs": 20,
"styleRecalcDurationMs": 22.458,
"layouts": 15,
"layoutDurationMs": 9.111,
"taskDurationMs": 672.8629999999999,
"heapDeltaBytes": -7835736,
"heapUsedBytes": 87521200,
"domNodes": 13673,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 10.269999999999994,
"eventListeners": 2373,
"totalBlockingTimeMs": 103,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8120.092999999997,
"styleRecalcs": 250,
"styleRecalcDurationMs": 23.645000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3017.614,
"heapDeltaBytes": 8269064,
"heapUsedBytes": 82861392,
"domNodes": -260,
"jsHeapTotalBytes": -1089536,
"scriptDurationMs": 705.21,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8093.637000000058,
"styleRecalcs": 250,
"styleRecalcDurationMs": 22.541999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2969.369,
"heapDeltaBytes": -6526156,
"heapUsedBytes": 67961272,
"domNodes": -276,
"jsHeapTotalBytes": -303104,
"scriptDurationMs": 671.834,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12032.019000000048,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10887.387,
"heapDeltaBytes": -25552704,
"heapUsedBytes": 181735772,
"domNodes": -8312,
"jsHeapTotalBytes": -6676480,
"scriptDurationMs": 62.71300000000002,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10707.086000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10263.341,
"heapDeltaBytes": -43892788,
"heapUsedBytes": 176249360,
"domNodes": -8312,
"jsHeapTotalBytes": -10653696,
"scriptDurationMs": 44.948,
"eventListeners": -16393,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13761.149000000045,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.121999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12985.884,
"heapDeltaBytes": -18340928,
"heapUsedBytes": 188940048,
"domNodes": -8312,
"jsHeapTotalBytes": -18018304,
"scriptDurationMs": 344.557,
"eventListeners": -16387,
"totalBlockingTimeMs": 32,
"frameDurationMs": 17.783333333333335,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 13302.486000000044,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.757000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12540.655,
"heapDeltaBytes": -14855584,
"heapUsedBytes": 191128948,
"domNodes": -8312,
"jsHeapTotalBytes": -15429632,
"scriptDurationMs": 264.129,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 101.04699999999411,
"styleRecalcs": 6,
"styleRecalcDurationMs": 7.4750000000000005,
"layouts": 2,
"layoutDurationMs": 0.78,
"taskDurationMs": 62.295,
"heapDeltaBytes": 3100140,
"heapUsedBytes": 64015048,
"domNodes": 127,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.699000000000002,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 88.97999999999229,
"styleRecalcs": 6,
"styleRecalcDurationMs": 9.434,
"layouts": 2,
"layoutDurationMs": 0.34400000000000003,
"taskDurationMs": 55.46599999999999,
"heapDeltaBytes": 3146848,
"heapUsedBytes": 63622464,
"domNodes": 106,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 3.887,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (11)
Included review availability: 1 review is currently available. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour. 📝 WalkthroughWalkthroughChangesNode-definition localization now uses shared resolvers. Live backend text takes precedence over stale bundled translations across graph tooltips, Vue node tooltips, input rendering, and LiteGraph registration. Tests cover locale fallback, raw values, dotted names, and custom translations. ChangesNode-definition localization
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to This change updates widget labels, output names, and tooltips to use backend-resolved text with locale-aware behavior; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant BackendNodeDefinition
participant i18nResolvers
participant NodeTooltip
participant useNodeTooltips
participant litegraphService
participant LiteGraph
BackendNodeDefinition->>i18nResolvers: provide live names and tooltips
NodeTooltip->>i18nResolvers: resolve graph description or slot tooltip
useNodeTooltips->>i18nResolvers: resolve Vue description or slot tooltip
litegraphService->>i18nResolvers: resolve registered slot label
litegraphService->>LiteGraph: register localized node labels
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #14797 +/- ##
==========================================
+ Coverage 78.98% 80.89% +1.91%
==========================================
Files 2209 1882 -327
Lines 119645 108991 -10654
Branches 36919 34389 -2530
==========================================
- Hits 94496 88170 -6326
+ Misses 24615 20444 -4171
+ Partials 534 377 -157
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 464 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/graph/NodeTooltip.test.ts`:
- Around line 236-238: Update the afterEach cleanup in the NodeTooltip test
suite to also reset nodeDefs.SAM3_Detect.outputs.0.tooltip, in addition to
mergeInputTooltipMessage(jsonTooltip), restoring the output tooltip state
changed during setup so later tests remain isolated.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 2fa5ebe5-932f-432e-b10b-5cc1ea52ff22
📒 Files selected for processing (8)
src/components/graph/NodeTooltip.test.tssrc/components/graph/NodeTooltip.vuesrc/i18n.test.tssrc/i18n.tssrc/renderer/extensions/vueNodes/composables/useNodeTooltips.test.tssrc/renderer/extensions/vueNodes/composables/useNodeTooltips.tssrc/services/litegraphService.test.tssrc/services/litegraphService.ts
DrJKL
left a comment
There was a problem hiding this comment.
Please address the consumer-path regressions and consolidate the slot resolver API where practical.
DrJKL
left a comment
There was a problem hiding this comment.
Please replace the implementation-detail assertions and duplicate precedence cases with behavioral coverage at the affected consumer boundaries.
…widget-labels-and-tooltips # Conflicts: # src/services/litegraphService.test.ts
|
Working on fixes for my comments. |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/graph/NodeTooltip.vue`:
- Line 16: Update the title tooltip call in NodeTooltip.vue to resolve the
description through resolveNodeDefText('description', nodeType,
nodeDef?.description) before passing it to showTooltip, while preserving the
existing tooltip behavior.
In `@src/renderer/extensions/vueNodes/components/InputSlot.vue`:
- Around line 103-107: Update the tooltip construction around
getInputSlotTooltip to use useI18n() and translate the fallback “Input:” label
instead of embedding the user-facing literal. Add the corresponding translation
entry to main.json and preserve the existing displayName fallback behavior.
In `@src/renderer/extensions/vueNodes/composables/useNodeTooltips.test.ts`:
- Line 85: Reset the actual i18n catalog after each test instead of relying only
on mergeCustomNodesI18n({}), which clears custom-node data but leaves merged
locale messages active. In
src/renderer/extensions/vueNodes/composables/useNodeTooltips.test.ts lines 85-85
and src/services/litegraphService.test.ts lines 90-92, restore the affected
locale messages or reset the test i18n instance so i18n and Pinia state remain
isolated between tests.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 841cbb2d-a6dd-4b35-bde0-36f7ee301f9c
📒 Files selected for processing (10)
src/components/graph/NodeTooltip.test.tssrc/components/graph/NodeTooltip.vuesrc/i18n.test.tssrc/i18n.tssrc/renderer/extensions/vueNodes/components/InputSlot.test.tssrc/renderer/extensions/vueNodes/components/InputSlot.vuesrc/renderer/extensions/vueNodes/composables/useNodeTooltips.test.tssrc/renderer/extensions/vueNodes/composables/useNodeTooltips.tssrc/services/litegraphService.test.tssrc/services/litegraphService.ts
💤 Files with no reviewable changes (1)
- src/components/graph/NodeTooltip.test.ts
|
Resolved, and I was wrong about the diagnosis. #15356 landed on That PR reached the same mechanical conclusion I did — same bounding box inside the My "deterministic, specific to this branch" call was wrong. I treated Only Nothing left here but review. All threads resolved; |
DrJKL
left a comment
There was a problem hiding this comment.
Please tighten the changed unit tests around behavioral boundaries and isolated shared state.
| }) | ||
|
|
||
| describe('InputSlot', () => { | ||
| it('uses the raw input name to resolve the tooltip', () => { |
There was a problem hiding this comment.
This mocks useNodeTooltips, so it proves calls to an internal collaborator rather than the metadata-tooltip behavior. Please render with the real composable/store, use differing raw and localized names, and assert the bound metadata tooltip; keep a separate fallback case for the localized display name.
There was a problem hiding this comment.
Fixed in 6fe6d732fc: the component test now uses the real composable/store and separately covers metadata lookup and localized fallback.
| import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest' | ||
|
|
||
| import { i18n, te } from '@/i18n' | ||
| import { i18n, mergeCustomNodesI18n, te } from '@/i18n' |
There was a problem hiding this comment.
These te() assertions only verify fixture setup and do not prove the bundled path runs—the live backend value short-circuits it. Please remove the six equivalent assertions/constants/imports across this file and useNodeTooltips.test.ts; the rendered/result assertions protect behavior.
There was a problem hiding this comment.
Fixed in 6fe6d732fc: removed all six te() fixture assertions and their unused keys/imports.
| await useLitegraphService().registerNodeDef(nodeName, nodeDef) | ||
| }) | ||
|
|
||
| afterEach(() => { |
There was a problem hiding this comment.
registerNodeDef mutates LiteGraph's global node-type registry. Please unregister each test node during cleanup so these tests leave all shared state isolated.
There was a problem hiding this comment.
Fixed in 6fe6d732fc: both suites now unregister their test node type during cleanup.
|
|
||
| describe('slot text', () => { | ||
| describe('precedence', () => { | ||
| it.for([ |
There was a problem hiding this comment.
This exercises the full input/output × name/tooltip cross-product even though those are orthogonal branches. Please keep pairwise representatives for backend and bundled precedence; the dedicated raw/compiled test already protects the field-specific reader behavior.
There was a problem hiding this comment.
Fixed in 6fe6d732fc: precedence uses pairwise input/output and name/tooltip representatives; raw/compiled coverage remains separate.
| mergeOutputTooltipMessage(staleOutputTooltip) | ||
| }) | ||
|
|
||
| afterEach(() => { |
There was a problem hiding this comment.
This nested cleanup is redundant because the outer afterEach restores the complete English catalog immediately afterward. Please delete it and keep the single lifecycle owner.
There was a problem hiding this comment.
Fixed in 6fe6d732fc: removed the nested cleanup; the outer hook is the sole catalog lifecycle owner.
Amp-Thread-ID: https://ampcode.com/threads/T-01a0169e-9c79-7422-99dd-ef5d2608f031 Co-authored-by: Amp <amp@ampcode.com>
|
|
#14797) #14541 made English `display_name` and `description` come from the backend. Widget labels, output names and tooltips were still read from the stale bundled snapshot, so a renamed node showed a new title beside old labels. Adds `resolveNodeDefInputText` / `resolveNodeDefOutputText` and extracts `resolveNodeDefPath`, so the per-locale precedence table now lives in exactly one place and `resolveNodeDefText` delegates to it. Applied in `litegraphService` (widget labels, socket and output `localized_name`), `NodeTooltip.vue`, and `useNodeTooltips.ts`. Also fixes `getNodeDescription`, which wrapped an already-resolved value in `st()` and let the stale bundle win. ## Review focus **Tooltips must never be escaped or compiled.** They are read through `stRaw`/`tm()`, which returns the message uncompiled, so a literal `{'@'}` would render to the user. One function decides it: ```ts return field === 'tooltip' ? stRaw : st ``` Backend values short-circuit before any reader runs, so a tooltip reaches the compiler by no path. No runtime escaping added; `escapeI18nMessage` stays build-time-only. Coverage was verified by mutation rather than inspection, which matters here: `st()` swallows a vue-i18n `SyntaxError` and returns the raw stored message, so a fixture containing a throwing character passes whether or not the code is correct. The raw/compiled fixture (`50{'%'} {'@'}`) compiles cleanly so that escape hatch cannot mask a defect. Forcing the reader to always-`st` or always-`stRaw` each fails the suite. ## Migration guidance (`node.widgets`) `widget.label` now resolves through the node-def text pipeline (custom-node translations, then the live backend value, then the bundled snapshot) instead of taking the node definition's `display_name` verbatim. The resolved string therefore varies by active locale and by what `/object_info` sends. Extensions must use `widget.name` for widget identity. `widget.label` is display text and was never stable across locales. No type or API shape changed. Fixes #14631 --- Previously merged without review and backed out by #14791. Re-submitting for normal review. Rebased onto post-revert `main`; content unchanged. --------- Co-authored-by: Connor Byrne <c.byrne@comfy.org> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: DrJKL <DrJKL0424@gmail.com>
|
@christian-byrne Successfully backported to #15480 |
|
@christian-byrne Successfully backported to #15482 |
…ltips from the backend (#15480) Backport of #14797 to `core/1.51` Automatically created by backport workflow. Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: Connor Byrne <c.byrne@comfy.org> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: DrJKL <DrJKL0424@gmail.com>
…oltips from the backend (#15482) Backport of #14797 to `cloud/1.51` Automatically created by backport workflow. Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: Connor Byrne <c.byrne@comfy.org> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: DrJKL <DrJKL0424@gmail.com>
|
Audit complete: no residual patch. All five review items landed with #14797 and remain protected on current Full context for agent readers
Merge commit |
#14541 made English
display_nameanddescriptioncome from the backend. Widget labels, output names and tooltips were still read from the stale bundled snapshot, so a renamed node showed a new title beside old labels.Adds
resolveNodeDefInputText/resolveNodeDefOutputTextand extractsresolveNodeDefPath, so the per-locale precedence table now lives in exactly one place andresolveNodeDefTextdelegates to it. Applied inlitegraphService(widget labels, socket and outputlocalized_name),NodeTooltip.vue, anduseNodeTooltips.ts. Also fixesgetNodeDescription, which wrapped an already-resolved value inst()and let the stale bundle win.Review focus
Tooltips must never be escaped or compiled. They are read through
stRaw/tm(), which returns the message uncompiled, so a literal{'@'}would render to the user. One function decides it:Backend values short-circuit before any reader runs, so a tooltip reaches the compiler by no path. No runtime escaping added;
escapeI18nMessagestays build-time-only.Coverage was verified by mutation rather than inspection, which matters here:
st()swallows a vue-i18nSyntaxErrorand returns the raw stored message, so a fixture containing a throwing character passes whether or not the code is correct. The raw/compiled fixture (50{'%'} {'@'}) compiles cleanly so that escape hatch cannot mask a defect. Forcing the reader to always-stor always-stRaweach fails the suite.Migration guidance (
node.widgets)widget.labelnow resolves through the node-def text pipeline (custom-node translations, then the live backend value, then the bundled snapshot) instead of taking the node definition'sdisplay_nameverbatim. The resolved string therefore varies by active locale and by what/object_infosends.Extensions must use
widget.namefor widget identity.widget.labelis display text and was never stable across locales. No type or API shape changed.Fixes #14631
Previously merged without review and backed out by #14791. Re-submitting for normal review. Rebased onto post-revert
main; content unchanged.