Repository navigation
test: pin the remaining container-coupled node titles - #14795
christian-byrne wants to merge 1 commit into
Conversation
Extends the #14744 stub to the two sites it left out: the `api-pricing-*` goldens (`FluxProUltraImageNode` -> `Flux 1.1 [pro] Ultra Image`) and the `node-badge-{mode}` goldens (`PreviewImage` -> `Preview Image`). The other node in `nodes/execution_error`, `DevToolsErrorRaiseNode`, is left unpinned: it ships from `tools/devtools/` in this repo, so its title is not a function of the container image. No baselines regenerated — both strings are the ones the committed PNGs already render.
🎭 Playwright: ✅ 1788 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-05T12:13:04.922Z",
"gitSha": "3c2dba8113e51dc7a8eacf3f63b8f604963b2a40",
"branch": "test/stub-remaining-container-coupled-goldens",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2042.7779999999984,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.978000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 389.82900000000006,
"heapDeltaBytes": 5368168,
"heapUsedBytes": 69483936,
"domNodes": 20,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 13.308,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1997.9020000000673,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.319000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 373.756,
"heapDeltaBytes": 5344540,
"heapUsedBytes": 69455544,
"domNodes": 20,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 13.154,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1780.9399999999869,
"styleRecalcs": 73,
"styleRecalcDurationMs": 27.875999999999998,
"layouts": 12,
"layoutDurationMs": 2.385,
"taskDurationMs": 749.583,
"heapDeltaBytes": -682136,
"heapUsedBytes": 63429916,
"domNodes": 55,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 94.17500000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1704.4419999999718,
"styleRecalcs": 72,
"styleRecalcDurationMs": 23.094,
"layouts": 12,
"layoutDurationMs": 2.359,
"taskDurationMs": 655.284,
"heapDeltaBytes": -13920916,
"heapUsedBytes": 50082760,
"domNodes": -278,
"jsHeapTotalBytes": 23834624,
"scriptDurationMs": 78.959,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1685.5150000000094,
"styleRecalcs": 30,
"styleRecalcDurationMs": 11.930000000000001,
"layouts": 6,
"layoutDurationMs": 0.49199999999999994,
"taskDurationMs": 300.45900000000006,
"heapDeltaBytes": 8323208,
"heapUsedBytes": 72413388,
"domNodes": 79,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 14.31,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1684.3170000000782,
"styleRecalcs": 31,
"styleRecalcDurationMs": 10.982000000000003,
"layouts": 6,
"layoutDurationMs": 0.393,
"taskDurationMs": 292.556,
"heapDeltaBytes": 8193028,
"heapUsedBytes": 72345524,
"domNodes": 77,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 13.781999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 459.3189999999936,
"styleRecalcs": 13,
"styleRecalcDurationMs": 5.452999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 266.876,
"heapDeltaBytes": -12599148,
"heapUsedBytes": 51510608,
"domNodes": 22,
"jsHeapTotalBytes": 26476544,
"scriptDurationMs": 36.662,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 465.7479999999623,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.422999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 277.341,
"heapDeltaBytes": -12746480,
"heapUsedBytes": 51492200,
"domNodes": 20,
"jsHeapTotalBytes": 26738688,
"scriptDurationMs": 37.425,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2029.7289999999748,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.521999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 534.988,
"heapDeltaBytes": 7583164,
"heapUsedBytes": 66957164,
"domNodes": -282,
"jsHeapTotalBytes": 2727936,
"scriptDurationMs": 66.44500000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2013.4080000000267,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.558,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.38,
"heapDeltaBytes": 6771884,
"heapUsedBytes": 68311372,
"domNodes": -279,
"jsHeapTotalBytes": 3514368,
"scriptDurationMs": 63.660999999999994,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2084.4880000000217,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.66,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 906.102,
"heapDeltaBytes": 3191968,
"heapUsedBytes": 64373216,
"domNodes": -283,
"jsHeapTotalBytes": 3444736,
"scriptDurationMs": 274.54699999999997,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2093.4029999999666,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.939,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 914.755,
"heapDeltaBytes": 3313352,
"heapUsedBytes": 64220540,
"domNodes": -283,
"jsHeapTotalBytes": 3182592,
"scriptDurationMs": 278.609,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3071.006000000011,
"styleRecalcs": 67,
"styleRecalcDurationMs": 10.731000000000002,
"layouts": 60,
"layoutDurationMs": 5.387,
"taskDurationMs": 1026.703,
"heapDeltaBytes": 22737900,
"heapUsedBytes": 85070148,
"domNodes": 16,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 332.90500000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3090.1189999999588,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.043,
"layouts": 60,
"layoutDurationMs": 5.46,
"taskDurationMs": 1078.614,
"heapDeltaBytes": 23016244,
"heapUsedBytes": 85310056,
"domNodes": 16,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 347.23400000000004,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2030.9690000000273,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.361,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 547.361,
"heapDeltaBytes": 5748528,
"heapUsedBytes": 66669656,
"domNodes": -283,
"jsHeapTotalBytes": 3514368,
"scriptDurationMs": 66.312,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2009.4589999999926,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.280000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 534.111,
"heapDeltaBytes": 9084956,
"heapUsedBytes": 70247136,
"domNodes": -282,
"jsHeapTotalBytes": 4300800,
"scriptDurationMs": 63.218999999999994,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 476.07899999997016,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.814000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 307.415,
"heapDeltaBytes": -10817256,
"heapUsedBytes": 53334192,
"domNodes": 22,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 83.554,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 471.512999999959,
"styleRecalcs": 49,
"styleRecalcDurationMs": 7.559,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 284.542,
"heapDeltaBytes": -10973280,
"heapUsedBytes": 53470124,
"domNodes": 24,
"jsHeapTotalBytes": 26476544,
"scriptDurationMs": 75.69300000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2005.5090000000177,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.8790000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.668,
"heapDeltaBytes": -18757404,
"heapUsedBytes": 45481668,
"domNodes": 19,
"jsHeapTotalBytes": 23310336,
"scriptDurationMs": 11.419,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1998.6100000000988,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.103999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.421,
"heapDeltaBytes": 5030960,
"heapUsedBytes": 69234576,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 11.232999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1675.9590000000344,
"styleRecalcs": 76,
"styleRecalcDurationMs": 22.935999999999996,
"layouts": 16,
"layoutDurationMs": 2.519,
"taskDurationMs": 580.3810000000001,
"heapDeltaBytes": -4035984,
"heapUsedBytes": 60194904,
"domNodes": 64,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 56.928999999999995,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.3670000000611,
"styleRecalcs": 76,
"styleRecalcDurationMs": 21.799,
"layouts": 16,
"layoutDurationMs": 2.406,
"taskDurationMs": 578.2839999999999,
"heapDeltaBytes": -16911504,
"heapUsedBytes": 47290272,
"domNodes": -280,
"jsHeapTotalBytes": 23048192,
"scriptDurationMs": 56.50600000000001,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 900.888000000009,
"styleRecalcs": 19,
"styleRecalcDurationMs": 23.067999999999998,
"layouts": 15,
"layoutDurationMs": 8.383999999999999,
"taskDurationMs": 717.686,
"heapDeltaBytes": 28645560,
"heapUsedBytes": 96194436,
"domNodes": 13673,
"jsHeapTotalBytes": 17301504,
"scriptDurationMs": 27.035000000000004,
"eventListeners": 2373,
"totalBlockingTimeMs": 106,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8116.180999999983,
"styleRecalcs": 250,
"styleRecalcDurationMs": 23.423000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3216.5999999999995,
"heapDeltaBytes": 4165544,
"heapUsedBytes": 63869156,
"domNodes": -280,
"jsHeapTotalBytes": 5279744,
"scriptDurationMs": 892.0709999999999,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8103.915000000029,
"styleRecalcs": 249,
"styleRecalcDurationMs": 23.04,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3127.245,
"heapDeltaBytes": 4344732,
"heapUsedBytes": 66230164,
"domNodes": -280,
"jsHeapTotalBytes": 6852608,
"scriptDurationMs": 871.3740000000001,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 10842.022999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10827.724,
"heapDeltaBytes": -58019724,
"heapUsedBytes": 168718460,
"domNodes": -8312,
"jsHeapTotalBytes": -6496256,
"scriptDurationMs": 403.364,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 10557.4509999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10543.335,
"heapDeltaBytes": -34981524,
"heapUsedBytes": 184542276,
"domNodes": -8312,
"jsHeapTotalBytes": -7544832,
"scriptDurationMs": 387.6,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 13774.568999999985,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.020000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13754.086000000001,
"heapDeltaBytes": -37812036,
"heapUsedBytes": 167362780,
"domNodes": -8312,
"jsHeapTotalBytes": -9375744,
"scriptDurationMs": 676.158,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 12996.245999999928,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.572999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12976.401000000002,
"heapDeltaBytes": -39877668,
"heapUsedBytes": 166810004,
"domNodes": -8312,
"jsHeapTotalBytes": -9641984,
"scriptDurationMs": 614.4079999999999,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 466.20900000004895,
"styleRecalcs": 16,
"styleRecalcDurationMs": 14.021999999999998,
"layouts": 2,
"layoutDurationMs": 0.30100000000000005,
"taskDurationMs": 95.02499999999999,
"heapDeltaBytes": 5335596,
"heapUsedBytes": 68656648,
"domNodes": 138,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7.131,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 430.15700000000834,
"styleRecalcs": 15,
"styleRecalcDurationMs": 13.793999999999999,
"layouts": 3,
"layoutDurationMs": 0.938,
"taskDurationMs": 84.15,
"heapDeltaBytes": 5158028,
"heapUsedBytes": 68405604,
"domNodes": 125,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7.470000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
}
]
} |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## fix/decouple-node-title-goldens-from-ci-container #14795 +/- ##
=====================================================================================
+ Coverage 78.61% 78.63% +0.02%
=====================================================================================
Files 1798 1797 -1
Lines 106789 106723 -66
Branches 29732 30599 +867
=====================================================================================
- Hits 83956 83926 -30
+ Misses 22375 22339 -36
Partials 458 458
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
See reason on base PR for closure. |
Stacked on #14794 — review that one first; this targets its branch and will retarget
mainonce it lands.Extends the same stubbing to the goldens 14794 left out:
api-pricing-{on,off}-{classic,vue}FluxProUltraImageNodeFlux 1.1 [pro] Ultra Imagenode-badge-{Show-all,Hide-built-in,None}PreviewImagePreview ImageGoldens unchanged; both strings match
src/locales/en/nodeDefs.jsonand are legible in the committed PNGs.Deliberately not pinned:
DevToolsErrorRaiseNode(Raise Error). It is defined in this repo attools/devtools/nodes/errors.py:76and copied intocustom_nodesduring CI, so pinning it would mask a deliberate in-repo rename rather than container drift.Related: #14630
Previously merged without review and backed out by #14791. Re-submitting for normal review. Rebased onto post-revert
main; content unchanged.