Repository navigation
refactor: resolve node display name and description at read time - #14798
Conversation
🎭 Playwright: ✅ 1814 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 8.85 MB gzip 🔴 +221 BDetailsSummary
Category Glance App Entry Points — 3.71 kB (baseline 3.71 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.37 MB (baseline 1.37 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 566 kB (baseline 566 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 16 unchanged User & Accounts — 27.7 kB (baseline 27.7 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 8 unchanged Data & Services — 3.52 MB (baseline 3.52 MB) • 🔴 +551 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 550 kB (baseline 550 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 20 unchanged Vendor & Third-Party — 16.8 MB (baseline 16.8 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 14.2 MB (baseline 14.2 MB) • ⚪ 0 BBundles that do not match a named category
Status: 68 added / 68 removed / 217 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-17T01:32:07.148Z",
"gitSha": "76248543510c8dcbac4e4fa3dbe1f36c8d0b7b10",
"branch": "refactor/resolve-node-text-at-read-time",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2031.8139999999971,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.4959999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.18300000000005,
"heapDeltaBytes": 5057336,
"heapUsedBytes": 70581104,
"domNodes": 18,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 8.165000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2038.7149999999679,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.264000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.53000000000003,
"heapDeltaBytes": 4951828,
"heapUsedBytes": 70206444,
"domNodes": 20,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 8.557,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2012.9890000000046,
"styleRecalcs": 80,
"styleRecalcDurationMs": 45.088,
"layouts": 12,
"layoutDurationMs": 4.149,
"taskDurationMs": 979.918,
"heapDeltaBytes": -18716828,
"heapUsedBytes": 46543908,
"domNodes": 3,
"jsHeapTotalBytes": 23957504,
"scriptDurationMs": 117.21900000000002,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1836.5049999999883,
"styleRecalcs": 76,
"styleRecalcDurationMs": 33.949,
"layouts": 12,
"layoutDurationMs": 3.6110000000000007,
"taskDurationMs": 796.455,
"heapDeltaBytes": -41144,
"heapUsedBytes": 65173744,
"domNodes": 58,
"jsHeapTotalBytes": 25956352,
"scriptDurationMs": 100.522,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1735.6899999999769,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.158999999999999,
"layouts": 6,
"layoutDurationMs": 0.717,
"taskDurationMs": 362.567,
"heapDeltaBytes": 7787112,
"heapUsedBytes": 73116812,
"domNodes": 76,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 9.536000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.9639999999863,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.985,
"layouts": 6,
"layoutDurationMs": 0.6709999999999999,
"taskDurationMs": 371.64799999999997,
"heapDeltaBytes": 7839212,
"heapUsedBytes": 73150012,
"domNodes": 77,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 9.957,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 578.9450000000045,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.093999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 368.456,
"heapDeltaBytes": -11872252,
"heapUsedBytes": 53617572,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 53.10099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 575.7109999999557,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.610999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.24,
"heapDeltaBytes": -11553320,
"heapUsedBytes": 53963048,
"domNodes": 18,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 51.266,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2036.6510000000062,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.863000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 591.5409999999999,
"heapDeltaBytes": 12875232,
"heapUsedBytes": 73178452,
"domNodes": -283,
"jsHeapTotalBytes": 3506176,
"scriptDurationMs": 16.976000000000003,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2030.4980000000796,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.006999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 591.756,
"heapDeltaBytes": 12774864,
"heapUsedBytes": 72853828,
"domNodes": -283,
"jsHeapTotalBytes": 3506176,
"scriptDurationMs": 13.377999999999998,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2151.826999999969,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.944999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1153.521,
"heapDeltaBytes": -6098180,
"heapUsedBytes": 54906592,
"domNodes": -285,
"jsHeapTotalBytes": 3768320,
"scriptDurationMs": 305.772,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2174.784999999929,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.943999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1201.1370000000002,
"heapDeltaBytes": 7625936,
"heapUsedBytes": 68365020,
"domNodes": -284,
"jsHeapTotalBytes": 3174400,
"scriptDurationMs": 317.65700000000004,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3130.8089999999993,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.455000000000004,
"layouts": 60,
"layoutDurationMs": 7.92,
"taskDurationMs": 1327.0040000000001,
"heapDeltaBytes": 17246528,
"heapUsedBytes": 79137188,
"domNodes": 12,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 377.973,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3181.332999999995,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.869,
"layouts": 60,
"layoutDurationMs": 8.278999999999998,
"taskDurationMs": 1349.438,
"heapDeltaBytes": 17283068,
"heapUsedBytes": 80520144,
"domNodes": 8,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 384.562,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2028.5739999999919,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.387,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.1990000000001,
"heapDeltaBytes": 13432180,
"heapUsedBytes": 73964152,
"domNodes": -283,
"jsHeapTotalBytes": 2457600,
"scriptDurationMs": 13.513999999999998,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2040.0659999999107,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.913999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 583.897,
"heapDeltaBytes": 13406916,
"heapUsedBytes": 74848580,
"domNodes": -284,
"jsHeapTotalBytes": 2981888,
"scriptDurationMs": 13.099,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 600.1980000000344,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.122,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.626,
"heapDeltaBytes": -9943248,
"heapUsedBytes": 55566900,
"domNodes": 20,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 122.84200000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 627.112000000011,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.567,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.384,
"heapDeltaBytes": -11367680,
"heapUsedBytes": 54202816,
"domNodes": 20,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 130.617,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2020.024000000035,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.9570000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.19699999999995,
"heapDeltaBytes": 5190084,
"heapUsedBytes": 70722068,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 6.476000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1994.6029999999837,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.816,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.50800000000004,
"heapDeltaBytes": 5190436,
"heapUsedBytes": 70737064,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 6.590999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1699.528999999984,
"styleRecalcs": 76,
"styleRecalcDurationMs": 38.316,
"layouts": 16,
"layoutDurationMs": 5.055000000000001,
"taskDurationMs": 753.047,
"heapDeltaBytes": -3752256,
"heapUsedBytes": 61907012,
"domNodes": 62,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 80.954,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1688.2900000000518,
"styleRecalcs": 76,
"styleRecalcDurationMs": 34.269999999999996,
"layouts": 16,
"layoutDurationMs": 3.838,
"taskDurationMs": 725.795,
"heapDeltaBytes": -3656204,
"heapUsedBytes": 61777832,
"domNodes": 64,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 78.92200000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1350.9669999999687,
"styleRecalcs": 20,
"styleRecalcDurationMs": 28.520000000000003,
"layouts": 15,
"layoutDurationMs": 11.205,
"taskDurationMs": 900.5099999999999,
"heapDeltaBytes": -6086324,
"heapUsedBytes": 81242520,
"domNodes": 13673,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 16.572000000000003,
"eventListeners": 2375,
"totalBlockingTimeMs": 120,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8211.228999999947,
"styleRecalcs": 250,
"styleRecalcDurationMs": 42.25900000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4039.2419999999997,
"heapDeltaBytes": 13340540,
"heapUsedBytes": 73810404,
"domNodes": -281,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 944.175,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8219.537999999942,
"styleRecalcs": 249,
"styleRecalcDurationMs": 40.76200000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4064.7580000000003,
"heapDeltaBytes": 14245328,
"heapUsedBytes": 74738280,
"domNodes": -284,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 945.249,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17382.66900000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16665.557,
"heapDeltaBytes": -39749068,
"heapUsedBytes": 170883544,
"domNodes": -8312,
"jsHeapTotalBytes": -7016448,
"scriptDurationMs": 119.499,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18020.676999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17167.492,
"heapDeltaBytes": -43388268,
"heapUsedBytes": 167472916,
"domNodes": -8312,
"jsHeapTotalBytes": -12783616,
"scriptDurationMs": 131.541,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21249.43000000002,
"styleRecalcs": 168,
"styleRecalcDurationMs": 18.468999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20622.36,
"heapDeltaBytes": -41652712,
"heapUsedBytes": 169457928,
"domNodes": -8312,
"jsHeapTotalBytes": -14950400,
"scriptDurationMs": 434.5060000000001,
"eventListeners": -16385,
"totalBlockingTimeMs": 91,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21563.8449999999,
"styleRecalcs": 177,
"styleRecalcDurationMs": 21.56399999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20937.536,
"heapDeltaBytes": -34446736,
"heapUsedBytes": 163950672,
"domNodes": -8342,
"jsHeapTotalBytes": -13275136,
"scriptDurationMs": 413.54100000000005,
"eventListeners": -16435,
"totalBlockingTimeMs": 80,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 449.2880000000241,
"styleRecalcs": 13,
"styleRecalcDurationMs": 18.073000000000004,
"layouts": 3,
"layoutDurationMs": 0.7050000000000001,
"taskDurationMs": 101.20400000000001,
"heapDeltaBytes": 4948972,
"heapUsedBytes": 69483260,
"domNodes": 126,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 6.9350000000000005,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 485.6130000000576,
"styleRecalcs": 17,
"styleRecalcDurationMs": 22.572,
"layouts": 3,
"layoutDurationMs": 1.391,
"taskDurationMs": 114.05900000000001,
"heapDeltaBytes": 5048804,
"heapUsedBytes": 69626736,
"domNodes": 147,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 6.958999999999998,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 27 minutes Limit details: You’ve used all 4 included reviews currently available under your plan. You completed 64 included PR reviews in the past 7 days; at that activity level, included reviews refill at 4 reviews per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughNode definitions now retain raw backend text. ChangesNode text localization
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related issues
Possibly related PRs
Suggested labels: Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/stores/nodeDefStore.ts`:
- Line 426: Make nodeDefsByDisplayName a derived index from nodeDefsByName so it
recomputes whenever localized ComfyNodeDefImpl.display_name values change,
rather than relying on the insertion-time assignments in updateNodeDefs and
addNodeDef. Update lookups to use the reactive index while preserving existing
behavior, and add a regression test that calls updateNodeDefs, switches locale,
and verifies lookup by the new localized display name.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 0b028864-2bbc-4d7b-b80a-3854e4bbf4f6
📒 Files selected for processing (5)
src/locales/CONTRIBUTING.mdsrc/scripts/app.getNodeDefs.test.tssrc/scripts/app.tssrc/stores/nodeDefStore.nodeText.test.tssrc/stores/nodeDefStore.ts
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14798 +/- ##
==========================================
+ Coverage 79.02% 81.37% +2.34%
==========================================
Files 2209 1882 -327
Lines 122800 117898 -4902
Branches 36772 35622 -1150
==========================================
- Hits 97045 95938 -1107
+ Misses 25186 21493 -3693
+ Partials 569 467 -102
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 335 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…ange Addresses review feedback: #14798 (comment)
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/stores/nodeDefStore.ts (1)
157-158: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winPreserve empty backend text.
display_name || undefinedanddescription || undefinedconvert an empty backend value toundefined. The resolver then treats that value as absent and may use a fallback or a different value frombackendNodeText. This violates raw text pass-through and can produce an incorrect display-name index key.Normalize only nullish values.
Proposed fix
- this.backendDisplayName = display_name || undefined - this.backendDescription = description || undefined + this.backendDisplayName = display_name ?? undefined + this.backendDescription = description ?? undefined🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/stores/nodeDefStore.ts` around lines 157 - 158, Update the assignments in the node definition store that set backendDisplayName and backendDescription to normalize only nullish values, preserving empty strings and other valid backend text exactly. Replace the falsy-value fallback behavior with nullish handling so resolver pass-through and display-name index keys remain based on the raw backend text.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/stores/nodeDefStore.ts`:
- Around line 157-158: Update the assignments in the node definition store that
set backendDisplayName and backendDescription to normalize only nullish values,
preserving empty strings and other valid backend text exactly. Replace the
falsy-value fallback behavior with nullish handling so resolver pass-through and
display-name index keys remain based on the raw backend text.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: a487f99a-8762-4fab-b687-97455da0e48a
📒 Files selected for processing (2)
src/stores/nodeDefStore.nodeText.test.tssrc/stores/nodeDefStore.ts
`ComfyApp.getNodeDefs()` baked resolved text into each def at fetch time, so `nodeDefStore` held translated values, the raw `/object_info` strings were discarded, and switching locale needed a full `Comfy.RefreshNodeDefinitions` round trip. `ComfyNodeDefImpl.display_name` and `.description` become getters that delegate to `resolveNodeDefText`, holding the raw backend value on the instance. `translateNodeDef` keeps resolving `category` only. Property-access shape is unchanged, so the ~96 files reading `display_name` are untouched. The raw values are held as TypeScript `private` fields rather than `#private`: Vue wraps store instances in a Proxy, and `#private` reads throw through one. The constructor also holds `display_name`/`description` out of its `Object.assign`, which would otherwise throw on the setter-less accessors.
…ange Addresses review feedback: #14798 (comment)
bec0ca6 to
a1ed780
Compare
|
Rebased onto current Context: this was merged without review on 2026-08-05 and backed out by #14791, so it needs a real approval this time. Closes #14629, which I reopened since the fix is not on Independent of #14796 despite both touching |
…or boundary `display_name` and `description` became prototype accessors in #14798. `page.evaluate` serializes own enumerable properties only, so the release locale collector received both as undefined and `serializeNodeDefLocales` fell through to `nodeDef.name`. The next regeneration of `src/locales/en/nodeDefs.json` would have rewritten every node's English display name as its internal name and dropped every description, then lobe-i18n would have retranslated all 13 locales from that. The collector only runs at release, so nothing on main would have caught it. Adds `toSerializable()` and a test that fails if it stops materializing.
…or boundary (Comfy-Org#15538) `ComfyNodeDefImpl.display_name` and `.description` became prototype accessors in Comfy-Org#14798. `page.evaluate` serializes own enumerable properties only, so accessors do not cross it. `scripts/collect-i18n-node-defs.ts` builds `ComfyNodeDefImpl`s inside the browser and returns them to Node. After Comfy-Org#14798 both fields arrive `undefined`, and `serializeNodeDefLocales` falls through to `nodeDef.display_name ?? nodeDef.name`. The next release would regenerate `src/locales/en/nodeDefs.json` with every node's English display name replaced by its internal name and every description dropped, then lobe-i18n would retranslate all 13 locales from that. Changed English is not retranslated back, so it would not self-heal. Measured before and after the boundary, using `structuredClone({ ...impl })` as a stand-in for Playwright's serialization: | | `display_name` | `description` | | --- | --- | --- | | in-browser | `Live Display Name` | `Live description` | | after `page.evaluate` | *(absent)* | *(absent)* | | what the serializer would write | `SerializationProbe` (the node name) | dropped | `backendDisplayName` and `backendDescription` do survive — they are own properties — which is why nothing else broke. ## Why no test caught it The collector runs only at release, against a live backend, so it has no CI coverage. `nodeDefStore.nodeText.test.ts` asserts the accessors in-process, where they work. `toSerializable()` materializes both, and `nodeDefStore.serialization.test.ts` fails if it stops. `Object.assign` rather than spread because `no-misused-spread` correctly rejects spreading a class instance. Second test pins the underlying hazard — a bare instance loses both across the boundary — so anything else that carries a def out of the browser has the reason written down. --------- Co-authored-by: Benjamin Lu <benjaminlu1107@gmail.com>
ComfyApp.getNodeDefs()baked resolved text into the def at fetch time, sonodeDefStoreheld translated values and the raw backend strings were discarded. Locale switching therefore needed a full refetch.Converts
ComfyNodeDefImpl.display_nameanddescriptionto getters delegating toresolveNodeDefText, holding the raw backend value in instance fields.translateNodeDefstops resolving those two (still doescategory). Property-access shape is preserved, so the ~96 files readingdisplay_nameare untouched.Review focus
Three hazards were checked empirically rather than assumed, and one is load-bearing:
#privatefields throw through a Proxy. Vue wraps store instances in one, so the raw values use TypeScriptprivate(plain own properties). Using#privatewould have made every store read throw.Object.assign(this, obj)throws on setter-less accessors — defused by destructuringdisplay_name/descriptionout.JSON.stringify,structuredCloneandObject.keysall drop prototype getters. EveryComfyNodeDefImplconsumer was swept; exactly one structurally copies (nodeBookmarkStore.buildBookmarkTree, via es-toolkitclone, which preserves the prototype). A regression test covers it, since swapping that for a spread would silently blank every bookmark label.Perf measured at +0.28µs per read, ~1.5ms across 5000 defs.
Known remainders are tracked in #14777:
node.titleis still baked at registration, andnodeDefsByDisplayNamestill snapshots its keys.Fixes #14629
Previously merged without review and backed out by #14791. Re-submitting for normal review. Rebased onto post-revert
main; content unchanged.