Repository navigation
fix(workflow): build nodes for uninstalled types on API JSON import - #14555
Conversation
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
🎭 Playwright: ✅ 1790 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 8.26 MB gzip 🔴 +339 BDetailsSummary
Category Glance App Entry Points — 3.64 kB (baseline 3.64 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.35 MB (baseline 1.35 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 552 kB (baseline 552 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 16 unchanged User & Accounts — 27 kB (baseline 27 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 4 unchanged Editors & Dialogs — 124 kB (baseline 124 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 6 added / 6 removed / 1 unchanged UI Components — 72.1 kB (baseline 72.1 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 9 unchanged Data & Services — 3.48 MB (baseline 3.48 MB) • 🔴 +1.61 kBStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 387 kB (baseline 387 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 16 added / 16 removed / 20 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 12.8 MB (baseline 12.8 MB) • ⚪ 0 BBundles that do not match a named category
Status: 70 added / 70 removed / 214 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-06T02:31:08.074Z",
"gitSha": "3a3ac2faba169c254b6ccebb24700029fa8cdada",
"branch": "jaeone94/prA-a1-api-json",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2084.974999999986,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.966000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 682.932,
"heapDeltaBytes": 5653604,
"heapUsedBytes": 69656608,
"domNodes": 16,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 30.584000000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2022.420000000011,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.374999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 547.827,
"heapDeltaBytes": 5771360,
"heapUsedBytes": 70105828,
"domNodes": 20,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 23.267000000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1942.3649999999952,
"styleRecalcs": 75,
"styleRecalcDurationMs": 40.352,
"layouts": 12,
"layoutDurationMs": 3.7690000000000006,
"taskDurationMs": 937.878,
"heapDeltaBytes": 115096,
"heapUsedBytes": 64281400,
"domNodes": 57,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 143.403,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1862.1600000000171,
"styleRecalcs": 73,
"styleRecalcDurationMs": 37.515,
"layouts": 12,
"layoutDurationMs": 3.182,
"taskDurationMs": 931.907,
"heapDeltaBytes": -13997804,
"heapUsedBytes": 50069692,
"domNodes": -282,
"jsHeapTotalBytes": 23310336,
"scriptDurationMs": 128.964,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.1859999999983,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.618000000000002,
"layouts": 6,
"layoutDurationMs": 0.5760000000000001,
"taskDurationMs": 428.20200000000006,
"heapDeltaBytes": 8676696,
"heapUsedBytes": 72759208,
"domNodes": 79,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 25.781,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1749.7950000000628,
"styleRecalcs": 30,
"styleRecalcDurationMs": 21.557999999999996,
"layouts": 6,
"layoutDurationMs": 0.735,
"taskDurationMs": 519.2280000000001,
"heapDeltaBytes": 8683332,
"heapUsedBytes": 72800396,
"domNodes": 75,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 29.27,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 598.5709999999926,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.294000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.97499999999997,
"heapDeltaBytes": -10933020,
"heapUsedBytes": 53123152,
"domNodes": 18,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 65.924,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 660.5220000000145,
"styleRecalcs": 12,
"styleRecalcDurationMs": 11.001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.431,
"heapDeltaBytes": -10950660,
"heapUsedBytes": 53199728,
"domNodes": 20,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 62.73999999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2048.0019999999968,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.109,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 814.561,
"heapDeltaBytes": 6171580,
"heapUsedBytes": 66108184,
"domNodes": -283,
"jsHeapTotalBytes": 2465792,
"scriptDurationMs": 128.405,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2035.8889999999974,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.498,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 779.9200000000001,
"heapDeltaBytes": 6732160,
"heapUsedBytes": 66171192,
"domNodes": -283,
"jsHeapTotalBytes": 3776512,
"scriptDurationMs": 125.79199999999999,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2320.9909999999923,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.947999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1397.637,
"heapDeltaBytes": 4849448,
"heapUsedBytes": 65325396,
"domNodes": -287,
"jsHeapTotalBytes": 4493312,
"scriptDurationMs": 469.65400000000005,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2285.5260000000044,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.092999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1405.962,
"heapDeltaBytes": -4738732,
"heapUsedBytes": 55777628,
"domNodes": -282,
"jsHeapTotalBytes": 5611520,
"scriptDurationMs": 477.52400000000006,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3462.040000000002,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.663,
"layouts": 60,
"layoutDurationMs": 7.666000000000001,
"taskDurationMs": 1655.5490000000002,
"heapDeltaBytes": 10966796,
"heapUsedBytes": 73550152,
"domNodes": -291,
"jsHeapTotalBytes": 5349376,
"scriptDurationMs": 589.4639999999999,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3459.4240000000127,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.677,
"layouts": 60,
"layoutDurationMs": 7.646,
"taskDurationMs": 1660.718,
"heapDeltaBytes": 11844592,
"heapUsedBytes": 73966140,
"domNodes": -289,
"jsHeapTotalBytes": 5611520,
"scriptDurationMs": 575.403,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2031.3989999999649,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.774000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 807.893,
"heapDeltaBytes": 6662568,
"heapUsedBytes": 67061296,
"domNodes": -284,
"jsHeapTotalBytes": 4300800,
"scriptDurationMs": 128.28799999999998,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2038.4230000000798,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.876000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 885.925,
"heapDeltaBytes": 4262368,
"heapUsedBytes": 65089404,
"domNodes": -283,
"jsHeapTotalBytes": 3514368,
"scriptDurationMs": 138.704,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.6619999999521,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.614999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.694,
"heapDeltaBytes": -10567824,
"heapUsedBytes": 53403940,
"domNodes": 20,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 122.443,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 614.1660000000684,
"styleRecalcs": 45,
"styleRecalcDurationMs": 11.011,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.134,
"heapDeltaBytes": -10750504,
"heapUsedBytes": 53342992,
"domNodes": 16,
"jsHeapTotalBytes": 26738688,
"scriptDurationMs": 123.268,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2004.5879999999556,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.729999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 561.353,
"heapDeltaBytes": 5106632,
"heapUsedBytes": 69279528,
"domNodes": 20,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 22.596000000000004,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2000.1979999999548,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.713,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 560.9470000000001,
"heapDeltaBytes": 4922272,
"heapUsedBytes": 68967360,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 22.235999999999997,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1674.568000000022,
"styleRecalcs": 75,
"styleRecalcDurationMs": 37.397,
"layouts": 16,
"layoutDurationMs": 4.868,
"taskDurationMs": 806.908,
"heapDeltaBytes": -3719124,
"heapUsedBytes": 60256020,
"domNodes": 61,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 101.11399999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.9619999999813,
"styleRecalcs": 77,
"styleRecalcDurationMs": 40.21900000000001,
"layouts": 16,
"layoutDurationMs": 5.163000000000001,
"taskDurationMs": 877.006,
"heapDeltaBytes": -3974812,
"heapUsedBytes": 60173572,
"domNodes": 62,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 106.754,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1433.4910000000036,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.951000000000008,
"layouts": 14,
"layoutDurationMs": 13.344000000000001,
"taskDurationMs": 1061.7189999999998,
"heapDeltaBytes": 30785196,
"heapUsedBytes": 100676424,
"domNodes": 13673,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 39.91299999999999,
"eventListeners": 2375,
"totalBlockingTimeMs": 155,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8593.95699999999,
"styleRecalcs": 251,
"styleRecalcDurationMs": 39.858000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4860.2119999999995,
"heapDeltaBytes": 12517696,
"heapUsedBytes": 71806424,
"domNodes": -279,
"jsHeapTotalBytes": 6328320,
"scriptDurationMs": 1513.413,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8740.692000000081,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.794000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4897.9,
"heapDeltaBytes": 14639988,
"heapUsedBytes": 74113520,
"domNodes": -285,
"jsHeapTotalBytes": 6066176,
"scriptDurationMs": 1492.547,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17603.324999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17573.98,
"heapDeltaBytes": -28531676,
"heapUsedBytes": 167965608,
"domNodes": -8312,
"jsHeapTotalBytes": -6234112,
"scriptDurationMs": 621.3,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 20061.034000000065,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20040.149,
"heapDeltaBytes": -40559816,
"heapUsedBytes": 165480600,
"domNodes": -8312,
"jsHeapTotalBytes": -10690560,
"scriptDurationMs": 675.658,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21617.06499999997,
"styleRecalcs": 152,
"styleRecalcDurationMs": 20.80599999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21572.531,
"heapDeltaBytes": -27276776,
"heapUsedBytes": 178450928,
"domNodes": -8312,
"jsHeapTotalBytes": -9449472,
"scriptDurationMs": 917.591,
"eventListeners": -16385,
"totalBlockingTimeMs": 355,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 24554.201999999917,
"styleRecalcs": 173,
"styleRecalcDurationMs": 25.99199999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24525.793999999998,
"heapDeltaBytes": -41226696,
"heapUsedBytes": 164301256,
"domNodes": -8312,
"jsHeapTotalBytes": -10428416,
"scriptDurationMs": 1081.316,
"eventListeners": -16383,
"totalBlockingTimeMs": 1295,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 459.52999999997246,
"styleRecalcs": 14,
"styleRecalcDurationMs": 19.134999999999998,
"layouts": 3,
"layoutDurationMs": 0.7579999999999998,
"taskDurationMs": 127.20400000000001,
"heapDeltaBytes": 5311772,
"heapUsedBytes": 68541408,
"domNodes": 136,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.315999999999999,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 465.48199999995177,
"styleRecalcs": 12,
"styleRecalcDurationMs": 19.069,
"layouts": 3,
"layoutDurationMs": 0.717,
"taskDurationMs": 118.43599999999999,
"heapDeltaBytes": 5082492,
"heapUsedBytes": 68280996,
"domNodes": 123,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 11.09,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughWorkflow loading now preserves unknown node types as error-marked placeholders with serialized data and replacement metadata. Missing-node warnings use workflow state with deferred display during asynchronous loading. Tests cover API loading, replacement, warning timing, drag-and-drop loading, and persistence. ChangesMissing-node workflow handling
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related issues
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@browser_tests/tests/workflowPersistence.spec.ts`:
- Around line 315-331: Consolidate the three separate polls around getNodes into
one retrying expect.poll assertion that validates the complete expected node
set: KSampler, EmptyLatentImage, and NonExistentCustomNode_XYZ_12345 with
hasErrors true. Preserve the existing node property checks while ensuring all
expectations are evaluated against the same page.evaluate result.
In `@src/scripts/app.test.ts`:
- Around line 1517-1542: Replace the `as never` casts in the `activeWorkflow`
assignments with a properly typed `LoadedComfyWorkflow` fixture or load the
workflow through the existing workflow-loading path. Ensure both
`realWorkflowStore.activeWorkflow` assignments type-check against
`LoadedComfyWorkflow | null` without using `any` or unsafe casts, while
preserving the test’s existing workflow behavior.
- Around line 967-979: Update the test around the deferred handleFile call to
assert that the active workflow’s pendingWarnings.missingNodeTypes contains the
expected UninstalledDeferredNode entry before invoking the immediate load. Keep
the existing missingNodesError assertions to verify deferred warnings remain
hidden initially and are later surfaced.
In `@src/scripts/app.ts`:
- Around line 2221-2266: In the node creation flow, replace the
`missingNodeIndex` bookkeeping with a direct reference variable initialized
before the `!node` branch. Assign it to the object returned by
`missingNodeTypes.push` for placeholder nodes, then update `nodeId` and
`last_serialization.id` through that reference after `app.rootGraph.add(node)`,
removing the indexed lookup and `typeof missingNodeType === 'object'` guard.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 96f43412-a702-4868-b0be-0555784ef171
📒 Files selected for processing (3)
browser_tests/tests/workflowPersistence.spec.tssrc/scripts/app.test.tssrc/scripts/app.ts
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #14555 +/- ##
==========================================
- Coverage 79.73% 79.52% -0.21%
==========================================
Files 1804 1804
Lines 125725 116192 -9533
Branches 38891 37832 -1059
==========================================
- Hits 100241 92403 -7838
+ Misses 24802 23243 -1559
+ Partials 682 546 -136
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 244 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…asts The deferred API JSON test asserted only that nothing surfaced during the deferred load, then re-derived the same warning from the same mock on the immediate load. Removing `updatePendingWarnings` from the deferred path left it green. Assert the active workflow's `pendingWarnings.missingNodeTypes` directly. Replace the `as never` casts on `activeWorkflow` with a `LoadedComfyWorkflow` fixture, following the idiom already used in workflowService.test.ts.
|
Applied two of the four, skipped two. Applied — deferred warnings assertion. Correct, and the gap was larger than described: the test ran with
So the test was blind to the exact regression it claimed to cover. Now asserts Applied — Skipped — consolidating the three Skipped — |
christian-byrne
left a comment
There was a problem hiding this comment.
note (non-blocking): useNodeReplacement.ts still calls useMissingNodesErrorStore().removeMissingNodesByType(replaced) directly after a node replacement, bypassing the pendingWarnings path that this PR routes missing-node errors through. If the missing-nodes panel is ever updated to read exclusively from pendingWarnings, replacements will silently fail to update the UI. The two stores are now partially duplicating missing-node display state -- worth reconciling in a follow-up. (Filing here because useNodeReplacement.ts is not in this diff.)
Address review feedback on the placeholder path:
- Build `widgets_values_named` with a null prototype. `LGraphNode.configure`
restores values via `widget.name in namedValues`, so an inherited key such as
`constructor` would match and assign the inherited value to a widget.
- Guard `data.inputs` with `?? {}`, matching `processNodeInputs`. `loadApiJson`
is public, so a caller can reach it with `inputs` absent at runtime.
- Track the pushed entry by reference instead of indexing by a pre-push length.
The index worked only because a resolved node read past the end and the
`typeof === 'object'` guard rejected `undefined`.
The deferred-warning test now flushes through `showPendingWarnings`, which is
what the drop handler actually calls; the previous second `handleFile` re-derived
the warning and so proved nothing about deferral. Tighten the E2E node count to
the fixture's exact 3.
|
Confirmed, and agreed it belongs in a follow-up rather than here.
Collecting three follow-ups from your two reviews:
None are introduced by this PR and each changes behaviour outside its thesis. I will file them rather than fold them in. |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
Updated from 1. 2. vi.mock('@/platform/workflow/core/services/workflowService', () => ({
useWorkflowService: vi.fn(() => mockWorkflowService)
}))Two tests here need the real implementation — the deferred-warning test flushes through async function useRealWorkflowService(): Promise<WorkflowService> {
const actual = await vi.importActual<...>('@/platform/workflow/core/services/workflowService')
const real = actual.useWorkflowService()
mockWorkflowService.beforeLoadNewGraph.mockImplementation(real.beforeLoadNewGraph)
mockWorkflowService.afterLoadNewGraph.mockImplementation(real.afterLoadNewGraph)
mockWorkflowService.showPendingWarnings.mockImplementation(real.showPendingWarnings)
return real
}No assertion from #14556 is modified. Verification. The deferred test still fails under both mutations it was written to catch, so the delegation is real and not just green:
Gates: unit 51/51, Running the whole Note for whoever merges #14557 after this: the same class of silent conflict applies there, with |
|
|
…s on API JSON import (#14555) (#14833) Backport of #14555 to this branch. Clean cherry-pick of `db147c098f` — no conflicts, no adjustments. **Verification on this branch:** `pnpm typecheck`, `pnpm typecheck:browser`, `pnpm lint` (0 errors) all pass; `src/scripts/app.test.ts` 51/51. The automation reported this branch as failed only because it batched with the `1.48` targets, which did conflict. Those are handled separately and required a real adjustment — see the `1.48` backport PRs.
… on API JSON import (#14555) (#14832) Backport of #14555 to this branch. Clean cherry-pick of `db147c098f` — no conflicts, no adjustments. **Verification on this branch:** `pnpm typecheck`, `pnpm typecheck:browser`, `pnpm lint` (0 errors) all pass; `src/scripts/app.test.ts` 51/51. The automation reported this branch as failed only because it batched with the `1.48` targets, which did conflict. Those are handled separately and required a real adjustment — see the `1.48` backport PRs.
|
|
|
|
Splits out of #14251, which was doing four things at once. This is one of them.
What
An API-format (prompt-format) JSON references node types by
class_type. When one of those types is not installed,loadApiJsondidif (!node) continue— the node was dropped, and the missing type was reported to the Issues panel as a bare string.A bare string has no
nodeId, so nothing can retire it:removeMissingNodesByNodeIdandremoveMissingNodesByPrefixboth preserve strings by design,onNodeRemovedcannot fire because there is no node, andMissingPackGroupRowrenders no Locate action. The entry outlived everything except a full workflow reload.Now the node is built from the data instead of being skipped. API format is what gets submitted to the server, so it carries every input by name — either a literal or a link:
For an uninstalled type we do not have the node definition, but we do not need it — the names are in the data. Each link input becomes a named wildcard slot so
processNodeInputscan resolve it; each literal is preserved inwidgets_values_named(keyed, exact) alongsidewidgets_values(positional, for the existing replacement path).last_serializationcarries the real content, and the node'sinputsare re-synced after links resolve.The result is a node on the canvas that is a faithful record of what the JSON said, flagged
has_errors, with a realnodeId. Locate works, deleting it retires the entry, and Replace has something to work from.The E2E assertion this flips
workflowPersistence.spec.tsasserted the unknown type was absent from the graph. That assertion was never a requirement. Its own annotation says what it guards:The regression was that the whole workflow failed to load. The test is named "partially loads", and the requirements are the two
toContainassertions — the known nodes appear. The.not.toContainwas the adjacent comment ("unknown node skipped") frozen into an assertion: a description of theif (!node) continueimplementation, not a decision. It is updated to assert the placeholder is present withhas_errors.Verification
workflowPersistencePlaywright spec run against a local backend: 14/14.Known limitation
The placeholder cannot reproduce a positional
widgets_valuesfaithfully without the node definition, which is why the keyed form is the source of truth. If a replacement node's widget names differ from the API input names, Replace will not map them — that mapping does not exist today and is out of scope here.Related
Screenshot