Repository navigation
[backport core/1.48] fix(workflow): build nodes for uninstalled types on API JSON import (#14555) - #14834
[backport core/1.48] fix(workflow): build nodes for uninstalled types on API JSON import (#14555)#14834jaeone94 wants to merge 1 commit into
Conversation
…14555) Backport of #14555 to core/1.48. Backport adjustments: - Drop `widgets_values_named` from the placeholder's `last_serialization`. The field was introduced by #10392, which is on 1.49 and main but not on 1.48, so `ISerialisedNode` has no such property here. This branch restores widget values positionally only (`LGraphNode.configure` reads `info.widgets_values[i++]` and has no named-restore path), so the field would have been dead data. - Drop four imports the cherry-pick pulled into `app.test.ts` for tests that live on main but not on this branch (telemetry registry, execution context, `createNodeExecutionId`). - Adapt the two placeholder-serialization assertions to positional values.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1767 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-06T06:04:47.451Z",
"gitSha": "cfe7604b41505adb440869cecff019a300313be6",
"branch": "backport-14555-to-core-1.48",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2101.3379999999984,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.088999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 585.1579999999999,
"heapDeltaBytes": 3445912,
"heapUsedBytes": 71306408,
"domNodes": 18,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 18.921,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2051.2209999999413,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.929999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.364,
"heapDeltaBytes": 3931040,
"heapUsedBytes": 71883496,
"domNodes": 18,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 15.152,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1824.2219999999634,
"styleRecalcs": 74,
"styleRecalcDurationMs": 36.946,
"layouts": 12,
"layoutDurationMs": 3.791,
"taskDurationMs": 870.5240000000001,
"heapDeltaBytes": -14128268,
"heapUsedBytes": 53739968,
"domNodes": -276,
"jsHeapTotalBytes": 20443136,
"scriptDurationMs": 112.251,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1823.5069999999496,
"styleRecalcs": 75,
"styleRecalcDurationMs": 35.277,
"layouts": 12,
"layoutDurationMs": 3.6029999999999993,
"taskDurationMs": 852.043,
"heapDeltaBytes": -14299196,
"heapUsedBytes": 53740516,
"domNodes": -275,
"jsHeapTotalBytes": 20967424,
"scriptDurationMs": 108.98,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1752.8429999999844,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.684999999999997,
"layouts": 6,
"layoutDurationMs": 0.575,
"taskDurationMs": 367.497,
"heapDeltaBytes": 7288268,
"heapUsedBytes": 75143724,
"domNodes": 78,
"jsHeapTotalBytes": 20578304,
"scriptDurationMs": 17.903000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1734.3600000000379,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.043,
"layouts": 6,
"layoutDurationMs": 0.565,
"taskDurationMs": 355.96000000000004,
"heapDeltaBytes": 7279908,
"heapUsedBytes": 75185772,
"domNodes": 77,
"jsHeapTotalBytes": 20054016,
"scriptDurationMs": 17.194999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 573.2580000000098,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.635999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.31,
"heapDeltaBytes": -12408684,
"heapUsedBytes": 55546892,
"domNodes": 18,
"jsHeapTotalBytes": 21626880,
"scriptDurationMs": 56.608,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 595.6599999999526,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.916999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.15799999999996,
"heapDeltaBytes": -12226428,
"heapUsedBytes": 55830428,
"domNodes": 22,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 52.274,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2032.8839999999673,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.798000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 657.592,
"heapDeltaBytes": 6914736,
"heapUsedBytes": 65999544,
"domNodes": -276,
"jsHeapTotalBytes": 4521984,
"scriptDurationMs": 92.71300000000002,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2038.314000000014,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.953000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 654.5529999999999,
"heapDeltaBytes": 7393860,
"heapUsedBytes": 65998384,
"domNodes": -275,
"jsHeapTotalBytes": 4784128,
"scriptDurationMs": 89.18799999999999,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2177.455000000009,
"styleRecalcs": 70,
"styleRecalcDurationMs": 15.305000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1206.081,
"heapDeltaBytes": 5144228,
"heapUsedBytes": 65192956,
"domNodes": -275,
"jsHeapTotalBytes": 4726784,
"scriptDurationMs": 401.314,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2154.7649999999976,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.421,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1205.504,
"heapDeltaBytes": 5231184,
"heapUsedBytes": 65319212,
"domNodes": -279,
"jsHeapTotalBytes": 4988928,
"scriptDurationMs": 392.896,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3192.3909999999864,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.674000000000003,
"layouts": 60,
"layoutDurationMs": 7.908999999999999,
"taskDurationMs": 1472.041,
"heapDeltaBytes": -3456952,
"heapUsedBytes": 57949912,
"domNodes": -279,
"jsHeapTotalBytes": 8192000,
"scriptDurationMs": 514.591,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3180.872000000022,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.615,
"layouts": 60,
"layoutDurationMs": 7.908,
"taskDurationMs": 1482.6999999999998,
"heapDeltaBytes": -3945128,
"heapUsedBytes": 57923988,
"domNodes": -280,
"jsHeapTotalBytes": 6881280,
"scriptDurationMs": 514.764,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.5119999999965,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.047999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 663.465,
"heapDeltaBytes": 6289212,
"heapUsedBytes": 67041080,
"domNodes": -277,
"jsHeapTotalBytes": 5046272,
"scriptDurationMs": 91.416,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2014.536000000021,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.7769999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 679.6589999999999,
"heapDeltaBytes": 6030828,
"heapUsedBytes": 67038836,
"domNodes": -278,
"jsHeapTotalBytes": 4521984,
"scriptDurationMs": 98.34899999999999,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.8780000000038,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.761000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.923,
"heapDeltaBytes": -12204392,
"heapUsedBytes": 55846184,
"domNodes": 20,
"jsHeapTotalBytes": 22151168,
"scriptDurationMs": 121.41000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 584.7529999999779,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.066999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.85400000000004,
"heapDeltaBytes": -11799148,
"heapUsedBytes": 56169432,
"domNodes": 22,
"jsHeapTotalBytes": 21626880,
"scriptDurationMs": 125.81200000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2026.7259999999965,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.905000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.809,
"heapDeltaBytes": -22407900,
"heapUsedBytes": 45710256,
"domNodes": -273,
"jsHeapTotalBytes": 20443136,
"scriptDurationMs": 12.692,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1994.4370000000617,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.2730000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.87200000000007,
"heapDeltaBytes": 3377116,
"heapUsedBytes": 71521516,
"domNodes": 20,
"jsHeapTotalBytes": 21102592,
"scriptDurationMs": 13.078999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1727.9970000000162,
"styleRecalcs": 75,
"styleRecalcDurationMs": 34.836000000000006,
"layouts": 16,
"layoutDurationMs": 3.9639999999999995,
"taskDurationMs": 729.606,
"heapDeltaBytes": -5456008,
"heapUsedBytes": 62660284,
"domNodes": 63,
"jsHeapTotalBytes": 20840448,
"scriptDurationMs": 83.926,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1739.4090000000233,
"styleRecalcs": 75,
"styleRecalcDurationMs": 33.007,
"layouts": 16,
"layoutDurationMs": 4.105,
"taskDurationMs": 762.7230000000001,
"heapDeltaBytes": -19190388,
"heapUsedBytes": 48926364,
"domNodes": -274,
"jsHeapTotalBytes": 20967424,
"scriptDurationMs": 85.13600000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.251000000063,
"styleRecalcs": 19,
"styleRecalcDurationMs": 28.865999999999996,
"layouts": 15,
"layoutDurationMs": 11.372,
"taskDurationMs": 899.9849999999998,
"heapDeltaBytes": 29152304,
"heapUsedBytes": 96716848,
"domNodes": 13673,
"jsHeapTotalBytes": 15990784,
"scriptDurationMs": 41.43899999999999,
"eventListeners": 2375,
"totalBlockingTimeMs": 118,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8177.9149999999845,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.788000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4154.919000000001,
"heapDeltaBytes": 9953384,
"heapUsedBytes": 68836092,
"domNodes": -276,
"jsHeapTotalBytes": 6561792,
"scriptDurationMs": 1277.719,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8261.901999999964,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.080999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4255.26,
"heapDeltaBytes": 10233096,
"heapUsedBytes": 69648408,
"domNodes": -277,
"jsHeapTotalBytes": 6270976,
"scriptDurationMs": 1312.665,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17320.787999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17284.961,
"heapDeltaBytes": -52278904,
"heapUsedBytes": 155801600,
"domNodes": -8312,
"jsHeapTotalBytes": -13045760,
"scriptDurationMs": 557.344,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17314.63199999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17276.709,
"heapDeltaBytes": -57660988,
"heapUsedBytes": 167060828,
"domNodes": -8312,
"jsHeapTotalBytes": -13307904,
"scriptDurationMs": 556.053,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21713.26400000004,
"styleRecalcs": 156,
"styleRecalcDurationMs": 20.46899999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21689.986,
"heapDeltaBytes": -56342028,
"heapUsedBytes": 164233548,
"domNodes": -8312,
"jsHeapTotalBytes": -15138816,
"scriptDurationMs": 917.5649999999999,
"eventListeners": -16383,
"totalBlockingTimeMs": 311,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21152.150000000005,
"styleRecalcs": 143,
"styleRecalcDurationMs": 18.998999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21125.007999999998,
"heapDeltaBytes": -35018496,
"heapUsedBytes": 166271580,
"domNodes": -8312,
"jsHeapTotalBytes": -15900672,
"scriptDurationMs": 894.5529999999999,
"eventListeners": -16381,
"totalBlockingTimeMs": 319,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 484.6790000000283,
"styleRecalcs": 13,
"styleRecalcDurationMs": 19.161,
"layouts": 3,
"layoutDurationMs": 0.6809999999999999,
"taskDurationMs": 123.234,
"heapDeltaBytes": -15665176,
"heapUsedBytes": 51469996,
"domNodes": 130,
"jsHeapTotalBytes": 7471104,
"scriptDurationMs": 10.719999999999999,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 459.84999999996035,
"styleRecalcs": 13,
"styleRecalcDurationMs": 17.651,
"layouts": 2,
"layoutDurationMs": 0.41300000000000014,
"taskDurationMs": 103.41300000000001,
"heapDeltaBytes": -16201472,
"heapUsedBytes": 51051232,
"domNodes": 117,
"jsHeapTotalBytes": 7471104,
"scriptDurationMs": 8.894,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.48 #14834 +/- ##
=============================================
+ Coverage 79.53% 79.56% +0.02%
=============================================
Files 1749 1749
Lines 99628 99652 +24
Branches 31923 31927 +4
=============================================
+ Hits 79239 79286 +47
+ Misses 19988 19967 -21
+ Partials 401 399 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
cloud/1.48 isn't shipping, cloud/1.49 is shipping today afternoon. |
Backport of #14555 to this branch. The automation could not do this one — see below.
Why the auto-backport failed
The bot reported a cherry-pick conflict in
src/scripts/app.test.ts. That is real but superficial: all three hunks are import-block conflicts, because this branch'sapp.test.tshas a much smaller import list thanmain(several PRs that touched that file were never backported here), so the diff context does not line up.The blocking problem was underneath, and only surfaced at typecheck:
widgets_values_namedwas introduced by #10392 ("Implement widgets_values_named for serialization"). It is present on1.49andmain, and absent here:widgets_values_namedinserialisation.tsSo a literal cherry-pick does not compile on
1.48regardless of how the import conflict is resolved.Adjustments made
1. Dropped
widgets_values_namedfrom the placeholder'slast_serialization. Not a behaviour loss on this branch:LGraphNode.configurehere restores widget values positionally only —— with no named-restore path (
namedValuesRestoreand thewidgets_values_namedread arrive with #10392). The field would have been written and never read. The placeholder still carries its values positionally, its input slots, and its links, which is the substance of the fix.2. Resolved the three import conflicts by taking the incoming side, which is a superset of what this branch had, then removed four imports whose consuming tests only exist on
main:setTelemetryRegistry,TelemetryRegistry,executionContextUtils,createNodeExecutionId.3. Adapted two assertions in the placeholder-serialization test from
widgets_values+widgets_values_namedto positionalwidgets_valuesonly.Verification
pnpm typecheck,pnpm typecheck:browser,pnpm format,pnpm lint(0 errors) all pass.src/scripts/app.test.ts42/42.