Repository navigation
[backport core/1.49] fix(workflow): build nodes for uninstalled types on API JSON import (#14555) - #14832
Conversation
…14555) Splits out of #14251, which was doing four things at once. This is one of them. ## What An API-format (prompt-format) JSON references node types by `class_type`. When one of those types is not installed, `loadApiJson` did `if (!node) continue` — the node was dropped, and the missing type was reported to the Issues panel as a bare string. A bare string has no `nodeId`, so nothing can retire it: `removeMissingNodesByNodeId` and `removeMissingNodesByPrefix` both preserve strings by design, `onNodeRemoved` cannot fire because there is no node, and `MissingPackGroupRow` renders no Locate action. The entry outlived everything except a full workflow reload. Now the node is built from the data instead of being skipped. API format is what gets submitted to the server, so it carries every input by name — either a literal or a link: ```json "3": { "class_type": "PreviewImage", "inputs": { "images": ["4", 0] } } "4": { "class_type": "EmptyLatentImage", "inputs": { "width": 512, "height": 512 } } ``` For an uninstalled type we do not have the node definition, but we do not need it — the names are in the data. Each link input becomes a named wildcard slot so `processNodeInputs` can resolve it; each literal is preserved in `widgets_values_named` (keyed, exact) alongside `widgets_values` (positional, for the existing replacement path). `last_serialization` carries the real content, and the node's `inputs` are re-synced after links resolve. The result is a node on the canvas that is a faithful record of what the JSON said, flagged `has_errors`, with a real `nodeId`. Locate works, deleting it retires the entry, and Replace has something to work from. ## The E2E assertion this flips `workflowPersistence.spec.ts` asserted the unknown type was **absent** from the graph. That assertion was never a requirement. Its own annotation says what it guards: > `PR #9694 — loadApiJson early-returned on missing node types` The regression was that the *whole workflow* failed to load. The test is named "partially loads", and the requirements are the two `toContain` assertions — the known nodes appear. The `.not.toContain` was the adjacent comment ("unknown node skipped") frozen into an assertion: a description of the `if (!node) continue` implementation, not a decision. It is updated to assert the placeholder is present with `has_errors`. ## Verification - 5 unit tests, each mutation-proved: revert the production line, watch the named assertion fail, restore, watch it pass. Removing the slot creation fails the link assertion; removing the value carry fails the widget-values assertion. - `workflowPersistence` Playwright spec run against a local backend: **14/14**. - typecheck, lint, format, knip clean. ## Known limitation The placeholder cannot reproduce a *positional* `widgets_values` faithfully without the node definition, which is why the keyed form is the source of truth. If a replacement node's widget names differ from the API input names, Replace will not map them — that mapping does not exist today and is out of scope here. ## Related - Follow-up to #14251 (closed) - Lands before the narrow submission fix, which removes the last thing that currently retires an anchor-less entry ## Screenshot <img width="1450" height="892" alt="스크린샷 2026-08-03 오후 1 45 56" src="https://github.com/user-attachments/assets/2a80eddd-5fa9-4201-9e19-d510e532f67e" />
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1785 passed, 0 failed · 3 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-06T06:04:51.192Z",
"gitSha": "0cc94086d46feee92c5a14ce8b7b143b2c457f8b",
"branch": "backport-14555-to-core-1.49",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2050.212999999985,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.135000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 549.6419999999999,
"heapDeltaBytes": 5184772,
"heapUsedBytes": 73426576,
"domNodes": 18,
"jsHeapTotalBytes": 20041728,
"scriptDurationMs": 23.612,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2032.7540000000113,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.304000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.559,
"heapDeltaBytes": 5237612,
"heapUsedBytes": 73485812,
"domNodes": 16,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 14.110000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2061.762999999985,
"styleRecalcs": 78,
"styleRecalcDurationMs": 48.08800000000001,
"layouts": 12,
"layoutDurationMs": 4.715,
"taskDurationMs": 1110.3039999999999,
"heapDeltaBytes": -15989636,
"heapUsedBytes": 52306080,
"domNodes": -280,
"jsHeapTotalBytes": 21217280,
"scriptDurationMs": 138.998,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1770.4120000000785,
"styleRecalcs": 72,
"styleRecalcDurationMs": 33.071000000000005,
"layouts": 12,
"layoutDurationMs": 3.3900000000000006,
"taskDurationMs": 812.466,
"heapDeltaBytes": -445464,
"heapUsedBytes": 67899588,
"domNodes": 54,
"jsHeapTotalBytes": 21090304,
"scriptDurationMs": 118.335,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1675.9870000000205,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.243000000000002,
"layouts": 6,
"layoutDurationMs": 0.5670000000000001,
"taskDurationMs": 374.783,
"heapDeltaBytes": 7852728,
"heapUsedBytes": 76058528,
"domNodes": 79,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 16.938999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1748.9170000000058,
"styleRecalcs": 31,
"styleRecalcDurationMs": 22.614999999999995,
"layouts": 6,
"layoutDurationMs": 0.76,
"taskDurationMs": 521.741,
"heapDeltaBytes": 7843224,
"heapUsedBytes": 76061756,
"domNodes": 76,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 31.835,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 596.494000000007,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.040999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.336,
"heapDeltaBytes": -12229660,
"heapUsedBytes": 56030232,
"domNodes": 20,
"jsHeapTotalBytes": 20828160,
"scriptDurationMs": 63.332,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 608.5100000000239,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.74,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.315,
"heapDeltaBytes": -12471104,
"heapUsedBytes": 55735932,
"domNodes": 18,
"jsHeapTotalBytes": 22401024,
"scriptDurationMs": 63.907000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2039.166000000023,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.33,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 681.7299999999999,
"heapDeltaBytes": 8393444,
"heapUsedBytes": 67749708,
"domNodes": -283,
"jsHeapTotalBytes": 5038080,
"scriptDurationMs": 101.93599999999998,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2034.4299999999294,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.414000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 672.059,
"heapDeltaBytes": 8189684,
"heapUsedBytes": 67692644,
"domNodes": -283,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 104.23100000000002,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2167.0330000000035,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.701999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1253.7530000000002,
"heapDeltaBytes": 5689444,
"heapUsedBytes": 66016544,
"domNodes": -283,
"jsHeapTotalBytes": 4739072,
"scriptDurationMs": 422.59499999999997,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2178.841000000034,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.791,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1278.505,
"heapDeltaBytes": 4987300,
"heapUsedBytes": 65773832,
"domNodes": -286,
"jsHeapTotalBytes": 5001216,
"scriptDurationMs": 436.3,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3180.723999999998,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.132,
"layouts": 60,
"layoutDurationMs": 7.086,
"taskDurationMs": 1478.561,
"heapDeltaBytes": -1703428,
"heapUsedBytes": 60583672,
"domNodes": -292,
"jsHeapTotalBytes": 6873088,
"scriptDurationMs": 518.6729999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3165.134999999964,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.146000000000003,
"layouts": 60,
"layoutDurationMs": 7.2139999999999995,
"taskDurationMs": 1475.838,
"heapDeltaBytes": 24101576,
"heapUsedBytes": 85946604,
"domNodes": 14,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 535.13,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2050.326000000041,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.732000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 674.6419999999999,
"heapDeltaBytes": 8332296,
"heapUsedBytes": 70718316,
"domNodes": -284,
"jsHeapTotalBytes": 5038080,
"scriptDurationMs": 99.462,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2035.0819999999885,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.990000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 872.294,
"heapDeltaBytes": 7890844,
"heapUsedBytes": 69709732,
"domNodes": -286,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 132.84099999999998,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 612.5059999999962,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.152000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.1859999999999,
"heapDeltaBytes": -10840032,
"heapUsedBytes": 57339300,
"domNodes": 20,
"jsHeapTotalBytes": 21352448,
"scriptDurationMs": 119.446,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 703.6920000000464,
"styleRecalcs": 44,
"styleRecalcDurationMs": 10.215000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.14700000000005,
"heapDeltaBytes": -10957912,
"heapUsedBytes": 57417272,
"domNodes": 14,
"jsHeapTotalBytes": 21352448,
"scriptDurationMs": 134.11900000000003,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2037.9630000000475,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.521,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 579.442,
"heapDeltaBytes": -21006688,
"heapUsedBytes": 47211704,
"domNodes": -282,
"jsHeapTotalBytes": 20168704,
"scriptDurationMs": 20.270999999999997,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2014.6980000000667,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.890999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.862,
"heapDeltaBytes": 4802788,
"heapUsedBytes": 73191532,
"domNodes": 20,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 12.230999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.5229999999942,
"styleRecalcs": 76,
"styleRecalcDurationMs": 38.836999999999996,
"layouts": 16,
"layoutDurationMs": 4.569,
"taskDurationMs": 787.9860000000001,
"heapDeltaBytes": -4514872,
"heapUsedBytes": 63657084,
"domNodes": 62,
"jsHeapTotalBytes": 20566016,
"scriptDurationMs": 94.21700000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.2670000000253,
"styleRecalcs": 76,
"styleRecalcDurationMs": 34.616,
"layouts": 16,
"layoutDurationMs": 4.46,
"taskDurationMs": 799.6620000000001,
"heapDeltaBytes": -19816692,
"heapUsedBytes": 48330168,
"domNodes": -281,
"jsHeapTotalBytes": 20168704,
"scriptDurationMs": 87.198,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.700000000029,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.872999999999998,
"layouts": 13,
"layoutDurationMs": 12.014000000000001,
"taskDurationMs": 908.879,
"heapDeltaBytes": 32835392,
"heapUsedBytes": 100027872,
"domNodes": 13673,
"jsHeapTotalBytes": 14155776,
"scriptDurationMs": 34.33,
"eventListeners": 2375,
"totalBlockingTimeMs": 138,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8289.894000000004,
"styleRecalcs": 248,
"styleRecalcDurationMs": 33.57299999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4446.52,
"heapDeltaBytes": 27434328,
"heapUsedBytes": 86974976,
"domNodes": -282,
"jsHeapTotalBytes": 7098368,
"scriptDurationMs": 1368.63,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8897.422000000006,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.96,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5169.304,
"heapDeltaBytes": 21152412,
"heapUsedBytes": 80872744,
"domNodes": -283,
"jsHeapTotalBytes": 8900608,
"scriptDurationMs": 1715.5790000000002,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17260.671000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17242.573,
"heapDeltaBytes": -41944728,
"heapUsedBytes": 172030644,
"domNodes": -8312,
"jsHeapTotalBytes": -4661248,
"scriptDurationMs": 562.8499999999999,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 13804.227000000083,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13782.604999999998,
"heapDeltaBytes": -31336044,
"heapUsedBytes": 181439364,
"domNodes": -8312,
"jsHeapTotalBytes": -3874816,
"scriptDurationMs": 590.835,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20504.76199999997,
"styleRecalcs": 138,
"styleRecalcDurationMs": 15.08799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20458.154,
"heapDeltaBytes": -44402028,
"heapUsedBytes": 179594144,
"domNodes": -8312,
"jsHeapTotalBytes": -10498048,
"scriptDurationMs": 849.872,
"eventListeners": -16381,
"totalBlockingTimeMs": 92,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 23039.24100000006,
"styleRecalcs": 171,
"styleRecalcDurationMs": 25.815000000000033,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22995.329999999998,
"heapDeltaBytes": -68629192,
"heapUsedBytes": 154163620,
"domNodes": -8312,
"jsHeapTotalBytes": -11214848,
"scriptDurationMs": 1003.0049999999999,
"eventListeners": -16383,
"totalBlockingTimeMs": 477,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 472.2360000000094,
"styleRecalcs": 16,
"styleRecalcDurationMs": 23.406999999999996,
"layouts": 3,
"layoutDurationMs": 1.1300000000000001,
"taskDurationMs": 136.17499999999998,
"heapDeltaBytes": -15890624,
"heapUsedBytes": 51668044,
"domNodes": 136,
"jsHeapTotalBytes": 7720960,
"scriptDurationMs": 10.700999999999999,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 475.24699999996756,
"styleRecalcs": 15,
"styleRecalcDurationMs": 22.799,
"layouts": 3,
"layoutDurationMs": 0.8089999999999998,
"taskDurationMs": 131.585,
"heapDeltaBytes": -15608348,
"heapUsedBytes": 51915624,
"domNodes": 123,
"jsHeapTotalBytes": 7196672,
"scriptDurationMs": 10.571,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.49 #14832 +/- ##
=============================================
+ Coverage 78.76% 78.83% +0.06%
=============================================
Files 1791 1791
Lines 104559 104585 +26
Branches 32070 32077 +7
=============================================
+ Hits 82359 82448 +89
+ Misses 21770 21708 -62
+ Partials 430 429 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #14555 to this branch.
Clean cherry-pick of
db147c098f— no conflicts, no adjustments.Verification on this branch:
pnpm typecheck,pnpm typecheck:browser,pnpm lint(0 errors) all pass;src/scripts/app.test.ts51/51.The automation reported this branch as failed only because it batched with the
1.48targets, which did conflict. Those are handled separately and required a real adjustment — see the1.48backport PRs.