Repository navigation
Conversation
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 8.19 MB gzip 🔴 +123 BDetailsSummary
Category Glance App Entry Points — 3.62 kB (baseline 3.62 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.29 MB (baseline 1.29 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 1 unchanged Views & Navigation — 111 kB (baseline 111 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 12 added / 12 removed / 4 unchanged Panels & Settings — 551 kB (baseline 551 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 15 unchanged User & Accounts — 28.7 kB (baseline 28.7 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 3 unchanged Editors & Dialogs — 124 kB (baseline 124 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 6 added / 6 removed / 1 unchanged UI Components — 70 kB (baseline 70 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 9 unchanged Data & Services — 3.44 MB (baseline 3.44 MB) • 🔴 +304 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 386 kB (baseline 386 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 16 added / 16 removed / 20 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 12.7 MB (baseline 12.7 MB) • ⚪ 0 BBundles that do not match a named category
Status: 70 added / 70 removed / 210 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-07-31T07:57:31.425Z",
"gitSha": "4da54f71d9d88846b9092085061c68179095978f",
"branch": "jaeone94/errors-node-pack-lifecycle",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2104.719999999986,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.476999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.2610000000001,
"heapDeltaBytes": 4945404,
"heapUsedBytes": 72760512,
"domNodes": 18,
"jsHeapTotalBytes": 20574208,
"scriptDurationMs": 15.674999999999997,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2028.8470000000416,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.145999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.38300000000004,
"heapDeltaBytes": 4624504,
"heapUsedBytes": 72463268,
"domNodes": 20,
"jsHeapTotalBytes": 20574208,
"scriptDurationMs": 13.526000000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1747.3410000000058,
"styleRecalcs": 73,
"styleRecalcDurationMs": 28.610999999999997,
"layouts": 12,
"layoutDurationMs": 3.3,
"taskDurationMs": 673.355,
"heapDeltaBytes": -1108440,
"heapUsedBytes": 66814660,
"domNodes": 55,
"jsHeapTotalBytes": 21098496,
"scriptDurationMs": 89.427,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1776.2010000000146,
"styleRecalcs": 72,
"styleRecalcDurationMs": 27.976,
"layouts": 12,
"layoutDurationMs": 3.3659999999999997,
"taskDurationMs": 730.46,
"heapDeltaBytes": -18259604,
"heapUsedBytes": 49757320,
"domNodes": -279,
"jsHeapTotalBytes": 20963328,
"scriptDurationMs": 87.954,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.3449999999812,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.357000000000001,
"layouts": 6,
"layoutDurationMs": 0.626,
"taskDurationMs": 319.159,
"heapDeltaBytes": 8027192,
"heapUsedBytes": 75849616,
"domNodes": 78,
"jsHeapTotalBytes": 19787776,
"scriptDurationMs": 15.477999999999998,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1684.4260000000304,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.482999999999999,
"layouts": 6,
"layoutDurationMs": 0.6719999999999998,
"taskDurationMs": 340.431,
"heapDeltaBytes": 7820504,
"heapUsedBytes": 75787540,
"domNodes": 77,
"jsHeapTotalBytes": 21098496,
"scriptDurationMs": 16.438000000000002,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 511.9109999999978,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.774999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 315.454,
"heapDeltaBytes": -12117140,
"heapUsedBytes": 55569220,
"domNodes": 20,
"jsHeapTotalBytes": 21884928,
"scriptDurationMs": 45.839999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 535.3420000000142,
"styleRecalcs": 13,
"styleRecalcDurationMs": 5.9030000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 311.17,
"heapDeltaBytes": -12126048,
"heapUsedBytes": 55831844,
"domNodes": 22,
"jsHeapTotalBytes": 21098496,
"scriptDurationMs": 43.49,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2030.9680000000299,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.7429999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 587.146,
"heapDeltaBytes": 7712580,
"heapUsedBytes": 66689096,
"domNodes": -281,
"jsHeapTotalBytes": 3993600,
"scriptDurationMs": 77.25,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2035.0179999999227,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.556,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.219,
"heapDeltaBytes": 8128804,
"heapUsedBytes": 67381228,
"domNodes": -281,
"jsHeapTotalBytes": 5042176,
"scriptDurationMs": 75.911,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2100.213999999994,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.040000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1068.7669999999998,
"heapDeltaBytes": 5662524,
"heapUsedBytes": 65586560,
"domNodes": -282,
"jsHeapTotalBytes": 5005312,
"scriptDurationMs": 343.221,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2135.475999999926,
"styleRecalcs": 70,
"styleRecalcDurationMs": 13.256999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1058.378,
"heapDeltaBytes": 4870492,
"heapUsedBytes": 64620996,
"domNodes": -279,
"jsHeapTotalBytes": 5267456,
"scriptDurationMs": 330.887,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3134.2930000000138,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.205,
"layouts": 60,
"layoutDurationMs": 8.416,
"taskDurationMs": 1304.431,
"heapDeltaBytes": -5038752,
"heapUsedBytes": 56404644,
"domNodes": -286,
"jsHeapTotalBytes": 7925760,
"scriptDurationMs": 407.258,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3067.481999999927,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.711999999999998,
"layouts": 60,
"layoutDurationMs": 8.373,
"taskDurationMs": 1228.2190000000003,
"heapDeltaBytes": 22864852,
"heapUsedBytes": 85722408,
"domNodes": 10,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 392.835,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2031.6060000000107,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.422999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 579.886,
"heapDeltaBytes": 7644928,
"heapUsedBytes": 68203596,
"domNodes": -282,
"jsHeapTotalBytes": 5042176,
"scriptDurationMs": 74.661,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2021.1210000001074,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.549000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 576.2669999999999,
"heapDeltaBytes": 8122864,
"heapUsedBytes": 68857268,
"domNodes": -281,
"jsHeapTotalBytes": 3993600,
"scriptDurationMs": 75.01,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 536.2409999999613,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.230999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 323.84000000000003,
"heapDeltaBytes": -11856440,
"heapUsedBytes": 56066468,
"domNodes": 22,
"jsHeapTotalBytes": 22147072,
"scriptDurationMs": 91.47,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 518.9080000000104,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.036000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 328.86400000000003,
"heapDeltaBytes": -11815776,
"heapUsedBytes": 56227548,
"domNodes": 20,
"jsHeapTotalBytes": 22147072,
"scriptDurationMs": 92.503,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 1999.1489999999885,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.690999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.02,
"heapDeltaBytes": 4620416,
"heapUsedBytes": 72718720,
"domNodes": 22,
"jsHeapTotalBytes": 20836352,
"scriptDurationMs": 12.365,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2009.3100000000277,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.979000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.501,
"heapDeltaBytes": -21200480,
"heapUsedBytes": 46629316,
"domNodes": -278,
"jsHeapTotalBytes": 21487616,
"scriptDurationMs": 12.581000000000001,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1716.0729999999944,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.873,
"layouts": 16,
"layoutDurationMs": 3.4729999999999994,
"taskDurationMs": 620.342,
"heapDeltaBytes": -4635376,
"heapUsedBytes": 63351612,
"domNodes": 66,
"jsHeapTotalBytes": 20836352,
"scriptDurationMs": 63.580999999999996,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1688.908999999967,
"styleRecalcs": 76,
"styleRecalcDurationMs": 27.826999999999998,
"layouts": 16,
"layoutDurationMs": 3.2630000000000003,
"taskDurationMs": 635.019,
"heapDeltaBytes": -4876016,
"heapUsedBytes": 63168048,
"domNodes": 65,
"jsHeapTotalBytes": 21098496,
"scriptDurationMs": 64.111,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 916.2959999999885,
"styleRecalcs": 19,
"styleRecalcDurationMs": 23.430999999999994,
"layouts": 15,
"layoutDurationMs": 8.468000000000002,
"taskDurationMs": 745.5169999999999,
"heapDeltaBytes": 4738396,
"heapUsedBytes": 96730028,
"domNodes": 13673,
"jsHeapTotalBytes": 13893632,
"scriptDurationMs": 20.984999999999996,
"eventListeners": 2369,
"totalBlockingTimeMs": 124,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8140.532000000007,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.336,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3788.7960000000003,
"heapDeltaBytes": 8210924,
"heapUsedBytes": 69659304,
"domNodes": -278,
"jsHeapTotalBytes": 6840320,
"scriptDurationMs": 1107.8570000000002,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8115.052999999989,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.089,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3803.8549999999996,
"heapDeltaBytes": 5554448,
"heapUsedBytes": 65547768,
"domNodes": -280,
"jsHeapTotalBytes": 6578176,
"scriptDurationMs": 1107.126,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13559.368000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13533.456000000002,
"heapDeltaBytes": -60147384,
"heapUsedBytes": 166251336,
"domNodes": -8312,
"jsHeapTotalBytes": -14098432,
"scriptDurationMs": 491.71799999999996,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 13486.452999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13454.294000000002,
"heapDeltaBytes": -47829592,
"heapUsedBytes": 166045544,
"domNodes": -8312,
"jsHeapTotalBytes": -13836288,
"scriptDurationMs": 472.092,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 16529.126999999902,
"styleRecalcs": 93,
"styleRecalcDurationMs": 15.240000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16487.983,
"heapDeltaBytes": -28540388,
"heapUsedBytes": 180806868,
"domNodes": -8312,
"jsHeapTotalBytes": -10760192,
"scriptDurationMs": 798.128,
"eventListeners": -16385,
"totalBlockingTimeMs": 16,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 16413.949,
"styleRecalcs": 94,
"styleRecalcDurationMs": 14.885000000000009,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16379.021000000002,
"heapDeltaBytes": -48400612,
"heapUsedBytes": 164642220,
"domNodes": -8312,
"jsHeapTotalBytes": -9379840,
"scriptDurationMs": 789.355,
"eventListeners": -16387,
"totalBlockingTimeMs": 60,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 449.6199999999817,
"styleRecalcs": 20,
"styleRecalcDurationMs": 16.417,
"layouts": 3,
"layoutDurationMs": 1.1250000000000002,
"taskDurationMs": 96.723,
"heapDeltaBytes": -15890756,
"heapUsedBytes": 51076112,
"domNodes": 156,
"jsHeapTotalBytes": 7991296,
"scriptDurationMs": 7.521000000000002,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 453.1570000000329,
"styleRecalcs": 14,
"styleRecalcDurationMs": 14.984999999999998,
"layouts": 3,
"layoutDurationMs": 0.619,
"taskDurationMs": 99.243,
"heapDeltaBytes": -16031728,
"heapUsedBytes": 50978716,
"domNodes": 119,
"jsHeapTotalBytes": 7467008,
"scriptDurationMs": 7.389999999999999,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000728
}
]
}🎭 Playwright: ✅ 1772 passed, 0 failed · 1 flaky📊 Browser Reports
|
🎭 Playwright: ⏳ Running... |
📝 WalkthroughWalkthrough
ChangesMissing Node State Lifecycle
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant ComfyApp
participant importA1111
participant executionErrorStore
participant LiteGraph
ComfyApp->>importA1111: import image parameters
importA1111-->>ComfyApp: graph replaced boolean
alt graph replaced
ComfyApp->>executionErrorStore: clear missing-node types
ComfyApp->>LiteGraph: load replacement graph
end
Possibly related PRs
Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #14251 +/- ##
==========================================
+ Coverage 79.12% 79.30% +0.18%
==========================================
Files 1763 1767 +4
Lines 112306 112541 +235
Branches 35930 35957 +27
==========================================
+ Hits 88862 89253 +391
+ Misses 22916 22754 -162
- Partials 528 534 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 20 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/stores/executionErrorStore.test.ts (1)
852-887: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winSeed a real missing-node pack in this regression.
seedMissingError()assignsfromAny({}), which is not a valid
MissingNodesErrorand contains no node pack. Seed through
setMissingNodeTypes()and assert the actualnodeTypespersist.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/stores/executionErrorStore.test.ts` around lines 852 - 887, Update the regression setup around clearRunErrors to seed missing-node data through missingNodesStore.setMissingNodeTypes(), using a valid MissingNodeType entry rather than relying on seedMissingError(). Assert after executionErrorStore.clearRunErrors() that the actual missing nodeTypes remain preserved, while the run errors are reset.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/stores/executionErrorStore.ts`:
- Around line 86-89: Replace the misleading comment above clearRunErrors with
documentation describing clearRunErrors’ actual run-error and missing-state
behavior; remove the claim about clearMissingModels resetting imported model
download metadata, since this action does not call it.
---
Outside diff comments:
In `@src/stores/executionErrorStore.test.ts`:
- Around line 852-887: Update the regression setup around clearRunErrors to seed
missing-node data through missingNodesStore.setMissingNodeTypes(), using a valid
MissingNodeType entry rather than relying on seedMissingError(). Assert after
executionErrorStore.clearRunErrors() that the actual missing nodeTypes remain
preserved, while the run errors are reset.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 4d82b519-2f68-449d-af7d-140f13000142
📒 Files selected for processing (6)
src/platform/workflow/core/services/workflowService.test.tssrc/platform/workflow/core/services/workflowService.tssrc/scripts/app.test.tssrc/scripts/app.tssrc/stores/executionErrorStore.test.tssrc/stores/executionErrorStore.ts
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
clearAllErrors() runs inside queuePrompt, so submitting a prompt wiped the missing node pack list on every run while missing model and media state was deliberately preserved. A missing node pack is not resolved by submitting a prompt - it persists until the pack is installed and the app restarts - so the list only reappeared when the backend happened to reject the prompt with missing_node_type. Align it with the missing model/media lifecycle: preserve it across runs and clear it on workflow load and on explicit workflow clean instead. Both clearing points are required - loadGraphData can be called with clean: false, and the Clear Workflow command and the legacy Clear button call clean() without going through loadGraphData.
2a9d9e0 to
0c61495
Compare
Submission clears execution errors only. Missing resources are not execution errors: a missing node can sit on a branch the run never executes, so a successful run says nothing about whether it is still missing. Missing model and media state already behaved this way. The rescan also called showErrorOverlay whenever the graph had missing nodes, so submitting such a workflow popped the overlay.
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/scripts/app.ts (1)
2415-2416: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winClear missing-node state for
loadGraphData(..., false).
loadGraphData()callsbeforeLoadNewGraph()at Line 1224. It skipsclean()whenclean === false. This changed reset only runs throughclean(). Therefore, a workflow loaded withclean: falseretains missing-node packs from the previous workflow.Clear missing-node state after
beforeLoadNewGraph()for every workflow load. Keep the reset inclean()for explicit workflow cleanup. Add coverage for loading a valid workflow withclean: falseafter seeding missing-node state.This conflicts with the PR objective to cover workflow loads with
clean: false.Proposed fix
useWorkflowService().beforeLoadNewGraph() + useMissingNodesErrorStore().setMissingNodeTypes([]) if (skipAssetScans) {🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/scripts/app.ts` around lines 2415 - 2416, Update loadGraphData and the beforeLoadNewGraph flow so useMissingNodesErrorStore().setMissingNodeTypes([]) runs after beforeLoadNewGraph for every workflow load, including clean: false. Keep the existing reset in clean() for explicit workflow cleanup, and add coverage that loads a valid workflow with clean: false after seeding missing-node state.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/scripts/app.ts`:
- Around line 2415-2416: Update loadGraphData and the beforeLoadNewGraph flow so
useMissingNodesErrorStore().setMissingNodeTypes([]) runs after
beforeLoadNewGraph for every workflow load, including clean: false. Keep the
existing reset in clean() for explicit workflow cleanup, and add coverage that
loads a valid workflow with clean: false after seeding missing-node state.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 617cd389-0574-4a99-a5c9-989461531743
📒 Files selected for processing (6)
src/platform/workflow/core/services/workflowService.test.tssrc/scripts/app.test.tssrc/scripts/app.tssrc/scripts/pnginfo.tssrc/stores/executionErrorStore.test.tssrc/stores/executionErrorStore.ts
surfaceMissingNodes already clears on an empty list, which is the idiom workflowService documents. Also assert the A1111 tab is seeded from the rebuilt graph, which nothing pinned.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/scripts/pnginfo.ts`:
- Around line 554-557: Update the caller of importA1111 in the workflow import
path to check graphWasReplaced before clearing missing-node state or invoking
afterLoadNewGraph; when it is false, report the failed import and return without
finalizing or registering the unchanged graph as the new workflow.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 8b1b53b8-c903-4dc8-88f8-a18ce82ef01a
📒 Files selected for processing (6)
src/platform/workflow/core/services/workflowService.test.tssrc/scripts/app.test.tssrc/scripts/app.tssrc/scripts/pnginfo.tssrc/stores/executionErrorStore.test.tssrc/stores/executionErrorStore.ts
importA1111 has four early returns that leave the graph untouched. The caller gated the missing-node clear on that but still registered the unchanged graph under the dropped file's name. Falling through instead reaches showErrorOnFileLoad, which already reports an unusable file.
The previous wording asserted a rule with an exception: ComfyApp.clean clears missing state unconditionally while its rootGraph.clear() is skipped inside a subgraph.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/scripts/app.ts`:
- Around line 2062-2070: Update the graph replacement branch in loadGraphData to
await useWorkflowService().afterLoadNewGraph(...) before returning, matching the
existing awaited call elsewhere and preventing a floating promise.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 6bfab7b9-0e91-4219-a029-b0be594aa943
📒 Files selected for processing (2)
src/scripts/app.test.tssrc/scripts/app.ts
| const graphWasReplaced = await importA1111(this.rootGraph, parameters) | ||
| if (graphWasReplaced) { | ||
| useMissingNodesErrorStore().setMissingNodeTypes([]) | ||
| useWorkflowService().afterLoadNewGraph( | ||
| fileName, | ||
| this.rootGraph.serialize() as unknown as ComfyWorkflowJSON | ||
| ) | ||
| return | ||
| } |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Await afterLoadNewGraph to avoid a floating promise.
Line 2065 calls useWorkflowService().afterLoadNewGraph(...) without await. loadGraphData awaits the same call at line 1511. Add await here for consistency and to prevent an unhandled rejection if afterLoadNewGraph throws.
🐛 Proposed fix
if (graphWasReplaced) {
useMissingNodesErrorStore().setMissingNodeTypes([])
- useWorkflowService().afterLoadNewGraph(
+ await useWorkflowService().afterLoadNewGraph(
fileName,
this.rootGraph.serialize() as unknown as ComfyWorkflowJSON
)
return
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const graphWasReplaced = await importA1111(this.rootGraph, parameters) | |
| if (graphWasReplaced) { | |
| useMissingNodesErrorStore().setMissingNodeTypes([]) | |
| useWorkflowService().afterLoadNewGraph( | |
| fileName, | |
| this.rootGraph.serialize() as unknown as ComfyWorkflowJSON | |
| ) | |
| return | |
| } | |
| const graphWasReplaced = await importA1111(this.rootGraph, parameters) | |
| if (graphWasReplaced) { | |
| useMissingNodesErrorStore().setMissingNodeTypes([]) | |
| await useWorkflowService().afterLoadNewGraph( | |
| fileName, | |
| this.rootGraph.serialize() as unknown as ComfyWorkflowJSON | |
| ) | |
| return | |
| } |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/scripts/app.ts` around lines 2062 - 2070, Update the graph replacement
branch in loadGraphData to await useWorkflowService().afterLoadNewGraph(...)
before returning, matching the existing awaited call elsewhere and preventing a
floating promise.
Source: Coding guidelines
christian-byrne
left a comment
There was a problem hiding this comment.
The central judgement here is right, and I want to say that first because most of
what follows is critical. Missing-resource state genuinely should not be cleared
by a prompt submission — a missing node can sit on a branch the run never
touches, so a submission carries no information about it. I verified the two
load-bearing claims in the description independently: clean()'s net behaviour
is byte-identical to before (clearRunErrors + the explicit
setMissingNodeTypes([]) reproduce what clearAllErrors used to do
transitively), and the undo path really does re-derive through
normalizePendingWarnings → surfaceMissingNodes. Both hold.
What I want to push on is that the fix is expressed as three hand-written clear
sites and a boolean, and in that form it is defeated on two of the paths it is
supposed to cover.
Blocking
1. The API-JSON path now produces a card the user cannot get rid of.
loadApiJson surfaces missing nodes as bare strings (app.ts:2204,
.map((t) => t.class_type)) and never adds the nodes to the graph
(if (!node) continue, app.ts:2211). Every removal path is closed against a
string entry: removeMissingNodesByNodeId and removeMissingNodesByPrefix both
return true for typeof node === 'string'; onNodeRemoved can't fire because
there is no node; rescanAndSurfaceMissingNodes only runs on a
missing_node_type prompt error, which the backend won't raise since the node
was dropped from the prompt; and MissingPackGroupRow.vue renders no
Install/Locate action when nodeId == null. Before this PR the next Run cleared
it. Now the only exits are loading another workflow or reloading the page.
To reproduce: Workflow → Open, pick an API JSON containing
{"1":{"class_type":"Uninstalled_XYZ","inputs":{}}}.
The description lists this as follow-up #1, but this PR is what removes the
workaround, so the follow-up and the removal need to ship together. Creating the
has_errors placeholder node in loadApiJson — the option the description
itself prefers — gives the entry a nodeId and makes every existing remover
work.
2. On drag-and-drop, the new clear is undone inside the same gesture.
beforeLoadNewGraph copies the outgoing missing-node list into
activeWorkflow.pendingWarnings (workflowService.ts:419). Then
afterLoadNewGraph is not awaited (app.ts:2065), and it suspends at
await workflowStore.openWorkflow(...) before activeWorkflow is reassigned
(workflowStore.ts:205). So handleFile returns, the drop handler calls
showPendingWarnings() with no argument (app.ts:720), that reads the still-old
activeWorkflow, and surfaceMissingNodes re-applies the stale list.
The same shape applies to loadApiJson (un-awaited afterLoadNewGraph at
app.ts:2266), where it lands the other way and wipes a card that was just set.
deferWarnings: true doesn't save it — handleFile forwards that flag only to
loadGraphData (app.ts:2027), not to the A1111 or API branches.
await on line 2065 and 2266 is the immediate fix. The root cause is that
missing-node truth is stored twice and kept in sync by hand; pendingWarnings
should be the cache for inactive tabs only, with the store authoritative for
the active one.
Not covered by the new tests — app.test.ts:745 and :773 call handleFile
directly, never the drop listener.
3. await importA1111 can now reject out of handleFile and kill the file
picker. importA1111 awaits api.getEmbeddings() (pnginfo.ts:189), which
doesn't check resp.ok and calls resp.json() unguarded — a 500 with an HTML
body throws. That rejection used to be orphaned in an unawaited promise; now it
propagates, so fileInput.value = '' (ui.ts:411) never runs. The input still
holds the file, re-selecting it fires no change event, and Open silently does
nothing on every retry. No toast, no dialog. try/catch around the import, and
finally on the input reset.
4. Two identical "failed to load" alerts for one file. Both the
invalid-structure branch (app.ts:2034) and the parse catch (:2038) call
showErrorOnFileLoad and then fall through. Previously the parameters branch
always returned, so :2073 was unreachable; now a bailing import reaches it.
Drop a PNG with a truncated workflow chunk and a parameters chunk lacking
\nNegative prompt: and you get two stacked alerts. showErrorOnFileLoad does
no deduplication.
5. beforeLoadNewGraph can now run with no matching after, and one of its
effects is destructive. It's called unconditionally at app.ts:2061, before an
import that may bail. It commits five things with no rollback, including
domWidgetStore.clear() (workflowService.ts:428), which empties the map
activeWidgetStates renders from — and registerWidget only runs at widget
construction, so on a bail path nothing re-registers. A workflow with a
CLIPTextEncode multiline prompt on screen loses its DOM widget overlays when
the user drops a PNG whose parameters don't parse.
To be fair: that damage was reachable before this PR too, since the old bail path
called afterLoadNewGraph, which also doesn't re-register. What's new is
structural — the documented paired protocol (workflowService.ts:397-406, and
the call-relationship list at :441 which now says something false) is unpaired,
which is what makes the destructive step unauditable from here on.
Design — worth fixing in this PR
6. Promise<boolean> collapses four outcomes, and one of them is the thing
this PR is about. false is returned for "not an A1111 file" (:557),
"malformed metadata" (:196), and "the file is fine, your install lacks
CheckpointLoaderSimple/KSampler/…" (:234). The caller maps all three to
showErrorOnFileLoad → "this file is unusable", which for the third is simply
untrue — and it's the one place A1111 could report missing node types, swallowed
into a console.error. true is also loose: the size handler bails at
:423-:464 when hires nodes are unregistered, so true can mean "graph
replaced with a half-wired chain", which the caller then finalizes as a clean
workflow.
export type A1111ImportResult =
| { status: 'not-a1111' }
| { status: 'unparseable' }
| { status: 'unavailable-node-types'; types: string[] }
| { status: 'imported'; incompleteNodeTypes: string[] }A switch on that also makes #4 disappear, and lets the missing types reach the
UI they belong in.
7. "The graph was replaced" is a fact nothing dispatches — it's re-asserted at
three sites that clear different subsets. loadGraphData (via clean())
clears missing nodes, models, media, node errors, outputs and DOM widgets.
loadApiJson and the A1111 branch each clear exactly one of those six. Neither
routes through clean() — they call rootGraph.clear() (app.ts:2207) and
graph.clear() (pnginfo.ts:334) directly.
Import an A1111 PNG while lastNodeErrors holds entries from the outgoing
workflow: nothing clears them, and since ids are graph-local,
useNodeErrorFlagSync resolves stale ids against the new graph and paints
has_errors on whichever node now occupies that id.
One named operation both fixes this and stops the table from needing to be
re-derived by hand every time a store gains lifecycle state:
export function resetForNewGraph(scope: { keepAssetScans?: boolean } = {}) {
useNodeOutputStore().resetAllOutputsAndPreviews()
useExecutionErrorStore().clearRunErrors()
useMissingNodesErrorStore().clearMissingNodes()
// …models / media / domWidgets
}clean(), loadApiJson, and the A1111 branch each call it once. A fourth load
path then can't forget a column. Note clearMissingModels already resets seven
refs plus an abort controller — that's the shape this is heading toward.
8. clearRunErrors closes the overlay while hasAnyError stays true.
isErrorOverlayOpen = false (executionErrorStore.ts:91) was consistent
pre-PR because clearAllErrors nulled every category. It isn't now: with a
missing-pack overlay open, clicking Run closes the overlay but leaves
hasAnyError true, which flips showErrorIndicatorOnPanelButton
(TopMenuSection.vue:274) from false to true — a red indicator appears as a
side effect of submitting a prompt, and nothing reopens the overlay until the
next showMissingNodesError. Visibility is already gated on totalErrorCount at
useErrorOverlayState.ts:203, so clearRunErrors shouldn't touch overlay
visibility at all.
Smaller notes
9. One correction to the description. The rationale for not clearing in
beforeLoadNewGraph — that it "opened a window in which hasAnyError was
briefly false" — doesn't hold for the clean path: there is no suspension point
between app.ts:1224 and app.ts:1247, so the two positions are
indistinguishable. And that window exists today regardless, between app.ts:2413
and app.ts:1548, across seven awaits. The reasoning is sound for the undo
path (changeTracker.ts:470, clean === false), where clean() is skipped and
a clear at :1224 would be unconditional. That's a real reason — it's just not
the one stated, and the stated one implies a safety the code doesn't have.
The underlying problem is RightSidePanel.vue:227, a watchEffect that reads a
computed and writes rightSidePanelStore.openPanel. Because openPanel has no
memory of what it clobbered, every transient in the error stores becomes a
permanent UI change. Deriving the resolved tab instead of repairing it from an
effect makes the placement of the clear a non-decision. Out of scope here, but
it's the thing that forced this PR's hardest choice.
10. Pre-existing, but newly load-bearing. setMissingNodeTypes([]) doubles
as teardown (if (!types.length) { missingNodesError.value = null; return }), so
this PR's diff makes showMissingNodesError the API-JSON path's clear
(app.ts:2204 is now unconditional). A method named show…Error that hides is
worth a clearMissingNodes() sibling — missingModelStore already has both
forms. Separately surfaceMissingNodes returns
types.length > 0 && settingStore.get('Comfy.RightSidePanel.ShowErrorsTab'),
smuggling a setting read out of a setter, and missingNodesError.message is
computed once at set time from st() (so it won't follow a locale change), has
no production consumer, and duplicates
missingErrorResolver.ts:342. That last one matters more now that missing-node
state survives every submission and its lifetime is unbounded.
11. importA1111 clears the root graph with no subgraph guard. clean()
guards this exact case (app.ts:2415, "LGraph's clear breaks the subgraph
structure"); pnginfo.ts:334 doesn't. Navigate into a subgraph, drop a valid
A1111 PNG, and the new boolean contract reports a clean replacement over a
corrupt canvas.
Tests
The four new app.test.ts cases are mutation-sensitive — I checked each against
its inverse and they fail on the reverted change. Good.
Gaps:
- Only one of
importA1111's threefalsepaths is exercised. The test string
has no\nSteps:, so it returns at:557without reaching
await api.getEmbeddings()— the two paths that return after the suspension
point, where the ordering actually matters, are untested.pnginfo.test.tshas
noimportA1111coverage at all; three direct unit tests there would be
cheaper and stronger than the current indirect ones. - Nothing pins the stuck state from #1 —
loadApiJsonwith a missing type, then
queuePrompt, asserting the entry survives. That's the most consequential
behaviour change in the PR and it's unasserted. workflowService.test.ts:330/:333assert that
pendingWarnings.missingNodeTypesandmissingNodesError.nodeTypesagree.
That's a guard on two copies of one fact being in sync, which will actively
resist collapsing them. If the duplication is deliberate for the tab cache,
assert the cache semantics instead — that a snapshot is taken for the
outgoing tab.- In
clears missing node packs after importing A1111 parameters, the
registerNodeTypeloop sits outside thetry, so a throw mid-loop leaks real
node names into the module-global registry for the rest of the file.
One note on the public surface
src/scripts/** is covered by comfyAPIPlugin's isLegacyFile, so
importA1111 is shimmed onto window.comfyAPI.pnginfo.importA1111.
Promise<void> → Promise<boolean> is a runtime-compatible widening and is
fine, but it's a public-surface change and worth a line in the description.
| ) { | ||
| console.error('Failed to create required nodes for A1111 import') | ||
| return | ||
| return false |
There was a problem hiding this comment.
This is the one place A1111 can tell you your install is missing node types, and it becomes false — which app.ts:2073 renders as "this file is unusable." The file is fine. See item 6: a discriminated union carries { status: 'unavailable-node-types', types } to a UI that can act on it, and collapses the double-toast in item 4 at the same time.
| const graphWasReplaced = await importA1111(this.rootGraph, parameters) | ||
| if (graphWasReplaced) { | ||
| useMissingNodesErrorStore().setMissingNodeTypes([]) | ||
| useWorkflowService().afterLoadNewGraph( |
There was a problem hiding this comment.
afterLoadNewGraph isn't awaited, but importA1111 on the line above is. It suspends at openWorkflow before activeWorkflow is reassigned, so handleFile returns while the old workflow is still active and the drop handler's showPendingWarnings() (app.ts:720) re-applies the stale missing-node list this PR just cleared. Same shape at :2266. See item 2.
| return | ||
| const graphWasReplaced = await importA1111(this.rootGraph, parameters) | ||
| if (graphWasReplaced) { | ||
| useMissingNodesErrorStore().setMissingNodeTypes([]) |
There was a problem hiding this comment.
This is the third hand-written answer to "what does replacing the graph invalidate?", and each of the three clears a different subset. clean() clears six things; this clears one. Import an A1111 PNG with lastNodeErrors populated and the stale ids get resolved against the new graph. See item 7 for a single resetForNewGraph().
| if (missingNodeTypes.length) { | ||
| this.showMissingNodesError(missingNodeTypes.map((t) => t.class_type)) | ||
| } | ||
| this.showMissingNodesError(missingNodeTypes.map((t) => t.class_type)) |
There was a problem hiding this comment.
Two things here. Dropping the if (missingNodeTypes.length) guard makes showMissingNodesError the clear for this path, via setMissingNodeTypes([])'s teardown overload — a method named show…Error that hides. And the entries it sets are bare strings with no nodeId, which every removal path rejects; removing the submit-time wipe means nothing can clear them at all. Item 1 is the blocking half.
| * resource can sit on a branch the run never executed, so a submission says | ||
| * nothing about whether it is still missing, and installing a node pack needs | ||
| * a backend restart. Missing nodes are cleared by `ComfyApp.clean` and by the | ||
| * file-import paths that rebuild the graph. */ |
There was a problem hiding this comment.
Closing the overlay was consistent pre-PR because clearAllErrors nulled every category. Now missing packs survive, so Run closes the overlay with hasAnyError still true — which flips showErrorIndicatorOnPanelButton (TopMenuSection.vue:274) to true. Submitting a prompt makes a red dot appear. Visibility is already gated on totalErrorCount at useErrorOverlayState.ts:203; this line can just go.
| expect(activeWorkflow.pendingWarnings?.missingNodeTypes).toEqual( | ||
| missingNodeTypes | ||
| ) | ||
| expect(missingNodesStore.missingNodesError?.nodeTypes).toEqual( |
There was a problem hiding this comment.
These two assertions say "the two copies of this fact agree right now", which locks in the duplication that makes item 2 possible. If the mirror is deliberately the cache for inactive tabs, assert that instead — a snapshot is taken for the outgoing workflow — so the test survives making the store authoritative for the active one.
|
Closing this in favour of three smaller PRs. Thanks for the review — every blocker in it held up, and working through them is what made it clear this PR was doing too much. The thesis here was one sentence: a prompt submission should not clear missing-node state. Taking all eight review items into it grew it to ~600 non-test lines across the A1111 importer, the API-JSON loader, the graph-reset lifecycle and the error store. Those are four different changes with four different risk profiles, and bundling them means no reviewer can approve any one of them independently and nothing can be reverted on its own. Splitting into: A1 — API-JSON load. Unknown node types become placeholder nodes with A2 — A1111 import. The lifecycle fixes only: On your #6 — That also means nothing from the A1111 path writes to the missing-node panel at all. A node type that was never added to the graph does not belong in a list of nodes missing from the graph. A3 — this PR's original thesis, and only that: Order: A1 then A3. Your point that the follow-up and the removal have to ship together was right — A3 removes the only thing that currently retires an anchor-less API-JSON entry, so A1 has to give those entries an anchor first. A2 is independent of both. Two other things from your review that were right and are carried into the split: Not carried: the |
|
Closing — superseded by the three-PR split described above. Will link A1/A2/A3 here as they open. |
|
Split is open:
Merge order: #14555 before #14557. #14556 is independent. Your point that the follow-up and the removal have to ship together is what set that order — #14557 removes the last thing that retires an anchor-less API-JSON entry, so #14555 has to give those entries an anchor first. |
…stalls accurately (Comfy-Org#14556) Splits out of Comfy-Org#14251. Five lifecycle fixes on the A1111 image-import path. 30 production lines. ## What Dropping an A1111-generated PNG parses its `parameters` string and builds a ComfyUI graph from it. The path had four defects that only show up when something goes wrong, plus one that shows up always: 1. **`afterLoadNewGraph` was not awaited.** It suspends before the active workflow is reassigned, so `rootGraph.serialize()` on the next line captured the *outgoing* graph — the new tab was born dirty against a stale baseline. 2. **A rejection escaped an async DOM handler.** `importA1111` awaits `api.getEmbeddings()`, which does not check `resp.ok`. On a 500 with an HTML body it throws, `fileInput.value = ''` never runs, the input still holds the file, re-selecting it fires no `change` event, and Open silently does nothing on every retry. Now: `try`/`catch` with a toast, `finally` resets the input. 3. **Two identical alerts for one file.** The invalid-structure `else` and the parse `catch` each called `showErrorOnFileLoad`, then fell through to the final call at the end of `handleFile`. Those two are the `else` and `catch` of one `try`, so the maximum is two alerts, not three. 4. **`beforeLoadNewGraph()` ran before an import that might bail.** It calls `domWidgetStore.clear()`, and nothing re-registers on a bail path — a workflow with a multiline prompt on screen lost its DOM widget overlays when the user dropped a PNG that did not parse. It now runs immediately before the mutation, and the A1111 path gets the subgraph guard `clean()` already had. 5. **No message at all when required node types are unavailable, and silent corruption of the open workflow.** `importA1111` logged to the console and returned `void`. Because the call was unawaited, `afterLoadNewGraph` then registered the user's *unchanged* graph under the dropped file's name, after `beforeLoadNewGraph` had already cleared `domWidgetStore`. See below. ## The message The seven types this importer needs — `CheckpointLoaderSimple`, `CLIPSetLastLayer`, `CLIPTextEncode`, `KSampler`, `EmptyLatentImage`, `VAEDecode`, `SaveImage` — are all **core nodes**, as are `LoraLoader` and the hires chain. Their absence does not mean a node pack is missing. It means the backend did not load, or the install is broken. So this path deliberately writes nothing to the missing-node panel: no card, no entry, no placeholder. A type that was never added to the graph does not belong in a list of nodes missing *from the graph*, and naming the individual types would read as "install this pack" and send people looking for something that does not exist. ``` "Could not load the workflow because this ComfyUI installation is missing core nodes. Check that the backend started correctly." ``` `importA1111` returns `Promise<'imported' | 'not-a1111' | 'core-nodes-unavailable'>` — three string literals, replacing `Promise<boolean>`. The boolean could not distinguish "bailed and already told the user" from "bailed silently", which is how an ordinary A1111 PNG could vanish with no feedback at all: A1111 omits the `Negative prompt:` line entirely when the negative prompt is empty. The `core-nodes-unavailable` return happens **before** the graph is touched, so a failed import leaves the open workflow intact. `pnginfo.test.ts` asserts that directly. ## What this deliberately does not do `pnginfo.ts` is **+8 −4**, with zero re-indentation (`git diff` and `git diff -w` report the same line count). The nesting in that file is not pretty and it is not this PR's business. An earlier revision restructured it; that diff was 759 lines, ~72% of it re-indentation, and none of it fixed a bug. If it deserves a refactor it deserves a PR where a reviewer sees only that. ## Verification 6 unit tests across `app.test.ts`, `pnginfo.test.ts` and `ui.test.ts`, each mutation-proved. typecheck, lint, format, knip clean. Full unit suite: only pre-existing timeout flakes, confirmed by re-running the same files at the merge base and getting byte-identical results. ## Related - Follow-up to Comfy-Org#14251 (closed) - Independent of Comfy-Org#14555 and of the narrow submission fix — no ordering constraint
…omfy-Org#14555) Splits out of Comfy-Org#14251, which was doing four things at once. This is one of them. ## What An API-format (prompt-format) JSON references node types by `class_type`. When one of those types is not installed, `loadApiJson` did `if (!node) continue` — the node was dropped, and the missing type was reported to the Issues panel as a bare string. A bare string has no `nodeId`, so nothing can retire it: `removeMissingNodesByNodeId` and `removeMissingNodesByPrefix` both preserve strings by design, `onNodeRemoved` cannot fire because there is no node, and `MissingPackGroupRow` renders no Locate action. The entry outlived everything except a full workflow reload. Now the node is built from the data instead of being skipped. API format is what gets submitted to the server, so it carries every input by name — either a literal or a link: ```json "3": { "class_type": "PreviewImage", "inputs": { "images": ["4", 0] } } "4": { "class_type": "EmptyLatentImage", "inputs": { "width": 512, "height": 512 } } ``` For an uninstalled type we do not have the node definition, but we do not need it — the names are in the data. Each link input becomes a named wildcard slot so `processNodeInputs` can resolve it; each literal is preserved in `widgets_values_named` (keyed, exact) alongside `widgets_values` (positional, for the existing replacement path). `last_serialization` carries the real content, and the node's `inputs` are re-synced after links resolve. The result is a node on the canvas that is a faithful record of what the JSON said, flagged `has_errors`, with a real `nodeId`. Locate works, deleting it retires the entry, and Replace has something to work from. ## The E2E assertion this flips `workflowPersistence.spec.ts` asserted the unknown type was **absent** from the graph. That assertion was never a requirement. Its own annotation says what it guards: > `PR Comfy-Org#9694 — loadApiJson early-returned on missing node types` The regression was that the *whole workflow* failed to load. The test is named "partially loads", and the requirements are the two `toContain` assertions — the known nodes appear. The `.not.toContain` was the adjacent comment ("unknown node skipped") frozen into an assertion: a description of the `if (!node) continue` implementation, not a decision. It is updated to assert the placeholder is present with `has_errors`. ## Verification - 5 unit tests, each mutation-proved: revert the production line, watch the named assertion fail, restore, watch it pass. Removing the slot creation fails the link assertion; removing the value carry fails the widget-values assertion. - `workflowPersistence` Playwright spec run against a local backend: **14/14**. - typecheck, lint, format, knip clean. ## Known limitation The placeholder cannot reproduce a *positional* `widgets_values` faithfully without the node definition, which is why the keyed form is the source of truth. If a replacement node's widget names differ from the API input names, Replace will not map them — that mapping does not exist today and is out of scope here. ## Related - Follow-up to Comfy-Org#14251 (closed) - Lands before the narrow submission fix, which removes the last thing that currently retires an anchor-less entry ## Screenshot <img width="1450" height="892" alt="스크린샷 2026-08-03 오후 1 45 56" src="https://github.com/user-attachments/assets/2a80eddd-5fa9-4201-9e19-d510e532f67e" />
Summary
Missing node packs were wiped from the Issues/Errors panel on every prompt submission, while missing model and media state was deliberately preserved. This aligns node packs with the other two.
Why this matters now
#14177 (FE-1388) replaced the Run-button warning icon's independent derivation with a store read:
Before that, the icon re-derived from the graph on every access, so
clearAllErrors()on submit could not affect it. After it, the icon is a pure read ofmissingNodeTypes— so the submit-time wipe started flipping the Run button fromtriangle-alertback toplayon the first submission. This closes that window.Blame also shows the submit-time clear was an omission rather than a decision: the commit that introduced missing-node state added the clear in the same stroke with no comment and no test, while adding 97 lines of tests for the adjacent API. The
clearAllErrors()call inqueuePromptpredates missing-node state by ~20 months.Changes
clearAllErrorsrenamed toclearRunErrors, and it no longer clears missing-node state. The name now matches what it does: it resets the three categories this store owns and leaves the three that live in other stores.loadApiJson, theimportA1111branch (gated on the import having happened), andclean().importA1111returnsPromise<boolean>so the caller can tell whether the graph was rebuilt, and is now awaited. When it reportsfalsethe caller no longer finalizes a workflow — it falls through toshowErrorOnFileLoad, which already reports an unusable file. Previously a failed import still registered the unchanged graph under the dropped file's name.Review focus
Why the clear is not in
beforeLoadNewGraph(). That looked like the natural funnel — all three documented graph-load entry points call it — but it is wrong in both directions:importA1111calls it and then has four early returns (pnginfo.ts:188/196/210/234) that leave the graph untouched, so the card was wiped while every missing node was still on the canvas.loadGraphDatanever needed it: it re-derives the whole list on every path, either viaclean()or viashowPendingWarnings->surfaceMissingNodes(... ?? []). Clearing at the top only opened a window in whichhasAnyErrorwas briefly false, during which the right-panelwatchEffectreassigned the active tab from Errors to Parameters and never restored it — so every undo on a workflow whose only error was a missing pack silently switched the panel.Why
clean()keeps its own clear. It is not a caller ofbeforeLoadNewGraph, and it is reached standalone fromComfy.ClearWorkflowand the legacy Clear button.Awaiting
importA1111is required to read its return value, and it also fixes a latent ordering bug: the function's first suspension point precedes its only graph mutation, sorootGraph.serialize()on the next line previously captured the outgoing graph — the new tab was born dirty against a stale baseline. A prior PR (#7840) fixed this and was reverted pending a split that never landed.Every production line is mutation-proved: reverting it fails the test that names it, restoring it passes.
Findings for the team — not fixed here
1. Should an API-format load silently drop unsupported nodes?
loadApiJsondoesconst node = LiteGraph.createNode(data.class_type); if (!node) continue— the node is never added to the graph. Normal workflow loads do not do this; the established idiom elsewhere in the codebase is to build a placeholderLGraphNodewithhas_errors = true(seeLGraph.ts's subgraph-unpack path).The consequence is visible today, independent of this PR: open an API JSON referencing an uninstalled node and you get a "Missing Node Packs" card for a node that exists on no canvas. Because the entry carries no
nodeId, every targeted remover preserves it by design, the card renders no Install/Locate/Apply action (those require a known pack), and the Errors tab has no dismiss control. Previously the submit-time wipe cleared it as a side effect; with that gone, the only exits are loading another workflow or reloading the page.If the silent drop is unintentional, creating the placeholder fixes this class outright — the entry anchors to a node, deleting the node retires it, and API loads behave like every other load. If it is intentional, we need a dismiss affordance for unknown-pack groups instead. Either way it is a separate change; flagging it here so the decision is made deliberately rather than inherited.
2.
beforeLoadNewGraph()runs unconditionally on the A1111 branch, and it clears DOM widgets.app.ts:2061calls it before we know whether the import will do anything.importA1111has four early returns that leave the graph untouched — the most reachable being aparameterschunk withSteps:but no\nNegative prompt:(pnginfo.ts:210). On those pathsdomWidgetStore.clear()has already run, no node is re-added to recreate the widget state, and the user's current workflow loses its textareas until it is reloaded; a thumbnail is captured and a draft persisted for a load that never happened.This is pre-existing —
maincalls it unconditionally on this branch too — and gating it is not a one-liner, because three of the four bail conditions are only knowable after real work (getEmbeddings, the regex match,createNode). It needsimportA1111split into a parse step and an apply step, withbeforeLoadNewGraph()between them. Same territory as the reverted #7840.3. Drag-and-drop takes a different path than the file button. The drop handler calls
showPendingWarnings()after an un-awaitedafterLoadNewGraph, so a freshly created temporary workflow (whosependingWarningsisnull) can re-apply an empty list over the store — wiping the card even when the graph was not replaced. This is pre-existing and unchanged by this PR (theapp.tsdelta does not touch that hunk), and it is the same class as (1). Worth folding into the same follow-up.4. Pre-existing and out of scope:
Comfy.ClearWorkflowclears missing nodes but not missing models or media, so those go stale on a manual clear. Same before and after this PR.