Skip to content

fix: keep missing node packs across runs - #14251

Closed
jaeone94 wants to merge 9 commits into
mainfrom
jaeone94/errors-node-pack-lifecycle
Closed

jaeone94 wants to merge 9 commits into
mainfrom
jaeone94/errors-node-pack-lifecycle

Conversation

@jaeone94

@jaeone94 jaeone94 commented Jul 29, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Missing node packs were wiped from the Issues/Errors panel on every prompt submission, while missing model and media state was deliberately preserved. This aligns node packs with the other two.

Why this matters now

#14177 (FE-1388) replaced the Run-button warning icon's independent derivation with a store read:

-const hasMissingNodes = computed(() => graphHasMissingNodes(app.rootGraph, nodeDefStore.nodeDefsByName))
+const { hasMissingError } = storeToRefs(useExecutionErrorStore())

Before that, the icon re-derived from the graph on every access, so clearAllErrors() on submit could not affect it. After it, the icon is a pure read of missingNodeTypes — so the submit-time wipe started flipping the Run button from triangle-alert back to play on the first submission. This closes that window.

Blame also shows the submit-time clear was an omission rather than a decision: the commit that introduced missing-node state added the clear in the same stroke with no comment and no test, while adding 97 lines of tests for the adjacent API. The clearAllErrors() call in queuePrompt predates missing-node state by ~20 months.

Changes

  • clearAllErrors renamed to clearRunErrors, and it no longer clears missing-node state. The name now matches what it does: it resets the three categories this store owns and leaves the three that live in other stores.
  • Missing-node state is cleared where the graph is actually replaced: loadApiJson, the importA1111 branch (gated on the import having happened), and clean().
  • importA1111 returns Promise<boolean> so the caller can tell whether the graph was rebuilt, and is now awaited. When it reports false the caller no longer finalizes a workflow — it falls through to showErrorOnFileLoad, which already reports an unusable file. Previously a failed import still registered the unchanged graph under the dropped file's name.

Review focus

Why the clear is not in beforeLoadNewGraph(). That looked like the natural funnel — all three documented graph-load entry points call it — but it is wrong in both directions:

  • importA1111 calls it and then has four early returns (pnginfo.ts:188/196/210/234) that leave the graph untouched, so the card was wiped while every missing node was still on the canvas.
  • loadGraphData never needed it: it re-derives the whole list on every path, either via clean() or via showPendingWarnings -> surfaceMissingNodes(... ?? []). Clearing at the top only opened a window in which hasAnyError was briefly false, during which the right-panel watchEffect reassigned the active tab from Errors to Parameters and never restored it — so every undo on a workflow whose only error was a missing pack silently switched the panel.

Why clean() keeps its own clear. It is not a caller of beforeLoadNewGraph, and it is reached standalone from Comfy.ClearWorkflow and the legacy Clear button.

Awaiting importA1111 is required to read its return value, and it also fixes a latent ordering bug: the function's first suspension point precedes its only graph mutation, so rootGraph.serialize() on the next line previously captured the outgoing graph — the new tab was born dirty against a stale baseline. A prior PR (#7840) fixed this and was reverted pending a split that never landed.

Every production line is mutation-proved: reverting it fails the test that names it, restoring it passes.

Findings for the team — not fixed here

1. Should an API-format load silently drop unsupported nodes? loadApiJson does const node = LiteGraph.createNode(data.class_type); if (!node) continue — the node is never added to the graph. Normal workflow loads do not do this; the established idiom elsewhere in the codebase is to build a placeholder LGraphNode with has_errors = true (see LGraph.ts's subgraph-unpack path).

The consequence is visible today, independent of this PR: open an API JSON referencing an uninstalled node and you get a "Missing Node Packs" card for a node that exists on no canvas. Because the entry carries no nodeId, every targeted remover preserves it by design, the card renders no Install/Locate/Apply action (those require a known pack), and the Errors tab has no dismiss control. Previously the submit-time wipe cleared it as a side effect; with that gone, the only exits are loading another workflow or reloading the page.

If the silent drop is unintentional, creating the placeholder fixes this class outright — the entry anchors to a node, deleting the node retires it, and API loads behave like every other load. If it is intentional, we need a dismiss affordance for unknown-pack groups instead. Either way it is a separate change; flagging it here so the decision is made deliberately rather than inherited.

2. beforeLoadNewGraph() runs unconditionally on the A1111 branch, and it clears DOM widgets. app.ts:2061 calls it before we know whether the import will do anything. importA1111 has four early returns that leave the graph untouched — the most reachable being a parameters chunk with Steps: but no \nNegative prompt: (pnginfo.ts:210). On those paths domWidgetStore.clear() has already run, no node is re-added to recreate the widget state, and the user's current workflow loses its textareas until it is reloaded; a thumbnail is captured and a draft persisted for a load that never happened.

This is pre-existing — main calls it unconditionally on this branch too — and gating it is not a one-liner, because three of the four bail conditions are only knowable after real work (getEmbeddings, the regex match, createNode). It needs importA1111 split into a parse step and an apply step, with beforeLoadNewGraph() between them. Same territory as the reverted #7840.

3. Drag-and-drop takes a different path than the file button. The drop handler calls showPendingWarnings() after an un-awaited afterLoadNewGraph, so a freshly created temporary workflow (whose pendingWarnings is null) can re-apply an empty list over the store — wiping the card even when the graph was not replaced. This is pre-existing and unchanged by this PR (the app.ts delta does not touch that hunk), and it is the same class as (1). Worth folding into the same follow-up.

4. Pre-existing and out of scope: Comfy.ClearWorkflow clears missing nodes but not missing models or media, so those go stale on a manual clear. Same before and after this PR.

@github-actions

github-actions Bot commented Jul 29, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 07/31/2026, 07:45:38 AM UTC

Links

📦 Bundle: 8.19 MB gzip 🔴 +123 B

Details

Summary

  • Raw size: 34.4 MB baseline 34.4 MB — 🔴 +304 B
  • Gzip: 8.19 MB baseline 8.19 MB — 🔴 +123 B
  • Brotli: 5.67 MB baseline 5.67 MB — 🔴 +254 B
  • Bundles: 426 current • 426 baseline • 144 added / 144 removed

Category Glance
Data & Services 🔴 +304 B (3.44 MB) · Vendor & Third-Party ⚪ 0 B (15.7 MB) · Other ⚪ 0 B (12.7 MB) · Graph Workspace ⚪ 0 B (1.29 MB) · Panels & Settings ⚪ 0 B (551 kB) · Utilities & Hooks ⚪ 0 B (386 kB) · + 5 more

App Entry Points — 3.62 kB (baseline 3.62 kB) • ⚪ 0 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-COZgw3v-.js (new) — 3.62 kB 🔴 +3.62 kB 🔴 +1.81 kB 🔴 +1.57 kB
assets/index-DSDPWH_0.js (removed) 3.62 kB — 🟢 -3.62 kB 🟢 -1.8 kB 🟢 -1.57 kB

Status: 1 added / 1 removed

Graph Workspace — 1.29 MB (baseline 1.29 MB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-DRXk8OKB.js (removed) 1.29 MB — 🟢 -1.29 MB 🟢 -276 kB 🟢 -208 kB
assets/GraphView-nBbiTE4_.js (new) — 1.29 MB 🔴 +1.29 MB 🔴 +276 kB 🔴 +208 kB

Status: 1 added / 1 removed / 1 unchanged

Views & Navigation — 111 kB (baseline 111 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CloudSurveyView-CK2qEX_V.js (removed) 24.9 kB — 🟢 -24.9 kB 🟢 -6.22 kB 🟢 -5.51 kB
assets/CloudSurveyView-Pf3prHCo.js (new) — 24.9 kB 🔴 +24.9 kB 🔴 +6.22 kB 🔴 +5.51 kB
assets/CloudLoginView-B1ce-15j.js (removed) 11.6 kB — 🟢 -11.6 kB 🟢 -3.1 kB 🟢 -2.73 kB
assets/CloudLoginView-DDgdpFD_.js (new) — 11.6 kB 🔴 +11.6 kB 🔴 +3.11 kB 🔴 +2.73 kB
assets/CloudSignupView-Bao-73OG.js (new) — 9.9 kB 🔴 +9.9 kB 🔴 +2.77 kB 🔴 +2.43 kB
assets/CloudSignupView-Do1c1vY4.js (removed) 9.9 kB — 🟢 -9.9 kB 🟢 -2.77 kB 🟢 -2.43 kB
assets/CloudLayoutView-B8zBjqHx.js (new) — 9.48 kB 🔴 +9.48 kB 🔴 +2.32 kB 🔴 +2 kB
assets/CloudLayoutView-oz7WM9XA.js (removed) 9.48 kB — 🟢 -9.48 kB 🟢 -2.31 kB 🟢 -2 kB
assets/UserCheckView-C44UFX4P.js (removed) 8.75 kB — 🟢 -8.75 kB 🟢 -2.19 kB 🟢 -1.9 kB
assets/UserCheckView-KtZJueNr.js (new) — 8.75 kB 🔴 +8.75 kB 🔴 +2.19 kB 🔴 +1.9 kB
assets/WidgetTextPreview-C3GMCZy_.js (new) — 6.07 kB 🔴 +6.07 kB 🔴 +2.13 kB 🔴 +1.9 kB
assets/WidgetTextPreview-DkB8EUT2.js (removed) 6.07 kB — 🟢 -6.07 kB 🟢 -2.13 kB 🟢 -1.9 kB
assets/CloudSubscriptionRedirectView-CJh3JqjU.js (new) — 5.99 kB 🔴 +5.99 kB 🔴 +2.23 kB 🔴 +1.94 kB
assets/CloudSubscriptionRedirectView-DbWBYBaf.js (removed) 5.99 kB — 🟢 -5.99 kB 🟢 -2.23 kB 🟢 -1.94 kB
assets/UserSelectView-BM4BViK1.js (new) — 5.49 kB 🔴 +5.49 kB 🔴 +1.96 kB 🔴 +1.71 kB
assets/UserSelectView-CNEdhn8K.js (removed) 5.49 kB — 🟢 -5.49 kB 🟢 -1.95 kB 🟢 -1.71 kB
assets/CloudForgotPasswordView-CnrBPBZ-.js (new) — 5.09 kB 🔴 +5.09 kB 🔴 +1.72 kB 🔴 +1.51 kB
assets/CloudForgotPasswordView-DhLBf8GO.js (removed) 5.09 kB — 🟢 -5.09 kB 🟢 -1.73 kB 🟢 -1.51 kB
assets/CloudAuthTimeoutView-c4sAy-Qa.js (removed) 4.43 kB — 🟢 -4.43 kB 🟢 -1.54 kB 🟢 -1.33 kB
assets/CloudAuthTimeoutView-DkKwLa8I.js (new) — 4.43 kB 🔴 +4.43 kB 🔴 +1.53 kB 🔴 +1.34 kB
assets/OAuthLayoutView-BIqW9JTa.js (new) — 1.31 kB 🔴 +1.31 kB 🔴 +701 B 🔴 +596 B
assets/OAuthLayoutView-BR_MSD55.js (removed) 1.31 kB — 🟢 -1.31 kB 🟢 -700 B 🟢 -594 B
assets/WidgetTextPreview-8nKYMV2r.js (new) — 131 B 🔴 +131 B 🔴 +100 B 🔴 +89 B
assets/WidgetTextPreview-BgVJ3uXI.js (removed) 131 B — 🟢 -131 B 🟢 -100 B 🟢 -91 B

Status: 12 added / 12 removed / 4 unchanged

Panels & Settings — 551 kB (baseline 551 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/KeybindingPanel-3-li21VV.js (new) — 49.4 kB 🔴 +49.4 kB 🔴 +9.95 kB 🔴 +8.8 kB
assets/KeybindingPanel-B2cPX7Wv.js (removed) 49.4 kB — 🟢 -49.4 kB 🟢 -9.95 kB 🟢 -8.79 kB
assets/SecretsPanel-C1rFjvug.js (new) — 33.7 kB 🔴 +33.7 kB 🔴 +7.86 kB 🔴 +6.89 kB
assets/SecretsPanel-CV8vFa1r.js (removed) 33.7 kB — 🟢 -33.7 kB 🟢 -7.86 kB 🟢 -6.9 kB
assets/CreditsPanel-CI-WNh-m.js (new) — 15.9 kB 🔴 +15.9 kB 🔴 +4.63 kB 🔴 +4.07 kB
assets/CreditsPanel-DbqTUfqG.js (removed) 15.9 kB — 🟢 -15.9 kB 🟢 -4.63 kB 🟢 -4.07 kB
assets/SubscriptionPanel-CNz2Ddjf.js (new) — 11.4 kB 🔴 +11.4 kB 🔴 +3.63 kB 🔴 +3.19 kB
assets/SubscriptionPanel-DgolOVWD.js (removed) 11.4 kB — 🟢 -11.4 kB 🟢 -3.63 kB 🟢 -3.17 kB
assets/AboutPanel-B6bi1b1p.js (new) — 11.2 kB 🔴 +11.2 kB 🔴 +3.02 kB 🔴 +2.71 kB
assets/AboutPanel-bUHjNdXA.js (removed) 11.2 kB — 🟢 -11.2 kB 🟢 -3.02 kB 🟢 -2.72 kB
assets/ExtensionPanel-BxsKEbUv.js (new) — 9.19 kB 🔴 +9.19 kB 🔴 +2.51 kB 🔴 +2.22 kB
assets/ExtensionPanel-R9haJi8f.js (removed) 9.19 kB — 🟢 -9.19 kB 🟢 -2.51 kB 🟢 -2.22 kB
assets/ServerConfigPanel-CWainWtY.js (removed) 6.09 kB — 🟢 -6.09 kB 🟢 -1.94 kB 🟢 -1.72 kB
assets/ServerConfigPanel-Dc0F4wKX.js (new) — 6.09 kB 🔴 +6.09 kB 🔴 +1.94 kB 🔴 +1.73 kB
assets/UserPanel-BPoMTKU7.js (new) — 5.73 kB 🔴 +5.73 kB 🔴 +1.78 kB 🔴 +1.54 kB
assets/UserPanel-Ds1rS8uA.js (removed) 5.73 kB — 🟢 -5.73 kB 🟢 -1.78 kB 🟢 -1.55 kB
assets/refreshRemoteConfig-BFtxXlYx.js (new) — 2.91 kB 🔴 +2.91 kB 🔴 +1.24 kB 🔴 +1.09 kB
assets/refreshRemoteConfig-DcLIxdqv.js (removed) 2.91 kB — 🟢 -2.91 kB 🟢 -1.24 kB 🟢 -1.09 kB
assets/cloudRemoteConfig-CS6gJlFm.js (new) — 933 B 🔴 +933 B 🔴 +506 B 🔴 +417 B
assets/cloudRemoteConfig-yPc4RmlA.js (removed) 933 B — 🟢 -933 B 🟢 -505 B 🟢 -419 B
assets/refreshRemoteConfig-C2MkSbrb.js (new) — 110 B 🔴 +110 B 🔴 +89 B 🔴 +90 B
assets/refreshRemoteConfig-wxvEOi3C.js (removed) 110 B — 🟢 -110 B 🟢 -89 B 🟢 -85 B

Status: 11 added / 11 removed / 15 unchanged

User & Accounts — 28.7 kB (baseline 28.7 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/SignUpForm-BJcUQVUD.js (new) — 12.2 kB 🔴 +12.2 kB 🔴 +4.15 kB 🔴 +3.62 kB
assets/SignUpForm-CQF3-bkk.js (removed) 12.2 kB — 🟢 -12.2 kB 🟢 -4.15 kB 🟢 -3.62 kB
assets/auth-BQVqaHD6.js (removed) 3.65 kB — 🟢 -3.65 kB 🟢 -1.27 kB 🟢 -1.09 kB
assets/auth-C62NnMjC.js (new) — 3.65 kB 🔴 +3.65 kB 🔴 +1.27 kB 🔴 +1.09 kB
assets/usePostAuthRedirect-CkmDtje9.js (removed) 3.28 kB — 🟢 -3.28 kB 🟢 -1.24 kB 🟢 -1.08 kB
assets/usePostAuthRedirect-m2z-5Kjm.js (new) — 3.28 kB 🔴 +3.28 kB 🔴 +1.24 kB 🔴 +1.08 kB
assets/UpdatePasswordContent-BYwsg-OF.js (removed) 1.85 kB — 🟢 -1.85 kB 🟢 -839 B 🟢 -728 B
assets/UpdatePasswordContent-DrJrTjxu.js (new) — 1.85 kB 🔴 +1.85 kB 🔴 +838 B 🔴 +730 B
assets/authStore-CB6Ynfih.js (new) — 128 B 🔴 +128 B 🔴 +104 B 🔴 +104 B
assets/authStore-g02iB_vV.js (removed) 128 B — 🟢 -128 B 🟢 -104 B 🟢 -104 B
assets/workspaceAuthStore-CSRUlTu8.js (removed) 108 B — 🟢 -108 B 🟢 -99 B 🟢 -100 B
assets/workspaceAuthStore-GuzGq3WG.js (new) — 108 B 🔴 +108 B 🔴 +99 B 🔴 +101 B
assets/auth-CzzwrwfY.js (new) — 105 B 🔴 +105 B 🔴 +96 B 🔴 +87 B
assets/auth-DM3FlYan.js (removed) 105 B — 🟢 -105 B 🟢 -96 B 🟢 -92 B

Status: 7 added / 7 removed / 3 unchanged

Editors & Dialogs — 124 kB (baseline 124 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyHubPublishDialog-Dh37ewCQ.js (removed) 90 kB — 🟢 -90 kB 🟢 -19.2 kB 🟢 -16.5 kB
assets/ComfyHubPublishDialog-DzAOPfUr.js (new) — 90 kB 🔴 +90 kB 🔴 +19.2 kB 🔴 +16.5 kB
assets/useShareDialog-Cp3ggtoZ.js (removed) 23.9 kB — 🟢 -23.9 kB 🟢 -5.69 kB 🟢 -5.03 kB
assets/useShareDialog-DZdRuAbA.js (new) — 23.9 kB 🔴 +23.9 kB 🔴 +5.69 kB 🔴 +5.04 kB
assets/feedbackDialog-DtFgwjo4.js (removed) 4.45 kB — 🟢 -4.45 kB 🟢 -1.86 kB 🟢 -1.59 kB
assets/feedbackDialog-DU-x9xWf.js (new) — 4.45 kB 🔴 +4.45 kB 🔴 +1.86 kB 🔴 +1.59 kB
assets/useRangeEditor-n95o1PJ_.js (removed) 3.23 kB — 🟢 -3.23 kB 🟢 -1.13 kB 🟢 -1.02 kB
assets/useRangeEditor-rRfUKhB4.js (new) — 3.23 kB 🔴 +3.23 kB 🔴 +1.13 kB 🔴 +1.02 kB
assets/ComfyHubPublishDialog-BSkrRKSJ.js (new) — 143 B 🔴 +143 B 🔴 +105 B 🔴 +90 B
assets/ComfyHubPublishDialog-C9wKD8lq.js (removed) 143 B — 🟢 -143 B 🟢 -105 B 🟢 -88 B
assets/useSubscriptionDialog-BMmtS9gP.js (removed) 108 B — 🟢 -108 B 🟢 -102 B 🟢 -89 B
assets/useSubscriptionDialog-CO0vIHqG.js (new) — 108 B 🔴 +108 B 🔴 +102 B 🔴 +80 B

Status: 6 added / 6 removed / 1 unchanged

UI Components — 70 kB (baseline 70 kB) • ⚪ 0 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyQueueButton-CbHKBQHm.js (removed) 13.5 kB — 🟢 -13.5 kB 🟢 -3.73 kB 🟢 -3.31 kB
assets/ComfyQueueButton-CT_Ic76k.js (new) — 13.5 kB 🔴 +13.5 kB 🔴 +3.73 kB 🔴 +3.31 kB
assets/useTerminalTabs-B9CTkTkp.js (removed) 11.8 kB — 🟢 -11.8 kB 🟢 -3.69 kB 🟢 -3.27 kB
assets/useTerminalTabs-BrNH6tTs.js (new) — 11.8 kB 🔴 +11.8 kB 🔴 +3.69 kB 🔴 +3.26 kB
assets/InviteMembersForm-Br_a1acC.js (new) — 7.96 kB 🔴 +7.96 kB 🔴 +2.65 kB 🔴 +2.36 kB
assets/InviteMembersForm-DfAcwm0q.js (removed) 7.96 kB — 🟢 -7.96 kB 🟢 -2.65 kB 🟢 -2.36 kB
assets/SubscribeButton-DQpZc9EA.js (removed) 2.13 kB — 🟢 -2.13 kB 🟢 -954 B 🟢 -834 B
assets/SubscribeButton-vi8UhRXB.js (new) — 2.13 kB 🔴 +2.13 kB 🔴 +954 B 🔴 +833 B
assets/cloudFeedbackTopbarButton-B-pAHVxg.js (removed) 705 B — 🟢 -705 B 🟢 -419 B 🟢 -360 B
assets/cloudFeedbackTopbarButton-DE6v3Vem.js (new) — 705 B 🔴 +705 B 🔴 +419 B 🔴 +362 B
assets/ComfyQueueButton-Cv15_z-h.js (new) — 128 B 🔴 +128 B 🔴 +99 B 🔴 +90 B
assets/ComfyQueueButton-kLDHpNCM.js (removed) 128 B — 🟢 -128 B 🟢 -99 B 🟢 -92 B

Status: 6 added / 6 removed / 9 unchanged

Data & Services — 3.44 MB (baseline 3.44 MB) • 🔴 +304 B

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/settingStore-DuFql3v1.js (new) — 3.17 MB 🔴 +3.17 MB 🔴 +734 kB 🔴 +553 kB
assets/settingStore-BwiYMaDL.js (removed) 3.17 MB — 🟢 -3.17 MB 🟢 -734 kB 🟢 -553 kB
assets/load3dService-CQdkg-Gd.js (new) — 132 kB 🔴 +132 kB 🔴 +29.2 kB 🔴 +24.6 kB
assets/load3dService-DwPJP6wH.js (removed) 132 kB — 🟢 -132 kB 🟢 -29.2 kB 🟢 -24.5 kB
assets/api-9VlTmb2Q.js (new) — 92 kB 🔴 +92 kB 🔴 +25.4 kB 🔴 +21.8 kB
assets/api-CqIaML8T.js (removed) 92 kB — 🟢 -92 kB 🟢 -25.4 kB 🟢 -21.9 kB
assets/workflowShareService-Bwyoebrx.js (removed) 16.4 kB — 🟢 -16.4 kB 🟢 -4.89 kB 🟢 -4.34 kB
assets/workflowShareService-Ctz7hc11.js (new) — 16.4 kB 🔴 +16.4 kB 🔴 +4.89 kB 🔴 +4.33 kB
assets/keybindingService-b3Pb4gJM.js (removed) 7.08 kB — 🟢 -7.08 kB 🟢 -1.82 kB 🟢 -1.58 kB
assets/keybindingService-Bk97BCW-.js (new) — 7.08 kB 🔴 +7.08 kB 🔴 +1.82 kB 🔴 +1.58 kB
assets/releaseStore-Cyve3pnf.js (new) — 6.72 kB 🔴 +6.72 kB 🔴 +2.03 kB 🔴 +1.77 kB
assets/releaseStore-D0sVNeGf.js (removed) 6.72 kB — 🟢 -6.72 kB 🟢 -2.03 kB 🟢 -1.77 kB
assets/systemStatsStore-C-uGOixZ.js (removed) 4.93 kB — 🟢 -4.93 kB 🟢 -1.74 kB 🟢 -1.47 kB
assets/systemStatsStore-HgUTxr-e.js (new) — 4.93 kB 🔴 +4.93 kB 🔴 +1.74 kB 🔴 +1.47 kB
assets/userStore-BBE71dtM.js (removed) 2.38 kB — 🟢 -2.38 kB 🟢 -898 B 🟢 -796 B
assets/userStore-C3WVL08m.js (new) — 2.38 kB 🔴 +2.38 kB 🔴 +897 B 🔴 +801 B
assets/audioService-CASaJ2J_.js (removed) 1.71 kB — 🟢 -1.71 kB 🟢 -831 B 🟢 -722 B
assets/audioService-Cy3-v0SO.js (new) — 1.71 kB 🔴 +1.71 kB 🔴 +828 B 🔴 +725 B
assets/dialogService-ClIxAkaC.js (removed) 98 B — 🟢 -98 B 🟢 -97 B 🟢 -83 B
assets/dialogService-CP-B33YQ.js (new) — 98 B 🔴 +98 B 🔴 +97 B 🔴 +81 B
assets/releaseStore-BM8ZLyF8.js (new) — 95 B 🔴 +95 B 🔴 +86 B 🔴 +85 B
assets/releaseStore-DexrtXlx.js (removed) 95 B — 🟢 -95 B 🟢 -86 B 🟢 -78 B
assets/settingStore-CW6VhOLx.js (removed) 95 B — 🟢 -95 B 🟢 -86 B 🟢 -78 B
assets/settingStore-DbKIMozC.js (new) — 95 B 🔴 +95 B 🔴 +86 B 🔴 +82 B
assets/assetsStore-CZffUFTk.js (removed) 94 B — 🟢 -94 B 🟢 -92 B 🟢 -84 B
assets/assetsStore-OW0c-0pf.js (new) — 94 B 🔴 +94 B 🔴 +92 B 🔴 +84 B
assets/api-fXiMEahu.js (new) — 62 B 🔴 +62 B 🔴 +74 B 🔴 +66 B
assets/api-m45BF4F7.js (removed) 62 B — 🟢 -62 B 🟢 -74 B 🟢 -66 B

Status: 14 added / 14 removed / 3 unchanged

Utilities & Hooks — 386 kB (baseline 386 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useConflictDetection-CQR04uHc.js (new) — 235 kB 🔴 +235 kB 🔴 +52.5 kB 🔴 +42.7 kB
assets/useConflictDetection-f-ZW6h87.js (removed) 235 kB — 🟢 -235 kB 🟢 -52.5 kB 🟢 -42.7 kB
assets/useLoad3d-DSw5eB0r.js (removed) 25.7 kB — 🟢 -25.7 kB 🟢 -5.79 kB 🟢 -5.13 kB
assets/useLoad3d-T0us21S3.js (new) — 25.7 kB 🔴 +25.7 kB 🔴 +5.79 kB 🔴 +5.14 kB
assets/useLoad3dViewer-CA_Iz6ZP.js (new) — 21.2 kB 🔴 +21.2 kB 🔴 +4.98 kB 🔴 +4.38 kB
assets/useLoad3dViewer-vK4s8tcg.js (removed) 21.2 kB — 🟢 -21.2 kB 🟢 -4.98 kB 🟢 -4.35 kB
assets/useImageCrop-CtAzv7RF.js (new) — 15 kB 🔴 +15 kB 🔴 +3.42 kB 🔴 +2.98 kB
assets/useImageCrop-DmZESRga.js (removed) 15 kB — 🟢 -15 kB 🟢 -3.42 kB 🟢 -2.98 kB
assets/useDowngradeToPersonal-Hmh7GaY_.js (new) — 8.85 kB 🔴 +8.85 kB 🔴 +2.53 kB 🔴 +2.17 kB
assets/useDowngradeToPersonal-nuipv_9W.js (removed) 8.85 kB — 🟢 -8.85 kB 🟢 -2.53 kB 🟢 -2.17 kB
assets/useFeatureFlags-KOa_ViIz.js (new) — 7.31 kB 🔴 +7.31 kB 🔴 +2.18 kB 🔴 +1.83 kB
assets/useFeatureFlags-qc4IXfnk.js (removed) 7.31 kB — 🟢 -7.31 kB 🟢 -2.18 kB 🟢 -1.83 kB
assets/assetPreviewUtil-f0Gfvzsj.js (removed) 2.35 kB — 🟢 -2.35 kB 🟢 -969 B 🟢 -847 B
assets/assetPreviewUtil-SeiZV9ZL.js (new) — 2.35 kB 🔴 +2.35 kB 🔴 +971 B 🔴 +843 B
assets/useUpstreamValue-CFWaLTHy.js (removed) 1.99 kB — 🟢 -1.99 kB 🟢 -757 B 🟢 -679 B
assets/useUpstreamValue-DppPXR_V.js (new) — 1.99 kB 🔴 +1.99 kB 🔴 +758 B 🔴 +669 B
assets/useWorkspaceTierLabel-CYO3wAgz.js (new) — 1.93 kB 🔴 +1.93 kB 🔴 +818 B 🔴 +696 B
assets/useWorkspaceTierLabel-DbA5ydoc.js (removed) 1.93 kB — 🟢 -1.93 kB 🟢 -813 B 🟢 -699 B
assets/subscriptionCheckoutUtil-DiVNUHha.js (removed) 841 B — 🟢 -841 B 🟢 -502 B 🟢 -424 B
assets/subscriptionCheckoutUtil-U1W2A5r9.js (new) — 841 B 🔴 +841 B 🔴 +502 B 🔴 +425 B
assets/useSessionCookie-CM9dgSpK.js (new) — 692 B 🔴 +692 B 🔴 +356 B 🔴 +308 B
assets/useSessionCookie-COY0UJ0c.js (removed) 692 B — 🟢 -692 B 🟢 -356 B 🟢 -307 B
assets/useLoad3d-CVQAl6Jr.js (new) — 311 B 🔴 +311 B 🔴 +162 B 🔴 +147 B
assets/useLoad3d-DC6Acucd.js (removed) 311 B — 🟢 -311 B 🟢 -163 B 🟢 -148 B
assets/useSessionCookie-CHtR6S27.js (removed) 101 B — 🟢 -101 B 🟢 -86 B 🟢 -85 B
assets/useSessionCookie-Cusx80HQ.js (new) — 101 B 🔴 +101 B 🔴 +86 B 🔴 +81 B
assets/useFeatureFlags-DEa4GayM.js (removed) 98 B — 🟢 -98 B 🟢 -85 B 🟢 -86 B
assets/useFeatureFlags-DpbUWtRv.js (new) — 98 B 🔴 +98 B 🔴 +85 B 🔴 +89 B
assets/useLoad3dViewer-Bnu4LYO7.js (removed) 98 B — 🟢 -98 B 🟢 -85 B 🟢 -85 B
assets/useLoad3dViewer-CfOwofA7.js (new) — 98 B 🔴 +98 B 🔴 +85 B 🔴 +89 B
assets/useCurrentUser-1229G3ES.js (removed) 94 B — 🟢 -94 B 🟢 -95 B 🟢 -85 B
assets/useCurrentUser-C20k5d_s.js (new) — 94 B 🔴 +94 B 🔴 +95 B 🔴 +85 B

Status: 16 added / 16 removed / 20 unchanged

Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 16 unchanged

Other — 12.7 MB (baseline 12.7 MB) • ⚪ 0 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/core-Bg9VIJJW.js (new) — 111 kB 🔴 +111 kB 🔴 +28.6 kB 🔴 +24.3 kB
assets/core-CODaEXlP.js (removed) 111 kB — 🟢 -111 kB 🟢 -28.6 kB 🟢 -24.3 kB
assets/WidgetSelect-Dg9uNW4_.js (new) — 88 kB 🔴 +88 kB 🔴 +19.9 kB 🔴 +17 kB
assets/WidgetSelect-J8RMdLMl.js (removed) 88 kB — 🟢 -88 kB 🟢 -19.9 kB 🟢 -17.1 kB
assets/Load3D-DaEvF1cI.js (removed) 71.3 kB — 🟢 -71.3 kB 🟢 -11.7 kB 🟢 -9.97 kB
assets/Load3D-DsekvYfi.js (new) — 71.3 kB 🔴 +71.3 kB 🔴 +11.7 kB 🔴 +9.97 kB
assets/WidgetVideoEdit-DOjI2Kyw.js (removed) 63.4 kB — 🟢 -63.4 kB 🟢 -14.6 kB 🟢 -12.8 kB
assets/WidgetVideoEdit-STwCsphN.js (new) — 63.4 kB 🔴 +63.4 kB 🔴 +14.6 kB 🔴 +12.9 kB
assets/WorkspaceSettingsPanelContent-C2GvLp-0.js (removed) 61.6 kB — 🟢 -61.6 kB 🟢 -13.1 kB 🟢 -11.4 kB
assets/WorkspaceSettingsPanelContent-DTlOJDQo.js (new) — 61.6 kB 🔴 +61.6 kB 🔴 +13.1 kB 🔴 +11.5 kB
assets/SubscriptionTransitionPreviewWorkspace-C752Fj-n.js (removed) 61.3 kB — 🟢 -61.3 kB 🟢 -12.5 kB 🟢 -10.9 kB
assets/SubscriptionTransitionPreviewWorkspace-Dmm_Z-7f.js (new) — 61.3 kB 🔴 +61.3 kB 🔴 +12.5 kB 🔴 +10.9 kB
assets/Preview3d-BOoVE2df.js (removed) 50.9 kB — 🟢 -50.9 kB 🟢 -8.3 kB 🟢 -7.25 kB
assets/Preview3d-Dcp5sYMU.js (new) — 50.9 kB 🔴 +50.9 kB 🔴 +8.3 kB 🔴 +7.24 kB
assets/main-Bjr-E_K4.js (removed) 46.9 kB — 🟢 -46.9 kB 🟢 -13.8 kB 🟢 -12 kB
assets/main-Cl2I2sK8.js (new) — 46.9 kB 🔴 +46.9 kB 🔴 +13.8 kB 🔴 +12 kB
assets/SubscriptionRequiredDialogContentUnified-BXsRYIZ1.js (removed) 42.7 kB — 🟢 -42.7 kB 🟢 -9.42 kB 🟢 -8.21 kB
assets/SubscriptionRequiredDialogContentUnified-D-iC0CkW.js (new) — 42.7 kB 🔴 +42.7 kB 🔴 +9.43 kB 🔴 +8.2 kB
assets/MembersPanelContent-D3MeRqTy.js (new) — 41.8 kB 🔴 +41.8 kB 🔴 +8.79 kB 🔴 +7.82 kB
assets/MembersPanelContent-Ddp8eBsQ.js (removed) 41.8 kB — 🟢 -41.8 kB 🟢 -8.79 kB 🟢 -7.83 kB
assets/WidgetBoundingBoxes-BIxVn2ri.js (removed) 33.7 kB — 🟢 -33.7 kB 🟢 -9.16 kB 🟢 -8.13 kB
assets/WidgetBoundingBoxes-CYEk7_Zz.js (new) — 33.7 kB 🔴 +33.7 kB 🔴 +9.16 kB 🔴 +8.13 kB
assets/WidgetPainter-BkXYlxFY.js (removed) 32.6 kB — 🟢 -32.6 kB 🟢 -7.87 kB 🟢 -6.95 kB
assets/WidgetPainter-CZnOkkXC.js (new) — 32.6 kB 🔴 +32.6 kB 🔴 +7.87 kB 🔴 +6.96 kB
assets/Load3dViewerContent-B7o86Tcn.js (new) — 30.8 kB 🔴 +30.8 kB 🔴 +6.26 kB 🔴 +5.44 kB
assets/Load3dViewerContent-CmD_1mp5.js (removed) 30.8 kB — 🟢 -30.8 kB 🟢 -6.26 kB 🟢 -5.43 kB
assets/SubscriptionPanelContentWorkspace-CoP4A-xi.js (removed) 29.5 kB — 🟢 -29.5 kB 🟢 -6.83 kB 🟢 -6 kB
assets/SubscriptionPanelContentWorkspace-DVTiv0OF.js (new) — 29.5 kB 🔴 +29.5 kB 🔴 +6.83 kB 🔴 +5.99 kB
assets/SubscriptionRequiredDialogContent-aWtWKW3x.js (new) — 26.1 kB 🔴 +26.1 kB 🔴 +6.14 kB 🔴 +5.41 kB
assets/SubscriptionRequiredDialogContent-C9POYpL5.js (removed) 26.1 kB — 🟢 -26.1 kB 🟢 -6.14 kB 🟢 -5.41 kB
assets/SubscriptionRequiredDialogContentWorkspace-eTqWpNty.js (removed) 25.1 kB — 🟢 -25.1 kB 🟢 -5.8 kB 🟢 -5.1 kB
assets/SubscriptionRequiredDialogContentWorkspace-UV2NQXJ1.js (new) — 25.1 kB 🔴 +25.1 kB 🔴 +5.8 kB 🔴 +5.11 kB
assets/load3d-CSIe2rRT.js (removed) 22.2 kB — 🟢 -22.2 kB 🟢 -5.4 kB 🟢 -4.67 kB
assets/load3d-D-PYhlHl.js (new) — 22.2 kB 🔴 +22.2 kB 🔴 +5.4 kB 🔴 +4.67 kB
assets/CurrentUserPopoverWorkspace-1k3rsbw-.js (removed) 20.5 kB — 🟢 -20.5 kB 🟢 -4.69 kB 🟢 -4.18 kB
assets/CurrentUserPopoverWorkspace-DhVSbsc9.js (new) — 20.5 kB 🔴 +20.5 kB 🔴 +4.69 kB 🔴 +4.17 kB
assets/SignInContent-B_YShTkW.js (new) — 20.2 kB 🔴 +20.2 kB 🔴 +5.1 kB 🔴 +4.46 kB
assets/SignInContent-C3E8QfMT.js (removed) 20.2 kB — 🟢 -20.2 kB 🟢 -5.1 kB 🟢 -4.46 kB
assets/CreditsTile-BnjZoAm8.js (new) — 17.2 kB 🔴 +17.2 kB 🔴 +4.55 kB 🔴 +4.01 kB
assets/CreditsTile-Xn815g2Y.js (removed) 17.2 kB — 🟢 -17.2 kB 🟢 -4.55 kB 🟢 -4.03 kB
assets/WidgetRecordAudio-BKrYmH5_.js (new) — 16.6 kB 🔴 +16.6 kB 🔴 +4.59 kB 🔴 +4.1 kB
assets/WidgetRecordAudio-DWCk6CfE.js (removed) 16.6 kB — 🟢 -16.6 kB 🟢 -4.6 kB 🟢 -4.09 kB
assets/WidgetInputNumber-BFnBcFG-.js (new) — 13.9 kB 🔴 +13.9 kB 🔴 +3.63 kB 🔴 +3.21 kB
assets/WidgetInputNumber-D--LapOs.js (removed) 13.9 kB — 🟢 -13.9 kB 🟢 -3.63 kB 🟢 -3.21 kB
assets/WidgetRange-BdHrSgSv.js (removed) 13.7 kB — 🟢 -13.7 kB 🟢 -3.53 kB 🟢 -3.12 kB
assets/WidgetRange-D7sLQAx7.js (new) — 13.7 kB 🔴 +13.7 kB 🔴 +3.53 kB 🔴 +3.12 kB
assets/WaveAudioPlayer-BBOhPhte.js (new) — 12.8 kB 🔴 +12.8 kB 🔴 +3.46 kB 🔴 +3.05 kB
assets/WaveAudioPlayer-ByPd29ci.js (removed) 12.8 kB — 🟢 -12.8 kB 🟢 -3.46 kB 🟢 -3.05 kB
assets/WidgetCurve-BtblWhg5.js (new) — 11.2 kB 🔴 +11.2 kB 🔴 +3.47 kB 🔴 +3.15 kB
assets/WidgetCurve-egCkmddM.js (removed) 11.2 kB — 🟢 -11.2 kB 🟢 -3.47 kB 🟢 -3.15 kB
assets/TeamWorkspacesDialogContent-BbIBW5Fg.js (removed) 10.3 kB — 🟢 -10.3 kB 🟢 -2.97 kB 🟢 -2.63 kB
assets/TeamWorkspacesDialogContent-NrUzcuEt.js (new) — 10.3 kB 🔴 +10.3 kB 🔴 +2.97 kB 🔴 +2.63 kB
assets/onboardingCloudRoutes-CVRcm4tm.js (removed) 9.07 kB — 🟢 -9.07 kB 🟢 -2.78 kB 🟢 -2.4 kB
assets/onboardingCloudRoutes-t8LA8AkD.js (new) — 9.07 kB 🔴 +9.07 kB 🔴 +2.78 kB 🔴 +2.4 kB
assets/Load3DConfiguration-CToMSp3h.js (removed) 8.91 kB — 🟢 -8.91 kB 🟢 -2.61 kB 🟢 -2.29 kB
assets/Load3DConfiguration-nHcCsbqp.js (new) — 8.91 kB 🔴 +8.91 kB 🔴 +2.61 kB 🔴 +2.3 kB
assets/WidgetImageCrop-gAiJphg1.js (new) — 8.49 kB 🔴 +8.49 kB 🔴 +2.65 kB 🔴 +2.34 kB
assets/WidgetImageCrop-tmXEwtKN.js (removed) 8.49 kB — 🟢 -8.49 kB 🟢 -2.65 kB 🟢 -2.33 kB
assets/SetMemberCreditLimitDialogContent-BUw3bEJi.js (removed) 8.47 kB — 🟢 -8.47 kB 🟢 -2.34 kB 🟢 -2.05 kB
assets/SetMemberCreditLimitDialogContent-CsCHAN87.js (new) — 8.47 kB 🔴 +8.47 kB 🔴 +2.34 kB 🔴 +2.04 kB
assets/nodeTemplates-D4RJpdvH.js (new) — 8.28 kB 🔴 +8.28 kB 🔴 +2.84 kB 🔴 +2.5 kB
assets/nodeTemplates-IdeJE6v-.js (removed) 8.28 kB — 🟢 -8.28 kB 🟢 -2.84 kB 🟢 -2.5 kB
assets/NightlySurveyController-BqL7BwUT.js (removed) 7.5 kB — 🟢 -7.5 kB 🟢 -2.55 kB 🟢 -2.24 kB
assets/NightlySurveyController-D5Q5xQdh.js (new) — 7.5 kB 🔴 +7.5 kB 🔴 +2.55 kB 🔴 +2.24 kB
assets/WidgetWithControl-B0_sXLbr.js (removed) 6.35 kB — 🟢 -6.35 kB 🟢 -2.57 kB 🟢 -2.29 kB
assets/WidgetWithControl-CfTnX6GF.js (new) — 6.35 kB 🔴 +6.35 kB 🔴 +2.57 kB 🔴 +2.3 kB
assets/tierBenefits-DSTBTZ1T.js (removed) 6.2 kB — 🟢 -6.2 kB 🟢 -1.96 kB 🟢 -1.71 kB
assets/tierBenefits-ysc4wYr7.js (new) — 6.2 kB 🔴 +6.2 kB 🔴 +1.96 kB 🔴 +1.72 kB
assets/CancelSubscriptionDialogContent-Bc-ZY_qc.js (new) — 5.97 kB 🔴 +5.97 kB 🔴 +1.98 kB 🔴 +1.74 kB
assets/CancelSubscriptionDialogContent-Dg1vT97u.js (removed) 5.97 kB — 🟢 -5.97 kB 🟢 -1.98 kB 🟢 -1.74 kB
assets/load3dPreviewExtensions-DCkm9ayA.js (new) — 5.88 kB 🔴 +5.88 kB 🔴 +1.81 kB 🔴 +1.6 kB
assets/load3dPreviewExtensions-DhO2l1Aw.js (removed) 5.88 kB — 🟢 -5.88 kB 🟢 -1.81 kB 🟢 -1.59 kB
assets/missingModelDownload-7iu4zSmz.js (removed) 5.88 kB — 🟢 -5.88 kB 🟢 -2.07 kB 🟢 -1.81 kB
assets/missingModelDownload-CusEnnIA.js (new) — 5.88 kB 🔴 +5.88 kB 🔴 +2.07 kB 🔴 +1.81 kB
assets/launchCancellationFlow-CIZliHpi.js (new) — 5.18 kB 🔴 +5.18 kB 🔴 +1.78 kB 🔴 +1.56 kB
assets/launchCancellationFlow-iTfqGMof.js (removed) 5.18 kB — 🟢 -5.18 kB 🟢 -1.78 kB 🟢 -1.56 kB
assets/CreateWorkspaceDialogContent-B_XGnQ-8.js (removed) 5.12 kB — 🟢 -5.12 kB 🟢 -1.79 kB 🟢 -1.55 kB
assets/CreateWorkspaceDialogContent-HFtZ1I7a.js (new) — 5.12 kB 🔴 +5.12 kB 🔴 +1.79 kB 🔴 +1.55 kB
assets/ChangeMemberRoleDialogContent-DGH5RWjC.js (removed) 4.97 kB — 🟢 -4.97 kB 🟢 -1.63 kB 🟢 -1.43 kB
assets/ChangeMemberRoleDialogContent-Fm9x47EY.js (new) — 4.97 kB 🔴 +4.97 kB 🔴 +1.63 kB 🔴 +1.42 kB
assets/EditWorkspaceDialogContent-BBPKpRTx.js (removed) 4.93 kB — 🟢 -4.93 kB 🟢 -1.76 kB 🟢 -1.53 kB
assets/EditWorkspaceDialogContent-CJyalfWK.js (new) — 4.93 kB 🔴 +4.93 kB 🔴 +1.76 kB 🔴 +1.52 kB
assets/WidgetTextarea-CmYTALd8.js (removed) 4.81 kB — 🟢 -4.81 kB 🟢 -1.87 kB 🟢 -1.63 kB
assets/WidgetTextarea-DKekvZVo.js (new) — 4.81 kB 🔴 +4.81 kB 🔴 +1.87 kB 🔴 +1.62 kB
assets/saveMesh-CO2fZGrc.js (new) — 4.76 kB 🔴 +4.76 kB 🔴 +1.52 kB 🔴 +1.34 kB
assets/saveMesh-DTxgA4vH.js (removed) 4.76 kB — 🟢 -4.76 kB 🟢 -1.52 kB 🟢 -1.35 kB
assets/WorkspacePanelContent-B0itfxyf.js (new) — 4.72 kB 🔴 +4.72 kB 🔴 +1.6 kB 🔴 +1.4 kB
assets/WorkspacePanelContent-CXs99NxN.js (removed) 4.72 kB — 🟢 -4.72 kB 🟢 -1.6 kB 🟢 -1.4 kB
assets/InviteMemberDialogContent-DK-hTear.js (removed) 4.68 kB — 🟢 -4.68 kB 🟢 -1.58 kB 🟢 -1.38 kB
assets/InviteMemberDialogContent-yonjkh2X.js (new) — 4.68 kB 🔴 +4.68 kB 🔴 +1.58 kB 🔴 +1.37 kB
assets/ValueControlPopover-B6izqV77.js (removed) 4.49 kB — 🟢 -4.49 kB 🟢 -1.54 kB 🟢 -1.38 kB
assets/ValueControlPopover-Bg-Gjzim.js (new) — 4.49 kB 🔴 +4.49 kB 🔴 +1.55 kB 🔴 +1.38 kB
assets/DeleteWorkspaceDialogContent-BMIJhqbp.js (new) — 3.84 kB 🔴 +3.84 kB 🔴 +1.44 kB 🔴 +1.23 kB
assets/DeleteWorkspaceDialogContent-BOTk25Pz.js (removed) 3.84 kB — 🟢 -3.84 kB 🟢 -1.44 kB 🟢 -1.23 kB
assets/LeaveWorkspaceDialogContent-CAPvSK4Q.js (new) — 3.67 kB 🔴 +3.67 kB 🔴 +1.38 kB 🔴 +1.19 kB
assets/LeaveWorkspaceDialogContent-CIBC__U1.js (removed) 3.67 kB — 🟢 -3.67 kB 🟢 -1.38 kB 🟢 -1.18 kB
assets/RemoveMemberDialogContent-B1Csqdth.js (removed) 3.65 kB — 🟢 -3.65 kB 🟢 -1.34 kB 🟢 -1.15 kB
assets/RemoveMemberDialogContent-DcYOTfZw.js (new) — 3.65 kB 🔴 +3.65 kB 🔴 +1.33 kB 🔴 +1.15 kB
assets/RevokeInviteDialogContent-BhFF2b_m.js (new) — 3.56 kB 🔴 +3.56 kB 🔴 +1.35 kB 🔴 +1.17 kB
assets/RevokeInviteDialogContent-DX39F1P9.js (removed) 3.56 kB — 🟢 -3.56 kB 🟢 -1.35 kB 🟢 -1.17 kB
assets/InviteMemberUpsellDialogContent-DL6oLqbi.js (removed) 3.44 kB — 🟢 -3.44 kB 🟢 -1.23 kB 🟢 -1.09 kB
assets/InviteMemberUpsellDialogContent-irciLBcF.js (new) — 3.44 kB 🔴 +3.44 kB 🔴 +1.23 kB 🔴 +1.08 kB
assets/workspaceCheckoutTelemetry-ChGnZuY9.js (new) — 3.4 kB 🔴 +3.4 kB 🔴 +1.52 kB 🔴 +1.33 kB
assets/workspaceCheckoutTelemetry-D-vlvkkd.js (removed) 3.4 kB — 🟢 -3.4 kB 🟢 -1.52 kB 🟢 -1.33 kB
assets/Media3DTop-CFw00sK-.js (new) — 3.21 kB 🔴 +3.21 kB 🔴 +1.26 kB 🔴 +1.1 kB
assets/Media3DTop-DV3Ri-BF.js (removed) 3.21 kB — 🟢 -3.21 kB 🟢 -1.26 kB 🟢 -1.1 kB
assets/GlobalToast-Bq4E38IJ.js (new) — 3 kB 🔴 +3 kB 🔴 +1.22 kB 🔴 +1.08 kB
assets/GlobalToast-C69tKNOB.js (removed) 3 kB — 🟢 -3 kB 🟢 -1.22 kB 🟢 -1.04 kB
assets/load3dAdvanced-Dl3Ni3x_.js (new) — 2.82 kB 🔴 +2.82 kB 🔴 +1.09 kB 🔴 +954 B
assets/load3dAdvanced-DZ1wamvn.js (removed) 2.82 kB — 🟢 -2.82 kB 🟢 -1.09 kB 🟢 -955 B
assets/SubscribeToRun-D-SVsB3L.js (new) — 2.39 kB 🔴 +2.39 kB 🔴 +1.03 kB 🔴 +901 B
assets/SubscribeToRun-l2cbsqaV.js (removed) 2.39 kB — 🟢 -2.39 kB 🟢 -1.03 kB 🟢 -902 B
assets/MediaAudioTop-CuRAA3kR.js (removed) 1.62 kB — 🟢 -1.62 kB 🟢 -804 B 🟢 -664 B
assets/MediaAudioTop-DUAMEIJO.js (new) — 1.62 kB 🔴 +1.62 kB 🔴 +805 B 🔴 +664 B
assets/CloudRunButtonWrapper-DZlMi7rY.js (removed) 1.05 kB — 🟢 -1.05 kB 🟢 -513 B 🟢 -451 B
assets/CloudRunButtonWrapper-iUmPlE97.js (new) — 1.05 kB 🔴 +1.05 kB 🔴 +515 B 🔴 +470 B
assets/cloudSessionCookie-BJee334T.js (removed) 933 B — 🟢 -933 B 🟢 -431 B 🟢 -378 B
assets/cloudSessionCookie-CUszhBww.js (new) — 933 B 🔴 +933 B 🔴 +431 B 🔴 +379 B
assets/cloudBadges-BY2vFxdW.js (new) — 922 B 🔴 +922 B 🔴 +514 B 🔴 +432 B
assets/cloudBadges-CeRbujpP.js (removed) 922 B — 🟢 -922 B 🟢 -511 B 🟢 -436 B
assets/Load3DAdvanced-C7VmAcHX.js (removed) 761 B — 🟢 -761 B 🟢 -422 B 🟢 -357 B
assets/Load3DAdvanced-DnL3jHEc.js (new) — 761 B 🔴 +761 B 🔴 +421 B 🔴 +360 B
assets/nightlyBadges-DK3dI8EU.js (removed) 411 B — 🟢 -411 B 🟢 -270 B 🟢 -231 B
assets/nightlyBadges-DWWC3WLV.js (new) — 411 B 🔴 +411 B 🔴 +270 B 🔴 +229 B
assets/missingModelDownload-D3aSLsis.js (new) — 371 B 🔴 +371 B 🔴 +203 B 🔴 +173 B
assets/missingModelDownload-DOoWj0wd.js (removed) 371 B — 🟢 -371 B 🟢 -205 B 🟢 -177 B
assets/SubscriptionPanelContentWorkspace-BWbo65-U.js (new) — 179 B 🔴 +179 B 🔴 +117 B 🔴 +109 B
assets/SubscriptionPanelContentWorkspace-CeWzgRu2.js (removed) 179 B — 🟢 -179 B 🟢 -117 B 🟢 -90 B
assets/Load3dViewerContent-BajGNKM_.js (removed) 137 B — 🟢 -137 B 🟢 -103 B 🟢 -93 B
assets/Load3dViewerContent-QdBqhHGw.js (new) — 137 B 🔴 +137 B 🔴 +103 B 🔴 +91 B
assets/Load3DAdvanced-DgbXDCNG.js (new) — 122 B 🔴 +122 B 🔴 +97 B 🔴 +88 B
assets/Load3DAdvanced-Y-KVkITa.js (removed) 122 B — 🟢 -122 B 🟢 -97 B 🟢 -91 B
assets/WidgetLegacy-CFQcSoaA.js (new) — 117 B 🔴 +117 B 🔴 +106 B 🔴 +102 B
assets/WidgetLegacy-CvQYnBp8.js (removed) 117 B — 🟢 -117 B 🟢 -106 B 🟢 -102 B
assets/workflowDraftStoreV2-CRedw5ZL.js (new) — 112 B 🔴 +112 B 🔴 +101 B 🔴 +109 B
assets/workflowDraftStoreV2-DOWb2VLr.js (removed) 112 B — 🟢 -112 B 🟢 -101 B 🟢 -111 B
assets/Load3D-_nbz8Wrv.js (new) — 98 B 🔴 +98 B 🔴 +89 B 🔴 +82 B
assets/Load3D-C-J9WFq9.js (removed) 98 B — 🟢 -98 B 🟢 -89 B 🟢 -81 B
assets/changeTracker-B6Dcbg9l.js (removed) 91 B — 🟢 -91 B 🟢 -93 B 🟢 -83 B
assets/changeTracker-DWb6VWXX.js (new) — 91 B 🔴 +91 B 🔴 +93 B 🔴 +86 B

Status: 70 added / 70 removed / 210 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.6 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.9 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.1 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.8 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.5 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.9 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.3 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 124ms TBT · 92.2 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.5 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 158.5 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 38ms TBT · 164.7 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 48.7 MB heap

⚠️ 1 regression detected

Show regressions
Metric Baseline PR (median) Δ Sig
canvas-idle: task duration 452ms 457ms +1% ⚠️ z=2.0
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms +0% z=-0.1
canvas-idle: p95 frame time 17ms 17ms -1% —
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 9ms 6ms -33% z=-5.6
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 10 10 -5% z=-2.9
canvas-idle: task duration 452ms 457ms +1% ⚠️ z=2.0
canvas-idle: script duration 14ms 15ms +1% z=-4.8
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 69.5 MB 69.2 MB -0% —
canvas-idle: DOM nodes 20 19 -5% z=-2.8
canvas-idle: event listeners 4 5 +25% z=-1.4
canvas-mouse-sweep: avg frame time 17ms 17ms +0% z=-0.4
canvas-mouse-sweep: p95 frame time 17ms 17ms -0% —
canvas-mouse-sweep: layout duration 4ms 3ms -6% z=-1.4
canvas-mouse-sweep: style recalc duration 37ms 28ms -23% z=-4.5
canvas-mouse-sweep: layout count 12 12 +0% —
canvas-mouse-sweep: style recalc count 74 73 -2% z=-2.6
canvas-mouse-sweep: task duration 849ms 702ms -17% z=-2.8
canvas-mouse-sweep: script duration 118ms 89ms -25% z=-7.2
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 52.2 MB 55.6 MB +7% —
canvas-mouse-sweep: DOM nodes -277 -112 -60% z=-67.4
canvas-mouse-sweep: event listeners -148 -71 -52% z=-19.1
canvas-zoom-sweep: avg frame time 17ms 17ms -0% z=-0.3
canvas-zoom-sweep: p95 frame time 17ms 17ms -0% —
canvas-zoom-sweep: layout duration 1ms 1ms +13% z=0.1
canvas-zoom-sweep: style recalc duration 16ms 13ms -17% z=-3.7
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 31 31 +0% z=-0.6
canvas-zoom-sweep: task duration 362ms 330ms -9% z=0.1
canvas-zoom-sweep: script duration 17ms 16ms -6% z=-3.7
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 72.3 MB 72.3 MB +0% —
canvas-zoom-sweep: DOM nodes 77 78 +1% z=-2.2
canvas-zoom-sweep: event listeners 19 21 +11% z=-0.5
dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.5
dom-widget-clipping: p95 frame time 17ms 17ms -1% —
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 8ms 6ms -24% z=-5.1
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 11 13 +14% z=-1.2
dom-widget-clipping: task duration 364ms 313ms -14% z=-3.1
dom-widget-clipping: script duration 56ms 45ms -21% z=-7.1
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 53.2 MB 53.1 MB -0% —
dom-widget-clipping: DOM nodes 18 21 +17% z=-0.8
dom-widget-clipping: event listeners 0 0 +0% variance too high
large-graph-idle: avg frame time 17ms 17ms +0% z=-0.2
large-graph-idle: p95 frame time 17ms 17ms +0% —
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 8ms 6ms -26% z=-6.3
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 9 9 +0% z=-8.3
large-graph-idle: task duration 657ms 583ms -11% z=0.8
large-graph-idle: script duration 101ms 77ms -24% z=-2.5
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 63.6 MB 63.9 MB +0% —
large-graph-idle: DOM nodes -281 -281 +0% z=-338.2
large-graph-idle: event listeners -142 -144 +1% z=-27.9
large-graph-pan: avg frame time 17ms 17ms +0% z=0.3
large-graph-pan: p95 frame time 17ms 17ms -0% —
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 12ms 13ms +6% z=-5.2
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 68 70 +2% z=-0.1
large-graph-pan: task duration 1244ms 1064ms -14% z=-0.4
large-graph-pan: script duration 424ms 337ms -20% z=-3.6
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 62.9 MB 62.1 MB -1% —
large-graph-pan: DOM nodes -284 -281 -1% z=-181.5
large-graph-pan: event listeners -144 -143 -1% z=-178.6
large-graph-zoom: avg frame time 17ms 17ms -0% —
large-graph-zoom: p95 frame time 17ms 17ms +0% —
large-graph-zoom: layout duration 7ms 8ms +21% —
large-graph-zoom: style recalc duration 15ms 14ms -0% —
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 66 65 -2% —
large-graph-zoom: task duration 1466ms 1266ms -14% —
large-graph-zoom: script duration 512ms 400ms -22% —
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 57.5 MB 67.8 MB +18% —
large-graph-zoom: DOM nodes -287 -138 -52% —
large-graph-zoom: event listeners -148 -70 -53% —
minimap-idle: avg frame time 17ms 17ms -0% z=-0.9
minimap-idle: p95 frame time 17ms 17ms +0% —
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 7ms 5ms -25% z=-5.0
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 8 9 +6% z=-1.6
minimap-idle: task duration 650ms 578ms -11% z=1.1
minimap-idle: script duration 101ms 75ms -26% z=-2.4
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 65.1 MB 65.4 MB +0% —
minimap-idle: DOM nodes -282 -282 -0% z=-219.8
minimap-idle: event listeners -144 -144 +0% z=-225.0
subgraph-dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.7
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms +0% —
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 10ms 8ms -16% z=-4.9
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 47 48 +1% z=-0.8
subgraph-dom-widget-clipping: task duration 392ms 326ms -17% z=-2.8
subgraph-dom-widget-clipping: script duration 116ms 92ms -21% z=-5.7
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 53.9 MB 53.5 MB -1% —
subgraph-dom-widget-clipping: DOM nodes 20 21 +5% z=-1.1
subgraph-dom-widget-clipping: event listeners 6 7 +17% z=-1.6
subgraph-idle: avg frame time 17ms 17ms +0% z=0.4
subgraph-idle: p95 frame time 17ms 17ms -0% —
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 9ms 7ms -21% z=-4.6
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 10 11 +5% z=-0.6
subgraph-idle: task duration 467ms 422ms -10% z=1.7
subgraph-idle: script duration 12ms 12ms +2% z=-2.9
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 44.5 MB 56.9 MB +28% —
subgraph-idle: DOM nodes -281 -128 -54% z=-100.2
subgraph-idle: event listeners -148 -70 -53% variance too high
subgraph-mouse-sweep: avg frame time 17ms 17ms +0% z=0.8
subgraph-mouse-sweep: p95 frame time 17ms 17ms +1% —
subgraph-mouse-sweep: layout duration 4ms 3ms -8% z=-4.1
subgraph-mouse-sweep: style recalc duration 34ms 28ms -17% z=-4.4
subgraph-mouse-sweep: layout count 16 16 +0% —
subgraph-mouse-sweep: style recalc count 75 77 +2% z=-1.9
subgraph-mouse-sweep: task duration 763ms 628ms -18% z=-2.0
subgraph-mouse-sweep: script duration 85ms 64ms -25% z=-5.7
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 46.0 MB 60.3 MB +31% —
subgraph-mouse-sweep: DOM nodes -278 66 -124% z=-0.6
subgraph-mouse-sweep: event listeners -148 5 -103% variance too high
subgraph-transition-enter: avg frame time 17ms 17ms +0% —
subgraph-transition-enter: p95 frame time 17ms 17ms +0% —
subgraph-transition-enter: layout duration 13ms 8ms -33% —
subgraph-transition-enter: style recalc duration 30ms 23ms -22% —
subgraph-transition-enter: layout count 14 15 +7% —
subgraph-transition-enter: style recalc count 18 19 +6% —
subgraph-transition-enter: task duration 925ms 746ms -19% —
subgraph-transition-enter: script duration 31ms 21ms -33% —
subgraph-transition-enter: TBT 149ms 124ms -17% —
subgraph-transition-enter: heap used 94.8 MB 92.2 MB -3% —
subgraph-transition-enter: DOM nodes 13673 13673 +0% —
subgraph-transition-enter: event listeners 2371 2369 -0% —
viewport-pan-sweep: avg frame time 17ms 17ms +0% —
viewport-pan-sweep: p95 frame time 17ms 17ms -1% —
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 35ms 38ms +8% —
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 250 249 -0% —
viewport-pan-sweep: task duration 4306ms 3796ms -12% —
viewport-pan-sweep: script duration 1334ms 1107ms -17% —
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 66.6 MB 64.5 MB -3% —
viewport-pan-sweep: DOM nodes -281 -279 -1% —
viewport-pan-sweep: event listeners -128 -128 +0% —
vue-large-graph-idle: avg frame time 18ms 17ms -3% —
vue-large-graph-idle: p95 frame time 17ms 17ms +0% —
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 16542ms 13494ms -18% —
vue-large-graph-idle: script duration 532ms 482ms -9% —
vue-large-graph-idle: TBT 0ms 0ms +0% —
vue-large-graph-idle: heap used 159.1 MB 158.5 MB -0% —
vue-large-graph-idle: DOM nodes -8312 -8312 +0% —
vue-large-graph-idle: event listeners -16387 -16389 +0% —
vue-large-graph-pan: avg frame time 18ms 18ms -2% —
vue-large-graph-pan: p95 frame time 17ms 17ms -0% —
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 15ms 15ms +1% —
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 137 94 -32% —
vue-large-graph-pan: task duration 20194ms 16434ms -19% —
vue-large-graph-pan: script duration 903ms 794ms -12% —
vue-large-graph-pan: TBT 102ms 38ms -63% —
vue-large-graph-pan: heap used 169.0 MB 164.7 MB -3% —
vue-large-graph-pan: DOM nodes -8312 -8312 +0% —
vue-large-graph-pan: event listeners -16385 -16386 +0% —
workflow-execution: avg frame time 17ms 17ms -0% z=0.1
workflow-execution: p95 frame time 17ms 17ms +0% —
workflow-execution: layout duration 1ms 1ms -19% z=-4.7
workflow-execution: style recalc duration 21ms 16ms -24% z=-3.9
workflow-execution: layout count 3 3 +0% z=-3.6
workflow-execution: style recalc count 14 17 +21% z=-0.4
workflow-execution: task duration 112ms 98ms -13% z=-2.3
workflow-execution: script duration 9ms 7ms -19% z=-7.3
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 48.6 MB 48.7 MB +0% —
workflow-execution: DOM nodes 121 138 +14% z=-3.3
workflow-execution: event listeners 65 66 +2% z=3.2
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 11ms 1ms 8.2%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 11 1 5.0%
canvas-idle: task duration 395ms 31ms 7.9%
canvas-idle: script duration 25ms 2ms 8.8%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: DOM nodes 23 1 5.6%
canvas-idle: event listeners 12 5 40.9%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: layout duration 4ms 0ms 5.4%
canvas-mouse-sweep: style recalc duration 43ms 3ms 7.4%
canvas-mouse-sweep: layout count 12 0 0.0%
canvas-mouse-sweep: style recalc count 79 2 3.0%
canvas-mouse-sweep: task duration 865ms 58ms 6.7%
canvas-mouse-sweep: script duration 136ms 6ms 4.8%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: DOM nodes 62 3 4.2%
canvas-mouse-sweep: event listeners 8 4 49.4%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: layout duration 1ms 0ms 7.0%
canvas-zoom-sweep: style recalc duration 19ms 2ms 8.0%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 0 1.5%
canvas-zoom-sweep: task duration 327ms 23ms 7.1%
canvas-zoom-sweep: script duration 27ms 3ms 11.1%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: DOM nodes 79 1 1.0%
canvas-zoom-sweep: event listeners 24 5 21.8%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 10ms 1ms 8.0%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 13 0 3.8%
dom-widget-clipping: task duration 365ms 16ms 4.5%
dom-widget-clipping: script duration 68ms 3ms 4.8%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: DOM nodes 22 1 6.4%
dom-widget-clipping: event listeners 8 6 81.2%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 12ms 1ms 8.6%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 12 0 2.7%
large-graph-idle: task duration 542ms 54ms 10.0%
large-graph-idle: script duration 102ms 11ms 10.3%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: DOM nodes 25 1 3.7%
large-graph-idle: event listeners 26 6 23.2%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 17ms 1ms 4.6%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 70 1 0.9%
large-graph-pan: task duration 1082ms 43ms 4.0%
large-graph-pan: script duration 408ms 20ms 4.8%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: DOM nodes 19 2 8.7%
large-graph-pan: event listeners 5 1 16.8%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 10ms 1ms 8.6%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 10 1 7.1%
minimap-idle: task duration 527ms 47ms 9.0%
minimap-idle: script duration 98ms 10ms 10.1%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: DOM nodes 19 1 7.1%
minimap-idle: event listeners 5 1 14.4%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 13ms 1ms 7.4%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 48 1 1.2%
subgraph-dom-widget-clipping: task duration 378ms 18ms 4.9%
subgraph-dom-widget-clipping: script duration 128ms 6ms 4.9%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: DOM nodes 22 1 5.0%
subgraph-dom-widget-clipping: event listeners 16 6 36.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 10ms 1ms 7.5%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 11 1 6.0%
subgraph-idle: task duration 370ms 31ms 8.5%
subgraph-idle: script duration 20ms 3ms 13.2%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: DOM nodes 22 1 6.9%
subgraph-idle: event listeners 10 7 64.5%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: layout duration 5ms 0ms 6.8%
subgraph-mouse-sweep: style recalc duration 42ms 3ms 7.8%
subgraph-mouse-sweep: layout count 16 0 0.0%
subgraph-mouse-sweep: style recalc count 80 2 2.4%
subgraph-mouse-sweep: task duration 766ms 69ms 9.0%
subgraph-mouse-sweep: script duration 101ms 7ms 6.5%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: DOM nodes 67 2 3.3%
subgraph-mouse-sweep: event listeners 8 4 52.6%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: layout duration 2ms 0ms 9.4%
workflow-execution: style recalc duration 24ms 2ms 9.1%
workflow-execution: layout count 5 1 11.0%
workflow-execution: style recalc count 18 2 11.5%
workflow-execution: task duration 123ms 11ms 8.8%
workflow-execution: script duration 29ms 3ms 10.2%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: DOM nodes 161 7 4.4%
workflow-execution: event listeners 52 4 8.4%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▆▃▆▁▆▃▆█▆▆▄▃▃▄▃ ➡️ 17ms
canvas-idle: p95 frame time ➡️ NaNms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▇▇▆▆▃█▄▃▄▃▇▄▁▆▇ ➡️ 11ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count █▃▅▂▅▆▃▁▂▁▂▅▆▅▆ ➡️ 12
canvas-idle: task duration ▃▃▃▆▂▃▃▅▆▂█▃▁▃▃ ➡️ 391ms
canvas-idle: script duration ▄▃▅▇▂▅▃▆▇▅█▄▁▅▆ ➡️ 27ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ➡️ NaN MB
canvas-idle: DOM nodes █▇▆▅▃▇▃▁▂▂▅▆▆▆▇ ➡️ 24
canvas-idle: event listeners ▅█▅▄▁▅▁▁▁▄▅▅▁▅▄ 📉 11
canvas-mouse-sweep: avg frame time ▆█▆▃▁▃▁▆▆▁▃▆▆▃▃ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ➡️ NaNms
canvas-mouse-sweep: layout duration ▁▃▂▄▁▂▁▃▆▂█▇▆▄▃ ➡️ 4ms
canvas-mouse-sweep: style recalc duration ▄▄▂▄▁▂▃▃▅▄█▆▂▄▄ ➡️ 43ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: style recalc count █▅▄▃▂▂▁▄▄▅▆▅▂▇▄ ➡️ 79
canvas-mouse-sweep: task duration █▆▄▂▂▃▂▄▄▅█▆▁▆▄ ➡️ 868ms
canvas-mouse-sweep: script duration ▄▅▄▆▄▆▆▆▅▅█▆▁▅▆ ➡️ 139ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ➡️ NaN MB
canvas-mouse-sweep: DOM nodes █▅▃▃▁▂▂▃▂▄▆▅▃▅▅ ➡️ 64
canvas-mouse-sweep: event listeners █▁▁▁▁▁▇▁▁▁██▇▁█ 📈 13
canvas-zoom-sweep: avg frame time ▅▅█▄▅▁▁▁▅▁▁▅▄▅▁ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ➡️ NaNms
canvas-zoom-sweep: layout duration ▆▅▅▄▁▁█▅▃▅▇▆▁▂▆ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▆▅▄▆▅▃█▆▇▅▇▄▁▃▅ ➡️ 20ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▁▁▃▄▆▃▆█▄▄▆▁▆▁▆ ➡️ 32
canvas-zoom-sweep: task duration ▄▂▁▇▂▂▄▅▆▃█▄▁▁▅ ➡️ 338ms
canvas-zoom-sweep: script duration ▃▃▂▇▂▂▅▇▆▅█▄▁▂▆ ➡️ 30ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ➡️ NaN MB
canvas-zoom-sweep: DOM nodes ▄▃▁▅█▁▃▆▄▅▅▃▃▄▃ ➡️ 79
canvas-zoom-sweep: event listeners ▁▁▂▅█▂▁▅▁▅▅▄▁▅▁ ➡️ 19
dom-widget-clipping: avg frame time ▂▄▅▅▂▄█▇▅▇▇▅▅▁▇ ➡️ 17ms
dom-widget-clipping: p95 frame time ➡️ NaNms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▆▆▂▆▄▃██▄▁▆▇▆▃▅ ➡️ 10ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▇█▅█▅▄█▇▇▁▇▄▇▂▅ ➡️ 13
dom-widget-clipping: task duration ▃▃▁▅▄▃▅▆▅▂▇█▁▅▅ ➡️ 371ms
dom-widget-clipping: script duration ▅▄▄▆▆▅▇▇▆▃█▇▁▇▇ ➡️ 71ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ➡️ NaN MB
dom-widget-clipping: DOM nodes ▇▇▄▇▅▄█▇▅▁▅▄▇▃▄ ➡️ 21
dom-widget-clipping: event listeners ▅▅▅▅▁▅██▁▁▁▁█▁▁ 📉 2
large-graph-idle: avg frame time ▅▅▅▅▅▂▁▂▄▅▄▂▂▅█ ➡️ 17ms
large-graph-idle: p95 frame time ➡️ NaNms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▅▅▅▆▄▅▃▄▅▅▆█▁▄▆ ➡️ 13ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count █▆█▃▃▁▃▆▃▆▆▃▆██ ➡️ 12
large-graph-idle: task duration ▂▃▂▆▂▃▃▇▅▃██▁▂▅ ➡️ 569ms
large-graph-idle: script duration ▄▅▄▆▄▅▅▇▆▅█▆▁▃▆ ➡️ 110ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ➡️ NaN MB
large-graph-idle: DOM nodes ▆█▅▂▅▃▁▂▃▅▅▆▂▆▅ ➡️ 25
large-graph-idle: event listeners ███▇██▄▁▄▇▇█▂█▇ ➡️ 29
large-graph-pan: avg frame time ▆▃▃▆█▃▁█▆▆▆▆█▁▆ ➡️ 17ms
large-graph-pan: p95 frame time ➡️ NaNms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▂▄▄▁▅▂▂▁▄▄█▃▁▂ ➡️ 17ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▆▃█▂▃▂▂▂▁▇▅▃█▆▃ ➡️ 69
large-graph-pan: task duration ▄▃▄▆▄▄▄▆▄▄█▆▁▂▅ ➡️ 1100ms
large-graph-pan: script duration ▅▄▅▆▆▅▄▆▄▅█▄▁▄▅ ➡️ 413ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ➡️ NaN MB
large-graph-pan: DOM nodes ▅▃▆▂▄▁▃▁▁▅▁▂█▅▂ ➡️ 18
large-graph-pan: event listeners █▆█▁▁▆▁▁▃▆▁▃██▃ ➡️ 5
minimap-idle: avg frame time ▃▆▆▃█▁█▆▆▃▃▆█▆█ ➡️ 17ms
minimap-idle: p95 frame time ➡️ NaNms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▄█▁█▅▅█▅▅▃▅▁▁▄▆ ➡️ 10ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 9
minimap-idle: task duration ▃▄▁▅▁▃▄▅▇▃█▅▁▁▅ ➡️ 547ms
minimap-idle: script duration ▄▆▃▇▃▅▆▆▇▅█▅▁▃▆ ➡️ 106ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ➡️ NaN MB
minimap-idle: DOM nodes ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 19
minimap-idle: event listeners ▃▃▆▁▁▁▃▁▁▆▁▃█▆▁ ➡️ 4
subgraph-dom-widget-clipping: avg frame time ▅▄▄▄▄▄█▄▄▄▃▁▆▃▃ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ➡️ NaNms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▂▄▃▅▅▃▂▅▇▃▄█▁▄▆ ➡️ 14ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▇█▆▃▆▃▁▆█▇▃▆▇█▅ ➡️ 48
subgraph-dom-widget-clipping: task duration ▂▃▃▆▅▅▂▅█▂▆█▁▂▇ ➡️ 398ms
subgraph-dom-widget-clipping: script duration ▃▃▃▄▅▅▂▄█▂▅▇▁▂▅ ➡️ 131ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ➡️ NaN MB
subgraph-dom-widget-clipping: DOM nodes ▅▇▅▂▅▂▁▅▅▅▁▇▅█▄ ➡️ 22
subgraph-dom-widget-clipping: event listeners ▅▅▅▂▅▁▅██▁▁█▅█▅ 📈 16
subgraph-idle: avg frame time ▆▆█▁▆▃▆▆▆▃▆▁▃▆█ ➡️ 17ms
subgraph-idle: p95 frame time ➡️ NaNms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▁▇▃▆▂▄▂▃▃▆▆▄▃▇█ ➡️ 12ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▃▆▃▃▂▅▁▂▁▆▃▃██▇ ➡️ 12
subgraph-idle: task duration ▁▃▁▇▁▁▃▆▅▂█▅▁▁▄ ➡️ 378ms
subgraph-idle: script duration ▁▃▂▇▁▂▃▇▆▂█▅▂▁▅ ➡️ 22ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ➡️ NaN MB
subgraph-idle: DOM nodes ▃▅▃▂▁▄▁▂▁▅▃▂▇█▇ ➡️ 24
subgraph-idle: event listeners ▁▅▁▁▁▁▁▁▁▅▄▁███ 📈 21
subgraph-mouse-sweep: avg frame time ▅▄▁▃▃▄▆▄▆▃▃█▁▃▃ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ➡️ NaNms
subgraph-mouse-sweep: layout duration ▁▄▄▄▃▃▅▅▅▂█▇▂▃▆ ➡️ 5ms
subgraph-mouse-sweep: style recalc duration ▃▂▄▅▂▃▄▅█▃█▆▁▂▅ ➡️ 43ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: style recalc count ▅▂▅▅▁▄▃▅█▅▆▄▂▄▅ ➡️ 81
subgraph-mouse-sweep: task duration ▃▂▄▅▂▄▄▅▇▄█▆▁▃▅ ➡️ 785ms
subgraph-mouse-sweep: script duration ▄▅▄▇▅▅▆▇▆▅██▁▄▆ ➡️ 105ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ➡️ NaN MB
subgraph-mouse-sweep: DOM nodes ▅▁▄▅▁▄▃▃█▅▅▄▂▅▃ ➡️ 66
subgraph-mouse-sweep: event listeners ▇▁▂▇▁▂▂▂█▇▂▂▇▇▂ 📈 5
workflow-execution: avg frame time ▆▆▆▄▆▆▃▄▁▄█▆▅▄▆ ➡️ 17ms
workflow-execution: p95 frame time ➡️ NaNms
workflow-execution: layout duration ▁▆▁▃▂▄▃▂▃▃▅█▄▂▅ ➡️ 2ms
workflow-execution: style recalc duration ▃▇▅▇▁▅▆▇█▁██▂▄▆ ➡️ 25ms
workflow-execution: layout count ▁█▂▃▂▃▃▁▃▃▄▃▂▃▂ ➡️ 5
workflow-execution: style recalc count ▃█▅▇▁▄▅▆▅▅▅▅▄▄▂ ➡️ 15
workflow-execution: task duration ▂▅▄▅▁▄▆▆▆▁▇█▁▃▃ ➡️ 120ms
workflow-execution: script duration ▄▃▄▄▃▅▄▅▆▂▇█▁▃▄ ➡️ 29ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ➡️ NaN MB
workflow-execution: DOM nodes ▂█▃▆▁▄▃▅▃█▃▃▄▃▁ ➡️ 152
workflow-execution: event listeners ▅███▁▅███▁██▅█▅ ➡️ 49
Raw data
{
  "timestamp": "2026-07-31T07:57:31.425Z",
  "gitSha": "4da54f71d9d88846b9092085061c68179095978f",
  "branch": "jaeone94/errors-node-pack-lifecycle",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2104.719999999986,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.476999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 505.2610000000001,
      "heapDeltaBytes": 4945404,
      "heapUsedBytes": 72760512,
      "domNodes": 18,
      "jsHeapTotalBytes": 20574208,
      "scriptDurationMs": 15.674999999999997,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2028.8470000000416,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.145999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 408.38300000000004,
      "heapDeltaBytes": 4624504,
      "heapUsedBytes": 72463268,
      "domNodes": 20,
      "jsHeapTotalBytes": 20574208,
      "scriptDurationMs": 13.526000000000002,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1747.3410000000058,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 28.610999999999997,
      "layouts": 12,
      "layoutDurationMs": 3.3,
      "taskDurationMs": 673.355,
      "heapDeltaBytes": -1108440,
      "heapUsedBytes": 66814660,
      "domNodes": 55,
      "jsHeapTotalBytes": 21098496,
      "scriptDurationMs": 89.427,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1776.2010000000146,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 27.976,
      "layouts": 12,
      "layoutDurationMs": 3.3659999999999997,
      "taskDurationMs": 730.46,
      "heapDeltaBytes": -18259604,
      "heapUsedBytes": 49757320,
      "domNodes": -279,
      "jsHeapTotalBytes": 20963328,
      "scriptDurationMs": 87.954,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1738.3449999999812,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 13.357000000000001,
      "layouts": 6,
      "layoutDurationMs": 0.626,
      "taskDurationMs": 319.159,
      "heapDeltaBytes": 8027192,
      "heapUsedBytes": 75849616,
      "domNodes": 78,
      "jsHeapTotalBytes": 19787776,
      "scriptDurationMs": 15.477999999999998,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1684.4260000000304,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 13.482999999999999,
      "layouts": 6,
      "layoutDurationMs": 0.6719999999999998,
      "taskDurationMs": 340.431,
      "heapDeltaBytes": 7820504,
      "heapUsedBytes": 75787540,
      "domNodes": 77,
      "jsHeapTotalBytes": 21098496,
      "scriptDurationMs": 16.438000000000002,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 511.9109999999978,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 5.774999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 315.454,
      "heapDeltaBytes": -12117140,
      "heapUsedBytes": 55569220,
      "domNodes": 20,
      "jsHeapTotalBytes": 21884928,
      "scriptDurationMs": 45.839999999999996,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 535.3420000000142,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 5.9030000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 311.17,
      "heapDeltaBytes": -12126048,
      "heapUsedBytes": 55831844,
      "domNodes": 22,
      "jsHeapTotalBytes": 21098496,
      "scriptDurationMs": 43.49,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2030.9680000000299,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.7429999999999986,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 587.146,
      "heapDeltaBytes": 7712580,
      "heapUsedBytes": 66689096,
      "domNodes": -281,
      "jsHeapTotalBytes": 3993600,
      "scriptDurationMs": 77.25,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2035.0179999999227,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.556,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 578.219,
      "heapDeltaBytes": 8128804,
      "heapUsedBytes": 67381228,
      "domNodes": -281,
      "jsHeapTotalBytes": 5042176,
      "scriptDurationMs": 75.911,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2100.213999999994,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 13.040000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1068.7669999999998,
      "heapDeltaBytes": 5662524,
      "heapUsedBytes": 65586560,
      "domNodes": -282,
      "jsHeapTotalBytes": 5005312,
      "scriptDurationMs": 343.221,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2135.475999999926,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 13.256999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1058.378,
      "heapDeltaBytes": 4870492,
      "heapUsedBytes": 64620996,
      "domNodes": -279,
      "jsHeapTotalBytes": 5267456,
      "scriptDurationMs": 330.887,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3134.2930000000138,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 15.205,
      "layouts": 60,
      "layoutDurationMs": 8.416,
      "taskDurationMs": 1304.431,
      "heapDeltaBytes": -5038752,
      "heapUsedBytes": 56404644,
      "domNodes": -286,
      "jsHeapTotalBytes": 7925760,
      "scriptDurationMs": 407.258,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3067.481999999927,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 13.711999999999998,
      "layouts": 60,
      "layoutDurationMs": 8.373,
      "taskDurationMs": 1228.2190000000003,
      "heapDeltaBytes": 22864852,
      "heapUsedBytes": 85722408,
      "domNodes": 10,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 392.835,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2031.6060000000107,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 5.422999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 579.886,
      "heapDeltaBytes": 7644928,
      "heapUsedBytes": 68203596,
      "domNodes": -282,
      "jsHeapTotalBytes": 5042176,
      "scriptDurationMs": 74.661,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2021.1210000001074,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.549000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 576.2669999999999,
      "heapDeltaBytes": 8122864,
      "heapUsedBytes": 68857268,
      "domNodes": -281,
      "jsHeapTotalBytes": 3993600,
      "scriptDurationMs": 75.01,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 536.2409999999613,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 8.230999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 323.84000000000003,
      "heapDeltaBytes": -11856440,
      "heapUsedBytes": 56066468,
      "domNodes": 22,
      "jsHeapTotalBytes": 22147072,
      "scriptDurationMs": 91.47,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 518.9080000000104,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 8.036000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 328.86400000000003,
      "heapDeltaBytes": -11815776,
      "heapUsedBytes": 56227548,
      "domNodes": 20,
      "jsHeapTotalBytes": 22147072,
      "scriptDurationMs": 92.503,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1999.1489999999885,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.690999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 391.02,
      "heapDeltaBytes": 4620416,
      "heapUsedBytes": 72718720,
      "domNodes": 22,
      "jsHeapTotalBytes": 20836352,
      "scriptDurationMs": 12.365,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2009.3100000000277,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.979000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 453.501,
      "heapDeltaBytes": -21200480,
      "heapUsedBytes": 46629316,
      "domNodes": -278,
      "jsHeapTotalBytes": 21487616,
      "scriptDurationMs": 12.581000000000001,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1716.0729999999944,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 27.873,
      "layouts": 16,
      "layoutDurationMs": 3.4729999999999994,
      "taskDurationMs": 620.342,
      "heapDeltaBytes": -4635376,
      "heapUsedBytes": 63351612,
      "domNodes": 66,
      "jsHeapTotalBytes": 20836352,
      "scriptDurationMs": 63.580999999999996,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1688.908999999967,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 27.826999999999998,
      "layouts": 16,
      "layoutDurationMs": 3.2630000000000003,
      "taskDurationMs": 635.019,
      "heapDeltaBytes": -4876016,
      "heapUsedBytes": 63168048,
      "domNodes": 65,
      "jsHeapTotalBytes": 21098496,
      "scriptDurationMs": 64.111,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 916.2959999999885,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 23.430999999999994,
      "layouts": 15,
      "layoutDurationMs": 8.468000000000002,
      "taskDurationMs": 745.5169999999999,
      "heapDeltaBytes": 4738396,
      "heapUsedBytes": 96730028,
      "domNodes": 13673,
      "jsHeapTotalBytes": 13893632,
      "scriptDurationMs": 20.984999999999996,
      "eventListeners": 2369,
      "totalBlockingTimeMs": 124,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8140.532000000007,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 37.336,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3788.7960000000003,
      "heapDeltaBytes": 8210924,
      "heapUsedBytes": 69659304,
      "domNodes": -278,
      "jsHeapTotalBytes": 6840320,
      "scriptDurationMs": 1107.8570000000002,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8115.052999999989,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 38.089,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3803.8549999999996,
      "heapDeltaBytes": 5554448,
      "heapUsedBytes": 65547768,
      "domNodes": -280,
      "jsHeapTotalBytes": 6578176,
      "scriptDurationMs": 1107.126,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 13559.368000000006,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13533.456000000002,
      "heapDeltaBytes": -60147384,
      "heapUsedBytes": 166251336,
      "domNodes": -8312,
      "jsHeapTotalBytes": -14098432,
      "scriptDurationMs": 491.71799999999996,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 13486.452999999983,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13454.294000000002,
      "heapDeltaBytes": -47829592,
      "heapUsedBytes": 166045544,
      "domNodes": -8312,
      "jsHeapTotalBytes": -13836288,
      "scriptDurationMs": 472.092,
      "eventListeners": -16391,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16529.126999999902,
      "styleRecalcs": 93,
      "styleRecalcDurationMs": 15.240000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16487.983,
      "heapDeltaBytes": -28540388,
      "heapUsedBytes": 180806868,
      "domNodes": -8312,
      "jsHeapTotalBytes": -10760192,
      "scriptDurationMs": 798.128,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 16,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16413.949,
      "styleRecalcs": 94,
      "styleRecalcDurationMs": 14.885000000000009,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16379.021000000002,
      "heapDeltaBytes": -48400612,
      "heapUsedBytes": 164642220,
      "domNodes": -8312,
      "jsHeapTotalBytes": -9379840,
      "scriptDurationMs": 789.355,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 60,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 449.6199999999817,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 16.417,
      "layouts": 3,
      "layoutDurationMs": 1.1250000000000002,
      "taskDurationMs": 96.723,
      "heapDeltaBytes": -15890756,
      "heapUsedBytes": 51076112,
      "domNodes": 156,
      "jsHeapTotalBytes": 7991296,
      "scriptDurationMs": 7.521000000000002,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 453.1570000000329,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 14.984999999999998,
      "layouts": 3,
      "layoutDurationMs": 0.619,
      "taskDurationMs": 99.243,
      "heapDeltaBytes": -16031728,
      "heapUsedBytes": 50978716,
      "domNodes": 119,
      "jsHeapTotalBytes": 7467008,
      "scriptDurationMs": 7.389999999999999,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🎭 Playwright: ✅ 1772 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1751 / ❌ 0 / ⚠️ 1 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

@github-actions

Copy link
Copy Markdown
Contributor

🎭 Playwright: ⏳ Running...

@coderabbitai

coderabbitai Bot commented Jul 29, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

clearRunErrors() now preserves missing-node packs. Prompt submission clears only run errors. API JSON loading, successful A1111 workflow imports, and workflow cleanup reset missing-node state. A1111 imports now report whether they replaced the graph.

Changes

Missing Node State Lifecycle

Layer / File(s) Summary
Preserve missing setup state
src/stores/executionErrorStore.ts, src/stores/executionErrorStore.test.ts
Renames clearAllErrors() to clearRunErrors(). The function clears run-related errors while preserving missing-node packs.
Preserve missing nodes during prompt submission
src/scripts/app.ts, src/scripts/app.test.ts
Prompt queuing clears run errors without removing missing-node packs. Tests add workflow, graph, and subgraph mocks for this behavior.
Reset missing nodes during workflow transitions
src/platform/workflow/core/services/workflowService.test.ts, src/scripts/app.ts, src/scripts/pnginfo.ts, src/scripts/app.test.ts
Workflow loading caches missing-node types. API JSON loading, successful A1111 imports, and clean() clear missing-node state. A1111 imports return a boolean indicating graph replacement.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant ComfyApp
  participant importA1111
  participant executionErrorStore
  participant LiteGraph
  ComfyApp->>importA1111: import image parameters
  importA1111-->>ComfyApp: graph replaced boolean
  alt graph replaced
    ComfyApp->>executionErrorStore: clear missing-node types
    ComfyApp->>LiteGraph: load replacement graph
  end
Loading

Possibly related PRs

Suggested reviewers: christian-byrne


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
End-To-End Regression Coverage For Fixes ❓ Inconclusive The changed files and PR description are available, but the PR title and commit subjects are not provided; the required bug-fix signal cannot be verified. Provide the PR title and commit subjects to determine whether the regression-test requirement applies.
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Adr Compliance For Entity/Litegraph Changes ✅ Passed The metadata shows graph-loading and error-state changes, but no node/link/widget entity mutations, entity methods, ECS components, or extension-callback changes described by ADR 0003/0008.
Title check ✅ Passed The title clearly summarizes the primary change: preserving missing-node packs across prompt submissions.
Description check ✅ Passed The description covers the summary, changes, review focus, edge cases, and rationale; the omitted screenshots section is not required for this change.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jaeone94/errors-node-pack-lifecycle

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Jul 29, 2026
@codecov

codecov Bot commented Jul 29, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/scripts/pnginfo.ts 80.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main   #14251      +/-   ##
==========================================
+ Coverage   79.12%   79.30%   +0.18%     
==========================================
  Files        1763     1767       +4     
  Lines      112306   112541     +235     
  Branches    35930    35957      +27     
==========================================
+ Hits        88862    89253     +391     
+ Misses      22916    22754     -162     
- Partials      528      534       +6     
Flag Coverage Δ
unit 70.41% <93.33%> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/scripts/app.ts 70.59% <100.00%> (+1.13%) ⬆️
src/stores/executionErrorStore.ts 95.23% <100.00%> (-0.03%) ⬇️
src/scripts/pnginfo.ts 64.66% <80.00%> (+38.31%) ⬆️

... and 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
src/stores/executionErrorStore.test.ts (1)

852-887: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Seed a real missing-node pack in this regression.

seedMissingError() assigns fromAny({}), which is not a valid
MissingNodesError and contains no node pack. Seed through
setMissingNodeTypes() and assert the actual nodeTypes persist.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/stores/executionErrorStore.test.ts` around lines 852 - 887, Update the
regression setup around clearRunErrors to seed missing-node data through
missingNodesStore.setMissingNodeTypes(), using a valid MissingNodeType entry
rather than relying on seedMissingError(). Assert after
executionErrorStore.clearRunErrors() that the actual missing nodeTypes remain
preserved, while the run errors are reset.

Source: Path instructions

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/stores/executionErrorStore.ts`:
- Around line 86-89: Replace the misleading comment above clearRunErrors with
documentation describing clearRunErrors’ actual run-error and missing-state
behavior; remove the claim about clearMissingModels resetting imported model
download metadata, since this action does not call it.

---

Outside diff comments:
In `@src/stores/executionErrorStore.test.ts`:
- Around line 852-887: Update the regression setup around clearRunErrors to seed
missing-node data through missingNodesStore.setMissingNodeTypes(), using a valid
MissingNodeType entry rather than relying on seedMissingError(). Assert after
executionErrorStore.clearRunErrors() that the actual missing nodeTypes remain
preserved, while the run errors are reset.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 4d82b519-2f68-449d-af7d-140f13000142

📥 Commits

Reviewing files that changed from the base of the PR and between c443cf3 and 2a9d9e0.

📒 Files selected for processing (6)
  • src/platform/workflow/core/services/workflowService.test.ts
  • src/platform/workflow/core/services/workflowService.ts
  • src/scripts/app.test.ts
  • src/scripts/app.ts
  • src/stores/executionErrorStore.test.ts
  • src/stores/executionErrorStore.ts

Comment thread src/stores/executionErrorStore.ts Resolved
@jaeone94
jaeone94 marked this pull request as ready for review July 31, 2026 01:29
@jaeone94
jaeone94 requested a review from a team July 31, 2026 01:29
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 31, 2026
@dosubot

dosubot Bot commented Jul 31, 2026

Copy link
Copy Markdown

📄 Knowledge review

Dosu skipped reviewing this PR because your organization has used its 200 included credits for the month. Your usage will reset on 2026-08-01. To have Dosu review this PR before then, ask your organization admin to upgrade to a pro account.


Leave Feedback Ask Dosu about ComfyUI_frontend Add Dosu to your team

jaeone94 added 4 commits July 31, 2026 10:30
clearAllErrors() runs inside queuePrompt, so submitting a prompt wiped the
missing node pack list on every run while missing model and media state was
deliberately preserved. A missing node pack is not resolved by submitting a
prompt - it persists until the pack is installed and the app restarts - so the
list only reappeared when the backend happened to reject the prompt with
missing_node_type.

Align it with the missing model/media lifecycle: preserve it across runs and
clear it on workflow load and on explicit workflow clean instead. Both clearing
points are required - loadGraphData can be called with clean: false, and the
Clear Workflow command and the legacy Clear button call clean() without going
through loadGraphData.
@jaeone94
jaeone94 force-pushed the jaeone94/errors-node-pack-lifecycle branch from 2a9d9e0 to 0c61495 Compare July 31, 2026 01:30
@jaeone94
jaeone94 marked this pull request as draft July 31, 2026 02:01
Submission clears execution errors only. Missing resources are not execution
errors: a missing node can sit on a branch the run never executes, so a
successful run says nothing about whether it is still missing. Missing model
and media state already behaved this way.

The rescan also called showErrorOverlay whenever the graph had missing nodes,
so submitting such a workflow popped the overlay.
@jaeone94
jaeone94 marked this pull request as ready for review July 31, 2026 04:21
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jul 31, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
src/scripts/app.ts (1)

2415-2416: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Clear missing-node state for loadGraphData(..., false).

loadGraphData() calls beforeLoadNewGraph() at Line 1224. It skips clean() when clean === false. This changed reset only runs through clean(). Therefore, a workflow loaded with clean: false retains missing-node packs from the previous workflow.

Clear missing-node state after beforeLoadNewGraph() for every workflow load. Keep the reset in clean() for explicit workflow cleanup. Add coverage for loading a valid workflow with clean: false after seeding missing-node state.

This conflicts with the PR objective to cover workflow loads with clean: false.

Proposed fix
     useWorkflowService().beforeLoadNewGraph()
+    useMissingNodesErrorStore().setMissingNodeTypes([])
 
     if (skipAssetScans) {
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/scripts/app.ts` around lines 2415 - 2416, Update loadGraphData and the
beforeLoadNewGraph flow so useMissingNodesErrorStore().setMissingNodeTypes([])
runs after beforeLoadNewGraph for every workflow load, including clean: false.
Keep the existing reset in clean() for explicit workflow cleanup, and add
coverage that loads a valid workflow with clean: false after seeding
missing-node state.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@src/scripts/app.ts`:
- Around line 2415-2416: Update loadGraphData and the beforeLoadNewGraph flow so
useMissingNodesErrorStore().setMissingNodeTypes([]) runs after
beforeLoadNewGraph for every workflow load, including clean: false. Keep the
existing reset in clean() for explicit workflow cleanup, and add coverage that
loads a valid workflow with clean: false after seeding missing-node state.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 617cd389-0574-4a99-a5c9-989461531743

📥 Commits

Reviewing files that changed from the base of the PR and between 98a8946 and df5e706.

📒 Files selected for processing (6)
  • src/platform/workflow/core/services/workflowService.test.ts
  • src/scripts/app.test.ts
  • src/scripts/app.ts
  • src/scripts/pnginfo.ts
  • src/stores/executionErrorStore.test.ts
  • src/stores/executionErrorStore.ts

coderabbitai[bot]
coderabbitai Bot previously approved these changes Jul 31, 2026
surfaceMissingNodes already clears on an empty list, which is the idiom
workflowService documents. Also assert the A1111 tab is seeded from the
rebuilt graph, which nothing pinned.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/scripts/pnginfo.ts`:
- Around line 554-557: Update the caller of importA1111 in the workflow import
path to check graphWasReplaced before clearing missing-node state or invoking
afterLoadNewGraph; when it is false, report the failed import and return without
finalizing or registering the unchanged graph as the new workflow.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 8b1b53b8-c903-4dc8-88f8-a18ce82ef01a

📥 Commits

Reviewing files that changed from the base of the PR and between 98a8946 and fd2140e.

📒 Files selected for processing (6)
  • src/platform/workflow/core/services/workflowService.test.ts
  • src/scripts/app.test.ts
  • src/scripts/app.ts
  • src/scripts/pnginfo.ts
  • src/stores/executionErrorStore.test.ts
  • src/stores/executionErrorStore.ts

Comment thread src/scripts/pnginfo.ts Resolved
jaeone94 added 2 commits July 31, 2026 16:29
importA1111 has four early returns that leave the graph untouched. The
caller gated the missing-node clear on that but still registered the
unchanged graph under the dropped file's name. Falling through instead
reaches showErrorOnFileLoad, which already reports an unusable file.
The previous wording asserted a rule with an exception: ComfyApp.clean
clears missing state unconditionally while its rootGraph.clear() is
skipped inside a subgraph.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/scripts/app.ts`:
- Around line 2062-2070: Update the graph replacement branch in loadGraphData to
await useWorkflowService().afterLoadNewGraph(...) before returning, matching the
existing awaited call elsewhere and preventing a floating promise.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 6bfab7b9-0e91-4219-a029-b0be594aa943

📥 Commits

Reviewing files that changed from the base of the PR and between fd2140e and 85e1fa9.

📒 Files selected for processing (2)
  • src/scripts/app.test.ts
  • src/scripts/app.ts

Comment thread src/scripts/app.ts
Comment on lines +2062 to +2070
const graphWasReplaced = await importA1111(this.rootGraph, parameters)
if (graphWasReplaced) {
useMissingNodesErrorStore().setMissingNodeTypes([])
useWorkflowService().afterLoadNewGraph(
fileName,
this.rootGraph.serialize() as unknown as ComfyWorkflowJSON
)
return
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

Await afterLoadNewGraph to avoid a floating promise.

Line 2065 calls useWorkflowService().afterLoadNewGraph(...) without await. loadGraphData awaits the same call at line 1511. Add await here for consistency and to prevent an unhandled rejection if afterLoadNewGraph throws.

🐛 Proposed fix
       if (graphWasReplaced) {
         useMissingNodesErrorStore().setMissingNodeTypes([])
-        useWorkflowService().afterLoadNewGraph(
+        await useWorkflowService().afterLoadNewGraph(
           fileName,
           this.rootGraph.serialize() as unknown as ComfyWorkflowJSON
         )
         return
       }
As per coding guidelines: "Disallow floating promises and unused imports."
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
const graphWasReplaced = await importA1111(this.rootGraph, parameters)
if (graphWasReplaced) {
useMissingNodesErrorStore().setMissingNodeTypes([])
useWorkflowService().afterLoadNewGraph(
fileName,
this.rootGraph.serialize() as unknown as ComfyWorkflowJSON
)
return
}
const graphWasReplaced = await importA1111(this.rootGraph, parameters)
if (graphWasReplaced) {
useMissingNodesErrorStore().setMissingNodeTypes([])
await useWorkflowService().afterLoadNewGraph(
fileName,
this.rootGraph.serialize() as unknown as ComfyWorkflowJSON
)
return
}
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/scripts/app.ts` around lines 2062 - 2070, Update the graph replacement
branch in loadGraphData to await useWorkflowService().afterLoadNewGraph(...)
before returning, matching the existing awaited call elsewhere and preventing a
floating promise.

Source: Coding guidelines

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The central judgement here is right, and I want to say that first because most of
what follows is critical. Missing-resource state genuinely should not be cleared
by a prompt submission — a missing node can sit on a branch the run never
touches, so a submission carries no information about it. I verified the two
load-bearing claims in the description independently: clean()'s net behaviour
is byte-identical to before (clearRunErrors + the explicit
setMissingNodeTypes([]) reproduce what clearAllErrors used to do
transitively), and the undo path really does re-derive through
normalizePendingWarnings → surfaceMissingNodes. Both hold.

What I want to push on is that the fix is expressed as three hand-written clear
sites and a boolean, and in that form it is defeated on two of the paths it is
supposed to cover.

Blocking

1. The API-JSON path now produces a card the user cannot get rid of.
loadApiJson surfaces missing nodes as bare strings (app.ts:2204,
.map((t) => t.class_type)) and never adds the nodes to the graph
(if (!node) continue, app.ts:2211). Every removal path is closed against a
string entry: removeMissingNodesByNodeId and removeMissingNodesByPrefix both
return true for typeof node === 'string'; onNodeRemoved can't fire because
there is no node; rescanAndSurfaceMissingNodes only runs on a
missing_node_type prompt error, which the backend won't raise since the node
was dropped from the prompt; and MissingPackGroupRow.vue renders no
Install/Locate action when nodeId == null. Before this PR the next Run cleared
it. Now the only exits are loading another workflow or reloading the page.

To reproduce: Workflow → Open, pick an API JSON containing
{"1":{"class_type":"Uninstalled_XYZ","inputs":{}}}.

The description lists this as follow-up #1, but this PR is what removes the
workaround, so the follow-up and the removal need to ship together. Creating the
has_errors placeholder node in loadApiJson — the option the description
itself prefers — gives the entry a nodeId and makes every existing remover
work.

2. On drag-and-drop, the new clear is undone inside the same gesture.
beforeLoadNewGraph copies the outgoing missing-node list into
activeWorkflow.pendingWarnings (workflowService.ts:419). Then
afterLoadNewGraph is not awaited (app.ts:2065), and it suspends at
await workflowStore.openWorkflow(...) before activeWorkflow is reassigned
(workflowStore.ts:205). So handleFile returns, the drop handler calls
showPendingWarnings() with no argument (app.ts:720), that reads the still-old
activeWorkflow, and surfaceMissingNodes re-applies the stale list.

The same shape applies to loadApiJson (un-awaited afterLoadNewGraph at
app.ts:2266), where it lands the other way and wipes a card that was just set.
deferWarnings: true doesn't save it — handleFile forwards that flag only to
loadGraphData (app.ts:2027), not to the A1111 or API branches.

await on line 2065 and 2266 is the immediate fix. The root cause is that
missing-node truth is stored twice and kept in sync by hand; pendingWarnings
should be the cache for inactive tabs only, with the store authoritative for
the active one.

Not covered by the new tests — app.test.ts:745 and :773 call handleFile
directly, never the drop listener.

3. await importA1111 can now reject out of handleFile and kill the file
picker.
importA1111 awaits api.getEmbeddings() (pnginfo.ts:189), which
doesn't check resp.ok and calls resp.json() unguarded — a 500 with an HTML
body throws. That rejection used to be orphaned in an unawaited promise; now it
propagates, so fileInput.value = '' (ui.ts:411) never runs. The input still
holds the file, re-selecting it fires no change event, and Open silently does
nothing on every retry. No toast, no dialog. try/catch around the import, and
finally on the input reset.

4. Two identical "failed to load" alerts for one file. Both the
invalid-structure branch (app.ts:2034) and the parse catch (:2038) call
showErrorOnFileLoad and then fall through. Previously the parameters branch
always returned, so :2073 was unreachable; now a bailing import reaches it.
Drop a PNG with a truncated workflow chunk and a parameters chunk lacking
\nNegative prompt: and you get two stacked alerts. showErrorOnFileLoad does
no deduplication.

5. beforeLoadNewGraph can now run with no matching after, and one of its
effects is destructive.
It's called unconditionally at app.ts:2061, before an
import that may bail. It commits five things with no rollback, including
domWidgetStore.clear() (workflowService.ts:428), which empties the map
activeWidgetStates renders from — and registerWidget only runs at widget
construction, so on a bail path nothing re-registers. A workflow with a
CLIPTextEncode multiline prompt on screen loses its DOM widget overlays when
the user drops a PNG whose parameters don't parse.

To be fair: that damage was reachable before this PR too, since the old bail path
called afterLoadNewGraph, which also doesn't re-register. What's new is
structural — the documented paired protocol (workflowService.ts:397-406, and
the call-relationship list at :441 which now says something false) is unpaired,
which is what makes the destructive step unauditable from here on.

Design — worth fixing in this PR

6. Promise<boolean> collapses four outcomes, and one of them is the thing
this PR is about.
false is returned for "not an A1111 file" (:557),
"malformed metadata" (:196), and "the file is fine, your install lacks
CheckpointLoaderSimple/KSampler/…" (:234). The caller maps all three to
showErrorOnFileLoad → "this file is unusable", which for the third is simply
untrue — and it's the one place A1111 could report missing node types, swallowed
into a console.error. true is also loose: the size handler bails at
:423-:464 when hires nodes are unregistered, so true can mean "graph
replaced with a half-wired chain", which the caller then finalizes as a clean
workflow.

export type A1111ImportResult =
  | { status: 'not-a1111' }
  | { status: 'unparseable' }
  | { status: 'unavailable-node-types'; types: string[] }
  | { status: 'imported'; incompleteNodeTypes: string[] }

A switch on that also makes #4 disappear, and lets the missing types reach the
UI they belong in.

7. "The graph was replaced" is a fact nothing dispatches — it's re-asserted at
three sites that clear different subsets.
loadGraphData (via clean())
clears missing nodes, models, media, node errors, outputs and DOM widgets.
loadApiJson and the A1111 branch each clear exactly one of those six. Neither
routes through clean() — they call rootGraph.clear() (app.ts:2207) and
graph.clear() (pnginfo.ts:334) directly.

Import an A1111 PNG while lastNodeErrors holds entries from the outgoing
workflow: nothing clears them, and since ids are graph-local,
useNodeErrorFlagSync resolves stale ids against the new graph and paints
has_errors on whichever node now occupies that id.

One named operation both fixes this and stops the table from needing to be
re-derived by hand every time a store gains lifecycle state:

export function resetForNewGraph(scope: { keepAssetScans?: boolean } = {}) {
  useNodeOutputStore().resetAllOutputsAndPreviews()
  useExecutionErrorStore().clearRunErrors()
  useMissingNodesErrorStore().clearMissingNodes()
  // …models / media / domWidgets
}

clean(), loadApiJson, and the A1111 branch each call it once. A fourth load
path then can't forget a column. Note clearMissingModels already resets seven
refs plus an abort controller — that's the shape this is heading toward.

8. clearRunErrors closes the overlay while hasAnyError stays true.
isErrorOverlayOpen = false (executionErrorStore.ts:91) was consistent
pre-PR because clearAllErrors nulled every category. It isn't now: with a
missing-pack overlay open, clicking Run closes the overlay but leaves
hasAnyError true, which flips showErrorIndicatorOnPanelButton
(TopMenuSection.vue:274) from false to true — a red indicator appears as a
side effect of submitting a prompt, and nothing reopens the overlay until the
next showMissingNodesError. Visibility is already gated on totalErrorCount at
useErrorOverlayState.ts:203, so clearRunErrors shouldn't touch overlay
visibility at all.

Smaller notes

9. One correction to the description. The rationale for not clearing in
beforeLoadNewGraph — that it "opened a window in which hasAnyError was
briefly false" — doesn't hold for the clean path: there is no suspension point
between app.ts:1224 and app.ts:1247, so the two positions are
indistinguishable. And that window exists today regardless, between app.ts:2413
and app.ts:1548, across seven awaits. The reasoning is sound for the undo
path (changeTracker.ts:470, clean === false), where clean() is skipped and
a clear at :1224 would be unconditional. That's a real reason — it's just not
the one stated, and the stated one implies a safety the code doesn't have.

The underlying problem is RightSidePanel.vue:227, a watchEffect that reads a
computed and writes rightSidePanelStore.openPanel. Because openPanel has no
memory of what it clobbered, every transient in the error stores becomes a
permanent UI change. Deriving the resolved tab instead of repairing it from an
effect makes the placement of the clear a non-decision. Out of scope here, but
it's the thing that forced this PR's hardest choice.

10. Pre-existing, but newly load-bearing. setMissingNodeTypes([]) doubles
as teardown (if (!types.length) { missingNodesError.value = null; return }), so
this PR's diff makes showMissingNodesError the API-JSON path's clear
(app.ts:2204 is now unconditional). A method named show…Error that hides is
worth a clearMissingNodes() sibling — missingModelStore already has both
forms. Separately surfaceMissingNodes returns
types.length > 0 && settingStore.get('Comfy.RightSidePanel.ShowErrorsTab'),
smuggling a setting read out of a setter, and missingNodesError.message is
computed once at set time from st() (so it won't follow a locale change), has
no production consumer, and duplicates
missingErrorResolver.ts:342. That last one matters more now that missing-node
state survives every submission and its lifetime is unbounded.

11. importA1111 clears the root graph with no subgraph guard. clean()
guards this exact case (app.ts:2415, "LGraph's clear breaks the subgraph
structure"); pnginfo.ts:334 doesn't. Navigate into a subgraph, drop a valid
A1111 PNG, and the new boolean contract reports a clean replacement over a
corrupt canvas.

Tests

The four new app.test.ts cases are mutation-sensitive — I checked each against
its inverse and they fail on the reverted change. Good.

Gaps:

  • Only one of importA1111's three false paths is exercised. The test string
    has no \nSteps:, so it returns at :557 without reaching
    await api.getEmbeddings() — the two paths that return after the suspension
    point, where the ordering actually matters, are untested. pnginfo.test.ts has
    no importA1111 coverage at all; three direct unit tests there would be
    cheaper and stronger than the current indirect ones.
  • Nothing pins the stuck state from #1 — loadApiJson with a missing type, then
    queuePrompt, asserting the entry survives. That's the most consequential
    behaviour change in the PR and it's unasserted.
  • workflowService.test.ts:330/:333 assert that
    pendingWarnings.missingNodeTypes and missingNodesError.nodeTypes agree.
    That's a guard on two copies of one fact being in sync, which will actively
    resist collapsing them. If the duplication is deliberate for the tab cache,
    assert the cache semantics instead — that a snapshot is taken for the
    outgoing tab.
  • In clears missing node packs after importing A1111 parameters, the
    registerNodeType loop sits outside the try, so a throw mid-loop leaks real
    node names into the module-global registry for the rest of the file.

One note on the public surface

src/scripts/** is covered by comfyAPIPlugin's isLegacyFile, so
importA1111 is shimmed onto window.comfyAPI.pnginfo.importA1111.
Promise<void> → Promise<boolean> is a runtime-compatible widening and is
fine, but it's a public-surface change and worth a line in the description.

Comment thread src/scripts/pnginfo.ts
) {
console.error('Failed to create required nodes for A1111 import')
return
return false

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the one place A1111 can tell you your install is missing node types, and it becomes false — which app.ts:2073 renders as "this file is unusable." The file is fine. See item 6: a discriminated union carries { status: 'unavailable-node-types', types } to a UI that can act on it, and collapses the double-toast in item 4 at the same time.

Comment thread src/scripts/app.ts
const graphWasReplaced = await importA1111(this.rootGraph, parameters)
if (graphWasReplaced) {
useMissingNodesErrorStore().setMissingNodeTypes([])
useWorkflowService().afterLoadNewGraph(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afterLoadNewGraph isn't awaited, but importA1111 on the line above is. It suspends at openWorkflow before activeWorkflow is reassigned, so handleFile returns while the old workflow is still active and the drop handler's showPendingWarnings() (app.ts:720) re-applies the stale missing-node list this PR just cleared. Same shape at :2266. See item 2.

Comment thread src/scripts/app.ts
return
const graphWasReplaced = await importA1111(this.rootGraph, parameters)
if (graphWasReplaced) {
useMissingNodesErrorStore().setMissingNodeTypes([])

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the third hand-written answer to "what does replacing the graph invalidate?", and each of the three clears a different subset. clean() clears six things; this clears one. Import an A1111 PNG with lastNodeErrors populated and the stale ids get resolved against the new graph. See item 7 for a single resetForNewGraph().

Comment thread src/scripts/app.ts
if (missingNodeTypes.length) {
this.showMissingNodesError(missingNodeTypes.map((t) => t.class_type))
}
this.showMissingNodesError(missingNodeTypes.map((t) => t.class_type))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things here. Dropping the if (missingNodeTypes.length) guard makes showMissingNodesError the clear for this path, via setMissingNodeTypes([])'s teardown overload — a method named show…Error that hides. And the entries it sets are bare strings with no nodeId, which every removal path rejects; removing the submit-time wipe means nothing can clear them at all. Item 1 is the blocking half.

* resource can sit on a branch the run never executed, so a submission says
* nothing about whether it is still missing, and installing a node pack needs
* a backend restart. Missing nodes are cleared by `ComfyApp.clean` and by the
* file-import paths that rebuild the graph. */

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing the overlay was consistent pre-PR because clearAllErrors nulled every category. Now missing packs survive, so Run closes the overlay with hasAnyError still true — which flips showErrorIndicatorOnPanelButton (TopMenuSection.vue:274) to true. Submitting a prompt makes a red dot appear. Visibility is already gated on totalErrorCount at useErrorOverlayState.ts:203; this line can just go.

expect(activeWorkflow.pendingWarnings?.missingNodeTypes).toEqual(
missingNodeTypes
)
expect(missingNodesStore.missingNodesError?.nodeTypes).toEqual(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two assertions say "the two copies of this fact agree right now", which locks in the duplication that makes item 2 possible. If the mirror is deliberately the cache for inactive tabs, assert that instead — a snapshot is taken for the outgoing workflow — so the test survives making the store authoritative for the active one.

@jaeone94

Copy link
Copy Markdown
Collaborator Author

Closing this in favour of three smaller PRs. Thanks for the review — every blocker in it held up, and working through them is what made it clear this PR was doing too much.

The thesis here was one sentence: a prompt submission should not clear missing-node state. Taking all eight review items into it grew it to ~600 non-test lines across the A1111 importer, the API-JSON loader, the graph-reset lifecycle and the error store. Those are four different changes with four different risk profiles, and bundling them means no reviewer can approve any one of them independently and nothing can be reverted on its own.

Splitting into:

A1 — API-JSON load. Unknown node types become placeholder nodes with has_errors and a real nodeId, instead of being silently dropped. This is your blocker #1. Giving the entry a nodeId is what makes every existing remover work, so the card stops being permanent.

A2 — A1111 import. The lifecycle fixes only: await the afterLoadNewGraph call, try/catch around the import with the file-input reset in finally, remove the duplicate alert, and stop beforeLoadNewGraph() from running before an import that may bail.

On your #6 — Promise<boolean> collapsing four outcomes — I built the discriminated union and then concluded it was solving the wrong problem, so A2 will not carry it. All seven "required" types (CheckpointLoaderSimple, KSampler, SaveImage, …) are core nodes, as are LoraLoader and the hires chain. Their absence does not mean a node pack is missing; it means the backend did not load or the install is broken. So there is really one outcome to distinguish, not four, and it needs an accurate message rather than a type: "Could not load the workflow because this ComfyUI installation is missing core nodes." Naming the individual types there would read as "install this pack" and send people looking for something that does not exist.

That also means nothing from the A1111 path writes to the missing-node panel at all. A node type that was never added to the graph does not belong in a list of nodes missing from the graph.

A3 — this PR's original thesis, and only that: clearAllErrors → clearRunErrors, no longer clearing missing-node state, with clean() keeping an explicit clear so its net behaviour is unchanged. About 12 non-test lines.

Order: A1 then A3. Your point that the follow-up and the removal have to ship together was right — A3 removes the only thing that currently retires an anchor-less API-JSON entry, so A1 has to give those entries an anchor first. A2 is independent of both.

Two other things from your review that were right and are carried into the split: clearRunErrors no longer touches overlay visibility (#8 — it was flipping the panel indicator on as a side effect of pressing Run), and the loadApiJson root-graph clear gets the subgraph guard clean() already has (#11, same gap, second site).

Not carried: the RightSidePanel.vue watchEffect that reassigns the active tab from a computed. You called it out of scope and it is, but you were right that it is the thing that made the placement of this clear a hard decision at all.

@jaeone94

Copy link
Copy Markdown
Collaborator Author

Closing — superseded by the three-PR split described above. Will link A1/A2/A3 here as they open.

@jaeone94

jaeone94 commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator Author

Split is open:

Merge order: #14555 before #14557. #14556 is independent.

Your point that the follow-up and the removal have to ship together is what set that order — #14557 removes the last thing that retires an anchor-less API-JSON entry, so #14555 has to give those entries an anchor first.

kaili-yang pushed a commit to kaili-yang/ComfyUI_frontend that referenced this pull request Aug 5, 2026
…stalls accurately (Comfy-Org#14556)

Splits out of Comfy-Org#14251. Five lifecycle fixes on the A1111 image-import
path. 30 production lines.

## What

Dropping an A1111-generated PNG parses its `parameters` string and
builds a ComfyUI graph from it. The path had four defects that only show
up when something goes wrong, plus one that shows up always:

1. **`afterLoadNewGraph` was not awaited.** It suspends before the
active workflow is reassigned, so `rootGraph.serialize()` on the next
line captured the *outgoing* graph — the new tab was born dirty against
a stale baseline.
2. **A rejection escaped an async DOM handler.** `importA1111` awaits
`api.getEmbeddings()`, which does not check `resp.ok`. On a 500 with an
HTML body it throws, `fileInput.value = ''` never runs, the input still
holds the file, re-selecting it fires no `change` event, and Open
silently does nothing on every retry. Now: `try`/`catch` with a toast,
`finally` resets the input.
3. **Two identical alerts for one file.** The invalid-structure `else`
and the parse `catch` each called `showErrorOnFileLoad`, then fell
through to the final call at the end of `handleFile`. Those two are the
`else` and `catch` of one `try`, so the maximum is two alerts, not
three.
4. **`beforeLoadNewGraph()` ran before an import that might bail.** It
calls `domWidgetStore.clear()`, and nothing re-registers on a bail path
— a workflow with a multiline prompt on screen lost its DOM widget
overlays when the user dropped a PNG that did not parse. It now runs
immediately before the mutation, and the A1111 path gets the subgraph
guard `clean()` already had.
5. **No message at all when required node types are unavailable, and
silent corruption of the open workflow.** `importA1111` logged to the
console and returned `void`. Because the call was unawaited,
`afterLoadNewGraph` then registered the user's *unchanged* graph under
the dropped file's name, after `beforeLoadNewGraph` had already cleared
`domWidgetStore`. See below.

## The message

The seven types this importer needs — `CheckpointLoaderSimple`,
`CLIPSetLastLayer`, `CLIPTextEncode`, `KSampler`, `EmptyLatentImage`,
`VAEDecode`, `SaveImage` — are all **core nodes**, as are `LoraLoader`
and the hires chain. Their absence does not mean a node pack is missing.
It means the backend did not load, or the install is broken.

So this path deliberately writes nothing to the missing-node panel: no
card, no entry, no placeholder. A type that was never added to the graph
does not belong in a list of nodes missing *from the graph*, and naming
the individual types would read as "install this pack" and send people
looking for something that does not exist.

```
"Could not load the workflow because this ComfyUI installation is missing core nodes.
 Check that the backend started correctly."
```

`importA1111` returns `Promise<'imported' | 'not-a1111' |
'core-nodes-unavailable'>` — three string literals, replacing
`Promise<boolean>`. The boolean could not distinguish "bailed and
already told the user" from "bailed silently", which is how an ordinary
A1111 PNG could vanish with no feedback at all: A1111 omits the
`Negative prompt:` line entirely when the negative prompt is empty.

The `core-nodes-unavailable` return happens **before** the graph is
touched, so a failed import leaves the open workflow intact.
`pnginfo.test.ts` asserts that directly.

## What this deliberately does not do

`pnginfo.ts` is **+8 −4**, with zero re-indentation (`git diff` and `git
diff -w` report the same line count). The nesting in that file is not
pretty and it is not this PR's business. An earlier revision
restructured it; that diff was 759 lines, ~72% of it re-indentation, and
none of it fixed a bug. If it deserves a refactor it deserves a PR where
a reviewer sees only that.

## Verification

6 unit tests across `app.test.ts`, `pnginfo.test.ts` and `ui.test.ts`,
each mutation-proved. typecheck, lint, format, knip clean. Full unit
suite: only pre-existing timeout flakes, confirmed by re-running the
same files at the merge base and getting byte-identical results.

## Related

- Follow-up to Comfy-Org#14251 (closed)
- Independent of Comfy-Org#14555 and of the narrow submission fix — no ordering
constraint
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Aug 6, 2026
…omfy-Org#14555)

Splits out of Comfy-Org#14251, which was doing four things at once. This is one
of them.

## What

An API-format (prompt-format) JSON references node types by
`class_type`. When one of those types is not installed, `loadApiJson`
did `if (!node) continue` — the node was dropped, and the missing type
was reported to the Issues panel as a bare string.

A bare string has no `nodeId`, so nothing can retire it:
`removeMissingNodesByNodeId` and `removeMissingNodesByPrefix` both
preserve strings by design, `onNodeRemoved` cannot fire because there is
no node, and `MissingPackGroupRow` renders no Locate action. The entry
outlived everything except a full workflow reload.

Now the node is built from the data instead of being skipped. API format
is what gets submitted to the server, so it carries every input by name
— either a literal or a link:

```json
"3": { "class_type": "PreviewImage",     "inputs": { "images": ["4", 0] } }
"4": { "class_type": "EmptyLatentImage", "inputs": { "width": 512, "height": 512 } }
```

For an uninstalled type we do not have the node definition, but we do
not need it — the names are in the data. Each link input becomes a named
wildcard slot so `processNodeInputs` can resolve it; each literal is
preserved in `widgets_values_named` (keyed, exact) alongside
`widgets_values` (positional, for the existing replacement path).
`last_serialization` carries the real content, and the node's `inputs`
are re-synced after links resolve.

The result is a node on the canvas that is a faithful record of what the
JSON said, flagged `has_errors`, with a real `nodeId`. Locate works,
deleting it retires the entry, and Replace has something to work from.

## The E2E assertion this flips

`workflowPersistence.spec.ts` asserted the unknown type was **absent**
from the graph. That assertion was never a requirement. Its own
annotation says what it guards:

> `PR Comfy-Org#9694 — loadApiJson early-returned on missing node types`

The regression was that the *whole workflow* failed to load. The test is
named "partially loads", and the requirements are the two `toContain`
assertions — the known nodes appear. The `.not.toContain` was the
adjacent comment ("unknown node skipped") frozen into an assertion: a
description of the `if (!node) continue` implementation, not a decision.
It is updated to assert the placeholder is present with `has_errors`.

## Verification

- 5 unit tests, each mutation-proved: revert the production line, watch
the named assertion fail, restore, watch it pass. Removing the slot
creation fails the link assertion; removing the value carry fails the
widget-values assertion.
- `workflowPersistence` Playwright spec run against a local backend:
**14/14**.
- typecheck, lint, format, knip clean.

## Known limitation

The placeholder cannot reproduce a *positional* `widgets_values`
faithfully without the node definition, which is why the keyed form is
the source of truth. If a replacement node's widget names differ from
the API input names, Replace will not map them — that mapping does not
exist today and is out of scope here.

## Related

- Follow-up to Comfy-Org#14251 (closed)
- Lands before the narrow submission fix, which removes the last thing
that currently retires an anchor-less entry

## Screenshot

<img width="1450" height="892" alt="스크린샷 2026-08-03 오후 1 45 56"
src="https://github.com/user-attachments/assets/2a80eddd-5fa9-4201-9e19-d510e532f67e"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants