Repository navigation
Conversation
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
🎭 Playwright: ✅ 1787 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 8.25 MB gzip 🟢 -207 kBDetailsSummary
Category Glance App Entry Points — 3.64 kB (baseline 3.64 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.35 MB (baseline 1.35 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 540 kB (baseline 570 kB) • 🟢 -29.3 kBConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 15 unchanged User & Accounts — 27 kB (baseline 27 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 4 unchanged Editors & Dialogs — 124 kB (baseline 124 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 6 added / 6 removed / 1 unchanged UI Components — 71 kB (baseline 71 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 8 unchanged Data & Services — 3.48 MB (baseline 3.48 MB) • 🔴 +370 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 386 kB (baseline 386 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 17 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 12.8 MB (baseline 13.8 MB) • 🟢 -940 kBBundles that do not match a named category
Status: 104 added / 104 removed / 177 unchanged ⚡ Performance Report
✅ No regressions detected. All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-07T02:13:45.992Z",
"gitSha": "3e40e49f0d1ff31d84d1774f707964690cf37793",
"branch": "jaeone94/prA-a3-narrow",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2064.469000000031,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.3919999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.19599999999997,
"heapDeltaBytes": 5386988,
"heapUsedBytes": 69374324,
"domNodes": 20,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 14.634999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1996.5480000000753,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.116,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.341,
"heapDeltaBytes": 5458412,
"heapUsedBytes": 69405040,
"domNodes": 20,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 13.525,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1688.980000000015,
"styleRecalcs": 73,
"styleRecalcDurationMs": 21.608999999999995,
"layouts": 12,
"layoutDurationMs": 2.2030000000000003,
"taskDurationMs": 623.7199999999999,
"heapDeltaBytes": -11799924,
"heapUsedBytes": 52203476,
"domNodes": -278,
"jsHeapTotalBytes": 23310336,
"scriptDurationMs": 72.845,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1701.6210000000456,
"styleRecalcs": 72,
"styleRecalcDurationMs": 20.864,
"layouts": 12,
"layoutDurationMs": 2.229,
"taskDurationMs": 589.619,
"heapDeltaBytes": -74456,
"heapUsedBytes": 64131400,
"domNodes": 53,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 80.323,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1687.0159999999714,
"styleRecalcs": 33,
"styleRecalcDurationMs": 13.205,
"layouts": 6,
"layoutDurationMs": 0.546,
"taskDurationMs": 304.511,
"heapDeltaBytes": 8067628,
"heapUsedBytes": 72459448,
"domNodes": 81,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 14.472,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1686.9560000000092,
"styleRecalcs": 30,
"styleRecalcDurationMs": 12.286999999999997,
"layouts": 6,
"layoutDurationMs": 0.4960000000000001,
"taskDurationMs": 311.69800000000004,
"heapDeltaBytes": 8139380,
"heapUsedBytes": 72407968,
"domNodes": 79,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 14.838000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 456.61600000005365,
"styleRecalcs": 13,
"styleRecalcDurationMs": 5.541999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 269.177,
"heapDeltaBytes": -12611288,
"heapUsedBytes": 51508600,
"domNodes": 22,
"jsHeapTotalBytes": 26476544,
"scriptDurationMs": 37.105,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 488.9289999999846,
"styleRecalcs": 13,
"styleRecalcDurationMs": 5.287,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 269.55400000000003,
"heapDeltaBytes": -11470884,
"heapUsedBytes": 52663712,
"domNodes": 22,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 37.582,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2026.9329999999854,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.221999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 541.809,
"heapDeltaBytes": 5153864,
"heapUsedBytes": 64983200,
"domNodes": -278,
"jsHeapTotalBytes": 2727936,
"scriptDurationMs": 66.483,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2018.461000000002,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.637999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 540.892,
"heapDeltaBytes": 6497224,
"heapUsedBytes": 66797436,
"domNodes": -282,
"jsHeapTotalBytes": 3252224,
"scriptDurationMs": 64.82499999999999,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2090.233000000012,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.844999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 910.7030000000001,
"heapDeltaBytes": -746336,
"heapUsedBytes": 60085048,
"domNodes": -281,
"jsHeapTotalBytes": 4493312,
"scriptDurationMs": 277.311,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2068.6379999999644,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.816,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 901.9370000000001,
"heapDeltaBytes": 2843012,
"heapUsedBytes": 65165896,
"domNodes": -280,
"jsHeapTotalBytes": 4231168,
"scriptDurationMs": 275.22400000000005,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3068.1070000000545,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.014000000000003,
"layouts": 60,
"layoutDurationMs": 5.136,
"taskDurationMs": 1008.8919999999999,
"heapDeltaBytes": 22517788,
"heapUsedBytes": 84996140,
"domNodes": 14,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 326.85600000000005,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3071.794999999952,
"styleRecalcs": 66,
"styleRecalcDurationMs": 9.962,
"layouts": 60,
"layoutDurationMs": 5.175000000000001,
"taskDurationMs": 1032.248,
"heapDeltaBytes": 22977084,
"heapUsedBytes": 85416180,
"domNodes": 16,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 334.922,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2021.949999999947,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.949000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 544.208,
"heapDeltaBytes": 6732664,
"heapUsedBytes": 69122080,
"domNodes": -280,
"jsHeapTotalBytes": 3776512,
"scriptDurationMs": 66.87100000000001,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2010.7779999999593,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.435999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 537.5969999999999,
"heapDeltaBytes": 6383656,
"heapUsedBytes": 67009328,
"domNodes": -282,
"jsHeapTotalBytes": 3514368,
"scriptDurationMs": 64.856,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 475.15500000008615,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.054000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 285.796,
"heapDeltaBytes": -10800500,
"heapUsedBytes": 53467116,
"domNodes": 22,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 79.386,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 492.0439999999644,
"styleRecalcs": 49,
"styleRecalcDurationMs": 7.901,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 286.315,
"heapDeltaBytes": -10776528,
"heapUsedBytes": 53336944,
"domNodes": 24,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 76.03099999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2007.8459999999723,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.806000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.89099999999996,
"heapDeltaBytes": 5015056,
"heapUsedBytes": 69208056,
"domNodes": 24,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 11.567,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2003.404000000046,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.391999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 372.05899999999997,
"heapDeltaBytes": 5046388,
"heapUsedBytes": 69357064,
"domNodes": 22,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 11.522999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1705.2999999999656,
"styleRecalcs": 79,
"styleRecalcDurationMs": 25.870000000000005,
"layouts": 16,
"layoutDurationMs": 2.5669999999999997,
"taskDurationMs": 622.9670000000001,
"heapDeltaBytes": -18006024,
"heapUsedBytes": 46066700,
"domNodes": -275,
"jsHeapTotalBytes": 23834624,
"scriptDurationMs": 58.188,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1681.9289999999683,
"styleRecalcs": 75,
"styleRecalcDurationMs": 23.42,
"layouts": 16,
"layoutDurationMs": 2.6710000000000003,
"taskDurationMs": 570.316,
"heapDeltaBytes": -4297540,
"heapUsedBytes": 59854416,
"domNodes": 63,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 57.288999999999994,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 882.2209999999586,
"styleRecalcs": 19,
"styleRecalcDurationMs": 21.700999999999997,
"layouts": 15,
"layoutDurationMs": 8.07,
"taskDurationMs": 690.9999999999999,
"heapDeltaBytes": 30594344,
"heapUsedBytes": 98685348,
"domNodes": 13673,
"jsHeapTotalBytes": 15990784,
"scriptDurationMs": 19.539,
"eventListeners": 2373,
"totalBlockingTimeMs": 96,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8103.148000000033,
"styleRecalcs": 249,
"styleRecalcDurationMs": 22.417999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3167.12,
"heapDeltaBytes": 9604324,
"heapUsedBytes": 69933732,
"domNodes": -279,
"jsHeapTotalBytes": 6328320,
"scriptDurationMs": 879.985,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8103.791000000001,
"styleRecalcs": 249,
"styleRecalcDurationMs": 22.316,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3217.997,
"heapDeltaBytes": 11074012,
"heapUsedBytes": 70749188,
"domNodes": -280,
"jsHeapTotalBytes": 6066176,
"scriptDurationMs": 910.938,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 10569.84799999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10553.692000000001,
"heapDeltaBytes": -29375584,
"heapUsedBytes": 167169232,
"domNodes": -8312,
"jsHeapTotalBytes": -9379840,
"scriptDurationMs": 369.46099999999996,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10739.410000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10717.817000000001,
"heapDeltaBytes": -52087932,
"heapUsedBytes": 173109460,
"domNodes": -8312,
"jsHeapTotalBytes": -1773568,
"scriptDurationMs": 406.109,
"eventListeners": -16393,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 13214.847999999962,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.01000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13196.547,
"heapDeltaBytes": -34766060,
"heapUsedBytes": 171381432,
"domNodes": -8312,
"jsHeapTotalBytes": -8069120,
"scriptDurationMs": 646.752,
"eventListeners": -16385,
"totalBlockingTimeMs": 42,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 13169.79600000002,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.889999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13130.459000000003,
"heapDeltaBytes": -30489044,
"heapUsedBytes": 165994108,
"domNodes": -8313,
"jsHeapTotalBytes": -9641984,
"scriptDurationMs": 687.9649999999999,
"eventListeners": -16389,
"totalBlockingTimeMs": 44,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 425.4760000000033,
"styleRecalcs": 14,
"styleRecalcDurationMs": 11.429000000000002,
"layouts": 2,
"layoutDurationMs": 0.2590000000000001,
"taskDurationMs": 81.20799999999998,
"heapDeltaBytes": 5317072,
"heapUsedBytes": 68562372,
"domNodes": 136,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7.482000000000001,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 431.15499999998974,
"styleRecalcs": 14,
"styleRecalcDurationMs": 13.489,
"layouts": 2,
"layoutDurationMs": 0.35899999999999993,
"taskDurationMs": 82.716,
"heapDeltaBytes": 5089812,
"heapUsedBytes": 68281768,
"domNodes": 125,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 6.877000000000002,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
}
]
} |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe execution error store now separates run-scoped error clearing from full cleanup. Queue submission preserves missing-node errors while clearing prior execution errors. ChangesError clearing lifecycle
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/scripts/app.ts`:
- Around line 2411-2413: Update clean() to clear missing model and missing media
state in addition to missing node types, using the corresponding missing-model
and missing-media store cleanup methods alongside
executionErrorStore.clearRunErrors(), executionErrorStore.dismissErrorOverlay(),
and useMissingNodesErrorStore().setMissingNodeTypes([]). Extend the clean() test
to verify both stores are reset.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 7af15b7f-7f59-42bc-903c-903ca8b6b25f
📒 Files selected for processing (4)
src/scripts/app.test.tssrc/scripts/app.tssrc/stores/executionErrorStore.test.tssrc/stores/executionErrorStore.ts
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14557 +/- ##
==========================================
- Coverage 78.61% 78.61% -0.01%
==========================================
Files 1803 1802 -1
Lines 110177 110132 -45
Branches 31437 32268 +831
==========================================
- Hits 86621 86576 -45
+ Misses 23047 23039 -8
- Partials 509 517 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Not a regression —
function clearAllErrors() {
lastExecutionError.value = null
lastPromptError.value = null
lastNodeErrors.value = null
missingNodesStore.setMissingNodeTypes([])
isErrorOverlayOpen.value = false
}This PR splits that into Missing model/media clearing already happens, six lines above if (skipAssetScans) {
useMissingModelStore().createVerificationAbortController().abort()
useMissingMediaStore().createVerificationAbortController().abort()
useMissingModelStore().setMissingModels([])
useMissingMediaStore().setMissingMedia([])
} else {
useMissingModelStore().clearMissingModels()
useMissingMediaStore().clearMissingMedia()
}
if (clean !== false) {
this.canvas.setGraph(this.rootGraph)
this.clean()
}The proposed patch would regress the
On a workflow tab switch ( Not applying. If missing model/media clearing should move into |
|
Integration note: merging this after #14555 needs one import restored, and git will not flag it. Found while building a local A1+A3 tree. The cause is a clean semantic conflict:
Git takes A1's deletion of the import line and this PR's addition of the Handling: whichever of the two lands second must be updated from No code change here — both branches are individually correct, and pre-adding an unused import to #14555 would fail |
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed the diff and traced the clean() parity claim myself rather than taking it. It holds: effect for effect, nothing is dropped or duplicated, only the missing-node and overlay writes swap order, and both are plain ref assignments that nothing observes in between (dismissErrorOverlay reads nothing; the one watcher on missingNodesError is default flush:'pre'). Both former clearAllErrors call sites are migrated and no reference remains anywhere in the tree.
The unit tests are strong. I re-ran mutations against every production line the PR touches and all of them are killed, including the two single-effect variants (re-adding only the overlay reset, or only setMissingNodeTypes([])). executionErrorStore.test.ts is not a mechanical rename: it inverts three assertions and is the only thing pinning that clearRunErrors leaves the overlay alone.
One finding could not be anchored inline because it is about the PR description rather than a diff line:
note (non-blocking): the "Ordering" section is stronger than what I could confirm.
"Landing this one alone would strand them" overstates it. The first half holds: API-JSON entries are bare strings (app.ts:2202), so removeMissingNodesByNodeId and removeMissingNodesByPrefix genuinely cannot touch them, and removeMissingNodesByType is unreachable for them because replaceNodesInPlace walks live graph nodes that were never instantiated.
But they are not unclearable. clean(), which this PR teaches to call setMissingNodeTypes([]), is reachable from Comfy.ClearWorkflow (useCoreCommands.ts:278), the Clear button (ui.ts:674), and loadGraphData(clean=true). Switching or opening a workflow runs showPendingWarnings, which clears when empty. rescanAndSurfaceMissingNodes yields [] for API JSON.
Accurate framing looks like: within the currently-open API-JSON graph, submission was the only in-place clearer, so after this lands you have to discard or switch the workflow to shed the row. Bounded UX regression rather than a permanent leak, which makes #14555 a quality improvement to land first rather than a correctness prerequisite.
| executionErrorStore.clearAllErrors() | ||
| executionErrorStore.clearRunErrors() | ||
| executionErrorStore.dismissErrorOverlay() | ||
| useMissingNodesErrorStore().setMissingNodeTypes([]) |
There was a problem hiding this comment.
issue (blocking): this PR and #14555 auto-merge app.ts into a tree that does not compile.
#14555 removes the useMissingNodesErrorStore import at app.ts:86 when it rewrites showMissingNodesError, because that was the last use. This PR adds a new use here. Git merges both hunks with no conflict.
I ran it. Merge #14555 into main, then this branch, resolve only the app.test.ts conflict, then pnpm typecheck:
src/scripts/app.ts(2435,5): error TS2304: Cannot find name 'useMissingNodesErrorStore'.
app.test.ts does conflict, so a manual rebase forces someone to look. But a merge-queue or merge-commit path that resolves only the test file ships a non-compiling app.ts. Whoever lands second needs to re-add that import, and the order does not matter.
| const executionErrorStore = useExecutionErrorStore() | ||
| const telemetry = useTelemetry() | ||
| executionErrorStore.clearAllErrors() | ||
| executionErrorStore.clearRunErrors() |
There was a problem hiding this comment.
issue: queuePrompt no longer dismisses the error overlay, and mobile linear mode reads that flag raw.
On main, clearAllErrors() here set isErrorOverlayOpen = false on every submit. clearRunErrors does not, and the dismissal was added only to clean().
Desktop is fine: useErrorOverlayState.ts:202-207 gates isVisible on totalErrorCount > 0, so a stale-true flag renders nothing. But MobileDisplay.vue:223 and :257 read the flag directly, with LinearPreview in the v-else:
<MobileError v-if="executionErrorStore.isErrorOverlayOpen" />
<LinearPreview v-else mobile ... />So after a run fails and the overlay opens, tapping Run clears the three error refs and leaves the flag true. MobileError keeps rendering with nothing in it, LinearPreview never appears, and the tab-1 indicator stays lit. It self-heals only when execution_start arrives, which is the whole queue wait for a job behind others, and never if the user cancels first.
Restoring the dismissal here would reintroduce the bug this PR fixes, so gating those two MobileDisplay reads on useErrorOverlayState().isVisible looks like the right direction instead.
| * in-progress model repairs (importTaskIds, URL inputs, etc.). | ||
| * Missing models are cleared separately during workflow load/clean paths. */ | ||
| function clearAllErrors() { | ||
| /** Clear errors tied to the previous run: execution, prompt, and node errors. |
There was a problem hiding this comment.
suggestion (non-blocking): this comment is not accurate for group-node entries.
"Missing nodes are cleared by ComfyApp.clean and the graph error-clearing hooks" holds for entries carrying a nodeId. Group nodes do not: groupNode.ts:778 and :783 push {type, hint} and {type, action} with no nodeId via the beforeConfigureGraph hook, so removeMissingNodesByNodeId and removeMissingNodesByPrefix both skip them by design and only the full-overwrite paths clear them.
This PR's own clean test seeds setMissingNodeTypes(['MissingGroupNode']), so the shape is already in view. Narrowing the sentence to the overwrite paths would keep the comment true.
| vi.spyOn(api, 'dispatchCustomEvent').mockImplementation(() => true) | ||
| } | ||
|
|
||
| it('preserves missing node packs when submitting a prompt', async () => { |
There was a problem hiding this comment.
suggestion (non-blocking): the user-visible bug has no e2e.
The unit tests pin the store and queuePrompt well; I re-ran mutations on every production line this PR touches and all are killed. But the thing a user reports, missing node packs disappearing from the Errors tab when they press Run, is only covered at the store level.
browser_tests/tests/propertiesPanel/errorsTabMissingNodes.spec.ts already exists and is the natural home: load a workflow with a missing pack, submit, assert the panel is still populated. That is the assertion that would survive a future refactor moving the clear somewhere else entirely.
Submitting a prompt used to close the overlay because `clearAllErrors` did both. Splitting that function dropped the dismissal with it, which is wrong: clearing run errors and dismissing the overlay are different actions that happened to share a caller. The dismissal belongs to the submit signal, not to `clearRunErrors`, so it goes at the call site. `clearRunErrors` still leaves the overlay untouched. Without this, `MobileDisplay` — which reads `isErrorOverlayOpen` directly rather than through `useErrorOverlayState().isVisible` — keeps rendering an empty `MobileError` after a submit clears the errors, hiding `LinearPreview` until `execution_start` arrives.
The unit tests pin the store and `queuePrompt`, but the thing a user reports — missing node packs vanishing from the Errors tab on Run — was only covered at the store level. Load a workflow with a missing pack, submit, assert the card survives. Also narrow the `clearRunErrors` comment. Group-node entries are pushed without a `nodeId` (`groupNode.ts:778`, `:783`), so `removeMissingNodesByNodeId` and `removeMissingNodesByPrefix` skip them by design; only the full-overwrite paths clear those.
4b74764 to
37ba004
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
Replaced by #14900 — same thesis, rebased onto Thanks for the review here; all of it carried over. The blocking finding — that this branch and #14555 auto-merge
The one substantive difference: #14900 is deliberately narrower than this branch. An intermediate version generalised the rule to the missing-model and missing-media stores. Three independent unbriefed reviews found five defects in that generalisation — those two stores carry async verification that outlives the graph that started it, a per-workflow cache, and a two-tier repair state, none of which missing nodes have. That work is written up and will be its own change; #14900 fixes the reported bug in four production lines and leaves models and media exactly as they are. |
…-Org#14900) ## Summary Pressing Run emptied the missing-node-pack rows from the Errors tab; the nodes were still missing, the panel just stopped saying so. ## Changes - **What**: `clearAllErrors` was shared by `queuePrompt` ("forget the last run") and `clean()` ("forget this graph"), and cleared missing-node state for both. A submission carries no evidence about the environment — it never checks whether the pack was installed — so it cannot justify dropping the row. The clear moves to `clean()`, and the function is renamed `clearRunErrors` to match what it now does. Missing **model** and **media** state already followed this rule: `clearAllErrors` never touched it, and it is cleared in `loadGraphData` instead. This aligns missing nodes with the two resources that were already right; it does not change when models or media are cleared. Production change is four lines. ## Review Focus **Every discard path still clears.** `clean()` is reached by `loadGraphData`, `loadApiJson`, `Comfy.ClearWorkflow` (`useCoreCommands.ts:279`) and the legacy Clear button (`ui.ts:680`). **Except one, which needed the clear spelled out.** The A1111 import replaces the graph from inside `importA1111` through a `beforeGraphClear` callback and never reaches `clean()`, so it already left the store describing the outgoing graph. That was survivable only because the next submission happened to wipe it — with submissions no longer clearing, the stale rows would persist indefinitely. `afterLoadNewGraph` does not call `showPendingWarnings`, so nothing else re-syncs that path. The callback runs after the parameters and required core nodes validate, so a failed import keeps the current state. **What this deliberately does not do.** An earlier version of this PR generalised the same rule to the missing-model and missing-media stores. It was abandoned: those two carry async verification that outlives the graph that started it, plus a per-workflow cache and a two-tier repair state, and unifying them produced five separate defects (cache resurrection after discard, cache not synced on per-node removal, verification not aborted, an abort whose signal was passed but never checked after the await, and the A1111 bypass for all three resources). None of that is in this PR. It is written up separately and will be its own change. ## Verification Four tests, each mutation-proved — revert the production line, watch the named test fail, restore, watch it pass: | mutation | fails | |---|---| | restore the clear inside `clearRunErrors` | `preserves missing node packs when submitting a prompt`, store test, E2E | | drop `clean()`'s clear | `clears missing node packs when the graph is discarded` | | drop the A1111 callback clear | `clears missing node packs, which its graph swap skips clean() for` | | drop `queuePrompt`'s `clearRunErrors()` | queue unit test | The E2E (`errorsTabMissingNodes.spec.ts`) waits on the `POST /api/prompt` response before re-asserting, so it observes the state after the submit path has run rather than racing it. `pnpm typecheck`, `pnpm typecheck:browser`, `pnpm lint` (0 errors), `pnpm knip`, `pnpm format` all clean; 88 unit tests and the E2E pass. Replaces Comfy-Org#14557.
The original thesis of #14251, and nothing else. 10 production lines added, 10 removed.
What
Missing node packs were wiped from the Issues panel on every prompt submission, while missing model and media state was deliberately preserved. This aligns node packs with the other two.
A submission carries no information about whether a node pack is installed. The missing node can sit on a branch the run never touches, and installing a pack needs a backend restart either way.
Why it started mattering
#14177 replaced the Run-button warning icon's independent derivation with a store read:
Before that the icon re-derived from the graph on every access, so clearing on submit could not affect it. After it, the icon is a pure read of
missingNodeTypes, and the submit-time wipe started flipping the Run button fromtriangle-alertback toplayon the first submission.Blame also shows the clear was an omission rather than a decision: the commit that introduced missing-node state added it in the same stroke with no comment and no test, and the
clearAllErrors()call inqueuePromptpredates missing-node state by ~20 months.Changes
clearAllErrorsrenamed toclearRunErrors. It clears the three categories this store owns — execution, prompt and node errors — and no longer touches missing-node state or overlay visibility. The name now matches what it does.ComfyApp.clean()spells out what it used to get transitively: the missing-node clear and the overlay dismissal. Its net behaviour is unchanged — all eight effects are preserved, only the ordering of two inert steps differs.The single intended behaviour change is at
queuePrompt.Why the overlay dismissal moved rather than disappeared
Leaving
isErrorOverlayOpen = falseinclearRunErrorswould have been actively wrong once missing-node state survives:hasAnyErrorstays true while the overlay closes, which flipsshowErrorIndicatorOnPanelButton(TopMenuSection.vue:274) from false to true. A red indicator would appear as a side effect of pressing Run.MobileDisplay.vuealso reads the flag raw, with no error-count guard.Ordering
#14555 first, but as a quality improvement rather than a prerequisite. (Corrected after review — the original wording overstated this.)
API-JSON entries are bare strings (
app.ts:2202), soremoveMissingNodesByNodeIdandremoveMissingNodesByPrefixcannot touch them, andremoveMissingNodesByTypeis unreachable becausereplaceNodesInPlacewalks live graph nodes that were never instantiated. #14555 gives those entries anodeId, which makes the existing removers work.They are not unclearable without it, though.
clean()— which this PR teaches to callsetMissingNodeTypes([])— is reachable fromComfy.ClearWorkflow(useCoreCommands.ts:278), the Clear button (ui.ts:674) andloadGraphData(clean=true); switching or opening a workflow runsshowPendingWarnings, which clears when empty.So the accurate framing: within the currently-open API-JSON graph, submission was the only in-place clearer, and after this lands you have to discard or switch the workflow to shed the row. A bounded UX regression, not a permanent leak.
#14556 is independent of both, and has already merged.
Verification
3 unit tests, mutation-proved.
clean()parity against the merge base checked effect by effect. NoclearAllErrorsreference remains anywhere in the tree. typecheck, lint, format, knip clean; the full unit suite's failures reproduce identically at the merge base.Related