Skip to content

test: restore deleted subgraph serialization E2E tests - #11579

Merged
DrJKL merged 7 commits into
mainfrom
glary/restore-subgraph-serialization-tests
Apr 27, 2026
Merged

DrJKL merged 7 commits into
mainfrom
glary/restore-subgraph-serialization-tests

Conversation

@DrJKL

@DrJKL DrJKL commented Apr 23, 2026 •

Copy link
Copy Markdown
Contributor

PR Created by the Glary-Bot Agent


Summary

#10759 removed ~12 E2E tests from subgraphSerialization.spec.ts during a reorganization that shifted semantic coverage to Vitest. Several of the removed tests covered the exact serialize() → JSON → configure() round-trip that #10849's positional _instanceWidgetValues path later regressed on Main — promoted widget values binding to the wrong slots when loading templates whose widgets_values ordering doesn't match current proxyWidgets.

This restores the pre-reorg E2E coverage so future regressions in promoted-widget serialization are caught at the browser level.

Restored tests

From subgraphSerialization.spec.ts (pre-#10759):

  • Deterministic proxyWidgets Hydrate (3 tests) — round-trip stability and compressed target_slot resolution.
  • Legacy And Round-Trip Coverage (5 tests) — includes the most directly-relevant restorations:
    • Promoted widgets survive serialize -> loadGraphData round-trip
    • Multi-link input representative stays stable through save/reload
    • Cloning a subgraph node keeps promoted widget entries on original and clone
  • Duplicate ID Remapping (5 tests) — includes Promoted widget tuples are stable after full page reload boot path.

The 4 tests that already existed on Main (added by #10849 and the Vue-nodes legacy-prefixed block) are kept as-is.

Adaptations to current APIs

  • Imports reworked for the post-@e2e/* alias layout.
  • Redundant comfyPage.nextFrame() calls dropped — loadWorkflow / loadGraphData / serializeAndReload already wait internally (test: Add waitForWorkflowIdle & remove redundant nextFrame #11264).
  • Alt-drag clone block wrapped in try/finally around keyboard.up('Alt') to match the current subgraphCrud.spec.ts pattern.
  • PromotedWidgetEntry is now exported from browser_tests/helpers/promotedWidgets.ts so the restored expectPromotedWidgetsToResolveToInteriorNodes helper can type its argument.

Review follow-ups applied

  • Use expect.poll() instead of expect(async () => …).toPass() for the single-value snapshot comparison, per browser_tests/AGENTS.md.
  • Capture and call dispose() from SubgraphHelper.collectConsoleWarnings() inside a try/finally so the console listener is unregistered after the test.

Verification

  • pnpm typecheck:browser — clean.
  • pnpm exec eslint + pnpm exec oxlint on changed files — 0 warnings, 0 errors.
  • pnpm exec oxfmt on changed files — applied (no diff).
  • Ran 2 key restored tests against local ComfyUI + dev server:
    • Promoted widgets survive serialize -> loadGraphData round-trip — PASS (3.9s)
    • Multi-link input representative stays stable through save/reload — PASS (2.9s)
  • Full-suite runs in this sandbox are blocked by the existing comfyPage fixture's createUser path failing on repeat runs against persistent backend state — unrelated to this PR. CI will exercise the full suite.

┆Issue is synchronized with this Notion page by Unito

PR #10759 removed ~12 E2E tests from subgraphSerialization.spec.ts during
a reorganization that shifted semantic coverage to Vitest. Several of the
removed tests covered the exact save/load round-trip that PR #10849's
positional _instanceWidgetValues path later regressed on Main (promoted
widget values binding to wrong slots after configure).

Restore the pre-reorg test coverage so future regressions in promoted
widget serialization are caught at the E2E level:

- Deterministic proxyWidgets Hydrate (3 tests)
- Legacy And Round-Trip Coverage (5 tests)
- Duplicate ID Remapping (5 tests)

Export PromotedWidgetEntry from the promotedWidgets helper so the restored
tests can type the helper results.
- Replace expect(async () => ...).toPass() with expect.poll() for the
  single-value snapshot comparison (matches browser_tests/AGENTS.md guidance)
- Capture and call dispose() from collectConsoleWarnings() inside a
  try/finally to avoid leaking the console listener after the test
@coderabbitai

coderabbitai Bot commented Apr 23, 2026 •

Copy link
Copy Markdown
Contributor

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

A single type alias (PromotedWidgetEntry) in browser_tests/helpers/promotedWidgets.ts was exported, and browser_tests/tests/subgraph/subgraphSerialization.spec.ts was substantially expanded with multiple new test suites covering promoted-widget hydration, determinism across reloads, ID remapping, cloning/regression checks, legacy normalization, and UI/assertion updates.

Changes

Cohort / File(s) Summary
Type Export
browser_tests/helpers/promotedWidgets.ts
Changed a private tuple type to a public export: export type PromotedWidgetEntry = [string, string].
Subgraph Serialization Tests (expanded)
browser_tests/tests/subgraph/subgraphSerialization.spec.ts
Large expansion of test suites: promoted-widget interior-node resolution, determinism across serializeAndReload() and full page reload, legacy -1 proxy hydration/normalization, promoted-widget persistence across clone/round-trip operations, multi-link snapshot stability, duplicate/global ID remapping (root canonicalization and link endpoint resolvability), continued subgraph navigation after remapping, UI assertions for rendered rows/labels, and console warning checks.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Poem

🐰 I hopped through nodes both old and new,
I exported a tuple and checked each view,
IDs remapped and widgets held tight,
Round-trips, clones, and reloads at night,
A carrot-cheer for tests passing bright! 🥕

🚥 Pre-merge checks | ✅ 6 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: restoring previously-deleted E2E tests for subgraph serialization, which is the core focus of this PR.
Description check ✅ Passed The description is comprehensive and well-structured, covering summary, restored tests, adaptations, verification steps, and follow-ups applied, matching the template's core requirements.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed PR passes regression coverage check: title/commits lack bug-fix language, files are under browser_tests/, and description explains tests were restored because they previously caught regression #10849.
Adr Compliance For Entity/Litegraph Changes ✅ Passed PR only modifies test files in browser_tests/ directory, which do not fall under src/lib/litegraph/, src/ecs/, or source files related to graph entities.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch glary/restore-subgraph-serialization-tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Apr 23, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 04/25/2026, 08:17:21 AM UTC

Links

@github-actions

github-actions Bot commented Apr 23, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1336 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1321 / ❌ 0 / ⚠️ 0 / ⏭️ 1)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 12 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

@github-actions

github-actions Bot commented Apr 23, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle: 5.21 MB gzip 🟢 -43 B

Details

Summary

  • Raw size: 24 MB baseline 24 MB — ⚪ 0 B
  • Gzip: 5.21 MB baseline 5.21 MB — 🟢 -43 B
  • Brotli: 4.03 MB baseline 4.03 MB — 🟢 -378 B
  • Bundles: 255 current • 255 baseline • 116 added / 116 removed

Category Glance
Vendor & Third-Party ⚪ 0 B (9.88 MB) · Other ⚪ 0 B (8.77 MB) · Data & Services ⚪ 0 B (3.02 MB) · Graph Workspace ⚪ 0 B (1.22 MB) · Panels & Settings ⚪ 0 B (483 kB) · Utilities & Hooks ⚪ 0 B (361 kB) · + 5 more

App Entry Points — 22.4 kB (baseline 22.4 kB) • ⚪ 0 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-B-ZrY6aJ.js (removed) 22.4 kB — 🟢 -22.4 kB 🟢 -7.96 kB 🟢 -6.85 kB
assets/index-DDq_IPf0.js (new) — 22.4 kB 🔴 +22.4 kB 🔴 +7.96 kB 🔴 +6.83 kB

Status: 1 added / 1 removed

Graph Workspace — 1.22 MB (baseline 1.22 MB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView--T4SCmPM.js (new) — 1.22 MB 🔴 +1.22 MB 🔴 +260 kB 🔴 +196 kB
assets/GraphView-Cf1IR-ug.js (removed) 1.22 MB — 🟢 -1.22 MB 🟢 -260 kB 🟢 -196 kB

Status: 1 added / 1 removed

Views & Navigation — 76.6 kB (baseline 76.6 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CloudSurveyView-Dk04KeZK.js (new) — 15.7 kB 🔴 +15.7 kB 🔴 +3.4 kB 🔴 +2.91 kB
assets/CloudSurveyView-DuRivd9u.js (removed) 15.7 kB — 🟢 -15.7 kB 🟢 -3.39 kB 🟢 -2.9 kB
assets/CloudLoginView-CIUhW0DJ.js (new) — 12 kB 🔴 +12 kB 🔴 +3.35 kB 🔴 +2.96 kB
assets/CloudLoginView-ewlAE0VO.js (removed) 12 kB — 🟢 -12 kB 🟢 -3.35 kB 🟢 -2.97 kB
assets/CloudSignupView-Ds0ymacK.js (removed) 9.78 kB — 🟢 -9.78 kB 🟢 -2.85 kB 🟢 -2.5 kB
assets/CloudSignupView-DYpCd1l-.js (new) — 9.78 kB 🔴 +9.78 kB 🔴 +2.85 kB 🔴 +2.52 kB
assets/UserCheckView-B5s8baRX.js (removed) 9.04 kB — 🟢 -9.04 kB 🟢 -2.32 kB 🟢 -2.04 kB
assets/UserCheckView-fI-VN7OA.js (new) — 9.04 kB 🔴 +9.04 kB 🔴 +2.32 kB 🔴 +2.03 kB
assets/CloudLayoutView-C8y2IPnD.js (new) — 7.54 kB 🔴 +7.54 kB 🔴 +2.36 kB 🔴 +2.05 kB
assets/CloudLayoutView-DziEOrvm.js (removed) 7.54 kB — 🟢 -7.54 kB 🟢 -2.36 kB 🟢 -2.05 kB
assets/CloudForgotPasswordView-2cdE83Zr.js (removed) 5.94 kB — 🟢 -5.94 kB 🟢 -2.09 kB 🟢 -1.84 kB
assets/CloudForgotPasswordView-DiRJ4ufI.js (new) — 5.94 kB 🔴 +5.94 kB 🔴 +2.09 kB 🔴 +1.84 kB
assets/CloudAuthTimeoutView-D_TPz_aH.js (removed) 5.31 kB — 🟢 -5.31 kB 🟢 -1.93 kB 🟢 -1.71 kB
assets/CloudAuthTimeoutView-fHKGTDzD.js (new) — 5.31 kB 🔴 +5.31 kB 🔴 +1.93 kB 🔴 +1.69 kB
assets/CloudSubscriptionRedirectView-BU0AaPrz.js (new) — 5.08 kB 🔴 +5.08 kB 🔴 +1.91 kB 🔴 +1.69 kB
assets/CloudSubscriptionRedirectView-BxdnSjJR.js (removed) 5.08 kB — 🟢 -5.08 kB 🟢 -1.91 kB 🟢 -1.69 kB
assets/UserSelectView-B8Z6g6hq.js (removed) 4.71 kB — 🟢 -4.71 kB 🟢 -1.74 kB 🟢 -1.54 kB
assets/UserSelectView-BHu4b-Ug.js (new) — 4.71 kB 🔴 +4.71 kB 🔴 +1.74 kB 🔴 +1.54 kB

Status: 9 added / 9 removed / 2 unchanged

Panels & Settings — 483 kB (baseline 483 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/KeybindingPanel-9qkoOsCt.js (new) — 46.5 kB 🔴 +46.5 kB 🔴 +9.54 kB 🔴 +8.48 kB
assets/KeybindingPanel-eI_w60hd.js (removed) 46.5 kB — 🟢 -46.5 kB 🟢 -9.53 kB 🟢 -8.48 kB
assets/SecretsPanel-BxWwzt8l.js (new) — 22.5 kB 🔴 +22.5 kB 🔴 +5.46 kB 🔴 +4.79 kB
assets/SecretsPanel-CKmzv8ku.js (removed) 22.5 kB — 🟢 -22.5 kB 🟢 -5.46 kB 🟢 -4.8 kB
assets/LegacyCreditsPanel-BjoZ1GPs.js (new) — 21.5 kB 🔴 +21.5 kB 🔴 +5.81 kB 🔴 +5.13 kB
assets/LegacyCreditsPanel-D0Vq9CJM.js (removed) 21.5 kB — 🟢 -21.5 kB 🟢 -5.81 kB 🟢 -5.13 kB
assets/SubscriptionPanel-CBF00KxN.js (removed) 19.7 kB — 🟢 -19.7 kB 🟢 -5.03 kB 🟢 -4.43 kB
assets/SubscriptionPanel-mseFHc4W.js (new) — 19.7 kB 🔴 +19.7 kB 🔴 +5.03 kB 🔴 +4.45 kB
assets/AboutPanel-lGQ_gpXg.js (removed) 12 kB — 🟢 -12 kB 🟢 -3.33 kB 🟢 -2.99 kB
assets/AboutPanel-Wk1ZTP0v.js (new) — 12 kB 🔴 +12 kB 🔴 +3.33 kB 🔴 +2.98 kB
assets/ExtensionPanel-BgB03qlB.js (new) — 9.78 kB 🔴 +9.78 kB 🔴 +2.82 kB 🔴 +2.5 kB
assets/ExtensionPanel-i3Kot-gp.js (removed) 9.78 kB — 🟢 -9.78 kB 🟢 -2.82 kB 🟢 -2.51 kB
assets/ServerConfigPanel-CmFdGFbe.js (removed) 6.85 kB — 🟢 -6.85 kB 🟢 -2.27 kB 🟢 -2.04 kB
assets/ServerConfigPanel-CzpawNPf.js (new) — 6.85 kB 🔴 +6.85 kB 🔴 +2.27 kB 🔴 +2.03 kB
assets/UserPanel-BUCnWzVN.js (new) — 6.56 kB 🔴 +6.56 kB 🔴 +2.15 kB 🔴 +1.88 kB
assets/UserPanel-CNvPYzms.js (removed) 6.56 kB — 🟢 -6.56 kB 🟢 -2.15 kB 🟢 -1.88 kB
assets/cloudRemoteConfig-DeNB4s-Z.js (new) — 1.85 kB 🔴 +1.85 kB 🔴 +899 B 🔴 +797 B
assets/cloudRemoteConfig-DYLbdXWJ.js (removed) 1.85 kB — 🟢 -1.85 kB 🟢 -902 B 🟢 -793 B
assets/refreshRemoteConfig-Dih6aN-r.js (new) — 1.45 kB 🔴 +1.45 kB 🔴 +648 B 🔴 +553 B
assets/refreshRemoteConfig-f18pqQ4p.js (removed) 1.45 kB — 🟢 -1.45 kB 🟢 -650 B 🟢 -549 B

Status: 10 added / 10 removed / 11 unchanged

User & Accounts — 17.1 kB (baseline 17.1 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/auth-B-w9A3G-.js (removed) 3.57 kB — 🟢 -3.57 kB 🟢 -1.26 kB 🟢 -1.07 kB
assets/auth-YnKE8VyH.js (new) — 3.57 kB 🔴 +3.57 kB 🔴 +1.26 kB 🔴 +1.07 kB
assets/SignUpForm-BER53ULC.js (removed) 3.16 kB — 🟢 -3.16 kB 🟢 -1.28 kB 🟢 -1.15 kB
assets/SignUpForm-C5NzZxFq.js (new) — 3.16 kB 🔴 +3.16 kB 🔴 +1.29 kB 🔴 +1.15 kB
assets/UpdatePasswordContent-DVjUxGYm.js (removed) 2.7 kB — 🟢 -2.7 kB 🟢 -1.21 kB 🟢 -1.07 kB
assets/UpdatePasswordContent-EynI9em6.js (new) — 2.7 kB 🔴 +2.7 kB 🔴 +1.21 kB 🔴 +1.07 kB
assets/authStore-Bmixa3UC.js (removed) 989 B — 🟢 -989 B 🟢 -483 B 🟢 -436 B
assets/authStore-IzqKuQuN.js (new) — 989 B 🔴 +989 B 🔴 +482 B 🔴 +432 B
assets/auth-C503cHIf.js (removed) 348 B — 🟢 -348 B 🟢 -216 B 🟢 -190 B
assets/auth-DRnBJZZS.js (new) — 348 B 🔴 +348 B 🔴 +218 B 🔴 +190 B

Status: 5 added / 5 removed / 2 unchanged

Editors & Dialogs — 110 kB (baseline 110 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useShareDialog-BoRFGWrz.js (new) — 109 kB 🔴 +109 kB 🔴 +22.5 kB 🔴 +18.9 kB
assets/useShareDialog-DhY2va6r.js (removed) 109 kB — 🟢 -109 kB 🟢 -22.5 kB 🟢 -18.9 kB
assets/useSubscriptionDialog-Bbhc6mag.js (removed) 969 B — 🟢 -969 B 🟢 -474 B 🟢 -418 B
assets/useSubscriptionDialog-CsdHuMsF.js (new) — 969 B 🔴 +969 B 🔴 +471 B 🔴 +416 B

Status: 2 added / 2 removed

UI Components — 60.5 kB (baseline 60.5 kB) • ⚪ 0 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyQueueButton-CAbMThoo.js (new) — 13.5 kB 🔴 +13.5 kB 🔴 +3.79 kB 🔴 +3.38 kB
assets/ComfyQueueButton-DVLZF-_h.js (removed) 13.5 kB — 🟢 -13.5 kB 🟢 -3.79 kB 🟢 -3.38 kB
assets/useTerminalTabs-Cm8LzN-w.js (removed) 10.9 kB — 🟢 -10.9 kB 🟢 -3.65 kB 🟢 -3.21 kB
assets/useTerminalTabs-CnukoMds.js (new) — 10.9 kB 🔴 +10.9 kB 🔴 +3.65 kB 🔴 +3.21 kB
assets/SubscribeButton-Cwd0sAFK.js (new) — 2.42 kB 🔴 +2.42 kB 🔴 +1.05 kB 🔴 +934 B
assets/SubscribeButton-o4IY7gRE.js (removed) 2.42 kB — 🟢 -2.42 kB 🟢 -1.05 kB 🟢 -946 B
assets/cloudFeedbackTopbarButton-9qwkJ1HO.js (removed) 1.64 kB — 🟢 -1.64 kB 🟢 -856 B 🟢 -750 B
assets/cloudFeedbackTopbarButton-CcCgT1U-.js (new) — 1.64 kB 🔴 +1.64 kB 🔴 +854 B 🔴 +749 B
assets/ComfyQueueButton-DgiJ-rO7.js (new) — 1.03 kB 🔴 +1.03 kB 🔴 +485 B 🔴 +437 B
assets/ComfyQueueButton-MrbgRe_S.js (removed) 1.03 kB — 🟢 -1.03 kB 🟢 -487 B 🟢 -443 B

Status: 5 added / 5 removed / 8 unchanged

Data & Services — 3.02 MB (baseline 3.02 MB) • ⚪ 0 B

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/dialogService-BbzGzvQf.js (new) — 1.97 MB 🔴 +1.97 MB 🔴 +452 kB 🔴 +342 kB
assets/dialogService-CPTzrXnv.js (removed) 1.97 MB — 🟢 -1.97 MB 🟢 -452 kB 🟢 -343 kB
assets/api-DXABHeuA.js (new) — 893 kB 🔴 +893 kB 🔴 +214 kB 🔴 +168 kB
assets/api-xL245YiI.js (removed) 893 kB — 🟢 -893 kB 🟢 -214 kB 🟢 -168 kB
assets/load3dService-C8-R3VAP.js (removed) 105 kB — 🟢 -105 kB 🟢 -22.1 kB 🟢 -18.9 kB
assets/load3dService-CVQgsgZl.js (new) — 105 kB 🔴 +105 kB 🔴 +22.1 kB 🔴 +18.8 kB
assets/workflowShareService-a-mh-qHr.js (removed) 16.6 kB — 🟢 -16.6 kB 🟢 -4.88 kB 🟢 -4.33 kB
assets/workflowShareService-CgMOIKgS.js (new) — 16.6 kB 🔴 +16.6 kB 🔴 +4.89 kB 🔴 +4.33 kB
assets/keybindingService-D7v9PL0s.js (removed) 13.8 kB — 🟢 -13.8 kB 🟢 -3.66 kB 🟢 -3.21 kB
assets/keybindingService-vI43BT9v.js (new) — 13.8 kB 🔴 +13.8 kB 🔴 +3.67 kB 🔴 +3.21 kB
assets/releaseStore-DF9YP9oe.js (removed) 8.12 kB — 🟢 -8.12 kB 🟢 -2.28 kB 🟢 -2 kB
assets/releaseStore-pbcCz6Sa.js (new) — 8.12 kB 🔴 +8.12 kB 🔴 +2.28 kB 🔴 +2 kB
assets/userStore-D33Litau.js (new) — 2.24 kB 🔴 +2.24 kB 🔴 +869 B 🔴 +760 B
assets/userStore-DEiUoclP.js (removed) 2.24 kB — 🟢 -2.24 kB 🟢 -870 B 🟢 -761 B
assets/audioService-8WAtAKbv.js (removed) 1.8 kB — 🟢 -1.8 kB 🟢 -878 B 🟢 -756 B
assets/audioService-C1Q1QXcr.js (new) — 1.8 kB 🔴 +1.8 kB 🔴 +878 B 🔴 +759 B
assets/releaseStore-Bo1z6k6p.js (new) — 993 B 🔴 +993 B 🔴 +477 B 🔴 +427 B
assets/releaseStore-DRHAaSKv.js (removed) 993 B — 🟢 -993 B 🟢 -479 B 🟢 -426 B
assets/workflowDraftStore-B-J9GLH6.js (removed) 969 B — 🟢 -969 B 🟢 -471 B 🟢 -423 B
assets/workflowDraftStore-Dth3H58O.js (new) — 969 B 🔴 +969 B 🔴 +470 B 🔴 +422 B
assets/dialogService-CIan3wsg.js (removed) 958 B — 🟢 -958 B 🟢 -465 B 🟢 -419 B
assets/dialogService-Dpn0a_xr.js (new) — 958 B 🔴 +958 B 🔴 +463 B 🔴 +417 B
assets/settingStore-CeLjBCv7.js (removed) 956 B — 🟢 -956 B 🟢 -468 B 🟢 -418 B
assets/settingStore-CEXvRigZ.js (new) — 956 B 🔴 +956 B 🔴 +466 B 🔴 +415 B
assets/assetsStore-CshsThUG.js (new) — 955 B 🔴 +955 B 🔴 +466 B 🔴 +416 B
assets/assetsStore-DqFsVQAu.js (removed) 955 B — 🟢 -955 B 🟢 -468 B 🟢 -421 B

Status: 13 added / 13 removed / 4 unchanged

Utilities & Hooks — 361 kB (baseline 361 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useConflictDetection-CRVs2j4w.js (removed) 233 kB — 🟢 -233 kB 🟢 -51.8 kB 🟢 -42.2 kB
assets/useConflictDetection-CxVkxLmv.js (new) — 233 kB 🔴 +233 kB 🔴 +51.8 kB 🔴 +42.2 kB
assets/useLoad3d-BfYga17s.js (new) — 21.6 kB 🔴 +21.6 kB 🔴 +4.92 kB 🔴 +4.37 kB
assets/useLoad3d-CqzhlJY_.js (removed) 21.6 kB — 🟢 -21.6 kB 🟢 -4.92 kB 🟢 -4.35 kB
assets/useLoad3dViewer-BxsRwJFI.js (new) — 20.2 kB 🔴 +20.2 kB 🔴 +4.74 kB 🔴 +4.14 kB
assets/useLoad3dViewer-CRnmnZjT.js (removed) 20.2 kB — 🟢 -20.2 kB 🟢 -4.74 kB 🟢 -4.14 kB
assets/useFeatureFlags-BYHNvjBf.js (new) — 5.95 kB 🔴 +5.95 kB 🔴 +1.79 kB 🔴 +1.52 kB
assets/useFeatureFlags-DO4fBPeV.js (removed) 5.95 kB — 🟢 -5.95 kB 🟢 -1.8 kB 🟢 -1.52 kB
assets/useCopyToClipboard-Bnmpmra8.js (new) — 5.29 kB 🔴 +5.29 kB 🔴 +1.86 kB 🔴 +1.58 kB
assets/useCopyToClipboard-DndxkENd.js (removed) 5.29 kB — 🟢 -5.29 kB 🟢 -1.86 kB 🟢 -1.57 kB
assets/useWorkspaceUI-BSYzhNUd.js (new) — 3.34 kB 🔴 +3.34 kB 🔴 +982 B 🔴 +807 B
assets/useWorkspaceUI-BuGnGs-C.js (removed) 3.34 kB — 🟢 -3.34 kB 🟢 -980 B 🟢 -810 B
assets/subscriptionCheckoutUtil-BmScegFZ.js (removed) 3.31 kB — 🟢 -3.31 kB 🟢 -1.36 kB 🟢 -1.19 kB
assets/subscriptionCheckoutUtil-D9VNmsTi.js (new) — 3.31 kB 🔴 +3.31 kB 🔴 +1.36 kB 🔴 +1.19 kB
assets/assetPreviewUtil-cyr5w7P3.js (removed) 2.27 kB — 🟢 -2.27 kB 🟢 -960 B 🟢 -838 B
assets/assetPreviewUtil-qK-3Tbvv.js (new) — 2.27 kB 🔴 +2.27 kB 🔴 +960 B 🔴 +834 B
assets/useUpstreamValue-Cy6QcwKk.js (new) — 2.08 kB 🔴 +2.08 kB 🔴 +806 B 🔴 +708 B
assets/useUpstreamValue-yJokVGeq.js (removed) 2.08 kB — 🟢 -2.08 kB 🟢 -806 B 🟢 -710 B
assets/useLoad3d-CLx08lgs.js (removed) 1.13 kB — 🟢 -1.13 kB 🟢 -538 B 🟢 -480 B
assets/useLoad3d-DRqs6_4b.js (new) — 1.13 kB 🔴 +1.13 kB 🔴 +536 B 🔴 +478 B
assets/useLoad3dViewer-BlppJy4F.js (removed) 1.07 kB — 🟢 -1.07 kB 🟢 -504 B 🟢 -454 B
assets/useLoad3dViewer-gnkCMJ7T.js (new) — 1.07 kB 🔴 +1.07 kB 🔴 +502 B 🔴 +452 B
assets/useCurrentUser-CN9NPOMB.js (new) — 955 B 🔴 +955 B 🔴 +466 B 🔴 +413 B
assets/useCurrentUser-CndGoGe5.js (removed) 955 B — 🟢 -955 B 🟢 -469 B 🟢 -417 B
assets/useWorkspaceSwitch-DHOH8Fw4.js (new) — 747 B 🔴 +747 B 🔴 +384 B 🔴 +331 B
assets/useWorkspaceSwitch-VBZFKWA5.js (removed) 747 B — 🟢 -747 B 🟢 -385 B 🟢 -331 B

Status: 13 added / 13 removed / 18 unchanged

Vendor & Third-Party — 9.88 MB (baseline 9.88 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 16 unchanged

Other — 8.77 MB (baseline 8.77 MB) • ⚪ 0 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/core-B7ASNk3K.js (new) — 76.4 kB 🔴 +76.4 kB 🔴 +19.8 kB 🔴 +16.9 kB
assets/core-C3cqWsor.js (removed) 76.4 kB — 🟢 -76.4 kB 🟢 -19.8 kB 🟢 -16.9 kB
assets/groupNode-CWS62BAf.js (new) — 74.9 kB 🔴 +74.9 kB 🔴 +18.7 kB 🔴 +16.5 kB
assets/groupNode-Dv-dglar.js (removed) 74.9 kB — 🟢 -74.9 kB 🟢 -18.7 kB 🟢 -16.5 kB
assets/WidgetSelect-CDm0oDCj.js (removed) 65 kB — 🟢 -65 kB 🟢 -14 kB 🟢 -12.1 kB
assets/WidgetSelect-DuG6GMVf.js (new) — 65 kB 🔴 +65 kB 🔴 +14 kB 🔴 +12.2 kB
assets/SubscriptionRequiredDialogContentWorkspace-C2hQfSgc.js (removed) 49.1 kB — 🟢 -49.1 kB 🟢 -9.35 kB 🟢 -7.98 kB
assets/SubscriptionRequiredDialogContentWorkspace-CDqVvGtE.js (new) — 49.1 kB 🔴 +49.1 kB 🔴 +9.35 kB 🔴 +8.02 kB
assets/Load3DControls-BH1J9Np7.js (removed) 45.9 kB — 🟢 -45.9 kB 🟢 -7.47 kB 🟢 -6.52 kB
assets/Load3DControls-D2Vhlr_d.js (new) — 45.9 kB 🔴 +45.9 kB 🔴 +7.46 kB 🔴 +6.52 kB
assets/WidgetPainter-9_eMM6R6.js (new) — 33.8 kB 🔴 +33.8 kB 🔴 +8.22 kB 🔴 +7.28 kB
assets/WidgetPainter-s6VMzWt3.js (removed) 33.8 kB — 🟢 -33.8 kB 🟢 -8.22 kB 🟢 -7.28 kB
assets/WorkspacePanelContent-BY56-FSX.js (new) — 32.6 kB 🔴 +32.6 kB 🔴 +6.93 kB 🔴 +6.14 kB
assets/WorkspacePanelContent-CZi7y75R.js (removed) 32.6 kB — 🟢 -32.6 kB 🟢 -6.93 kB 🟢 -6.13 kB
assets/Load3dViewerContent-DNemf7QJ.js (new) — 28.3 kB 🔴 +28.3 kB 🔴 +5.89 kB 🔴 +5.12 kB
assets/Load3dViewerContent-DyWWluRY.js (removed) 28.3 kB — 🟢 -28.3 kB 🟢 -5.89 kB 🟢 -5.12 kB
assets/SubscriptionRequiredDialogContent-DgbvGOkN.js (new) — 27.3 kB 🔴 +27.3 kB 🔴 +6.88 kB 🔴 +6.08 kB
assets/SubscriptionRequiredDialogContent-wQVeukNr.js (removed) 27.3 kB — 🟢 -27.3 kB 🟢 -6.88 kB 🟢 -6.1 kB
assets/WidgetImageCrop-CcwVP7qT.js (new) — 24.2 kB 🔴 +24.2 kB 🔴 +6.14 kB 🔴 +5.42 kB
assets/WidgetImageCrop-DCf1Xm_U.js (removed) 24.2 kB — 🟢 -24.2 kB 🟢 -6.13 kB 🟢 -5.42 kB
assets/SubscriptionPanelContentWorkspace-Cljze7AO.js (new) — 22.2 kB 🔴 +22.2 kB 🔴 +5.18 kB 🔴 +4.56 kB
assets/SubscriptionPanelContentWorkspace-CmT7XZC4.js (removed) 22.2 kB — 🟢 -22.2 kB 🟢 -5.18 kB 🟢 -4.58 kB
assets/SignInContent-ajesT7-J.js (new) — 20.4 kB 🔴 +20.4 kB 🔴 +5.29 kB 🔴 +4.63 kB
assets/SignInContent-CRBGwqW7.js (removed) 20.4 kB — 🟢 -20.4 kB 🟢 -5.29 kB 🟢 -4.62 kB
assets/CurrentUserPopoverWorkspace-CIMIFpzR.js (removed) 20.4 kB — 🟢 -20.4 kB 🟢 -4.83 kB 🟢 -4.33 kB
assets/CurrentUserPopoverWorkspace-DZUkOuRA.js (new) — 20.4 kB 🔴 +20.4 kB 🔴 +4.83 kB 🔴 +4.33 kB
assets/WidgetInputNumber-CPysmuaV.js (new) — 19.1 kB 🔴 +19.1 kB 🔴 +4.84 kB 🔴 +4.31 kB
assets/WidgetInputNumber-CYSd20Y9.js (removed) 19.1 kB — 🟢 -19.1 kB 🟢 -4.84 kB 🟢 -4.31 kB
assets/Load3D-Cjm92wji.js (removed) 18.2 kB — 🟢 -18.2 kB 🟢 -4.34 kB 🟢 -3.81 kB
assets/Load3D-DzISURAp.js (new) — 18.2 kB 🔴 +18.2 kB 🔴 +4.34 kB 🔴 +3.79 kB
assets/WidgetRecordAudio-Byf-sfLl.js (removed) 17.2 kB — 🟢 -17.2 kB 🟢 -4.92 kB 🟢 -4.41 kB
assets/WidgetRecordAudio-Df-LeSpX.js (new) — 17.2 kB 🔴 +17.2 kB 🔴 +4.92 kB 🔴 +4.41 kB
assets/WidgetRange-BGHPO9Br.js (new) — 16.9 kB 🔴 +16.9 kB 🔴 +4.53 kB 🔴 +4.05 kB
assets/WidgetRange-CdZ1oIfn.js (removed) 16.9 kB — 🟢 -16.9 kB 🟢 -4.53 kB 🟢 -4.05 kB
assets/load3d-DEjSHjKD.js (removed) 15.1 kB — 🟢 -15.1 kB 🟢 -4.33 kB 🟢 -3.75 kB
assets/load3d-Wx6L8eTy.js (new) — 15.1 kB 🔴 +15.1 kB 🔴 +4.33 kB 🔴 +3.75 kB
assets/WaveAudioPlayer-DCFwW8Hw.js (removed) 13.4 kB — 🟢 -13.4 kB 🟢 -3.69 kB 🟢 -3.23 kB
assets/WaveAudioPlayer-DVur0tY7.js (new) — 13.4 kB 🔴 +13.4 kB 🔴 +3.69 kB 🔴 +3.23 kB
assets/WidgetCurve-6zZzQMZd.js (new) — 12 kB 🔴 +12 kB 🔴 +3.86 kB 🔴 +3.5 kB
assets/WidgetCurve-Bs11wy4T.js (removed) 12 kB — 🟢 -12 kB 🟢 -3.86 kB 🟢 -3.5 kB
assets/TeamWorkspacesDialogContent-BlCxin3p.js (new) — 11.1 kB 🔴 +11.1 kB 🔴 +3.33 kB 🔴 +2.97 kB
assets/TeamWorkspacesDialogContent-DxGDheLD.js (removed) 11.1 kB — 🟢 -11.1 kB 🟢 -3.33 kB 🟢 -2.97 kB
assets/nodeTemplates-D4QfHt0q.js (new) — 9.64 kB 🔴 +9.64 kB 🔴 +3.39 kB 🔴 +2.99 kB
assets/nodeTemplates-DncjiNG_.js (removed) 9.64 kB — 🟢 -9.64 kB 🟢 -3.39 kB 🟢 -2.98 kB
assets/NightlySurveyController-C6f_q6ch.js (removed) 8.82 kB — 🟢 -8.82 kB 🟢 -3.06 kB 🟢 -2.72 kB
assets/NightlySurveyController-D9dJdv3G.js (new) — 8.82 kB 🔴 +8.82 kB 🔴 +3.06 kB 🔴 +2.71 kB
assets/Load3DConfiguration-CJm8lj4x.js (new) — 7.82 kB 🔴 +7.82 kB 🔴 +2.31 kB 🔴 +2.02 kB
assets/Load3DConfiguration-Dyb1HMDO.js (removed) 7.82 kB — 🟢 -7.82 kB 🟢 -2.31 kB 🟢 -2.02 kB
assets/InviteMemberDialogContent-CavHyZZG.js (new) — 7.77 kB 🔴 +7.77 kB 🔴 +2.45 kB 🔴 +2.15 kB
assets/InviteMemberDialogContent-W7FzhhYH.js (removed) 7.77 kB — 🟢 -7.77 kB 🟢 -2.45 kB 🟢 -2.14 kB
assets/onboardingCloudRoutes-BIy3XtwJ.js (removed) 6.58 kB — 🟢 -6.58 kB 🟢 -2.05 kB 🟢 -1.77 kB
assets/onboardingCloudRoutes-Dw7S9sRG.js (new) — 6.58 kB 🔴 +6.58 kB 🔴 +2.06 kB 🔴 +1.76 kB
assets/WidgetWithControl-C-fATzHC.js (removed) 6.02 kB — 🟢 -6.02 kB 🟢 -2.4 kB 🟢 -2.13 kB
assets/WidgetWithControl-FSOW2Pl6.js (new) — 6.02 kB 🔴 +6.02 kB 🔴 +2.4 kB 🔴 +2.14 kB
assets/CreateWorkspaceDialogContent-lah6kuCg.js (new) — 5.95 kB 🔴 +5.95 kB 🔴 +2.15 kB 🔴 +1.87 kB
assets/CreateWorkspaceDialogContent-omk0IbW3.js (removed) 5.95 kB — 🟢 -5.95 kB 🟢 -2.15 kB 🟢 -1.88 kB
assets/FreeTierDialogContent-CqMT75U_.js (new) — 5.82 kB 🔴 +5.82 kB 🔴 +2.04 kB 🔴 +1.8 kB
assets/FreeTierDialogContent-K5Rf6nHC.js (removed) 5.82 kB — 🟢 -5.82 kB 🟢 -2.04 kB 🟢 -1.81 kB
assets/EditWorkspaceDialogContent-DxtIP7bR.js (removed) 5.75 kB — 🟢 -5.75 kB 🟢 -2.11 kB 🟢 -1.85 kB
assets/EditWorkspaceDialogContent-wtmxgh0T.js (new) — 5.75 kB 🔴 +5.75 kB 🔴 +2.11 kB 🔴 +1.85 kB
assets/WidgetTextarea-DCHC1Twm.js (new) — 5.59 kB 🔴 +5.59 kB 🔴 +2.19 kB 🔴 +1.94 kB
assets/WidgetTextarea-k810wBDc.js (removed) 5.59 kB — 🟢 -5.59 kB 🟢 -2.2 kB 🟢 -1.94 kB
assets/Preview3d-9VlKJNbc.js (removed) 5.39 kB — 🟢 -5.39 kB 🟢 -1.81 kB 🟢 -1.57 kB
assets/Preview3d-BpDIpTSX.js (new) — 5.39 kB 🔴 +5.39 kB 🔴 +1.8 kB 🔴 +1.57 kB
assets/ValueControlPopover-BQK2r9ms.js (removed) 5.33 kB — 🟢 -5.33 kB 🟢 -1.93 kB 🟢 -1.72 kB
assets/ValueControlPopover-IpUYCGGm.js (new) — 5.33 kB 🔴 +5.33 kB 🔴 +1.92 kB 🔴 +1.72 kB
assets/CancelSubscriptionDialogContent-DjkdZPFO.js (new) — 5.29 kB 🔴 +5.29 kB 🔴 +1.97 kB 🔴 +1.72 kB
assets/CancelSubscriptionDialogContent-UccuNksb.js (removed) 5.29 kB — 🟢 -5.29 kB 🟢 -1.97 kB 🟢 -1.73 kB
assets/DeleteWorkspaceDialogContent-BRoko0K_.js (removed) 4.65 kB — 🟢 -4.65 kB 🟢 -1.79 kB 🟢 -1.55 kB
assets/DeleteWorkspaceDialogContent-DO4MEcLe.js (new) — 4.65 kB 🔴 +4.65 kB 🔴 +1.78 kB 🔴 +1.55 kB
assets/LeaveWorkspaceDialogContent-BSlUf4r3.js (removed) 4.48 kB — 🟢 -4.48 kB 🟢 -1.73 kB 🟢 -1.51 kB
assets/LeaveWorkspaceDialogContent-BXJ8lllK.js (new) — 4.48 kB 🔴 +4.48 kB 🔴 +1.73 kB 🔴 +1.51 kB
assets/RemoveMemberDialogContent-CsuNfueU.js (new) — 4.46 kB 🔴 +4.46 kB 🔴 +1.68 kB 🔴 +1.48 kB
assets/RemoveMemberDialogContent-DpiICX61.js (removed) 4.46 kB — 🟢 -4.46 kB 🟢 -1.69 kB 🟢 -1.48 kB
assets/tierBenefits-BOC7iRyn.js (removed) 4.45 kB — 🟢 -4.45 kB 🟢 -1.57 kB 🟢 -1.36 kB
assets/tierBenefits-DN1Np8lV.js (new) — 4.45 kB 🔴 +4.45 kB 🔴 +1.58 kB 🔴 +1.36 kB
assets/RevokeInviteDialogContent-CNH-TIsI.js (new) — 4.37 kB 🔴 +4.37 kB 🔴 +1.69 kB 🔴 +1.49 kB
assets/RevokeInviteDialogContent-DFoUuak6.js (removed) 4.37 kB — 🟢 -4.37 kB 🟢 -1.7 kB 🟢 -1.49 kB
assets/InviteMemberUpsellDialogContent-BUX39o77.js (removed) 4.27 kB — 🟢 -4.27 kB 🟢 -1.56 kB 🟢 -1.37 kB
assets/InviteMemberUpsellDialogContent-CBBAzt2z.js (new) — 4.27 kB 🔴 +4.27 kB 🔴 +1.56 kB 🔴 +1.37 kB
assets/cloudSessionCookie-BEHQ4wSM.js (removed) 4.12 kB — 🟢 -4.12 kB 🟢 -1.48 kB 🟢 -1.29 kB
assets/cloudSessionCookie-C6MkPiju.js (new) — 4.12 kB 🔴 +4.12 kB 🔴 +1.48 kB 🔴 +1.3 kB
assets/saveMesh-N5ynd7Kl.js (removed) 3.96 kB — 🟢 -3.96 kB 🟢 -1.7 kB 🟢 -1.5 kB
assets/saveMesh-pJZ588cH.js (new) — 3.96 kB 🔴 +3.96 kB 🔴 +1.7 kB 🔴 +1.5 kB
assets/Media3DTop-BNOfSn_O.js (removed) 3.85 kB — 🟢 -3.85 kB 🟢 -1.62 kB 🟢 -1.43 kB
assets/Media3DTop-D992WxXE.js (new) — 3.85 kB 🔴 +3.85 kB 🔴 +1.62 kB 🔴 +1.44 kB
assets/GlobalToast-B-h4fBwl.js (removed) 3.05 kB — 🟢 -3.05 kB 🟢 -1.26 kB 🟢 -1.11 kB
assets/GlobalToast-BbzlUggQ.js (new) — 3.05 kB 🔴 +3.05 kB 🔴 +1.26 kB 🔴 +1.07 kB
assets/SubscribeToRun-C3esOX9n.js (new) — 2.13 kB 🔴 +2.13 kB 🔴 +981 B 🔴 +878 B
assets/SubscribeToRun-DUePqpQ-.js (removed) 2.13 kB — 🟢 -2.13 kB 🟢 -981 B 🟢 -884 B
assets/MediaAudioTop-BS1Lj7tq.js (new) — 2.02 kB 🔴 +2.02 kB 🔴 +976 B 🔴 +840 B
assets/MediaAudioTop-Bz4EyUdm.js (removed) 2.02 kB — 🟢 -2.02 kB 🟢 -977 B 🟢 -845 B
assets/CloudRunButtonWrapper-9pebOo1H.js (new) — 1.99 kB 🔴 +1.99 kB 🔴 +905 B 🔴 +811 B
assets/CloudRunButtonWrapper-BHDeikSz.js (removed) 1.99 kB — 🟢 -1.99 kB 🟢 -909 B 🟢 -806 B
assets/graphHasMissingNodes-xq4MgyJY.js (new) — 1.83 kB 🔴 +1.83 kB 🔴 +862 B 🔴 +757 B
assets/graphHasMissingNodes-Zen8kiNt.js (removed) 1.83 kB — 🟢 -1.83 kB 🟢 -861 B 🟢 -758 B
assets/cloudBadges-BKaG3Lts.js (removed) 1.77 kB — 🟢 -1.77 kB 🟢 -891 B 🟢 -785 B
assets/cloudBadges-DLB_fHrO.js (new) — 1.77 kB 🔴 +1.77 kB 🔴 +890 B 🔴 +775 B
assets/cloudSubscription-DsCsTroc.js (new) — 1.68 kB 🔴 +1.68 kB 🔴 +811 B 🔴 +702 B
assets/cloudSubscription-jONsXz8K.js (removed) 1.68 kB — 🟢 -1.68 kB 🟢 -811 B 🟢 -715 B
assets/previousFullPath--TCFYkOP.js (new) — 1.53 kB 🔴 +1.53 kB 🔴 +694 B 🔴 +600 B
assets/previousFullPath-iG_cma8b.js (removed) 1.53 kB — 🟢 -1.53 kB 🟢 -693 B 🟢 -591 B
assets/Load3D-BInzM5ps.js (new) — 1.38 kB 🔴 +1.38 kB 🔴 +628 B 🔴 +555 B
assets/Load3D-D3smG9un.js (removed) 1.38 kB — 🟢 -1.38 kB 🟢 -630 B 🟢 -558 B
assets/nightlyBadges-CTmpmQ5e.js (new) — 1.29 kB 🔴 +1.29 kB 🔴 +654 B 🔴 +579 B
assets/nightlyBadges-Cx1BYLpA.js (removed) 1.29 kB — 🟢 -1.29 kB 🟢 -656 B 🟢 -577 B
assets/Load3dViewerContent-Bwwp-O_f.js (new) — 1.26 kB 🔴 +1.26 kB 🔴 +578 B 🔴 +506 B
assets/Load3dViewerContent-Cgj65CR1.js (removed) 1.26 kB — 🟢 -1.26 kB 🟢 -578 B 🟢 -510 B
assets/SubscriptionPanelContentWorkspace-LHy_dUAW.js (new) — 1.15 kB 🔴 +1.15 kB 🔴 +533 B 🔴 +467 B
assets/SubscriptionPanelContentWorkspace-Pnn1xQjE.js (removed) 1.15 kB — 🟢 -1.15 kB 🟢 -534 B 🟢 -469 B
assets/WidgetLegacy-D4xbEL4X.js (removed) 978 B — 🟢 -978 B 🟢 -478 B 🟢 -426 B
assets/WidgetLegacy-Dbp_p8FI.js (new) — 978 B 🔴 +978 B 🔴 +477 B 🔴 +422 B
assets/changeTracker-C90ChSIP.js (new) — 953 B 🔴 +953 B 🔴 +466 B 🔴 +409 B
assets/changeTracker-sEbMnePF.js (removed) 953 B — 🟢 -953 B 🟢 -468 B 🟢 -412 B

Status: 57 added / 57 removed / 78 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.7 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 48.6 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.9 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.3 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.5 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 48.6 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.1 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.4 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.0 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 160.7 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 164.2 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 48.2 MB heap

⚠️ 7 regressions detected

Metric Baseline PR (median) Δ Sig
canvas-mouse-sweep: task duration 958ms 1024ms +7% ⚠️ z=2.7
canvas-zoom-sweep: layout duration 1ms 1ms +19% ⚠️ z=3.0
large-graph-idle: task duration 559ms 707ms +26% ⚠️ z=3.0
large-graph-idle: script duration 102ms 129ms +27% ⚠️ z=2.5
large-graph-pan: task duration 1077ms 1264ms +17% ⚠️ z=4.2
minimap-idle: task duration 558ms 683ms +22% ⚠️ z=3.3
workflow-execution: event listeners 37 71 +92% ⚠️ z=4.4
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms -0% z=-0.1
canvas-idle: p95 frame time 17ms 17ms +1% —
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 8ms 9ms +8% z=-2.5
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 8 8 +0% z=-5.6
canvas-idle: task duration 367ms 455ms +24% z=1.9
canvas-idle: script duration 20ms 27ms +39% z=0.9
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 60.8 MB 61.7 MB +1% —
canvas-idle: DOM nodes 16 16 +0% z=-5.2
canvas-idle: event listeners 6 6 +0% z=-1.2
canvas-mouse-sweep: avg frame time 17ms 17ms +0% z=-0.4
canvas-mouse-sweep: p95 frame time 17ms 17ms +0% —
canvas-mouse-sweep: layout duration 3ms 4ms +12% z=1.0
canvas-mouse-sweep: style recalc duration 44ms 46ms +4% z=1.2
canvas-mouse-sweep: layout count 12 12 +0% —
canvas-mouse-sweep: style recalc count 81 82 +1% z=1.4
canvas-mouse-sweep: task duration 958ms 1024ms +7% ⚠️ z=2.7
canvas-mouse-sweep: script duration 131ms 143ms +9% z=1.1
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 57.6 MB 57.0 MB -1% —
canvas-mouse-sweep: DOM nodes 64 63 -2% z=0.3
canvas-mouse-sweep: event listeners 6 6 +0% z=-0.6
canvas-zoom-sweep: avg frame time 17ms 17ms +0% z=0.5
canvas-zoom-sweep: p95 frame time 17ms 17ms +1% —
canvas-zoom-sweep: layout duration 1ms 1ms +19% ⚠️ z=3.0
canvas-zoom-sweep: style recalc duration 19ms 19ms +2% z=-0.1
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 30 32 +7% z=1.6
canvas-zoom-sweep: task duration 317ms 351ms +11% z=1.0
canvas-zoom-sweep: script duration 22ms 32ms +44% z=1.6
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 65.6 MB 65.3 MB -0% —
canvas-zoom-sweep: DOM nodes 77 78 +1% z=-1.6
canvas-zoom-sweep: event listeners 19 19 +0% z=-0.9
dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.1
dom-widget-clipping: p95 frame time 17ms 17ms +0% —
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 9ms 9ms -1% z=-0.9
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 13 13 +0% z=-0.2
dom-widget-clipping: task duration 345ms 359ms +4% z=-0.4
dom-widget-clipping: script duration 63ms 66ms +4% z=-0.7
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 48.6 MB 48.6 MB -0% —
dom-widget-clipping: DOM nodes 22 21 -5% z=-0.8
dom-widget-clipping: event listeners 2 2 +0% variance too high
large-graph-idle: avg frame time 17ms 17ms +0% z=-0.2
large-graph-idle: p95 frame time 17ms 17ms -1% —
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 10ms 11ms +14% z=-0.8
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 10 10 +0% z=-5.1
large-graph-idle: task duration 559ms 707ms +26% ⚠️ z=3.0
large-graph-idle: script duration 102ms 129ms +27% ⚠️ z=2.5
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 54.5 MB 53.9 MB -1% —
large-graph-idle: DOM nodes -259 -259 +0% z=-313.9
large-graph-idle: event listeners -127 -127 +0% z=-25.1
large-graph-pan: avg frame time 17ms 17ms +0% z=1.3
large-graph-pan: p95 frame time 17ms 17ms +0% —
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 19ms 18ms -4% z=0.9
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 69 68 -1% z=-2.4
large-graph-pan: task duration 1077ms 1264ms +17% ⚠️ z=4.2
large-graph-pan: script duration 397ms 444ms +12% z=1.8
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 70.0 MB 71.3 MB +2% —
large-graph-pan: DOM nodes -262 -266 +2% z=-172.7
large-graph-pan: event listeners -127 -127 +0% z=-159.3
large-graph-zoom: avg frame time 17ms 17ms +0% —
large-graph-zoom: p95 frame time 17ms 17ms -1% —
large-graph-zoom: layout duration 7ms 8ms +8% —
large-graph-zoom: style recalc duration 19ms 21ms +7% —
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 66 66 +0% —
large-graph-zoom: task duration 1326ms 1518ms +15% —
large-graph-zoom: script duration 491ms 562ms +14% —
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 59.6 MB 61.5 MB +3% —
large-graph-zoom: DOM nodes -269 -266 -1% —
large-graph-zoom: event listeners -123 -123 +0% —
minimap-idle: avg frame time 17ms 17ms +0% z=0.1
minimap-idle: p95 frame time 17ms 17ms -1% —
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 9ms 10ms +9% z=0.2
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 9 9 +0% z=-0.8
minimap-idle: task duration 558ms 683ms +22% ⚠️ z=3.3
minimap-idle: script duration 95ms 114ms +20% z=1.6
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 56.6 MB 57.0 MB +1% —
minimap-idle: DOM nodes -264 -263 -0% z=-206.3
minimap-idle: event listeners -127 -127 +0% z=-199.3
subgraph-dom-widget-clipping: avg frame time 17ms 17ms -0% z=-0.9
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms +0% —
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 13ms 11ms -10% z=-1.5
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 47 47 +0% z=-1.6
subgraph-dom-widget-clipping: task duration 362ms 366ms +1% z=-0.7
subgraph-dom-widget-clipping: script duration 123ms 125ms +2% z=-0.5
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 48.8 MB 48.6 MB -0% —
subgraph-dom-widget-clipping: DOM nodes 20 20 +0% z=-1.9
subgraph-dom-widget-clipping: event listeners 8 8 +0% z=-1.4
subgraph-idle: avg frame time 17ms 17ms +0% z=0.4
subgraph-idle: p95 frame time 17ms 17ms -0% —
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 10ms 9ms -10% z=-1.5
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 11 10 -9% z=-1.4
subgraph-idle: task duration 350ms 427ms +22% z=1.8
subgraph-idle: script duration 19ms 25ms +35% z=1.9
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 61.2 MB 61.1 MB -0% —
subgraph-idle: DOM nodes 21 20 -5% z=-1.2
subgraph-idle: event listeners 6 6 +0% variance too high
subgraph-mouse-sweep: avg frame time 17ms 17ms +0% z=0.4
subgraph-mouse-sweep: p95 frame time 17ms 17ms -1% —
subgraph-mouse-sweep: layout duration 5ms 5ms +7% z=0.4
subgraph-mouse-sweep: style recalc duration 47ms 45ms -4% z=0.9
subgraph-mouse-sweep: layout count 16 16 +0% —
subgraph-mouse-sweep: style recalc count 85 76 -11% z=-2.1
subgraph-mouse-sweep: task duration 906ms 739ms -18% z=-0.4
subgraph-mouse-sweep: script duration 102ms 106ms +3% z=0.7
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 53.3 MB 53.4 MB +0% —
subgraph-mouse-sweep: DOM nodes 73 63 -14% z=-1.8
subgraph-mouse-sweep: event listeners 6 6 +0% variance too high
viewport-pan-sweep: avg frame time 17ms 17ms -0% —
viewport-pan-sweep: p95 frame time 17ms 17ms +0% —
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 52ms 56ms +8% —
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 250 251 +0% —
viewport-pan-sweep: task duration 3703ms 4074ms +10% —
viewport-pan-sweep: script duration 1251ms 1347ms +8% —
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 70.5 MB 56.0 MB -21% —
viewport-pan-sweep: DOM nodes -259 -259 +0% —
viewport-pan-sweep: event listeners -111 -111 +0% —
vue-large-graph-idle: avg frame time 17ms 17ms +0% —
vue-large-graph-idle: p95 frame time 17ms 17ms +0% —
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 12255ms 12622ms +3% —
vue-large-graph-idle: script duration 592ms 629ms +6% —
vue-large-graph-idle: TBT 0ms 0ms +0% —
vue-large-graph-idle: heap used 155.9 MB 160.7 MB +3% —
vue-large-graph-idle: DOM nodes -9850 -9850 +0% —
vue-large-graph-idle: event listeners -23959 -23959 +0% —
vue-large-graph-pan: avg frame time 17ms 17ms -0% —
vue-large-graph-pan: p95 frame time 17ms 17ms +0% —
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 17ms 18ms +6% —
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 67 67 +0% —
vue-large-graph-pan: task duration 14473ms 14798ms +2% —
vue-large-graph-pan: script duration 868ms 922ms +6% —
vue-large-graph-pan: TBT 0ms 0ms +0% —
vue-large-graph-pan: heap used 164.5 MB 164.2 MB -0% —
vue-large-graph-pan: DOM nodes -9849 -9850 +0% —
vue-large-graph-pan: event listeners -23954 -23957 +0% —
workflow-execution: avg frame time 17ms 17ms +0% z=-0.4
workflow-execution: p95 frame time 17ms 17ms +0% —
workflow-execution: layout duration 1ms 1ms -1% z=-0.9
workflow-execution: style recalc duration 17ms 24ms +38% z=-0.1
workflow-execution: layout count 4 5 +25% z=0.1
workflow-execution: style recalc count 11 16 +45% z=-0.9
workflow-execution: task duration 93ms 132ms +42% z=0.8
workflow-execution: script duration 19ms 27ms +38% z=-0.8
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 47.0 MB 48.2 MB +3% —
workflow-execution: DOM nodes 151 165 +9% z=0.6
workflow-execution: event listeners 37 71 +92% ⚠️ z=4.4
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 11ms 1ms 8.2%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 11 1 5.0%
canvas-idle: task duration 395ms 31ms 7.9%
canvas-idle: script duration 25ms 2ms 8.8%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: DOM nodes 23 1 5.6%
canvas-idle: event listeners 12 5 40.9%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: layout duration 4ms 0ms 5.4%
canvas-mouse-sweep: style recalc duration 43ms 3ms 7.4%
canvas-mouse-sweep: layout count 12 0 0.0%
canvas-mouse-sweep: style recalc count 79 2 3.0%
canvas-mouse-sweep: task duration 865ms 58ms 6.7%
canvas-mouse-sweep: script duration 136ms 6ms 4.8%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: DOM nodes 62 3 4.2%
canvas-mouse-sweep: event listeners 8 4 49.4%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: layout duration 1ms 0ms 7.0%
canvas-zoom-sweep: style recalc duration 19ms 2ms 8.0%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 0 1.5%
canvas-zoom-sweep: task duration 327ms 23ms 7.1%
canvas-zoom-sweep: script duration 27ms 3ms 11.1%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: DOM nodes 79 1 1.0%
canvas-zoom-sweep: event listeners 24 5 21.8%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 10ms 1ms 8.0%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 13 0 3.8%
dom-widget-clipping: task duration 365ms 16ms 4.5%
dom-widget-clipping: script duration 68ms 3ms 4.8%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: DOM nodes 22 1 6.4%
dom-widget-clipping: event listeners 8 6 81.2%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 12ms 1ms 8.6%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 12 0 2.7%
large-graph-idle: task duration 542ms 54ms 10.0%
large-graph-idle: script duration 102ms 11ms 10.3%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: DOM nodes 25 1 3.7%
large-graph-idle: event listeners 26 6 23.2%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 17ms 1ms 4.6%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 70 1 0.9%
large-graph-pan: task duration 1082ms 43ms 4.0%
large-graph-pan: script duration 408ms 20ms 4.8%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: DOM nodes 19 2 8.7%
large-graph-pan: event listeners 5 1 16.8%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 10ms 1ms 8.6%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 10 1 7.1%
minimap-idle: task duration 527ms 47ms 9.0%
minimap-idle: script duration 98ms 10ms 10.1%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: DOM nodes 19 1 7.1%
minimap-idle: event listeners 5 1 14.4%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 13ms 1ms 7.4%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 48 1 1.2%
subgraph-dom-widget-clipping: task duration 378ms 18ms 4.9%
subgraph-dom-widget-clipping: script duration 128ms 6ms 4.9%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: DOM nodes 22 1 5.0%
subgraph-dom-widget-clipping: event listeners 16 6 36.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 10ms 1ms 7.5%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 11 1 6.0%
subgraph-idle: task duration 370ms 31ms 8.5%
subgraph-idle: script duration 20ms 3ms 13.2%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: DOM nodes 22 1 6.9%
subgraph-idle: event listeners 10 7 64.5%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: layout duration 5ms 0ms 6.8%
subgraph-mouse-sweep: style recalc duration 42ms 3ms 7.8%
subgraph-mouse-sweep: layout count 16 0 0.0%
subgraph-mouse-sweep: style recalc count 80 2 2.4%
subgraph-mouse-sweep: task duration 766ms 69ms 9.0%
subgraph-mouse-sweep: script duration 101ms 7ms 6.5%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: DOM nodes 67 2 3.3%
subgraph-mouse-sweep: event listeners 8 4 52.6%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: layout duration 2ms 0ms 9.4%
workflow-execution: style recalc duration 24ms 2ms 9.1%
workflow-execution: layout count 5 1 11.0%
workflow-execution: style recalc count 18 2 11.5%
workflow-execution: task duration 123ms 11ms 8.8%
workflow-execution: script duration 29ms 3ms 10.2%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: DOM nodes 161 7 4.4%
workflow-execution: event listeners 52 4 8.4%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▆▃▆▁▆▃▆█▆▆▄▃▃▄▃ ➡️ 17ms
canvas-idle: p95 frame time ➡️ NaNms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▇▇▆▆▃█▄▃▄▃▇▄▁▆▇ ➡️ 11ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count █▃▅▂▅▆▃▁▂▁▂▅▆▅▆ ➡️ 12
canvas-idle: task duration ▃▃▃▆▂▃▃▅▆▂█▃▁▃▃ ➡️ 391ms
canvas-idle: script duration ▄▃▅▇▂▅▃▆▇▅█▄▁▅▆ ➡️ 27ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ➡️ NaN MB
canvas-idle: DOM nodes █▇▆▅▃▇▃▁▂▂▅▆▆▆▇ ➡️ 24
canvas-idle: event listeners ▅█▅▄▁▅▁▁▁▄▅▅▁▅▄ 📉 11
canvas-mouse-sweep: avg frame time ▆█▆▃▁▃▁▆▆▁▃▆▆▃▃ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ➡️ NaNms
canvas-mouse-sweep: layout duration ▁▃▂▄▁▂▁▃▆▂█▇▆▄▃ ➡️ 4ms
canvas-mouse-sweep: style recalc duration ▄▄▂▄▁▂▃▃▅▄█▆▂▄▄ ➡️ 43ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: style recalc count █▅▄▃▂▂▁▄▄▅▆▅▂▇▄ ➡️ 79
canvas-mouse-sweep: task duration █▆▄▂▂▃▂▄▄▅█▆▁▆▄ ➡️ 868ms
canvas-mouse-sweep: script duration ▄▅▄▆▄▆▆▆▅▅█▆▁▅▆ ➡️ 139ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ➡️ NaN MB
canvas-mouse-sweep: DOM nodes █▅▃▃▁▂▂▃▂▄▆▅▃▅▅ ➡️ 64
canvas-mouse-sweep: event listeners █▁▁▁▁▁▇▁▁▁██▇▁█ 📈 13
canvas-zoom-sweep: avg frame time ▅▅█▄▅▁▁▁▅▁▁▅▄▅▁ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ➡️ NaNms
canvas-zoom-sweep: layout duration ▆▅▅▄▁▁█▅▃▅▇▆▁▂▆ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▆▅▄▆▅▃█▆▇▅▇▄▁▃▅ ➡️ 20ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▁▁▃▄▆▃▆█▄▄▆▁▆▁▆ ➡️ 32
canvas-zoom-sweep: task duration ▄▂▁▇▂▂▄▅▆▃█▄▁▁▅ ➡️ 338ms
canvas-zoom-sweep: script duration ▃▃▂▇▂▂▅▇▆▅█▄▁▂▆ ➡️ 30ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ➡️ NaN MB
canvas-zoom-sweep: DOM nodes ▄▃▁▅█▁▃▆▄▅▅▃▃▄▃ ➡️ 79
canvas-zoom-sweep: event listeners ▁▁▂▅█▂▁▅▁▅▅▄▁▅▁ ➡️ 19
dom-widget-clipping: avg frame time ▂▄▅▅▂▄█▇▅▇▇▅▅▁▇ ➡️ 17ms
dom-widget-clipping: p95 frame time ➡️ NaNms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▆▆▂▆▄▃██▄▁▆▇▆▃▅ ➡️ 10ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▇█▅█▅▄█▇▇▁▇▄▇▂▅ ➡️ 13
dom-widget-clipping: task duration ▃▃▁▅▄▃▅▆▅▂▇█▁▅▅ ➡️ 371ms
dom-widget-clipping: script duration ▅▄▄▆▆▅▇▇▆▃█▇▁▇▇ ➡️ 71ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ➡️ NaN MB
dom-widget-clipping: DOM nodes ▇▇▄▇▅▄█▇▅▁▅▄▇▃▄ ➡️ 21
dom-widget-clipping: event listeners ▅▅▅▅▁▅██▁▁▁▁█▁▁ 📉 2
large-graph-idle: avg frame time ▅▅▅▅▅▂▁▂▄▅▄▂▂▅█ ➡️ 17ms
large-graph-idle: p95 frame time ➡️ NaNms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▅▅▅▆▄▅▃▄▅▅▆█▁▄▆ ➡️ 13ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count █▆█▃▃▁▃▆▃▆▆▃▆██ ➡️ 12
large-graph-idle: task duration ▂▃▂▆▂▃▃▇▅▃██▁▂▅ ➡️ 569ms
large-graph-idle: script duration ▄▅▄▆▄▅▅▇▆▅█▆▁▃▆ ➡️ 110ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ➡️ NaN MB
large-graph-idle: DOM nodes ▆█▅▂▅▃▁▂▃▅▅▆▂▆▅ ➡️ 25
large-graph-idle: event listeners ███▇██▄▁▄▇▇█▂█▇ ➡️ 29
large-graph-pan: avg frame time ▆▃▃▆█▃▁█▆▆▆▆█▁▆ ➡️ 17ms
large-graph-pan: p95 frame time ➡️ NaNms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▂▄▄▁▅▂▂▁▄▄█▃▁▂ ➡️ 17ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▆▃█▂▃▂▂▂▁▇▅▃█▆▃ ➡️ 69
large-graph-pan: task duration ▄▃▄▆▄▄▄▆▄▄█▆▁▂▅ ➡️ 1100ms
large-graph-pan: script duration ▅▄▅▆▆▅▄▆▄▅█▄▁▄▅ ➡️ 413ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ➡️ NaN MB
large-graph-pan: DOM nodes ▅▃▆▂▄▁▃▁▁▅▁▂█▅▂ ➡️ 18
large-graph-pan: event listeners █▆█▁▁▆▁▁▃▆▁▃██▃ ➡️ 5
minimap-idle: avg frame time ▃▆▆▃█▁█▆▆▃▃▆█▆█ ➡️ 17ms
minimap-idle: p95 frame time ➡️ NaNms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▄█▁█▅▅█▅▅▃▅▁▁▄▆ ➡️ 10ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 9
minimap-idle: task duration ▃▄▁▅▁▃▄▅▇▃█▅▁▁▅ ➡️ 547ms
minimap-idle: script duration ▄▆▃▇▃▅▆▆▇▅█▅▁▃▆ ➡️ 106ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ➡️ NaN MB
minimap-idle: DOM nodes ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 19
minimap-idle: event listeners ▃▃▆▁▁▁▃▁▁▆▁▃█▆▁ ➡️ 4
subgraph-dom-widget-clipping: avg frame time ▅▄▄▄▄▄█▄▄▄▃▁▆▃▃ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ➡️ NaNms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▂▄▃▅▅▃▂▅▇▃▄█▁▄▆ ➡️ 14ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▇█▆▃▆▃▁▆█▇▃▆▇█▅ ➡️ 48
subgraph-dom-widget-clipping: task duration ▂▃▃▆▅▅▂▅█▂▆█▁▂▇ ➡️ 398ms
subgraph-dom-widget-clipping: script duration ▃▃▃▄▅▅▂▄█▂▅▇▁▂▅ ➡️ 131ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ➡️ NaN MB
subgraph-dom-widget-clipping: DOM nodes ▅▇▅▂▅▂▁▅▅▅▁▇▅█▄ ➡️ 22
subgraph-dom-widget-clipping: event listeners ▅▅▅▂▅▁▅██▁▁█▅█▅ 📈 16
subgraph-idle: avg frame time ▆▆█▁▆▃▆▆▆▃▆▁▃▆█ ➡️ 17ms
subgraph-idle: p95 frame time ➡️ NaNms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▁▇▃▆▂▄▂▃▃▆▆▄▃▇█ ➡️ 12ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▃▆▃▃▂▅▁▂▁▆▃▃██▇ ➡️ 12
subgraph-idle: task duration ▁▃▁▇▁▁▃▆▅▂█▅▁▁▄ ➡️ 378ms
subgraph-idle: script duration ▁▃▂▇▁▂▃▇▆▂█▅▂▁▅ ➡️ 22ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ➡️ NaN MB
subgraph-idle: DOM nodes ▃▅▃▂▁▄▁▂▁▅▃▂▇█▇ ➡️ 24
subgraph-idle: event listeners ▁▅▁▁▁▁▁▁▁▅▄▁███ 📈 21
subgraph-mouse-sweep: avg frame time ▅▄▁▃▃▄▆▄▆▃▃█▁▃▃ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ➡️ NaNms
subgraph-mouse-sweep: layout duration ▁▄▄▄▃▃▅▅▅▂█▇▂▃▆ ➡️ 5ms
subgraph-mouse-sweep: style recalc duration ▃▂▄▅▂▃▄▅█▃█▆▁▂▅ ➡️ 43ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: style recalc count ▅▂▅▅▁▄▃▅█▅▆▄▂▄▅ ➡️ 81
subgraph-mouse-sweep: task duration ▃▂▄▅▂▄▄▅▇▄█▆▁▃▅ ➡️ 785ms
subgraph-mouse-sweep: script duration ▄▅▄▇▅▅▆▇▆▅██▁▄▆ ➡️ 105ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ➡️ NaN MB
subgraph-mouse-sweep: DOM nodes ▅▁▄▅▁▄▃▃█▅▅▄▂▅▃ ➡️ 66
subgraph-mouse-sweep: event listeners ▇▁▂▇▁▂▂▂█▇▂▂▇▇▂ 📈 5
workflow-execution: avg frame time ▆▆▆▄▆▆▃▄▁▄█▆▅▄▆ ➡️ 17ms
workflow-execution: p95 frame time ➡️ NaNms
workflow-execution: layout duration ▁▆▁▃▂▄▃▂▃▃▅█▄▂▅ ➡️ 2ms
workflow-execution: style recalc duration ▃▇▅▇▁▅▆▇█▁██▂▄▆ ➡️ 25ms
workflow-execution: layout count ▁█▂▃▂▃▃▁▃▃▄▃▂▃▂ ➡️ 5
workflow-execution: style recalc count ▃█▅▇▁▄▅▆▅▅▅▅▄▄▂ ➡️ 15
workflow-execution: task duration ▂▅▄▅▁▄▆▆▆▁▇█▁▃▃ ➡️ 120ms
workflow-execution: script duration ▄▃▄▄▃▅▄▅▆▂▇█▁▃▄ ➡️ 29ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ➡️ NaN MB
workflow-execution: DOM nodes ▂█▃▆▁▄▃▅▃█▃▃▄▃▁ ➡️ 152
workflow-execution: event listeners ▅███▁▅███▁██▅█▅ ➡️ 49
Raw data
{
  "timestamp": "2026-04-25T08:31:06.456Z",
  "gitSha": "e4e003192513e8c5992e92833ba88336d4788816",
  "branch": "glary/restore-subgraph-serialization-tests",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2056.1200000000213,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 8.444,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 464.734,
      "heapDeltaBytes": 20321084,
      "heapUsedBytes": 64332264,
      "domNodes": 14,
      "jsHeapTotalBytes": 22544384,
      "scriptDurationMs": 27.178,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2018.6939999999822,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.614,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 455.11600000000004,
      "heapDeltaBytes": 21017108,
      "heapUsedBytes": 65034956,
      "domNodes": 16,
      "jsHeapTotalBytes": 23068672,
      "scriptDurationMs": 27.228999999999996,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2020.403999999985,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 10.078,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 453.71099999999996,
      "heapDeltaBytes": 20984664,
      "heapUsedBytes": 64656648,
      "domNodes": 20,
      "jsHeapTotalBytes": 23068672,
      "scriptDurationMs": 31.998000000000005,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2060.769999999991,
      "styleRecalcs": 82,
      "styleRecalcDurationMs": 47.055,
      "layouts": 12,
      "layoutDurationMs": 3.8,
      "taskDurationMs": 1040.6060000000002,
      "heapDeltaBytes": 15653172,
      "heapUsedBytes": 59805796,
      "domNodes": 63,
      "jsHeapTotalBytes": 24117248,
      "scriptDurationMs": 139.21699999999998,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1880.4979999999887,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 42.114,
      "layouts": 12,
      "layoutDurationMs": 3.851,
      "taskDurationMs": 816.0409999999999,
      "heapDeltaBytes": 15917792,
      "heapUsedBytes": 59619104,
      "domNodes": 58,
      "jsHeapTotalBytes": 23592960,
      "scriptDurationMs": 142.85899999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2023.9480000000185,
      "styleRecalcs": 84,
      "styleRecalcDurationMs": 46.346,
      "layouts": 12,
      "layoutDurationMs": 3.4610000000000003,
      "taskDurationMs": 1024.0749999999998,
      "heapDeltaBytes": 18590880,
      "heapUsedBytes": 68486332,
      "domNodes": 65,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 144.121,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1742.2789999999964,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.712,
      "layouts": 6,
      "layoutDurationMs": 0.6149999999999999,
      "taskDurationMs": 350.933,
      "heapDeltaBytes": 25036164,
      "heapUsedBytes": 68674472,
      "domNodes": 78,
      "jsHeapTotalBytes": 21495808,
      "scriptDurationMs": 31.979999999999993,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1711.7229999998926,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 18.934,
      "layouts": 6,
      "layoutDurationMs": 0.7800000000000001,
      "taskDurationMs": 349.089,
      "heapDeltaBytes": 24747248,
      "heapUsedBytes": 68472304,
      "domNodes": 75,
      "jsHeapTotalBytes": 20971520,
      "scriptDurationMs": 26.60599999999999,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1756.6470000000436,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 21.072,
      "layouts": 6,
      "layoutDurationMs": 0.788,
      "taskDurationMs": 393.34499999999997,
      "heapDeltaBytes": 975948,
      "heapUsedBytes": 52542924,
      "domNodes": 78,
      "jsHeapTotalBytes": 25165824,
      "scriptDurationMs": 37.2,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 544.7489999999675,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 8.884,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 345.831,
      "heapDeltaBytes": 7027824,
      "heapUsedBytes": 50703772,
      "domNodes": 21,
      "jsHeapTotalBytes": 12582912,
      "scriptDurationMs": 65.64399999999999,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 566.867000000002,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 10.577,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 358.699,
      "heapDeltaBytes": 7081992,
      "heapUsedBytes": 50913744,
      "domNodes": 22,
      "jsHeapTotalBytes": 12582912,
      "scriptDurationMs": 63.41000000000001,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 573.517000000038,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 9.170000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 380.67799999999994,
      "heapDeltaBytes": 7364932,
      "heapUsedBytes": 50953664,
      "domNodes": 20,
      "jsHeapTotalBytes": 12845056,
      "scriptDurationMs": 71.75300000000001,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2074.3310000000292,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 11.658999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 730.469,
      "heapDeltaBytes": 3330480,
      "heapUsedBytes": 55538240,
      "domNodes": -257,
      "jsHeapTotalBytes": 16683008,
      "scriptDurationMs": 129.135,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2048.952999999983,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 11.407,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 655.6979999999999,
      "heapDeltaBytes": 3937412,
      "heapUsedBytes": 56894740,
      "domNodes": -259,
      "jsHeapTotalBytes": 16683008,
      "scriptDurationMs": 119.85400000000001,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2037.7469999999676,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.832,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 707.378,
      "heapDeltaBytes": 3953952,
      "heapUsedBytes": 56476276,
      "domNodes": -262,
      "jsHeapTotalBytes": 16158720,
      "scriptDurationMs": 130.806,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2178.1029999999646,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 17.611,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1216.8490000000002,
      "heapDeltaBytes": 19779760,
      "heapUsedBytes": 74791988,
      "domNodes": -266,
      "jsHeapTotalBytes": 17674240,
      "scriptDurationMs": 425.148,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2193.458000000078,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 18.022000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1282.051,
      "heapDeltaBytes": 19967320,
      "heapUsedBytes": 75111404,
      "domNodes": -266,
      "jsHeapTotalBytes": 18460672,
      "scriptDurationMs": 461.328,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2187.864999999988,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 22.153,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1263.9180000000001,
      "heapDeltaBytes": 16967552,
      "heapUsedBytes": 71999700,
      "domNodes": -263,
      "jsHeapTotalBytes": 18984960,
      "scriptDurationMs": 443.577,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3163.409999999999,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 19.576,
      "layouts": 60,
      "layoutDurationMs": 7.723000000000001,
      "taskDurationMs": 1425.261,
      "heapDeltaBytes": 8253476,
      "heapUsedBytes": 64530028,
      "domNodes": -265,
      "jsHeapTotalBytes": 16683008,
      "scriptDurationMs": 518.412,
      "eventListeners": -123,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3250.3040000000283,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 20.901,
      "layouts": 60,
      "layoutDurationMs": 7.885,
      "taskDurationMs": 1518.089,
      "heapDeltaBytes": 9991232,
      "heapUsedBytes": 65591160,
      "domNodes": -267,
      "jsHeapTotalBytes": 15896576,
      "scriptDurationMs": 561.71,
      "eventListeners": -123,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3248.9069999999174,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 20.533999999999995,
      "layouts": 60,
      "layoutDurationMs": 7.880999999999999,
      "taskDurationMs": 1553.1320000000003,
      "heapDeltaBytes": 7316736,
      "heapUsedBytes": 63977152,
      "domNodes": -266,
      "jsHeapTotalBytes": 17575936,
      "scriptDurationMs": 583.434,
      "eventListeners": -123,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2044.36800000002,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.758,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 682.7189999999998,
      "heapDeltaBytes": 975348,
      "heapUsedBytes": 68120072,
      "domNodes": -263,
      "jsHeapTotalBytes": 11116544,
      "scriptDurationMs": 110.867,
      "eventListeners": -129,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2020.723000000089,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 11.443000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 667.988,
      "heapDeltaBytes": 124728,
      "heapUsedBytes": 56105204,
      "domNodes": -261,
      "jsHeapTotalBytes": 15896576,
      "scriptDurationMs": 114.242,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2071.1969999999837,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.387000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 692.882,
      "heapDeltaBytes": 3567196,
      "heapUsedBytes": 59720404,
      "domNodes": -264,
      "jsHeapTotalBytes": 16420864,
      "scriptDurationMs": 119.869,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 571.0480000000189,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.339,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 363.90299999999996,
      "heapDeltaBytes": 7049148,
      "heapUsedBytes": 50988452,
      "domNodes": 20,
      "jsHeapTotalBytes": 12845056,
      "scriptDurationMs": 126.78499999999998,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 564.60299999992,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.657999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 366.15000000000003,
      "heapDeltaBytes": 8186776,
      "heapUsedBytes": 58571900,
      "domNodes": 20,
      "jsHeapTotalBytes": 13893632,
      "scriptDurationMs": 125.332,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 590.7910000000811,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.401999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 378.864,
      "heapDeltaBytes": 6880152,
      "heapUsedBytes": 50245228,
      "domNodes": 15,
      "jsHeapTotalBytes": 12845056,
      "scriptDurationMs": 124.91799999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999998,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2038.9249999999493,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.253,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 426.606,
      "heapDeltaBytes": 21003188,
      "heapUsedBytes": 64846440,
      "domNodes": 20,
      "jsHeapTotalBytes": 23068672,
      "scriptDurationMs": 27.038999999999994,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2016.6000000000395,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 10.283000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 442.96399999999994,
      "heapDeltaBytes": 19923700,
      "heapUsedBytes": 63923852,
      "domNodes": 20,
      "jsHeapTotalBytes": 23068672,
      "scriptDurationMs": 25.316,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2004.099999999994,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.01,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 412.45200000000006,
      "heapDeltaBytes": 19872136,
      "heapUsedBytes": 64041716,
      "domNodes": 18,
      "jsHeapTotalBytes": 23068672,
      "scriptDurationMs": 21.900000000000002,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1718.956999999989,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 45.364000000000004,
      "layouts": 16,
      "layoutDurationMs": 5.116,
      "taskDurationMs": 738.94,
      "heapDeltaBytes": 12231996,
      "heapUsedBytes": 56204016,
      "domNodes": 63,
      "jsHeapTotalBytes": 23068672,
      "scriptDurationMs": 105.53800000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1676.2560000000803,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 38.934,
      "layouts": 16,
      "layoutDurationMs": 4.8149999999999995,
      "taskDurationMs": 696.861,
      "heapDeltaBytes": 12278964,
      "heapUsedBytes": 56035124,
      "domNodes": 61,
      "jsHeapTotalBytes": 23068672,
      "scriptDurationMs": 101.23800000000003,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1974.646000000007,
      "styleRecalcs": 84,
      "styleRecalcDurationMs": 48.69099999999999,
      "layouts": 16,
      "layoutDurationMs": 4.62,
      "taskDurationMs": 964.061,
      "heapDeltaBytes": 11903044,
      "heapUsedBytes": 55872232,
      "domNodes": 72,
      "jsHeapTotalBytes": 22282240,
      "scriptDurationMs": 112.815,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8195.375000000013,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 53.297999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4012.582999999999,
      "heapDeltaBytes": 6261568,
      "heapUsedBytes": 58706532,
      "domNodes": -260,
      "jsHeapTotalBytes": 19771392,
      "scriptDurationMs": 1333.995,
      "eventListeners": -109,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8243.348999999966,
      "styleRecalcs": 252,
      "styleRecalcDurationMs": 55.864,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4130.013,
      "heapDeltaBytes": 24921188,
      "heapUsedBytes": 77078340,
      "domNodes": -259,
      "jsHeapTotalBytes": 19771392,
      "scriptDurationMs": 1349.3950000000002,
      "eventListeners": -111,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8215.88399999996,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 58.666000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4074.2659999999996,
      "heapDeltaBytes": -231616,
      "heapUsedBytes": 51853680,
      "domNodes": -258,
      "jsHeapTotalBytes": 19304448,
      "scriptDurationMs": 1347.2630000000001,
      "eventListeners": -111,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12604.758000000003,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12591.192,
      "heapDeltaBytes": -28930160,
      "heapUsedBytes": 168815112,
      "domNodes": -9850,
      "jsHeapTotalBytes": 23916544,
      "scriptDurationMs": 609.211,
      "eventListeners": -23958,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333237,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12637.701000000106,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12621.631000000001,
      "heapDeltaBytes": -47130756,
      "heapUsedBytes": 168461324,
      "domNodes": -9848,
      "jsHeapTotalBytes": 26275840,
      "scriptDurationMs": 628.8199999999999,
      "eventListeners": -23959,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12916.52499999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12897.977,
      "heapDeltaBytes": -30586740,
      "heapUsedBytes": 167685656,
      "domNodes": -9850,
      "jsHeapTotalBytes": 23130112,
      "scriptDurationMs": 646.797,
      "eventListeners": -23959,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333237,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14958.844999999998,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 18.496000000000013,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14932.811999999998,
      "heapDeltaBytes": -63461640,
      "heapUsedBytes": 162698304,
      "domNodes": -9850,
      "jsHeapTotalBytes": -16539648,
      "scriptDurationMs": 913.5649999999999,
      "eventListeners": -23955,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14739.536000000044,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 17.620000000000026,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14708.742999999999,
      "heapDeltaBytes": -41925708,
      "heapUsedBytes": 172133980,
      "domNodes": -9850,
      "jsHeapTotalBytes": -14704640,
      "scriptDurationMs": 937.273,
      "eventListeners": -23985,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14824.659999999994,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 18.394999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14797.565999999999,
      "heapDeltaBytes": -35688172,
      "heapUsedBytes": 185917056,
      "domNodes": -9852,
      "jsHeapTotalBytes": 21995520,
      "scriptDurationMs": 922.2949999999998,
      "eventListeners": -23957,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333237,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 466.8750000000159,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 23.945,
      "layouts": 5,
      "layoutDurationMs": 1.8279999999999998,
      "taskDurationMs": 131.87099999999998,
      "heapDeltaBytes": 5187552,
      "heapUsedBytes": 50541556,
      "domNodes": 165,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 26.732999999999997,
      "eventListeners": 71,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 469.51400000000376,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 25.48,
      "layouts": 5,
      "layoutDurationMs": 1.418,
      "taskDurationMs": 138.35700000000003,
      "heapDeltaBytes": 5102160,
      "heapUsedBytes": 50551016,
      "domNodes": 154,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 32.478,
      "eventListeners": 71,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 476.7229999999927,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 23.928000000000004,
      "layouts": 4,
      "layoutDurationMs": 1.1850000000000003,
      "taskDurationMs": 124.36299999999997,
      "heapDeltaBytes": 5043100,
      "heapUsedBytes": 50354672,
      "domNodes": 175,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 23.245999999999995,
      "eventListeners": 71,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
browser_tests/tests/subgraph/subgraphSerialization.spec.ts (1)

104-121: ⚠️ Potential issue | 🟠 Major

Don't re-load the fixture in the "full reload boot path" cases.

After page.reload(), both tests call workflow.loadWorkflow(DUPLICATE_IDS_WORKFLOW) again, which replaces whatever the app restored during boot. That means a regression in persisted reload hydration/localStorage recovery can still pass here. If the goal is true boot-path coverage, assert against the post-reload state directly, or seed saved workflow state before reload and let the app restore it on startup.

Based on learnings: For bug-fix PRs, ensure end-to-end regression coverage by either adding or updating a Playwright regression test under browser_tests/, or provide a concrete, non-placeholder explanation in the PR description of why an end-to-end regression test is not practical.

Also applies to: 342-363

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@browser_tests/tests/subgraph/subgraphSerialization.spec.ts` around lines 104
- 121, The test "Duplicate ID remap workflow remains navigable after a full
reload boot path" incorrectly calls
comfyPage.workflow.loadWorkflow(DUPLICATE_IDS_WORKFLOW) after page.reload(),
which overwrites the app's restored boot state; remove the second
comfyPage.workflow.loadWorkflow call and instead either (A) seed the saved
workflow/localStorage before calling comfyPage.page.reload() and let the app
restore it on startup, or (B) after comfyPage.page.reload() use assertions
against the post-reload state (e.g., check that the expected nodes exist and
that comfyPage.subgraph.isInSubgraph() behaves) without reloading the fixture;
update the same pattern in the other test block (lines 342-363) where the
fixture is reloaded post-reload.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@browser_tests/tests/subgraph/subgraphSerialization.spec.ts`:
- Around line 104-121: The test "Duplicate ID remap workflow remains navigable
after a full reload boot path" incorrectly calls
comfyPage.workflow.loadWorkflow(DUPLICATE_IDS_WORKFLOW) after page.reload(),
which overwrites the app's restored boot state; remove the second
comfyPage.workflow.loadWorkflow call and instead either (A) seed the saved
workflow/localStorage before calling comfyPage.page.reload() and let the app
restore it on startup, or (B) after comfyPage.page.reload() use assertions
against the post-reload state (e.g., check that the expected nodes exist and
that comfyPage.subgraph.isInSubgraph() behaves) without reloading the fixture;
update the same pattern in the other test block (lines 342-363) where the
fixture is reloaded post-reload.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 59fe8bcc-4de6-46d8-ae91-84a4bd87ca8f

📥 Commits

Reviewing files that changed from the base of the PR and between 39e1877 and 4260c8c.

📒 Files selected for processing (2)
  • browser_tests/helpers/promotedWidgets.ts
  • browser_tests/tests/subgraph/subgraphSerialization.spec.ts

coderabbitai[bot]
coderabbitai Bot previously approved these changes Apr 23, 2026
@codecov

codecov Bot commented Apr 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@             Coverage Diff             @@
##             main   #11579       +/-   ##
===========================================
- Coverage   67.29%   47.90%   -19.39%     
===========================================
  Files        1466     1361      -105     
  Lines       82824    69925    -12899     
  Branches    21900    19442     -2458     
===========================================
- Hits        55735    33498    -22237     
- Misses      26155    35832     +9677     
+ Partials      934      595      -339     
Flag Coverage Δ
e2e ?
unit 47.90% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1011 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DrJKL
DrJKL marked this pull request as ready for review April 24, 2026 21:45
@DrJKL
DrJKL requested a review from a team April 24, 2026 21:45
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 24, 2026

@jaeone94 jaeone94 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice restoration of the round-trip and multi-instance assertions that were lost in #10759 — these cover exactly the kind of regression #10849 introduced. A few notes inline on the new tests; nothing blocking, but worth a look before merge.

}
})

test('Multiple instances of the same subgraph keep distinct promoted widget values after load and reload', async ({

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Issue] This is the most direct regression guard for the per-instance promoted widget values fix (#10849), but it now sits inside the Legacy Prefixed proxyWidget Normalization describe whose beforeEach sets Comfy.VueNodes.Enabled = true. The collision being guarded is an instance-state issue at the LiteGraph node level, unrelated to the Vue rendering layer — running it only with Vue nodes enabled subtly changes the regression scenario.

Consider hoisting this test into its own describe (or covering both VueNodes.Enabled true/false) so the assertion isn't coupled to the legacy-prefixed normalization fixture setup.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 35916e7 — hoisted the Multiple instances of the same subgraph keep distinct promoted widget values test out of the Legacy Prefixed proxyWidget Normalization describe and made it a sibling at the top level of Subgraph Serialization. The regression guard now runs without Comfy.VueNodes.Enabled = true, exercising the LiteGraph instance-state path directly.

},
[hostSubgraphNodeId, interiorNodeIds] as const
)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Issue] If widgets is empty, interiorNodeIds is [], results is [], and this loop runs zero times — the assertion passes despite a real hydration failure. Some callers (e.g. afterFirst / afterSecond in the double round-trip) feed getPromotedWidgets straight in without first asserting non-emptiness, so an empty hydration is only caught indirectly by the later toEqual(initialWidgets) comparison.

A single expect(widgets.length).toBeGreaterThan(0) at the top of the helper would close this. As a bonus, expect(results).toEqual(widgets.map(() => true)) would also surface which interiorNodeId was missing on failure.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 35916e7 — added expect(widgets.length).toBeGreaterThan(0) at the top of expectPromotedWidgetsToResolveToInteriorNodes and replaced the for loop with expect(results).toEqual(widgets.map(() => true)) so the failure points at the specific interior node ID that's missing.

)
]

const isNonNegative = (id: number | string) =>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Issue] The isNonNegative short-circuit excludes the cases this test claims to catch. A link with origin_id: -1 (or a non-numeric id) makes the left side false, the && chain short-circuits to false, and .filter(Boolean) drops it — so malformed links produce no error string and the test silently passes despite the assertion name being "all links reference valid nodes".

Validating both well-formedness and resolution would fix it, e.g.:

const missing = (label: string, kind: 'origin_id' | 'target_id', id: number | string, g) =>
  (!isNonNegative(id) || !g._nodes_by_id[id])
    ? `${label}: ${kind} ${id} not found`
    : null

The nested flatMap + bool && string + .filter(Boolean) pipeline also reads slowly; pulling the per-link check into a small named helper would make the intent obvious.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 35916e7 — pulled the per-link resolution check into a named checkEndpoint(label, kind, id, g) helper and used a typed null filter so malformed entries can't be silently dropped.

One nuance worth flagging: the broader isNonNegative skip wasn't a logic bug — -1 and the subgraph I/O sentinels (-10, -20) are legitimate placeholder values used by litegraph for floating links and subgraph input/output node markers (e.g. LLink.ts checks origin_id === -1, LGraphNode.ts matches origin_id === -10 for inputNode). The renamed helper now spells that out as SENTINEL_IDS = new Set([-1, -10, -20]) and the predicate is isResolvableNodeId(id), so the skip is intentional and visible rather than implicit in a >= 0 check. The test now asserts: "every non-sentinel link endpoint resolves to a node in its graph."


test.describe('Legacy And Round-Trip Coverage', () => {
test.beforeEach(async ({ comfyPage }) => {
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Disabled')

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Suggestion] Comfy.UseNewMenu is mutated in beforeEach with no afterEach restore. Settings persist server-side, so when these tests run before another spec that depends on the default, that spec becomes order-dependent.

let prevMenu: string
test.beforeEach(async ({ comfyPage }) => {
  prevMenu = await comfyPage.settings.getSetting('Comfy.UseNewMenu')
  await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Disabled')
})
test.afterEach(async ({ comfyPage }) => {
  await comfyPage.settings.setSetting('Comfy.UseNewMenu', prevMenu)
})

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 35916e7 — added previousUseNewMenu capture in beforeEach and an afterEach that restores it, so the block no longer leaks Comfy.UseNewMenu = 'Disabled' to subsequent specs.

await comfyPage.page.keyboard.up('Alt')
}

const subgraphNodeIds = await comfyPage.page.evaluate(() => {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Suggestion] Two race-flake risks here:

  1. There's no nextFrame() (or any wait) between mouse.up() on line 280 and the page.evaluate that reads graph.nodes — the clone may not yet be in the graph when the read happens. The follow-up expect(subgraphNodeIds.length).toBeGreaterThan(1) is a one-shot assertion, so a slow CI runner would just fail. Wrapping it in expect.poll(() => …).toBeGreaterThan(1) would make it retry-safe.
  2. The gesture is hand-rolled with raw canvas coords plus magic offsets +16/+16 (start point inside title bar) and +72/+72 (drag distance). If a clone helper exists on NodeOperationsHelper or via command.executeCommand, prefer that; otherwise pulling this into something like NodeOperationsHelper.cloneByAltDrag(node) would let the test read as intent rather than input emulation.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partially addressed in 35916e7.

Race (1): Fixed — the post-drag node-count check is now await expect.poll(async () => (await collectSubgraphNodeIds()).length).toBeGreaterThan(1), so a slow runner gets retry-safe behavior.

Helper extraction (2): Not done in this PR. I checked NodeOperationsHelper and the existing subgraphCrud.spec.ts, and there's currently no shared cloneByAltDrag helper — subgraphCrud.spec.ts uses the same hand-rolled gesture (in a local duplicateSubgraphNodeViaAltDrag function with the same +16/+16 offset pattern). I'd rather not introduce a one-off helper inside this restoration PR; pulling alt-drag cloning into a proper shared NodeOperationsHelper.cloneByAltDrag(node) would land more cleanly as its own refactor that updates both call sites. Happy to file a follow-up issue for that if useful.

- Hoist 'Multiple instances ... distinct promoted widget values' out of the
  Vue-nodes describe so the LiteGraph instance-state regression guard isn't
  coupled to Comfy.VueNodes.Enabled = true.
- expectPromotedWidgetsToResolveToInteriorNodes: assert non-empty input and
  use toEqual(map(true)) so empty-array hydration failures fail loud and
  point at which interior node was missing.
- 'All links reference valid nodes': pull the per-link resolution check into
  a named helper, explicitly enumerate sentinel IDs (-1, -10, -20) for
  floating links / subgraph I/O nodes, and use a typed null filter so the
  intent is obvious and malformed link objects aren't silently dropped.
- Capture and restore Comfy.UseNewMenu in afterEach so the Legacy And
  Round-Trip Coverage block doesn't leave server-side settings mutated.
- 'Cloning a subgraph node ...': wrap the post-drag node-count check in
  expect.poll() so a slow CI runner doesn't fail the assertion before the
  cloned node enters the graph.
@glary-bot
glary-bot Bot force-pushed the glary/restore-subgraph-serialization-tests branch from 3bbd3b3 to 35916e7 Compare April 25, 2026 07:49

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
browser_tests/tests/subgraph/subgraphSerialization.spec.ts (1)

322-322: Redundant tag inherited from parent describe.

The { tag: ['@subgraph'] } is already applied to the parent test.describe('Subgraph Serialization', ...) at line 70. Tags are inherited, so this duplication is unnecessary.

♻️ Remove redundant tag
-  test.describe('Duplicate ID Remapping', { tag: ['@subgraph'] }, () => {
+  test.describe('Duplicate ID Remapping', () => {
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@browser_tests/tests/subgraph/subgraphSerialization.spec.ts` at line 322,
Remove the redundant tag object from the nested describe call: locate the
test.describe('Duplicate ID Remapping', { tag: ['@subgraph'] }, ...) and delete
the { tag: ['@subgraph'] } argument so the nested suite relies on inheritance
from the parent test.describe('Subgraph Serialization', ...); ensure the
describe call signature becomes test.describe('Duplicate ID Remapping', () => {
... }) and run tests to confirm no behavioral change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@browser_tests/tests/subgraph/subgraphSerialization.spec.ts`:
- Line 322: Remove the redundant tag object from the nested describe call:
locate the test.describe('Duplicate ID Remapping', { tag: ['@subgraph'] }, ...)
and delete the { tag: ['@subgraph'] } argument so the nested suite relies on
inheritance from the parent test.describe('Subgraph Serialization', ...); ensure
the describe call signature becomes test.describe('Duplicate ID Remapping', ()
=> { ... }) and run tests to confirm no behavioral change.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9014ea0e-d34c-4d12-866e-f312ee92d5a9

📥 Commits

Reviewing files that changed from the base of the PR and between 4260c8c and 35916e7.

📒 Files selected for processing (1)
  • browser_tests/tests/subgraph/subgraphSerialization.spec.ts

coderabbitai[bot]
coderabbitai Bot previously approved these changes Apr 25, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
browser_tests/tests/subgraph/subgraphSerialization.spec.ts (1)

20-68: Use function declarations for these top-level helpers.

These are module-level utilities, not callbacks, so async function fits the repo convention better and reads more cleanly than binding them to const.

♻️ Suggested refactor
-const expectPromotedWidgetsToResolveToInteriorNodes = async (
+async function expectPromotedWidgetsToResolveToInteriorNodes(
   comfyPage: ComfyPage,
   hostSubgraphNodeId: string,
   widgets: PromotedWidgetEntry[]
-) => {
+) {
   expect(widgets.length).toBeGreaterThan(0)

   const interiorNodeIds = widgets.map(([id]) => id)
   const results = await comfyPage.page.evaluate(
@@
 
   expect(results).toEqual(widgets.map(() => true))
-}
+}
 
-const getPromotedHostWidgetValues = async (
+async function getPromotedHostWidgetValues(
   comfyPage: ComfyPage,
   nodeIds: string[]
-) => {
+) {
   return comfyPage.page.evaluate((ids) => {
     const graph = window.app!.canvas.graph!
@@
       }
     })
   }, nodeIds)
-}
+}

As per coding guidelines, "Do not use function expressions if it's possible to use function declarations instead."

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@browser_tests/tests/subgraph/subgraphSerialization.spec.ts` around lines 20 -
68, Convert the two top-level helper arrow functions into async function
declarations: replace the const-bound async function
expectPromotedWidgetsToResolveToInteriorNodes = async (...) => { ... } with
async function expectPromotedWidgetsToResolveToInteriorNodes(...) { ... } and
likewise replace const getPromotedHostWidgetValues = async (...) => { ... } with
async function getPromotedHostWidgetValues(...) { ... }; keep the same parameter
types (ComfyPage, PromotedWidgetEntry, string[]), return values, and internal
logic (including the page.evaluate calls) so only the declaration style changes
and no behavior or names (expectPromotedWidgetsToResolveToInteriorNodes,
getPromotedHostWidgetValues) are altered.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@browser_tests/tests/subgraph/subgraphSerialization.spec.ts`:
- Around line 20-68: Convert the two top-level helper arrow functions into async
function declarations: replace the const-bound async function
expectPromotedWidgetsToResolveToInteriorNodes = async (...) => { ... } with
async function expectPromotedWidgetsToResolveToInteriorNodes(...) { ... } and
likewise replace const getPromotedHostWidgetValues = async (...) => { ... } with
async function getPromotedHostWidgetValues(...) { ... }; keep the same parameter
types (ComfyPage, PromotedWidgetEntry, string[]), return values, and internal
logic (including the page.evaluate calls) so only the declaration style changes
and no behavior or names (expectPromotedWidgetsToResolveToInteriorNodes,
getPromotedHostWidgetValues) are altered.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c8083855-3374-46df-b4b6-df84ef418652

📥 Commits

Reviewing files that changed from the base of the PR and between 35916e7 and 0f01c56.

📒 Files selected for processing (1)
  • browser_tests/tests/subgraph/subgraphSerialization.spec.ts

coderabbitai[bot]
coderabbitai Bot previously approved these changes Apr 25, 2026
Per repo convention (AGENTS.md: 'Do not use function expressions if it's
possible to use function declarations instead'), convert
expectPromotedWidgetsToResolveToInteriorNodes and getPromotedHostWidgetValues
from const-bound async arrow functions to async function declarations.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️ Duplicate comments (2)
browser_tests/tests/subgraph/subgraphSerialization.spec.ts (2)

456-458: ⚠️ Potential issue | 🟠 Major

Restore Comfy.VueNodes.Enabled after each test.

This describe mutates a persisted setting but never resets it, so later specs can become order-dependent. Comfy.UseNewMenu is already handled that way earlier in this file; Comfy.VueNodes.Enabled needs the same cleanup.

Suggested change
   test.describe(
     'Legacy Prefixed proxyWidget Normalization',
     { tag: ['@subgraph', '@widget'] },
     () => {
+      let previousVueNodesEnabled: unknown
+
       test.beforeEach(async ({ comfyPage }) => {
+        previousVueNodesEnabled =
+          await comfyPage.settings.getSetting('Comfy.VueNodes.Enabled')
         await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true)
       })
+
+      test.afterEach(async ({ comfyPage }) => {
+        await comfyPage.settings.setSetting(
+          'Comfy.VueNodes.Enabled',
+          previousVueNodesEnabled
+        )
+      })

       test('Loads without console warnings about failed widget resolution', async ({
         comfyPage
       }) => {
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@browser_tests/tests/subgraph/subgraphSerialization.spec.ts` around lines 456
- 458, The test suite currently sets Comfy.VueNodes.Enabled to true in the
test.beforeEach block (comfyPage.settings.setSetting('Comfy.VueNodes.Enabled',
true)) but never restores it; add a test.afterEach that resets
Comfy.VueNodes.Enabled to its previous value (or false) using
comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', <originalValue>) so the
persisted setting is cleaned up between specs; locate the existing
test.beforeEach and add a corresponding test.afterEach to call
comfyPage.settings.setSetting for Comfy.VueNodes.Enabled.

396-408: ⚠️ Potential issue | 🟡 Minor

Malformed string link IDs still slip past this guard.

checkEndpoint() only reports failures for numeric, non-sentinel IDs. If deserialization/remapping leaves a link endpoint as '5' or any other string, this test still passes even though the endpoint is malformed. Either treat non-sentinel non-number IDs as invalid, or narrow the test name to match what is actually being asserted.

Suggested change
         const SENTINEL_IDS = new Set([-1, -10, -20])
-        const isResolvableNodeId = (id: number | string): id is number =>
-          typeof id === 'number' && id >= 0 && !SENTINEL_IDS.has(id)
+        const isSentinelNodeId = (id: number | string): id is number =>
+          typeof id === 'number' && SENTINEL_IDS.has(id)

         const checkEndpoint = (
           label: string,
           kind: 'origin_id' | 'target_id',
           id: number | string,
           g: typeof graph
         ): string | null =>
-          isResolvableNodeId(id) && !g._nodes_by_id[id]
-            ? `${label}: ${kind} ${id} not found`
+          isSentinelNodeId(id)
+            ? null
+            : typeof id !== 'number' || !g._nodes_by_id[id]
+              ? `${label}: ${kind} ${id} invalid or not found`
+              : null
-            : null
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@browser_tests/tests/subgraph/subgraphSerialization.spec.ts` around lines 396
- 408, The guard allows string IDs like "5" to pass as valid endpoints; update
the check so non-numeric (non-number) IDs are treated as invalid. Modify
isResolvableNodeId and/or checkEndpoint (referencing SENTINEL_IDS,
isResolvableNodeId, and checkEndpoint) so that only typeof id === 'number' is
accepted and any string (even numeric-looking) that is not a sentinel is flagged
as an error—i.e., change the predicate to explicitly reject strings and have
checkEndpoint return a failure message when id is not a number or when the
numeric id is missing from g._nodes_by_id.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Duplicate comments:
In `@browser_tests/tests/subgraph/subgraphSerialization.spec.ts`:
- Around line 456-458: The test suite currently sets Comfy.VueNodes.Enabled to
true in the test.beforeEach block
(comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true)) but never
restores it; add a test.afterEach that resets Comfy.VueNodes.Enabled to its
previous value (or false) using
comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', <originalValue>) so the
persisted setting is cleaned up between specs; locate the existing
test.beforeEach and add a corresponding test.afterEach to call
comfyPage.settings.setSetting for Comfy.VueNodes.Enabled.
- Around line 396-408: The guard allows string IDs like "5" to pass as valid
endpoints; update the check so non-numeric (non-number) IDs are treated as
invalid. Modify isResolvableNodeId and/or checkEndpoint (referencing
SENTINEL_IDS, isResolvableNodeId, and checkEndpoint) so that only typeof id ===
'number' is accepted and any string (even numeric-looking) that is not a
sentinel is flagged as an error—i.e., change the predicate to explicitly reject
strings and have checkEndpoint return a failure message when id is not a number
or when the numeric id is missing from g._nodes_by_id.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b0a52f62-5614-41d9-b81a-754ef7513440

📥 Commits

Reviewing files that changed from the base of the PR and between 0f01c56 and 0b83564.

📒 Files selected for processing (1)
  • browser_tests/tests/subgraph/subgraphSerialization.spec.ts

coderabbitai[bot]
coderabbitai Bot previously approved these changes Apr 25, 2026
- Restore Comfy.VueNodes.Enabled in afterEach so the Legacy Prefixed
  proxyWidget Normalization block doesn't leak the setting to subsequent
  specs (matches the existing Comfy.UseNewMenu pattern).
- 'All links reference valid nodes': flip checkEndpoint() to flag any
  non-sentinel, non-numeric, or unresolved link endpoint as invalid.
  Previously string ids slipped past the type guard and were silently
  treated as valid; now the test name matches what's actually asserted.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
browser_tests/tests/subgraph/subgraphSerialization.spec.ts (1)

296-305: Consider function declaration for the local helper.

The collectSubgraphNodeIds helper is defined as an arrow function. While acceptable in a test context, prefer function declarations for clarity and consistency with the top-level helpers (lines 20, 45):

-const collectSubgraphNodeIds = () =>
-  comfyPage.page.evaluate(() => {
+async function collectSubgraphNodeIds() {
+  return comfyPage.page.evaluate(() => {
     const graph = window.app!.canvas.graph!
     return graph.nodes
       .filter(
         (n) =>
           typeof n.isSubgraphNode === 'function' && n.isSubgraphNode()
       )
       .map((n) => String(n.id))
   })
+}

This aligns with the established pattern of using function declarations for pure helpers. As per coding guidelines, function declarations are preferred over function expressions for clarity and hoisting behavior.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@browser_tests/tests/subgraph/subgraphSerialization.spec.ts` around lines 296
- 305, The helper collectSubgraphNodeIds is currently an arrow function; change
it to a function declaration named collectSubgraphNodeIds (preserving its
implementation that calls comfyPage.page.evaluate and returns the array of node
id strings) so it matches the existing top-level helper style and hoisting
behavior; replace the const arrow definition with a function
collectSubgraphNodeIds() { ... } keeping the inner code unchanged and ensure all
uses of collectSubgraphNodeIds still work after the refactor.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@browser_tests/tests/subgraph/subgraphSerialization.spec.ts`:
- Around line 296-305: The helper collectSubgraphNodeIds is currently an arrow
function; change it to a function declaration named collectSubgraphNodeIds
(preserving its implementation that calls comfyPage.page.evaluate and returns
the array of node id strings) so it matches the existing top-level helper style
and hoisting behavior; replace the const arrow definition with a function
collectSubgraphNodeIds() { ... } keeping the inner code unchanged and ensure all
uses of collectSubgraphNodeIds still work after the refactor.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 589d1a50-2b7c-408b-8bbd-7724fed910a3

📥 Commits

Reviewing files that changed from the base of the PR and between 0b83564 and 5c19120.

📒 Files selected for processing (1)
  • browser_tests/tests/subgraph/subgraphSerialization.spec.ts

coderabbitai[bot]
coderabbitai Bot previously approved these changes Apr 25, 2026

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed current head faba0d6. The restored subgraph serialization E2E coverage looks good to me, and CI is green.

@dante01yoon dante01yoon removed their assignment Apr 25, 2026
@DrJKL

DrJKL commented Apr 27, 2026 •

Copy link
Copy Markdown
Contributor Author

Reviewed current head faba0d6. The restored subgraph serialization E2E coverage looks good to me, and CI is green.

@dante01yoon Shouldn't it have failed because of the other change?

@DrJKL
DrJKL added this pull request to the merge queue Apr 27, 2026
Merged via the queue into main with commit 8dcadd6 Apr 27, 2026
37 checks passed
@DrJKL
DrJKL deleted the glary/restore-subgraph-serialization-tests branch April 27, 2026 21:45
@dante01yoon

Copy link
Copy Markdown
Collaborator

Reviewed current head faba0d6. The restored subgraph serialization E2E coverage looks good to me, and CI is green.

@dante01yoon Shouldn't it have failed because of the other change?

Which change?

pull Bot pushed a commit to Mu-L/ComfyUI_frontend that referenced this pull request Apr 28, 2026
…with it.fails (Comfy-Org#11697)

*PR Created by the Glary-Bot Agent*

---

## Summary

Comfy-Org#11579 restored *categorical* test coverage for subgraph serialization
but didn't reproduce the specific Z-Image-Turbo regression introduced by
Comfy-Org#10849 — pre-Comfy-Org#10849 templates whose `widgets_values` is leftover noise
get corrupted on load because the new code applies that array
positionally to promoted widget views.

This PR adds two **vitest** cases that pin the user-visible symptom
directly: after loading a misaligned legacy payload, the promoted widget
value should reflect the source default, not the legacy
`widgets_values[i]`.

Both use `it.fails` so the suite stays green while the bug is present
and flips to failing the moment the fix on
`fix/subgraph-promoted-widget-inline-state` lands.

## Tests

1. `falls back to source widget value when proxyWidgets is in legacy
2-tuple shape` — configure() with `proxyWidgets: [['-1', 'widget']]` +
`widgets_values: [999]` should leave the widget at the source default
(42), not 999.
2. `does not corrupt unbound promoted widgets when widgets_values length
mismatches view count` — same shape with longer/wrong-length array.

## Verification

- All 8 cases in the file pass under `it.fails` (CI green).
- Removing `.fails` locally produces the expected failures: `expected
42, received 999` and `expected 42, received 111` — confirming both
tests catch the regression.
- `pnpm typecheck`, `pnpm exec eslint`, `pnpm exec oxlint` all clean.

## Why `it.fails` and not plain failing tests

The actual fix (`fix/subgraph-promoted-widget-inline-state`) is
unmerged. Landing genuinely-failing tests on main would break CI for
everyone. `it.fails` documents the bug runnably, keeps CI green, and
signals when the fix lands so the marker can be dropped.

## Why these assertions, not "widgets_values must be undefined"

A first draft asserted that `serialize()` should not write
`widgets_values` at all. That conflicts with existing coverage in the
same file (`preserves per-instance widget values after configure`,
`round-trips per-instance widget values`) which deliberately uses
`widgets_values` for round-trip persistence. These rewritten assertions
target the load-time corruption symptom directly without contradicting
the per-instance contract — feedback from Oracle review.

## Coordination

Mirrors the failing tests already on commit `6a982675e` of the unmerged
`fix/subgraph-promoted-widget-inline-state` branch, with the addition of
`.fails` markers and a clarifying comment so they can land on main
first.

Follow-up to Comfy-Org#11579.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-11697-test-subgraph-pin-10849-promoted-widget-value-corruption-with-it-fails-34f6d73d365081d7a04dcf48ebeceafe)
by [Unito](https://www.unito.io)

---------

Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
pull Bot pushed a commit to Mu-L/ComfyUI_frontend that referenced this pull request May 1, 2026
…moted widget values) (Comfy-Org#11790)

## Summary

Reverts Comfy-Org#10849 (per-instance promoted widget value storage) and its
companion test-pinning PR Comfy-Org#11697. The fix in Comfy-Org#10849 caused regressions
in promoted-widget serialization (notably the Z-Image-Turbo template,
see Comfy-Org#10146 follow-up). A replacement fix is being developed on
`fix/subgraph-promoted-widget-inline-state` and will land separately.

## Changes

- **Revert Comfy-Org#11697** — drops the `it.fails`-marked tests that pin the
Comfy-Org#10849 corruption symptom. With Comfy-Org#10849 reverted, those markers would
falsely flip to passing.
- **Revert Comfy-Org#10849** — removes per-instance `_instanceWidgetValues` map,
`_pendingWidgetsValues` configure-time hydration, the `widgets_values`
write path in `SubgraphNode.serialize()`, the `sourceSerialize` field on
`PromotedWidgetView`, the multi-instance Vitest suite, and the
multi-instance E2E test + asset.
- **Conflict resolution** in
`browser_tests/tests/subgraph/subgraphSerialization.spec.ts`: kept the
restored test coverage from Comfy-Org#11579 (which is post-Comfy-Org#10849 on main) and
removed only the now-unreachable multi-instance test, its helper, and
its workflow constant. Auto-merge with Comfy-Org#11698 (`incrementVersion`) and
Comfy-Org#11699 (ID type aliases) was clean.

## Review Focus

- Confirm no other on-main code path has come to depend on
`PromotedWidgetView.sourceSerialize` or
`SubgraphNode._instanceWidgetValues` since Comfy-Org#10849 (grep is clean
locally).
- Confirm we want to land this revert before the replacement fix on
`fix/subgraph-promoted-widget-inline-state` is ready — this leaves the
original Comfy-Org#10146 (multi-instance widget value collision) unfixed in the
meantime.
- The retained Comfy-Org#11579 test coverage now exercises pre-Comfy-Org#10849 behavior;
some of those assertions were written expecting the Comfy-Org#10849 code path. CI
will surface any that need adjustment.

┆Issue is synchronized with this [Notion
page](https://app.notion.com/p/PR-11790-revert-roll-back-10849-11697-per-instance-promoted-widget-values-3536d73d3650814094abd58b6b712d8d)
by [Unito](https://www.unito.io)
dante01yoon added a commit that referenced this pull request May 9, 2026
… promoted widget values) (#11790) (#12098)

*PR Created by the Glary-Bot Agent*

---

## Summary

Backport of #11790 onto `cloud/1.43`. Reverts #10849 (per-instance
promoted widget value storage) and its companion test-pinning PR #11697.

**Why this is needed on `cloud/1.43`:** Glary-Bot's consolidated
backport (#11926) cherry-picked #10849 into `cloud/1.43` on May 5 — four
days *after* the same change was reverted on `main` in #11790. The audit
didn't surface the upstream revert. As a result, `cloud/1.43` (1.43.16)
currently ships the buggy #10849 implementation while `main` / nightly
(1.45.1) doesn't. This is the cause of the Hub
`rob_realistic_2k_images_quick_variations` model/vae/clip mixup
regression reported in `#bug-dump`; the same template renders correctly
on nightly.

After this lands, `cloud/1.43` and `main` will be on the same code path
for promoted-widget serialization. The replacement fix (#11811 with
`_pendingWidgetsValuesReplay`) will land separately on `main` and can be
backported afterward.

## Changes

Mirrors the upstream revert of #10849 + #11697:
- Removes `_instanceWidgetValues` map, `_pendingWidgetsValues`
hydration, and the `widgets_values` write path in
`SubgraphNode.serialize()`
- Removes `sourceSerialize` field on `PromotedWidgetView`
- Removes the multi-instance Vitest suite
(`SubgraphNode.multiInstance.test.ts`) and the multi-instance E2E test +
workflow asset

## Conflict Resolution

Two conflicts surfaced (vs the original revert, which conflict-resolved
against #11579 on `main`):

1. **`browser_tests/tests/subgraph/subgraphSerialization.spec.ts`** —
`cloud/1.43` does not have the #11579 expanded test coverage (`Duplicate
ID Remapping`, `Legacy Prefixed proxyWidget Normalization`) that the
original revert preserved. Took the `cloud/1.43` HEAD structure and
removed only the now-unreachable multi-instance test, its helper
`getPromotedHostWidgetValues`, and the unused `ComfyPage` import.
2.
**`src/lib/litegraph/src/subgraph/SubgraphNode.multiInstance.test.ts`**
— `modify/delete` (file was present on `cloud/1.43`'s #10849 backport,
deleted by the revert). Resolved by removing the file, matching the
revert.

## Verification

**Static analysis & tests:**
- `pnpm typecheck` — clean
- `pnpm typecheck:browser` — clean
- `pnpm exec eslint` on all changed files — clean
- `pnpm test:unit -- --run subgraph` — 506 tests passing across 34
suites (`SubgraphNode.test.ts`, `promotedWidgetView.test.ts`,
`subgraphNodePromotion.test.ts`, etc.)

**Manual verification (Playwright + local dev server):**
- Started ComfyUI backend (`--cpu --port 8188`) and `pnpm dev` frontend;
loaded the page successfully.
- Loaded `subgraph-with-multiple-promoted-widgets.json` — subgraph node
hydrated with 2 promoted widgets.
- Set distinct values on each promoted widget (`first-promoted-value`,
`second-promoted-value`), serialized via `app.graph.serialize()`, and
reloaded via `app.loadGraphData(...)`. Both values round-tripped
correctly to the right widget slots — confirming the revert restores the
working single-instance path that nightly currently ships.
- Hub-fetched template (`rob_realistic_2k_images_quick_variations`)
could not be reproduced locally — `comfy.org/workflows/...` API returns
404 to anonymous curl from the sandbox, and the Hub UI flow needs auth
wired up. The team has already confirmed this template renders correctly
on nightly, which ships this same revert.

## Note on Oracle Review

Oracle flagged the multi-instance regression and the cloud/1.43
forward-compat trade-off as "critical." These describe the *intended*
behavior of this revert — the team has consciously chosen the legacy
clobber path over #10849's broken per-instance code while the
replacement (#11811) is finalized on `main`. Both findings are accepted
trade-offs, not blockers.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-12098-backport-cloud-1-43-revert-roll-back-10849-11697-per-instance-promoted-widget-va-35b6d73d36508109a715fc9d3428a294)
by [Unito](https://www.unito.io)

Co-authored-by: Alexander Brown <drjkl@comfy.org>
dante01yoon pushed a commit that referenced this pull request Jul 27, 2026
*PR Created by the Glary-Bot Agent*

---

## Summary

#10759 removed ~12 E2E tests from `subgraphSerialization.spec.ts` during
a reorganization that shifted semantic coverage to Vitest. Several of
the removed tests covered the exact `serialize() → JSON → configure()`
round-trip that #10849's positional `_instanceWidgetValues` path later
regressed on Main — promoted widget values binding to the wrong slots
when loading templates whose `widgets_values` ordering doesn't match
current `proxyWidgets`.

This restores the pre-reorg E2E coverage so future regressions in
promoted-widget serialization are caught at the browser level.

## Restored tests

From `subgraphSerialization.spec.ts` (pre-#10759):

- **Deterministic proxyWidgets Hydrate** (3 tests) — round-trip
stability and compressed `target_slot` resolution.
- **Legacy And Round-Trip Coverage** (5 tests) — includes the most
directly-relevant restorations:
  - `Promoted widgets survive serialize -> loadGraphData round-trip`
  - `Multi-link input representative stays stable through save/reload`
- `Cloning a subgraph node keeps promoted widget entries on original and
clone`
- **Duplicate ID Remapping** (5 tests) — includes `Promoted widget
tuples are stable after full page reload boot path`.

The 4 tests that already existed on Main (added by #10849 and the
Vue-nodes legacy-prefixed block) are kept as-is.

## Adaptations to current APIs

- Imports reworked for the post-`@e2e/*` alias layout.
- Redundant `comfyPage.nextFrame()` calls dropped — `loadWorkflow` /
`loadGraphData` / `serializeAndReload` already wait internally (#11264).
- Alt-drag clone block wrapped in `try/finally` around
`keyboard.up('Alt')` to match the current `subgraphCrud.spec.ts`
pattern.
- `PromotedWidgetEntry` is now exported from
`browser_tests/helpers/promotedWidgets.ts` so the restored
`expectPromotedWidgetsToResolveToInteriorNodes` helper can type its
argument.

## Review follow-ups applied

- Use `expect.poll()` instead of `expect(async () => …).toPass()` for
the single-value snapshot comparison, per `browser_tests/AGENTS.md`.
- Capture and call `dispose()` from
`SubgraphHelper.collectConsoleWarnings()` inside a `try/finally` so the
console listener is unregistered after the test.

## Verification

- `pnpm typecheck:browser` — clean.
- `pnpm exec eslint` + `pnpm exec oxlint` on changed files — 0 warnings,
0 errors.
- `pnpm exec oxfmt` on changed files — applied (no diff).
- Ran 2 key restored tests against local ComfyUI + dev server:
- `Promoted widgets survive serialize -> loadGraphData round-trip` —
PASS (3.9s)
- `Multi-link input representative stays stable through save/reload` —
PASS (2.9s)
- Full-suite runs in this sandbox are blocked by the existing
`comfyPage` fixture's `createUser` path failing on repeat runs against
persistent backend state — unrelated to this PR. CI will exercise the
full suite.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-11579-test-restore-deleted-subgraph-serialization-E2E-tests-34b6d73d365081f29b27c1069476ad17)
by [Unito](https://www.unito.io)

---------

Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
dante01yoon pushed a commit that referenced this pull request Jul 27, 2026
…ails (#11697)

*PR Created by the Glary-Bot Agent*

---

## Summary

#11579 restored *categorical* test coverage for subgraph serialization
but didn't reproduce the specific Z-Image-Turbo regression introduced by
#10849 — pre-#10849 templates whose `widgets_values` is leftover noise
get corrupted on load because the new code applies that array
positionally to promoted widget views.

This PR adds two **vitest** cases that pin the user-visible symptom
directly: after loading a misaligned legacy payload, the promoted widget
value should reflect the source default, not the legacy
`widgets_values[i]`.

Both use `it.fails` so the suite stays green while the bug is present
and flips to failing the moment the fix on
`fix/subgraph-promoted-widget-inline-state` lands.

## Tests

1. `falls back to source widget value when proxyWidgets is in legacy
2-tuple shape` — configure() with `proxyWidgets: [['-1', 'widget']]` +
`widgets_values: [999]` should leave the widget at the source default
(42), not 999.
2. `does not corrupt unbound promoted widgets when widgets_values length
mismatches view count` — same shape with longer/wrong-length array.

## Verification

- All 8 cases in the file pass under `it.fails` (CI green).
- Removing `.fails` locally produces the expected failures: `expected
42, received 999` and `expected 42, received 111` — confirming both
tests catch the regression.
- `pnpm typecheck`, `pnpm exec eslint`, `pnpm exec oxlint` all clean.

## Why `it.fails` and not plain failing tests

The actual fix (`fix/subgraph-promoted-widget-inline-state`) is
unmerged. Landing genuinely-failing tests on main would break CI for
everyone. `it.fails` documents the bug runnably, keeps CI green, and
signals when the fix lands so the marker can be dropped.

## Why these assertions, not "widgets_values must be undefined"

A first draft asserted that `serialize()` should not write
`widgets_values` at all. That conflicts with existing coverage in the
same file (`preserves per-instance widget values after configure`,
`round-trips per-instance widget values`) which deliberately uses
`widgets_values` for round-trip persistence. These rewritten assertions
target the load-time corruption symptom directly without contradicting
the per-instance contract — feedback from Oracle review.

## Coordination

Mirrors the failing tests already on commit `6a982675e` of the unmerged
`fix/subgraph-promoted-widget-inline-state` branch, with the addition of
`.fails` markers and a clarifying comment so they can land on main
first.

Follow-up to #11579.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-11697-test-subgraph-pin-10849-promoted-widget-value-corruption-with-it-fails-34f6d73d365081d7a04dcf48ebeceafe)
by [Unito](https://www.unito.io)

---------

Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
dante01yoon pushed a commit that referenced this pull request Jul 27, 2026
…s) (#11790)

## Summary

Reverts #10849 (per-instance promoted widget value storage) and its
companion test-pinning PR #11697. The fix in #10849 caused regressions
in promoted-widget serialization (notably the Z-Image-Turbo template,
see #10146 follow-up). A replacement fix is being developed on
`fix/subgraph-promoted-widget-inline-state` and will land separately.

## Changes

- **Revert #11697** — drops the `it.fails`-marked tests that pin the
#10849 corruption symptom. With #10849 reverted, those markers would
falsely flip to passing.
- **Revert #10849** — removes per-instance `_instanceWidgetValues` map,
`_pendingWidgetsValues` configure-time hydration, the `widgets_values`
write path in `SubgraphNode.serialize()`, the `sourceSerialize` field on
`PromotedWidgetView`, the multi-instance Vitest suite, and the
multi-instance E2E test + asset.
- **Conflict resolution** in
`browser_tests/tests/subgraph/subgraphSerialization.spec.ts`: kept the
restored test coverage from #11579 (which is post-#10849 on main) and
removed only the now-unreachable multi-instance test, its helper, and
its workflow constant. Auto-merge with #11698 (`incrementVersion`) and
#11699 (ID type aliases) was clean.

## Review Focus

- Confirm no other on-main code path has come to depend on
`PromotedWidgetView.sourceSerialize` or
`SubgraphNode._instanceWidgetValues` since #10849 (grep is clean
locally).
- Confirm we want to land this revert before the replacement fix on
`fix/subgraph-promoted-widget-inline-state` is ready — this leaves the
original #10146 (multi-instance widget value collision) unfixed in the
meantime.
- The retained #11579 test coverage now exercises pre-#10849 behavior;
some of those assertions were written expecting the #10849 code path. CI
will surface any that need adjustment.

┆Issue is synchronized with this [Notion
page](https://app.notion.com/p/PR-11790-revert-roll-back-10849-11697-per-instance-promoted-widget-values-3536d73d3650814094abd58b6b712d8d)
by [Unito](https://www.unito.io)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants