Repository navigation
test: restore deleted subgraph serialization E2E tests - #11579
Conversation
PR #10759 removed ~12 E2E tests from subgraphSerialization.spec.ts during a reorganization that shifted semantic coverage to Vitest. Several of the removed tests covered the exact save/load round-trip that PR #10849's positional _instanceWidgetValues path later regressed on Main (promoted widget values binding to wrong slots after configure). Restore the pre-reorg test coverage so future regressions in promoted widget serialization are caught at the E2E level: - Deterministic proxyWidgets Hydrate (3 tests) - Legacy And Round-Trip Coverage (5 tests) - Duplicate ID Remapping (5 tests) Export PromotedWidgetEntry from the promotedWidgets helper so the restored tests can type the helper results.
- Replace expect(async () => ...).toPass() with expect.poll() for the single-value snapshot comparison (matches browser_tests/AGENTS.md guidance) - Capture and call dispose() from collectConsoleWarnings() inside a try/finally to avoid leaking the console listener after the test
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughA single type alias ( Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook |
🎭 Playwright: ✅ 1336 passed, 0 failed📊 Browser Reports
|
📦 Bundle: 5.21 MB gzip 🟢 -43 BDetailsSummary
Category Glance App Entry Points — 22.4 kB (baseline 22.4 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.22 MB (baseline 1.22 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 76.6 kB (baseline 76.6 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 2 unchanged Panels & Settings — 483 kB (baseline 483 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 11 unchanged User & Accounts — 17.1 kB (baseline 17.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed / 2 unchanged Editors & Dialogs — 110 kB (baseline 110 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 60.5 kB (baseline 60.5 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 8 unchanged Data & Services — 3.02 MB (baseline 3.02 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 361 kB (baseline 361 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 13 added / 13 removed / 18 unchanged Vendor & Third-Party — 9.88 MB (baseline 9.88 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 8.77 MB (baseline 8.77 MB) • ⚪ 0 BBundles that do not match a named category
Status: 57 added / 57 removed / 78 unchanged ⚡ Performance Report
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-04-25T08:31:06.456Z",
"gitSha": "e4e003192513e8c5992e92833ba88336d4788816",
"branch": "glary/restore-subgraph-serialization-tests",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2056.1200000000213,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.444,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.734,
"heapDeltaBytes": 20321084,
"heapUsedBytes": 64332264,
"domNodes": 14,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 27.178,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2018.6939999999822,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.614,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.11600000000004,
"heapDeltaBytes": 21017108,
"heapUsedBytes": 65034956,
"domNodes": 16,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 27.228999999999996,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2020.403999999985,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.078,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.71099999999996,
"heapDeltaBytes": 20984664,
"heapUsedBytes": 64656648,
"domNodes": 20,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 31.998000000000005,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2060.769999999991,
"styleRecalcs": 82,
"styleRecalcDurationMs": 47.055,
"layouts": 12,
"layoutDurationMs": 3.8,
"taskDurationMs": 1040.6060000000002,
"heapDeltaBytes": 15653172,
"heapUsedBytes": 59805796,
"domNodes": 63,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 139.21699999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1880.4979999999887,
"styleRecalcs": 75,
"styleRecalcDurationMs": 42.114,
"layouts": 12,
"layoutDurationMs": 3.851,
"taskDurationMs": 816.0409999999999,
"heapDeltaBytes": 15917792,
"heapUsedBytes": 59619104,
"domNodes": 58,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 142.85899999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2023.9480000000185,
"styleRecalcs": 84,
"styleRecalcDurationMs": 46.346,
"layouts": 12,
"layoutDurationMs": 3.4610000000000003,
"taskDurationMs": 1024.0749999999998,
"heapDeltaBytes": 18590880,
"heapUsedBytes": 68486332,
"domNodes": 65,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 144.121,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1742.2789999999964,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.712,
"layouts": 6,
"layoutDurationMs": 0.6149999999999999,
"taskDurationMs": 350.933,
"heapDeltaBytes": 25036164,
"heapUsedBytes": 68674472,
"domNodes": 78,
"jsHeapTotalBytes": 21495808,
"scriptDurationMs": 31.979999999999993,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1711.7229999998926,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.934,
"layouts": 6,
"layoutDurationMs": 0.7800000000000001,
"taskDurationMs": 349.089,
"heapDeltaBytes": 24747248,
"heapUsedBytes": 68472304,
"domNodes": 75,
"jsHeapTotalBytes": 20971520,
"scriptDurationMs": 26.60599999999999,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1756.6470000000436,
"styleRecalcs": 32,
"styleRecalcDurationMs": 21.072,
"layouts": 6,
"layoutDurationMs": 0.788,
"taskDurationMs": 393.34499999999997,
"heapDeltaBytes": 975948,
"heapUsedBytes": 52542924,
"domNodes": 78,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 37.2,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 544.7489999999675,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.884,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 345.831,
"heapDeltaBytes": 7027824,
"heapUsedBytes": 50703772,
"domNodes": 21,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 65.64399999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 566.867000000002,
"styleRecalcs": 13,
"styleRecalcDurationMs": 10.577,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 358.699,
"heapDeltaBytes": 7081992,
"heapUsedBytes": 50913744,
"domNodes": 22,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 63.41000000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 573.517000000038,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.170000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.67799999999994,
"heapDeltaBytes": 7364932,
"heapUsedBytes": 50953664,
"domNodes": 20,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 71.75300000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2074.3310000000292,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.658999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 730.469,
"heapDeltaBytes": 3330480,
"heapUsedBytes": 55538240,
"domNodes": -257,
"jsHeapTotalBytes": 16683008,
"scriptDurationMs": 129.135,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2048.952999999983,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.407,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 655.6979999999999,
"heapDeltaBytes": 3937412,
"heapUsedBytes": 56894740,
"domNodes": -259,
"jsHeapTotalBytes": 16683008,
"scriptDurationMs": 119.85400000000001,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2037.7469999999676,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.832,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 707.378,
"heapDeltaBytes": 3953952,
"heapUsedBytes": 56476276,
"domNodes": -262,
"jsHeapTotalBytes": 16158720,
"scriptDurationMs": 130.806,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2178.1029999999646,
"styleRecalcs": 68,
"styleRecalcDurationMs": 17.611,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1216.8490000000002,
"heapDeltaBytes": 19779760,
"heapUsedBytes": 74791988,
"domNodes": -266,
"jsHeapTotalBytes": 17674240,
"scriptDurationMs": 425.148,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2193.458000000078,
"styleRecalcs": 68,
"styleRecalcDurationMs": 18.022000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1282.051,
"heapDeltaBytes": 19967320,
"heapUsedBytes": 75111404,
"domNodes": -266,
"jsHeapTotalBytes": 18460672,
"scriptDurationMs": 461.328,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2187.864999999988,
"styleRecalcs": 69,
"styleRecalcDurationMs": 22.153,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1263.9180000000001,
"heapDeltaBytes": 16967552,
"heapUsedBytes": 71999700,
"domNodes": -263,
"jsHeapTotalBytes": 18984960,
"scriptDurationMs": 443.577,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3163.409999999999,
"styleRecalcs": 65,
"styleRecalcDurationMs": 19.576,
"layouts": 60,
"layoutDurationMs": 7.723000000000001,
"taskDurationMs": 1425.261,
"heapDeltaBytes": 8253476,
"heapUsedBytes": 64530028,
"domNodes": -265,
"jsHeapTotalBytes": 16683008,
"scriptDurationMs": 518.412,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3250.3040000000283,
"styleRecalcs": 66,
"styleRecalcDurationMs": 20.901,
"layouts": 60,
"layoutDurationMs": 7.885,
"taskDurationMs": 1518.089,
"heapDeltaBytes": 9991232,
"heapUsedBytes": 65591160,
"domNodes": -267,
"jsHeapTotalBytes": 15896576,
"scriptDurationMs": 561.71,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3248.9069999999174,
"styleRecalcs": 66,
"styleRecalcDurationMs": 20.533999999999995,
"layouts": 60,
"layoutDurationMs": 7.880999999999999,
"taskDurationMs": 1553.1320000000003,
"heapDeltaBytes": 7316736,
"heapUsedBytes": 63977152,
"domNodes": -266,
"jsHeapTotalBytes": 17575936,
"scriptDurationMs": 583.434,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2044.36800000002,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.758,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 682.7189999999998,
"heapDeltaBytes": 975348,
"heapUsedBytes": 68120072,
"domNodes": -263,
"jsHeapTotalBytes": 11116544,
"scriptDurationMs": 110.867,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.723000000089,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.443000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 667.988,
"heapDeltaBytes": 124728,
"heapUsedBytes": 56105204,
"domNodes": -261,
"jsHeapTotalBytes": 15896576,
"scriptDurationMs": 114.242,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2071.1969999999837,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.387000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 692.882,
"heapDeltaBytes": 3567196,
"heapUsedBytes": 59720404,
"domNodes": -264,
"jsHeapTotalBytes": 16420864,
"scriptDurationMs": 119.869,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 571.0480000000189,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.339,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.90299999999996,
"heapDeltaBytes": 7049148,
"heapUsedBytes": 50988452,
"domNodes": 20,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 126.78499999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 564.60299999992,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.657999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 366.15000000000003,
"heapDeltaBytes": 8186776,
"heapUsedBytes": 58571900,
"domNodes": 20,
"jsHeapTotalBytes": 13893632,
"scriptDurationMs": 125.332,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.7910000000811,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.401999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.864,
"heapDeltaBytes": 6880152,
"heapUsedBytes": 50245228,
"domNodes": 15,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 124.91799999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2038.9249999999493,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.253,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.606,
"heapDeltaBytes": 21003188,
"heapUsedBytes": 64846440,
"domNodes": 20,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 27.038999999999994,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2016.6000000000395,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.283000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.96399999999994,
"heapDeltaBytes": 19923700,
"heapUsedBytes": 63923852,
"domNodes": 20,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 25.316,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2004.099999999994,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.01,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.45200000000006,
"heapDeltaBytes": 19872136,
"heapUsedBytes": 64041716,
"domNodes": 18,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 21.900000000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1718.956999999989,
"styleRecalcs": 76,
"styleRecalcDurationMs": 45.364000000000004,
"layouts": 16,
"layoutDurationMs": 5.116,
"taskDurationMs": 738.94,
"heapDeltaBytes": 12231996,
"heapUsedBytes": 56204016,
"domNodes": 63,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 105.53800000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1676.2560000000803,
"styleRecalcs": 75,
"styleRecalcDurationMs": 38.934,
"layouts": 16,
"layoutDurationMs": 4.8149999999999995,
"taskDurationMs": 696.861,
"heapDeltaBytes": 12278964,
"heapUsedBytes": 56035124,
"domNodes": 61,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 101.23800000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1974.646000000007,
"styleRecalcs": 84,
"styleRecalcDurationMs": 48.69099999999999,
"layouts": 16,
"layoutDurationMs": 4.62,
"taskDurationMs": 964.061,
"heapDeltaBytes": 11903044,
"heapUsedBytes": 55872232,
"domNodes": 72,
"jsHeapTotalBytes": 22282240,
"scriptDurationMs": 112.815,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8195.375000000013,
"styleRecalcs": 251,
"styleRecalcDurationMs": 53.297999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4012.582999999999,
"heapDeltaBytes": 6261568,
"heapUsedBytes": 58706532,
"domNodes": -260,
"jsHeapTotalBytes": 19771392,
"scriptDurationMs": 1333.995,
"eventListeners": -109,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8243.348999999966,
"styleRecalcs": 252,
"styleRecalcDurationMs": 55.864,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4130.013,
"heapDeltaBytes": 24921188,
"heapUsedBytes": 77078340,
"domNodes": -259,
"jsHeapTotalBytes": 19771392,
"scriptDurationMs": 1349.3950000000002,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8215.88399999996,
"styleRecalcs": 251,
"styleRecalcDurationMs": 58.666000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4074.2659999999996,
"heapDeltaBytes": -231616,
"heapUsedBytes": 51853680,
"domNodes": -258,
"jsHeapTotalBytes": 19304448,
"scriptDurationMs": 1347.2630000000001,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12604.758000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12591.192,
"heapDeltaBytes": -28930160,
"heapUsedBytes": 168815112,
"domNodes": -9850,
"jsHeapTotalBytes": 23916544,
"scriptDurationMs": 609.211,
"eventListeners": -23958,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12637.701000000106,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12621.631000000001,
"heapDeltaBytes": -47130756,
"heapUsedBytes": 168461324,
"domNodes": -9848,
"jsHeapTotalBytes": 26275840,
"scriptDurationMs": 628.8199999999999,
"eventListeners": -23959,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12916.52499999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12897.977,
"heapDeltaBytes": -30586740,
"heapUsedBytes": 167685656,
"domNodes": -9850,
"jsHeapTotalBytes": 23130112,
"scriptDurationMs": 646.797,
"eventListeners": -23959,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14958.844999999998,
"styleRecalcs": 71,
"styleRecalcDurationMs": 18.496000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14932.811999999998,
"heapDeltaBytes": -63461640,
"heapUsedBytes": 162698304,
"domNodes": -9850,
"jsHeapTotalBytes": -16539648,
"scriptDurationMs": 913.5649999999999,
"eventListeners": -23955,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14739.536000000044,
"styleRecalcs": 67,
"styleRecalcDurationMs": 17.620000000000026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14708.742999999999,
"heapDeltaBytes": -41925708,
"heapUsedBytes": 172133980,
"domNodes": -9850,
"jsHeapTotalBytes": -14704640,
"scriptDurationMs": 937.273,
"eventListeners": -23985,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 14824.659999999994,
"styleRecalcs": 65,
"styleRecalcDurationMs": 18.394999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14797.565999999999,
"heapDeltaBytes": -35688172,
"heapUsedBytes": 185917056,
"domNodes": -9852,
"jsHeapTotalBytes": 21995520,
"scriptDurationMs": 922.2949999999998,
"eventListeners": -23957,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 466.8750000000159,
"styleRecalcs": 15,
"styleRecalcDurationMs": 23.945,
"layouts": 5,
"layoutDurationMs": 1.8279999999999998,
"taskDurationMs": 131.87099999999998,
"heapDeltaBytes": 5187552,
"heapUsedBytes": 50541556,
"domNodes": 165,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 26.732999999999997,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 469.51400000000376,
"styleRecalcs": 16,
"styleRecalcDurationMs": 25.48,
"layouts": 5,
"layoutDurationMs": 1.418,
"taskDurationMs": 138.35700000000003,
"heapDeltaBytes": 5102160,
"heapUsedBytes": 50551016,
"domNodes": 154,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 32.478,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 476.7229999999927,
"styleRecalcs": 20,
"styleRecalcDurationMs": 23.928000000000004,
"layouts": 4,
"layoutDurationMs": 1.1850000000000003,
"taskDurationMs": 124.36299999999997,
"heapDeltaBytes": 5043100,
"heapUsedBytes": 50354672,
"domNodes": 175,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 23.245999999999995,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
browser_tests/tests/subgraph/subgraphSerialization.spec.ts (1)
104-121:⚠️ Potential issue | 🟠 MajorDon't re-load the fixture in the "full reload boot path" cases.
After
page.reload(), both tests callworkflow.loadWorkflow(DUPLICATE_IDS_WORKFLOW)again, which replaces whatever the app restored during boot. That means a regression in persisted reload hydration/localStorage recovery can still pass here. If the goal is true boot-path coverage, assert against the post-reload state directly, or seed saved workflow state before reload and let the app restore it on startup.Based on learnings: For bug-fix PRs, ensure end-to-end regression coverage by either adding or updating a Playwright regression test under browser_tests/, or provide a concrete, non-placeholder explanation in the PR description of why an end-to-end regression test is not practical.
Also applies to: 342-363
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/subgraph/subgraphSerialization.spec.ts` around lines 104 - 121, The test "Duplicate ID remap workflow remains navigable after a full reload boot path" incorrectly calls comfyPage.workflow.loadWorkflow(DUPLICATE_IDS_WORKFLOW) after page.reload(), which overwrites the app's restored boot state; remove the second comfyPage.workflow.loadWorkflow call and instead either (A) seed the saved workflow/localStorage before calling comfyPage.page.reload() and let the app restore it on startup, or (B) after comfyPage.page.reload() use assertions against the post-reload state (e.g., check that the expected nodes exist and that comfyPage.subgraph.isInSubgraph() behaves) without reloading the fixture; update the same pattern in the other test block (lines 342-363) where the fixture is reloaded post-reload.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@browser_tests/tests/subgraph/subgraphSerialization.spec.ts`:
- Around line 104-121: The test "Duplicate ID remap workflow remains navigable
after a full reload boot path" incorrectly calls
comfyPage.workflow.loadWorkflow(DUPLICATE_IDS_WORKFLOW) after page.reload(),
which overwrites the app's restored boot state; remove the second
comfyPage.workflow.loadWorkflow call and instead either (A) seed the saved
workflow/localStorage before calling comfyPage.page.reload() and let the app
restore it on startup, or (B) after comfyPage.page.reload() use assertions
against the post-reload state (e.g., check that the expected nodes exist and
that comfyPage.subgraph.isInSubgraph() behaves) without reloading the fixture;
update the same pattern in the other test block (lines 342-363) where the
fixture is reloaded post-reload.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 59fe8bcc-4de6-46d8-ae91-84a4bd87ca8f
📒 Files selected for processing (2)
browser_tests/helpers/promotedWidgets.tsbrowser_tests/tests/subgraph/subgraphSerialization.spec.ts
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #11579 +/- ##
===========================================
- Coverage 67.29% 47.90% -19.39%
===========================================
Files 1466 1361 -105
Lines 82824 69925 -12899
Branches 21900 19442 -2458
===========================================
- Hits 55735 33498 -22237
- Misses 26155 35832 +9677
+ Partials 934 595 -339
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| } | ||
| }) | ||
|
|
||
| test('Multiple instances of the same subgraph keep distinct promoted widget values after load and reload', async ({ |
There was a problem hiding this comment.
[Issue] This is the most direct regression guard for the per-instance promoted widget values fix (#10849), but it now sits inside the Legacy Prefixed proxyWidget Normalization describe whose beforeEach sets Comfy.VueNodes.Enabled = true. The collision being guarded is an instance-state issue at the LiteGraph node level, unrelated to the Vue rendering layer — running it only with Vue nodes enabled subtly changes the regression scenario.
Consider hoisting this test into its own describe (or covering both VueNodes.Enabled true/false) so the assertion isn't coupled to the legacy-prefixed normalization fixture setup.
There was a problem hiding this comment.
Fixed in 35916e7 — hoisted the Multiple instances of the same subgraph keep distinct promoted widget values test out of the Legacy Prefixed proxyWidget Normalization describe and made it a sibling at the top level of Subgraph Serialization. The regression guard now runs without Comfy.VueNodes.Enabled = true, exercising the LiteGraph instance-state path directly.
| }, | ||
| [hostSubgraphNodeId, interiorNodeIds] as const | ||
| ) | ||
|
|
There was a problem hiding this comment.
[Issue] If widgets is empty, interiorNodeIds is [], results is [], and this loop runs zero times — the assertion passes despite a real hydration failure. Some callers (e.g. afterFirst / afterSecond in the double round-trip) feed getPromotedWidgets straight in without first asserting non-emptiness, so an empty hydration is only caught indirectly by the later toEqual(initialWidgets) comparison.
A single expect(widgets.length).toBeGreaterThan(0) at the top of the helper would close this. As a bonus, expect(results).toEqual(widgets.map(() => true)) would also surface which interiorNodeId was missing on failure.
There was a problem hiding this comment.
Fixed in 35916e7 — added expect(widgets.length).toBeGreaterThan(0) at the top of expectPromotedWidgetsToResolveToInteriorNodes and replaced the for loop with expect(results).toEqual(widgets.map(() => true)) so the failure points at the specific interior node ID that's missing.
| ) | ||
| ] | ||
|
|
||
| const isNonNegative = (id: number | string) => |
There was a problem hiding this comment.
[Issue] The isNonNegative short-circuit excludes the cases this test claims to catch. A link with origin_id: -1 (or a non-numeric id) makes the left side false, the && chain short-circuits to false, and .filter(Boolean) drops it — so malformed links produce no error string and the test silently passes despite the assertion name being "all links reference valid nodes".
Validating both well-formedness and resolution would fix it, e.g.:
const missing = (label: string, kind: 'origin_id' | 'target_id', id: number | string, g) =>
(!isNonNegative(id) || !g._nodes_by_id[id])
? `${label}: ${kind} ${id} not found`
: nullThe nested flatMap + bool && string + .filter(Boolean) pipeline also reads slowly; pulling the per-link check into a small named helper would make the intent obvious.
There was a problem hiding this comment.
Fixed in 35916e7 — pulled the per-link resolution check into a named checkEndpoint(label, kind, id, g) helper and used a typed null filter so malformed entries can't be silently dropped.
One nuance worth flagging: the broader isNonNegative skip wasn't a logic bug — -1 and the subgraph I/O sentinels (-10, -20) are legitimate placeholder values used by litegraph for floating links and subgraph input/output node markers (e.g. LLink.ts checks origin_id === -1, LGraphNode.ts matches origin_id === -10 for inputNode). The renamed helper now spells that out as SENTINEL_IDS = new Set([-1, -10, -20]) and the predicate is isResolvableNodeId(id), so the skip is intentional and visible rather than implicit in a >= 0 check. The test now asserts: "every non-sentinel link endpoint resolves to a node in its graph."
|
|
||
| test.describe('Legacy And Round-Trip Coverage', () => { | ||
| test.beforeEach(async ({ comfyPage }) => { | ||
| await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Disabled') |
There was a problem hiding this comment.
[Suggestion] Comfy.UseNewMenu is mutated in beforeEach with no afterEach restore. Settings persist server-side, so when these tests run before another spec that depends on the default, that spec becomes order-dependent.
let prevMenu: string
test.beforeEach(async ({ comfyPage }) => {
prevMenu = await comfyPage.settings.getSetting('Comfy.UseNewMenu')
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Disabled')
})
test.afterEach(async ({ comfyPage }) => {
await comfyPage.settings.setSetting('Comfy.UseNewMenu', prevMenu)
})There was a problem hiding this comment.
Fixed in 35916e7 — added previousUseNewMenu capture in beforeEach and an afterEach that restores it, so the block no longer leaks Comfy.UseNewMenu = 'Disabled' to subsequent specs.
| await comfyPage.page.keyboard.up('Alt') | ||
| } | ||
|
|
||
| const subgraphNodeIds = await comfyPage.page.evaluate(() => { |
There was a problem hiding this comment.
[Suggestion] Two race-flake risks here:
- There's no
nextFrame()(or any wait) betweenmouse.up()on line 280 and thepage.evaluatethat readsgraph.nodes— the clone may not yet be in the graph when the read happens. The follow-upexpect(subgraphNodeIds.length).toBeGreaterThan(1)is a one-shot assertion, so a slow CI runner would just fail. Wrapping it inexpect.poll(() => …).toBeGreaterThan(1)would make it retry-safe. - The gesture is hand-rolled with raw canvas coords plus magic offsets
+16/+16(start point inside title bar) and+72/+72(drag distance). If a clone helper exists onNodeOperationsHelperor viacommand.executeCommand, prefer that; otherwise pulling this into something likeNodeOperationsHelper.cloneByAltDrag(node)would let the test read as intent rather than input emulation.
There was a problem hiding this comment.
Partially addressed in 35916e7.
Race (1): Fixed — the post-drag node-count check is now await expect.poll(async () => (await collectSubgraphNodeIds()).length).toBeGreaterThan(1), so a slow runner gets retry-safe behavior.
Helper extraction (2): Not done in this PR. I checked NodeOperationsHelper and the existing subgraphCrud.spec.ts, and there's currently no shared cloneByAltDrag helper — subgraphCrud.spec.ts uses the same hand-rolled gesture (in a local duplicateSubgraphNodeViaAltDrag function with the same +16/+16 offset pattern). I'd rather not introduce a one-off helper inside this restoration PR; pulling alt-drag cloning into a proper shared NodeOperationsHelper.cloneByAltDrag(node) would land more cleanly as its own refactor that updates both call sites. Happy to file a follow-up issue for that if useful.
- Hoist 'Multiple instances ... distinct promoted widget values' out of the Vue-nodes describe so the LiteGraph instance-state regression guard isn't coupled to Comfy.VueNodes.Enabled = true. - expectPromotedWidgetsToResolveToInteriorNodes: assert non-empty input and use toEqual(map(true)) so empty-array hydration failures fail loud and point at which interior node was missing. - 'All links reference valid nodes': pull the per-link resolution check into a named helper, explicitly enumerate sentinel IDs (-1, -10, -20) for floating links / subgraph I/O nodes, and use a typed null filter so the intent is obvious and malformed link objects aren't silently dropped. - Capture and restore Comfy.UseNewMenu in afterEach so the Legacy And Round-Trip Coverage block doesn't leave server-side settings mutated. - 'Cloning a subgraph node ...': wrap the post-drag node-count check in expect.poll() so a slow CI runner doesn't fail the assertion before the cloned node enters the graph.
3bbd3b3 to
35916e7
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
browser_tests/tests/subgraph/subgraphSerialization.spec.ts (1)
322-322: Redundant tag inherited from parent describe.The
{ tag: ['@subgraph'] }is already applied to the parenttest.describe('Subgraph Serialization', ...)at line 70. Tags are inherited, so this duplication is unnecessary.♻️ Remove redundant tag
- test.describe('Duplicate ID Remapping', { tag: ['@subgraph'] }, () => { + test.describe('Duplicate ID Remapping', () => {🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/subgraph/subgraphSerialization.spec.ts` at line 322, Remove the redundant tag object from the nested describe call: locate the test.describe('Duplicate ID Remapping', { tag: ['@subgraph'] }, ...) and delete the { tag: ['@subgraph'] } argument so the nested suite relies on inheritance from the parent test.describe('Subgraph Serialization', ...); ensure the describe call signature becomes test.describe('Duplicate ID Remapping', () => { ... }) and run tests to confirm no behavioral change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@browser_tests/tests/subgraph/subgraphSerialization.spec.ts`:
- Line 322: Remove the redundant tag object from the nested describe call:
locate the test.describe('Duplicate ID Remapping', { tag: ['@subgraph'] }, ...)
and delete the { tag: ['@subgraph'] } argument so the nested suite relies on
inheritance from the parent test.describe('Subgraph Serialization', ...); ensure
the describe call signature becomes test.describe('Duplicate ID Remapping', ()
=> { ... }) and run tests to confirm no behavioral change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 9014ea0e-d34c-4d12-866e-f312ee92d5a9
📒 Files selected for processing (1)
browser_tests/tests/subgraph/subgraphSerialization.spec.ts
There was a problem hiding this comment.
🧹 Nitpick comments (1)
browser_tests/tests/subgraph/subgraphSerialization.spec.ts (1)
20-68: Use function declarations for these top-level helpers.These are module-level utilities, not callbacks, so
async functionfits the repo convention better and reads more cleanly than binding them toconst.♻️ Suggested refactor
-const expectPromotedWidgetsToResolveToInteriorNodes = async ( +async function expectPromotedWidgetsToResolveToInteriorNodes( comfyPage: ComfyPage, hostSubgraphNodeId: string, widgets: PromotedWidgetEntry[] -) => { +) { expect(widgets.length).toBeGreaterThan(0) const interiorNodeIds = widgets.map(([id]) => id) const results = await comfyPage.page.evaluate( @@ expect(results).toEqual(widgets.map(() => true)) -} +} -const getPromotedHostWidgetValues = async ( +async function getPromotedHostWidgetValues( comfyPage: ComfyPage, nodeIds: string[] -) => { +) { return comfyPage.page.evaluate((ids) => { const graph = window.app!.canvas.graph! @@ } }) }, nodeIds) -} +}As per coding guidelines, "Do not use function expressions if it's possible to use function declarations instead."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/subgraph/subgraphSerialization.spec.ts` around lines 20 - 68, Convert the two top-level helper arrow functions into async function declarations: replace the const-bound async function expectPromotedWidgetsToResolveToInteriorNodes = async (...) => { ... } with async function expectPromotedWidgetsToResolveToInteriorNodes(...) { ... } and likewise replace const getPromotedHostWidgetValues = async (...) => { ... } with async function getPromotedHostWidgetValues(...) { ... }; keep the same parameter types (ComfyPage, PromotedWidgetEntry, string[]), return values, and internal logic (including the page.evaluate calls) so only the declaration style changes and no behavior or names (expectPromotedWidgetsToResolveToInteriorNodes, getPromotedHostWidgetValues) are altered.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@browser_tests/tests/subgraph/subgraphSerialization.spec.ts`:
- Around line 20-68: Convert the two top-level helper arrow functions into async
function declarations: replace the const-bound async function
expectPromotedWidgetsToResolveToInteriorNodes = async (...) => { ... } with
async function expectPromotedWidgetsToResolveToInteriorNodes(...) { ... } and
likewise replace const getPromotedHostWidgetValues = async (...) => { ... } with
async function getPromotedHostWidgetValues(...) { ... }; keep the same parameter
types (ComfyPage, PromotedWidgetEntry, string[]), return values, and internal
logic (including the page.evaluate calls) so only the declaration style changes
and no behavior or names (expectPromotedWidgetsToResolveToInteriorNodes,
getPromotedHostWidgetValues) are altered.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: c8083855-3374-46df-b4b6-df84ef418652
📒 Files selected for processing (1)
browser_tests/tests/subgraph/subgraphSerialization.spec.ts
Per repo convention (AGENTS.md: 'Do not use function expressions if it's possible to use function declarations instead'), convert expectPromotedWidgetsToResolveToInteriorNodes and getPromotedHostWidgetValues from const-bound async arrow functions to async function declarations.
There was a problem hiding this comment.
♻️ Duplicate comments (2)
browser_tests/tests/subgraph/subgraphSerialization.spec.ts (2)
456-458:⚠️ Potential issue | 🟠 MajorRestore
Comfy.VueNodes.Enabledafter each test.This describe mutates a persisted setting but never resets it, so later specs can become order-dependent.
Comfy.UseNewMenuis already handled that way earlier in this file;Comfy.VueNodes.Enabledneeds the same cleanup.Suggested change
test.describe( 'Legacy Prefixed proxyWidget Normalization', { tag: ['@subgraph', '@widget'] }, () => { + let previousVueNodesEnabled: unknown + test.beforeEach(async ({ comfyPage }) => { + previousVueNodesEnabled = + await comfyPage.settings.getSetting('Comfy.VueNodes.Enabled') await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true) }) + + test.afterEach(async ({ comfyPage }) => { + await comfyPage.settings.setSetting( + 'Comfy.VueNodes.Enabled', + previousVueNodesEnabled + ) + }) test('Loads without console warnings about failed widget resolution', async ({ comfyPage }) => {🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/subgraph/subgraphSerialization.spec.ts` around lines 456 - 458, The test suite currently sets Comfy.VueNodes.Enabled to true in the test.beforeEach block (comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true)) but never restores it; add a test.afterEach that resets Comfy.VueNodes.Enabled to its previous value (or false) using comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', <originalValue>) so the persisted setting is cleaned up between specs; locate the existing test.beforeEach and add a corresponding test.afterEach to call comfyPage.settings.setSetting for Comfy.VueNodes.Enabled.
396-408:⚠️ Potential issue | 🟡 MinorMalformed string link IDs still slip past this guard.
checkEndpoint()only reports failures for numeric, non-sentinel IDs. If deserialization/remapping leaves a link endpoint as'5'or any other string, this test still passes even though the endpoint is malformed. Either treat non-sentinel non-number IDs as invalid, or narrow the test name to match what is actually being asserted.Suggested change
const SENTINEL_IDS = new Set([-1, -10, -20]) - const isResolvableNodeId = (id: number | string): id is number => - typeof id === 'number' && id >= 0 && !SENTINEL_IDS.has(id) + const isSentinelNodeId = (id: number | string): id is number => + typeof id === 'number' && SENTINEL_IDS.has(id) const checkEndpoint = ( label: string, kind: 'origin_id' | 'target_id', id: number | string, g: typeof graph ): string | null => - isResolvableNodeId(id) && !g._nodes_by_id[id] - ? `${label}: ${kind} ${id} not found` + isSentinelNodeId(id) + ? null + : typeof id !== 'number' || !g._nodes_by_id[id] + ? `${label}: ${kind} ${id} invalid or not found` + : null - : null🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/subgraph/subgraphSerialization.spec.ts` around lines 396 - 408, The guard allows string IDs like "5" to pass as valid endpoints; update the check so non-numeric (non-number) IDs are treated as invalid. Modify isResolvableNodeId and/or checkEndpoint (referencing SENTINEL_IDS, isResolvableNodeId, and checkEndpoint) so that only typeof id === 'number' is accepted and any string (even numeric-looking) that is not a sentinel is flagged as an error—i.e., change the predicate to explicitly reject strings and have checkEndpoint return a failure message when id is not a number or when the numeric id is missing from g._nodes_by_id.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@browser_tests/tests/subgraph/subgraphSerialization.spec.ts`:
- Around line 456-458: The test suite currently sets Comfy.VueNodes.Enabled to
true in the test.beforeEach block
(comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true)) but never
restores it; add a test.afterEach that resets Comfy.VueNodes.Enabled to its
previous value (or false) using
comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', <originalValue>) so the
persisted setting is cleaned up between specs; locate the existing
test.beforeEach and add a corresponding test.afterEach to call
comfyPage.settings.setSetting for Comfy.VueNodes.Enabled.
- Around line 396-408: The guard allows string IDs like "5" to pass as valid
endpoints; update the check so non-numeric (non-number) IDs are treated as
invalid. Modify isResolvableNodeId and/or checkEndpoint (referencing
SENTINEL_IDS, isResolvableNodeId, and checkEndpoint) so that only typeof id ===
'number' is accepted and any string (even numeric-looking) that is not a
sentinel is flagged as an error—i.e., change the predicate to explicitly reject
strings and have checkEndpoint return a failure message when id is not a number
or when the numeric id is missing from g._nodes_by_id.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b0a52f62-5614-41d9-b81a-754ef7513440
📒 Files selected for processing (1)
browser_tests/tests/subgraph/subgraphSerialization.spec.ts
- Restore Comfy.VueNodes.Enabled in afterEach so the Legacy Prefixed proxyWidget Normalization block doesn't leak the setting to subsequent specs (matches the existing Comfy.UseNewMenu pattern). - 'All links reference valid nodes': flip checkEndpoint() to flag any non-sentinel, non-numeric, or unresolved link endpoint as invalid. Previously string ids slipped past the type guard and were silently treated as valid; now the test name matches what's actually asserted.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
browser_tests/tests/subgraph/subgraphSerialization.spec.ts (1)
296-305: Consider function declaration for the local helper.The
collectSubgraphNodeIdshelper is defined as an arrow function. While acceptable in a test context, prefer function declarations for clarity and consistency with the top-level helpers (lines 20, 45):-const collectSubgraphNodeIds = () => - comfyPage.page.evaluate(() => { +async function collectSubgraphNodeIds() { + return comfyPage.page.evaluate(() => { const graph = window.app!.canvas.graph! return graph.nodes .filter( (n) => typeof n.isSubgraphNode === 'function' && n.isSubgraphNode() ) .map((n) => String(n.id)) }) +}This aligns with the established pattern of using function declarations for pure helpers. As per coding guidelines, function declarations are preferred over function expressions for clarity and hoisting behavior.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/subgraph/subgraphSerialization.spec.ts` around lines 296 - 305, The helper collectSubgraphNodeIds is currently an arrow function; change it to a function declaration named collectSubgraphNodeIds (preserving its implementation that calls comfyPage.page.evaluate and returns the array of node id strings) so it matches the existing top-level helper style and hoisting behavior; replace the const arrow definition with a function collectSubgraphNodeIds() { ... } keeping the inner code unchanged and ensure all uses of collectSubgraphNodeIds still work after the refactor.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@browser_tests/tests/subgraph/subgraphSerialization.spec.ts`:
- Around line 296-305: The helper collectSubgraphNodeIds is currently an arrow
function; change it to a function declaration named collectSubgraphNodeIds
(preserving its implementation that calls comfyPage.page.evaluate and returns
the array of node id strings) so it matches the existing top-level helper style
and hoisting behavior; replace the const arrow definition with a function
collectSubgraphNodeIds() { ... } keeping the inner code unchanged and ensure all
uses of collectSubgraphNodeIds still work after the refactor.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 589d1a50-2b7c-408b-8bbd-7724fed910a3
📒 Files selected for processing (1)
browser_tests/tests/subgraph/subgraphSerialization.spec.ts
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed current head faba0d6. The restored subgraph serialization E2E coverage looks good to me, and CI is green.
@dante01yoon Shouldn't it have failed because of the other change? |
Which change? |
…with it.fails (Comfy-Org#11697) *PR Created by the Glary-Bot Agent* --- ## Summary Comfy-Org#11579 restored *categorical* test coverage for subgraph serialization but didn't reproduce the specific Z-Image-Turbo regression introduced by Comfy-Org#10849 — pre-Comfy-Org#10849 templates whose `widgets_values` is leftover noise get corrupted on load because the new code applies that array positionally to promoted widget views. This PR adds two **vitest** cases that pin the user-visible symptom directly: after loading a misaligned legacy payload, the promoted widget value should reflect the source default, not the legacy `widgets_values[i]`. Both use `it.fails` so the suite stays green while the bug is present and flips to failing the moment the fix on `fix/subgraph-promoted-widget-inline-state` lands. ## Tests 1. `falls back to source widget value when proxyWidgets is in legacy 2-tuple shape` — configure() with `proxyWidgets: [['-1', 'widget']]` + `widgets_values: [999]` should leave the widget at the source default (42), not 999. 2. `does not corrupt unbound promoted widgets when widgets_values length mismatches view count` — same shape with longer/wrong-length array. ## Verification - All 8 cases in the file pass under `it.fails` (CI green). - Removing `.fails` locally produces the expected failures: `expected 42, received 999` and `expected 42, received 111` — confirming both tests catch the regression. - `pnpm typecheck`, `pnpm exec eslint`, `pnpm exec oxlint` all clean. ## Why `it.fails` and not plain failing tests The actual fix (`fix/subgraph-promoted-widget-inline-state`) is unmerged. Landing genuinely-failing tests on main would break CI for everyone. `it.fails` documents the bug runnably, keeps CI green, and signals when the fix lands so the marker can be dropped. ## Why these assertions, not "widgets_values must be undefined" A first draft asserted that `serialize()` should not write `widgets_values` at all. That conflicts with existing coverage in the same file (`preserves per-instance widget values after configure`, `round-trips per-instance widget values`) which deliberately uses `widgets_values` for round-trip persistence. These rewritten assertions target the load-time corruption symptom directly without contradicting the per-instance contract — feedback from Oracle review. ## Coordination Mirrors the failing tests already on commit `6a982675e` of the unmerged `fix/subgraph-promoted-widget-inline-state` branch, with the addition of `.fails` markers and a clarifying comment so they can land on main first. Follow-up to Comfy-Org#11579. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11697-test-subgraph-pin-10849-promoted-widget-value-corruption-with-it-fails-34f6d73d365081d7a04dcf48ebeceafe) by [Unito](https://www.unito.io) --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
…moted widget values) (Comfy-Org#11790) ## Summary Reverts Comfy-Org#10849 (per-instance promoted widget value storage) and its companion test-pinning PR Comfy-Org#11697. The fix in Comfy-Org#10849 caused regressions in promoted-widget serialization (notably the Z-Image-Turbo template, see Comfy-Org#10146 follow-up). A replacement fix is being developed on `fix/subgraph-promoted-widget-inline-state` and will land separately. ## Changes - **Revert Comfy-Org#11697** — drops the `it.fails`-marked tests that pin the Comfy-Org#10849 corruption symptom. With Comfy-Org#10849 reverted, those markers would falsely flip to passing. - **Revert Comfy-Org#10849** — removes per-instance `_instanceWidgetValues` map, `_pendingWidgetsValues` configure-time hydration, the `widgets_values` write path in `SubgraphNode.serialize()`, the `sourceSerialize` field on `PromotedWidgetView`, the multi-instance Vitest suite, and the multi-instance E2E test + asset. - **Conflict resolution** in `browser_tests/tests/subgraph/subgraphSerialization.spec.ts`: kept the restored test coverage from Comfy-Org#11579 (which is post-Comfy-Org#10849 on main) and removed only the now-unreachable multi-instance test, its helper, and its workflow constant. Auto-merge with Comfy-Org#11698 (`incrementVersion`) and Comfy-Org#11699 (ID type aliases) was clean. ## Review Focus - Confirm no other on-main code path has come to depend on `PromotedWidgetView.sourceSerialize` or `SubgraphNode._instanceWidgetValues` since Comfy-Org#10849 (grep is clean locally). - Confirm we want to land this revert before the replacement fix on `fix/subgraph-promoted-widget-inline-state` is ready — this leaves the original Comfy-Org#10146 (multi-instance widget value collision) unfixed in the meantime. - The retained Comfy-Org#11579 test coverage now exercises pre-Comfy-Org#10849 behavior; some of those assertions were written expecting the Comfy-Org#10849 code path. CI will surface any that need adjustment. ┆Issue is synchronized with this [Notion page](https://app.notion.com/p/PR-11790-revert-roll-back-10849-11697-per-instance-promoted-widget-values-3536d73d3650814094abd58b6b712d8d) by [Unito](https://www.unito.io)
… promoted widget values) (#11790) (#12098) *PR Created by the Glary-Bot Agent* --- ## Summary Backport of #11790 onto `cloud/1.43`. Reverts #10849 (per-instance promoted widget value storage) and its companion test-pinning PR #11697. **Why this is needed on `cloud/1.43`:** Glary-Bot's consolidated backport (#11926) cherry-picked #10849 into `cloud/1.43` on May 5 — four days *after* the same change was reverted on `main` in #11790. The audit didn't surface the upstream revert. As a result, `cloud/1.43` (1.43.16) currently ships the buggy #10849 implementation while `main` / nightly (1.45.1) doesn't. This is the cause of the Hub `rob_realistic_2k_images_quick_variations` model/vae/clip mixup regression reported in `#bug-dump`; the same template renders correctly on nightly. After this lands, `cloud/1.43` and `main` will be on the same code path for promoted-widget serialization. The replacement fix (#11811 with `_pendingWidgetsValuesReplay`) will land separately on `main` and can be backported afterward. ## Changes Mirrors the upstream revert of #10849 + #11697: - Removes `_instanceWidgetValues` map, `_pendingWidgetsValues` hydration, and the `widgets_values` write path in `SubgraphNode.serialize()` - Removes `sourceSerialize` field on `PromotedWidgetView` - Removes the multi-instance Vitest suite (`SubgraphNode.multiInstance.test.ts`) and the multi-instance E2E test + workflow asset ## Conflict Resolution Two conflicts surfaced (vs the original revert, which conflict-resolved against #11579 on `main`): 1. **`browser_tests/tests/subgraph/subgraphSerialization.spec.ts`** — `cloud/1.43` does not have the #11579 expanded test coverage (`Duplicate ID Remapping`, `Legacy Prefixed proxyWidget Normalization`) that the original revert preserved. Took the `cloud/1.43` HEAD structure and removed only the now-unreachable multi-instance test, its helper `getPromotedHostWidgetValues`, and the unused `ComfyPage` import. 2. **`src/lib/litegraph/src/subgraph/SubgraphNode.multiInstance.test.ts`** — `modify/delete` (file was present on `cloud/1.43`'s #10849 backport, deleted by the revert). Resolved by removing the file, matching the revert. ## Verification **Static analysis & tests:** - `pnpm typecheck` — clean - `pnpm typecheck:browser` — clean - `pnpm exec eslint` on all changed files — clean - `pnpm test:unit -- --run subgraph` — 506 tests passing across 34 suites (`SubgraphNode.test.ts`, `promotedWidgetView.test.ts`, `subgraphNodePromotion.test.ts`, etc.) **Manual verification (Playwright + local dev server):** - Started ComfyUI backend (`--cpu --port 8188`) and `pnpm dev` frontend; loaded the page successfully. - Loaded `subgraph-with-multiple-promoted-widgets.json` — subgraph node hydrated with 2 promoted widgets. - Set distinct values on each promoted widget (`first-promoted-value`, `second-promoted-value`), serialized via `app.graph.serialize()`, and reloaded via `app.loadGraphData(...)`. Both values round-tripped correctly to the right widget slots — confirming the revert restores the working single-instance path that nightly currently ships. - Hub-fetched template (`rob_realistic_2k_images_quick_variations`) could not be reproduced locally — `comfy.org/workflows/...` API returns 404 to anonymous curl from the sandbox, and the Hub UI flow needs auth wired up. The team has already confirmed this template renders correctly on nightly, which ships this same revert. ## Note on Oracle Review Oracle flagged the multi-instance regression and the cloud/1.43 forward-compat trade-off as "critical." These describe the *intended* behavior of this revert — the team has consciously chosen the legacy clobber path over #10849's broken per-instance code while the replacement (#11811) is finalized on `main`. Both findings are accepted trade-offs, not blockers. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-12098-backport-cloud-1-43-revert-roll-back-10849-11697-per-instance-promoted-widget-va-35b6d73d36508109a715fc9d3428a294) by [Unito](https://www.unito.io) Co-authored-by: Alexander Brown <drjkl@comfy.org>
*PR Created by the Glary-Bot Agent* --- ## Summary #10759 removed ~12 E2E tests from `subgraphSerialization.spec.ts` during a reorganization that shifted semantic coverage to Vitest. Several of the removed tests covered the exact `serialize() → JSON → configure()` round-trip that #10849's positional `_instanceWidgetValues` path later regressed on Main — promoted widget values binding to the wrong slots when loading templates whose `widgets_values` ordering doesn't match current `proxyWidgets`. This restores the pre-reorg E2E coverage so future regressions in promoted-widget serialization are caught at the browser level. ## Restored tests From `subgraphSerialization.spec.ts` (pre-#10759): - **Deterministic proxyWidgets Hydrate** (3 tests) — round-trip stability and compressed `target_slot` resolution. - **Legacy And Round-Trip Coverage** (5 tests) — includes the most directly-relevant restorations: - `Promoted widgets survive serialize -> loadGraphData round-trip` - `Multi-link input representative stays stable through save/reload` - `Cloning a subgraph node keeps promoted widget entries on original and clone` - **Duplicate ID Remapping** (5 tests) — includes `Promoted widget tuples are stable after full page reload boot path`. The 4 tests that already existed on Main (added by #10849 and the Vue-nodes legacy-prefixed block) are kept as-is. ## Adaptations to current APIs - Imports reworked for the post-`@e2e/*` alias layout. - Redundant `comfyPage.nextFrame()` calls dropped — `loadWorkflow` / `loadGraphData` / `serializeAndReload` already wait internally (#11264). - Alt-drag clone block wrapped in `try/finally` around `keyboard.up('Alt')` to match the current `subgraphCrud.spec.ts` pattern. - `PromotedWidgetEntry` is now exported from `browser_tests/helpers/promotedWidgets.ts` so the restored `expectPromotedWidgetsToResolveToInteriorNodes` helper can type its argument. ## Review follow-ups applied - Use `expect.poll()` instead of `expect(async () => …).toPass()` for the single-value snapshot comparison, per `browser_tests/AGENTS.md`. - Capture and call `dispose()` from `SubgraphHelper.collectConsoleWarnings()` inside a `try/finally` so the console listener is unregistered after the test. ## Verification - `pnpm typecheck:browser` — clean. - `pnpm exec eslint` + `pnpm exec oxlint` on changed files — 0 warnings, 0 errors. - `pnpm exec oxfmt` on changed files — applied (no diff). - Ran 2 key restored tests against local ComfyUI + dev server: - `Promoted widgets survive serialize -> loadGraphData round-trip` — PASS (3.9s) - `Multi-link input representative stays stable through save/reload` — PASS (2.9s) - Full-suite runs in this sandbox are blocked by the existing `comfyPage` fixture's `createUser` path failing on repeat runs against persistent backend state — unrelated to this PR. CI will exercise the full suite. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11579-test-restore-deleted-subgraph-serialization-E2E-tests-34b6d73d365081f29b27c1069476ad17) by [Unito](https://www.unito.io) --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
…ails (#11697) *PR Created by the Glary-Bot Agent* --- ## Summary #11579 restored *categorical* test coverage for subgraph serialization but didn't reproduce the specific Z-Image-Turbo regression introduced by #10849 — pre-#10849 templates whose `widgets_values` is leftover noise get corrupted on load because the new code applies that array positionally to promoted widget views. This PR adds two **vitest** cases that pin the user-visible symptom directly: after loading a misaligned legacy payload, the promoted widget value should reflect the source default, not the legacy `widgets_values[i]`. Both use `it.fails` so the suite stays green while the bug is present and flips to failing the moment the fix on `fix/subgraph-promoted-widget-inline-state` lands. ## Tests 1. `falls back to source widget value when proxyWidgets is in legacy 2-tuple shape` — configure() with `proxyWidgets: [['-1', 'widget']]` + `widgets_values: [999]` should leave the widget at the source default (42), not 999. 2. `does not corrupt unbound promoted widgets when widgets_values length mismatches view count` — same shape with longer/wrong-length array. ## Verification - All 8 cases in the file pass under `it.fails` (CI green). - Removing `.fails` locally produces the expected failures: `expected 42, received 999` and `expected 42, received 111` — confirming both tests catch the regression. - `pnpm typecheck`, `pnpm exec eslint`, `pnpm exec oxlint` all clean. ## Why `it.fails` and not plain failing tests The actual fix (`fix/subgraph-promoted-widget-inline-state`) is unmerged. Landing genuinely-failing tests on main would break CI for everyone. `it.fails` documents the bug runnably, keeps CI green, and signals when the fix lands so the marker can be dropped. ## Why these assertions, not "widgets_values must be undefined" A first draft asserted that `serialize()` should not write `widgets_values` at all. That conflicts with existing coverage in the same file (`preserves per-instance widget values after configure`, `round-trips per-instance widget values`) which deliberately uses `widgets_values` for round-trip persistence. These rewritten assertions target the load-time corruption symptom directly without contradicting the per-instance contract — feedback from Oracle review. ## Coordination Mirrors the failing tests already on commit `6a982675e` of the unmerged `fix/subgraph-promoted-widget-inline-state` branch, with the addition of `.fails` markers and a clarifying comment so they can land on main first. Follow-up to #11579. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11697-test-subgraph-pin-10849-promoted-widget-value-corruption-with-it-fails-34f6d73d365081d7a04dcf48ebeceafe) by [Unito](https://www.unito.io) --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
…s) (#11790) ## Summary Reverts #10849 (per-instance promoted widget value storage) and its companion test-pinning PR #11697. The fix in #10849 caused regressions in promoted-widget serialization (notably the Z-Image-Turbo template, see #10146 follow-up). A replacement fix is being developed on `fix/subgraph-promoted-widget-inline-state` and will land separately. ## Changes - **Revert #11697** — drops the `it.fails`-marked tests that pin the #10849 corruption symptom. With #10849 reverted, those markers would falsely flip to passing. - **Revert #10849** — removes per-instance `_instanceWidgetValues` map, `_pendingWidgetsValues` configure-time hydration, the `widgets_values` write path in `SubgraphNode.serialize()`, the `sourceSerialize` field on `PromotedWidgetView`, the multi-instance Vitest suite, and the multi-instance E2E test + asset. - **Conflict resolution** in `browser_tests/tests/subgraph/subgraphSerialization.spec.ts`: kept the restored test coverage from #11579 (which is post-#10849 on main) and removed only the now-unreachable multi-instance test, its helper, and its workflow constant. Auto-merge with #11698 (`incrementVersion`) and #11699 (ID type aliases) was clean. ## Review Focus - Confirm no other on-main code path has come to depend on `PromotedWidgetView.sourceSerialize` or `SubgraphNode._instanceWidgetValues` since #10849 (grep is clean locally). - Confirm we want to land this revert before the replacement fix on `fix/subgraph-promoted-widget-inline-state` is ready — this leaves the original #10146 (multi-instance widget value collision) unfixed in the meantime. - The retained #11579 test coverage now exercises pre-#10849 behavior; some of those assertions were written expecting the #10849 code path. CI will surface any that need adjustment. ┆Issue is synchronized with this [Notion page](https://app.notion.com/p/PR-11790-revert-roll-back-10849-11697-per-instance-promoted-widget-values-3536d73d3650814094abd58b6b712d8d) by [Unito](https://www.unito.io)
PR Created by the Glary-Bot Agent
Summary
#10759 removed ~12 E2E tests from
subgraphSerialization.spec.tsduring a reorganization that shifted semantic coverage to Vitest. Several of the removed tests covered the exactserialize() → JSON → configure()round-trip that #10849's positional_instanceWidgetValuespath later regressed on Main — promoted widget values binding to the wrong slots when loading templates whosewidgets_valuesordering doesn't match currentproxyWidgets.This restores the pre-reorg E2E coverage so future regressions in promoted-widget serialization are caught at the browser level.
Restored tests
From
subgraphSerialization.spec.ts(pre-#10759):target_slotresolution.Promoted widgets survive serialize -> loadGraphData round-tripMulti-link input representative stays stable through save/reloadCloning a subgraph node keeps promoted widget entries on original and clonePromoted widget tuples are stable after full page reload boot path.The 4 tests that already existed on Main (added by #10849 and the Vue-nodes legacy-prefixed block) are kept as-is.
Adaptations to current APIs
@e2e/*alias layout.comfyPage.nextFrame()calls dropped —loadWorkflow/loadGraphData/serializeAndReloadalready wait internally (test: Add waitForWorkflowIdle & remove redundant nextFrame #11264).try/finallyaroundkeyboard.up('Alt')to match the currentsubgraphCrud.spec.tspattern.PromotedWidgetEntryis now exported frombrowser_tests/helpers/promotedWidgets.tsso the restoredexpectPromotedWidgetsToResolveToInteriorNodeshelper can type its argument.Review follow-ups applied
expect.poll()instead ofexpect(async () => …).toPass()for the single-value snapshot comparison, perbrowser_tests/AGENTS.md.dispose()fromSubgraphHelper.collectConsoleWarnings()inside atry/finallyso the console listener is unregistered after the test.Verification
pnpm typecheck:browser— clean.pnpm exec eslint+pnpm exec oxlinton changed files — 0 warnings, 0 errors.pnpm exec oxfmton changed files — applied (no diff).Promoted widgets survive serialize -> loadGraphData round-trip— PASS (3.9s)Multi-link input representative stays stable through save/reload— PASS (2.9s)comfyPagefixture'screateUserpath failing on repeat runs against persistent backend state — unrelated to this PR. CI will exercise the full suite.┆Issue is synchronized with this Notion page by Unito