Skip to content

test(subgraph): pin #10849 promoted-widget-value corruption with it.fails - #11697

Merged
DrJKL merged 3 commits into
mainfrom
glary/subgraph-misaligned-widgets-values-test
Apr 28, 2026
Merged

DrJKL merged 3 commits into
mainfrom
glary/subgraph-misaligned-widgets-values-test

Conversation

@DrJKL

@DrJKL DrJKL commented Apr 27, 2026 •

Copy link
Copy Markdown
Contributor

PR Created by the Glary-Bot Agent


Summary

#11579 restored categorical test coverage for subgraph serialization but didn't reproduce the specific Z-Image-Turbo regression introduced by #10849 — pre-#10849 templates whose widgets_values is leftover noise get corrupted on load because the new code applies that array positionally to promoted widget views.

This PR adds two vitest cases that pin the user-visible symptom directly: after loading a misaligned legacy payload, the promoted widget value should reflect the source default, not the legacy widgets_values[i].

Both use it.fails so the suite stays green while the bug is present and flips to failing the moment the fix on fix/subgraph-promoted-widget-inline-state lands.

Tests

  1. falls back to source widget value when proxyWidgets is in legacy 2-tuple shape — configure() with proxyWidgets: [['-1', 'widget']] + widgets_values: [999] should leave the widget at the source default (42), not 999.
  2. does not corrupt unbound promoted widgets when widgets_values length mismatches view count — same shape with longer/wrong-length array.

Verification

  • All 8 cases in the file pass under it.fails (CI green).
  • Removing .fails locally produces the expected failures: expected 42, received 999 and expected 42, received 111 — confirming both tests catch the regression.
  • pnpm typecheck, pnpm exec eslint, pnpm exec oxlint all clean.

Why it.fails and not plain failing tests

The actual fix (fix/subgraph-promoted-widget-inline-state) is unmerged. Landing genuinely-failing tests on main would break CI for everyone. it.fails documents the bug runnably, keeps CI green, and signals when the fix lands so the marker can be dropped.

Why these assertions, not "widgets_values must be undefined"

A first draft asserted that serialize() should not write widgets_values at all. That conflicts with existing coverage in the same file (preserves per-instance widget values after configure, round-trips per-instance widget values) which deliberately uses widgets_values for round-trip persistence. These rewritten assertions target the load-time corruption symptom directly without contradicting the per-instance contract — feedback from Oracle review.

Coordination

Mirrors the failing tests already on commit 6a982675e of the unmerged fix/subgraph-promoted-widget-inline-state branch, with the addition of .fails markers and a clarifying comment so they can land on main first.

Follow-up to #11579.

┆Issue is synchronized with this Notion page by Unito

…ails

The Z-Image-Turbo regression introduced by #10849 corrupts promoted widget
values on load when widgets_values comes from a pre-#10849 template (where
that array was leftover noise rather than promoted-widget state). The fix
on the unmerged inline-proxyWidgets-state branch distinguishes legacy
2-tuple proxyWidgets entries from new-format entries that carry inline
state, and falls back to the source widget's value for the legacy shape.

Two new vitest cases assert the user-visible symptom directly:

1. After configure() with a legacy 2-tuple proxyWidgets entry and a
   misaligned widgets_values, widget.value reflects the source default
   (42), not the legacy noise (999).
2. After configure() with a misaligned widgets_values whose length doesn't
   match the promoted-view count, the bound widget still reflects the
   source default, not the leaked legacy entry.

Both use it.fails so CI stays green while the bug is present and flips to
failing the moment the inline-proxyWidgets-state fix lands. When that
happens, drop the .fails marker. Verified locally that removing .fails
makes both tests fail with the expected positional-corruption errors
(received 999 / 111, expected 42).

Care taken not to assert serialize-side contracts that conflict with the
existing 'preserves per-instance widget values after configure' / 'round-
trips per-instance widget values' coverage in the same file.
@coderabbitai

coderabbitai Bot commented Apr 27, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 917f1ddf-5f81-4759-8e04-5d8ab3e9bd96

📥 Commits

Reviewing files that changed from the base of the PR and between 1502d3d and 76c6e6e.

📒 Files selected for processing (1)
  • src/lib/litegraph/src/subgraph/SubgraphNode.multiInstance.test.ts
✅ Files skipped from review due to trivial changes (1)
  • src/lib/litegraph/src/subgraph/SubgraphNode.multiInstance.test.ts

📝 Walkthrough

Walkthrough

Adds two failing Vitest regression cases to SubgraphNode.multiInstance.test.ts that pin SubgraphNode.configure behavior around legacy proxyWidgets handling and widgets_values length mismatch; no production code modified. (50 words)

Changes

Cohort / File(s) Summary
SubgraphNode Test Coverage
src/lib/litegraph/src/subgraph/SubgraphNode.multiInstance.test.ts
Adds two it.fails tests: one verifying promoted widget value/serializeValue comes from the source widget when proxyWidgets uses the legacy 2-tuple format; another verifying a promoted widget remains unbound and not overwritten when widgets_values length mismatches view count.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 I nibble keys and test each case,
Legacy tuples hop in place,
Two small tests to guard the gate,
So widgets wake and don't misstate.
Tiny hops keep bugs away!

🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding regression test cases (it.fails) that pin the #10849 promoted-widget-value corruption issue in the subgraph module.
Description check ✅ Passed The description provides comprehensive context: it explains the regression being tested, details both test cases, clarifies the it.fails strategy with rationale, and documents verification steps taken.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed PR title does not use bug-fix language; uses conventional commit type 'test' instead of fix-related keywords.
Adr Compliance For Entity/Litegraph Changes ✅ Passed PR adds test cases to SubgraphNode.multiInstance.test.ts without modifying implementation or introducing problematic ADR patterns.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch glary/subgraph-misaligned-widgets-values-test

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Apr 27, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 04/28/2026, 12:15:00 AM UTC

Links

@github-actions

github-actions Bot commented Apr 27, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1335 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1320 / ❌ 0 / ⚠️ 2 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 12 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

@github-actions

github-actions Bot commented Apr 27, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle: 5.22 MB gzip 🔴 +37 B

Details

Summary

  • Raw size: 24.1 MB baseline 24.1 MB — ⚪ 0 B
  • Gzip: 5.22 MB baseline 5.22 MB — 🔴 +37 B
  • Brotli: 4.04 MB baseline 4.04 MB — 🟢 -250 B
  • Bundles: 255 current • 255 baseline • 116 added / 116 removed

Category Glance
Vendor & Third-Party ⚪ 0 B (9.88 MB) · Other ⚪ 0 B (8.78 MB) · Data & Services ⚪ 0 B (3.03 MB) · Graph Workspace ⚪ 0 B (1.23 MB) · Panels & Settings ⚪ 0 B (484 kB) · Utilities & Hooks ⚪ 0 B (363 kB) · + 5 more

App Entry Points — 22.5 kB (baseline 22.5 kB) • ⚪ 0 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-BqWu4Rb_.js (new) — 22.5 kB 🔴 +22.5 kB 🔴 +7.99 kB 🔴 +6.84 kB
assets/index-Chr-zHCR.js (removed) 22.5 kB — 🟢 -22.5 kB 🟢 -7.99 kB 🟢 -6.88 kB

Status: 1 added / 1 removed

Graph Workspace — 1.23 MB (baseline 1.23 MB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-B808nXD6.js (removed) 1.23 MB — 🟢 -1.23 MB 🟢 -264 kB 🟢 -199 kB
assets/GraphView-Bj6Sc0Uw.js (new) — 1.23 MB 🔴 +1.23 MB 🔴 +264 kB 🔴 +199 kB

Status: 1 added / 1 removed

Views & Navigation — 77.7 kB (baseline 77.7 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CloudSurveyView-BF8aXQdG.js (removed) 15.7 kB — 🟢 -15.7 kB 🟢 -3.41 kB 🟢 -2.91 kB
assets/CloudSurveyView-CwvN_D50.js (new) — 15.7 kB 🔴 +15.7 kB 🔴 +3.41 kB 🔴 +2.92 kB
assets/CloudLoginView-5W_6UNLM.js (removed) 12.2 kB — 🟢 -12.2 kB 🟢 -3.43 kB 🟢 -3.04 kB
assets/CloudLoginView-Tpr6J_t9.js (new) — 12.2 kB 🔴 +12.2 kB 🔴 +3.43 kB 🔴 +3.03 kB
assets/CloudSignupView-BsDIrJ5L.js (new) — 9.94 kB 🔴 +9.94 kB 🔴 +2.93 kB 🔴 +2.57 kB
assets/CloudSignupView-Kn_ylx0L.js (removed) 9.94 kB — 🟢 -9.94 kB 🟢 -2.93 kB 🟢 -2.59 kB
assets/UserCheckView-3NZ_GcuJ.js (new) — 9.07 kB 🔴 +9.07 kB 🔴 +2.33 kB 🔴 +2.05 kB
assets/UserCheckView-Dz1eYZ-x.js (removed) 9.07 kB — 🟢 -9.07 kB 🟢 -2.33 kB 🟢 -2.06 kB
assets/CloudLayoutView-ClWz3JVl.js (removed) 7.7 kB — 🟢 -7.7 kB 🟢 -2.43 kB 🟢 -2.12 kB
assets/CloudLayoutView-DtDtS2jV.js (new) — 7.7 kB 🔴 +7.7 kB 🔴 +2.43 kB 🔴 +2.12 kB
assets/CloudForgotPasswordView-B3UQ98Za.js (removed) 6.11 kB — 🟢 -6.11 kB 🟢 -2.17 kB 🟢 -1.91 kB
assets/CloudForgotPasswordView-D3G6AUA6.js (new) — 6.11 kB 🔴 +6.11 kB 🔴 +2.17 kB 🔴 +1.9 kB
assets/CloudAuthTimeoutView-B3gC68br.js (new) — 5.47 kB 🔴 +5.47 kB 🔴 +2 kB 🔴 +1.75 kB
assets/CloudAuthTimeoutView-CtF0oQio.js (removed) 5.47 kB — 🟢 -5.47 kB 🟢 -2 kB 🟢 -1.75 kB
assets/CloudSubscriptionRedirectView-BByxe9_l.js (new) — 5.25 kB 🔴 +5.25 kB 🔴 +1.98 kB 🔴 +1.77 kB
assets/CloudSubscriptionRedirectView-D9UwSEvB.js (removed) 5.25 kB — 🟢 -5.25 kB 🟢 -1.98 kB 🟢 -1.76 kB
assets/UserSelectView-CDBYe14_.js (removed) 4.73 kB — 🟢 -4.73 kB 🟢 -1.75 kB 🟢 -1.55 kB
assets/UserSelectView-Cjt4Svyi.js (new) — 4.73 kB 🔴 +4.73 kB 🔴 +1.75 kB 🔴 +1.55 kB

Status: 9 added / 9 removed / 2 unchanged

Panels & Settings — 484 kB (baseline 484 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/KeybindingPanel-DnkpASLF.js (new) — 46.7 kB 🔴 +46.7 kB 🔴 +9.6 kB 🔴 +8.53 kB
assets/KeybindingPanel-hhJHz-vi.js (removed) 46.7 kB — 🟢 -46.7 kB 🟢 -9.61 kB 🟢 -8.53 kB
assets/SecretsPanel-1L7Ww9b6.js (removed) 22.9 kB — 🟢 -22.9 kB 🟢 -5.54 kB 🟢 -4.87 kB
assets/SecretsPanel-BsVmO7rR.js (new) — 22.9 kB 🔴 +22.9 kB 🔴 +5.54 kB 🔴 +4.86 kB
assets/LegacyCreditsPanel-CVr7dX6a.js (new) — 21.7 kB 🔴 +21.7 kB 🔴 +5.89 kB 🔴 +5.2 kB
assets/LegacyCreditsPanel-DTCxvHmc.js (removed) 21.7 kB — 🟢 -21.7 kB 🟢 -5.89 kB 🟢 -5.2 kB
assets/SubscriptionPanel-BOArsSA0.js (removed) 19.9 kB — 🟢 -19.9 kB 🟢 -5.06 kB 🟢 -4.46 kB
assets/SubscriptionPanel-fFNqAQD_.js (new) — 19.9 kB 🔴 +19.9 kB 🔴 +5.07 kB 🔴 +4.47 kB
assets/AboutPanel-BD2N3lzN.js (removed) 12 kB — 🟢 -12 kB 🟢 -3.33 kB 🟢 -2.99 kB
assets/AboutPanel-BhsEcz3P.js (new) — 12 kB 🔴 +12 kB 🔴 +3.33 kB 🔴 +2.99 kB
assets/ExtensionPanel-B8NUYaS6.js (new) — 9.94 kB 🔴 +9.94 kB 🔴 +2.9 kB 🔴 +2.56 kB
assets/ExtensionPanel-Sdtf6L6_.js (removed) 9.94 kB — 🟢 -9.94 kB 🟢 -2.9 kB 🟢 -2.58 kB
assets/ServerConfigPanel-BYbDYbwy.js (removed) 7.02 kB — 🟢 -7.02 kB 🟢 -2.35 kB 🟢 -2.09 kB
assets/ServerConfigPanel-DUq-JUnc.js (new) — 7.02 kB 🔴 +7.02 kB 🔴 +2.35 kB 🔴 +2.09 kB
assets/UserPanel-BkpQfBGE.js (removed) 6.73 kB — 🟢 -6.73 kB 🟢 -2.23 kB 🟢 -1.96 kB
assets/UserPanel-W8rHEIvo.js (new) — 6.73 kB 🔴 +6.73 kB 🔴 +2.23 kB 🔴 +1.96 kB
assets/cloudRemoteConfig-CXb-5xjL.js (removed) 2.02 kB — 🟢 -2.02 kB 🟢 -972 B 🟢 -836 B
assets/cloudRemoteConfig-DgUpcA8n.js (new) — 2.02 kB 🔴 +2.02 kB 🔴 +972 B 🔴 +834 B
assets/refreshRemoteConfig-2PkxGnZW.js (removed) 1.45 kB — 🟢 -1.45 kB 🟢 -650 B 🟢 -558 B
assets/refreshRemoteConfig-CyqfnXth.js (new) — 1.45 kB 🔴 +1.45 kB 🔴 +648 B 🔴 +551 B

Status: 10 added / 10 removed / 11 unchanged

User & Accounts — 17.4 kB (baseline 17.4 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/auth-DN7mUr4b.js (new) — 3.57 kB 🔴 +3.57 kB 🔴 +1.26 kB 🔴 +1.07 kB
assets/auth-NyWdPCqU.js (removed) 3.57 kB — 🟢 -3.57 kB 🟢 -1.26 kB 🟢 -1.07 kB
assets/SignUpForm-CES8KfI5.js (new) — 3.16 kB 🔴 +3.16 kB 🔴 +1.28 kB 🔴 +1.14 kB
assets/SignUpForm-LK-9odXv.js (removed) 3.16 kB — 🟢 -3.16 kB 🟢 -1.28 kB 🟢 -1.14 kB
assets/UpdatePasswordContent-j3NzM-Ax.js (new) — 2.87 kB 🔴 +2.87 kB 🔴 +1.29 kB 🔴 +1.14 kB
assets/UpdatePasswordContent-VzVXMdt0.js (removed) 2.87 kB — 🟢 -2.87 kB 🟢 -1.28 kB 🟢 -1.14 kB
assets/authStore-C9qWUR9m.js (removed) 1.16 kB — 🟢 -1.16 kB 🟢 -551 B 🟢 -496 B
assets/authStore-DKqb7VE3.js (new) — 1.16 kB 🔴 +1.16 kB 🔴 +550 B 🔴 +490 B
assets/auth-Bea9yMuL.js (removed) 348 B — 🟢 -348 B 🟢 -218 B 🟢 -192 B
assets/auth-DcNblUkl.js (new) — 348 B 🔴 +348 B 🔴 +218 B 🔴 +207 B

Status: 5 added / 5 removed / 2 unchanged

Editors & Dialogs — 110 kB (baseline 110 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useShareDialog-BLeDD0py.js (removed) 109 kB — 🟢 -109 kB 🟢 -22.5 kB 🟢 -19 kB
assets/useShareDialog-BN3WevNq.js (new) — 109 kB 🔴 +109 kB 🔴 +22.5 kB 🔴 +19 kB
assets/useSubscriptionDialog-9E5nE_56.js (removed) 1.14 kB — 🟢 -1.14 kB 🟢 -542 B 🟢 -479 B
assets/useSubscriptionDialog-BWXNvRDQ.js (new) — 1.14 kB 🔴 +1.14 kB 🔴 +541 B 🔴 +474 B

Status: 2 added / 2 removed

UI Components — 61 kB (baseline 61 kB) • ⚪ 0 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyQueueButton-CZk8n5rJ.js (removed) 13.5 kB — 🟢 -13.5 kB 🟢 -3.79 kB 🟢 -3.38 kB
assets/ComfyQueueButton-eR9PM12b.js (new) — 13.5 kB 🔴 +13.5 kB 🔴 +3.79 kB 🔴 +3.38 kB
assets/useTerminalTabs-BboSCU7q.js (new) — 11 kB 🔴 +11 kB 🔴 +3.71 kB 🔴 +3.27 kB
assets/useTerminalTabs-C0D9n8c3.js (removed) 11 kB — 🟢 -11 kB 🟢 -3.71 kB 🟢 -3.28 kB
assets/SubscribeButton-Bgb7pica.js (removed) 2.42 kB — 🟢 -2.42 kB 🟢 -1.04 kB 🟢 -922 B
assets/SubscribeButton-CqyJ3mQz.js (new) — 2.42 kB 🔴 +2.42 kB 🔴 +1.05 kB 🔴 +943 B
assets/cloudFeedbackTopbarButton-DKka5Eyc.js (new) — 1.8 kB 🔴 +1.8 kB 🔴 +928 B 🔴 +814 B
assets/cloudFeedbackTopbarButton-nejdyyF9.js (removed) 1.8 kB — 🟢 -1.8 kB 🟢 -927 B 🟢 -821 B
assets/ComfyQueueButton-DYSWX88y.js (removed) 1.24 kB — 🟢 -1.24 kB 🟢 -579 B 🟢 -518 B
assets/ComfyQueueButton-IB4eVlzv.js (new) — 1.24 kB 🔴 +1.24 kB 🔴 +580 B 🔴 +516 B

Status: 5 added / 5 removed / 8 unchanged

Data & Services — 3.03 MB (baseline 3.03 MB) • ⚪ 0 B

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/dialogService-DLF-ZrtP.js (removed) 1.97 MB — 🟢 -1.97 MB 🟢 -454 kB 🟢 -344 kB
assets/dialogService-p8EyiIdo.js (new) — 1.97 MB 🔴 +1.97 MB 🔴 +454 kB 🔴 +344 kB
assets/api-Bkla8zBO.js (removed) 894 kB — 🟢 -894 kB 🟢 -214 kB 🟢 -168 kB
assets/api-DfDYgEAo.js (new) — 894 kB 🔴 +894 kB 🔴 +214 kB 🔴 +168 kB
assets/load3dService-CAe4momq.js (new) — 109 kB 🔴 +109 kB 🔴 +23.1 kB 🔴 +19.8 kB
assets/load3dService-CHZROgRo.js (removed) 109 kB — 🟢 -109 kB 🟢 -23.1 kB 🟢 -19.7 kB
assets/workflowShareService-75Q0PUNe.js (removed) 16.6 kB — 🟢 -16.6 kB 🟢 -4.88 kB 🟢 -4.33 kB
assets/workflowShareService-aY8DuC28.js (new) — 16.6 kB 🔴 +16.6 kB 🔴 +4.88 kB 🔴 +4.32 kB
assets/keybindingService-CWB3gmDc.js (removed) 13.8 kB — 🟢 -13.8 kB 🟢 -3.67 kB 🟢 -3.22 kB
assets/keybindingService-D3pfcfgr.js (new) — 13.8 kB 🔴 +13.8 kB 🔴 +3.67 kB 🔴 +3.22 kB
assets/releaseStore-C4s8QaXT.js (removed) 8.12 kB — 🟢 -8.12 kB 🟢 -2.28 kB 🟢 -2 kB
assets/releaseStore-DXYtlPDB.js (new) — 8.12 kB 🔴 +8.12 kB 🔴 +2.28 kB 🔴 +2 kB
assets/userStore-D_u9RuTL.js (removed) 2.24 kB — 🟢 -2.24 kB 🟢 -870 B 🟢 -760 B
assets/userStore-HtqZqwj9.js (new) — 2.24 kB 🔴 +2.24 kB 🔴 +871 B 🔴 +762 B
assets/audioService-bpDl_FLc.js (new) — 1.8 kB 🔴 +1.8 kB 🔴 +874 B 🔴 +759 B
assets/audioService-Dn2xfvqj.js (removed) 1.8 kB — 🟢 -1.8 kB 🟢 -875 B 🟢 -757 B
assets/releaseStore-Bt5qr5Xm.js (new) — 1.16 kB 🔴 +1.16 kB 🔴 +544 B 🔴 +485 B
assets/releaseStore-Cj9vFZtY.js (removed) 1.16 kB — 🟢 -1.16 kB 🟢 -547 B 🟢 -488 B
assets/workflowDraftStore-Bq9UsbUc.js (new) — 1.14 kB 🔴 +1.14 kB 🔴 +539 B 🔴 +477 B
assets/workflowDraftStore-DPsut-WM.js (removed) 1.14 kB — 🟢 -1.14 kB 🟢 -540 B 🟢 -483 B
assets/dialogService-k5vT9rw6.js (new) — 1.13 kB 🔴 +1.13 kB 🔴 +531 B 🔴 +473 B
assets/dialogService-Wm1l1n20.js (removed) 1.13 kB — 🟢 -1.13 kB 🟢 -533 B 🟢 -480 B
assets/settingStore-D45fa8o7.js (removed) 1.12 kB — 🟢 -1.12 kB 🟢 -536 B 🟢 -479 B
assets/settingStore-DP-vHCXq.js (new) — 1.12 kB 🔴 +1.12 kB 🔴 +535 B 🔴 +474 B
assets/assetsStore-ByZcpXnJ.js (removed) 1.12 kB — 🟢 -1.12 kB 🟢 -537 B 🟢 -480 B
assets/assetsStore-Dvl3raeC.js (new) — 1.12 kB 🔴 +1.12 kB 🔴 +535 B 🔴 +475 B

Status: 13 added / 13 removed / 4 unchanged

Utilities & Hooks — 363 kB (baseline 363 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useConflictDetection-CVp4JQZt.js (removed) 233 kB — 🟢 -233 kB 🟢 -51.8 kB 🟢 -42.2 kB
assets/useConflictDetection-CyZg2Nj-.js (new) — 233 kB 🔴 +233 kB 🔴 +51.8 kB 🔴 +42.2 kB
assets/useLoad3d-BvmRO6ah.js (removed) 21.6 kB — 🟢 -21.6 kB 🟢 -4.92 kB 🟢 -4.35 kB
assets/useLoad3d-FkPIiTKn.js (new) — 21.6 kB 🔴 +21.6 kB 🔴 +4.92 kB 🔴 +4.37 kB
assets/useLoad3dViewer-CgGaSt0g.js (removed) 20.2 kB — 🟢 -20.2 kB 🟢 -4.74 kB 🟢 -4.14 kB
assets/useLoad3dViewer-DQTZkUpU.js (new) — 20.2 kB 🔴 +20.2 kB 🔴 +4.74 kB 🔴 +4.14 kB
assets/useFeatureFlags-C6dOko36.js (removed) 5.95 kB — 🟢 -5.95 kB 🟢 -1.8 kB 🟢 -1.53 kB
assets/useFeatureFlags-DTJ9X9iv.js (new) — 5.95 kB 🔴 +5.95 kB 🔴 +1.8 kB 🔴 +1.52 kB
assets/useCopyToClipboard-B5DPIDg3.js (new) — 5.29 kB 🔴 +5.29 kB 🔴 +1.86 kB 🔴 +1.58 kB
assets/useCopyToClipboard-D9D11DjU.js (removed) 5.29 kB — 🟢 -5.29 kB 🟢 -1.86 kB 🟢 -1.58 kB
assets/useWorkspaceUI-2FGNBK9H.js (removed) 3.34 kB — 🟢 -3.34 kB 🟢 -982 B 🟢 -865 B
assets/useWorkspaceUI-Di9aYLVU.js (new) — 3.34 kB 🔴 +3.34 kB 🔴 +981 B 🔴 +810 B
assets/subscriptionCheckoutUtil-L35zAGa0.js (removed) 3.31 kB — 🟢 -3.31 kB 🟢 -1.37 kB 🟢 -1.19 kB
assets/subscriptionCheckoutUtil-mabkbtfh.js (new) — 3.31 kB 🔴 +3.31 kB 🔴 +1.36 kB 🔴 +1.18 kB
assets/assetPreviewUtil-D4nHtifp.js (removed) 2.27 kB — 🟢 -2.27 kB 🟢 -955 B 🟢 -833 B
assets/assetPreviewUtil-OT3JOulg.js (new) — 2.27 kB 🔴 +2.27 kB 🔴 +956 B 🔴 +835 B
assets/useUpstreamValue-C60szs4C.js (new) — 2.08 kB 🔴 +2.08 kB 🔴 +803 B 🔴 +714 B
assets/useUpstreamValue-CwOagsGH.js (removed) 2.08 kB — 🟢 -2.08 kB 🟢 -805 B 🟢 -709 B
assets/useLoad3d-BHPJv4R5.js (removed) 1.3 kB — 🟢 -1.3 kB 🟢 -604 B 🟢 -548 B
assets/useLoad3d-CTLAlNp7.js (new) — 1.3 kB 🔴 +1.3 kB 🔴 +605 B 🔴 +540 B
assets/useLoad3dViewer-B6933yyF.js (removed) 1.24 kB — 🟢 -1.24 kB 🟢 -571 B 🟢 -516 B
assets/useLoad3dViewer-CftDUCKE.js (new) — 1.24 kB 🔴 +1.24 kB 🔴 +571 B 🔴 +511 B
assets/useCurrentUser-DXJ9x_QN.js (new) — 1.12 kB 🔴 +1.12 kB 🔴 +536 B 🔴 +473 B
assets/useCurrentUser-xStCgJro.js (removed) 1.12 kB — 🟢 -1.12 kB 🟢 -537 B 🟢 -480 B
assets/useWorkspaceSwitch-DkzIFQXC.js (removed) 747 B — 🟢 -747 B 🟢 -384 B 🟢 -333 B
assets/useWorkspaceSwitch-DOwnVvaw.js (new) — 747 B 🔴 +747 B 🔴 +384 B 🔴 +323 B

Status: 13 added / 13 removed / 18 unchanged

Vendor & Third-Party — 9.88 MB (baseline 9.88 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 16 unchanged

Other — 8.78 MB (baseline 8.78 MB) • ⚪ 0 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/core-BtOxe7VO.js (removed) 76.6 kB — 🟢 -76.6 kB 🟢 -19.8 kB 🟢 -16.9 kB
assets/core-CxI86Afm.js (new) — 76.6 kB 🔴 +76.6 kB 🔴 +19.8 kB 🔴 +16.9 kB
assets/groupNode-B_tP2WKd.js (removed) 74.9 kB — 🟢 -74.9 kB 🟢 -18.7 kB 🟢 -16.5 kB
assets/groupNode-qR2MKcvV.js (new) — 74.9 kB 🔴 +74.9 kB 🔴 +18.7 kB 🔴 +16.5 kB
assets/WidgetSelect-BxkHGdzD.js (removed) 67.2 kB — 🟢 -67.2 kB 🟢 -14.6 kB 🟢 -12.7 kB
assets/WidgetSelect-DVk30iZP.js (new) — 67.2 kB 🔴 +67.2 kB 🔴 +14.6 kB 🔴 +12.6 kB
assets/SubscriptionRequiredDialogContentWorkspace--mrDeU4l.js (new) — 49.3 kB 🔴 +49.3 kB 🔴 +9.41 kB 🔴 +8.03 kB
assets/SubscriptionRequiredDialogContentWorkspace-DtQgLTUr.js (removed) 49.3 kB — 🟢 -49.3 kB 🟢 -9.41 kB 🟢 -8.04 kB
assets/Load3DControls-Bx0_9soZ.js (removed) 45.9 kB — 🟢 -45.9 kB 🟢 -7.47 kB 🟢 -6.52 kB
assets/Load3DControls-P_9Umeoo.js (new) — 45.9 kB 🔴 +45.9 kB 🔴 +7.46 kB 🔴 +6.53 kB
assets/WidgetPainter-C2DX_nTN.js (removed) 33.9 kB — 🟢 -33.9 kB 🟢 -8.28 kB 🟢 -7.32 kB
assets/WidgetPainter-C4PpNzzV.js (new) — 33.9 kB 🔴 +33.9 kB 🔴 +8.28 kB 🔴 +7.35 kB
assets/WorkspacePanelContent-CiIfKSnG.js (new) — 32.8 kB 🔴 +32.8 kB 🔴 +6.99 kB 🔴 +6.17 kB
assets/WorkspacePanelContent-DL6eJhko.js (removed) 32.8 kB — 🟢 -32.8 kB 🟢 -6.99 kB 🟢 -6.18 kB
assets/Load3dViewerContent-BeQ0hPdO.js (removed) 28.3 kB — 🟢 -28.3 kB 🟢 -5.9 kB 🟢 -5.12 kB
assets/Load3dViewerContent-DgD9hLOA.js (new) — 28.3 kB 🔴 +28.3 kB 🔴 +5.9 kB 🔴 +5.13 kB
assets/SubscriptionRequiredDialogContent-Cs-fD1m2.js (removed) 27.5 kB — 🟢 -27.5 kB 🟢 -6.96 kB 🟢 -6.18 kB
assets/SubscriptionRequiredDialogContent-hRdUZUpD.js (new) — 27.5 kB 🔴 +27.5 kB 🔴 +6.96 kB 🔴 +6.15 kB
assets/WidgetImageCrop-BSDPy7gg.js (new) — 24.3 kB 🔴 +24.3 kB 🔴 +6.18 kB 🔴 +5.45 kB
assets/WidgetImageCrop-Ogbj6EaP.js (removed) 24.3 kB — 🟢 -24.3 kB 🟢 -6.18 kB 🟢 -5.45 kB
assets/SubscriptionPanelContentWorkspace-B8LIO6L4.js (new) — 22.2 kB 🔴 +22.2 kB 🔴 +5.17 kB 🔴 +4.57 kB
assets/SubscriptionPanelContentWorkspace-CPn-uVHL.js (removed) 22.2 kB — 🟢 -22.2 kB 🟢 -5.17 kB 🟢 -4.56 kB
assets/SignInContent-JfkvAlHW.js (new) — 20.6 kB 🔴 +20.6 kB 🔴 +5.36 kB 🔴 +4.67 kB
assets/SignInContent-NchXvENv.js (removed) 20.6 kB — 🟢 -20.6 kB 🟢 -5.35 kB 🟢 -4.68 kB
assets/CurrentUserPopoverWorkspace-CLAJ6G5Q.js (removed) 20.5 kB — 🟢 -20.5 kB 🟢 -4.9 kB 🟢 -4.39 kB
assets/CurrentUserPopoverWorkspace-ZXMBVNEZ.js (new) — 20.5 kB 🔴 +20.5 kB 🔴 +4.9 kB 🔴 +4.38 kB
assets/WidgetInputNumber-CIawPWQO.js (new) — 19.1 kB 🔴 +19.1 kB 🔴 +4.84 kB 🔴 +4.3 kB
assets/WidgetInputNumber-CuXstg2D.js (removed) 19.1 kB — 🟢 -19.1 kB 🟢 -4.84 kB 🟢 -4.29 kB
assets/Load3D-9a33d7Jj.js (new) — 18.2 kB 🔴 +18.2 kB 🔴 +4.34 kB 🔴 +3.79 kB
assets/Load3D-Bg1poYRN.js (removed) 18.2 kB — 🟢 -18.2 kB 🟢 -4.34 kB 🟢 -3.79 kB
assets/WidgetRecordAudio-BxmTWQye.js (removed) 17.4 kB — 🟢 -17.4 kB 🟢 -5 kB 🟢 -4.47 kB
assets/WidgetRecordAudio-CHGKFQUK.js (new) — 17.4 kB 🔴 +17.4 kB 🔴 +5 kB 🔴 +4.47 kB
assets/WidgetRange-B7kQIM1K.js (removed) 17 kB — 🟢 -17 kB 🟢 -4.6 kB 🟢 -4.11 kB
assets/WidgetRange-BzhFbYLX.js (new) — 17 kB 🔴 +17 kB 🔴 +4.6 kB 🔴 +4.11 kB
assets/load3d-B8u0CxYR.js (removed) 15.3 kB — 🟢 -15.3 kB 🟢 -4.41 kB 🟢 -3.82 kB
assets/load3d-CLkNCl4K.js (new) — 15.3 kB 🔴 +15.3 kB 🔴 +4.41 kB 🔴 +3.82 kB
assets/WaveAudioPlayer-BPFR7Nna.js (removed) 13.4 kB — 🟢 -13.4 kB 🟢 -3.69 kB 🟢 -3.23 kB
assets/WaveAudioPlayer-Dqb0RvfG.js (new) — 13.4 kB 🔴 +13.4 kB 🔴 +3.69 kB 🔴 +3.23 kB
assets/WidgetCurve-DAyeJDb6.js (removed) 12.1 kB — 🟢 -12.1 kB 🟢 -3.91 kB 🟢 -3.54 kB
assets/WidgetCurve-I5_lsOiS.js (new) — 12.1 kB 🔴 +12.1 kB 🔴 +3.91 kB 🔴 +3.54 kB
assets/TeamWorkspacesDialogContent-D9FBBYsJ.js (removed) 11.3 kB — 🟢 -11.3 kB 🟢 -3.41 kB 🟢 -3.04 kB
assets/TeamWorkspacesDialogContent-DPwyC5pn.js (new) — 11.3 kB 🔴 +11.3 kB 🔴 +3.4 kB 🔴 +3.03 kB
assets/nodeTemplates-D8LWXiZH.js (new) — 9.81 kB 🔴 +9.81 kB 🔴 +3.47 kB 🔴 +3.06 kB
assets/nodeTemplates-Dr6MSA6e.js (removed) 9.81 kB — 🟢 -9.81 kB 🟢 -3.47 kB 🟢 -3.06 kB
assets/NightlySurveyController-BSJyeJpX.js (new) — 8.99 kB 🔴 +8.99 kB 🔴 +3.15 kB 🔴 +2.77 kB
assets/NightlySurveyController-CzLgR52N.js (removed) 8.99 kB — 🟢 -8.99 kB 🟢 -3.15 kB 🟢 -2.77 kB
assets/InviteMemberDialogContent-C95i2cWN.js (new) — 7.91 kB 🔴 +7.91 kB 🔴 +2.51 kB 🔴 +2.21 kB
assets/InviteMemberDialogContent-Do_dA4Am.js (removed) 7.91 kB — 🟢 -7.91 kB 🟢 -2.51 kB 🟢 -2.22 kB
assets/Load3DConfiguration-BMpGqJJc.js (removed) 7.82 kB — 🟢 -7.82 kB 🟢 -2.31 kB 🟢 -2.02 kB
assets/Load3DConfiguration-D6heUNAR.js (new) — 7.82 kB 🔴 +7.82 kB 🔴 +2.31 kB 🔴 +2.02 kB
assets/onboardingCloudRoutes-DAkJQdUK.js (removed) 6.58 kB — 🟢 -6.58 kB 🟢 -2.06 kB 🟢 -1.76 kB
assets/onboardingCloudRoutes-DyFDcUVx.js (new) — 6.58 kB 🔴 +6.58 kB 🔴 +2.05 kB 🔴 +1.76 kB
assets/CreateWorkspaceDialogContent-CSVz1JBJ.js (new) — 6.12 kB 🔴 +6.12 kB 🔴 +2.22 kB 🔴 +1.94 kB
assets/CreateWorkspaceDialogContent-DJ1Hlcr9.js (removed) 6.12 kB — 🟢 -6.12 kB 🟢 -2.22 kB 🟢 -1.95 kB
assets/WidgetWithControl-BMFXhNqQ.js (removed) 6.02 kB — 🟢 -6.02 kB 🟢 -2.4 kB 🟢 -2.15 kB
assets/WidgetWithControl-DsV-VFt1.js (new) — 6.02 kB 🔴 +6.02 kB 🔴 +2.4 kB 🔴 +2.15 kB
assets/FreeTierDialogContent-CN357rbq.js (new) — 5.99 kB 🔴 +5.99 kB 🔴 +2.12 kB 🔴 +1.88 kB
assets/FreeTierDialogContent-CPmLz3nI.js (removed) 5.99 kB — 🟢 -5.99 kB 🟢 -2.12 kB 🟢 -1.88 kB
assets/EditWorkspaceDialogContent-CfH5Gm5S.js (new) — 5.92 kB 🔴 +5.92 kB 🔴 +2.18 kB 🔴 +1.92 kB
assets/EditWorkspaceDialogContent-nHNRTz0q.js (removed) 5.92 kB — 🟢 -5.92 kB 🟢 -2.18 kB 🟢 -1.92 kB
assets/WidgetTextarea-c7jIB1lq.js (new) — 5.73 kB 🔴 +5.73 kB 🔴 +2.26 kB 🔴 +1.99 kB
assets/WidgetTextarea-DCCMO2w8.js (removed) 5.73 kB — 🟢 -5.73 kB 🟢 -2.25 kB 🟢 -1.99 kB
assets/Preview3d-BQZl90jL.js (removed) 5.56 kB — 🟢 -5.56 kB 🟢 -1.87 kB 🟢 -1.64 kB
assets/Preview3d-DC1TyP0j.js (new) — 5.56 kB 🔴 +5.56 kB 🔴 +1.87 kB 🔴 +1.65 kB
assets/ValueControlPopover-BsFOp9o3.js (new) — 5.5 kB 🔴 +5.5 kB 🔴 +2 kB 🔴 +1.8 kB
assets/ValueControlPopover-BVDUjHqa.js (removed) 5.5 kB — 🟢 -5.5 kB 🟢 -2 kB 🟢 -1.78 kB
assets/CancelSubscriptionDialogContent-DwQj2zji.js (removed) 5.46 kB — 🟢 -5.46 kB 🟢 -2.04 kB 🟢 -1.79 kB
assets/CancelSubscriptionDialogContent-kRplRYQT.js (new) — 5.46 kB 🔴 +5.46 kB 🔴 +2.04 kB 🔴 +1.79 kB
assets/DeleteWorkspaceDialogContent-C-kwY7BE.js (new) — 4.82 kB 🔴 +4.82 kB 🔴 +1.86 kB 🔴 +1.62 kB
assets/DeleteWorkspaceDialogContent-lnqfcUzj.js (removed) 4.82 kB — 🟢 -4.82 kB 🟢 -1.86 kB 🟢 -1.62 kB
assets/LeaveWorkspaceDialogContent-D2eHGv9-.js (new) — 4.65 kB 🔴 +4.65 kB 🔴 +1.8 kB 🔴 +1.58 kB
assets/LeaveWorkspaceDialogContent-MrXcaSwZ.js (removed) 4.65 kB — 🟢 -4.65 kB 🟢 -1.8 kB 🟢 -1.57 kB
assets/RemoveMemberDialogContent-BpEE-4_d.js (removed) 4.63 kB — 🟢 -4.63 kB 🟢 -1.76 kB 🟢 -1.54 kB
assets/RemoveMemberDialogContent-C8pgHVCG.js (new) — 4.63 kB 🔴 +4.63 kB 🔴 +1.76 kB 🔴 +1.54 kB
assets/RevokeInviteDialogContent-DpvQHef2.js (removed) 4.54 kB — 🟢 -4.54 kB 🟢 -1.77 kB 🟢 -1.56 kB
assets/RevokeInviteDialogContent-eq1Dn9lJ.js (new) — 4.54 kB 🔴 +4.54 kB 🔴 +1.77 kB 🔴 +1.55 kB
assets/tierBenefits-Dwu72Uf0.js (new) — 4.45 kB 🔴 +4.45 kB 🔴 +1.57 kB 🔴 +1.36 kB
assets/tierBenefits-VvXdN2em.js (removed) 4.45 kB — 🟢 -4.45 kB 🟢 -1.57 kB 🟢 -1.36 kB
assets/InviteMemberUpsellDialogContent-2EU3rE2b.js (removed) 4.44 kB — 🟢 -4.44 kB 🟢 -1.63 kB 🟢 -1.43 kB
assets/InviteMemberUpsellDialogContent-CjftMy-8.js (new) — 4.44 kB 🔴 +4.44 kB 🔴 +1.64 kB 🔴 +1.44 kB
assets/cloudSessionCookie-BieZVnJP.js (removed) 4.28 kB — 🟢 -4.28 kB 🟢 -1.56 kB 🟢 -1.36 kB
assets/cloudSessionCookie-BkykZ4g3.js (new) — 4.28 kB 🔴 +4.28 kB 🔴 +1.56 kB 🔴 +1.36 kB
assets/saveMesh-BKGN1kxq.js (new) — 4.12 kB 🔴 +4.12 kB 🔴 +1.77 kB 🔴 +1.56 kB
assets/saveMesh-Ds3jaeFC.js (removed) 4.12 kB — 🟢 -4.12 kB 🟢 -1.77 kB 🟢 -1.56 kB
assets/Media3DTop-BVcWPo-g.js (removed) 4.01 kB — 🟢 -4.01 kB 🟢 -1.69 kB 🟢 -1.49 kB
assets/Media3DTop-eN2jro1i.js (new) — 4.01 kB 🔴 +4.01 kB 🔴 +1.69 kB 🔴 +1.49 kB
assets/GlobalToast-iRhXefGB.js (new) — 3.05 kB 🔴 +3.05 kB 🔴 +1.26 kB 🔴 +1.1 kB
assets/GlobalToast-JUEQGvFu.js (removed) 3.05 kB — 🟢 -3.05 kB 🟢 -1.26 kB 🟢 -1.08 kB
assets/CloudRunButtonWrapper-BDAhxtit.js (removed) 2.2 kB — 🟢 -2.2 kB 🟢 -1 kB 🟢 -895 B
assets/CloudRunButtonWrapper-CKL72A_u.js (new) — 2.2 kB 🔴 +2.2 kB 🔴 +1 kB 🔴 +894 B
assets/SubscribeToRun-CxkF9LTD.js (removed) 2.13 kB — 🟢 -2.13 kB 🟢 -980 B 🟢 -878 B
assets/SubscribeToRun-eJh633xR.js (new) — 2.13 kB 🔴 +2.13 kB 🔴 +981 B 🔴 +884 B
assets/MediaAudioTop-BoW69GcO.js (new) — 2.08 kB 🔴 +2.08 kB 🔴 +1.01 kB 🔴 +863 B
assets/MediaAudioTop-CnIyLmHn.js (removed) 2.08 kB — 🟢 -2.08 kB 🟢 -1 kB 🟢 -859 B
assets/cloudBadges-Cko51Bmi.js (removed) 1.93 kB — 🟢 -1.93 kB 🟢 -959 B 🟢 -835 B
assets/cloudBadges-Dz9ucvEe.js (new) — 1.93 kB 🔴 +1.93 kB 🔴 +960 B 🔴 +831 B
assets/cloudSubscription-B4RrdYZu.js (removed) 1.85 kB — 🟢 -1.85 kB 🟢 -882 B 🟢 -766 B
assets/cloudSubscription-BT7BvD8X.js (new) — 1.85 kB 🔴 +1.85 kB 🔴 +883 B 🔴 +763 B
assets/graphHasMissingNodes-BHEAit1C.js (removed) 1.84 kB — 🟢 -1.84 kB 🟢 -859 B 🟢 -760 B
assets/graphHasMissingNodes-BP2ZqvX4.js (new) — 1.84 kB 🔴 +1.84 kB 🔴 +859 B 🔴 +758 B
assets/Load3D-BlNdaYrB.js (new) — 1.55 kB 🔴 +1.55 kB 🔴 +696 B 🔴 +620 B
assets/Load3D-DaLZVKTz.js (removed) 1.55 kB — 🟢 -1.55 kB 🟢 -694 B 🟢 -624 B
assets/previousFullPath-BO32pnsH.js (new) — 1.53 kB 🔴 +1.53 kB 🔴 +693 B 🔴 +595 B
assets/previousFullPath-CUx7rXXw.js (removed) 1.53 kB — 🟢 -1.53 kB 🟢 -693 B 🟢 -600 B
assets/nightlyBadges-CdCVc_mx.js (removed) 1.46 kB — 🟢 -1.46 kB 🟢 -730 B 🟢 -670 B
assets/nightlyBadges-DiVQiE5A.js (new) — 1.46 kB 🔴 +1.46 kB 🔴 +726 B 🔴 +662 B
assets/Load3dViewerContent-1anfwpyi.js (new) — 1.43 kB 🔴 +1.43 kB 🔴 +649 B 🔴 +574 B
assets/Load3dViewerContent-CR890Zxv.js (removed) 1.43 kB — 🟢 -1.43 kB 🟢 -647 B 🟢 -597 B
assets/SubscriptionPanelContentWorkspace-B92hw5qO.js (removed) 1.32 kB — 🟢 -1.32 kB 🟢 -601 B 🟢 -528 B
assets/SubscriptionPanelContentWorkspace-h8TAZM3d.js (new) — 1.32 kB 🔴 +1.32 kB 🔴 +601 B 🔴 +524 B
assets/WidgetLegacy-CvHZsVwT.js (removed) 1.15 kB — 🟢 -1.15 kB 🟢 -548 B 🟢 -490 B
assets/WidgetLegacy-DhXLpRTm.js (new) — 1.15 kB 🔴 +1.15 kB 🔴 +548 B 🔴 +484 B
assets/changeTracker-Bs9SodSd.js (new) — 1.12 kB 🔴 +1.12 kB 🔴 +536 B 🔴 +467 B
assets/changeTracker-CtVLc6E4.js (removed) 1.12 kB — 🟢 -1.12 kB 🟢 -536 B 🟢 -473 B

Status: 57 added / 57 removed / 78 unchanged

⚡ Performance

⏳ Performance tests in progress…

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/lib/litegraph/src/subgraph/SubgraphNode.multiInstance.test.ts (1)

262-272: Trim the multi-line regression commentary block.

This comment block is verbose and duplicates intent already captured by the test names and PR description.

✂️ Proposed cleanup
-  // Pins the open `#10849` regression: the post-#10849 SubgraphNode.configure
-  // applies `widgets_values` positionally to promoted widgets, which corrupts
-  // pre-#10849 templates (e.g. Z-Image-Turbo) where `widgets_values` was
-  // leftover from older serialization and never represented promoted-widget
-  // values. The fix on the unmerged inline-proxyWidgets-state branch
-  // distinguishes legacy entries (plain 2-tuples) from new-format entries
-  // (entries carrying inline state), and falls back to the source widget's
-  // value for the legacy shape.
-  //
-  // Uses it.fails so the suite stays green while the bug is present and
-  // flips to failing when the fix lands. Drop the `.fails` marker then.
   it.fails('falls back to source widget value when proxyWidgets is in legacy 2-tuple shape (regression for `#10849`)', () => {

As per coding guidelines: "Avoid new usage of code comments; do not add or retain redundant comments."

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/lib/litegraph/src/subgraph/SubgraphNode.multiInstance.test.ts` around
lines 262 - 272, Remove or significantly shorten the long multi-line regression
commentary in SubgraphNode.multiInstance.test.ts that duplicates the test name
and PR description; keep a single concise sentence referencing the regression
and the related symbol SubgraphNode.configure (and optionally note the it.fails
marker) so the intent remains clear without redundant detail. Locate the block
at the top of the test (the multi-line comment describing post-#10849 behavior
and the inline-proxyWidgets-state fix) and replace it with a one-line summary
like "Regression test for SubgraphNode.configure applying widgets_values
positionally; retains it.fails until the fix is merged." Ensure the trimmed
comment still mentions the it.fails behavior and the affected symbol
SubgraphNode.configure.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/lib/litegraph/src/subgraph/SubgraphNode.multiInstance.test.ts`:
- Around line 262-272: Remove or significantly shorten the long multi-line
regression commentary in SubgraphNode.multiInstance.test.ts that duplicates the
test name and PR description; keep a single concise sentence referencing the
regression and the related symbol SubgraphNode.configure (and optionally note
the it.fails marker) so the intent remains clear without redundant detail.
Locate the block at the top of the test (the multi-line comment describing
post-#10849 behavior and the inline-proxyWidgets-state fix) and replace it with
a one-line summary like "Regression test for SubgraphNode.configure applying
widgets_values positionally; retains it.fails until the fix is merged." Ensure
the trimmed comment still mentions the it.fails behavior and the affected symbol
SubgraphNode.configure.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 079a9bfc-0a58-493e-85a1-9f8ff6c920a8

📥 Commits

Reviewing files that changed from the base of the PR and between 8dcadd6 and 1502d3d.

📒 Files selected for processing (1)
  • src/lib/litegraph/src/subgraph/SubgraphNode.multiInstance.test.ts

coderabbitai[bot]
coderabbitai Bot previously approved these changes Apr 27, 2026
@codecov

codecov Bot commented Apr 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@             Coverage Diff             @@
##             main   #11697       +/-   ##
===========================================
- Coverage   69.16%   51.14%   -18.03%     
===========================================
  Files        1481     1372      -109     
  Lines       84169    70239    -13930     
  Branches    22361    19551     -2810     
===========================================
- Hits        58219    35921    -22298     
- Misses      25004    33720     +8716     
+ Partials      946      598      -348     
Flag Coverage Δ
e2e ?
unit 51.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1002 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DrJKL DrJKL assigned dante01yoon and unassigned dante01yoon Apr 27, 2026
@DrJKL
DrJKL requested review from dante01yoon and jaeone94 April 27, 2026 23:06
@DrJKL DrJKL assigned jaeone94 and unassigned dante01yoon and jaeone94 Apr 27, 2026
@DrJKL
DrJKL requested review from AustinMroz April 27, 2026 23:06

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the current draft head. I did not find actionable inline issues; the added it.fails cases exercise the intended #10849 load-time regression, and the focused Vitest file passes on the PR head.

@dante01yoon dante01yoon assigned DrJKL and unassigned dante01yoon Apr 28, 2026
@dante01yoon
dante01yoon removed their request for review April 28, 2026 00:04
@DrJKL
DrJKL marked this pull request as ready for review April 28, 2026 00:13
@DrJKL
DrJKL requested a review from a team April 28, 2026 00:13
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 28, 2026
@DrJKL
DrJKL added this pull request to the merge queue Apr 28, 2026
@jaeone94 jaeone94 removed their assignment Apr 28, 2026
Merged via the queue into main with commit 95e9a94 Apr 28, 2026
46 checks passed
@DrJKL
DrJKL deleted the glary/subgraph-misaligned-widgets-values-test branch April 28, 2026 00:27
pull Bot pushed a commit to Mu-L/ComfyUI_frontend that referenced this pull request May 1, 2026
…moted widget values) (Comfy-Org#11790)

## Summary

Reverts Comfy-Org#10849 (per-instance promoted widget value storage) and its
companion test-pinning PR Comfy-Org#11697. The fix in Comfy-Org#10849 caused regressions
in promoted-widget serialization (notably the Z-Image-Turbo template,
see Comfy-Org#10146 follow-up). A replacement fix is being developed on
`fix/subgraph-promoted-widget-inline-state` and will land separately.

## Changes

- **Revert Comfy-Org#11697** — drops the `it.fails`-marked tests that pin the
Comfy-Org#10849 corruption symptom. With Comfy-Org#10849 reverted, those markers would
falsely flip to passing.
- **Revert Comfy-Org#10849** — removes per-instance `_instanceWidgetValues` map,
`_pendingWidgetsValues` configure-time hydration, the `widgets_values`
write path in `SubgraphNode.serialize()`, the `sourceSerialize` field on
`PromotedWidgetView`, the multi-instance Vitest suite, and the
multi-instance E2E test + asset.
- **Conflict resolution** in
`browser_tests/tests/subgraph/subgraphSerialization.spec.ts`: kept the
restored test coverage from Comfy-Org#11579 (which is post-Comfy-Org#10849 on main) and
removed only the now-unreachable multi-instance test, its helper, and
its workflow constant. Auto-merge with Comfy-Org#11698 (`incrementVersion`) and
Comfy-Org#11699 (ID type aliases) was clean.

## Review Focus

- Confirm no other on-main code path has come to depend on
`PromotedWidgetView.sourceSerialize` or
`SubgraphNode._instanceWidgetValues` since Comfy-Org#10849 (grep is clean
locally).
- Confirm we want to land this revert before the replacement fix on
`fix/subgraph-promoted-widget-inline-state` is ready — this leaves the
original Comfy-Org#10146 (multi-instance widget value collision) unfixed in the
meantime.
- The retained Comfy-Org#11579 test coverage now exercises pre-Comfy-Org#10849 behavior;
some of those assertions were written expecting the Comfy-Org#10849 code path. CI
will surface any that need adjustment.

┆Issue is synchronized with this [Notion
page](https://app.notion.com/p/PR-11790-revert-roll-back-10849-11697-per-instance-promoted-widget-values-3536d73d3650814094abd58b6b712d8d)
by [Unito](https://www.unito.io)
dante01yoon added a commit that referenced this pull request May 9, 2026
… promoted widget values) (#11790) (#12098)

*PR Created by the Glary-Bot Agent*

---

## Summary

Backport of #11790 onto `cloud/1.43`. Reverts #10849 (per-instance
promoted widget value storage) and its companion test-pinning PR #11697.

**Why this is needed on `cloud/1.43`:** Glary-Bot's consolidated
backport (#11926) cherry-picked #10849 into `cloud/1.43` on May 5 — four
days *after* the same change was reverted on `main` in #11790. The audit
didn't surface the upstream revert. As a result, `cloud/1.43` (1.43.16)
currently ships the buggy #10849 implementation while `main` / nightly
(1.45.1) doesn't. This is the cause of the Hub
`rob_realistic_2k_images_quick_variations` model/vae/clip mixup
regression reported in `#bug-dump`; the same template renders correctly
on nightly.

After this lands, `cloud/1.43` and `main` will be on the same code path
for promoted-widget serialization. The replacement fix (#11811 with
`_pendingWidgetsValuesReplay`) will land separately on `main` and can be
backported afterward.

## Changes

Mirrors the upstream revert of #10849 + #11697:
- Removes `_instanceWidgetValues` map, `_pendingWidgetsValues`
hydration, and the `widgets_values` write path in
`SubgraphNode.serialize()`
- Removes `sourceSerialize` field on `PromotedWidgetView`
- Removes the multi-instance Vitest suite
(`SubgraphNode.multiInstance.test.ts`) and the multi-instance E2E test +
workflow asset

## Conflict Resolution

Two conflicts surfaced (vs the original revert, which conflict-resolved
against #11579 on `main`):

1. **`browser_tests/tests/subgraph/subgraphSerialization.spec.ts`** —
`cloud/1.43` does not have the #11579 expanded test coverage (`Duplicate
ID Remapping`, `Legacy Prefixed proxyWidget Normalization`) that the
original revert preserved. Took the `cloud/1.43` HEAD structure and
removed only the now-unreachable multi-instance test, its helper
`getPromotedHostWidgetValues`, and the unused `ComfyPage` import.
2.
**`src/lib/litegraph/src/subgraph/SubgraphNode.multiInstance.test.ts`**
— `modify/delete` (file was present on `cloud/1.43`'s #10849 backport,
deleted by the revert). Resolved by removing the file, matching the
revert.

## Verification

**Static analysis & tests:**
- `pnpm typecheck` — clean
- `pnpm typecheck:browser` — clean
- `pnpm exec eslint` on all changed files — clean
- `pnpm test:unit -- --run subgraph` — 506 tests passing across 34
suites (`SubgraphNode.test.ts`, `promotedWidgetView.test.ts`,
`subgraphNodePromotion.test.ts`, etc.)

**Manual verification (Playwright + local dev server):**
- Started ComfyUI backend (`--cpu --port 8188`) and `pnpm dev` frontend;
loaded the page successfully.
- Loaded `subgraph-with-multiple-promoted-widgets.json` — subgraph node
hydrated with 2 promoted widgets.
- Set distinct values on each promoted widget (`first-promoted-value`,
`second-promoted-value`), serialized via `app.graph.serialize()`, and
reloaded via `app.loadGraphData(...)`. Both values round-tripped
correctly to the right widget slots — confirming the revert restores the
working single-instance path that nightly currently ships.
- Hub-fetched template (`rob_realistic_2k_images_quick_variations`)
could not be reproduced locally — `comfy.org/workflows/...` API returns
404 to anonymous curl from the sandbox, and the Hub UI flow needs auth
wired up. The team has already confirmed this template renders correctly
on nightly, which ships this same revert.

## Note on Oracle Review

Oracle flagged the multi-instance regression and the cloud/1.43
forward-compat trade-off as "critical." These describe the *intended*
behavior of this revert — the team has consciously chosen the legacy
clobber path over #10849's broken per-instance code while the
replacement (#11811) is finalized on `main`. Both findings are accepted
trade-offs, not blockers.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-12098-backport-cloud-1-43-revert-roll-back-10849-11697-per-instance-promoted-widget-va-35b6d73d36508109a715fc9d3428a294)
by [Unito](https://www.unito.io)

Co-authored-by: Alexander Brown <drjkl@comfy.org>
dante01yoon pushed a commit that referenced this pull request Jul 27, 2026
…ails (#11697)

*PR Created by the Glary-Bot Agent*

---

## Summary

#11579 restored *categorical* test coverage for subgraph serialization
but didn't reproduce the specific Z-Image-Turbo regression introduced by
#10849 — pre-#10849 templates whose `widgets_values` is leftover noise
get corrupted on load because the new code applies that array
positionally to promoted widget views.

This PR adds two **vitest** cases that pin the user-visible symptom
directly: after loading a misaligned legacy payload, the promoted widget
value should reflect the source default, not the legacy
`widgets_values[i]`.

Both use `it.fails` so the suite stays green while the bug is present
and flips to failing the moment the fix on
`fix/subgraph-promoted-widget-inline-state` lands.

## Tests

1. `falls back to source widget value when proxyWidgets is in legacy
2-tuple shape` — configure() with `proxyWidgets: [['-1', 'widget']]` +
`widgets_values: [999]` should leave the widget at the source default
(42), not 999.
2. `does not corrupt unbound promoted widgets when widgets_values length
mismatches view count` — same shape with longer/wrong-length array.

## Verification

- All 8 cases in the file pass under `it.fails` (CI green).
- Removing `.fails` locally produces the expected failures: `expected
42, received 999` and `expected 42, received 111` — confirming both
tests catch the regression.
- `pnpm typecheck`, `pnpm exec eslint`, `pnpm exec oxlint` all clean.

## Why `it.fails` and not plain failing tests

The actual fix (`fix/subgraph-promoted-widget-inline-state`) is
unmerged. Landing genuinely-failing tests on main would break CI for
everyone. `it.fails` documents the bug runnably, keeps CI green, and
signals when the fix lands so the marker can be dropped.

## Why these assertions, not "widgets_values must be undefined"

A first draft asserted that `serialize()` should not write
`widgets_values` at all. That conflicts with existing coverage in the
same file (`preserves per-instance widget values after configure`,
`round-trips per-instance widget values`) which deliberately uses
`widgets_values` for round-trip persistence. These rewritten assertions
target the load-time corruption symptom directly without contradicting
the per-instance contract — feedback from Oracle review.

## Coordination

Mirrors the failing tests already on commit `6a982675e` of the unmerged
`fix/subgraph-promoted-widget-inline-state` branch, with the addition of
`.fails` markers and a clarifying comment so they can land on main
first.

Follow-up to #11579.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-11697-test-subgraph-pin-10849-promoted-widget-value-corruption-with-it-fails-34f6d73d365081d7a04dcf48ebeceafe)
by [Unito](https://www.unito.io)

---------

Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
dante01yoon pushed a commit that referenced this pull request Jul 27, 2026
…s) (#11790)

## Summary

Reverts #10849 (per-instance promoted widget value storage) and its
companion test-pinning PR #11697. The fix in #10849 caused regressions
in promoted-widget serialization (notably the Z-Image-Turbo template,
see #10146 follow-up). A replacement fix is being developed on
`fix/subgraph-promoted-widget-inline-state` and will land separately.

## Changes

- **Revert #11697** — drops the `it.fails`-marked tests that pin the
#10849 corruption symptom. With #10849 reverted, those markers would
falsely flip to passing.
- **Revert #10849** — removes per-instance `_instanceWidgetValues` map,
`_pendingWidgetsValues` configure-time hydration, the `widgets_values`
write path in `SubgraphNode.serialize()`, the `sourceSerialize` field on
`PromotedWidgetView`, the multi-instance Vitest suite, and the
multi-instance E2E test + asset.
- **Conflict resolution** in
`browser_tests/tests/subgraph/subgraphSerialization.spec.ts`: kept the
restored test coverage from #11579 (which is post-#10849 on main) and
removed only the now-unreachable multi-instance test, its helper, and
its workflow constant. Auto-merge with #11698 (`incrementVersion`) and
#11699 (ID type aliases) was clean.

## Review Focus

- Confirm no other on-main code path has come to depend on
`PromotedWidgetView.sourceSerialize` or
`SubgraphNode._instanceWidgetValues` since #10849 (grep is clean
locally).
- Confirm we want to land this revert before the replacement fix on
`fix/subgraph-promoted-widget-inline-state` is ready — this leaves the
original #10146 (multi-instance widget value collision) unfixed in the
meantime.
- The retained #11579 test coverage now exercises pre-#10849 behavior;
some of those assertions were written expecting the #10849 code path. CI
will surface any that need adjustment.

┆Issue is synchronized with this [Notion
page](https://app.notion.com/p/PR-11790-revert-roll-back-10849-11697-per-instance-promoted-widget-values-3536d73d3650814094abd58b6b712d8d)
by [Unito](https://www.unito.io)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants