Skip to content

fix: restore SubgraphNode.widgets_values dead-field invariant (#10849 regression) - #11559

Closed
dante01yoon wants to merge 18 commits into
mainfrom
fix/subgraph-promoted-widget-inline-state
Closed

dante01yoon wants to merge 18 commits into
mainfrom
fix/subgraph-promoted-widget-inline-state

Conversation

@dante01yoon

@dante01yoon dante01yoon commented Apr 23, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • PR fix: store promoted widget values per SubgraphNode instance #10849 introduced positional widgets_values round-trip on SubgraphNode, corrupting pre-existing templates (for example Z-Image-Turbo) whose widgets_values was never produced by the promoted-widget save path.
  • Inline per-instance promoted-widget values into each proxyWidgets entry so identity and value travel together through reorder, null-entry filtering, clipboard paste, subgraph dedup, nested-pack ID remap, and sibling instance fallback paths.
  • Restore the pre-fix: store promoted widget values per SubgraphNode instance #10849 invariant that SubgraphNode.widgets_values is a dead field. Subgraph instances now serialize promoted values only through inline proxyWidgets state.

Reported: Slack thread

Root Cause

Pre-#10849, PromotedWidgetView.serialize = false and SubgraphNode never set serialize_widgets, so widgets_values on a SubgraphNode was a dead field. Saved templates could carry arbitrary stale content there without affecting runtime.

PR #10849 started writing widgets_values positionally from _getPromotedViews().filter(v => v.sourceSerialize) and reading it back positionally in _internalConfigureAfterSlots. Pre-existing templates can have widgets_values arrays that do not align with current promoted-view order, so the new loader applied stale values to the wrong slots.

Design

The chosen regression-fix format keeps promotion identity and per-instance value in the same existing proxyWidgets record:

// 4-tuple: [sourceNodeId, sourceWidgetName, disambiguator | null, { value }]

This avoids a broader migration of the clipboard, subgraph-dedup, and nested-pack ID-remap paths in this PR while making save/load robust against promoted-view reorder.

Important implementation details:

  • cloneWidgetValue now uses structuredClone without a raw-reference fallback, so uncloneable mutable values fail loudly instead of sharing references across instances.
  • Inline { value } state rejects explicit undefined; missing inline state remains represented by the 2/3-tuple forms.
  • Aligned legacy widgets_values from v1.44.5-7 are migrated into scoped inline state on load. Mismatched legacy arrays are not applied and now warn in DEV.
  • SubgraphNode suppresses widgets_values through LGraphNode.getSerializableWidgetsValues() instead of deleting the serialized field after super.serialize().
  • PromotedWidgetView.value writes scoped per-instance state only. It no longer mutates the source widget's .value.

Migration / Extension Notes

  • Pre-fix: store promoted widget values per SubgraphNode instance #10849 templates, including Z-Image-Turbo: stale or mismatched widgets_values are not applied to promoted-widget state, so inner widget defaults remain intact.
  • v1.44.5-7 workflows with aligned positional values: values migrate into inline proxyWidgets state on load and are re-saved there.
  • Forward compatibility: workflows saved by this PR contain 4-tuple proxyWidgets entries. Opening those workflows in pre-merge frontends can drop promotions for that SubgraphNode. If cross-version sharing is a release requirement, a tolerant-schema patch release against v1.44.x is needed before this ships.
  • Extension behavior: promoted-widget writes now update the instance-scoped promoted widget state, not the source widget's .value. Extensions that need per-instance state should read/write the promoted widget or widgetValueStore; the source widget remains the definition/default fallback.

Follow-Up Issues

Verification

  • CI red on the test-only commit that reproduced the original corruption.
  • CI green on the original fix commit for Unit and E2E.
  • Latest review-fix round:
    • pnpm test:unit -- src/lib/litegraph/src/subgraph/SubgraphNode.multiInstance.test.ts src/lib/litegraph/src/LGraphNode.test.ts
    • pnpm typecheck
    • pnpm format:check
    • pnpm exec oxlint src/core/graph/subgraph/promotedWidgetView.ts src/lib/litegraph/src/LGraphNode.ts src/lib/litegraph/src/subgraph/SubgraphNode.ts src/lib/litegraph/src/subgraph/SubgraphNode.multiInstance.test.ts
    • commit hook: oxfmt, oxlint, eslint, typecheck
    • push hook: pnpm knip

Video

Screen.Recording.2026-04-28.at.12.06.02.PM.mov

…10849)

Reproduces the Z-Image-Turbo regression: SubgraphNode.serialize writes
widgets_values and SubgraphNode.configure applies it positionally to
promoted widgets, corrupting pre-existing templates whose widgets_values
was never produced by the promoted-widget save path.

Both tests assert the pre-#10849 invariant that widgets_values on a
SubgraphNode must remain a dead field.
@coderabbitai

coderabbitai Bot commented Apr 23, 2026 •

Copy link
Copy Markdown
Contributor

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Promoted-widget per-instance values are moved into properties.proxyWidgets and widgets_values is no longer emitted. PromotedWidgetView gains instanceKey and restorePerInstanceValue. SubgraphNode reads inline values during configure, restores them to promoted views, and serializes proxyWidgets with per-instance state.

Changes

Cohort / File(s) Summary
Tests — multi-instance & promotion
src/lib/litegraph/src/subgraph/SubgraphNode.multiInstance.test.ts, src/core/graph/subgraph/promotedWidgetView.test.ts, src/core/graph/subgraph/subgraphNodePromotion.test.ts
Updated expectations to embed per-instance promoted values in properties.proxyWidgets (expanded tuple with trailing { value }) and assert serialize() does not emit widgets_values, including a backward-compatibility configure/serialize case.
Promoted widget types & view
src/core/graph/subgraph/promotedWidgetTypes.ts, src/core/graph/subgraph/promotedWidgetView.ts
Added instanceKey: string to PromotedWidgetView and a restorePerInstanceValue(value) method; made _instanceKey a public instanceKey getter; added logic to seed per-instance widget values and write shared widget-store state without invoking normal setter side effects.
Subgraph serialization & configuration
src/lib/litegraph/src/subgraph/SubgraphNode.ts
configure now parses properties.proxyWidgets for inline { value } payloads into a pending map keyed by promotion identity; after promoted views are created, calls restorePerInstanceValue per instance; serialize() bundles per-instance state into properties.proxyWidgets entries and removes widgets_values.
Schema validation
src/core/schemas/promotionSchema.ts
Extended Zod union to accept a 4-element proxyWidgets tuple: `[string, string, string
Browser test asset
browser_tests/assets/subgraphs/subgraph-multi-instance-promoted-text-values.json
Replaced legacy widgets_values usage with properties.proxyWidgets entries embedding promoted text values as ["10", "text", null, { "value": "<text>\n" }].

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Client
  participant SubgraphNode
  participant PromotedView
  participant Serializer
  Client->>SubgraphNode: request serialize()
  SubgraphNode->>PromotedView: query promotion identity / instanceKey
  PromotedView-->>SubgraphNode: return instanceKey and per-instance state (if any)
  alt has per-instance value
    SubgraphNode->>Serializer: emit proxyWidgets entry [id, name, null, {value}]
  else no per-instance value
    SubgraphNode->>Serializer: emit proxyWidgets entry [id, name] or [id, name, ...]
  end
  Serializer-->>Client: return payload (without widgets_values)
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Poem

🐇 I hid each nibble in a proxy nest,

Instance keys hummed and took their rest.
No stray arrays hopping out of line,
Every value tucked in its little sign.
Tests thump their feet — the changes are blessed.

🚥 Pre-merge checks | ✅ 6 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main fix: restoring the SubgraphNode.widgets_values dead-field invariant by fixing a regression from #10849.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed PR title uses bug-fix language and modifies browser_tests/ directory, satisfying E2E test coverage requirement.
Adr Compliance For Entity/Litegraph Changes ✅ Passed PR changes to graph-related files comply with ADR 0003 (command pattern), ADR 0008 (god-object growth, ECS separation, extension ecosystem). No imperative spatial mutations, narrowly scoped methods, and serialization changes are documented regression fixes.
Description check ✅ Passed The PR description comprehensively covers all required sections: Summary, Root Cause, Design, Migration/Extension Notes, Follow-Up Issues, Verification, and Video. It explains the regression, the chosen fix, implementation details, and migration path.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/subgraph-promoted-widget-inline-state

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Apr 23, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 04/29/2026, 05:50:06 AM UTC

Links

@github-actions

github-actions Bot commented Apr 23, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1426 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1410 / ❌ 0 / ⚠️ 0 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 13 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/lib/litegraph/src/subgraph/SubgraphNode.multiInstance.test.ts`:
- Around line 262-302: The existing test that currently expects
serialize().widgets_values to equal [10] and [20] must be updated to expect
undefined to match the new behavior; locate the test that uses
serialize().widgets_values (the one alongside serializeValue and round-trip
assertions) and change those direct widgets_values assertions to expect
undefined (leave serializeValue and round-trip tests unchanged), ensuring the
test names remain the same so it still verifies per-instance value preservation
while no longer asserting a top-level widgets_values array on SubgraphNode.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f15da234-8042-4877-b801-b43d2cdee2c1

📥 Commits

Reviewing files that changed from the base of the PR and between bab2870 and 6a98267.

📒 Files selected for processing (1)
  • src/lib/litegraph/src/subgraph/SubgraphNode.multiInstance.test.ts

@github-actions

github-actions Bot commented Apr 23, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle: 5.23 MB gzip 🔴 +1.45 kB

Details

Summary

  • Raw size: 24.1 MB baseline 24.1 MB — 🔴 +4.16 kB
  • Gzip: 5.23 MB baseline 5.23 MB — 🔴 +1.45 kB
  • Brotli: 4.05 MB baseline 4.05 MB — 🔴 +1.09 kB
  • Bundles: 257 current • 257 baseline • 120 added / 120 removed

Category Glance
Data & Services 🔴 +3.15 kB (3.04 MB) · Vendor & Third-Party 🔴 +861 B (9.88 MB) · Graph Workspace 🔴 +142 B (1.24 MB) · Other ⚪ 0 B (8.83 MB) · Panels & Settings ⚪ 0 B (488 kB) · Utilities & Hooks ⚪ 0 B (364 kB) · + 5 more

App Entry Points — 22.5 kB (baseline 22.5 kB) • ⚪ 0 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-BaHwfelg.js (new) — 22.5 kB 🔴 +22.5 kB 🔴 +7.99 kB 🔴 +6.84 kB
assets/index-DISmWkLS.js (removed) 22.5 kB — 🟢 -22.5 kB 🟢 -7.99 kB 🟢 -6.85 kB

Status: 1 added / 1 removed

Graph Workspace — 1.24 MB (baseline 1.24 MB) • 🔴 +142 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-BxOvwVwB.js (new) — 1.24 MB 🔴 +1.24 MB 🔴 +264 kB 🔴 +199 kB
assets/GraphView-BPP9_Xun.js (removed) 1.24 MB — 🟢 -1.24 MB 🟢 -264 kB 🟢 -199 kB

Status: 1 added / 1 removed

Views & Navigation — 77.7 kB (baseline 77.7 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CloudSurveyView-C6NH0-0g.js (new) — 15.7 kB 🔴 +15.7 kB 🔴 +3.41 kB 🔴 +2.92 kB
assets/CloudSurveyView-DHWzhebI.js (removed) 15.7 kB — 🟢 -15.7 kB 🟢 -3.41 kB 🟢 -2.92 kB
assets/CloudLoginView-BELXbZY5.js (removed) 12.2 kB — 🟢 -12.2 kB 🟢 -3.43 kB 🟢 -3.03 kB
assets/CloudLoginView-tMgkhHN0.js (new) — 12.2 kB 🔴 +12.2 kB 🔴 +3.43 kB 🔴 +3.04 kB
assets/CloudSignupView-BjRHCUey.js (removed) 9.94 kB — 🟢 -9.94 kB 🟢 -2.93 kB 🟢 -2.58 kB
assets/CloudSignupView-DC9f3UKK.js (new) — 9.94 kB 🔴 +9.94 kB 🔴 +2.93 kB 🔴 +2.58 kB
assets/UserCheckView-BRmnMZJn.js (removed) 9.07 kB — 🟢 -9.07 kB 🟢 -2.33 kB 🟢 -2.04 kB
assets/UserCheckView-D8U5yyvB.js (new) — 9.07 kB 🔴 +9.07 kB 🔴 +2.33 kB 🔴 +2.04 kB
assets/CloudLayoutView-B2RLe8bZ.js (removed) 7.7 kB — 🟢 -7.7 kB 🟢 -2.43 kB 🟢 -2.1 kB
assets/CloudLayoutView-BwX10uuN.js (new) — 7.7 kB 🔴 +7.7 kB 🔴 +2.43 kB 🔴 +2.12 kB
assets/CloudForgotPasswordView-5jPao_Iq.js (new) — 6.11 kB 🔴 +6.11 kB 🔴 +2.17 kB 🔴 +1.9 kB
assets/CloudForgotPasswordView-BWznZP1O.js (removed) 6.11 kB — 🟢 -6.11 kB 🟢 -2.17 kB 🟢 -1.91 kB
assets/CloudAuthTimeoutView-BA2G9lDR.js (new) — 5.47 kB 🔴 +5.47 kB 🔴 +2 kB 🔴 +1.75 kB
assets/CloudAuthTimeoutView-Cf8Une6R.js (removed) 5.47 kB — 🟢 -5.47 kB 🟢 -2 kB 🟢 -1.77 kB
assets/CloudSubscriptionRedirectView-C4CaOmSx.js (new) — 5.25 kB 🔴 +5.25 kB 🔴 +1.98 kB 🔴 +1.77 kB
assets/CloudSubscriptionRedirectView-JUYoIVTi.js (removed) 5.25 kB — 🟢 -5.25 kB 🟢 -1.98 kB 🟢 -1.76 kB
assets/UserSelectView-BtmQA2iC.js (removed) 4.73 kB — 🟢 -4.73 kB 🟢 -1.75 kB 🟢 -1.55 kB
assets/UserSelectView-CyEfDSnS.js (new) — 4.73 kB 🔴 +4.73 kB 🔴 +1.75 kB 🔴 +1.55 kB

Status: 9 added / 9 removed / 2 unchanged

Panels & Settings — 488 kB (baseline 488 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/KeybindingPanel-DrDFKCLA.js (removed) 46.7 kB — 🟢 -46.7 kB 🟢 -9.6 kB 🟢 -8.55 kB
assets/KeybindingPanel-DuqkIBla.js (new) — 46.7 kB 🔴 +46.7 kB 🔴 +9.6 kB 🔴 +8.53 kB
assets/SecretsPanel-B95c0YK4.js (new) — 22.9 kB 🔴 +22.9 kB 🔴 +5.54 kB 🔴 +4.87 kB
assets/SecretsPanel-R84MAfVl.js (removed) 22.9 kB — 🟢 -22.9 kB 🟢 -5.54 kB 🟢 -4.88 kB
assets/LegacyCreditsPanel-BpKzoWlR.js (new) — 21.7 kB 🔴 +21.7 kB 🔴 +5.89 kB 🔴 +5.2 kB
assets/LegacyCreditsPanel-DD4EDjwp.js (removed) 21.7 kB — 🟢 -21.7 kB 🟢 -5.89 kB 🟢 -5.21 kB
assets/SubscriptionPanel-Bfn0ba79.js (removed) 19.9 kB — 🟢 -19.9 kB 🟢 -5.06 kB 🟢 -4.45 kB
assets/SubscriptionPanel-CToP9dSg.js (new) — 19.9 kB 🔴 +19.9 kB 🔴 +5.06 kB 🔴 +4.46 kB
assets/AboutPanel-Bnt68y2U.js (new) — 12 kB 🔴 +12 kB 🔴 +3.33 kB 🔴 +2.98 kB
assets/AboutPanel-Mf-RW0f-.js (removed) 12 kB — 🟢 -12 kB 🟢 -3.33 kB 🟢 -2.98 kB
assets/ExtensionPanel-4OE4UY0P.js (new) — 9.94 kB 🔴 +9.94 kB 🔴 +2.9 kB 🔴 +2.56 kB
assets/ExtensionPanel-Dt1K_ajF.js (removed) 9.94 kB — 🟢 -9.94 kB 🟢 -2.9 kB 🟢 -2.57 kB
assets/ServerConfigPanel-D7CA5rpU.js (new) — 7.02 kB 🔴 +7.02 kB 🔴 +2.35 kB 🔴 +2.08 kB
assets/ServerConfigPanel-Dfcw1f04.js (removed) 7.02 kB — 🟢 -7.02 kB 🟢 -2.35 kB 🟢 -2.11 kB
assets/UserPanel-BOOxp1mk.js (new) — 6.73 kB 🔴 +6.73 kB 🔴 +2.22 kB 🔴 +1.95 kB
assets/UserPanel-CfudVNKL.js (removed) 6.73 kB — 🟢 -6.73 kB 🟢 -2.22 kB 🟢 -1.96 kB
assets/cloudRemoteConfig-B8Ir4n2y.js (new) — 2.02 kB 🔴 +2.02 kB 🔴 +970 B 🔴 +834 B
assets/cloudRemoteConfig-D5yffYM1.js (removed) 2.02 kB — 🟢 -2.02 kB 🟢 -973 B 🟢 -837 B
assets/refreshRemoteConfig-BDrWrk1v.js (new) — 1.45 kB 🔴 +1.45 kB 🔴 +646 B 🔴 +549 B
assets/refreshRemoteConfig-BmNzvqzG.js (removed) 1.45 kB — 🟢 -1.45 kB 🟢 -649 B 🟢 -558 B

Status: 10 added / 10 removed / 11 unchanged

User & Accounts — 17.4 kB (baseline 17.4 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/auth-BTbPm5JT.js (removed) 3.57 kB — 🟢 -3.57 kB 🟢 -1.26 kB 🟢 -1.07 kB
assets/auth-WUQDMrRP.js (new) — 3.57 kB 🔴 +3.57 kB 🔴 +1.26 kB 🔴 +1.07 kB
assets/SignUpForm-BXwZHKYu.js (removed) 3.16 kB — 🟢 -3.16 kB 🟢 -1.29 kB 🟢 -1.15 kB
assets/SignUpForm-CCefTde8.js (new) — 3.16 kB 🔴 +3.16 kB 🔴 +1.29 kB 🔴 +1.15 kB
assets/UpdatePasswordContent-DC9e-2_5.js (removed) 2.87 kB — 🟢 -2.87 kB 🟢 -1.28 kB 🟢 -1.14 kB
assets/UpdatePasswordContent-z0_56TKH.js (new) — 2.87 kB 🔴 +2.87 kB 🔴 +1.29 kB 🔴 +1.14 kB
assets/authStore-Bo_ExV4b.js (new) — 1.16 kB 🔴 +1.16 kB 🔴 +552 B 🔴 +495 B
assets/authStore-BuyWiXta.js (removed) 1.16 kB — 🟢 -1.16 kB 🟢 -552 B 🟢 -500 B
assets/auth-BqITn98e.js (new) — 348 B 🔴 +348 B 🔴 +216 B 🔴 +192 B
assets/auth-CYw_S8wY.js (removed) 348 B — 🟢 -348 B 🟢 -217 B 🟢 -211 B

Status: 5 added / 5 removed / 2 unchanged

Editors & Dialogs — 113 kB (baseline 113 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyHubPublishDialog-De82mAEU.js (removed) 86.9 kB — 🟢 -86.9 kB 🟢 -18.8 kB 🟢 -16 kB
assets/ComfyHubPublishDialog-O_5HSABm.js (new) — 86.9 kB 🔴 +86.9 kB 🔴 +18.8 kB 🔴 +16.1 kB
assets/useShareDialog-DJZSKZTA.js (removed) 23.7 kB — 🟢 -23.7 kB 🟢 -5.77 kB 🟢 -5.12 kB
assets/useShareDialog-qDqj6lsB.js (new) — 23.7 kB 🔴 +23.7 kB 🔴 +5.77 kB 🔴 +5.12 kB
assets/ComfyHubPublishDialog-CXHsQ166.js (new) — 1.32 kB 🔴 +1.32 kB 🔴 +614 B 🔴 +543 B
assets/ComfyHubPublishDialog-DZWIaqdT.js (removed) 1.32 kB — 🟢 -1.32 kB 🟢 -613 B 🟢 -557 B
assets/useSubscriptionDialog-CYm1Gc9G.js (removed) 1.14 kB — 🟢 -1.14 kB 🟢 -542 B 🟢 -485 B
assets/useSubscriptionDialog-D1cYYtLF.js (new) — 1.14 kB 🔴 +1.14 kB 🔴 +543 B 🔴 +480 B

Status: 4 added / 4 removed

UI Components — 61 kB (baseline 61 kB) • ⚪ 0 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyQueueButton-CNfod2FS.js (removed) 13.5 kB — 🟢 -13.5 kB 🟢 -3.79 kB 🟢 -3.38 kB
assets/ComfyQueueButton-DKuLlkQ_.js (new) — 13.5 kB 🔴 +13.5 kB 🔴 +3.79 kB 🔴 +3.38 kB
assets/useTerminalTabs-C0cNIcqL.js (new) — 11 kB 🔴 +11 kB 🔴 +3.71 kB 🔴 +3.26 kB
assets/useTerminalTabs-Dvr_A8ae.js (removed) 11 kB — 🟢 -11 kB 🟢 -3.71 kB 🟢 -3.26 kB
assets/SubscribeButton-CTSi8Nqb.js (new) — 2.42 kB 🔴 +2.42 kB 🔴 +1.05 kB 🔴 +943 B
assets/SubscribeButton-oXpLcWaZ.js (removed) 2.42 kB — 🟢 -2.42 kB 🟢 -1.05 kB 🟢 -918 B
assets/cloudFeedbackTopbarButton-9cYDnKBN.js (removed) 1.8 kB — 🟢 -1.8 kB 🟢 -929 B 🟢 -818 B
assets/cloudFeedbackTopbarButton-C5Xd-Vzj.js (new) — 1.8 kB 🔴 +1.8 kB 🔴 +929 B 🔴 +812 B
assets/ComfyQueueButton-BXvOpEDB.js (new) — 1.24 kB 🔴 +1.24 kB 🔴 +579 B 🔴 +514 B
assets/ComfyQueueButton-Ck5PnmYp.js (removed) 1.24 kB — 🟢 -1.24 kB 🟢 -578 B 🟢 -518 B

Status: 5 added / 5 removed / 8 unchanged

Data & Services — 3.04 MB (baseline 3.04 MB) • 🔴 +3.15 kB

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/dialogService-M5LUYfl8.js (new) — 1.97 MB 🔴 +1.97 MB 🔴 +454 kB 🔴 +344 kB
assets/dialogService-bfVUuN.js (removed) 1.97 MB — 🟢 -1.97 MB 🟢 -454 kB 🟢 -344 kB
assets/api-cut0RoRS.js (new) — 897 kB 🔴 +897 kB 🔴 +215 kB 🔴 +169 kB
assets/api-OPl5dd8w.js (removed) 894 kB — 🟢 -894 kB 🟢 -214 kB 🟢 -168 kB
assets/load3dService-C5YYv-gi.js (new) — 114 kB 🔴 +114 kB 🔴 +24.8 kB 🔴 +21 kB
assets/load3dService-DhOQ1uil.js (removed) 114 kB — 🟢 -114 kB 🟢 -24.8 kB 🟢 -21.1 kB
assets/workflowShareService-B03MLy04.js (removed) 16.6 kB — 🟢 -16.6 kB 🟢 -4.89 kB 🟢 -4.33 kB
assets/workflowShareService-C_90zwVf.js (new) — 16.6 kB 🔴 +16.6 kB 🔴 +4.89 kB 🔴 +4.33 kB
assets/keybindingService-CKvZykzA.js (removed) 13.8 kB — 🟢 -13.8 kB 🟢 -3.67 kB 🟢 -3.22 kB
assets/keybindingService-m1DpMvcz.js (new) — 13.8 kB 🔴 +13.8 kB 🔴 +3.67 kB 🔴 +3.22 kB
assets/releaseStore-BWaL2Z6H.js (new) — 8.12 kB 🔴 +8.12 kB 🔴 +2.28 kB 🔴 +2 kB
assets/releaseStore-Cjz0OhSt.js (removed) 8.12 kB — 🟢 -8.12 kB 🟢 -2.28 kB 🟢 -2 kB
assets/userStore-Bm08Btyt.js (new) — 2.24 kB 🔴 +2.24 kB 🔴 +867 B 🔴 +760 B
assets/userStore-DdiqojrO.js (removed) 2.24 kB — 🟢 -2.24 kB 🟢 -869 B 🟢 -758 B
assets/audioService-1wb_oPhX.js (removed) 1.8 kB — 🟢 -1.8 kB 🟢 -877 B 🟢 -761 B
assets/audioService-BbIOh19x.js (new) — 1.8 kB 🔴 +1.8 kB 🔴 +877 B 🔴 +754 B
assets/releaseStore-BU8jbQoJ.js (new) — 1.16 kB 🔴 +1.16 kB 🔴 +547 B 🔴 +486 B
assets/releaseStore-DKWWP9xK.js (removed) 1.16 kB — 🟢 -1.16 kB 🟢 -546 B 🟢 -491 B
assets/workflowDraftStore-Bqr0_P_H.js (removed) 1.14 kB — 🟢 -1.14 kB 🟢 -541 B 🟢 -486 B
assets/workflowDraftStore-CtlQLgIE.js (new) — 1.14 kB 🔴 +1.14 kB 🔴 +542 B 🔴 +481 B
assets/dialogService-C1seas9L.js (new) — 1.13 kB 🔴 +1.13 kB 🔴 +535 B 🔴 +478 B
assets/dialogService-Dkh0FE34.js (removed) 1.13 kB — 🟢 -1.13 kB 🟢 -534 B 🟢 -485 B
assets/settingStore-DmxZ3-AX.js (new) — 1.12 kB 🔴 +1.12 kB 🔴 +538 B 🔴 +476 B
assets/settingStore-DTb6qqfp.js (removed) 1.12 kB — 🟢 -1.12 kB 🟢 -537 B 🟢 -481 B
assets/assetsStore-0vk89fcB.js (removed) 1.12 kB — 🟢 -1.12 kB 🟢 -537 B 🟢 -482 B
assets/assetsStore-CLbz3tPM.js (new) — 1.12 kB 🔴 +1.12 kB 🔴 +537 B 🔴 +479 B

Status: 13 added / 13 removed / 4 unchanged

Utilities & Hooks — 364 kB (baseline 364 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useConflictDetection-BcXPe3YD.js (new) — 233 kB 🔴 +233 kB 🔴 +51.8 kB 🔴 +42.2 kB
assets/useConflictDetection-s4ciZ5sw.js (removed) 233 kB — 🟢 -233 kB 🟢 -51.8 kB 🟢 -42.2 kB
assets/useLoad3d-CeU0Gg_X.js (removed) 22.3 kB — 🟢 -22.3 kB 🟢 -5.09 kB 🟢 -4.49 kB
assets/useLoad3d-CUOgG1vn.js (new) — 22.3 kB 🔴 +22.3 kB 🔴 +5.09 kB 🔴 +4.51 kB
assets/useLoad3dViewer-DmzrEa96.js (new) — 20.8 kB 🔴 +20.8 kB 🔴 +4.91 kB 🔴 +4.3 kB
assets/useLoad3dViewer-TbW6B8QK.js (removed) 20.8 kB — 🟢 -20.8 kB 🟢 -4.91 kB 🟢 -4.28 kB
assets/useFeatureFlags-BOBhvpNb.js (new) — 5.95 kB 🔴 +5.95 kB 🔴 +1.79 kB 🔴 +1.52 kB
assets/useFeatureFlags-CwbVTts-.js (removed) 5.95 kB — 🟢 -5.95 kB 🟢 -1.8 kB 🟢 -1.52 kB
assets/useCopyToClipboard-CRtVSma_.js (new) — 5.29 kB 🔴 +5.29 kB 🔴 +1.86 kB 🔴 +1.57 kB
assets/useCopyToClipboard-DUdHUx2J.js (removed) 5.29 kB — 🟢 -5.29 kB 🟢 -1.86 kB 🟢 -1.58 kB
assets/useWorkspaceUI-Cmk-o7cU.js (removed) 3.34 kB — 🟢 -3.34 kB 🟢 -981 B 🟢 -806 B
assets/useWorkspaceUI-G7TdJv43.js (new) — 3.34 kB 🔴 +3.34 kB 🔴 +983 B 🔴 +810 B
assets/subscriptionCheckoutUtil-DkDm8AwV.js (new) — 3.31 kB 🔴 +3.31 kB 🔴 +1.36 kB 🔴 +1.19 kB
assets/subscriptionCheckoutUtil-n_qDpco1.js (removed) 3.31 kB — 🟢 -3.31 kB 🟢 -1.36 kB 🟢 -1.18 kB
assets/assetPreviewUtil-Bg_GpXon.js (removed) 2.27 kB — 🟢 -2.27 kB 🟢 -957 B 🟢 -830 B
assets/assetPreviewUtil-jITFy20J.js (new) — 2.27 kB 🔴 +2.27 kB 🔴 +958 B 🔴 +833 B
assets/useUpstreamValue-BC0QF490.js (removed) 2.08 kB — 🟢 -2.08 kB 🟢 -808 B 🟢 -715 B
assets/useUpstreamValue-lZd6D9UY.js (new) — 2.08 kB 🔴 +2.08 kB 🔴 +805 B 🔴 +721 B
assets/useLoad3d-BHd9zo4R.js (removed) 1.3 kB — 🟢 -1.3 kB 🟢 -605 B 🟢 -560 B
assets/useLoad3d-BoYDztJT.js (new) — 1.3 kB 🔴 +1.3 kB 🔴 +605 B 🔴 +555 B
assets/useLoad3dViewer-C6ZncrRv.js (removed) 1.24 kB — 🟢 -1.24 kB 🟢 -572 B 🟢 -519 B
assets/useLoad3dViewer-DdFPl9gl.js (new) — 1.24 kB 🔴 +1.24 kB 🔴 +571 B 🔴 +516 B
assets/useCurrentUser-BwI_LpYs.js (new) — 1.12 kB 🔴 +1.12 kB 🔴 +538 B 🔴 +478 B
assets/useCurrentUser-FnoXmwRI.js (removed) 1.12 kB — 🟢 -1.12 kB 🟢 -537 B 🟢 -479 B
assets/useWorkspaceSwitch-C31VZC4s.js (new) — 747 B 🔴 +747 B 🔴 +384 B 🔴 +334 B
assets/useWorkspaceSwitch-DZCakXqy.js (removed) 747 B — 🟢 -747 B 🟢 -384 B 🟢 -332 B

Status: 13 added / 13 removed / 18 unchanged

Vendor & Third-Party — 9.88 MB (baseline 9.88 MB) • 🔴 +861 B

External libraries and shared vendor chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/vendor-zod-CM1UD-cG.js (new) — 106 kB 🔴 +106 kB 🔴 +18.9 kB 🔴 +16.1 kB
assets/vendor-zod-Dg3yaIzQ.js (removed) 105 kB — 🟢 -105 kB 🟢 -18.7 kB 🟢 -15.9 kB

Status: 1 added / 1 removed / 15 unchanged

Other — 8.83 MB (baseline 8.83 MB) • ⚪ 0 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/core-BLD5RPZQ.js (new) — 76.6 kB 🔴 +76.6 kB 🔴 +19.8 kB 🔴 +16.9 kB
assets/core-R4K8MGT0.js (removed) 76.6 kB — 🟢 -76.6 kB 🟢 -19.8 kB 🟢 -16.9 kB
assets/groupNode-BDg3Fb3-.js (new) — 74.9 kB 🔴 +74.9 kB 🔴 +18.7 kB 🔴 +16.5 kB
assets/groupNode-CfUK6AS4.js (removed) 74.9 kB — 🟢 -74.9 kB 🟢 -18.7 kB 🟢 -16.5 kB
assets/WidgetSelect-CAMfr9Ka.js (new) — 67.2 kB 🔴 +67.2 kB 🔴 +14.6 kB 🔴 +12.7 kB
assets/WidgetSelect-DHlpQbn1.js (removed) 67.2 kB — 🟢 -67.2 kB 🟢 -14.6 kB 🟢 -12.7 kB
assets/SubscriptionRequiredDialogContentWorkspace-CU3kAZuM.js (new) — 49.3 kB 🔴 +49.3 kB 🔴 +9.41 kB 🔴 +8.04 kB
assets/SubscriptionRequiredDialogContentWorkspace-DO-ZL1AX.js (removed) 49.3 kB — 🟢 -49.3 kB 🟢 -9.41 kB 🟢 -8.05 kB
assets/Load3DControls-BlJTruT3.js (new) — 46.1 kB 🔴 +46.1 kB 🔴 +7.51 kB 🔴 +6.56 kB
assets/Load3DControls-CNm2e5_z.js (removed) 46.1 kB — 🟢 -46.1 kB 🟢 -7.51 kB 🟢 -6.54 kB
assets/WidgetPainter-BFsK4bpX.js (new) — 34 kB 🔴 +34 kB 🔴 +8.28 kB 🔴 +7.33 kB
assets/WidgetPainter-COirrvqY.js (removed) 34 kB — 🟢 -34 kB 🟢 -8.28 kB 🟢 -7.35 kB
assets/WorkspacePanelContent-CIASSjHk.js (new) — 32.8 kB 🔴 +32.8 kB 🔴 +6.99 kB 🔴 +6.17 kB
assets/WorkspacePanelContent-CRhsUr2q.js (removed) 32.8 kB — 🟢 -32.8 kB 🟢 -6.99 kB 🟢 -6.19 kB
assets/Load3dViewerContent-BPgfpTbS.js (new) — 28 kB 🔴 +28 kB 🔴 +5.85 kB 🔴 +5.07 kB
assets/Load3dViewerContent-DYkUARdf.js (removed) 28 kB — 🟢 -28 kB 🟢 -5.85 kB 🟢 -5.07 kB
assets/SubscriptionRequiredDialogContent-Cz0V33-B.js (removed) 27.5 kB — 🟢 -27.5 kB 🟢 -6.96 kB 🟢 -6.15 kB
assets/SubscriptionRequiredDialogContent-Deyffks_.js (new) — 27.5 kB 🔴 +27.5 kB 🔴 +6.96 kB 🔴 +6.15 kB
assets/WidgetImageCrop-CejiTKY0.js (new) — 24.3 kB 🔴 +24.3 kB 🔴 +6.18 kB 🔴 +5.44 kB
assets/WidgetImageCrop-CpJetCf5.js (removed) 24.3 kB — 🟢 -24.3 kB 🟢 -6.18 kB 🟢 -5.43 kB
assets/SubscriptionPanelContentWorkspace-Cah3860Y.js (new) — 22.2 kB 🔴 +22.2 kB 🔴 +5.18 kB 🔴 +4.57 kB
assets/SubscriptionPanelContentWorkspace-guxxdoQ1.js (removed) 22.2 kB — 🟢 -22.2 kB 🟢 -5.17 kB 🟢 -4.56 kB
assets/SignInContent-CQdebFVB.js (new) — 20.6 kB 🔴 +20.6 kB 🔴 +5.35 kB 🔴 +4.67 kB
assets/SignInContent-IxlmAQfp.js (removed) 20.6 kB — 🟢 -20.6 kB 🟢 -5.35 kB 🟢 -4.68 kB
assets/CurrentUserPopoverWorkspace-9VDzvJwj.js (new) — 20.5 kB 🔴 +20.5 kB 🔴 +4.89 kB 🔴 +4.38 kB
assets/CurrentUserPopoverWorkspace-BgBfheZ0.js (removed) 20.5 kB — 🟢 -20.5 kB 🟢 -4.89 kB 🟢 -4.38 kB
assets/WidgetInputNumber-C8T-oTUF.js (new) — 19.1 kB 🔴 +19.1 kB 🔴 +4.84 kB 🔴 +4.29 kB
assets/WidgetInputNumber-C8wok-M3.js (removed) 19.1 kB — 🟢 -19.1 kB 🟢 -4.84 kB 🟢 -4.3 kB
assets/Load3D-Gvli8lkw.js (removed) 18.5 kB — 🟢 -18.5 kB 🟢 -4.39 kB 🟢 -3.84 kB
assets/Load3D-Xs_d8cMa.js (new) — 18.5 kB 🔴 +18.5 kB 🔴 +4.39 kB 🔴 +3.84 kB
assets/WidgetRecordAudio-BOk_Apdo.js (removed) 17.4 kB — 🟢 -17.4 kB 🟢 -5 kB 🟢 -4.47 kB
assets/WidgetRecordAudio-BvqLaOju.js (new) — 17.4 kB 🔴 +17.4 kB 🔴 +5 kB 🔴 +4.47 kB
assets/WidgetRange-BBNu5CFM.js (new) — 17 kB 🔴 +17 kB 🔴 +4.59 kB 🔴 +4.11 kB
assets/WidgetRange-CHT-w9R-.js (removed) 17 kB — 🟢 -17 kB 🟢 -4.59 kB 🟢 -4.1 kB
assets/load3d-_AlyGy8S.js (removed) 15.7 kB — 🟢 -15.7 kB 🟢 -4.56 kB 🟢 -3.94 kB
assets/load3d-B8ANqL8t.js (new) — 15.7 kB 🔴 +15.7 kB 🔴 +4.56 kB 🔴 +3.94 kB
assets/WaveAudioPlayer-Cu0unrmN.js (removed) 13.4 kB — 🟢 -13.4 kB 🟢 -3.69 kB 🟢 -3.23 kB
assets/WaveAudioPlayer-qY71g2Wl.js (new) — 13.4 kB 🔴 +13.4 kB 🔴 +3.69 kB 🔴 +3.23 kB
assets/WidgetCurve-BXbJbdv9.js (removed) 12.1 kB — 🟢 -12.1 kB 🟢 -3.91 kB 🟢 -3.55 kB
assets/WidgetCurve-lzNr4Bcv.js (new) — 12.1 kB 🔴 +12.1 kB 🔴 +3.91 kB 🔴 +3.54 kB
assets/TeamWorkspacesDialogContent-CDwvc2Yg.js (new) — 11.3 kB 🔴 +11.3 kB 🔴 +3.4 kB 🔴 +3.03 kB
assets/TeamWorkspacesDialogContent-D3PutbfT.js (removed) 11.3 kB — 🟢 -11.3 kB 🟢 -3.41 kB 🟢 -3.04 kB
assets/nodeTemplates-B9R72zk1.js (removed) 9.81 kB — 🟢 -9.81 kB 🟢 -3.47 kB 🟢 -3.06 kB
assets/nodeTemplates-dTibYoml.js (new) — 9.81 kB 🔴 +9.81 kB 🔴 +3.47 kB 🔴 +3.05 kB
assets/NightlySurveyController-DUFUJLq4.js (removed) 8.99 kB — 🟢 -8.99 kB 🟢 -3.14 kB 🟢 -2.78 kB
assets/NightlySurveyController-M08ou7pw.js (new) — 8.99 kB 🔴 +8.99 kB 🔴 +3.14 kB 🔴 +2.78 kB
assets/InviteMemberDialogContent-C0rzYh1V.js (new) — 7.91 kB 🔴 +7.91 kB 🔴 +2.51 kB 🔴 +2.22 kB
assets/InviteMemberDialogContent-DK4mdsT9.js (removed) 7.91 kB — 🟢 -7.91 kB 🟢 -2.51 kB 🟢 -2.2 kB
assets/Load3DConfiguration-DPwGfwVf.js (removed) 7.82 kB — 🟢 -7.82 kB 🟢 -2.31 kB 🟢 -2.02 kB
assets/Load3DConfiguration-DQwZShdM.js (new) — 7.82 kB 🔴 +7.82 kB 🔴 +2.31 kB 🔴 +2.02 kB
assets/onboardingCloudRoutes-B_RnbAtN.js (new) — 6.58 kB 🔴 +6.58 kB 🔴 +2.05 kB 🔴 +1.77 kB
assets/onboardingCloudRoutes-g-YRk-gD.js (removed) 6.58 kB — 🟢 -6.58 kB 🟢 -2.05 kB 🟢 -1.77 kB
assets/CreateWorkspaceDialogContent-BYzFRuue.js (new) — 6.12 kB 🔴 +6.12 kB 🔴 +2.22 kB 🔴 +1.95 kB
assets/CreateWorkspaceDialogContent-DJsfORpy.js (removed) 6.12 kB — 🟢 -6.12 kB 🟢 -2.22 kB 🟢 -1.95 kB
assets/WidgetWithControl-DD0RrDZH.js (new) — 6.02 kB 🔴 +6.02 kB 🔴 +2.4 kB 🔴 +2.13 kB
assets/WidgetWithControl-DL6ikCg4.js (removed) 6.02 kB — 🟢 -6.02 kB 🟢 -2.4 kB 🟢 -2.15 kB
assets/FreeTierDialogContent-B_5FkIt8.js (new) — 5.99 kB 🔴 +5.99 kB 🔴 +2.12 kB 🔴 +1.87 kB
assets/FreeTierDialogContent-DIj1jX5r.js (removed) 5.99 kB — 🟢 -5.99 kB 🟢 -2.12 kB 🟢 -1.88 kB
assets/EditWorkspaceDialogContent-DKSg5PDI.js (new) — 5.92 kB 🔴 +5.92 kB 🔴 +2.18 kB 🔴 +1.91 kB
assets/EditWorkspaceDialogContent-uwUKvdJm.js (removed) 5.92 kB — 🟢 -5.92 kB 🟢 -2.18 kB 🟢 -1.92 kB
assets/WidgetTextarea-BOS2kV9-.js (new) — 5.73 kB 🔴 +5.73 kB 🔴 +2.26 kB 🔴 +1.98 kB
assets/WidgetTextarea-sAKgbxr4.js (removed) 5.73 kB — 🟢 -5.73 kB 🟢 -2.25 kB 🟢 -1.99 kB
assets/Preview3d-DCU3ogHF.js (new) — 5.7 kB 🔴 +5.7 kB 🔴 +1.91 kB 🔴 +1.67 kB
assets/Preview3d-DZ7FDSIN.js (removed) 5.7 kB — 🟢 -5.7 kB 🟢 -1.91 kB 🟢 -1.67 kB
assets/ValueControlPopover-CCKECIha.js (new) — 5.5 kB 🔴 +5.5 kB 🔴 +2 kB 🔴 +1.78 kB
assets/ValueControlPopover-DLiQUrLq.js (removed) 5.5 kB — 🟢 -5.5 kB 🟢 -2 kB 🟢 -1.8 kB
assets/CancelSubscriptionDialogContent-3W6IfnFO.js (removed) 5.46 kB — 🟢 -5.46 kB 🟢 -2.04 kB 🟢 -1.79 kB
assets/CancelSubscriptionDialogContent-DsRiUMiF.js (new) — 5.46 kB 🔴 +5.46 kB 🔴 +2.04 kB 🔴 +1.79 kB
assets/DeleteWorkspaceDialogContent-5LZbA-aV.js (removed) 4.82 kB — 🟢 -4.82 kB 🟢 -1.86 kB 🟢 -1.62 kB
assets/DeleteWorkspaceDialogContent-CVluh3u1.js (new) — 4.82 kB 🔴 +4.82 kB 🔴 +1.86 kB 🔴 +1.62 kB
assets/LeaveWorkspaceDialogContent-C8RbJa7D.js (removed) 4.65 kB — 🟢 -4.65 kB 🟢 -1.8 kB 🟢 -1.57 kB
assets/LeaveWorkspaceDialogContent-CW2nAlBu.js (new) — 4.65 kB 🔴 +4.65 kB 🔴 +1.8 kB 🔴 +1.57 kB
assets/RemoveMemberDialogContent-CkIFuLP9.js (new) — 4.63 kB 🔴 +4.63 kB 🔴 +1.76 kB 🔴 +1.53 kB
assets/RemoveMemberDialogContent-qD9NtScx.js (removed) 4.63 kB — 🟢 -4.63 kB 🟢 -1.76 kB 🟢 -1.54 kB
assets/RevokeInviteDialogContent-BZwnsAiN.js (new) — 4.54 kB 🔴 +4.54 kB 🔴 +1.77 kB 🔴 +1.55 kB
assets/RevokeInviteDialogContent-OGbTGO4m.js (removed) 4.54 kB — 🟢 -4.54 kB 🟢 -1.77 kB 🟢 -1.56 kB
assets/tierBenefits-CLhwIF8N.js (new) — 4.45 kB 🔴 +4.45 kB 🔴 +1.57 kB 🔴 +1.36 kB
assets/tierBenefits-CW-OebpR.js (removed) 4.45 kB — 🟢 -4.45 kB 🟢 -1.57 kB 🟢 -1.36 kB
assets/InviteMemberUpsellDialogContent-Co4MxNBG.js (new) — 4.44 kB 🔴 +4.44 kB 🔴 +1.64 kB 🔴 +1.44 kB
assets/InviteMemberUpsellDialogContent-CrqtuMSY.js (removed) 4.44 kB — 🟢 -4.44 kB 🟢 -1.63 kB 🟢 -1.44 kB
assets/cloudSessionCookie-CHq7w6wn.js (removed) 4.28 kB — 🟢 -4.28 kB 🟢 -1.56 kB 🟢 -1.36 kB
assets/cloudSessionCookie-D6PPuZDS.js (new) — 4.28 kB 🔴 +4.28 kB 🔴 +1.56 kB 🔴 +1.36 kB
assets/Media3DTop-beUDJU27.js (new) — 4.01 kB 🔴 +4.01 kB 🔴 +1.69 kB 🔴 +1.5 kB
assets/Media3DTop-Dc8A9RU2.js (removed) 4.01 kB — 🟢 -4.01 kB 🟢 -1.69 kB 🟢 -1.5 kB
assets/saveMesh-CLu0Ei7C.js (new) — 3.98 kB 🔴 +3.98 kB 🔴 +1.73 kB 🔴 +1.53 kB
assets/saveMesh-DOuuVEq1.js (removed) 3.98 kB — 🟢 -3.98 kB 🟢 -1.73 kB 🟢 -1.54 kB
assets/GlobalToast--j2Yzaf4.js (removed) 3.05 kB — 🟢 -3.05 kB 🟢 -1.26 kB 🟢 -1.11 kB
assets/GlobalToast-B82yu5LC.js (new) — 3.05 kB 🔴 +3.05 kB 🔴 +1.26 kB 🔴 +1.11 kB
assets/CloudRunButtonWrapper-BaehfrFh.js (new) — 2.2 kB 🔴 +2.2 kB 🔴 +1 kB 🔴 +891 B
assets/CloudRunButtonWrapper-DbC6Nhn6.js (removed) 2.2 kB — 🟢 -2.2 kB 🟢 -1 kB 🟢 -892 B
assets/SubscribeToRun-Bb5z9K-z.js (new) — 2.13 kB 🔴 +2.13 kB 🔴 +984 B 🔴 +884 B
assets/SubscribeToRun-DFRbveRM.js (removed) 2.13 kB — 🟢 -2.13 kB 🟢 -982 B 🟢 -880 B
assets/MediaAudioTop-CAftmLWr.js (removed) 2.08 kB — 🟢 -2.08 kB 🟢 -1.01 kB 🟢 -858 B
assets/MediaAudioTop-DACLrVZp.js (new) — 2.08 kB 🔴 +2.08 kB 🔴 +1 kB 🔴 +857 B
assets/cloudBadges-DYDYm3RY.js (new) — 1.93 kB 🔴 +1.93 kB 🔴 +960 B 🔴 +834 B
assets/cloudBadges-yNydaZag.js (removed) 1.93 kB — 🟢 -1.93 kB 🟢 -961 B 🟢 -834 B
assets/cloudSubscription-BpPOfIjp.js (removed) 1.85 kB — 🟢 -1.85 kB 🟢 -883 B 🟢 -767 B
assets/cloudSubscription-SITcZMC_.js (new) — 1.85 kB 🔴 +1.85 kB 🔴 +882 B 🔴 +765 B
assets/graphHasMissingNodes-Blh2aJVX.js (removed) 1.84 kB — 🟢 -1.84 kB 🟢 -862 B 🟢 -777 B
assets/graphHasMissingNodes-CZh_DAAy.js (new) — 1.84 kB 🔴 +1.84 kB 🔴 +860 B 🔴 +758 B
assets/signInSchema-aIdpYbBG.js (removed) 1.6 kB — 🟢 -1.6 kB 🟢 -585 B 🟢 -516 B
assets/signInSchema-tIQFdE1l.js (new) — 1.6 kB 🔴 +1.6 kB 🔴 +586 B 🔴 +513 B
assets/Load3D-1vPRX1GM.js (removed) 1.55 kB — 🟢 -1.55 kB 🟢 -694 B 🟢 -625 B
assets/Load3D-CseJdvqx.js (new) — 1.55 kB 🔴 +1.55 kB 🔴 +696 B 🔴 +620 B
assets/previousFullPath-j_xG7VIh.js (new) — 1.53 kB 🔴 +1.53 kB 🔴 +694 B 🔴 +595 B
assets/previousFullPath-zUvHKGi5.js (removed) 1.53 kB — 🟢 -1.53 kB 🟢 -694 B 🟢 -596 B
assets/nightlyBadges-BTaOwJ2p.js (removed) 1.46 kB — 🟢 -1.46 kB 🟢 -729 B 🟢 -650 B
assets/nightlyBadges-BYIRlJf8.js (new) — 1.46 kB 🔴 +1.46 kB 🔴 +731 B 🔴 +666 B
assets/Load3dViewerContent-B4sJkczw.js (new) — 1.43 kB 🔴 +1.43 kB 🔴 +647 B 🔴 +575 B
assets/Load3dViewerContent-Db5ur-33.js (removed) 1.43 kB — 🟢 -1.43 kB 🟢 -648 B 🟢 -580 B
assets/SubscriptionPanelContentWorkspace-BVjzGSU8.js (new) — 1.32 kB 🔴 +1.32 kB 🔴 +603 B 🔴 +527 B
assets/SubscriptionPanelContentWorkspace-fUfw3lrs.js (removed) 1.32 kB — 🟢 -1.32 kB 🟢 -599 B 🟢 -527 B
assets/WidgetLegacy-tzh7VgVY.js (removed) 1.15 kB — 🟢 -1.15 kB 🟢 -549 B 🟢 -488 B
assets/WidgetLegacy-yLVO33Wq.js (new) — 1.15 kB 🔴 +1.15 kB 🔴 +550 B 🔴 +485 B
assets/changeTracker-ClNC9geo.js (new) — 1.12 kB 🔴 +1.12 kB 🔴 +538 B 🔴 +472 B
assets/changeTracker-DR4ZrTbR.js (removed) 1.12 kB — 🟢 -1.12 kB 🟢 -538 B 🟢 -475 B

Status: 58 added / 58 removed / 77 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 50.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.7 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 51.5 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.0 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.4 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 47.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 165.6 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 148.4 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 50.2 MB heap

No regressions detected.

All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms +0% z=-0.1
canvas-idle: p95 frame time 17ms 17ms -1% —
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 9ms 9ms +3% z=-2.3
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 9 11 +22% z=-0.3
canvas-idle: task duration 467ms 352ms -25% z=-1.4
canvas-idle: script duration 28ms 20ms -29% z=-2.4
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 65.4 MB 64.2 MB -2% —
canvas-idle: DOM nodes 18 22 +22% z=-0.5
canvas-idle: event listeners 4 6 +50% z=-1.2
canvas-mouse-sweep: avg frame time 17ms 17ms +0% z=-0.4
canvas-mouse-sweep: p95 frame time 17ms 17ms -1% —
canvas-mouse-sweep: layout duration 4ms 4ms -2% z=1.0
canvas-mouse-sweep: style recalc duration 41ms 39ms -5% z=-1.1
canvas-mouse-sweep: layout count 12 12 +0% —
canvas-mouse-sweep: style recalc count 74 77 +4% z=-0.7
canvas-mouse-sweep: task duration 829ms 823ms -1% z=-0.7
canvas-mouse-sweep: script duration 125ms 126ms +1% z=-1.5
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 46.4 MB 50.2 MB +8% —
canvas-mouse-sweep: DOM nodes -264 -258 -2% z=-123.8
canvas-mouse-sweep: event listeners -131 -127 -3% z=-32.5
canvas-zoom-sweep: avg frame time 17ms 17ms +0% z=0.5
canvas-zoom-sweep: p95 frame time 17ms 17ms -0% —
canvas-zoom-sweep: layout duration 1ms 1ms -14% z=0.2
canvas-zoom-sweep: style recalc duration 19ms 17ms -10% z=-1.4
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 31 30 -3% z=-2.8
canvas-zoom-sweep: task duration 348ms 308ms -11% z=-0.8
canvas-zoom-sweep: script duration 27ms 24ms -13% z=-1.1
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 47.1 MB 68.7 MB +46% —
canvas-zoom-sweep: DOM nodes 77 79 +3% z=-0.3
canvas-zoom-sweep: event listeners 19 21 +11% z=-0.5
dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.1
dom-widget-clipping: p95 frame time 17ms 17ms +0% —
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 9ms 8ms -15% z=-2.5
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 13 12 -8% z=-2.2
dom-widget-clipping: task duration 379ms 340ms -10% z=-1.5
dom-widget-clipping: script duration 70ms 58ms -16% z=-3.0
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 51.8 MB 51.5 MB -1% —
dom-widget-clipping: DOM nodes 21 20 -5% z=-1.5
dom-widget-clipping: event listeners 0 2 — variance too high
large-graph-idle: avg frame time 17ms 17ms +0% z=-0.2
large-graph-idle: p95 frame time 17ms 17ms +1% —
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 9ms 8ms -20% z=-4.5
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 9 8 -11% z=-11.5
large-graph-idle: task duration 637ms 565ms -11% z=0.4
large-graph-idle: script duration 102ms 89ms -12% z=-1.3
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 64.4 MB 63.0 MB -2% —
large-graph-idle: DOM nodes -262 -263 +0% z=-318.3
large-graph-idle: event listeners -127 -127 +0% z=-25.1
large-graph-pan: avg frame time 17ms 17ms +0% z=0.3
large-graph-pan: p95 frame time 17ms 17ms +1% —
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 20ms 17ms -12% z=0.2
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 68 68 +0% z=-2.4
large-graph-pan: task duration 1246ms 1133ms -9% z=1.2
large-graph-pan: script duration 449ms 382ms -15% z=-1.3
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 62.7 MB 65.9 MB +5% —
large-graph-pan: DOM nodes -267 -262 -2% z=-170.3
large-graph-pan: event listeners -125 -125 +0% z=-156.9
large-graph-zoom: avg frame time 17ms 17ms +0% —
large-graph-zoom: p95 frame time 17ms 17ms +0% —
large-graph-zoom: layout duration 9ms 8ms -14% —
large-graph-zoom: style recalc duration 19ms 19ms -0% —
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 64 65 +2% —
large-graph-zoom: task duration 1391ms 1322ms -5% —
large-graph-zoom: script duration 505ms 461ms -9% —
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 71.9 MB 66.3 MB -8% —
large-graph-zoom: DOM nodes -268 -267 -0% —
large-graph-zoom: event listeners -125 -123 -2% —
minimap-idle: avg frame time 17ms 17ms +0% z=0.1
minimap-idle: p95 frame time 17ms 17ms +0% —
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 8ms 8ms -8% z=-2.5
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 8 8 +0% z=-2.3
minimap-idle: task duration 651ms 537ms -17% z=0.2
minimap-idle: script duration 105ms 84ms -20% z=-1.5
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 68.3 MB 61.4 MB -10% —
minimap-idle: DOM nodes -266 -266 +0% z=-208.5
minimap-idle: event listeners -127 -127 +0% z=-199.3
subgraph-dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.1
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms -1% —
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 13ms 11ms -15% z=-1.6
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 48 47 -2% z=-1.6
subgraph-dom-widget-clipping: task duration 393ms 355ms -10% z=-1.3
subgraph-dom-widget-clipping: script duration 138ms 119ms -14% z=-1.4
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 52.1 MB 53.2 MB +2% —
subgraph-dom-widget-clipping: DOM nodes 21 20 -5% z=-1.9
subgraph-dom-widget-clipping: event listeners 6 8 +33% z=-1.4
subgraph-idle: avg frame time 17ms 17ms +0% z=0.4
subgraph-idle: p95 frame time 17ms 17ms +1% —
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 9ms 9ms -4% z=-2.4
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 9 10 +11% z=-1.4
subgraph-idle: task duration 402ms 371ms -8% z=0.0
subgraph-idle: script duration 18ms 17ms -6% z=-1.2
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 66.2 MB 64.4 MB -3% —
subgraph-idle: DOM nodes 18 20 +11% z=-1.2
subgraph-idle: event listeners 4 6 +50% variance too high
subgraph-mouse-sweep: avg frame time 17ms 17ms +0% z=0.4
subgraph-mouse-sweep: p95 frame time 17ms 17ms +0% —
subgraph-mouse-sweep: layout duration 5ms 4ms -10% z=-0.8
subgraph-mouse-sweep: style recalc duration 42ms 44ms +5% z=0.4
subgraph-mouse-sweep: layout count 16 16 +0% —
subgraph-mouse-sweep: style recalc count 76 76 +0% z=-2.1
subgraph-mouse-sweep: task duration 760ms 805ms +6% z=0.6
subgraph-mouse-sweep: script duration 98ms 96ms -2% z=-0.8
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 47.3 MB 47.3 MB +0% —
subgraph-mouse-sweep: DOM nodes -261 -256 -2% z=-144.5
subgraph-mouse-sweep: event listeners -129 -129 +0% variance too high
viewport-pan-sweep: avg frame time 17ms 17ms +0% —
viewport-pan-sweep: p95 frame time 17ms 17ms -1% —
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 60ms 53ms -13% —
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 250 250 +0% —
viewport-pan-sweep: task duration 4038ms 3753ms -7% —
viewport-pan-sweep: script duration 1261ms 1215ms -4% —
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 66.4 MB 72.3 MB +9% —
viewport-pan-sweep: DOM nodes -264 -261 -1% —
viewport-pan-sweep: event listeners -111 -111 +0% —
vue-large-graph-idle: avg frame time 18ms 17ms -3% —
vue-large-graph-idle: p95 frame time 17ms 17ms +0% —
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 13847ms 10628ms -23% —
vue-large-graph-idle: script duration 670ms 575ms -14% —
vue-large-graph-idle: TBT 0ms 0ms +0% —
vue-large-graph-idle: heap used 159.9 MB 165.6 MB +4% —
vue-large-graph-idle: DOM nodes -9850 -9849 -0% —
vue-large-graph-idle: event listeners -23957 -23961 +0% —
vue-large-graph-pan: avg frame time 17ms 17ms +0% —
vue-large-graph-pan: p95 frame time 17ms 17ms +0% —
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 21ms 17ms -19% —
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 83 66 -20% —
vue-large-graph-pan: task duration 15723ms 12808ms -19% —
vue-large-graph-pan: script duration 922ms 854ms -7% —
vue-large-graph-pan: TBT 0ms 0ms +0% —
vue-large-graph-pan: heap used 158.3 MB 148.4 MB -6% —
vue-large-graph-pan: DOM nodes -9848 -9850 +0% —
vue-large-graph-pan: event listeners -23983 -23955 -0% —
workflow-execution: avg frame time 17ms 17ms +0% z=-0.4
workflow-execution: p95 frame time 17ms 17ms -1% —
workflow-execution: layout duration 2ms 2ms -9% z=0.2
workflow-execution: style recalc duration 26ms 23ms -11% z=-0.6
workflow-execution: layout count 5 5 +0% z=0.1
workflow-execution: style recalc count 21 16 -24% z=-0.9
workflow-execution: task duration 153ms 130ms -15% z=0.6
workflow-execution: script duration 27ms 24ms -12% z=-1.6
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 49.6 MB 50.2 MB +1% —
workflow-execution: DOM nodes 180 154 -14% z=-1.0
workflow-execution: event listeners 69 71 +3% z=4.4
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 11ms 1ms 8.2%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 11 1 5.0%
canvas-idle: task duration 395ms 31ms 7.9%
canvas-idle: script duration 25ms 2ms 8.8%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: DOM nodes 23 1 5.6%
canvas-idle: event listeners 12 5 40.9%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: layout duration 4ms 0ms 5.4%
canvas-mouse-sweep: style recalc duration 43ms 3ms 7.4%
canvas-mouse-sweep: layout count 12 0 0.0%
canvas-mouse-sweep: style recalc count 79 2 3.0%
canvas-mouse-sweep: task duration 865ms 58ms 6.7%
canvas-mouse-sweep: script duration 136ms 6ms 4.8%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: DOM nodes 62 3 4.2%
canvas-mouse-sweep: event listeners 8 4 49.4%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: layout duration 1ms 0ms 7.0%
canvas-zoom-sweep: style recalc duration 19ms 2ms 8.0%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 0 1.5%
canvas-zoom-sweep: task duration 327ms 23ms 7.1%
canvas-zoom-sweep: script duration 27ms 3ms 11.1%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: DOM nodes 79 1 1.0%
canvas-zoom-sweep: event listeners 24 5 21.8%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 10ms 1ms 8.0%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 13 0 3.8%
dom-widget-clipping: task duration 365ms 16ms 4.5%
dom-widget-clipping: script duration 68ms 3ms 4.8%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: DOM nodes 22 1 6.4%
dom-widget-clipping: event listeners 8 6 81.2%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 12ms 1ms 8.6%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 12 0 2.7%
large-graph-idle: task duration 542ms 54ms 10.0%
large-graph-idle: script duration 102ms 11ms 10.3%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: DOM nodes 25 1 3.7%
large-graph-idle: event listeners 26 6 23.2%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 17ms 1ms 4.6%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 70 1 0.9%
large-graph-pan: task duration 1082ms 43ms 4.0%
large-graph-pan: script duration 408ms 20ms 4.8%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: DOM nodes 19 2 8.7%
large-graph-pan: event listeners 5 1 16.8%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 10ms 1ms 8.6%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 10 1 7.1%
minimap-idle: task duration 527ms 47ms 9.0%
minimap-idle: script duration 98ms 10ms 10.1%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: DOM nodes 19 1 7.1%
minimap-idle: event listeners 5 1 14.4%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 13ms 1ms 7.4%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 48 1 1.2%
subgraph-dom-widget-clipping: task duration 378ms 18ms 4.9%
subgraph-dom-widget-clipping: script duration 128ms 6ms 4.9%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: DOM nodes 22 1 5.0%
subgraph-dom-widget-clipping: event listeners 16 6 36.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 10ms 1ms 7.5%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 11 1 6.0%
subgraph-idle: task duration 370ms 31ms 8.5%
subgraph-idle: script duration 20ms 3ms 13.2%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: DOM nodes 22 1 6.9%
subgraph-idle: event listeners 10 7 64.5%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: layout duration 5ms 0ms 6.8%
subgraph-mouse-sweep: style recalc duration 42ms 3ms 7.8%
subgraph-mouse-sweep: layout count 16 0 0.0%
subgraph-mouse-sweep: style recalc count 80 2 2.4%
subgraph-mouse-sweep: task duration 766ms 69ms 9.0%
subgraph-mouse-sweep: script duration 101ms 7ms 6.5%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: DOM nodes 67 2 3.3%
subgraph-mouse-sweep: event listeners 8 4 52.6%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: layout duration 2ms 0ms 9.4%
workflow-execution: style recalc duration 24ms 2ms 9.1%
workflow-execution: layout count 5 1 11.0%
workflow-execution: style recalc count 18 2 11.5%
workflow-execution: task duration 123ms 11ms 8.8%
workflow-execution: script duration 29ms 3ms 10.2%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: DOM nodes 161 7 4.4%
workflow-execution: event listeners 52 4 8.4%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▆▃▆▁▆▃▆█▆▆▄▃▃▄▃ ➡️ 17ms
canvas-idle: p95 frame time ➡️ NaNms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▇▇▆▆▃█▄▃▄▃▇▄▁▆▇ ➡️ 11ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count █▃▅▂▅▆▃▁▂▁▂▅▆▅▆ ➡️ 12
canvas-idle: task duration ▃▃▃▆▂▃▃▅▆▂█▃▁▃▃ ➡️ 391ms
canvas-idle: script duration ▄▃▅▇▂▅▃▆▇▅█▄▁▅▆ ➡️ 27ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ➡️ NaN MB
canvas-idle: DOM nodes █▇▆▅▃▇▃▁▂▂▅▆▆▆▇ ➡️ 24
canvas-idle: event listeners ▅█▅▄▁▅▁▁▁▄▅▅▁▅▄ 📉 11
canvas-mouse-sweep: avg frame time ▆█▆▃▁▃▁▆▆▁▃▆▆▃▃ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ➡️ NaNms
canvas-mouse-sweep: layout duration ▁▃▂▄▁▂▁▃▆▂█▇▆▄▃ ➡️ 4ms
canvas-mouse-sweep: style recalc duration ▄▄▂▄▁▂▃▃▅▄█▆▂▄▄ ➡️ 43ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: style recalc count █▅▄▃▂▂▁▄▄▅▆▅▂▇▄ ➡️ 79
canvas-mouse-sweep: task duration █▆▄▂▂▃▂▄▄▅█▆▁▆▄ ➡️ 868ms
canvas-mouse-sweep: script duration ▄▅▄▆▄▆▆▆▅▅█▆▁▅▆ ➡️ 139ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ➡️ NaN MB
canvas-mouse-sweep: DOM nodes █▅▃▃▁▂▂▃▂▄▆▅▃▅▅ ➡️ 64
canvas-mouse-sweep: event listeners █▁▁▁▁▁▇▁▁▁██▇▁█ 📈 13
canvas-zoom-sweep: avg frame time ▅▅█▄▅▁▁▁▅▁▁▅▄▅▁ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ➡️ NaNms
canvas-zoom-sweep: layout duration ▆▅▅▄▁▁█▅▃▅▇▆▁▂▆ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▆▅▄▆▅▃█▆▇▅▇▄▁▃▅ ➡️ 20ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▁▁▃▄▆▃▆█▄▄▆▁▆▁▆ ➡️ 32
canvas-zoom-sweep: task duration ▄▂▁▇▂▂▄▅▆▃█▄▁▁▅ ➡️ 338ms
canvas-zoom-sweep: script duration ▃▃▂▇▂▂▅▇▆▅█▄▁▂▆ ➡️ 30ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ➡️ NaN MB
canvas-zoom-sweep: DOM nodes ▄▃▁▅█▁▃▆▄▅▅▃▃▄▃ ➡️ 79
canvas-zoom-sweep: event listeners ▁▁▂▅█▂▁▅▁▅▅▄▁▅▁ ➡️ 19
dom-widget-clipping: avg frame time ▂▄▅▅▂▄█▇▅▇▇▅▅▁▇ ➡️ 17ms
dom-widget-clipping: p95 frame time ➡️ NaNms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▆▆▂▆▄▃██▄▁▆▇▆▃▅ ➡️ 10ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▇█▅█▅▄█▇▇▁▇▄▇▂▅ ➡️ 13
dom-widget-clipping: task duration ▃▃▁▅▄▃▅▆▅▂▇█▁▅▅ ➡️ 371ms
dom-widget-clipping: script duration ▅▄▄▆▆▅▇▇▆▃█▇▁▇▇ ➡️ 71ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ➡️ NaN MB
dom-widget-clipping: DOM nodes ▇▇▄▇▅▄█▇▅▁▅▄▇▃▄ ➡️ 21
dom-widget-clipping: event listeners ▅▅▅▅▁▅██▁▁▁▁█▁▁ 📉 2
large-graph-idle: avg frame time ▅▅▅▅▅▂▁▂▄▅▄▂▂▅█ ➡️ 17ms
large-graph-idle: p95 frame time ➡️ NaNms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▅▅▅▆▄▅▃▄▅▅▆█▁▄▆ ➡️ 13ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count █▆█▃▃▁▃▆▃▆▆▃▆██ ➡️ 12
large-graph-idle: task duration ▂▃▂▆▂▃▃▇▅▃██▁▂▅ ➡️ 569ms
large-graph-idle: script duration ▄▅▄▆▄▅▅▇▆▅█▆▁▃▆ ➡️ 110ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ➡️ NaN MB
large-graph-idle: DOM nodes ▆█▅▂▅▃▁▂▃▅▅▆▂▆▅ ➡️ 25
large-graph-idle: event listeners ███▇██▄▁▄▇▇█▂█▇ ➡️ 29
large-graph-pan: avg frame time ▆▃▃▆█▃▁█▆▆▆▆█▁▆ ➡️ 17ms
large-graph-pan: p95 frame time ➡️ NaNms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▂▄▄▁▅▂▂▁▄▄█▃▁▂ ➡️ 17ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▆▃█▂▃▂▂▂▁▇▅▃█▆▃ ➡️ 69
large-graph-pan: task duration ▄▃▄▆▄▄▄▆▄▄█▆▁▂▅ ➡️ 1100ms
large-graph-pan: script duration ▅▄▅▆▆▅▄▆▄▅█▄▁▄▅ ➡️ 413ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ➡️ NaN MB
large-graph-pan: DOM nodes ▅▃▆▂▄▁▃▁▁▅▁▂█▅▂ ➡️ 18
large-graph-pan: event listeners █▆█▁▁▆▁▁▃▆▁▃██▃ ➡️ 5
minimap-idle: avg frame time ▃▆▆▃█▁█▆▆▃▃▆█▆█ ➡️ 17ms
minimap-idle: p95 frame time ➡️ NaNms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▄█▁█▅▅█▅▅▃▅▁▁▄▆ ➡️ 10ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 9
minimap-idle: task duration ▃▄▁▅▁▃▄▅▇▃█▅▁▁▅ ➡️ 547ms
minimap-idle: script duration ▄▆▃▇▃▅▆▆▇▅█▅▁▃▆ ➡️ 106ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ➡️ NaN MB
minimap-idle: DOM nodes ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 19
minimap-idle: event listeners ▃▃▆▁▁▁▃▁▁▆▁▃█▆▁ ➡️ 4
subgraph-dom-widget-clipping: avg frame time ▅▄▄▄▄▄█▄▄▄▃▁▆▃▃ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ➡️ NaNms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▂▄▃▅▅▃▂▅▇▃▄█▁▄▆ ➡️ 14ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▇█▆▃▆▃▁▆█▇▃▆▇█▅ ➡️ 48
subgraph-dom-widget-clipping: task duration ▂▃▃▆▅▅▂▅█▂▆█▁▂▇ ➡️ 398ms
subgraph-dom-widget-clipping: script duration ▃▃▃▄▅▅▂▄█▂▅▇▁▂▅ ➡️ 131ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ➡️ NaN MB
subgraph-dom-widget-clipping: DOM nodes ▅▇▅▂▅▂▁▅▅▅▁▇▅█▄ ➡️ 22
subgraph-dom-widget-clipping: event listeners ▅▅▅▂▅▁▅██▁▁█▅█▅ 📈 16
subgraph-idle: avg frame time ▆▆█▁▆▃▆▆▆▃▆▁▃▆█ ➡️ 17ms
subgraph-idle: p95 frame time ➡️ NaNms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▁▇▃▆▂▄▂▃▃▆▆▄▃▇█ ➡️ 12ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▃▆▃▃▂▅▁▂▁▆▃▃██▇ ➡️ 12
subgraph-idle: task duration ▁▃▁▇▁▁▃▆▅▂█▅▁▁▄ ➡️ 378ms
subgraph-idle: script duration ▁▃▂▇▁▂▃▇▆▂█▅▂▁▅ ➡️ 22ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ➡️ NaN MB
subgraph-idle: DOM nodes ▃▅▃▂▁▄▁▂▁▅▃▂▇█▇ ➡️ 24
subgraph-idle: event listeners ▁▅▁▁▁▁▁▁▁▅▄▁███ 📈 21
subgraph-mouse-sweep: avg frame time ▅▄▁▃▃▄▆▄▆▃▃█▁▃▃ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ➡️ NaNms
subgraph-mouse-sweep: layout duration ▁▄▄▄▃▃▅▅▅▂█▇▂▃▆ ➡️ 5ms
subgraph-mouse-sweep: style recalc duration ▃▂▄▅▂▃▄▅█▃█▆▁▂▅ ➡️ 43ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: style recalc count ▅▂▅▅▁▄▃▅█▅▆▄▂▄▅ ➡️ 81
subgraph-mouse-sweep: task duration ▃▂▄▅▂▄▄▅▇▄█▆▁▃▅ ➡️ 785ms
subgraph-mouse-sweep: script duration ▄▅▄▇▅▅▆▇▆▅██▁▄▆ ➡️ 105ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ➡️ NaN MB
subgraph-mouse-sweep: DOM nodes ▅▁▄▅▁▄▃▃█▅▅▄▂▅▃ ➡️ 66
subgraph-mouse-sweep: event listeners ▇▁▂▇▁▂▂▂█▇▂▂▇▇▂ 📈 5
workflow-execution: avg frame time ▆▆▆▄▆▆▃▄▁▄█▆▅▄▆ ➡️ 17ms
workflow-execution: p95 frame time ➡️ NaNms
workflow-execution: layout duration ▁▆▁▃▂▄▃▂▃▃▅█▄▂▅ ➡️ 2ms
workflow-execution: style recalc duration ▃▇▅▇▁▅▆▇█▁██▂▄▆ ➡️ 25ms
workflow-execution: layout count ▁█▂▃▂▃▃▁▃▃▄▃▂▃▂ ➡️ 5
workflow-execution: style recalc count ▃█▅▇▁▄▅▆▅▅▅▅▄▄▂ ➡️ 15
workflow-execution: task duration ▂▅▄▅▁▄▆▆▆▁▇█▁▃▃ ➡️ 120ms
workflow-execution: script duration ▄▃▄▄▃▅▄▅▆▂▇█▁▃▄ ➡️ 29ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ➡️ NaN MB
workflow-execution: DOM nodes ▂█▃▆▁▄▃▅▃█▃▃▄▃▁ ➡️ 152
workflow-execution: event listeners ▅███▁▅███▁██▅█▅ ➡️ 49
Raw data
{
  "timestamp": "2026-04-29T06:01:34.351Z",
  "gitSha": "045a6c35d0ed7a17d3927f440d6158d73528dc36",
  "branch": "fix/subgraph-promoted-widget-inline-state",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2052.6089999999613,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.547000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 390.77099999999996,
      "heapDeltaBytes": 1130632,
      "heapUsedBytes": 67292540,
      "domNodes": 22,
      "jsHeapTotalBytes": 19234816,
      "scriptDurationMs": 23.977999999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2013.826999999992,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.546999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 351.551,
      "heapDeltaBytes": 22925828,
      "heapUsedBytes": 71584996,
      "domNodes": 18,
      "jsHeapTotalBytes": 14417920,
      "scriptDurationMs": 17.405000000000005,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2003.9379999999483,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.812999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 345.831,
      "heapDeltaBytes": 1221380,
      "heapUsedBytes": 67301488,
      "domNodes": 22,
      "jsHeapTotalBytes": 19759104,
      "scriptDurationMs": 19.970000000000002,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1921.3320000000067,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 43.38,
      "layouts": 12,
      "layoutDurationMs": 3.8120000000000003,
      "taskDurationMs": 822.827,
      "heapDeltaBytes": -1755428,
      "heapUsedBytes": 66641424,
      "domNodes": 62,
      "jsHeapTotalBytes": 20185088,
      "scriptDurationMs": 126.01199999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1811.2179999999398,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 36.257,
      "layouts": 12,
      "layoutDurationMs": 3.8989999999999996,
      "taskDurationMs": 814.6379999999999,
      "heapDeltaBytes": -20780172,
      "heapUsedBytes": 45262944,
      "domNodes": -259,
      "jsHeapTotalBytes": 20410368,
      "scriptDurationMs": 119.175,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1875.774999999976,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 39.167,
      "layouts": 12,
      "layoutDurationMs": 3.6929999999999996,
      "taskDurationMs": 839.477,
      "heapDeltaBytes": -13866788,
      "heapUsedBytes": 52686180,
      "domNodes": -258,
      "jsHeapTotalBytes": 19099648,
      "scriptDurationMs": 127.40700000000002,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1741.9759999999656,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 18.185,
      "layouts": 6,
      "layoutDurationMs": 0.652,
      "taskDurationMs": 330.055,
      "heapDeltaBytes": 5932100,
      "heapUsedBytes": 71918596,
      "domNodes": 79,
      "jsHeapTotalBytes": 19759104,
      "scriptDurationMs": 29.003,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1710.4950000000372,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 16.389,
      "layouts": 6,
      "layoutDurationMs": 0.7490000000000001,
      "taskDurationMs": 295.036,
      "heapDeltaBytes": 5577536,
      "heapUsedBytes": 72004716,
      "domNodes": 76,
      "jsHeapTotalBytes": 18972672,
      "scriptDurationMs": 18.381,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1724.8220000000174,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 17.014,
      "layouts": 6,
      "layoutDurationMs": 0.644,
      "taskDurationMs": 307.974,
      "heapDeltaBytes": 5927048,
      "heapUsedBytes": 72370560,
      "domNodes": 79,
      "jsHeapTotalBytes": 18710528,
      "scriptDurationMs": 23.725,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 576.7369999999801,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 8.896999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 359.115,
      "heapDeltaBytes": -11992644,
      "heapUsedBytes": 54164524,
      "domNodes": 22,
      "jsHeapTotalBytes": 19759104,
      "scriptDurationMs": 58.17099999999999,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 519.3110000000161,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.279000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 339.5199999999999,
      "heapDeltaBytes": -12486804,
      "heapUsedBytes": 54021908,
      "domNodes": 18,
      "jsHeapTotalBytes": 18710528,
      "scriptDurationMs": 52.14600000000001,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 538.2690000000139,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.908999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 335.804,
      "heapDeltaBytes": -12359660,
      "heapUsedBytes": 53763500,
      "domNodes": 20,
      "jsHeapTotalBytes": 20283392,
      "scriptDurationMs": 58.184,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2012.8469999999652,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.481999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 568.805,
      "heapDeltaBytes": 6893744,
      "heapUsedBytes": 66426912,
      "domNodes": -263,
      "jsHeapTotalBytes": 3497984,
      "scriptDurationMs": 87.943,
      "eventListeners": -129,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2068.0990000000747,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.135000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 557.0500000000001,
      "heapDeltaBytes": 11182732,
      "heapUsedBytes": 66109636,
      "domNodes": -260,
      "jsHeapTotalBytes": -491520,
      "scriptDurationMs": 92.39500000000001,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2024.925000000053,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.551000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 564.717,
      "heapDeltaBytes": 7499932,
      "heapUsedBytes": 65784724,
      "domNodes": -265,
      "jsHeapTotalBytes": -229376,
      "scriptDurationMs": 89.26599999999999,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2119.3850000000225,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 17.286,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1133.373,
      "heapDeltaBytes": 8502544,
      "heapUsedBytes": 69093620,
      "domNodes": -260,
      "jsHeapTotalBytes": -24576,
      "scriptDurationMs": 385.276,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2129.82599999998,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 17.472,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1111.564,
      "heapDeltaBytes": 11571900,
      "heapUsedBytes": 72182432,
      "domNodes": -262,
      "jsHeapTotalBytes": 4198400,
      "scriptDurationMs": 382.07,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2120.9749999999303,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 18.15,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1134.548,
      "heapDeltaBytes": 1198376,
      "heapUsedBytes": 59449972,
      "domNodes": -263,
      "jsHeapTotalBytes": 958464,
      "scriptDurationMs": 379.116,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3149.633999999992,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 27.479,
      "layouts": 60,
      "layoutDurationMs": 7.643000000000001,
      "taskDurationMs": 1347.485,
      "heapDeltaBytes": 9077556,
      "heapUsedBytes": 69520984,
      "domNodes": -268,
      "jsHeapTotalBytes": 229376,
      "scriptDurationMs": 460.77299999999997,
      "eventListeners": -123,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3149.1439999999784,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 17.953,
      "layouts": 60,
      "layoutDurationMs": 7.5329999999999995,
      "taskDurationMs": 1308.504,
      "heapDeltaBytes": 16197520,
      "heapUsedBytes": 75711844,
      "domNodes": -267,
      "jsHeapTotalBytes": -229376,
      "scriptDurationMs": 454.456,
      "eventListeners": -123,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3138.2770000000164,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 19.429000000000002,
      "layouts": 60,
      "layoutDurationMs": 7.8069999999999995,
      "taskDurationMs": 1322.284,
      "heapDeltaBytes": 8574856,
      "heapUsedBytes": 69189280,
      "domNodes": -267,
      "jsHeapTotalBytes": 4423680,
      "scriptDurationMs": 462.5400000000001,
      "eventListeners": -123,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2024.675000000002,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.518000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 553.72,
      "heapDeltaBytes": 2810876,
      "heapUsedBytes": 63069116,
      "domNodes": -266,
      "jsHeapTotalBytes": 32768,
      "scriptDurationMs": 88.37,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2026.90599999994,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.542,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 523.303,
      "heapDeltaBytes": 6306296,
      "heapUsedBytes": 64352476,
      "domNodes": -266,
      "jsHeapTotalBytes": 557056,
      "scriptDurationMs": 83.01099999999998,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2029.6869999999672,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.68,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 537.473,
      "heapDeltaBytes": 12666444,
      "heapUsedBytes": 72855832,
      "domNodes": -262,
      "jsHeapTotalBytes": 294912,
      "scriptDurationMs": 83.652,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 541.6180000000281,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.153000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 365.41400000000004,
      "heapDeltaBytes": -11778736,
      "heapUsedBytes": 54683564,
      "domNodes": 20,
      "jsHeapTotalBytes": 19759104,
      "scriptDurationMs": 120.98500000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 546.3730000000169,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 11.254,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 355.131,
      "heapDeltaBytes": -10780132,
      "heapUsedBytes": 55776544,
      "domNodes": 21,
      "jsHeapTotalBytes": 20971520,
      "scriptDurationMs": 117.46499999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 556.7300000000159,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.144,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 353.52099999999996,
      "heapDeltaBytes": 9081936,
      "heapUsedBytes": 57590456,
      "domNodes": 16,
      "jsHeapTotalBytes": 15728640,
      "scriptDurationMs": 119.114,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1998.7240000000384,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.963000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 374.95200000000006,
      "heapDeltaBytes": 959256,
      "heapUsedBytes": 67519216,
      "domNodes": 20,
      "jsHeapTotalBytes": 19234816,
      "scriptDurationMs": 18.09499999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2012.3669999999265,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.636,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 370.81899999999996,
      "heapDeltaBytes": 699460,
      "heapUsedBytes": 67426820,
      "domNodes": 18,
      "jsHeapTotalBytes": 18972672,
      "scriptDurationMs": 16.989000000000004,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1988.9419999999518,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.534,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 340.458,
      "heapDeltaBytes": 1322304,
      "heapUsedBytes": 67782052,
      "domNodes": 21,
      "jsHeapTotalBytes": 18972672,
      "scriptDurationMs": 16.049,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1760.4460000000017,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 43.958,
      "layouts": 16,
      "layoutDurationMs": 5.707,
      "taskDurationMs": 804.861,
      "heapDeltaBytes": -4069412,
      "heapUsedBytes": 44459308,
      "domNodes": -261,
      "jsHeapTotalBytes": 14807040,
      "scriptDurationMs": 95.836,
      "eventListeners": -129,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 2021.861000000058,
      "styleRecalcs": 86,
      "styleRecalcDurationMs": 46.883,
      "layouts": 16,
      "layoutDurationMs": 4.431,
      "taskDurationMs": 990.317,
      "heapDeltaBytes": -17092768,
      "heapUsedBytes": 49562160,
      "domNodes": -256,
      "jsHeapTotalBytes": 18837504,
      "scriptDurationMs": 96.11200000000001,
      "eventListeners": -129,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1687.0209999999588,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 35.409,
      "layouts": 16,
      "layoutDurationMs": 4.421,
      "taskDurationMs": 682.5799999999999,
      "heapDeltaBytes": -5469568,
      "heapUsedBytes": 62661772,
      "domNodes": 61,
      "jsHeapTotalBytes": 19136512,
      "scriptDurationMs": 84.619,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8182.598999999982,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 54.995999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3896.5449999999996,
      "heapDeltaBytes": 19950200,
      "heapUsedBytes": 75833600,
      "domNodes": -259,
      "jsHeapTotalBytes": 2072576,
      "scriptDurationMs": 1259.478,
      "eventListeners": -111,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8132.75699999997,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 51.73799999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3649.043,
      "heapDeltaBytes": 19259852,
      "heapUsedBytes": 78943764,
      "domNodes": -261,
      "jsHeapTotalBytes": 5509120,
      "scriptDurationMs": 1177.154,
      "eventListeners": -111,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8170.916000000034,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 52.528,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3752.8250000000003,
      "heapDeltaBytes": 9253844,
      "heapUsedBytes": 67435320,
      "domNodes": -263,
      "jsHeapTotalBytes": 1548288,
      "scriptDurationMs": 1215.282,
      "eventListeners": -111,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 10641.921999999966,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10627.566,
      "heapDeltaBytes": -44077464,
      "heapUsedBytes": 173661800,
      "domNodes": -9850,
      "jsHeapTotalBytes": 25489408,
      "scriptDurationMs": 575.093,
      "eventListeners": -23961,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333237,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 10736.810999999989,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10719.977,
      "heapDeltaBytes": -39378584,
      "heapUsedBytes": 182433544,
      "domNodes": -9845,
      "jsHeapTotalBytes": 24702976,
      "scriptDurationMs": 576.463,
      "eventListeners": -23961,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 10564.614000000005,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10551.435000000001,
      "heapDeltaBytes": -57440112,
      "heapUsedBytes": 171564564,
      "domNodes": -9849,
      "jsHeapTotalBytes": 22605824,
      "scriptDurationMs": 571.643,
      "eventListeners": -23965,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.329999999999927,
      "p95FrameDurationMs": 33.39999999999782
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 12950.071999999978,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 17.132000000000037,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12932.078000000001,
      "heapDeltaBytes": -66901592,
      "heapUsedBytes": 155403200,
      "domNodes": -9852,
      "jsHeapTotalBytes": -13045760,
      "scriptDurationMs": 868.7589999999999,
      "eventListeners": -23955,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 12500.854000000003,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 16.75500000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12482.979999999998,
      "heapDeltaBytes": -49854048,
      "heapUsedBytes": 171484128,
      "domNodes": -9850,
      "jsHeapTotalBytes": 24178688,
      "scriptDurationMs": 821.946,
      "eventListeners": -23957,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 12828.175999999985,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 17.881000000000007,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12807.729,
      "heapDeltaBytes": -64350840,
      "heapUsedBytes": 155560092,
      "domNodes": -9850,
      "jsHeapTotalBytes": -13832192,
      "scriptDurationMs": 854.267,
      "eventListeners": -23955,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 474.19800000000123,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 26.036,
      "layouts": 5,
      "layoutDurationMs": 1.604,
      "taskDurationMs": 152.15300000000002,
      "heapDeltaBytes": -15122108,
      "heapUsedBytes": 52602556,
      "domNodes": 166,
      "jsHeapTotalBytes": 4292608,
      "scriptDurationMs": 24.755000000000006,
      "eventListeners": 71,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 156.3099999999622,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 22.899999999999995,
      "layouts": 5,
      "layoutDurationMs": 1.583,
      "taskDurationMs": 127.86799999999998,
      "heapDeltaBytes": -17266420,
      "heapUsedBytes": 50461512,
      "domNodes": 150,
      "jsHeapTotalBytes": 5079040,
      "scriptDurationMs": 24.179000000000002,
      "eventListeners": 39,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 479.0140000000065,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 22.3,
      "layouts": 4,
      "layoutDurationMs": 1.0990000000000002,
      "taskDurationMs": 129.57599999999996,
      "heapDeltaBytes": -15002900,
      "heapUsedBytes": 52744164,
      "domNodes": 154,
      "jsHeapTotalBytes": 4554752,
      "scriptDurationMs": 23.233999999999998,
      "eventListeners": 71,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

Restore the pre-#10849 invariant that SubgraphNode.widgets_values is a
dead field. Per-instance promoted widget values are now carried inline
on their proxyWidgets entry, so identity and value cannot be separated
under reorder, null-entry filter, clipboard paste / subgraph dedup /
nested-pack ID remap.

Add PromotedWidgetView.restorePerInstanceValue to seed
_instanceWidgetValues and promotedSourceWriteMeta without triggering
sibling-fallback capture during configure. Align the shared value so
the getTrackedValue self-heal does not discard the restored state.

Legacy workflows with stale widgets_values on SubgraphNode are ignored;
values fall back to inner-widget delegation as pre-#10849.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (2)
src/core/graph/subgraph/promotedWidgetView.ts (1)

232-353: Extract shared write-to-store logic; set value and _writeValueToSharedState are now near-duplicates.

Lines 233–274 and 311–352 implement the same linked-widgets → resolved-deepest → widget-state → resolve-at-host cascade. The only difference in set value is the preceding captureSiblingFallbackValues() and the instance-map/meta writes. Recommend having the setter delegate to _writeValueToSharedState(value) to keep both code paths in lockstep — otherwise future fixes (new store, new resolution path, etc.) will need to be applied in two places and can silently drift, reintroducing exactly the class of regression this PR is fixing.

♻️ Proposed consolidation
   set value(value: IBaseWidget['value']) {
     this.captureSiblingFallbackValues()
-
-    // Keep per-instance map in sync for execution (graphToPrompt)
     this.subgraphNode._instanceWidgetValues.set(
       this.instanceKey,
       cloneWidgetValue(value)
     )
     setPromotedSourceWriteMeta(
       this.subgraphNode.rootGraph,
       this._sharedSourceKey,
       {
         value: cloneWidgetValue(value),
         writerInstanceId: String(this.subgraphNode.id)
       }
     )
-
-    const linkedWidgets = this.getLinkedInputWidgets()
-    if (linkedWidgets.length > 0) {
-      // …duplicated body…
-    }
-
-    const state = this.getWidgetState()
-    if (state) {
-      state.value = value
-      return
-    }
-
-    const resolved = this.resolveAtHost()
-    if (resolved && isWidgetValue(value)) {
-      resolved.widget.value = value
-    }
+    this._writeValueToSharedState(value)
   }
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/core/graph/subgraph/promotedWidgetView.ts` around lines 232 - 353, The
setter duplicates the shared "write-to-store" cascade implemented in
_writeValueToSharedState(value); refactor set value to call
_writeValueToSharedState(value) after it runs captureSiblingFallbackValues() and
the per-instance map + setPromotedSourceWriteMeta updates so the linked-widgets
→ resolveDeepest → getWidgetState → resolveAtHost logic is only implemented
once; update set value to remove the duplicated loop and resolution code and
delegate to _writeValueToSharedState(value), ensuring _writeValueToSharedState
uses useWidgetValueStore(), getLinkedInputWidgets(), resolveDeepest(),
stripGraphPrefix(), getWidgetState(), resolveAtHost(), and isWidgetValue()
exactly as the existing implementation.
src/lib/litegraph/src/subgraph/SubgraphNode.ts (1)

658-692: Serialize-side clone handles primitives and objects correctly; two small notes.

  1. raw ?? null coerces undefined → null on the wire. That's fine for JSON round-trip, but any call site inspecting { value } on an in-memory workflow right after serialize should not distinguish absent-value-from-default (undefined) vs. explicit null. Given Zod's value: z.unknown() accepts both, the restore path treats them identically — acceptable.
  2. JSON.parse(JSON.stringify(raw)) drops Date, Map, Set, Function, etc. If any promoted widget ever has a non-JSON-serializable value, it will mutate on save. Current widgets appear to only hold JSON-safe values, but worth a note for future widget types.

No change required; logging here for awareness.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/lib/litegraph/src/subgraph/SubgraphNode.ts` around lines 658 - 692, The
serialize logic in _serializeEntriesWithState currently coerces undefined to
null via (raw ?? null) and deep-clones objects using
JSON.parse(JSON.stringify(raw)), which loses Dates, Maps, Sets, Functions, etc.;
to fix/mitigate, update _serializeEntriesWithState (see function name and
variables raw, cloned, view.serializeValue) to preserve undefined when
appropriate (e.g., use raw === undefined ? undefined : raw) and replace the
JSON-based clone with a more robust clone such as structuredClone(raw) with a
safe fallback to JSON.stringify for environments without structuredClone, or add
a clear inline comment documenting the known limitation if you intentionally
accept JSON-only values.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/core/graph/subgraph/promotedWidgetView.ts`:
- Around line 232-353: The setter duplicates the shared "write-to-store" cascade
implemented in _writeValueToSharedState(value); refactor set value to call
_writeValueToSharedState(value) after it runs captureSiblingFallbackValues() and
the per-instance map + setPromotedSourceWriteMeta updates so the linked-widgets
→ resolveDeepest → getWidgetState → resolveAtHost logic is only implemented
once; update set value to remove the duplicated loop and resolution code and
delegate to _writeValueToSharedState(value), ensuring _writeValueToSharedState
uses useWidgetValueStore(), getLinkedInputWidgets(), resolveDeepest(),
stripGraphPrefix(), getWidgetState(), resolveAtHost(), and isWidgetValue()
exactly as the existing implementation.

In `@src/lib/litegraph/src/subgraph/SubgraphNode.ts`:
- Around line 658-692: The serialize logic in _serializeEntriesWithState
currently coerces undefined to null via (raw ?? null) and deep-clones objects
using JSON.parse(JSON.stringify(raw)), which loses Dates, Maps, Sets, Functions,
etc.; to fix/mitigate, update _serializeEntriesWithState (see function name and
variables raw, cloned, view.serializeValue) to preserve undefined when
appropriate (e.g., use raw === undefined ? undefined : raw) and replace the
JSON-based clone with a more robust clone such as structuredClone(raw) with a
safe fallback to JSON.stringify for environments without structuredClone, or add
a clear inline comment documenting the known limitation if you intentionally
accept JSON-only values.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 72b53e3f-728a-4901-9ce0-1c4cd1da1b7b

📥 Commits

Reviewing files that changed from the base of the PR and between 6a98267 and fe07063.

📒 Files selected for processing (7)
  • src/core/graph/subgraph/promotedWidgetTypes.ts
  • src/core/graph/subgraph/promotedWidgetView.test.ts
  • src/core/graph/subgraph/promotedWidgetView.ts
  • src/core/graph/subgraph/subgraphNodePromotion.test.ts
  • src/core/schemas/promotionSchema.ts
  • src/lib/litegraph/src/subgraph/SubgraphNode.multiInstance.test.ts
  • src/lib/litegraph/src/subgraph/SubgraphNode.ts
✅ Files skipped from review due to trivial changes (1)
  • src/core/graph/subgraph/promotedWidgetView.test.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/lib/litegraph/src/subgraph/SubgraphNode.multiInstance.test.ts

@codecov

codecov Bot commented Apr 23, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.55172% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/core/graph/subgraph/promotedWidgetView.ts 94.82% 3 Missing ⚠️
@@             Coverage Diff             @@
##             main   #11559       +/-   ##
===========================================
- Coverage   70.44%   52.46%   -17.99%     
===========================================
  Files        1482     1374      -108     
  Lines       85986    70279    -15707     
  Branches    24088    18670     -5418     
===========================================
- Hits        60576    36869    -23707     
- Misses      24468    32863     +8395     
+ Partials      942      547      -395     
Flag Coverage Δ
e2e ?
unit 52.46% <96.55%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...omponents/rightSidePanel/parameters/WidgetItem.vue 77.27% <100.00%> (-10.54%) ⬇️
src/composables/graph/useGraphNodeManager.ts 71.13% <100.00%> (-19.00%) ⬇️
src/core/graph/subgraph/cloneWidgetValue.ts 100.00% <100.00%> (ø)
src/core/graph/subgraph/promotedWidgetTypes.ts 100.00% <ø> (ø)
src/core/schemas/promotionSchema.ts 100.00% <100.00%> (+19.23%) ⬆️
...nsions/vueNodes/composables/useProcessedWidgets.ts 89.18% <100.00%> (-5.82%) ⬇️
src/stores/widgetValueStore.ts 100.00% <100.00%> (+2.12%) ⬆️
src/core/graph/subgraph/promotedWidgetView.ts 94.75% <94.82%> (+0.37%) ⬆️

... and 985 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/lib/litegraph/src/subgraph/SubgraphNode.ts`:
- Around line 1141-1170: When handling legacy '-1' widget entries in
SubgraphNode.ts, the resolved PromotedWidgetSource can lose its
disambiguatingSourceNodeId, causing pendingValues' key to not match
view.instanceKey during restore; update the '-1' branch (where
_resolveLegacyEntry is used) to populate the resolved object with
disambiguatingSourceNodeId (set it from sourceNodeId or the appropriate
variable) before calling makePromotionEntryKey and inserting into pendingValues,
and apply the same fix in the other occurrence (around the
normalizeLegacyProxyWidgetEntry/assignment block referenced at the second
location) so both code paths preserve disambiguatingSourceNodeId for
PromotedWidgetSource used by makePromotionEntryKey and pendingValues.
- Around line 691-693: The serializeValue call is passing a hardcoded -1 which
breaks dynamicPrompts because it expects the promoted widget index; locate the
usage of view.serializeValue(this, -1) in SubgraphNode (and the similar
occurrences around the other block referenced) and replace the -1 with the
actual promoted view index obtained from SubgraphNode._getPromotedViews() (e.g.,
find the promoted views array, determine the index of the current view within
that array and pass that index into serializeValue) so dynamicPrompts receives
the correct widgetIndex for writing back widgets_values.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8bce7522-3a98-4508-a496-2a5ef7d5db3f

📥 Commits

Reviewing files that changed from the base of the PR and between fe07063 and d7193a8.

📒 Files selected for processing (2)
  • src/core/graph/subgraph/promotedWidgetView.ts
  • src/lib/litegraph/src/subgraph/SubgraphNode.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/core/graph/subgraph/promotedWidgetView.ts

…state

The fixture was authored in v1.44.5-7 format where per-instance values
lived on widgets_values. With widgets_values restored to a dead field,
values now live inline on properties.proxyWidgets entries.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
browser_tests/assets/subgraphs/subgraph-multi-instance-promoted-text-values.json (1)

11-11: ⚠️ Potential issue | 🟡 Minor

Increase test asset node sizes to the browser-test minimum.

These node sizes are below [400, 200] in at least one dimension, which can make navigateIntoSubgraph flaky for this asset.

Proposed fixture size update
-      "size": [210, 168],
+      "size": [400, 200],
@@
-      "size": [210, 168],
+      "size": [400, 200],
@@
-      "size": [210, 168],
+      "size": [400, 200],
@@
-            "size": [270, 262],
+            "size": [400, 262],

As per coding guidelines, browser_tests/assets/**/*.json: Use node size [400, 200] minimum in test asset JSON to prevent navigateIntoSubgraph timeout issues.

Also applies to: 31-31, 51-51, 179-179

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In
`@browser_tests/assets/subgraphs/subgraph-multi-instance-promoted-text-values.json`
at line 11, Update the "size" arrays in the test asset
subgraph-multi-instance-promoted-text-values.json so no node has dimensions
smaller than the browser-test minimum [400, 200]; locate each "size" field
(e.g., the entries currently set to [210,168] and the other smaller occurrences)
and change them to at least [400,200] (or larger in width/height as needed) to
prevent navigateIntoSubgraph flakiness.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In
`@browser_tests/assets/subgraphs/subgraph-multi-instance-promoted-text-values.json`:
- Line 11: Update the "size" arrays in the test asset
subgraph-multi-instance-promoted-text-values.json so no node has dimensions
smaller than the browser-test minimum [400, 200]; locate each "size" field
(e.g., the entries currently set to [210,168] and the other smaller occurrences)
and change them to at least [400,200] (or larger in width/height as needed) to
prevent navigateIntoSubgraph flakiness.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4dda05e0-b544-453e-9298-acbac71ca444

📥 Commits

Reviewing files that changed from the base of the PR and between d7193a8 and c9138e3.

📒 Files selected for processing (1)
  • browser_tests/assets/subgraphs/subgraph-multi-instance-promoted-text-values.json

@dante01yoon
dante01yoon marked this pull request as ready for review April 23, 2026 05:53
@dante01yoon
dante01yoon requested a review from a team April 23, 2026 05:53
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 23, 2026

@jaeone94 jaeone94 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the save/load contract reshape end-to-end. The inline {value} on proxyWidgets tuples is the right direction — identity and value are coupled in a single record so ordering/filter drift can't misalign them, and no new top-level JSON key is introduced. Approach is sound.

My concerns cluster around load/clone edge cases (value corruption and silent drop), and a migration gap for workflows saved during the #10849 window. Inline comments below.

Breakdown: 4 issue · 4 suggestion · 1 nit. Approach itself is not blocked; the issues are worth resolving before merge.

Comment on lines +1215 to +1222
/**
* Hydrate per-instance values by resolved identity key. The pending
* map is built alongside entry resolution so legacy `-1` and ancestor
* normalization paths are handled with the same logic as the promotion
* store, and reorder / filter / ID-remap can't desync identity from
* value.
*/
if (pendingValues.size > 0) {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue — write-back immediately above (lines ~1181-1185 in the current file, just before the virtual-canvas auto-promote loop) demotes {value} right before this hydration block runs.

const serialized = this._serializeEntries(entries)
if (JSON.stringify(serialized) !== JSON.stringify(raw)) {
  this.properties.proxyWidgets = serialized
}

After loading a 4-tuple workflow, raw is 4-tuple and _serializeEntries (no State suffix) produces 2/3-tuple — the compare is always unequal → properties.proxyWidgets is demoted to state-less form. Live views still work (this pendingValues hydration runs against the still-buffered state), but any caller snapshotting properties.proxyWidgets between load and the next serialize() (extensions, undo/diff, clipboard clone) sees no {value}.

Fix: switch the write-back to _serializeEntriesWithState, or narrow the write-back condition to entries that actually needed resolution (legacy -1 normalization).

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair catch. Replaced the write-back with a new _serializeEntriesWithPendingValues helper (identity from resolved entries, value from pendingValues), so normalization no longer demotes 4-tuples to 2/3-tuples in properties.proxyWidgets. Live views are unaffected (pendingValues hydration was already the source of truth) but snapshots from clone/undo/extensions now stay faithful to the loaded state. Commit e2ca5e8.

Comment on lines +694 to +698
const cloned =
raw != null && typeof raw === 'object'
? JSON.parse(JSON.stringify(raw))
: (raw ?? null)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue — undefined → null coercion feeds back into load-side map poisoning.

const cloned = raw != null && typeof raw === 'object'
  ? JSON.parse(JSON.stringify(raw))
  : (raw ?? null)

Any promoted widget whose serializeValue() returns undefined is persisted as null. On reload, null is fed to restorePerInstanceValue (promotedWidgetView.ts:221–242), which has no null/undefined guard — it sets _instanceWidgetValues[key] = null, creating a ghost entry. getTrackedValue then treats null as a real value and returns it (numeric widgets display null), while captureSiblingFallbackValues.has(key) sees true and skips sibling propagation.

Fix: on serialize, skip entries whose resolved value is undefined (downgrade to 2/3-tuple here). On load, early-return in restorePerInstanceValue when value === undefined (and, if desired, when value === null).

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed both sides. Save: _serializeEntriesWithState now downgrades to identity-only 2/3-tuple when the resolved value is undefined (no more ?? null coercion). Load: restorePerInstanceValue early-returns on undefined to avoid seeding a ghost null that captureSiblingFallbackValues would treat as already-written. null is still allowed through since some widgets persist it legitimately. Commit e2ca5e8.

Comment thread src/core/schemas/promotionSchema.ts Resolved
}

if (resolved && rawEntry.length >= 4) {
const state = (rawEntry as unknown[])[3]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion — three as casts in PR-new code, all avoidable.

const state = (rawEntry as unknown[])[3]                    // L1166
(state as { value: unknown }).value                         // L1170
pendingValues.get(key) as typeof view.value                 // L1228

Per AGENTS.md, "Type assertions are a last resort". TS narrows tuple unions by length and 'value' in state narrows via the in operator.

Fix: add a typed helper in promotionSchema.ts:

export function getInlineState(
  tuple: ProxyWidgetsProperty[number]
): { value: unknown } | undefined {
  return tuple.length === 4 ? tuple[3] : undefined
}

Then replace all three casts with direct typed access.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two of three removed via a new getProxyWidgetInlineState typed helper in promotionSchema.ts — narrows by tuple length for the state-object accessor. The third (pendingValues.get(key) as typeof view.value) is the genuine JSON-input-to-typed-API boundary and felt like a legitimate "legacy interop" assertion per AGENTS.md, so I left it. Commit e2ca5e8.

Comment thread src/core/schemas/promotionSchema.ts Resolved
_resolveLegacyEntry now returns a full PromotedWidgetSource rather than a
bare [nodeId, widgetName] tuple, carrying disambiguatingSourceNodeId when
the resolved input widget is a nested PromotedWidgetView.

Without this, legacy -1 entries in nested subgraphs resolved to a key
'${source}:${widget}' while the promoted view registered under
'${source}:${widget}:${disambig}', causing the per-instance value
hydration lookup to miss silently. Values then fell back to inner-widget
delegation instead of the saved per-instance state.

Addresses CodeRabbit Major finding on PR #11559.
Addresses jaeone94's review on #11559:

- write-back during configure now uses `_serializeEntriesWithPendingValues`
  so legacy-entry normalization doesn't demote the freshly-loaded 4-tuple
  into an identity-only 2/3-tuple, which would drop per-instance values
  from `properties.proxyWidgets` until the next full `serialize()`.
- `cloneWidgetValue` now uses `structuredClone` with a raw-reference
  fallback, so a malformed `{value}` blob (circular ref, throwing
  `toJSON`, etc.) in saved JSON can't crash the whole subgraph load.
- `_serializeEntriesWithState` skips the `{value}` wrapper when the
  resolved value is `undefined`, preventing ghost `null` entries from
  poisoning the per-instance map and sibling-fallback capture.
- `restorePerInstanceValue` early-returns on `undefined` for the same
  reason.
- `set value` now shares `_seedInstanceState` with `restorePerInstanceValue`
  to prevent drift between the setter and load paths.
- `promotionSchema.ts` exposes `getProxyWidgetInlineState` + typed tuple
  names so inline state is read without `as` casts. Union order is
  load-bearing and now documented.
- Regression test now asserts the LOAD invariant (inner widget value
  survives stale `widgets_values` in the payload), not just the SAVE
  invariant.
Knip flagged the newly exported types as unused. They're consumed only
by getProxyWidgetInlineState in the same file, so keep them internal.
@dante01yoon
dante01yoon requested a review from jaeone94 April 24, 2026 10:32

@jaeone94 jaeone94 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the previous review feedback was addressed thoroughly — _serializeEntriesWithPendingValues handles the write-back demote, structuredClone with fallback prevents configure crashes, _seedInstanceState unifies the setter/restore paths, getProxyWidgetInlineState eliminates the type casts, the LOAD-side behavioral assertion was added, and the Zod union precedence comment is in. All of the issue-tier items and both of the partial/declined items came back with sound reasoning. 👍

However, one valid bug still remains after the follow-ups. The disambiguator preservation commit (968a2fd9a) correctly implemented CodeRabbit's suggested diff, but I traced the control flow and the fix actually covers a code path that isn't reachable during normal configure. The production-reachable path still drops the disambiguator — this is a narrow edge case (requires very-old workflow + nested subgraph + duplicate widget names), but it is a real remaining bug path. CodeRabbit's original suggestion itself was incomplete; Dante faithfully implemented it, so this isn't a review-follow-through issue.

One suggestion on test coverage attached as well. Everything here is follow-up territory, not a merge blocker.

@jaeone94 jaeone94 assigned dante01yoon and unassigned jaeone94 Apr 24, 2026
jaeone94
jaeone94 previously approved these changes Apr 24, 2026
@dante01yoon

Copy link
Copy Markdown
Collaborator Author

@coderabbitai approve

coderabbitai[bot]
coderabbitai Bot previously approved these changes Apr 24, 2026
@coderabbitai

coderabbitai Bot commented Apr 24, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Comments resolved and changes approved.

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A Gentle, Detailed Re-review

"The function of good software is to make the complex appear to be simple." — Grady Booch
"If you have a procedure with ten parameters, you probably missed some." — Alan Perlis, Epigram #11

Hello! Thank you for putting this PR together. The instinct that drove this change — the discomfort with three competing per-instance value channels (_instanceWidgetValues, promotedSourceWriteMetaByGraph, the unscoped widgetValueStore) — is exactly the right kind of architectural unease to follow. The deletions in this diff are genuinely good, and I want to walk through the rest of the change in the slow, patient way the code deserves, because the direction you're heading is right and the path you've taken needs a couple of corrections before it gets there.

What follows is long on purpose. I'd rather over-cite first principles than leave you guessing why a particular smell triggers a reviewer's instinct. Treat the citations as a reading list, not as gatekeeping.

I've also dropped inline comments at the most actionable spots in the diff. The body below is the framework; the inline comments are the local moves.


1. The Map of Where Data Lives Today

Let's start by counting. Every node in this diagram is a place this PR (or the surrounding code) can store the answer to "what is this promoted widget's identity / value?" Every edge is a place where two stores have to be kept in sync, which means every edge is a future bug.

%%{init: {'flowchart': {'htmlLabels': false, 'curve': 'basis'}}}%%
flowchart TB
    %% ════════════════════════════════════════════════════════════
    %% IDENTITY — the question "which widget is promoted?"
    %% ════════════════════════════════════════════════════════════
    subgraph IDENT["PROMOTION IDENTITY — 6 storage sites for one logical fact"]
        direction TB

        SSOT["`**Subgraph (definition-level)**
        _The single source of truth that does not exist_
        Identity should live here once, referenced by N instances`"]:::missing

        PROPS["`**SubgraphNode.properties.proxyWidgets**
        per-instance, persisted
        tuple shapes:
        [nid, name]
        [nid, name, disambig]
        [nid, name, disambig|null, {value}]  ← NEW`"]:::storage

        PSTORE["`**usePromotionStore()**
        key: (rootGraphId, instanceId)
        value: PromotedWidgetSource[]
        runtime mirror`"]:::storage

        VIEWS["`**_promotedViewManager.views[]**
        PromotedWidgetView instances`"]:::storage

        INPUT["`**SubgraphNode.inputs[i]._widget**
        back-reference to view`"]:::storage

        WIDS["`**SubgraphNode.widgets[]**
        getter materializing views`"]:::storage
    end

    SSOT -. "would obviate ↓" .-> PROPS
    PROPS <-->|"hydrate / serialize"| PSTORE
    PSTORE -->|"build views"| VIEWS
    VIEWS -->|"_resolveInputWidget"| INPUT
    VIEWS -->|"materialized via getter"| WIDS

    %% ════════════════════════════════════════════════════════════
    %% VALUE — the question "what is the current value of the promoted widget?"
    %% ════════════════════════════════════════════════════════════
    subgraph VAL["PROMOTED WIDGET VALUE — 8 storage sites for one logical fact"]
        direction TB

        INLINE["`**properties.proxyWidgets[i][3].value**
        PERSISTED — NEW
        value smuggled into identity tuple`"]:::new

        WSCOPE["`**useWidgetValueStore (scoped)**
        key: instanceId@nodeId:widgetName
        runtime, per-instance`"]:::storage

        WGLOBAL["`**useWidgetValueStore (unscoped)**
        key: nodeId:widgetName
        legacy / shared fallback`"]:::storage

        HOST["`**inner LGraphNode.widgets[i].value**
        the actual source widget`"]:::storage

        SAFE["`**SafeWidgetData.value**
        non-reactive snapshot — NEW`"]:::new

        LEGACY["`**legacy widgets_values[]**
        still parsed on import,
        length-aligned migration only`"]:::legacy

        PEND1["`**_pendingLegacyWidgetsValues**
        transient instance field,
        covert parameter`"]:::transient

        PEND2["`**pendingValues: Map**
        local in
        _internalConfigureAfterSlots`"]:::transient

        VIEWGET["`**PromotedWidgetView.value getter**
        precedence: scoped → host → legacy
        8th read site`"]:::storage
    end

    INLINE -->|"hydrate → "| PEND2
    LEGACY -->|"if length === raw.length"| PEND2
    LEGACY -->|"else: silently dropped"| LOSS["`💀 _data loss_`"]:::loss
    PEND1 -.->|"covert param"| PEND2
    PEND2 -->|"writeScopedValue"| WSCOPE
    WSCOPE -->|"serialize ← "| INLINE
    HOST --- VIEWGET
    WGLOBAL --- VIEWGET
    WSCOPE --- VIEWGET
    HOST -->|"snapshotted at map time"| SAFE

    %% ════════════════════════════════════════════════════════════
    %% IDENTITY KEYS — 4 incompatible encodings of the same key
    %% ════════════════════════════════════════════════════════════
    subgraph KEYS["IDENTITY-KEYING SCHEMES — 4 mutually translated encodings"]
        direction TB
        K1["`**PromotedWidgetView.instanceKey**
        ${nid}:${name}[:${disamb}]`"]:::keyfmt
        K2["`**WidgetKey** _stringly-typed_
        ${nid}:${name} |
        ${iid}@${nid}:${name}`"]:::keyfmt
        K3["`**makePromotionEntryKey()**
        used by promotionStore`"]:::keyfmt
        K4["`**SafeWidgetData identity fields**
        nodeId, storeNodeId,
        storeInstanceId, name, storeName`"]:::keyfmt
    end

    VIEWS -.-> K1
    WSCOPE -.-> K2
    PSTORE -.-> K3
    SAFE -.-> K4

    PROPS -.->|"identity tuple now also carries value"| INLINE

    classDef missing  fill:#fff7e6,stroke:#d97706,stroke-width:2px,stroke-dasharray:4 4,color:#7c2d12
    classDef storage  fill:#eef2ff,stroke:#4f46e5,stroke-width:1px,color:#1e1b4b
    classDef new      fill:#fee2e2,stroke:#b91c1c,stroke-width:2px,color:#7f1d1d
    classDef transient fill:#f5f3ff,stroke:#7c3aed,stroke-width:1px,stroke-dasharray:2 2,color:#3b0764
    classDef legacy   fill:#fef3c7,stroke:#a16207,stroke-width:1px,color:#713f12
    classDef keyfmt   fill:#ecfeff,stroke:#0e7490,stroke-width:1px,color:#083344
    classDef loss     fill:#000,stroke:#dc2626,color:#fff
Loading

Read this diagram with the question: if I edit a promoted widget once, how many writes have to happen, and how many reads have to agree? The answer this PR ships is "many." The answer the codebase deserves is "one."


2. Diagnostic Lenses (Why Each Issue Is An Issue)

Naming the lenses up front so my objections don't read as taste preferences. Each one is well-trodden ground in the literature.

2a. Single Source of Truth (SSOT)

"Every piece of knowledge must have a single, unambiguous, authoritative representation within a system." — Hunt & Thomas, The Pragmatic Programmer, "DRY", §1.7

DRY is famously misquoted as "don't repeat code." The original is "don't repeat knowledge." A logical fact (this promotion's identity, this promotion's value) must live in one place; everything else either references it or derives from it. When the same fact lives in two stores you do not have one fact — you have two facts that happen to agree until they don't.

2b. Connascence

Meilir Page-Jones (What Every Programmer Should Know About Object-Oriented Design, 1996) and Jim Weirich popularized the connascence taxonomy. The forms relevant here, in order from least-bad to worst:

  • Connascence of Name (CoN) — two things must agree on a name. Cheap.
  • Connascence of Type (CoT) — two things must agree on a type. Cheap, compiler helps.
  • Connascence of Position (CoP) — two things must agree on the order in a sequence. Expensive — invisible to the compiler, fragile under reordering. Tuples are the textbook example.
  • Connascence of Algorithm (CoA) — two things must run the same logic to agree.
  • Connascence of Identity (CoI) — two things must reference the same object. The worst form.

The 4-tuple [nodeId, widgetName, disambig|null, {value}] is CoP-3 spread across _serializeEntries, parseProxyWidgets, getProxyWidgetInlineState, the configure hydration path, and external custom-node consumers. CoP across module boundaries is the highest-cost form of coupling you can introduce in a serialized format.

2c. Information Hiding

"The connections between modules are the assumptions which the modules make about each other." — David Parnas, On the Criteria To Be Used in Decomposing Systems into Modules, CACM 1972

A field on this that is only meaningful during a single method's execution (_pendingLegacyWidgetsValues) leaks an internal assumption: that nothing else observes the field while it's set. Parnas would say this module's secret has been published.

2d. Deep Modules

"The best modules are deep: they have powerful functionality yet simple interfaces." — John Ousterhout, A Philosophy of Software Design, §4.5

When PromotedWidgetView grows seven near-synonymous getters, the module has become shallow — its interface (verbs callers must learn) has expanded faster than its underlying model. This is a refactoring signal, not a stylistic preference.

2e. Make Illegal States Unrepresentable

"Make illegal states unrepresentable." — Yaron Minsky, Jane Street, Effective ML, 2010

A value is either inside a legal envelope or it isn't. cloneWidgetValue's try { ... } catch { return value } represents the illegal state ("this value cannot be cloned") with the same shape as the legal one. The type system can no longer tell them apart, and the runtime now has a silent shared-reference path.

2f. Errors Are Values

"Don't just check errors, handle them gracefully." — Hunt & Thomas, The Pragmatic Programmer

Swallowing failure in a catch and returning the input untouched is the Pokémon exception handler anti-pattern: "gotta catch 'em all." It reframes a bug into normal control flow and erases the diagnostic.

2g. Hyrum's Law

"With a sufficient number of users of an API, it does not matter what you promise in the contract: all observable behaviors of your system will be depended on by somebody." — Hyrum Wright

AGENTS.md itself flags 40+ custom-node ecosystem consumers depending on the existing surface. The behavior change "writing a promoted widget no longer mutates the source widget" is observable. Some extension out there is observing it.

2h. Domain-Driven Design's Ubiquitous Language

"A domain model is the backbone of a language used by all team members." — Eric Evans, Domain-Driven Design, ch. 2

When the same concept is encoded as instanceKey, WidgetKey, makePromotionEntryKey, and {nodeId, storeNodeId, storeInstanceId}, the codebase has stopped having a ubiquitous language and started having four dialects.

2i. The ECS Architectural Constraint

The project has explicit ADR guidance (ADR 0003 + 0008 referenced in AGENTS.md):

"Centralized registries and ECS-style access: Entity data lives in the World, queried via world.getComponent(entityId, ComponentType)."

Stringly-typed keys in a flat Map are the opposite of ECS-style access. They re-encode an entity ID as a substring and depend on prefix scanning for collection operations. ECS exists precisely to avoid this.


3. The Issues, Walked Through Patiently

Each subsection names the smell, points at where it lives in the diff, names the principle, and proposes the alternative. Inline comments accompany the most actionable items.

3.1. Identity And Value Are Conflated In One Tuple

Where: src/core/schemas/promotionSchema.ts, src/lib/litegraph/src/subgraph/SubgraphNode.ts

properties.proxyWidgets is the persisted identity of which inner widgets a SubgraphNode promotes. Inlining {value} makes one record carry two unrelated concerns: who and what. This is Data Clumps with two clumps glued together (Fowler, Refactoring, ch. 3).

The principle violated — Single Responsibility (Robert C. Martin, Clean Architecture, ch. 7):

"A module should have one, and only one, reason to change."

Promotion identity changes when the user re-promotes a widget. Promotion value changes on every keystroke in a textbox. These are different cadences, different actors, different invariants. Co-storing them means every value edit produces a write to the identity record.

The defense in the PR description ("identity and value carry together so reorders, ID-remap, and dedup don't desync") is the problem statement, not the solution. The reason they desync is that they are stored separately. The fix is not to staple them together; it is to consolidate the value into a single per-instance store and let identity be reordered freely.

Architectural answer:

flowchart LR
    SG["`**Subgraph** (definition)
    proxyWidgets: PromotedWidgetSource[]
    _identity, shared by all instances_`"]
    INST["`**SubgraphNode** (instance)
    id: NodeId`"]
    STORE["`**WidgetValueStore**
    Map&lt;(SubgraphNode.id, PromotionId), Value&gt;
    _value, per instance_`"]

    SG -.->|"defines what is promoted"| STORE
    INST -.->|"scopes value lookups"| STORE
Loading

Identity belongs on the subgraph definition (one copy, N references). Value belongs in a single per-instance store keyed by (SubgraphNode.id, PromotionId). The persisted form serializes the store separately from the definition.

3.2. The 4-Tuple Schema Is Connascence-of-Position In Public Persisted Form

const proxyWidgetTupleSchema = z.union([
  z.tuple([z.string(), z.string(), z.union([z.string(), z.null()]), proxyWidgetStateSchema]),
  z.tuple([z.string(), z.string(), z.string()]),
  z.tuple([z.string(), z.string()])
])

Three smells in three lines:

  1. CoP across the persistence boundary. Position 2 must be null when absent so position 3 can be present. A future field needs a 5-tuple. Custom-node authors must memorize positions, not field names.
  2. The "ordering is defensive" comment is incorrect. z.tuple enforces arity; the union order does not affect matching. The comment is cargo-culted reassurance.
  3. proxyWidgetStateSchema = z.object({ value: z.unknown() }). With z.unknown(), an explicit undefined passes validation. So callers must do state && state.value !== undefined. The schema validates the illegal state.

Parse, Don't Validate (Alexis King, 2019):

type PromotedWidgetEntry =
  | { kind: 'identity', sourceNodeId: string, sourceWidgetName: string, disambiguator?: string }
  | { kind: 'instance-value', sourceNodeId: string, sourceWidgetName: string, disambiguator?: string, value: WidgetValue }

The kind discriminator is CoN (a name) rather than CoP (a position). Adding a future variant is additive.

3.3. cloneWidgetValue's Catch Hides A Correctness Bug

export function cloneWidgetValue<TValue>(value: TValue): TValue {
  if (value == null || typeof value !== 'object') return value
  try {
    return structuredClone(value)
  } catch {
    return value
  }
}

Two layers of concern:

Layer 1 — the test that locks this in fabricates an illegal input to satisfy a coverage goal. A widget value that contains a function is not a real product scenario; it's a contrivance constructed to make the catch branch reachable. Per the project's own AGENTS.md:

"Do not focus on making tests pass at the expense of correctness. Never hard-code expected values, add special-case logic only to satisfy a test, or use workarounds that mask the real problem."

Layer 2 — the catch undoes the very invariant the rest of this PR is fixing. When structuredClone fails and we return value, we return the same object reference. The next state.value = clonedValue write makes two instances point at the same object. Subsequent in-place mutation will leak across instances — exactly the bug the PR claims to fix.

The right code is loud:

export function cloneWidgetValue<TValue>(value: TValue): TValue {
  if (value == null || typeof value !== 'object') return value
  return structuredClone(value)   // let it throw, find the upstream offender
}

"An aborted serialize is recoverable; a silently corrupted multi-instance state is not." — paraphrasing the Erlang motto, "Let it crash."

3.4. Length-Aligned Legacy Migration Silently Discards User Data

const canHydrateLegacyWidgetsValues =
  this._pendingLegacyWidgetsValues?.length === raw.length

If raw and _pendingLegacyWidgetsValues are different lengths for any reason — a workflow saved by a prior version, a manual edit, partial corruption — canHydrateLegacyWidgetsValues becomes false and every legacy value is discarded with no warning, no error, no log.

Postel's Law's lesser-known corollary:

Be liberal in accepting, but loud about ambiguity.

Silent acceptance of malformed data and silent dropping of malformed data are both violations.

The fix:

  1. Migrate per-index where indices align (the 80% case).
  2. console.warn on length mismatch with enough context to diagnose.
  3. Even better: emit a structured migration result that callers can surface to the user.

3.5. delete serialized.widgets_values Is The Subclass Fighting The Base Class

override serialize(): ISerialisedNode {
  // ...write proxyWidgets with inline values...
  const serialized = super.serialize()
  delete serialized.widgets_values
  return serialized
}

The override calls super.serialize() to get a record, then deletes a field from it. The relationship between subclass and base class is now adversarial.

Liskov Substitution + Open/Closed (SOLID):

"Software entities should be open for extension, but closed for modification."

The base class should grow a hook:

protected getSerializableWidgetsValues(): unknown[] | undefined {
  return /* default: derive from this.widgets */
}

// SubgraphNode overrides:
protected override getSerializableWidgetsValues(): undefined {
  return undefined
}

If anyone ever adds a non-promoted widget to a SubgraphNode (a label widget, the CANVAS_IMAGE_PREVIEW_WIDGET already imported in this file), their value will be silently deleted by this single line. The delete is a tripwire for future contributors.

3.6. _pendingLegacyWidgetsValues Is A Covert Function Parameter

override configure(info: ExportedSubgraphInstance): void {
  this._pendingLegacyWidgetsValues = Array.isArray(info.widgets_values) ? info.widgets_values : undefined
  try { super.configure(info) }
  finally { this._pendingLegacyWidgetsValues = undefined }
}

override _internalConfigureAfterSlots() {
  // ...reads this._pendingLegacyWidgetsValues...
}

_pendingLegacyWidgetsValues exists only to pass data from configure to _internalConfigureAfterSlots. It is an instance field for the duration of one method call. This is Action At A Distance.

Information Hiding: the secret of "we're carrying widgets_values across a callback boundary" is broadcast to every method on the class — and every subclass override, every callback that fires during super.configure, every introspecting extension.

The fix — pass it explicitly:

override configure(info: ExportedSubgraphInstance): void {
  this._configureWith(info, info.widgets_values)
}

private _configureWith(info: ExportedSubgraphInstance, legacyValues: unknown[] | undefined) {
  super.configure(info)
  this._hydrateAfterSlots(legacyValues)
}

The parameter has a type, a scope, and a single visible call site. The try/finally cleanup disappears.

3.7. WidgetKey Is Stringly-Typed Identity (Primitive Obsession)

type WidgetKey = `${NodeId}:${string}` | `${NodeId}@${NodeId}:${string}`

function clearInstanceWidgets(graphId: UUID, instanceId: NodeId): void {
  const widgetStates = getWidgetStateMap(graphId)
  const prefix = `${instanceId}@`
  for (const key of widgetStates.keys()) {
    if (key.startsWith(prefix)) widgetStates.delete(key)
  }
}

Smells, plural:

  1. Primitive Obsession (Fowler, code smell #11). The compound concept "(instanceId?, nodeId, widgetName)" is encoded as a string whose internal structure is private convention.
  2. The encoding leaks via clearInstanceWidgets. The very existence of this method tells you the data shape was wrong.
  3. The format is fragile. The day a node ID legitimately contains @, this collides silently.
  4. It violates the project's own ADR. ECS-style access is structured, not stringified.
type WidgetIdentity = { readonly nodeId: NodeId, readonly widgetName: string }
type InstanceScope = NodeId | typeof UNSCOPED

const widgetStates: Map<UUID, Map<InstanceScope, Map<WidgetIdentity, WidgetState>>>

Now clearInstanceWidgets is widgetStates.get(graphId)?.delete(instanceId). No string parsing.

3.8. SafeWidgetData.value Is A Stale Snapshot Of A Reactive Value

value: normalizeWidgetValue(widget.value),   // captured non-reactively at mapping time

// consumed:
const value = (widgetState ? widgetState.value : widget.value) as WidgetValue

The previous comment on SafeWidgetData told the truth:

"Value and metadata (label, hidden, disabled, etc.) are accessed via widgetValueStore."

That was the right design. The new comment says:

"value provides the LiteGraph fallback when no scoped store entry exists yet."

"When no scoped store entry exists yet." That is a description of an eager-initialization bug, not a missing API. The right fix is "promoted views eagerly register a scoped store entry on creation," not "every consumer learns to fall back to a snapshot."

3.9. The Promoted-View Class Has Become Shallow

PromotedWidgetView now exposes getStoreBackedValue, getScopedStoreValue (public, on the interface), getScopedWidgetState, getLegacyWidgetState, getWidgetState, getWidgetStateForRefs, getStoreRefs, writeScopedValue. Eight methods, near-synonyms.

Ousterhout's deep modules:

"Modules should be deep: a simple interface that hides a great deal of complexity."

Collapse to one method that returns a precise value:

type PromotedWidgetSource =
  | { source: 'scoped',  state: WidgetState }
  | { source: 'host',    widget: IBaseWidget, node: LGraphNode }
  | { source: 'legacy',  state: WidgetState }
  | { source: 'missing' }

class PromotedWidgetView {
  resolve(): PromotedWidgetSource { /* one place, one precedence */ }
  get value() { return reduce(this.resolve()) }
  set value(v) { write(this.resolve(), v) }
}

The precedence (scoped → host → legacy) is named and visible, callers branch once on a discriminated union, adding a new resolution mode is a typed addition.

3.10. properties.proxyWidgets Gets Rewritten On Every Configure

const serialized = this._serializeEntries(entries, (key) => pendingValues.get(key))
if (JSON.stringify(serialized) !== JSON.stringify(raw)) {
  this.properties.proxyWidgets = serialized
}

Three concerns:

  1. JSON.stringify equality on a hot path. Twice per configure. JSON.stringify ordering is implementation-defined for object keys.
  2. The 4-tuple branch reconstructs {value} from pendingValues, so the serialized shape rarely matches the raw input byte-for-byte. The if check is a mirage; the write happens on essentially every load.
  3. External watchers fire on every load.

Idempotence:

"A noop should be a noop."

Loading a workflow and immediately saving it should produce a byte-identical artifact.

3.11. The Behavior Change Has No Migration Story

Tests confirm a deliberate behavioral inversion:

- expect(innerNodes[0].widgets![0].value).toBe('test2')  // old: source updated
+ expect(innerNodes[0].widgets![0].value).toBe('test')   // new: source unchanged

Hyrum's Law applies. AGENTS.md flags 40+ custom-node repos as observers of node.serialize and the propagation contract. The PR description should include a breaking-changes note, an extension-API audit, and (ideally) a defineDeprecatedProperty-style warning for the previous contract. The repo has an adding-deprecation-warnings skill specifically for this scenario.

3.12. The New Tests Are Change Detectors

Examples:

  • "uses storeInstanceId to resolve and update scoped widget state" — asserts that the new parameter exists and is wired through.
  • "clearInstanceWidgets removes only one instance scope" — asserts that prefix-string scanning works as designed.

AGENTS.md:

"Do not write change detector tests."

These pin the shape of the implementation, not the user-visible behavior. Reframe to:

test('multi-instance promoted widgets are isolated', () => {
  const [a, b] = makeTwoInstancesOfSameSubgraph()
  a.widgets[0].value = 'alpha'
  b.widgets[0].value = 'beta'
  expect(a.widgets[0].value).toBe('alpha')
  expect(b.widgets[0].value).toBe('beta')
})

That test passes today and will also pass under any of the refactors I'm suggesting.

3.13. getProxyWidgetInlineState Inflates Module Surface For A One-Liner

export function getProxyWidgetInlineState(entry: ProxyWidgetEntry): { value?: unknown } | undefined {
  return entry.length === 4 ? entry[3] : undefined
}

If the schema were a discriminated union (per §3.2), this helper would be unnecessary. The discriminator field would tell callers which variant they have, type-narrowed.

"Each new piece of vocabulary is a tax on every reader." — Ousterhout, paraphrased


4. The Path To Enlightenment (A Concrete Refactor Ladder)

Each rung is independently mergeable, and each one strictly improves on the previous.

Rung 0 — Land The Pure Deletions (Yes, Today)

These are subtractions and they are good:

  • Delete _instanceWidgetValues Map on SubgraphNode. ✓
  • Delete promotedSourceWriteMetaByGraph WeakMap. ✓
  • Delete captureSiblingFallbackValues. ✓
  • Replace inline JSON.parse(JSON.stringify(...)) with structuredClone. ✓ (then see Rung 6)

These can ship as a smaller PR. They reduce duplication unambiguously.

Rung 1 — One Per-Instance Value Store, Structured Keys

  • Replace WidgetKey with Map<InstanceScope, Map<{nodeId, widgetName}, WidgetState>>.
  • clearInstanceWidgets(scope) becomes outerMap.delete(scope).
  • getWidget(scope, identity) is a structured lookup with no string parsing.

Rung 2 — Eagerly Register Promoted Views

  • On PromotedWidgetView construction, insert a scoped store entry.
  • On onRemoved, clear it.
  • Delete SafeWidgetData.value. Consumers read the store unconditionally.

Rung 3 — Move Identity Off properties.proxyWidgets

  • Promotion identity becomes a property of the Subgraph definition.
  • SubgraphNode.properties.proxyWidgets is removed (or kept only as a one-time read-time migrator).

Rung 4 — Per-Instance Value Persistence In Its Own Slot

  • Workflow JSON gains subgraphInstanceState: { [subgraphNodeId]: { [promotionId]: value } }.
  • The 4-tuple inline form is replaced by direct serialization of the value store.

Rung 5 — Schema As Discriminated Union

  • Replace the 2/3/4-tuple union with named-variant objects.
  • Delete getProxyWidgetInlineState.
  • Delete the "ordering is defensive" comment.

Rung 6 — Replace cloneWidgetValue With An Invariant

  • Either widget values are JSON-serializable (assert at write time), or they aren't (typed escape hatch).
  • cloneWidgetValue becomes a thin alias for structuredClone or goes away.

Rung 7 — Fix Tests To Pin Behavior, Not Shape

  • Delete change-detector tests for storeInstanceId, clearInstanceWidgets prefix matching, etc.
  • Add behavioral tests of the form "two instances of the same subgraph isolate user edits."

5. A Word Of Encouragement

I want to emphasize, before signing off: the architectural instinct that produced this PR is correct. You looked at a system with three competing per-instance state channels and said "this should be one." That is the right diagnosis. The disagreement is only about the medicine.

The reason this re-review is so long is precisely because the issues are subtle. Inlining {value} into the identity tuple looks like consolidation. Adding instanceId to WidgetKey looks like scoping. cloneWidgetValue's try/catch looks like robustness. Each of these is a local improvement that, when composed, recreates the disease at a different layer.

The literature has names for every smell I cited above because every smell is common, well-known, and survivable. Robert Martin, John Ousterhout, Martin Fowler, Eric Evans, David Parnas, Yaron Minsky, Joe Armstrong, Hunt & Thomas — these authors have spent decades teaching exactly the moves this PR is one or two refactors away from.

If we ship Rung 0 now, and then walk Rungs 1–7 as separate PRs, the result will be:

  • One identity store (on the subgraph definition).
  • One per-instance value store (structured keys, no string concatenation).
  • One read precedence rule (named, typed, single method).
  • One schema (discriminated union, no positional tuples).
  • One failure mode for uncloneable values (loud).
  • One test class (behavioral, not shape-pinning).
  • Zero covert function parameters on this.
  • Zero silent data-loss branches.

That is an end-state worth aiming for, and you are closer to it than the diff makes it look.

"The competent programmer is fully aware of the strictly limited size of his own skull; therefore he approaches the programming task in full humility, and among other things he avoids clever tricks like the plague." — Edsger W. Dijkstra, The Humble Programmer, Turing Award Lecture, 1972

Onward — and gently. 🌱

try {
return structuredClone(value)
} catch {
return value

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌱 The catch undoes the very invariant the rest of this PR is fixing.

When structuredClone fails and we return value, we return the same reference. The next state.value = clonedValue then makes two instances point at the same object, and subsequent in-place mutation will leak across instances — which is exactly the multi-instance bug this PR claims to fix.

The accompanying test that forces a function-valued widget value to "prove the catch branch is reachable" is the giveaway. Per AGENTS.md:

Do not focus on making tests pass at the expense of correctness. Never add special-case logic only to satisfy a test, or use workarounds that mask the real problem.

This is the Pokémon exception handler anti-pattern (Hunt & Thomas, The Pragmatic Programmer): swallow everything, surface nothing. An aborted serialize is recoverable; a silently corrupted multi-instance state is not.

Suggested move: let it throw. If a DataCloneError happens in production, that is a real upstream bug worth surfacing.

Suggested change
return value
return structuredClone(value)

— “Make illegal states unrepresentable.” — Yaron Minsky, Effective ML, 2010

* Ordering is defensive: longest tuple first, though `z.tuple` also enforces
* exact arity so a 4-tuple cannot match the 3-tuple form by length alone.
*/
const proxyWidgetTupleSchema = z.union([

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌱 Connascence of Position across the persistence boundary.

This 4-tuple form encodes a compound concept (source identity + optional disambiguator + optional inline value state) by position. Three downstream concerns:

  1. Position 2 must be null when absent so position 3 can be present. Adding any future field requires a 5-tuple, then a 6-tuple. Custom-node authors must memorize positions, not field names.
  2. The Ordering is defensive: longest tuple first comment is incorrect. z.tuple enforces arity exactly; the union order does not affect matching. The comment is cargo-culted reassurance and tells future readers to be afraid of something that isn't there.
  3. proxyWidgetStateSchema = z.object({ value: z.unknown() }) — z.unknown() accepts undefined, which forces every caller to do state && state.value !== undefined. The schema is validating the illegal state.

This is CoP-3 (Page-Jones / Weirich connascence taxonomy) spread across _serializeEntries, parseProxyWidgets, getProxyWidgetInlineState, the configure hydration path, and any downstream extension that touches proxyWidgets. CoP across module boundaries is the most expensive form of coupling you can ship in a serialized format.

Parse, don't validate (Alexis King, 2019) — replace the union with a discriminated union of objects:

type PromotedWidgetEntry =
  | { kind: 'identity', sourceNodeId: string, sourceWidgetName: string, disambiguator?: string }
  | { kind: 'instance-value', sourceNodeId: string, sourceWidgetName: string, disambiguator?: string, value: WidgetValue }

The kind discriminator is CoN (a name) rather than CoP (a position). Adding a future variant becomes additive, and getProxyWidgetInlineState disappears.

* the legacy slot.
*/
type WidgetKey = `${NodeId}:${string}`
type WidgetKey = `${NodeId}:${string}` | `${NodeId}@${NodeId}:${string}`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌱 Primitive Obsession — stringly-typed identity (Fowler, Refactoring, code smell #11).

The compound concept (instanceId?, nodeId, widgetName) is encoded as a string whose internal structure is private convention (@ separates instance from node, : separates node from widget). Three concerns flow from this:

  1. clearInstanceWidgets becomes a prefix-string scan (line 99) — its very existence is a tell that the data shape is wrong.

  2. The format is fragile. The day a node ID legitimately contains @ (UUID-prefixed scoped IDs already use : per stripGraphPrefix), this collides silently.

  3. It contradicts the project's own ADR. AGENTS.md cites ADR 0003 + 0008:

    Centralized registries and ECS-style access: Entity data lives in the World, queried via world.getComponent(entityId, ComponentType).

    ECS-style access is structured composite keys, not stringified ones.

Suggested shape:

type WidgetIdentity = { readonly nodeId: NodeId; readonly widgetName: string }
type InstanceScope = NodeId | typeof UNSCOPED

const widgetStates: Map<UUID, Map<InstanceScope, Map<WidgetIdentity, WidgetState>>>

Now clearInstanceWidgets is outerMap.get(graphId)?.delete(scope) — no string parsing, no prefix scan, no fragility.

const widgetStates = getWidgetStateMap(graphId)
const prefix = `${instanceId}@`
for (const key of widgetStates.keys()) {
if (key.startsWith(prefix)) widgetStates.delete(key)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌱 The existence of this method is the smell, not its implementation. Prefix-string scanning a Map to delete-by-instance only makes sense when instance scope has been encoded into the key.

With the structured-key suggestion in the comment above, this method collapses to:

function clearInstanceWidgets(graphId: UUID, instanceId: NodeId): void {
  getWidgetStateMap(graphId).get(instanceId)?.clear()
  // or simply: outerMap.delete(instanceId)
}

No iteration, no string matching, no risk that a node ID containing @ collides with the scope prefix.

“The connections between modules are the assumptions which the modules make about each other.” — David Parnas, On the Criteria To Be Used in Decomposing Systems into Modules, CACM 1972.

hasMissingBoundSourceWidget: boolean
views: PromotedWidgetView[]
}
private _pendingLegacyWidgetsValues?: unknown[]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌱 This is a covert function parameter masquerading as instance state.

_pendingLegacyWidgetsValues exists only to pass data from configure to _internalConfigureAfterSlots. It is an instance field for the duration of one method call. Two costs follow:

  1. Information leakage (Parnas, 1972): the secret of "we're carrying widgets_values across a callback boundary" is broadcast to every method on the class — every subclass override, every callback that fires during super.configure, every introspecting extension. Per AGENTS.md, this surface has 40+ external observers.
  2. The try/finally cleanup at line 1113 only exists because the field outlives the call. Pass-by-parameter has no cleanup phase.

Suggested refactor:

override configure(info: ExportedSubgraphInstance): void {
  // ...other setup that doesn't need legacyValues...
  this._configureWith(info, info.widgets_values)
}

private _configureWith(info: ExportedSubgraphInstance, legacyValues: unknown[] | undefined) {
  super.configure(info)
  // _internalConfigureAfterSlots receives legacyValues directly via closure or another param
}

The parameter gains a type, a scope, and a single visible call site. The try/finally cleanup disappears. The blast radius shrinks from "the entire class hierarchy and all its callbacks" to "two methods and the lexical scope between them."

“If you have to look at the body of a function to understand its parameters, the function has lied to you.” — folk wisdom, often attributed to Steve McConnell, Code Complete.

const pendingValues = new Map<string, unknown>()

const canHydrateLegacyWidgetsValues =
this._pendingLegacyWidgetsValues?.length === raw.length

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌱 Silent data-loss branch.

The length === raw.length gate is all-or-nothing: if a single legacy widgets_values length differs from raw.length for any reason — a workflow saved by a prior version that emitted N+1 values, a partial file edit, slight schema drift — every legacy value gets discarded. No warning, no error, no log.

This is a Postel's-Law-corollary violation. Postel's liberal in accepting is sometimes paraphrased as "accept anything," but the lesser-known corollary is be loud about ambiguity. Silent acceptance and silent dropping are both forms of the same anti-pattern.

Three improvements, smallest first:

  1. Migrate per-index where indices align (the 80% case) — even a length mismatch usually has a recoverable prefix.
  2. console.warn (or better, console.error) on length mismatch with enough context to diagnose: workflow name, node ID, expected vs. actual length.
  3. Surface a structured migration result the caller can present to the user ("this workflow had N legacy values; we recovered M").

“Errors should be loud.” — Joe Armstrong, Programming Erlang.

This is exactly the kind of place where data loss breeds support tickets that are impossible to triage because there is no log of the loss.

const serialized = this._serializeEntries(entries, (key) =>
pendingValues.get(key)
)
if (JSON.stringify(serialized) !== JSON.stringify(raw)) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌱 Idempotence quietly broken.

Three concerns layered here:

  1. JSON.stringify equality on a hot path — twice per configure. JSON.stringify ordering is implementation-defined for object keys (V8 vs. JSC differ in edge cases), so the comparison is not even a stable canonical equality.
  2. The if is a mirage. The 4-tuple branch reconstructs {value} from pendingValues rather than preserving the original object reference, so the serialized shape rarely matches the raw input byte-for-byte. properties.proxyWidgets is mutated on essentially every configure pass.
  3. External watchers fire on every load. Any extension or store observing properties.proxyWidgets will see a change-event on every workflow load even when nothing changed.

A noop should be a noop. — twelve-factor app, Stable Configuration

Loading a workflow and immediately saving it should produce a byte-identical artifact. Today it doesn't.

If the schema becomes a discriminated union (see promotionSchema.ts), the rewrite isn't needed at all — the in-memory representation can carry the canonical shape from the moment of parse, and there is nothing to "normalize back."

* live inline on `proxyWidgets` entries. Delete any value the base-class
* serialize path may have written for defence in depth.
*/
delete serialized.widgets_values

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌱 The subclass is fighting the base class.

This override calls super.serialize() to get a record, then deletes a field from it. Two costs:

  1. Liskov Substitution / Open–Closed (SOLID) — SubgraphNode is modifying the base class's output rather than extending it. LGraphNode has no hook for "I have no widgets_values to serialize," so the subclass reaches into the base class's result. Future contributors changing LGraphNode.serialize won't know they have to coordinate with this delete.
  2. Tripwire for future contributors — the moment anyone adds a non-promoted widget to a SubgraphNode (a label widget, the CANVAS_IMAGE_PREVIEW_WIDGET already imported in this file), their value will be silently deleted by this single line.

Cleaner pattern — let the base class ask the subclass:

// In LGraphNode:
protected getSerializableWidgetsValues(): unknown[] | undefined {
  return /* current logic */
}

// In SubgraphNode:
protected override getSerializableWidgetsValues(): undefined {
  return undefined  // intent stated, typed, discoverable
}

“Software entities should be open for extension, but closed for modification.” — Bertrand Meyer / Robert C. Martin, SOLID.

This is Tell, Don't Ask at the inheritance boundary.

name: string
storeName?: string
type: string
value?: WidgetValue

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌱 A non-reactive snapshot of a reactive value.

The previous SafeWidgetData comment told the truth:

Value and metadata (label, hidden, disabled, etc.) are accessed via widgetValueStore.

That was the right design — single source of truth, reactive, store-backed. The new comment says:

value provides the LiteGraph fallback when no scoped store entry exists yet.

Re-read "when no scoped store entry exists yet." That's a description of an eager-initialization bug, not a missing API. The right fix is "promoted views eagerly register a scoped store entry on creation," not "every consumer learns to fall back to a snapshot."

Once snapshots exist, two consumers have to decide which one to read, and the snapshot inevitably drifts from widget.value. Vue's whole reason for existing is to avoid hand-rolled snapshots.

Suggested move (Rung 2 in the review body): in PromotedWidgetView's constructor, register a scoped entry in widgetValueStore seeded from the source widget's current value. Now the store always has an entry, consumers read the store unconditionally, and SafeWidgetData.value can be deleted.

cloneWidgetValue(sharedValue)
)
return sharedValue
private getStoreBackedValue(): IBaseWidget['value'] {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌱 The class has become shallow (Ousterhout, A Philosophy of Software Design, §4).

PromotedWidgetView now exposes:

  • getStoreBackedValue
  • getScopedStoreValue (public, on the interface)
  • getScopedWidgetState
  • getLegacyWidgetState
  • getWidgetState
  • getWidgetStateForRefs
  • getStoreRefs
  • writeScopedValue

Eight near-synonymous methods. The fan-out signals that the abstraction "a promoted widget view that may or may not have a scoped store entry" is fighting the data shape.

Suggested refactor — collapse to one method that returns a precise value:

type PromotedWidgetSource =
  | { source: 'scoped',  state: WidgetState }
  | { source: 'host',    widget: IBaseWidget, node: LGraphNode }
  | { source: 'legacy',  state: WidgetState }
  | { source: 'missing' }

class PromotedWidgetView {
  resolve(): PromotedWidgetSource { /* one place, one precedence */ }
  get value() { return reduce(this.resolve()) }
  set value(v) { write(this.resolve(), v) }
}

The precedence (scoped → host → legacy) is named and visible, callers branch once on a discriminated union, adding a new resolution mode is a typed addition rather than a new private getter.

The best modules are deep: they have powerful functionality yet simple interfaces. — Ousterhout, APoSD, §4.5

@DrJKL DrJKL assigned dante01yoon and unassigned DrJKL Apr 29, 2026
@dante01yoon

dante01yoon commented Apr 29, 2026 •

Copy link
Copy Markdown
Collaborator Author

Follow-up on @DrJKL re-review:

Fixed in eea6cb5b:

  • cloneWidgetValue no longer catches structuredClone failures and returns the original reference. Uncloneable mutable values now fail loudly instead of risking shared references across promoted-widget instances.
  • Inline proxyWidgets state no longer accepts undefined as a valid { value }, so the configure path can treat the presence of inline state as intentional state.
  • Removed the misleading tuple-order comment around z.tuple arity.

I am intentionally keeping the larger architecture points as follow-up work rather than expanding this regression PR:

  • structured widget-store keys instead of string keys
  • object/discriminated persistence instead of the current tuple shape
  • moving promotion identity out of SubgraphNode.properties.proxyWidgets
  • adding a dedicated per-instance persistence slot
  • changing the LiteGraph serialization hook shape instead of deleting widgets_values after super.serialize()
  • eager scoped-store registration so render consumers do not need fallback snapshots
  • collapsing the promoted-view resolver surface

Those are good directions, but they touch persisted workflow format, store architecture, LiteGraph serialization hooks, and extension-observable behavior. This PR is scoped to restoring the SubgraphNode.widgets_values dead-field invariant and multi-instance promoted-widget isolation. Pulling the full architecture migration into this PR would raise merge risk and make the regression fix harder to review.

Validation for eea6cb5b:

  • pnpm test:unit -- src/core/schemas/promotionSchema.test.ts src/lib/litegraph/src/subgraph/SubgraphNode.multiInstance.test.ts
  • pnpm typecheck
  • pnpm format:check
  • pre-commit hook: oxfmt, oxlint, eslint, typecheck
  • pre-push hook: pnpm knip
  • GitHub CI is green, including unit test, lint-and-format, perf-tests, and the full Playwright matrix.

@dante01yoon dante01yoon removed their assignment Apr 29, 2026
@dante01yoon
dante01yoon requested a review from DrJKL April 29, 2026 04:46
@DrJKL

DrJKL commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Hello again — and thank you genuinely for the careful follow-up on eea6cb5b. The three fixes there are substantive and clean: cloneWidgetValue now fails loudly, the schema rejects undefined, the misleading comment is gone, and the locked-in test was inverted rather than deleted. That is the right kind of work, and I don't want any of what follows to obscure it.

I do want to gently push back on the framing of the rest, though — because there is an important distinction hiding inside the deferral list, and I think it's worth surfacing before this lands.


The distinction: deferring existing debt vs. shipping new debt

The two are not the same thing, and our usual scope-discipline arguments only license the first.

"Don't leave 'broken windows' (bad designs, wrong decisions, or poor code) unrepaired. Fix each one as soon as it is discovered." — Hunt & Thomas, The Pragmatic Programmer, §1.4 ("Software Entropy")

"Always leave the campground cleaner than you found it." — Robert C. Martin, Clean Code, ch. 1 (the Boy Scout Rule)

The Boy Scout Rule explicitly tolerates not improving what you didn't touch. It does not tolerate worsening it. Of the seven items in your deferral list, four are existing debt the PR isn't expanding (#1, #3, #7 — and arguably #9 of my numbering above). I have no objection to deferring those.

But three of the seven are debt this PR is creating, not pre-existing debt being left alone:

A. The 4-tuple persisted shape (deferral item 2)

Pre-#10849 there was no inline {value} form on proxyWidgets. This PR introduces the 4-tuple as the persisted format, which is — by your own migration note in the PR description — a one-way forward-incompatibility for users on pre-merge frontends. Once this lands, every workflow saved is committed to that shape until the follow-up format migration ships. Switching to a discriminated { kind, ... } object form later therefore costs:

  • A second format migration in user workflows.
  • A second compatibility window for extensions.
  • A second round of ecosystem coordination.

Doing it now costs:

  • Localized changes in promotionSchema.ts, _serializeEntries, the configure hydration path, and getProxyWidgetInlineState (which then disappears).

This is the textbook case where Hunt & Thomas's "broken windows" framing applies most strongly: the cost of fixing a persisted-format choice scales with the number of artifacts saved between now and the fix. That number starts climbing the moment this merges.

B. delete serialized.widgets_values (deferral item 5)

Pre-#10849 there was no delete. This PR introduces the LSP/Open–Closed violation along with the regression fix, even though the clean version is a one-method addition to LGraphNode:

protected getSerializableWidgetsValues(): unknown[] | undefined {
  return /* current logic */
}
protected override getSerializableWidgetsValues(): undefined {
  return undefined
}

This change does not touch persisted format. It does not touch the multi-instance isolation logic. It is strictly orthogonal to the "regression fix" framing — which means it isn't expanding scope, it's correcting a footgun the PR is introducing. The current delete will silently drop values for any future non-promoted widget on a SubgraphNode (the file already imports CANVAS_IMAGE_PREVIEW_WIDGET); we shouldn't ship a tripwire we already know about.

C. SafeWidgetData.value snapshot (deferral item 6)

The previous SafeWidgetData JSDoc — "Value and metadata are accessed via widgetValueStore" — was the intentional design. This PR walks it back with "value provides the LiteGraph fallback when no scoped store entry exists yet," and adds the field plus a fallback branch in render consumers. Each consumer that adopts the fallback path is a future audit when we want to remove it.

The eager-registration alternative is one site: in PromotedWidgetView's constructor, widgetValueStore.registerWidget(...) seeded from the source widget's current value. That is smaller than the field addition + consumer fallback path you're shipping today. Walking back the SSOT comment now and re-asserting it later is more work than not walking it back.


What's small and just hasn't been done

#4 — the legacy length-mismatch drop is still silent

92e03ea2 is good work — the behavioral tests pinning both the aligned-migration path and the deliberate drop are exactly right. But the original ask was for observability on the drop, and the console.warn still isn't there. Something like:

if (this._pendingLegacyWidgetsValues && !canHydrateLegacyWidgetsValues) {
  if (import.meta.env.DEV) {
    console.warn(
      `[SubgraphNode] Legacy widgets_values length (${this._pendingLegacyWidgetsValues.length}) ` +
      `does not match proxyWidgets length (${raw.length}); dropping legacy values for instance ${this.id}.`
    )
  }
}

Five lines. Closes the issue completely. Joe Armstrong's "errors should be loud" applies whether the failure is an exception or a silent data-shape mismatch.

#6 — the covert parameter is now load-bearing

This one I want to flag with extra care, because the recent legacy-migration fix made it harder to refactor away rather than easier. _pendingLegacyWidgetsValues is now used by both _internalConfigureAfterSlots and the migration logic at lines 1147 and 1186. Each new reader of an instance field used as a covert parameter increases the cost of replacing it with an explicit parameter later.

The refactor today is local:

override configure(info: ExportedSubgraphInstance): void {
  // ... other setup ...
  this._configureWith(info, info.widgets_values)
}

private _configureWith(info: ExportedSubgraphInstance, legacyValues: unknown[] | undefined) {
  super.configure(info)
  // _internalConfigureAfterSlots receives legacyValues via closure or an extra param
}

The refactor in three months — after a couple more callbacks have learned to read this._pendingLegacyWidgetsValues — is not local.

"Easy changes accumulate into hard changes." — Ousterhout, A Philosophy of Software Design, §1.2 ("the iceberg of complexity")

#11 — the behavior change still has no migration story

Tests confirm a deliberate inversion of the public contract: writing a promoted widget no longer mutates the source widget's .value. AGENTS.md explicitly flags this as the surface that affects 40+ custom-node repos, and the project ships an adding-deprecation-warnings skill specifically for this scenario. Even a paragraph in the PR description plus a defineDeprecatedProperty-style warning would be a meaningful step. Hyrum's Law is not optional:

"With a sufficient number of users of an API, it does not matter what you promise in the contract: all observable behaviors of your system will be depended on by somebody." — Hyrum Wright


The ask, concretely

I want to be specific about what would unblock approval, because I don't want this conversation to feel open-ended:

Must land in this PR (each is small and orthogonal)

  1. console.warn on the legacy length-mismatch drop. Five lines. Closes Migrate widgets.js #4.
  2. Replace delete serialized.widgets_values with a base-class hook. One method on LGraphNode, one override on SubgraphNode. Fixes the LSP violation and the silent-deletion tripwire for future non-promoted widgets. Does not change persisted format.
  3. A migration note in the PR description plus, ideally, a deprecation warning on the previous "writing promoted widget mutates source" contract. Even a docstring on PromotedWidgetView.value setter pointing extension authors at the new semantics would help.
  4. File concrete follow-up issues (with code references) for the architectural items being deferred. A comment in a PR thread is not a backlog. An issue link in the PR description is.

Strong preference (debatable but worth your reflection)

  1. Discriminated union for the persisted form (deferral item 2). This is the persisted-format commitment that is hardest to undo. The change is localized to promotionSchema.ts and four call sites. If we're going to introduce a new variant of the schema in this PR anyway, the marginal cost of doing it as a discriminated union rather than a tuple-arity union is small; the cost of migrating away from a tuple-arity union after N workflows have been saved against it is not.

  2. Eager scoped-store registration (deferral item 6 in your list / Migreate ui.js #8 in mine). Removes the need for SafeWidgetData.value and re-asserts the SSOT comment that previously documented the design. One site, in PromotedWidgetView's constructor.

Comfortably deferred

WidgetKey structuring, identity-on-Subgraph-definition, dedicated per-instance persistence slot, and the resolver-surface collapse. These are pre-existing or load-bearing-elsewhere; deferring them with concrete follow-up issues filed is reasonable.


A word, gently

I really don't want to read as inflexible. The instinct to ship the regression fix narrowly and revisit architecture later is usually the right instinct, and it's why the original deferral framing felt natural. The wrinkle here is that this PR isn't purely subtractive — it's introducing new persisted shape, new store-keying dimensions, and a new render-side fallback field, each of which has a longer half-life than the regression fix itself. The boundary between "deferring existing debt" (which I fully support) and "shipping new debt" (which we should be allergic to) is the operative line.

"The worst is the solution that is solved a little bit at a time." — Frederick Brooks, The Mythical Man-Month, ch. 17

If we ship the four "must" items above, the PR is genuinely a regression fix plus minimal architectural surface. If we additionally ship the two "strong preference" items, the follow-up architecture work becomes net cleanup of pre-existing concerns rather than walking back commitments made in this PR.

Either way: thank you for engaging seriously with the review. I appreciate it more than this paragraph count probably suggests. 🌱

@dante01yoon

Copy link
Copy Markdown
Collaborator Author

@DrJKL thank you for drawing the distinction between deferring existing debt and shipping new debt. I agree that this PR needed a bit more than the previous follow-up comment captured.

Fixed in 6ada401bb:

  • Added a DEV console.warn when legacy widgets_values length does not match proxyWidgets length, and updated the mismatch regression test to assert the warning.
  • Replaced the delete serialized.widgets_values cleanup with a base-class serialization hook: LGraphNode.getSerializableWidgetsValues(), overridden by SubgraphNode to return undefined.
  • Added an extension-facing note on PromotedWidgetView.value: promoted widget writes now update scoped per-instance state and no longer mutate the source widget's .value.
  • Updated the PR description with the migration/extension note and removed stale wording around the old clone fallback / legacy handling.

I also filed concrete follow-up issues with code references:

I left the discriminated persisted shape and eager scoped-store registration as follow-ups rather than landing them in this regression PR because both change broader persisted/render architecture beyond the immediate corruption fix. They are now tracked as backlog issues instead of living only in this review thread.

Validation:

  • pnpm test:unit -- src/lib/litegraph/src/subgraph/SubgraphNode.multiInstance.test.ts src/lib/litegraph/src/LGraphNode.test.ts
  • pnpm typecheck
  • pnpm format:check
  • pnpm exec oxlint src/core/graph/subgraph/promotedWidgetView.ts src/lib/litegraph/src/LGraphNode.ts src/lib/litegraph/src/subgraph/SubgraphNode.ts src/lib/litegraph/src/subgraph/SubgraphNode.multiInstance.test.ts
  • commit hook: oxfmt, oxlint, eslint, typecheck
  • push hook: pnpm knip

@DrJKL

DrJKL commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Thank you for eea6cb5b — the throw-on-clone-failure inversion, the undefined rejection in inline proxyWidgets state, and removing the misleading tuple-ordering comment all land cleanly. That's three of the smaller items from the previous review absorbed without drama, and the test inversions in particular show care: a test that asserts a throw is a much louder canary than one that swallows it. 🌱

I owe you a third (and intended-final) round of feedback, and I want to be upfront about its shape before you read it: I spent meaningful time on this before writing, including weighing whether the right thing was simply to drop my objections, given that you have already shipped working behavior under regression tests, and given that the seven deferred items are real and reasonable to defer. I considered that, and rejected it — not because the deferrals are unreasonable individually, but because re-reading the PR end-to-end against Issue #10146 made me believe the PR is solving two problems where there is really only one, and the second "problem" is an artifact of how the first was approached rather than a thing that exists in the domain.

I also want to be clear that I considered (and rejected) asking for a pure rollback of #10849. The user impact of #10146 — silent wrong image generation on workflow load — is strictly worse than the template-corruption regression #11559 is fixing, and a pure revert resurrects it. So this isn't an argument for "don't fix it." It's an argument for "the cleaner fix is smaller than what's currently in the diff."

What follows is an attempt to lay that out as carefully as I can, so you (and the maintainers reading along) can decide whether it's worth a course correction now or whether the cost of re-cutting the PR exceeds the cost of carrying the extra surface area forward. I will try to be specific where I can, fair where the PR has good arguments on its side, and brief where the previous two reviews already covered the ground.


I. The story of how we got here

I think the clearest way to talk about this is as a sequence of timelines — five small acts, each ending with a single new piece of state being introduced that, with the benefit of hindsight, was either avoidable or pointed in a different direction than the one taken. Forgive me the theatricality; I find it easier to reason about regressions when they are told as a sequence of decisions rather than as a static diff.

Act I — v1.39.x and earlier: one widget, one value

Before the Vue-rendered widget pipeline, a widget's value lived in exactly one place: as a property on the plain widget object hanging off LGraphNode.widgets. Subgraphs existed but multi-instancing of the same subgraph blueprint was rare in user workflows in the wild. Issue #10146 was latent here — the data model already could not represent N instances of one inner widget — but it was invisible because almost no workflow exercised the multi-instance case.

╭──────────────╮     reads/writes      ╭───────────────╮
│ LGraphNode   │ ────────────────────▶ │ widget.value  │
│ .widgets[i]  │                       │ (plain field) │
╰──────────────╯                       ╰───────────────╯

One cell, one consumer, no ambiguity. The schema (widgets_values: any[]) is a positional projection of those cells. This is the format that workflows-on-disk have always carried, and the format the rest of the ComfyUI ecosystem expects.

Act II — v1.41.3 (PR #8594): WidgetValueStore is born

To support reactive Vue rendering, widget values were lifted into a Pinia store. The keying choice was natural for the problem in front of the author at the time: (graphId, nodeId, widgetName) (src/stores/widgetValueStore.ts:17). For non-subgraph nodes this is correct, because nodeId uniquely identifies the node within its graph.

For subgraph inner nodes, however, nodeId is the inner node's id within the Subgraph blueprint — and the blueprint is shared by reference across every SubgraphNode instance of that subgraph. From src/lib/litegraph/src/LGraph.ts:1671 (this.subgraphs.set(id, subgraph)) and src/lib/litegraph/src/subgraph/SubgraphNode.ts:750 (readonly subgraph: Subgraph), every SubgraphNode of the same subgraph holds the same blueprint reference and therefore the same inner LGraphNodes. Their inner widget values are intrinsically shared.

graph TD
  A["SubgraphNode #A<br/>outer instance 1"] --> S["Subgraph blueprint<br/>(shared by reference)"]
  B["SubgraphNode #B<br/>outer instance 2"] --> S
  C["SubgraphNode #C<br/>outer instance 3"] --> S
  S --> N["inner LGraphNode<br/>id = 7"]
  N --> K["WidgetValueStore key<br/>(graphId, nodeId=7, 'seed')<br/>ONE CELL"]
Loading

That last box is the bug. The store has one cell where the runtime needs N. Every instance writing through the same key clobbers the others. Issue #10146 is born here, but it is invisible until users actually save and re-load workflows with multi-instance subgraphs.

Act III — April 2026 (PR #10849, 6847c7ba2): the forward fix

The forward fix introduces a per-instance Map on each SubgraphNode (_instanceWidgetValues) and routes promoted-widget writes through PromotedWidgetView.value's setter into that Map. On serialize, the instance's Map is projected into positional widgets_values; on configure, widgets_values is read back into the Map. This restores per-instance isolation at runtime and on disk in the existing positional format.

graph TD
  PV["PromotedWidgetView<br/>per-instance, runtime-only"] --> M["SubgraphNode<br/>._instanceWidgetValues<br/>per-instance Map"]
  M -.serialize.-> WV["widgets_values: any[]<br/>positional, on disk"]
  WV -.load.-> M
Loading

This is correct in the small. The unfortunate side effect is that SubgraphNode.serialize() now writes widgets_values, when historically that field on a SubgraphNode was a dead artifact carrying noise from older saves (e.g. the Z-Image-Turbo template that tripped the regression on Slack). Templates saved before #10849 had legacy junk in that slot; #10849 began interpreting that slot. Hence the regression that PR #11559 is fixing.

Act IV — PR #11559 today: the forward-forward fix

To restore the dead-field invariant on SubgraphNodes ("don't trust legacy widgets_values on a SubgraphNode") and to keep multi-instance isolation, this PR makes a much larger commitment than #10849 did:

  • inlines {value} into the persisted proxyWidgets 4-tuple,
  • adds instanceId scoping to widgetValueStore,
  • introduces SafeWidgetData.value as a snapshot field,
  • adds delete serialized.widgets_values in SubgraphNode.serialize(),
  • adds _pendingLegacyWidgetsValues as a covert instance field,
  • adds cloneWidgetValue as a defensive utility,
  • and adds a 4-tuple parser/migrator pair.

The framing is "restore the dead-field invariant + multi-instance isolation." The diff is +876 / −382 with three new files. The seven items you deferred are deferred precisely because this PR opens that much new architectural surface in the first place — it is the surface area, not the deferral, that is the lever I want to push on here.

graph TD
  PV["PromotedWidgetView setter"] --> WS["widgetValueStore<br/>+instanceId scoping"]
  PV --> IM["_instanceWidgetValues Map<br/>(legacy from #10849)"]
  PV --> SAFE["SafeWidgetData.value<br/>snapshot"]
  IM -.serialize.-> P4["proxyWidgets 4-tuple<br/>[nid, name, disambig, {value}]"]
  WS -.serialize.-> P4
  P4 -.load.-> PEND["_pendingLegacyWidgetsValues<br/>covert instance field"]
  PEND -.replay.-> PV
  SUB["super.serialize()"] -.deletes.-> WV["widgets_values<br/>(deleted, defence in depth)"]
  CLONE["cloneWidgetValue<br/>defensive utility"] -.guards.-> P4
Loading

Read this last diagram with the question from the very first review: if I edit a promoted widget once, how many writes have to happen, and how many reads have to agree? The answer here is "many." That is the smell.

Act V — the proposed alternate timeline (S7)

Now consider a smaller patch that takes Act III as its starting point and asks: what is the minimum change that fixes Issue #10146 at its root, without introducing any new schema?

graph TD
  PV["PromotedWidgetView setter<br/>(per-instance, unchanged)"] --> WS["widgetValueStore<br/>keyed (instanceId, graphId, nodeId, name)<br/>SSOT"]
  WS -.serialize.-> WV["widgets_values: any[]<br/>positional, unchanged on wire"]
  WV -.load.-> WS
Loading

One change: add instanceId to the store key. The runtime SSOT shifts from "Map on the SubgraphNode" to "the store itself," which is what the rest of the Vue render path is already reading from anyway. Inner widget reads/writes already go through PromotedWidgetView, whose setter is the single chokepoint where instance identity is known. The on-wire format does not change. No delete. No covert _pending* field. No 4-tuple. No snapshot. No defensive clone. No migrator.

Sketch in §III.


II. The diagnosis from first principles

"Where there is repetition, there is the opportunity to reduce it; where there is a single piece of knowledge, that knowledge belongs in exactly one place." — Hunt & Thomas, paraphrasing themselves

The bug — the actual bug, the user-visible "silent wrong output on multi-instance subgraph load" of #10146 — has one root cause: widgetValueStore keys do not include the per-instance dimension. That is the entirety of it. Everything else this PR addresses is downstream of (a) treating widgets_values on a SubgraphNode as authoritative when historically it was noise, and (b) the fact that a Subgraph blueprint is structurally shared.

Once you fix the keying, three things become true at once:

  1. The store is the SSOT. There is exactly one cell per instance per widget. There is no possibility of "two values disagree" because there is only one place values live.
  2. widgets_values on the wire is just a projection of the store. It is no longer a competing source of truth; it is the format the file system speaks. The ComfyUI execution path, the rest of the workflow ecosystem, and pre-v1.41.3 saves all already speak this format.
  3. The need for delete serialized.widgets_values, for SafeWidgetData.value, for _pendingLegacyWidgetsValues, for the 4-tuple, for the migrator, and for cloneWidgetValue evaporates — they were each individually reasonable answers to "how do we make the inline-{value} schema not collide with positional widgets_values," but that question stops being asked when you don't add the inline {value} schema.

This is, I think, what Ousterhout means by deep modules in A Philosophy of Software Design — the interface should be narrow (one keying rule, one projection) relative to the functionality (per-instance widget value isolation across all subgraph instances, all storage paths, all hydration paths). PR #11559 widens the interface considerably (a new schema variant, a new instance field on every SubgraphNode, a new field on SafeWidgetData, a new utility, a new pending-state slot) to keep the existing implementation shape. S7 narrows the interface (one new key dimension on the store) and lets the implementation get smaller as a result.


III. The proposed S7 fix (concrete sketch)

What stays from #11559

  • instanceId dimension on widgetValueStore keys.
  • The instance-scoped getter/setter chokepoint at PromotedWidgetView.value.
  • The regression tests from PR #11697 (they pass under S7 because S7 implements the same runtime contract).

What reverts from #11559

  • Inline {value} in proxyWidgets (back to 2/3-tuple).
  • SafeWidgetData.value snapshot field.
  • delete serialized.widgets_values in SubgraphNode.serialize().
  • _pendingLegacyWidgetsValues covert field.
  • cloneWidgetValue utility.
  • 4-tuple parser/migrator (with one transitional caveat — see §VI).

What changes from #10849

  • _instanceWidgetValues Map on SubgraphNode is removed (the store replaces it).
  • The serialize() projection loop and the _internalConfigureAfterSlots rehydration loop point at the store instead of the Map. Same shape, ~10 lines each.

Pseudocode sketch (illustrative; not the literal patch)

// src/stores/widgetValueStore.ts — one new dimension on the key
type WidgetKey =
  `${graphId}:${nodeId}:${widgetName}`              // unchanged for non-subgraph
  | `${instanceId}@${graphId}:${nodeId}:${widgetName}` // new for promoted views

// src/core/graph/subgraph/promotedWidgetView.ts
//   the setter already knows the host instance; it becomes the chokepoint
set value(v) {
  widgetValueStore.set(
    /* instanceId */ this.subgraphNode.id,
    /* graphId    */ this.graphId,
    /* nodeId     */ stripGraphPrefix(this.sourceNodeId),
    /* widgetName */ this.sourceWidgetName,
    v,
  )
}

// src/lib/litegraph/src/subgraph/SubgraphNode.ts
//   serialize: project store into positional widgets_values
override serialize(): ISerialisedNode {
  const out = super.serialize()
  const views = this._getPromotedViews().filter(v => v.sourceSerialize)
  out.widgets_values = views.map(v => {
    const value = widgetValueStore.get(this.id, /*…*/, v.sourceWidgetName)
                  ?? v.value
    return isObject(value) ? structuredClone(value) : (value ?? null)
  })
  return out
}

//   configure: hydrate store from positional widgets_values
override _internalConfigureAfterSlots() {
  // ...existing slot rebind, proxyWidgets parse, promotion store hydrate...
  if (this._pendingWidgetsValues) {
    const views = this._getPromotedViews().filter(v => v.sourceSerialize)
    views.forEach((view, i) => {
      if (i < this._pendingWidgetsValues!.length) {
        view.value = this._pendingWidgetsValues![i]   // -> writeScopedValue
      }
    })
    this._pendingWidgetsValues = undefined
  }
}

Net diff vs. main, on top of #10849: roughly +150 / −50, no schema change, no new files, no new instance fields, no new utilities. Workflows saved under S7 are byte-equivalent to v1.39.x format with correct per-instance values.

The file:line references that make this concrete and that I'd encourage anyone evaluating this to verify directly:

  • src/lib/litegraph/src/LGraph.ts:1671 — this.subgraphs.set(id, subgraph), single blueprint creation per subgraph.id.
  • src/lib/litegraph/src/subgraph/SubgraphNode.ts:750 — readonly subgraph: Subgraph shared reference.
  • src/stores/widgetValueStore.ts:17 — current keying; the one place to add instanceId.
  • src/core/graph/subgraph/promotedWidgetView.ts:85 — readonly serialize = false on promoted views, which is why an explicit serialize loop on SubgraphNode is needed (and why fix: store promoted widget values per SubgraphNode instance #10849 already has one).
  • src/lib/litegraph/src/LGraph.ts:2675 — LGraph.configure walks outer nodes sequentially; under shared-blueprint semantics each instance's widgets_values overwrites earlier instances' shared store entries today, which is exactly the symptom of [Regression] Loading a workflow from an image sets incorrect subgraph parameters #10146 and what instanceId-scoped keys remove at the root.

IV. SSOT scorecard

Lens PR #11559 today S7
Per-instance value storage sites 4+ (proxyWidgets[3].value, _instanceWidgetValues legacy, _pendingLegacyWidgetsValues, store) 1 (store)
Key-encoding schemes 4 (@-string store key, 4-tuple positional, proxyWidgets[3].value inline, snapshot field) 1 (store key)
New persisted-format variants 1 (4-tuple) 0
Backwards-compat scaffolding for the new format _pendingLegacyWidgetsValues + 4-tuple migrator + snapshot + clone none
New files 3 0
Diff size relative to #10849 +876 / −382 ~+150 / −50

This is approximate, not a sharp measurement. But the order of magnitude difference is the point: when the keying is fixed at the source, almost everything else falls out, because almost everything else was scaffolding to keep two would-be sources of truth from disagreeing.

"There is no part so reliable as the part you didn't add." — folk variant of Antoine de Saint-Exupéry, by way of every embedded engineer who has had to debug at 3 a.m.


V. Steelman for keeping #11559 as-is

I want to make sure I'm being fair here. The PR is not arbitrary; there are real arguments for the inline-{value} schema. Here are the four strongest I can construct, with what I take to be honest counters:

1. Inline {value} is robust to the blueprint changing between saves. If a user adds or removes a promoted widget between save and load, positional widgets_values shifts and indices may misalign. An inline {value} keyed by widget identity does not have this problem.

Counter: this is a real concern, but it is a separate concern from #10146, and it predates this PR. If we want robustness against blueprint shape drift, the focused answer is a sidecar {instanceKey → index} map written alongside widgets_values, not a universal schema change. We can ship that change deliberately when we're ready to commit to a new persisted shape, with the migration story planned end-to-end. Bundling it into a regression fix forecloses better designs.

2. SafeWidgetData.value snapshot helps Vue avoid reactive-proxy issues during serialize. Reactive proxies inside JSON.stringify paths have bitten this codebase before.

Counter: LGraphNode.serialize already does a structured-clone-equivalent (JSON.parse(JSON.stringify(...))) on widget values precisely to handle this. Adding a parallel snapshot field is belt-and-suspenders that introduces a second authoritative copy of every widget value at serialize time. If reactive-proxy escape is a real and reproducible bug, it's worth fixing directly in the existing clone path; if it isn't, the snapshot is dead code that future maintainers will be afraid to remove (Hyrum's Law in slow motion).

3. Two-source-of-truth drift between widgets_values and inline {value} is exactly what delete serialized.widgets_values prevents. Removing the legacy projection guarantees the new schema is authoritative.

Counter: under S7 there is one source — the store. widgets_values is just the on-wire projection of the store; nothing reads it at runtime. There is no drift to prevent because there is no second source to drift from. The delete is a sensible patch given the inline-{value} decision; remove that decision and the patch is unnecessary. Subverting LGraphNode.serialize's contract from a subclass with a delete is precisely the kind of base-class subversion Liskov would frown at, and the prior follow-up's "base-class hook instead of delete" suggestion was an attempt to sand that edge — but the cleanest sanding is "don't need to delete it in the first place."

4. The PR has been red-green verified with it.fails regression tests from PR #11697 flipping to passing on this branch.

Counter: this is real and important, and I want to acknowledge it without diminishing it. Those tests are testing a runtime contract: each instance's promoted-widget value round-trips independently of every other instance's. S7 implements the same contract — instance-scoped writes through PromotedWidgetView.value's setter — on a simpler persistence surface. If S7 lands, the same tests pass. The tests do not constrain which implementation; they only verify the externally observable behavior, which is exactly the property we want of regression tests (per Beck's "tests are the shape of the cliff edge, not the path you walked along it").

There may be a fifth steelman I haven't found, and if so I'd genuinely like to hear it; reviewing my own argument for holes is the part I'm least confident about.


VI. Migration story (the three cohorts)

There are three populations of workflow files in the wild, and a serious answer needs to be honest about what each one experiences.

Cohort A — pre-v1.41.3 workflows. Positional widgets_values carries per-instance data correctly, because there was no shared store collapsing it. Under S7, these load correctly — more correctly than they do today, since today's path runs them through #10849's instance Map and PR #11559's 4-tuple, neither of which they were saved against. This is the cohort that benefits most from S7: it restores forward compatibility with the same positional format their files have always carried.

Cohort B — v1.41.3 through v1.43.x workflows. These were saved while the store was collapsing all instances into one cell. On disk, widgets_values for a given SubgraphNode reflects whichever instance was serialized last — every instance shows the same value. There is no recovery story for these. No PR can magically reconstruct data that was never persisted. Under both #11559-as-shipped and S7, users with these files re-edit per-instance values once after upgrade. This is unfortunate but is not a difference between the two approaches.

Cohort C — v1.44.x workflows saved under PR #11559's 4-tuple form. This is the only cohort where the choice has a cost. If S7 simply drops the 4-tuple, these files lose their per-instance values on load (they fall back to positional widgets_values, which #11559 now deletes, leaving nothing).

Mitigation: keep the 4-tuple parser in parseProxyWidgets for one release cycle as a read-only fallback. Roughly:

// ~5 lines: if 4-tuple inline {value} is present, populate the store
// for that instance/widget. This is read-only fallback; the writer
// always emits the 3-tuple + positional widgets_values shape.

Drop the parser in the next release with a console deprecation notice in between. This is consistent with how the prior follow-up framed deprecation ("warn loudly when accommodating legacy data, then remove the accommodation in a subsequent release") and gives Cohort C a clean upgrade path.

Cohort C is small if PR #11559 has not yet reached a stable release. If it has, the cost of the parser-shim mitigation is bounded and clearly time-limited.


VII. The ask

I want to be specific about what I am asking for, because "rework" without specifics is not a fair request to make of an author who has already shipped working behavior under regression tests.

Two procedural shapes are worth considering, and I do not have a strong preference between them — they are both honest paths and the choice is yours and the maintainers':

Option 1 — Rework this branch in place

Push the S7 changes onto the existing PR branch. This preserves PR history, reviewer continuity, and the regression tests already attached to the PR. The transitional 4-tuple parser shim (§VI) goes in alongside the schema revert. The branch goes from "introduces 4-tuple persistence" to "tightens widgetValueStore keying" — a smaller, more focused PR with the same green tests.

Estimated cost: ~1–2 days of author time, given that the runtime chokepoint (PromotedWidgetView.value setter) is already where instance scoping lives in the current branch. The mechanical work is removing the schema scaffolding and routing the existing serialize/configure projections through the store instead of the instance Map.

Option 2 — Close this PR; open a smaller successor

Land PR #11697's it.fails markers on main as a holding pattern, and open a new PR scoped to "add instanceId to widgetValueStore + replace _instanceWidgetValues Map with store-keyed reads." The new PR inherits this PR's regression contract and reviewer audience but starts fresh from a clean diff base.

Estimated cost: comparable to Option 1, with the trade that PR history is split (this PR's discussion threads don't carry over) but the resulting diff is easier for new reviewers to evaluate from cold start.

What either option requires

  • The runtime contract under regression tests stays exactly as it is now (same it.fails flips, same multi-instance isolation).
  • _instanceWidgetValues Map from fix: store promoted widget values per SubgraphNode instance #10849 is removed; the store replaces it.
  • The 4-tuple parser stays for one release as the migration shim for Cohort C; the writer never emits it.
  • A short note in the PR description and CHANGELOG explaining the Cohort C migration window.
  • No deprecation warnings on the source-widget-mutation contract change are needed under S7, because the runtime contract is the same as fix: restore SubgraphNode.widgets_values dead-field invariant (#10849 regression) #11559's — it's the persistence surface that shrinks. (The earlier follow-up's request for deprecation warnings was conditional on shipping the new contract; that becomes a non-issue here.)

What re-review costs

The Codex / @jaeone94 reviewers who endorsed the 4-tuple shape because "identity and value travel together so reorders don't desync" will rightly want to weigh in on the trade. The honest framing for them: "S7 makes the store the SSOT; identity and value desync is impossible because there is only one place values live; the persistence surface is the existing positional format that the entire ComfyUI ecosystem already speaks." If they push back hard, that's a real signal worth taking seriously, and at that point shipping #11559 as-is with the prior follow-up's items addressed (the console.warn on legacy length-mismatch drop, the base-class serialize hook, the migration note, the filed follow-up issues) is a reasonable fallback.

I am asking for the architectural conversation to happen now, before the persistence surface ships, because §VI's Cohort C only grows once #11559 reaches a stable release.


VIII. Closing word

The throughline I want to leave you with is this: #10849 was correct in instinct and small in size; #11559 has correct instincts but very much not small in size, and the difference between them is that #11559 chose to fix the regression and land an architectural commitment to a new persisted shape simultaneously. Those are separable concerns. S7 is what the regression fix looks like when they are separated.

You have engaged seriously with every round of feedback so far. The work in this PR — the regression contract, the instance-scoped chokepoint, the test inversions, the responses to the prior reviews — informs whatever ships next. The question now is just where the architectural commitment line gets drawn, and how durable that commitment is. The persisted format is the most durable kind of commitment a codebase can make; I'd ask that we be especially deliberate about that one.

Whichever path you take, thank you for the patience with three rounds of dense feedback. I really do think the codebase ends up better for the engagement, even when (especially when) the conclusion is "do less."

"Perfection is achieved, not when there is nothing more to add, but when there is nothing left to take away." — Antoine de Saint-Exupéry, Wind, Sand and Stars

🌱

@DrJKL DrJKL assigned dante01yoon and unassigned DrJKL Apr 29, 2026
@dante01yoon

Copy link
Copy Markdown
Collaborator Author

@DrJKL thanks for taking the time to write this out. I agree with the main architectural instinct behind S7: the instance dimension belongs in the value layer, and the current widgetValueStore scoping work is the direction we should keep moving.

I do not think we should re-cut this PR to S7 before landing, though.

First, a couple of details in the S7 comparison are now stale against the current head:

  • SubgraphNode.serialize() no longer deletes serialized.widgets_values after super.serialize(). 6ada401bb replaced that with LGraphNode.getSerializableWidgetsValues(), overridden by SubgraphNode.
  • _instanceWidgetValues is no longer present on this branch.

The larger reason is that I think there are two separate constraints here, not one:

  1. Runtime instance isolation: the value store needs an instance coordinate. I agree with that, and this PR already moves in that direction.
  2. Persistence safety for SubgraphNode.widgets_values: fix: store promoted widget values per SubgraphNode instance #10849 proved that treating that field as authoritative on legacy SubgraphNode saves can corrupt real templates. S7 fixes the runtime cell count, but it still depends on positional widgets_values as the writer/reader projection. That means the load path still needs to answer which promoted view each positional value belongs to, and it reopens the same class of stale/noisy positional-data risk this PR is trying to close.

The reason I am comfortable with the current inline { value } shape for this regression PR is that the persisted value is attached to the same promotion identity that already survives the existing remap/dedup/nested-subgraph paths. It is not the final architecture I would design from a clean sheet, but it makes the corruption fix local and avoids trusting a field that has already been demonstrated to contain historical noise.

I think S7 is worth prototyping as follow-up work, especially under #11740 / #11741. The acceptance bar I would want for that prototype is:

  • it keeps the runtime store as the single per-instance value cell;
  • it demonstrates that save/load is stable when promoted-widget order changes or stale widgets_values exists on a SubgraphNode;
  • it has a concrete migration story for workflows saved with the current 4-tuple form;
  • it can prove the same regression tests without depending on positional legacy data that caused this PR.

Given the current branch state, green CI, and the already-filed follow-ups, my preference is to land this regression fix and evaluate S7 as a deliberate successor/prototype rather than resetting this PR into a broader architecture rewrite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants