Repository navigation
revert: roll back #10849 + #11697 (per-instance promoted widget values) - #11790
Conversation
📝 WalkthroughWalkthroughThe changes refactor the promoted widget serialization mechanism in subgraphs, replacing per-instance widget value tracking with direct syncing of widget values into the subgraph definition before serialization. Multiple test assets and test suites covering the old mechanism are removed. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Poem
🚥 Pre-merge checks | ✅ 5 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook |
🎭 Playwright: ✅ 1441 passed, 0 failed · 2 flaky📊 Browser Reports
|
📦 Bundle: 5.23 MB gzip 🟢 -1 kBDetailsSummary
Category Glance App Entry Points — 22.5 kB (baseline 22.5 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.24 MB (baseline 1.24 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 77.7 kB (baseline 77.7 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 2 unchanged Panels & Settings — 488 kB (baseline 488 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 11 unchanged User & Accounts — 17.5 kB (baseline 17.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed / 2 unchanged Editors & Dialogs — 113 kB (baseline 113 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 4 added / 4 removed UI Components — 61 kB (baseline 61 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 8 unchanged Data & Services — 3.04 MB (baseline 3.04 MB) • 🟢 -4.25 kBStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 364 kB (baseline 364 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 13 added / 13 removed / 18 unchanged Vendor & Third-Party — 9.88 MB (baseline 9.88 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 8.84 MB (baseline 8.84 MB) • ⚪ 0 BBundles that do not match a named category
Status: 57 added / 57 removed / 78 unchanged ⚡ Performance Report
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-05-01T02:25:31.129Z",
"gitSha": "862d4b8bca81329e13edd18f69b943289f214f02",
"branch": "drjkl/reset-subgraph-stuff",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2023.842000000002,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.954,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.537,
"heapDeltaBytes": 23116848,
"heapUsedBytes": 71635308,
"domNodes": 18,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 26.305,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2029.3179999999893,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.03,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.65000000000003,
"heapDeltaBytes": 23467248,
"heapUsedBytes": 72426764,
"domNodes": 22,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 27.003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2035.74100000003,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.590999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.581,
"heapDeltaBytes": 23102128,
"heapUsedBytes": 71684504,
"domNodes": 16,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 24.226000000000006,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2019.204000000002,
"styleRecalcs": 78,
"styleRecalcDurationMs": 50.54,
"layouts": 12,
"layoutDurationMs": 3.9939999999999993,
"taskDurationMs": 1013.768,
"heapDeltaBytes": 6689248,
"heapUsedBytes": 55334776,
"domNodes": -266,
"jsHeapTotalBytes": 16642048,
"scriptDurationMs": 152.021,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1804.6339999999645,
"styleRecalcs": 75,
"styleRecalcDurationMs": 37.052,
"layouts": 12,
"layoutDurationMs": 5.1419999999999995,
"taskDurationMs": 743.1229999999999,
"heapDeltaBytes": 18000788,
"heapUsedBytes": 67246920,
"domNodes": 57,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 126.498,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1839.4930000000613,
"styleRecalcs": 72,
"styleRecalcDurationMs": 35.594,
"layouts": 12,
"layoutDurationMs": 3.521,
"taskDurationMs": 795.9110000000001,
"heapDeltaBytes": 4996588,
"heapUsedBytes": 53286020,
"domNodes": -263,
"jsHeapTotalBytes": 15855616,
"scriptDurationMs": 126.37799999999999,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1715.6800000000203,
"styleRecalcs": 31,
"styleRecalcDurationMs": 19.757000000000005,
"layouts": 6,
"layoutDurationMs": 0.742,
"taskDurationMs": 360.282,
"heapDeltaBytes": 223968,
"heapUsedBytes": 48565452,
"domNodes": 76,
"jsHeapTotalBytes": 14680064,
"scriptDurationMs": 27.802,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.15599999998,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.075999999999997,
"layouts": 6,
"layoutDurationMs": 0.586,
"taskDurationMs": 350.11899999999997,
"heapDeltaBytes": 5548520,
"heapUsedBytes": 70773256,
"domNodes": 78,
"jsHeapTotalBytes": 20283392,
"scriptDurationMs": 30.488000000000007,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1755.8640000000878,
"styleRecalcs": 30,
"styleRecalcDurationMs": 19.221999999999998,
"layouts": 6,
"layoutDurationMs": 0.7950000000000002,
"taskDurationMs": 328.97800000000007,
"heapDeltaBytes": 117792,
"heapUsedBytes": 48859612,
"domNodes": 77,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 22.323000000000004,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 562.5580000000241,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.984000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 343.26,
"heapDeltaBytes": 9133388,
"heapUsedBytes": 57273660,
"domNodes": 16,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 60.265,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 587.9039999999804,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.393000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 354.417,
"heapDeltaBytes": 8666408,
"heapUsedBytes": 57294840,
"domNodes": 20,
"jsHeapTotalBytes": 15990784,
"scriptDurationMs": 58.685,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 579.7949999999901,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.77,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 351.966,
"heapDeltaBytes": 9089848,
"heapUsedBytes": 57397476,
"domNodes": 16,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 62.141,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2010.6709999999453,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.108999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 707.295,
"heapDeltaBytes": 3988980,
"heapUsedBytes": 62318996,
"domNodes": -262,
"jsHeapTotalBytes": 557056,
"scriptDurationMs": 116.899,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2030.010999999945,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.487000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 556.578,
"heapDeltaBytes": 12815296,
"heapUsedBytes": 71011656,
"domNodes": -263,
"jsHeapTotalBytes": 32768,
"scriptDurationMs": 95.83999999999999,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2036.6450000000214,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.295000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 594.9889999999999,
"heapDeltaBytes": 3366024,
"heapUsedBytes": 61669632,
"domNodes": -262,
"jsHeapTotalBytes": 557056,
"scriptDurationMs": 105.462,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2161.864000000037,
"styleRecalcs": 69,
"styleRecalcDurationMs": 19.258999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1223.296,
"heapDeltaBytes": 2833444,
"heapUsedBytes": 62095624,
"domNodes": -267,
"jsHeapTotalBytes": 1810432,
"scriptDurationMs": 422.47600000000006,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2160.837000000015,
"styleRecalcs": 69,
"styleRecalcDurationMs": 19.763,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1147.77,
"heapDeltaBytes": -980768,
"heapUsedBytes": 58410580,
"domNodes": -264,
"jsHeapTotalBytes": 1548288,
"scriptDurationMs": 414.869,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2111.8889999999055,
"styleRecalcs": 68,
"styleRecalcDurationMs": 18.028000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1156.636,
"heapDeltaBytes": 5541612,
"heapUsedBytes": 64829604,
"domNodes": -263,
"jsHeapTotalBytes": 1024000,
"scriptDurationMs": 434.68600000000004,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3180.5930000000444,
"styleRecalcs": 64,
"styleRecalcDurationMs": 18.662,
"layouts": 60,
"layoutDurationMs": 8.112000000000002,
"taskDurationMs": 1482.773,
"heapDeltaBytes": 9048352,
"heapUsedBytes": 69954020,
"domNodes": -273,
"jsHeapTotalBytes": 557056,
"scriptDurationMs": 536.7570000000001,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3248.6670000000686,
"styleRecalcs": 66,
"styleRecalcDurationMs": 20.591,
"layouts": 60,
"layoutDurationMs": 7.911999999999999,
"taskDurationMs": 1487.827,
"heapDeltaBytes": 10680284,
"heapUsedBytes": 71759676,
"domNodes": -267,
"jsHeapTotalBytes": 1081344,
"scriptDurationMs": 565.91,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3169.4459999999935,
"styleRecalcs": 65,
"styleRecalcDurationMs": 19.169999999999998,
"layouts": 60,
"layoutDurationMs": 7.536,
"taskDurationMs": 1355.409,
"heapDeltaBytes": 8275612,
"heapUsedBytes": 68750432,
"domNodes": -269,
"jsHeapTotalBytes": 5537792,
"scriptDurationMs": 502.864,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2018.5490000000073,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.432000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 674.515,
"heapDeltaBytes": 1944040,
"heapUsedBytes": 62244052,
"domNodes": -265,
"jsHeapTotalBytes": 557056,
"scriptDurationMs": 114.78200000000001,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2039.333000000056,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.807,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 612.747,
"heapDeltaBytes": 8776616,
"heapUsedBytes": 69097100,
"domNodes": -262,
"jsHeapTotalBytes": -229376,
"scriptDurationMs": 105.682,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2019.7389999999587,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.796,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 605.363,
"heapDeltaBytes": 5068380,
"heapUsedBytes": 65554312,
"domNodes": -263,
"jsHeapTotalBytes": 819200,
"scriptDurationMs": 107.371,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 600.3830000000221,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.042999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.489,
"heapDeltaBytes": 9357328,
"heapUsedBytes": 58063440,
"domNodes": 18,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 125.18100000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 552.379999999971,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.167,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.602,
"heapDeltaBytes": 8792516,
"heapUsedBytes": 57462628,
"domNodes": 18,
"jsHeapTotalBytes": 16252928,
"scriptDurationMs": 122.69099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 524.5350000000144,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.297000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 339.27000000000004,
"heapDeltaBytes": 9098280,
"heapUsedBytes": 57715176,
"domNodes": 16,
"jsHeapTotalBytes": 16777216,
"scriptDurationMs": 114.201,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2005.5529999999635,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.301000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.53700000000003,
"heapDeltaBytes": 22531624,
"heapUsedBytes": 71216808,
"domNodes": 18,
"jsHeapTotalBytes": 14680064,
"scriptDurationMs": 22.321,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2004.0449999999055,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.030999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.186,
"heapDeltaBytes": 22552880,
"heapUsedBytes": 71107600,
"domNodes": 18,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 21.995,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2003.6379999999099,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.082999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.451,
"heapDeltaBytes": 22527548,
"heapUsedBytes": 71157776,
"domNodes": 18,
"jsHeapTotalBytes": 14417920,
"scriptDurationMs": 20.378000000000007,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1981.6509999999994,
"styleRecalcs": 85,
"styleRecalcDurationMs": 50.58,
"layouts": 16,
"layoutDurationMs": 4.192,
"taskDurationMs": 954.337,
"heapDeltaBytes": 14081108,
"heapUsedBytes": 63378920,
"domNodes": 74,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 109.464,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.6779999999771,
"styleRecalcs": 77,
"styleRecalcDurationMs": 40.098,
"layouts": 16,
"layoutDurationMs": 4.873,
"taskDurationMs": 704.289,
"heapDeltaBytes": 14388060,
"heapUsedBytes": 62919252,
"domNodes": 63,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 98.165,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1703.581999999983,
"styleRecalcs": 74,
"styleRecalcDurationMs": 37.636,
"layouts": 16,
"layoutDurationMs": 4.49,
"taskDurationMs": 695.222,
"heapDeltaBytes": 14136456,
"heapUsedBytes": 63757388,
"domNodes": 59,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 99.23499999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8226.903999999991,
"styleRecalcs": 248,
"styleRecalcDurationMs": 54.397999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4406.376,
"heapDeltaBytes": 20805704,
"heapUsedBytes": 79289156,
"domNodes": -267,
"jsHeapTotalBytes": 4431872,
"scriptDurationMs": 1478.8860000000002,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8199.977999999988,
"styleRecalcs": 252,
"styleRecalcDurationMs": 55.917,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4014.138,
"heapDeltaBytes": 11876936,
"heapUsedBytes": 68743804,
"domNodes": -257,
"jsHeapTotalBytes": 3121152,
"scriptDurationMs": 1333.745,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8177.057999999988,
"styleRecalcs": 250,
"styleRecalcDurationMs": 54.567,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3845.3239999999996,
"heapDeltaBytes": 10328408,
"heapUsedBytes": 68610440,
"domNodes": -262,
"jsHeapTotalBytes": 7053312,
"scriptDurationMs": 1291.105,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12965.94300000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12943.163,
"heapDeltaBytes": -29992904,
"heapUsedBytes": 180819996,
"domNodes": -8334,
"jsHeapTotalBytes": 25227264,
"scriptDurationMs": 676.03,
"eventListeners": -16460,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12961.88799999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12939.388,
"heapDeltaBytes": -41891920,
"heapUsedBytes": 166262788,
"domNodes": -8331,
"jsHeapTotalBytes": -17502208,
"scriptDurationMs": 667.735,
"eventListeners": -16462,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12465.598,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12455.224000000002,
"heapDeltaBytes": -35324180,
"heapUsedBytes": 171293804,
"domNodes": -8331,
"jsHeapTotalBytes": 23916544,
"scriptDurationMs": 606.5749999999999,
"eventListeners": -16462,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 14869.715999999982,
"styleRecalcs": 69,
"styleRecalcDurationMs": 18.233999999999973,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14835.665,
"heapDeltaBytes": -29788476,
"heapUsedBytes": 165477164,
"domNodes": -8331,
"jsHeapTotalBytes": -3608576,
"scriptDurationMs": 920.159,
"eventListeners": -16460,
"totalBlockingTimeMs": 2,
"frameDurationMs": 17.22666666666664,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14568.338999999924,
"styleRecalcs": 67,
"styleRecalcDurationMs": 17.115000000000048,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14525.297999999999,
"heapDeltaBytes": -59331336,
"heapUsedBytes": 154322872,
"domNodes": -8331,
"jsHeapTotalBytes": -4919296,
"scriptDurationMs": 944.498,
"eventListeners": -16488,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15159.717,
"styleRecalcs": 72,
"styleRecalcDurationMs": 19.652999999999977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15136.635000000002,
"heapDeltaBytes": -46839104,
"heapUsedBytes": 153502840,
"domNodes": -8331,
"jsHeapTotalBytes": -3870720,
"scriptDurationMs": 937.1160000000001,
"eventListeners": -16488,
"totalBlockingTimeMs": 15,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 472.0079999999598,
"styleRecalcs": 17,
"styleRecalcDurationMs": 25.794999999999998,
"layouts": 5,
"layoutDurationMs": 1.605,
"taskDurationMs": 134.885,
"heapDeltaBytes": 5275944,
"heapUsedBytes": 55128548,
"domNodes": 165,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 26.778,
"eventListeners": 69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 468.78400000002785,
"styleRecalcs": 16,
"styleRecalcDurationMs": 23.666000000000004,
"layouts": 5,
"layoutDurationMs": 1.299,
"taskDurationMs": 135.238,
"heapDeltaBytes": 5173212,
"heapUsedBytes": 54870816,
"domNodes": 156,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 30.178000000000004,
"eventListeners": 69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 126.19200000006003,
"styleRecalcs": 13,
"styleRecalcDurationMs": 18.235,
"layouts": 4,
"layoutDurationMs": 1.223,
"taskDurationMs": 93.75800000000001,
"heapDeltaBytes": 3459268,
"heapUsedBytes": 53493440,
"domNodes": 146,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 22.541999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/lib/litegraph/src/subgraph/SubgraphNode.ts`:
- Around line 1575-1604: SubgraphNode.serialize is currently mutating the shared
subgraph definition and dropping existing per-instance persisted data named
widgets_values; add a temporary compatibility shim that, if
this.properties.widgets_values exists, reads and merges those per-instance
values into the serialized output (or into this.properties.proxyWidgets) instead
of overwriting or mutating the shared subgraph definition, and avoid calling
getConnectedWidgets().value assignment directly on subgraph-definition widget
objects during serialize — operate on a shallow copy or the instance-level proxy
so only the instance's serialized data is updated; use symbols
SubgraphNode.serialize, this.properties.widgets_values,
this.properties.proxyWidgets, and usePromotionStore().getPromotions to implement
the shim and retain widgets_values in the serialized payload until the migration
fully replaces it.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 97e30995-a75d-42c2-bd5b-7ec1fabd5d0b
📒 Files selected for processing (8)
browser_tests/assets/subgraphs/subgraph-multi-instance-promoted-text-values.jsonbrowser_tests/tests/subgraph/subgraphSerialization.spec.tssrc/core/graph/subgraph/promotedWidgetTypes.tssrc/core/graph/subgraph/promotedWidgetView.tssrc/core/graph/subgraph/subgraphNodePromotion.test.tssrc/lib/litegraph/src/subgraph/ExecutableNodeDTO.tssrc/lib/litegraph/src/subgraph/SubgraphNode.multiInstance.test.tssrc/lib/litegraph/src/subgraph/SubgraphNode.ts
💤 Files with no reviewable changes (4)
- src/core/graph/subgraph/promotedWidgetTypes.ts
- browser_tests/tests/subgraph/subgraphSerialization.spec.ts
- src/lib/litegraph/src/subgraph/SubgraphNode.multiInstance.test.ts
- browser_tests/assets/subgraphs/subgraph-multi-instance-promoted-text-values.json
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #11790 +/- ##
===========================================
- Coverage 71.18% 54.85% -16.33%
===========================================
Files 1486 1377 -109
Lines 83430 70307 -13123
Branches 22066 18660 -3406
===========================================
- Hits 59386 38565 -20821
- Misses 23164 31196 +8032
+ Partials 880 546 -334
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 993 files with indirect coverage changes 🚀 New features to boost your workflow:
|
benceruleanlu
left a comment
There was a problem hiding this comment.
Looks like a clean double revert to me
|
1 similar comment
|
|
|
… promoted widget values) (#11790) (#12098) *PR Created by the Glary-Bot Agent* --- ## Summary Backport of #11790 onto `cloud/1.43`. Reverts #10849 (per-instance promoted widget value storage) and its companion test-pinning PR #11697. **Why this is needed on `cloud/1.43`:** Glary-Bot's consolidated backport (#11926) cherry-picked #10849 into `cloud/1.43` on May 5 — four days *after* the same change was reverted on `main` in #11790. The audit didn't surface the upstream revert. As a result, `cloud/1.43` (1.43.16) currently ships the buggy #10849 implementation while `main` / nightly (1.45.1) doesn't. This is the cause of the Hub `rob_realistic_2k_images_quick_variations` model/vae/clip mixup regression reported in `#bug-dump`; the same template renders correctly on nightly. After this lands, `cloud/1.43` and `main` will be on the same code path for promoted-widget serialization. The replacement fix (#11811 with `_pendingWidgetsValuesReplay`) will land separately on `main` and can be backported afterward. ## Changes Mirrors the upstream revert of #10849 + #11697: - Removes `_instanceWidgetValues` map, `_pendingWidgetsValues` hydration, and the `widgets_values` write path in `SubgraphNode.serialize()` - Removes `sourceSerialize` field on `PromotedWidgetView` - Removes the multi-instance Vitest suite (`SubgraphNode.multiInstance.test.ts`) and the multi-instance E2E test + workflow asset ## Conflict Resolution Two conflicts surfaced (vs the original revert, which conflict-resolved against #11579 on `main`): 1. **`browser_tests/tests/subgraph/subgraphSerialization.spec.ts`** — `cloud/1.43` does not have the #11579 expanded test coverage (`Duplicate ID Remapping`, `Legacy Prefixed proxyWidget Normalization`) that the original revert preserved. Took the `cloud/1.43` HEAD structure and removed only the now-unreachable multi-instance test, its helper `getPromotedHostWidgetValues`, and the unused `ComfyPage` import. 2. **`src/lib/litegraph/src/subgraph/SubgraphNode.multiInstance.test.ts`** — `modify/delete` (file was present on `cloud/1.43`'s #10849 backport, deleted by the revert). Resolved by removing the file, matching the revert. ## Verification **Static analysis & tests:** - `pnpm typecheck` — clean - `pnpm typecheck:browser` — clean - `pnpm exec eslint` on all changed files — clean - `pnpm test:unit -- --run subgraph` — 506 tests passing across 34 suites (`SubgraphNode.test.ts`, `promotedWidgetView.test.ts`, `subgraphNodePromotion.test.ts`, etc.) **Manual verification (Playwright + local dev server):** - Started ComfyUI backend (`--cpu --port 8188`) and `pnpm dev` frontend; loaded the page successfully. - Loaded `subgraph-with-multiple-promoted-widgets.json` — subgraph node hydrated with 2 promoted widgets. - Set distinct values on each promoted widget (`first-promoted-value`, `second-promoted-value`), serialized via `app.graph.serialize()`, and reloaded via `app.loadGraphData(...)`. Both values round-tripped correctly to the right widget slots — confirming the revert restores the working single-instance path that nightly currently ships. - Hub-fetched template (`rob_realistic_2k_images_quick_variations`) could not be reproduced locally — `comfy.org/workflows/...` API returns 404 to anonymous curl from the sandbox, and the Hub UI flow needs auth wired up. The team has already confirmed this template renders correctly on nightly, which ships this same revert. ## Note on Oracle Review Oracle flagged the multi-instance regression and the cloud/1.43 forward-compat trade-off as "critical." These describe the *intended* behavior of this revert — the team has consciously chosen the legacy clobber path over #10849's broken per-instance code while the replacement (#11811) is finalized on `main`. Both findings are accepted trade-offs, not blockers. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-12098-backport-cloud-1-43-revert-roll-back-10849-11697-per-instance-promoted-widget-va-35b6d73d36508109a715fc9d3428a294) by [Unito](https://www.unito.io) Co-authored-by: Alexander Brown <drjkl@comfy.org>
|
|
…s) (#11790) ## Summary Reverts #10849 (per-instance promoted widget value storage) and its companion test-pinning PR #11697. The fix in #10849 caused regressions in promoted-widget serialization (notably the Z-Image-Turbo template, see #10146 follow-up). A replacement fix is being developed on `fix/subgraph-promoted-widget-inline-state` and will land separately. ## Changes - **Revert #11697** — drops the `it.fails`-marked tests that pin the #10849 corruption symptom. With #10849 reverted, those markers would falsely flip to passing. - **Revert #10849** — removes per-instance `_instanceWidgetValues` map, `_pendingWidgetsValues` configure-time hydration, the `widgets_values` write path in `SubgraphNode.serialize()`, the `sourceSerialize` field on `PromotedWidgetView`, the multi-instance Vitest suite, and the multi-instance E2E test + asset. - **Conflict resolution** in `browser_tests/tests/subgraph/subgraphSerialization.spec.ts`: kept the restored test coverage from #11579 (which is post-#10849 on main) and removed only the now-unreachable multi-instance test, its helper, and its workflow constant. Auto-merge with #11698 (`incrementVersion`) and #11699 (ID type aliases) was clean. ## Review Focus - Confirm no other on-main code path has come to depend on `PromotedWidgetView.sourceSerialize` or `SubgraphNode._instanceWidgetValues` since #10849 (grep is clean locally). - Confirm we want to land this revert before the replacement fix on `fix/subgraph-promoted-widget-inline-state` is ready — this leaves the original #10146 (multi-instance widget value collision) unfixed in the meantime. - The retained #11579 test coverage now exercises pre-#10849 behavior; some of those assertions were written expecting the #10849 code path. CI will surface any that need adjustment. ┆Issue is synchronized with this [Notion page](https://app.notion.com/p/PR-11790-revert-roll-back-10849-11697-per-instance-promoted-widget-values-3536d73d3650814094abd58b6b712d8d) by [Unito](https://www.unito.io)
Summary
Reverts #10849 (per-instance promoted widget value storage) and its companion test-pinning PR #11697. The fix in #10849 caused regressions in promoted-widget serialization (notably the Z-Image-Turbo template, see #10146 follow-up). A replacement fix is being developed on
fix/subgraph-promoted-widget-inline-stateand will land separately.Changes
it.fails-marked tests that pin the fix: store promoted widget values per SubgraphNode instance #10849 corruption symptom. With fix: store promoted widget values per SubgraphNode instance #10849 reverted, those markers would falsely flip to passing._instanceWidgetValuesmap,_pendingWidgetsValuesconfigure-time hydration, thewidgets_valueswrite path inSubgraphNode.serialize(), thesourceSerializefield onPromotedWidgetView, the multi-instance Vitest suite, and the multi-instance E2E test + asset.browser_tests/tests/subgraph/subgraphSerialization.spec.ts: kept the restored test coverage from test: restore deleted subgraph serialization E2E tests #11579 (which is post-fix: store promoted widget values per SubgraphNode instance #10849 on main) and removed only the now-unreachable multi-instance test, its helper, and its workflow constant. Auto-merge with refactor(litegraph): centralize _version counter via incrementVersion() #11698 (incrementVersion) and feat: ECS Phase 0b — ID type aliases (FE-166/475/476/477) #11699 (ID type aliases) was clean.Review Focus
PromotedWidgetView.sourceSerializeorSubgraphNode._instanceWidgetValuessince fix: store promoted widget values per SubgraphNode instance #10849 (grep is clean locally).fix/subgraph-promoted-widget-inline-stateis ready — this leaves the original [Regression] Loading a workflow from an image sets incorrect subgraph parameters #10146 (multi-instance widget value collision) unfixed in the meantime.┆Issue is synchronized with this Notion page by Unito