Repository navigation
test: stabilize flaky Playwright tests - #10817
Conversation
🎨 Storybook: ✅ Built — View Storybook |
📦 Bundle: 5.12 MB gzip 🟢 -217 BDetailsSummary
Category Glance App Entry Points — 22.3 kB (baseline 22.3 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.2 MB (baseline 1.2 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 76.6 kB (baseline 76.6 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 2 unchanged Panels & Settings — 484 kB (baseline 484 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 12 unchanged User & Accounts — 17.1 kB (baseline 17.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed / 2 unchanged Editors & Dialogs — 109 kB (baseline 109 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 60.3 kB (baseline 60.3 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 8 unchanged Data & Services — 2.97 MB (baseline 2.97 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 338 kB (baseline 338 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 13 added / 13 removed / 13 unchanged Vendor & Third-Party — 9.8 MB (baseline 9.8 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 8.53 MB (baseline 8.53 MB) • ⚪ 0 BBundles that do not match a named category
Status: 55 added / 55 removed / 79 unchanged ⚡ Performance Report
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-04-08T02:17:20.908Z",
"gitSha": "2e5f30fc1d34c2d69ffa01c7eb1de7983808151a",
"branch": "drjkl/test/the-active-ingredient-is-selenium",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2019.8700000000258,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.849,
"heapDeltaBytes": 20388316,
"heapUsedBytes": 63205540,
"domNodes": 21,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 28.535000000000004,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2033.128999999974,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.712,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.20199999999994,
"heapDeltaBytes": 19988104,
"heapUsedBytes": 63197944,
"domNodes": 16,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 29.709,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2042.8630000000112,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.694,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.75600000000003,
"heapDeltaBytes": 20304272,
"heapUsedBytes": 63200000,
"domNodes": 22,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 29.110999999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2021.6929999999707,
"styleRecalcs": 79,
"styleRecalcDurationMs": 43.803999999999995,
"layouts": 12,
"layoutDurationMs": 3.6740000000000004,
"taskDurationMs": 1001.508,
"heapDeltaBytes": 15746292,
"heapUsedBytes": 58835752,
"domNodes": 62,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 131.773,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2118.50800000002,
"styleRecalcs": 83,
"styleRecalcDurationMs": 57.431999999999995,
"layouts": 12,
"layoutDurationMs": 3.88,
"taskDurationMs": 1130.456,
"heapDeltaBytes": 16326644,
"heapUsedBytes": 58872168,
"domNodes": 67,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 146.855,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2024.9820000000227,
"styleRecalcs": 84,
"styleRecalcDurationMs": 45.418,
"layouts": 12,
"layoutDurationMs": 3.5179999999999993,
"taskDurationMs": 1006.0469999999999,
"heapDeltaBytes": 16034744,
"heapUsedBytes": 58824236,
"domNodes": 66,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 134.4,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.7059999999788,
"styleRecalcs": 30,
"styleRecalcDurationMs": 18.435000000000002,
"layouts": 6,
"layoutDurationMs": 0.709,
"taskDurationMs": 330.884,
"heapDeltaBytes": 24686652,
"heapUsedBytes": 67594796,
"domNodes": 79,
"jsHeapTotalBytes": 20447232,
"scriptDurationMs": 30.798000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1746.1069999999381,
"styleRecalcs": 30,
"styleRecalcDurationMs": 20.5,
"layouts": 6,
"layoutDurationMs": 0.8219999999999998,
"taskDurationMs": 387.01800000000003,
"heapDeltaBytes": 24741432,
"heapUsedBytes": 67460764,
"domNodes": 77,
"jsHeapTotalBytes": 20709376,
"scriptDurationMs": 34.959,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1729.4370000000754,
"styleRecalcs": 34,
"styleRecalcDurationMs": 20.368,
"layouts": 6,
"layoutDurationMs": 0.702,
"taskDurationMs": 355.234,
"heapDeltaBytes": 24598532,
"heapUsedBytes": 67539948,
"domNodes": 81,
"jsHeapTotalBytes": 20709376,
"scriptDurationMs": 26.857,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 682.12699999998,
"styleRecalcs": 12,
"styleRecalcDurationMs": 15.582999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.45700000000005,
"heapDeltaBytes": 5853640,
"heapUsedBytes": 49088060,
"domNodes": 19,
"jsHeapTotalBytes": 13893632,
"scriptDurationMs": 66.404,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 644.5630000000051,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.286,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.01199999999994,
"heapDeltaBytes": 6844932,
"heapUsedBytes": 50724012,
"domNodes": 22,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 74.075,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 608.5170000000062,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.870000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 371.637,
"heapDeltaBytes": 6780060,
"heapUsedBytes": 49362660,
"domNodes": 22,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 66.858,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2045.94400000002,
"styleRecalcs": 11,
"styleRecalcDurationMs": 12.529000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 633.8199999999999,
"heapDeltaBytes": 4056960,
"heapUsedBytes": 54405752,
"domNodes": -259,
"jsHeapTotalBytes": 16183296,
"scriptDurationMs": 107.69099999999997,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2099.5609999999942,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.552,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 789.207,
"heapDeltaBytes": 5707644,
"heapUsedBytes": 56236808,
"domNodes": -257,
"jsHeapTotalBytes": 16445440,
"scriptDurationMs": 130.89600000000002,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2130.991999999992,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.522000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 796.9449999999999,
"heapDeltaBytes": 5018508,
"heapUsedBytes": 55756008,
"domNodes": -258,
"jsHeapTotalBytes": 16183296,
"scriptDurationMs": 149.47299999999998,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2163.2169999999746,
"styleRecalcs": 70,
"styleRecalcDurationMs": 19.166,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1237.13,
"heapDeltaBytes": 20714784,
"heapUsedBytes": 72632708,
"domNodes": -257,
"jsHeapTotalBytes": 19795968,
"scriptDurationMs": 444.317,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2195.869000000016,
"styleRecalcs": 70,
"styleRecalcDurationMs": 19.563000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1258.93,
"heapDeltaBytes": 17062920,
"heapUsedBytes": 69016212,
"domNodes": -258,
"jsHeapTotalBytes": 17514496,
"scriptDurationMs": 442.913,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2136.816999999951,
"styleRecalcs": 68,
"styleRecalcDurationMs": 16.532999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1129.4550000000002,
"heapDeltaBytes": 19524684,
"heapUsedBytes": 73014664,
"domNodes": -263,
"jsHeapTotalBytes": 17436672,
"scriptDurationMs": 381.224,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3192.9339999999797,
"styleRecalcs": 66,
"styleRecalcDurationMs": 19.342000000000002,
"layouts": 60,
"layoutDurationMs": 8.622000000000002,
"taskDurationMs": 1450.137,
"heapDeltaBytes": 5156436,
"heapUsedBytes": 59951400,
"domNodes": -264,
"jsHeapTotalBytes": 17494016,
"scriptDurationMs": 546.6039999999999,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3493.0029999999874,
"styleRecalcs": 67,
"styleRecalcDurationMs": 20.42,
"layouts": 60,
"layoutDurationMs": 8.945000000000002,
"taskDurationMs": 1603.8830000000003,
"heapDeltaBytes": 12510848,
"heapUsedBytes": 66991304,
"domNodes": -265,
"jsHeapTotalBytes": 15396864,
"scriptDurationMs": 582.818,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3196.8469999999343,
"styleRecalcs": 65,
"styleRecalcDurationMs": 18.615999999999996,
"layouts": 60,
"layoutDurationMs": 8.602,
"taskDurationMs": 1377.282,
"heapDeltaBytes": 10134392,
"heapUsedBytes": 66463560,
"domNodes": -265,
"jsHeapTotalBytes": 16502784,
"scriptDurationMs": 509.104,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2037.0549999999525,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.054000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 676.4810000000001,
"heapDeltaBytes": 2740348,
"heapUsedBytes": 56871164,
"domNodes": -262,
"jsHeapTotalBytes": 16445440,
"scriptDurationMs": 109.35899999999998,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2038.4229999999661,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.772999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 733.721,
"heapDeltaBytes": 3080680,
"heapUsedBytes": 55531204,
"domNodes": -260,
"jsHeapTotalBytes": 15659008,
"scriptDurationMs": 118.78099999999999,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2023.4769999999571,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.296,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 677.604,
"heapDeltaBytes": 4038416,
"heapUsedBytes": 56547548,
"domNodes": -262,
"jsHeapTotalBytes": 16969728,
"scriptDurationMs": 110.451,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 605.3499999999872,
"styleRecalcs": 49,
"styleRecalcDurationMs": 16.177999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.769,
"heapDeltaBytes": 6435064,
"heapUsedBytes": 49721224,
"domNodes": 23,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 141.437,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 587.3149999999896,
"styleRecalcs": 47,
"styleRecalcDurationMs": 13.108000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.71900000000005,
"heapDeltaBytes": 6135992,
"heapUsedBytes": 49307384,
"domNodes": 20,
"jsHeapTotalBytes": 13893632,
"scriptDurationMs": 136.565,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 593.7320000000454,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.315,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 379.437,
"heapDeltaBytes": 6514808,
"heapUsedBytes": 49590416,
"domNodes": 21,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 134.369,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2018.1049999999914,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.423,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.713,
"heapDeltaBytes": 19940628,
"heapUsedBytes": 63034244,
"domNodes": 21,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 24.171,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2039.0949999999748,
"styleRecalcs": 10,
"styleRecalcDurationMs": 13.159999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.267,
"heapDeltaBytes": 19971128,
"heapUsedBytes": 63145212,
"domNodes": 20,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 27.529999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1997.13799999995,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.829999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.358,
"heapDeltaBytes": 19879640,
"heapUsedBytes": 63076080,
"domNodes": 22,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 20.049,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2007.8490000000215,
"styleRecalcs": 88,
"styleRecalcDurationMs": 54.644,
"layouts": 16,
"layoutDurationMs": 4.82,
"taskDurationMs": 971.581,
"heapDeltaBytes": 11852600,
"heapUsedBytes": 55004952,
"domNodes": 73,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 108.072,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1729.024000000038,
"styleRecalcs": 76,
"styleRecalcDurationMs": 42.426,
"layouts": 16,
"layoutDurationMs": 5.23,
"taskDurationMs": 777.876,
"heapDeltaBytes": 11874952,
"heapUsedBytes": 54977392,
"domNodes": 62,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 114.13000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2023.0980000000045,
"styleRecalcs": 84,
"styleRecalcDurationMs": 49.45000000000001,
"layouts": 16,
"layoutDurationMs": 4.8549999999999995,
"taskDurationMs": 968.29,
"heapDeltaBytes": 12322612,
"heapUsedBytes": 55047772,
"domNodes": 74,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 108.69399999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8279.629,
"styleRecalcs": 252,
"styleRecalcDurationMs": 52.784000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4036.6710000000003,
"heapDeltaBytes": 18046572,
"heapUsedBytes": 68754036,
"domNodes": -257,
"jsHeapTotalBytes": 20058112,
"scriptDurationMs": 1290.322,
"eventListeners": -109,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8383.289999999988,
"styleRecalcs": 252,
"styleRecalcDurationMs": 55.834,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4473.1269999999995,
"heapDeltaBytes": 27795848,
"heapUsedBytes": 78563508,
"domNodes": -255,
"jsHeapTotalBytes": 23728128,
"scriptDurationMs": 1525.695,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8184.847999999988,
"styleRecalcs": 249,
"styleRecalcDurationMs": 47.73500000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3842.46,
"heapDeltaBytes": 26445908,
"heapUsedBytes": 79109768,
"domNodes": -263,
"jsHeapTotalBytes": 18485248,
"scriptDurationMs": 1204.1760000000002,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13160.685999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13144.477,
"heapDeltaBytes": -28783692,
"heapUsedBytes": 164720180,
"domNodes": -8331,
"jsHeapTotalBytes": 25255936,
"scriptDurationMs": 608.6400000000001,
"eventListeners": -16462,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13623.30899999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13607.183000000003,
"heapDeltaBytes": -29429640,
"heapUsedBytes": 165326292,
"domNodes": -8331,
"jsHeapTotalBytes": 24207360,
"scriptDurationMs": 649.292,
"eventListeners": -16462,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 13238.5230000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13223.763,
"heapDeltaBytes": -28827024,
"heapUsedBytes": 165239632,
"domNodes": -8331,
"jsHeapTotalBytes": 26042368,
"scriptDurationMs": 603.0070000000001,
"eventListeners": -16460,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 15557.537000000026,
"styleRecalcs": 76,
"styleRecalcDurationMs": 17.356000000000037,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15531.789,
"heapDeltaBytes": -40208404,
"heapUsedBytes": 154332180,
"domNodes": -8331,
"jsHeapTotalBytes": -1744896,
"scriptDurationMs": 856.4879999999999,
"eventListeners": -16486,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 16029.885000000035,
"styleRecalcs": 84,
"styleRecalcDurationMs": 22.035000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15992.013,
"heapDeltaBytes": -24159704,
"heapUsedBytes": 171516540,
"domNodes": -8331,
"jsHeapTotalBytes": -19656704,
"scriptDurationMs": 945.9179999999999,
"eventListeners": -16454,
"totalBlockingTimeMs": 164,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 15654.47800000004,
"styleRecalcs": 83,
"styleRecalcDurationMs": 20.714999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15632.346000000001,
"heapDeltaBytes": -11956212,
"heapUsedBytes": 181799272,
"domNodes": -8331,
"jsHeapTotalBytes": 19927040,
"scriptDurationMs": 912.385,
"eventListeners": -16458,
"totalBlockingTimeMs": 72,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 465.7229999999686,
"styleRecalcs": 21,
"styleRecalcDurationMs": 34.32,
"layouts": 5,
"layoutDurationMs": 1.7699999999999998,
"taskDurationMs": 149.859,
"heapDeltaBytes": 4726976,
"heapUsedBytes": 49628572,
"domNodes": 171,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.53900000000001,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 458.1359999999677,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.866999999999997,
"layouts": 5,
"layoutDurationMs": 1.5599999999999998,
"taskDurationMs": 140.015,
"heapDeltaBytes": 4511964,
"heapUsedBytes": 48272876,
"domNodes": 158,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 32.42399999999999,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 460.38900000007743,
"styleRecalcs": 17,
"styleRecalcDurationMs": 24.978,
"layouts": 5,
"layoutDurationMs": 1.5470000000000002,
"taskDurationMs": 128.916,
"heapDeltaBytes": 4500176,
"heapUsedBytes": 49770416,
"domNodes": 157,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.864999999999995,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
📝 WalkthroughWalkthroughTests and helpers changed to use retrying/polling assertions and explicit visibility/synchronization; one test reads a rendered canvas position at runtime instead of a hardcoded midpoint; drag-and-drop waits for upload; Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 994 passed, 0 failed📊 Browser Reports
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
browser_tests/tests/vueNodes/interactions/node/contextMenu.spec.ts (1)
225-228: Use a preview-specific readiness wait instead of a generic node image selector.Line 226 waits on the first
[data-node-id] img, which can resolve to a non-preview image and still leave image actions flaky. Please target the actual preview image and poll until it has a usablesrc.Proposed change
- await comfyPage.page - .locator('[data-node-id] img') - .first() - .waitFor({ state: 'visible' }) + const imagePreview = comfyPage.page.locator('.image-preview img').first() + await expect(imagePreview).toBeVisible() + await expect.poll(async () => imagePreview.getAttribute('src')).toBeTruthy()As per coding guidelines: “Follow Playwright best practices as documented in
@docs/guidance/playwright.md.”🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/vueNodes/interactions/node/contextMenu.spec.ts` around lines 225 - 228, The current wait uses comfyPage.page.locator('[data-node-id] img').first().waitFor(...) which can match non-preview images; change it to target the actual preview image locator (e.g., the preview image element inside the node preview) and poll its src until it's a usable value rather than just visible. Replace the generic selector with the preview-specific selector used elsewhere in the test suite (use the preview image locator) and loop/await until locator.getAttribute('src') returns a non-empty/valid URL (not a placeholder like data:), using Playwright polling (e.g., waitForFunction or repeated getAttribute checks) instead of first().waitFor to ensure the preview image is ready before proceeding.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@browser_tests/tests/vueNodes/interactions/node/contextMenu.spec.ts`:
- Around line 225-228: The current wait uses
comfyPage.page.locator('[data-node-id] img').first().waitFor(...) which can
match non-preview images; change it to target the actual preview image locator
(e.g., the preview image element inside the node preview) and poll its src until
it's a usable value rather than just visible. Replace the generic selector with
the preview-specific selector used elsewhere in the test suite (use the preview
image locator) and loop/await until locator.getAttribute('src') returns a
non-empty/valid URL (not a placeholder like data:), using Playwright polling
(e.g., waitForFunction or repeated getAttribute checks) instead of
first().waitFor to ensure the preview image is ready before proceeding.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 0376b44f-0ac8-4c77-9e84-0d159ead9e34
📒 Files selected for processing (8)
browser_tests/helpers/builderTestUtils.tsbrowser_tests/tests/changeTracker.spec.tsbrowser_tests/tests/rerouteNode.spec.tsbrowser_tests/tests/subgraph/subgraphPromotion.spec.tsbrowser_tests/tests/subgraph/subgraphPromotionDom.spec.tsbrowser_tests/tests/vueNodes/interactions/node/contextMenu.spec.tsbrowser_tests/tests/widget.spec.tsbrowser_tests/tests/zoomControls.spec.ts
Amp-Thread-ID: https://ampcode.com/threads/T-019d4c4c-4dbc-7120-9f90-f03f19d78a63 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019d4c4c-4dbc-7120-9f90-f03f19d78a63 Co-authored-by: Amp <amp@ampcode.com>
- proxyWidgets stale-read (3 tests): wrap assertions in toPass()/expect.poll() - changeTracker undo race: use expect.poll() for async undo assertions - rerouteNode timeout: replace hardcoded 8px click target with dynamic renderedPaths lookup - contextMenu image timeout: wait for img visible before interacting - widget animated webp: add waitForUpload: true to drag-and-drop - zoomControls input race: use fill() instead of pressSequentially Amp-Thread-ID: https://ampcode.com/threads/T-019d4c4c-4dbc-7120-9f90-f03f19d78a63 Co-authored-by: Amp <amp@ampcode.com>
751df14 to
636e035
Compare
Amp-Thread-ID: https://ampcode.com/threads/T-019d692a-5d74-708a-89a1-0d5605d601fe Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019d6958-61c6-775c-946d-c36522c258e9 Co-authored-by: Amp <amp@ampcode.com>
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
browser_tests/tests/nodeHelp.spec.ts (1)
337-347:⚠️ Potential issue | 🟠 MajorAvoid silent pass when the help button is missing
This branch lets the test pass without any assertion when
info-buttonis not visible, which can hide regressions in the custom-node help flow.✅ Suggested fix
- const helpButton = comfyPage.selectionToolbox.getByTestId('info-button') - if (await helpButton.isVisible()) { - const helpPage = await openSelectionToolboxHelp(comfyPage) - await expect(helpPage).toContainText('Custom Node Documentation') - - // Check image path for custom nodes - const image = helpPage.locator('img[alt="Custom Image"]') - await expect(image).toHaveAttribute( - 'src', - /.*\/extensions\/.*\/docs\/assets\/custom\.png/ - ) - } + const helpButton = comfyPage.selectionToolbox.getByTestId('info-button') + await expect(helpButton).toBeVisible() + const helpPage = await openSelectionToolboxHelp(comfyPage) + await expect(helpPage).toContainText('Custom Node Documentation') + + // Check image path for custom nodes + const image = helpPage.locator('img[alt="Custom Image"]') + await expect(image).toHaveAttribute( + 'src', + /.*\/extensions\/.*\/docs\/assets\/custom\.png/ + )🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/nodeHelp.spec.ts` around lines 337 - 347, The test currently silently skips assertions when helpButton.isVisible() is false; replace the conditional with an explicit assertion (e.g., expect(helpButton).toBeVisible() or throw a test failure in the else branch) so missing help button fails the test, then call openSelectionToolboxHelp(comfyPage), assert helpPage contains 'Custom Node Documentation', and assert the image locator ('img[alt="Custom Image"]') has src matching /.*\/extensions\/.*\/docs\/assets\/custom\.png/; target the symbols helpButton.isVisible(), openSelectionToolboxHelp, helpPage.locator and the image locator when making the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@browser_tests/tests/nodeHelp.spec.ts`:
- Around line 337-347: The test currently silently skips assertions when
helpButton.isVisible() is false; replace the conditional with an explicit
assertion (e.g., expect(helpButton).toBeVisible() or throw a test failure in the
else branch) so missing help button fails the test, then call
openSelectionToolboxHelp(comfyPage), assert helpPage contains 'Custom Node
Documentation', and assert the image locator ('img[alt="Custom Image"]') has src
matching /.*\/extensions\/.*\/docs\/assets\/custom\.png/; target the symbols
helpButton.isVisible(), openSelectionToolboxHelp, helpPage.locator and the image
locator when making the change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: dfb11c7e-7a94-455a-a327-98b597aad0ec
📒 Files selected for processing (4)
browser_tests/fixtures/components/ComfyNodeSearchBox.tsbrowser_tests/tests/nodeHelp.spec.tsbrowser_tests/tests/recordAudio.spec.tsbrowser_tests/tests/vueNodes/interactions/node/move.spec.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- browser_tests/tests/recordAudio.spec.ts
Amp-Thread-ID: https://ampcode.com/threads/T-019d697b-a520-719e-a6b2-833ff1417ebe Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019d69b0-92aa-708e-a4de-dcab7a321d89 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019d69d5-fea6-7722-be58-cb7c1149d36d Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019d69d5-fea6-7722-be58-cb7c1149d36d Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019d6a20-0810-735d-b374-d71bee4238f4 Co-authored-by: Amp <amp@ampcode.com>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #10817 +/- ##
=======================================
Coverage 42.88% 42.88%
=======================================
Files 1332 1332
Lines 68146 68146
Branches 17949 17949
=======================================
Hits 29226 29226
Misses 38324 38324
Partials 596 596 🚀 New features to boost your workflow:
|
Amp-Thread-ID: https://ampcode.com/threads/T-019d6a98-9edb-7780-9a19-57b97118fe01 Co-authored-by: Amp <amp@ampcode.com>
benceruleanlu
left a comment
There was a problem hiding this comment.
half a glance
my stance is just go fast here, not like we're doing a crazy fixture architectural change
| @@ -1,5 +1,6 @@ | |||
| import { expect } from '@playwright/test' | |||
|
|
|||
| import type { ComfyPage } from '../../fixtures/ComfyPage' | |||
There was a problem hiding this comment.
The only reason I didn't add a lint rule was because it's not really policy but a preference, feel free but a quick migration PR will probably do the same thing for AI agents to work off on
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
browser_tests/tests/sidebar/nodeLibrary.spec.ts (1)
223-305: Optional: extract repeated “open customize dialog + select icon + confirm” flow.The customization sequence is repeated in multiple tests; a helper would trim duplication and simplify future UI changes.
As per coding guidelines, prefer simpler implementations with smaller repeated surfaces and shorter functions where possible.♻️ Suggested refactor
+async function customizeFolder( + comfyPage: ComfyPage, + options: { chooseColor?: boolean } = {} +) { + const dialog = comfyPage.page.getByRole('dialog', { name: 'Customize Folder' }) + const iconGroup = dialog.getByText('Icon').locator('..').getByRole('group') + await iconGroup.getByRole('button').nth(1).click() + + if (options.chooseColor) { + const customColorOption = comfyPage.page.locator('.p-togglebutton-content > .pi-palette') + await customColorOption.click() + await customColorOption.click() + await dialog.getByRole('textbox').click() + await comfyPage.page.locator('.p-colorpicker-color-background').click() + } + + await dialog.getByRole('button', { name: 'Confirm' }).click() + await comfyPage.nextFrame() +}- const dialog = comfyPage.page.getByRole('dialog', { - name: 'Customize Folder' - }) - const iconGroup = dialog.getByText('Icon').locator('..').getByRole('group') - await iconGroup.getByRole('button').nth(1).click() - ... - await dialog.getByRole('button', { name: 'Confirm' }).click() - await comfyPage.nextFrame() + await customizeFolder(comfyPage, { chooseColor: true })🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/sidebar/nodeLibrary.spec.ts` around lines 223 - 305, Extract the repeated "open customize dialog + select icon + confirm" flow into a reusable helper (e.g., openCustomizeDialogAndChooseIcon) and replace duplicated sequences in tests that call comfyPage.menu.nodeLibraryTab.getFolder('foo').click(...), comfyPage.page.getByLabel('Customize').click(), locating the dialog, selecting the icon via iconGroup.getByRole('button').nth(1).click(), and clicking the Confirm button; the helper should accept parameters for folderName, iconIndex, and optional color interactions so tests like "Can customize icon", "Can customize icon (default field)" and "Can customize bookmark color after interacting with color options" call the helper instead of repeating the UI steps.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@browser_tests/tests/nodeHelp.spec.ts`:
- Around line 483-494: Remove the final cleanup call that resets locale to
English to avoid introducing an extra flaky async path: delete the finally block
invoking setLocaleAndWaitForWorkflowReload(comfyPage, 'en') in the test that
loads the 'default' workflow and asserts Japanese help text (the block that
selects a KSampler node, calls openSelectionToolboxHelp, and asserts
'KSamplerノード' and 'これは日本語のドキュメントです'). Leave the test body that loads the
workflow, selects the node (comfyPage.workflow.loadWorkflow,
comfyPage.nodeOps.getNodeRefsByType, selectNodeWithPan,
openSelectionToolboxHelp) and the assertions intact, relying on Playwright's
fresh Page per test for isolation.
---
Nitpick comments:
In `@browser_tests/tests/sidebar/nodeLibrary.spec.ts`:
- Around line 223-305: Extract the repeated "open customize dialog + select icon
+ confirm" flow into a reusable helper (e.g., openCustomizeDialogAndChooseIcon)
and replace duplicated sequences in tests that call
comfyPage.menu.nodeLibraryTab.getFolder('foo').click(...),
comfyPage.page.getByLabel('Customize').click(), locating the dialog, selecting
the icon via iconGroup.getByRole('button').nth(1).click(), and clicking the
Confirm button; the helper should accept parameters for folderName, iconIndex,
and optional color interactions so tests like "Can customize icon", "Can
customize icon (default field)" and "Can customize bookmark color after
interacting with color options" call the helper instead of repeating the UI
steps.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ba8452a5-9128-4778-a128-1744797499e1
📒 Files selected for processing (17)
browser_tests/AGENTS.mdbrowser_tests/FLAKE_PREVENTION_RULES.mdbrowser_tests/fixtures/components/ComfyNodeSearchBox.tsbrowser_tests/helpers/builderTestUtils.tsbrowser_tests/tests/copyPaste.spec.tsbrowser_tests/tests/dialogs/signInDialog.spec.tsbrowser_tests/tests/menu.spec.tsbrowser_tests/tests/nodeHelp.spec.tsbrowser_tests/tests/nodeSearchBox.spec.tsbrowser_tests/tests/recordAudio.spec.tsbrowser_tests/tests/selectionRectangle.spec.tsbrowser_tests/tests/sidebar/nodeLibrary.spec.tsbrowser_tests/tests/subgraph/subgraphPromotion.spec.tsbrowser_tests/tests/vueNodes/interactions/node/contextMenu.spec.tsbrowser_tests/tests/vueNodes/interactions/node/move.spec.tsbrowser_tests/tests/widget.spec.tsbrowser_tests/tests/workflowPersistence.spec.ts
✅ Files skipped from review due to trivial changes (4)
- browser_tests/AGENTS.md
- browser_tests/tests/dialogs/signInDialog.spec.ts
- browser_tests/tests/vueNodes/interactions/node/move.spec.ts
- browser_tests/tests/subgraph/subgraphPromotion.spec.ts
🚧 Files skipped from review as they are similar to previous changes (3)
- browser_tests/tests/recordAudio.spec.ts
- browser_tests/tests/vueNodes/interactions/node/contextMenu.spec.ts
- browser_tests/helpers/builderTestUtils.ts
| try { | ||
| await comfyPage.workflow.loadWorkflow('default') | ||
| const ksamplerNodes = | ||
| await comfyPage.nodeOps.getNodeRefsByType('KSampler') | ||
| await selectNodeWithPan(comfyPage, ksamplerNodes[0]) | ||
|
|
||
| const helpPage = await openSelectionToolboxHelp(comfyPage) | ||
| await expect(helpPage).toContainText('KSamplerノード') | ||
| await expect(helpPage).toContainText('これは日本語のドキュメントです') | ||
| } finally { | ||
| await setLocaleAndWaitForWorkflowReload(comfyPage, 'en') | ||
| } |
There was a problem hiding this comment.
Skip the locale reset cleanup.
If the Japanese-doc assertions pass but the cleanup reload hangs, this test still fails for the wrong reason. The extra reset does not improve isolation here and just adds another flaky async path.
✂️ Proposed simplification
- try {
- await comfyPage.workflow.loadWorkflow('default')
- const ksamplerNodes =
- await comfyPage.nodeOps.getNodeRefsByType('KSampler')
- await selectNodeWithPan(comfyPage, ksamplerNodes[0])
-
- const helpPage = await openSelectionToolboxHelp(comfyPage)
- await expect(helpPage).toContainText('KSamplerノード')
- await expect(helpPage).toContainText('これは日本語のドキュメントです')
- } finally {
- await setLocaleAndWaitForWorkflowReload(comfyPage, 'en')
- }
+ await comfyPage.workflow.loadWorkflow('default')
+ const ksamplerNodes =
+ await comfyPage.nodeOps.getNodeRefsByType('KSampler')
+ await selectNodeWithPan(comfyPage, ksamplerNodes[0])
+
+ const helpPage = await openSelectionToolboxHelp(comfyPage)
+ await expect(helpPage).toContainText('KSamplerノード')
+ await expect(helpPage).toContainText('これは日本語のドキュメントです')🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@browser_tests/tests/nodeHelp.spec.ts` around lines 483 - 494, Remove the
final cleanup call that resets locale to English to avoid introducing an extra
flaky async path: delete the finally block invoking
setLocaleAndWaitForWorkflowReload(comfyPage, 'en') in the test that loads the
'default' workflow and asserts Japanese help text (the block that selects a
KSampler node, calls openSelectionToolboxHelp, and asserts 'KSamplerノード' and
'これは日本語のドキュメントです'). Leave the test body that loads the workflow, selects the
node (comfyPage.workflow.loadWorkflow, comfyPage.nodeOps.getNodeRefsByType,
selectNodeWithPan, openSelectionToolboxHelp) and the assertions intact, relying
on Playwright's fresh Page per test for isolation.
Convert expect(await asyncRead()).toBe(...) to expect.poll() where a single async read follows an async UI mutation and could race. Files: copyPaste, rightClickMenu, subgraphNavigation, subgraphSlots, subgraphOperations, subgraphSerialization, select, contextMenu specs. Also convert toPass() to expect.poll() in builderTestUtils and templates helpers per AGENTS.md polling convention. Amp-Thread-ID: https://ampcode.com/threads/T-019d6abc-d307-72bb-96e9-49d4f3217afd Co-authored-by: Amp <amp@ampcode.com>
…-ingredient-is-selenium Amp-Thread-ID: https://ampcode.com/threads/T-019d6abc-d307-72bb-96e9-49d4f3217afd Co-authored-by: Amp <amp@ampcode.com> # Conflicts: # browser_tests/tests/changeTracker.spec.ts
d241e62
Convert 5 more expect(await asyncRead()).toBe(...) to expect.poll(): undo/redo queue size preconditions and toast error count after save. Amp-Thread-ID: https://ampcode.com/threads/T-019d6abc-d307-72bb-96e9-49d4f3217afd Co-authored-by: Amp <amp@ampcode.com>
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
browser_tests/tests/nodeHelp.spec.ts (1)
483-494:⚠️ Potential issue | 🟡 MinorDrop the locale reset in
finally.If the Japanese-doc assertions succeed but the cleanup reload on Line 493 stalls, this test still fails for the wrong reason. The reset does not improve isolation here and adds another async reload path back into a suite that is being deflaked.
Suggested simplification
- try { - await comfyPage.workflow.loadWorkflow('default') - const ksamplerNodes = - await comfyPage.nodeOps.getNodeRefsByType('KSampler') - await selectNodeWithPan(comfyPage, ksamplerNodes[0]) - - const helpPage = await openSelectionToolboxHelp(comfyPage) - await expect(helpPage).toContainText('KSamplerノード') - await expect(helpPage).toContainText('これは日本語のドキュメントです') - } finally { - await setLocaleAndWaitForWorkflowReload(comfyPage, 'en') - } + await comfyPage.workflow.loadWorkflow('default') + const ksamplerNodes = + await comfyPage.nodeOps.getNodeRefsByType('KSampler') + await selectNodeWithPan(comfyPage, ksamplerNodes[0]) + + const helpPage = await openSelectionToolboxHelp(comfyPage) + await expect(helpPage).toContainText('KSamplerノード') + await expect(helpPage).toContainText('これは日本語のドキュメントです')Based on learnings, Playwright creates a fresh
Pageper test in this suite, so locale state does not leak across tests.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/nodeHelp.spec.ts` around lines 483 - 494, The cleanup reset in the finally block is unnecessary and can cause spurious failures; remove the call to setLocaleAndWaitForWorkflowReload(comfyPage, 'en') (and the surrounding finally) so the test simply loads the 'default' workflow, selects the KSampler node via comfyPage.nodeOps.getNodeRefsByType and selectNodeWithPan, opens the help with openSelectionToolboxHelp, and asserts the Japanese text without performing an async locale reload in setLocaleAndWaitForWorkflowReload during teardown.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@browser_tests/tests/nodeHelp.spec.ts`:
- Around line 387-390: The test currently skips the help assertion when
comfyPage.selectionToolbox.getByTestId('info-button') is not visible, hiding
regressions; change the flow to assert the presence/visibility of the
info-button (helpButton) before proceeding (or select a specific deterministic
node that should expose help), then call openSelectionToolboxHelp(comfyPage) and
assert await expect(helpPage).toContainText('Custom Node Documentation'); ensure
you reference the helpButton (info-button),
comfyPage.selectionToolbox.getByTestId, and openSelectionToolboxHelp so the test
fails fast if help is not available.
---
Duplicate comments:
In `@browser_tests/tests/nodeHelp.spec.ts`:
- Around line 483-494: The cleanup reset in the finally block is unnecessary and
can cause spurious failures; remove the call to
setLocaleAndWaitForWorkflowReload(comfyPage, 'en') (and the surrounding finally)
so the test simply loads the 'default' workflow, selects the KSampler node via
comfyPage.nodeOps.getNodeRefsByType and selectNodeWithPan, opens the help with
openSelectionToolboxHelp, and asserts the Japanese text without performing an
async locale reload in setLocaleAndWaitForWorkflowReload during teardown.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 21299514-09a9-41b5-b66c-be7e81cba2a9
📒 Files selected for processing (25)
browser_tests/AGENTS.mdbrowser_tests/FLAKE_PREVENTION_RULES.mdbrowser_tests/fixtures/components/ComfyNodeSearchBox.tsbrowser_tests/helpers/builderTestUtils.tsbrowser_tests/helpers/templates.tsbrowser_tests/tests/changeTracker.spec.tsbrowser_tests/tests/copyPaste.spec.tsbrowser_tests/tests/dialogs/signInDialog.spec.tsbrowser_tests/tests/menu.spec.tsbrowser_tests/tests/nodeHelp.spec.tsbrowser_tests/tests/nodeSearchBox.spec.tsbrowser_tests/tests/recordAudio.spec.tsbrowser_tests/tests/rightClickMenu.spec.tsbrowser_tests/tests/selectionRectangle.spec.tsbrowser_tests/tests/sidebar/nodeLibrary.spec.tsbrowser_tests/tests/subgraph/subgraphNavigation.spec.tsbrowser_tests/tests/subgraph/subgraphOperations.spec.tsbrowser_tests/tests/subgraph/subgraphPromotion.spec.tsbrowser_tests/tests/subgraph/subgraphSerialization.spec.tsbrowser_tests/tests/subgraph/subgraphSlots.spec.tsbrowser_tests/tests/vueNodes/interactions/node/contextMenu.spec.tsbrowser_tests/tests/vueNodes/interactions/node/move.spec.tsbrowser_tests/tests/vueNodes/interactions/node/select.spec.tsbrowser_tests/tests/widget.spec.tsbrowser_tests/tests/workflowPersistence.spec.ts
✅ Files skipped from review due to trivial changes (3)
- browser_tests/tests/dialogs/signInDialog.spec.ts
- browser_tests/AGENTS.md
- browser_tests/tests/changeTracker.spec.ts
🚧 Files skipped from review as they are similar to previous changes (4)
- browser_tests/tests/recordAudio.spec.ts
- browser_tests/helpers/builderTestUtils.ts
- browser_tests/tests/widget.spec.ts
- browser_tests/tests/subgraph/subgraphPromotion.spec.ts
| const helpButton = comfyPage.selectionToolbox.getByTestId('info-button') | ||
| if (await helpButton.isVisible()) { | ||
| await helpButton.click() | ||
|
|
||
| const helpPage = comfyPage.page.locator( | ||
| '[data-testid="properties-panel"]' | ||
| ) | ||
| const helpPage = await openSelectionToolboxHelp(comfyPage) | ||
| await expect(helpPage).toContainText('Custom Node Documentation') |
There was a problem hiding this comment.
Don’t let this test pass without opening Help.
Line 388 turns the core assertion path into a no-op when the info-button never appears, so a regression in custom-node help wiring can still report green. This should fail fast, or the test should select a deterministic node that is expected to expose help.
Suggested change
- const helpButton = comfyPage.selectionToolbox.getByTestId('info-button')
- if (await helpButton.isVisible()) {
- const helpPage = await openSelectionToolboxHelp(comfyPage)
- await expect(helpPage).toContainText('Custom Node Documentation')
-
- // Check image path for custom nodes
- const image = helpPage.locator('img[alt="Custom Image"]')
- await expect(image).toHaveAttribute(
- 'src',
- /.*\/extensions\/.*\/docs\/assets\/custom\.png/
- )
- }
+ const helpPage = await openSelectionToolboxHelp(comfyPage)
+ await expect(helpPage).toContainText('Custom Node Documentation')
+
+ // Check image path for custom nodes
+ const image = helpPage.locator('img[alt="Custom Image"]')
+ await expect(image).toHaveAttribute(
+ 'src',
+ /.*\/extensions\/.*\/docs\/assets\/custom\.png/
+ )📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const helpButton = comfyPage.selectionToolbox.getByTestId('info-button') | |
| if (await helpButton.isVisible()) { | |
| await helpButton.click() | |
| const helpPage = comfyPage.page.locator( | |
| '[data-testid="properties-panel"]' | |
| ) | |
| const helpPage = await openSelectionToolboxHelp(comfyPage) | |
| await expect(helpPage).toContainText('Custom Node Documentation') | |
| const helpPage = await openSelectionToolboxHelp(comfyPage) | |
| await expect(helpPage).toContainText('Custom Node Documentation') | |
| // Check image path for custom nodes | |
| const image = helpPage.locator('img[alt="Custom Image"]') | |
| await expect(image).toHaveAttribute( | |
| 'src', | |
| /.*\/extensions\/.*\/docs\/assets\/custom\.png/ | |
| ) |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@browser_tests/tests/nodeHelp.spec.ts` around lines 387 - 390, The test
currently skips the help assertion when
comfyPage.selectionToolbox.getByTestId('info-button') is not visible, hiding
regressions; change the flow to assert the presence/visibility of the
info-button (helpButton) before proceeding (or select a specific deterministic
node that should expose help), then call openSelectionToolboxHelp(comfyPage) and
assert await expect(helpPage).toContainText('Custom Node Documentation'); ensure
you reference the helpButton (info-button),
comfyPage.selectionToolbox.getByTestId, and openSelectionToolboxHelp so the test
fails fast if help is not available.
Stabilize flaky Playwright tests by improving test reliability. This PR aims to identify and fix flaky e2e tests. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10817-test-stabilize-flaky-Playwright-tests-3366d73d365081ada40de73ce11af625) by [Unito](https://www.unito.io) --------- Co-authored-by: Amp <amp@ampcode.com>
Stabilize flaky Playwright tests by improving test reliability.
This PR aims to identify and fix flaky e2e tests.
┆Issue is synchronized with this Notion page by Unito