Skip to content

libobs: characterize and extract hidden service type lookup (Refs #5267) - #5272

Merged
zackees merged 2 commits into
masterfrom
test/5267-find-service
Nov 19, 2026
Merged

zackees merged 2 commits into
masterfrom
test/5267-find-service

Conversation

@zackees

@zackees zackees commented Nov 19, 2026

Copy link
Copy Markdown
Member

Refs #5267.

find_service now lives in libobs/obs-service-find.c.h, with its original nine-line body preserved verbatim in the sorted O unity group. It remains hidden under its unchanged private declaration. Registry storage and lifetime stay C-owned, with the same initialized-core and valid-C-string preconditions. This unit is separate from #3840's context, state and handler accessors.

The new portable C-source characterization uses a controlled private-header registry. It covers empty tables, misses, distinct buffers with equal IDs, case/prefix mismatches, non-UTF-8 IDs, first duplicate selection, logical count versus capacity, exact borrowed pointer identity and immediate observation of entry changes. Each call preserves the entire core/table storage and allocation count and invokes no callbacks. The fixture offers an external-implementation mode for the later Rust swap; its unchanged assertions also passed with the C implementation in a separate translation unit. The tests.d pointer and sorted canonical graph register the new target, and existing inventory readers discover the extracted member through the O group.

RED commit 3b8ef0cc7 records the fixture while the extraction file is absent from that commit. Replaying the real native compile command fails on the missing libobs/obs-service-find.c.h. A byte-for-byte snapshot of the original C body then passed 25 runs per Linux library mode before production extraction. GREEN commit 1fadad4a50e2 extracts that exact body without changing selection, ownership, callbacks, synchronization or visibility.

Whole native_build:: passed all 322 tests in 72.32 seconds; twelve build-group/module/graph-order checks and the one-agent clud-review passed. Linux built EVERY one of the 66 configured *_rust targets with -k 0; the new test and unchanged service settings/getters/lifecycle suites passed three times per library mode. Export sets are identical at 1,769 symbols. The hidden lookup is not dynamically exported. The single standalone ./lint invocation stopped at one extra blank line in the service monolith; clang-format corrected it in the amended GREEN commit. Fresh ./push client-lint passed all six supported targets, including Clippy and Dylint (67.9 seconds), and the repository self-tests passed. The complete client-test proof passed (1,246.4 seconds): 9,224 host tests passed with six skips, all 920 feature tests passed, documentation checks passed or reused matching passing verdicts, and all Windows GNU workspace test links passed. Nextest reported four slow tests and one leaky test in the successful main run. Optional Swift proof was unavailable because swift-format is absent; no Swift files changed. The final signed head is GitHub-verified and preserves the tested tree and RED parent.

The Windows checker passed all eight Rust category links (623.88 seconds), then hybrid libobs and all 57 selected Rust fixtures (843.69 seconds). Its combined 1,800-second deadline interrupted the Darwin C build; the separate Darwin checker completed hybrid libobs and all 57 fixtures (731.60 seconds). The new C characterization also linked explicitly on both Windows MSVC and Darwin arm64. Final Linux binaries and all four focused suites passed again after the whitespace-only amendment.

Forced-fetch merge-tree checks used full git footprints for 18 PR heads and covered nine relevant overlaps, including #5257, #5246 and the large #4655 migration. This branch merges cleanly with current master. No new conflicting paths were introduced. #5257 and #5246 combine cleanly in the final refresh; conflicts on #5155, #4655 and #4124 are already present in the unchanged-master baseline. All temporary refs were deleted.

This is the C-only prerequisite; unit-specific Rust Tier 1 and Tier 3 differential/mutation coverage belongs to the follow-up Rust swap. Network Tier 4 does not apply. Native Windows/macOS execution, the complete cmocka suite and hosted CI/merge outcomes were not observed. No Rust code, public header, existing C test, obs-websocket, workflow or features-ledger changes are included.

)

Ci-Attestation: {"at":1795113391,"gate":"data/all/compatibility","host":"linux-x86_64","key":"","lane":"client-checks","parents":["3b8ef0cc7125992633046ef83ad93bc67d1b22ea"],"secs":320,"stamp":"9f027ec39cba03efd7e44d274d26f1d5","tree":"4e62d28d9d1b107cbd474f98809a290289a2dc90","v":1,"via":"run"}
Ci-Attestation: {"at":1795113391,"gate":"data/all/flatpak-manifest","host":"linux-x86_64","key":"","lane":"client-checks","parents":["3b8ef0cc7125992633046ef83ad93bc67d1b22ea"],"secs":320,"stamp":"cbf007518036a1710e170d0499070a69","tree":"4e62d28d9d1b107cbd474f98809a290289a2dc90","v":1,"via":"run"}
Ci-Attestation: {"at":1795113391,"gate":"data/all/qt-xml","host":"linux-x86_64","key":"","lane":"client-checks","parents":["3b8ef0cc7125992633046ef83ad93bc67d1b22ea"],"secs":320,"stamp":"e689c5051d8b2c6f163f0a8dd83261d0","tree":"4e62d28d9d1b107cbd474f98809a290289a2dc90","v":1,"via":"run"}
Ci-Attestation: {"at":1795113391,"gate":"data/all/services-schema","host":"linux-x86_64","key":"","lane":"client-checks","parents":["3b8ef0cc7125992633046ef83ad93bc67d1b22ea"],"secs":320,"stamp":"45d66341850a0378cc1a3c9c013a47de","tree":"4e62d28d9d1b107cbd474f98809a290289a2dc90","v":1,"via":"run"}
Ci-Attestation: {"at":1795113067,"gate":"general/all/client-lint","host":"linux-x86_64","key":"6a6bbe763a7019fd592c2a4e343e899a00126f2fd161880d8e35d6ac23b9d61e","lane":"client-lint","parents":["3b8ef0cc7125992633046ef83ad93bc67d1b22ea"],"secs":68,"stamp":"14eda44cc6cc11db0144651ea8f8955b","tree":"4e62d28d9d1b107cbd474f98809a290289a2dc90","v":1,"via":"run"}
Ci-Attestation: {"at":1795113391,"gate":"python/all/self-test","host":"linux-x86_64","key":"","lane":"client-checks","parents":["3b8ef0cc7125992633046ef83ad93bc67d1b22ea"],"secs":320,"stamp":"28cda4fa88436a2d68f05ac3e94e7c99","tree":"4e62d28d9d1b107cbd474f98809a290289a2dc90","v":1,"via":"run"}
Ci-Attestation: {"at":1795113068,"gate":"rust/aarch64-apple-darwin/client-clippy","host":"linux-x86_64","key":"6a6bbe763a7019fd592c2a4e343e899a00126f2fd161880d8e35d6ac23b9d61e","lane":"client-lint","parents":["3b8ef0cc7125992633046ef83ad93bc67d1b22ea"],"secs":68,"stamp":"c22b42a2003ea7f76df63a80f226b316","tree":"4e62d28d9d1b107cbd474f98809a290289a2dc90","v":1,"via":"run"}
Ci-Attestation: {"at":1795113068,"gate":"rust/aarch64-apple-darwin/client-dylint","host":"linux-x86_64","key":"6a6bbe763a7019fd592c2a4e343e899a00126f2fd161880d8e35d6ac23b9d61e","lane":"client-lint","parents":["3b8ef0cc7125992633046ef83ad93bc67d1b22ea"],"secs":68,"stamp":"a441f129c49d4cadd9248618c53ace9f","tree":"4e62d28d9d1b107cbd474f98809a290289a2dc90","v":1,"via":"run"}
Ci-Attestation: {"at":1795113068,"gate":"rust/aarch64-pc-windows-msvc/client-clippy","host":"linux-x86_64","key":"6a6bbe763a7019fd592c2a4e343e899a00126f2fd161880d8e35d6ac23b9d61e","lane":"client-lint","parents":["3b8ef0cc7125992633046ef83ad93bc67d1b22ea"],"secs":68,"stamp":"6487dfa2787833d36620458f3317a4d5","tree":"4e62d28d9d1b107cbd474f98809a290289a2dc90","v":1,"via":"run"}
Ci-Attestation: {"at":1795113068,"gate":"rust/aarch64-pc-windows-msvc/client-dylint","host":"linux-x86_64","key":"6a6bbe763a7019fd592c2a4e343e899a00126f2fd161880d8e35d6ac23b9d61e","lane":"client-lint","parents":["3b8ef0cc7125992633046ef83ad93bc67d1b22ea"],"secs":68,"stamp":"ca9c1f63432430e0aa23822e56df18b2","tree":"4e62d28d9d1b107cbd474f98809a290289a2dc90","v":1,"via":"run"}
Ci-Attestation: {"at":1795113067,"gate":"rust/aarch64-unknown-linux-gnu/client-clippy","host":"linux-x86_64","key":"6a6bbe763a7019fd592c2a4e343e899a00126f2fd161880d8e35d6ac23b9d61e","lane":"client-lint","parents":["3b8ef0cc7125992633046ef83ad93bc67d1b22ea"],"secs":68,"stamp":"c65a0e038c3a8ecd58c4269705382397","tree":"4e62d28d9d1b107cbd474f98809a290289a2dc90","v":1,"via":"run"}
Ci-Attestation: {"at":1795113067,"gate":"rust/aarch64-unknown-linux-gnu/client-dylint","host":"linux-x86_64","key":"6a6bbe763a7019fd592c2a4e343e899a00126f2fd161880d8e35d6ac23b9d61e","lane":"client-lint","parents":["3b8ef0cc7125992633046ef83ad93bc67d1b22ea"],"secs":68,"stamp":"c1f5cdfbcad2ce8231221b0ee8a6f013","tree":"4e62d28d9d1b107cbd474f98809a290289a2dc90","v":1,"via":"run"}
Ci-Attestation: {"at":1795113068,"gate":"rust/x86_64-apple-darwin/client-clippy","host":"linux-x86_64","key":"6a6bbe763a7019fd592c2a4e343e899a00126f2fd161880d8e35d6ac23b9d61e","lane":"client-lint","parents":["3b8ef0cc7125992633046ef83ad93bc67d1b22ea"],"secs":68,"stamp":"a556068be74857fe8e23a4edb60a1921","tree":"4e62d28d9d1b107cbd474f98809a290289a2dc90","v":1,"via":"run"}
Ci-Attestation: {"at":1795113068,"gate":"rust/x86_64-apple-darwin/client-dylint","host":"linux-x86_64","key":"6a6bbe763a7019fd592c2a4e343e899a00126f2fd161880d8e35d6ac23b9d61e","lane":"client-lint","parents":["3b8ef0cc7125992633046ef83ad93bc67d1b22ea"],"secs":68,"stamp":"505e331dbdd2f186cc4f34190b8051cf","tree":"4e62d28d9d1b107cbd474f98809a290289a2dc90","v":1,"via":"run"}
Ci-Attestation: {"at":1795113067,"gate":"rust/x86_64-pc-windows-msvc/client-clippy","host":"linux-x86_64","key":"6a6bbe763a7019fd592c2a4e343e899a00126f2fd161880d8e35d6ac23b9d61e","lane":"client-lint","parents":["3b8ef0cc7125992633046ef83ad93bc67d1b22ea"],"secs":68,"stamp":"160fe2cf0aaca069f78944c63dd03c28","tree":"4e62d28d9d1b107cbd474f98809a290289a2dc90","v":1,"via":"run"}
Ci-Attestation: {"at":1795113068,"gate":"rust/x86_64-pc-windows-msvc/client-dylint","host":"linux-x86_64","key":"6a6bbe763a7019fd592c2a4e343e899a00126f2fd161880d8e35d6ac23b9d61e","lane":"client-lint","parents":["3b8ef0cc7125992633046ef83ad93bc67d1b22ea"],"secs":68,"stamp":"598cbccd86ef3fa4ad66c85688716a48","tree":"4e62d28d9d1b107cbd474f98809a290289a2dc90","v":1,"via":"run"}
Ci-Attestation: {"at":1795113067,"gate":"rust/x86_64-unknown-linux-gnu/client-clippy","host":"linux-x86_64","key":"6a6bbe763a7019fd592c2a4e343e899a00126f2fd161880d8e35d6ac23b9d61e","lane":"client-lint","parents":["3b8ef0cc7125992633046ef83ad93bc67d1b22ea"],"secs":68,"stamp":"a11fb015cc22ffb9a7ed1918ec37dc86","tree":"4e62d28d9d1b107cbd474f98809a290289a2dc90","v":1,"via":"run"}
Ci-Attestation: {"at":1795113067,"gate":"rust/x86_64-unknown-linux-gnu/client-dylint","host":"linux-x86_64","key":"6a6bbe763a7019fd592c2a4e343e899a00126f2fd161880d8e35d6ac23b9d61e","lane":"client-lint","parents":["3b8ef0cc7125992633046ef83ad93bc67d1b22ea"],"secs":68,"stamp":"439cde5efd7c96f6c95eefc64f8d4c2a","tree":"4e62d28d9d1b107cbd474f98809a290289a2dc90","v":1,"via":"run"}
Ci-Attestation: {"at":1795114639,"gate":"rust/x86_64-unknown-linux-gnu/client-test","host":"linux-x86_64","key":"e8da3f468740d1671f9a158cf731ba8c2c83e326e4127aab7ae55206565b319e","lane":"client-test-x86_64-unknown-linux-gnu","parents":["3b8ef0cc7125992633046ef83ad93bc67d1b22ea"],"secs":1246,"stamp":"e9fb706090214fe900de65b4eac7345b","tree":"4e62d28d9d1b107cbd474f98809a290289a2dc90","v":1,"via":"run"}

Client-Checks: {"checks":{"base":"56689012257936de0fb59449fe30ce304bf93179","coverage":"all-tracked-applicable-files","diff":["ci/linux_qt_frontend.py","ci/test_bench_libobs_stand_ins.py","ci/test_hotkey_register_extraction.py","ci/test_linux_qt_frontend.py","libobs/build/libobs.core+.h.c","libobs/build/libobs.core-output+.h.c","libobs/build/libobs.core-source+.h.c","libobs/build/libobs.graphics+.h.c","libobs/build/libobs.ported-encoder-get-name+.h.c","libobs/build/libobs.ported-graphics-active-shader-queries+.h.c","libobs/build/libobs.ported-source-audio-pause-callbacks+.h.c","libobs/build/ported-source-sets/encoder-get-name.json","libobs/build/ported-source-sets/graphics-active-shader-queries.json","libobs/build/ported-source-sets/source-audio-pause-callbacks.json","libobs/cmake/rust-exports.d/obs-encoder-get_name.txt","libobs/cmake/rust-exports.d/obs-graphics-active_shader_queries.txt","libobs/cmake/rust-exports.d/obs-source-source_audio_pause_callbacks.txt","libobs/graphics/graphics-active-shader-queries.c.h","libobs/graphics/graphics-device-queries-fields.c.h","libobs/obs-encoder-get-name-fields.c.h","libobs/obs-hotkey-background-state.c.h","libobs/obs-hotkey.c.h","libobs/obs-output-interleave-name-fields.c.h","libobs/obs-service-find.c.h","libobs/obs-service.c.h","rust/README.md","rust/obs-build/tests/native/registration/canonical_video_info_query_is_registered.rs","rust/obs-build/tests/native/registration/headless_characterizations_expected.json","rust/obs-build/tests/native/registration/portal_output_expected.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_hotkey_background_enum.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_hotkey_background_press.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_hotkey_background_trigger.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_hotkey_binding_press_steps.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_hotkey_getters_characterization.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_hotkey_load.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_hotkey_pair_steps.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_hotkey_press_steps.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_hotkey_unregister_entry.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_portal_shortcuts.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_wayland_hotkeys.json","rust/obs-c-oracle/benches/port_comparison.rs","rust/obs-c-oracle/legacy/graphics-active-shader-queries.c","rust/obs-c-oracle/oracle.d/encoder-get-name.list","rust/obs-c-oracle/oracle.d/graphics-active-shader-queries.list","rust/obs-c-oracle/oracle/device_queries.c","rust/obs-c-oracle/oracle/encoder_get_name.c","rust/obs-c-oracle/oracle/output_interleave.c","rust/obs-c-oracle/oracle/source_audio_pause_callbacks.c","rust/obs-encoder/src/ffi/get_name.rs","rust/obs-encoder/src/ffi/mod.rs","rust/obs-encoder/src/get_name.rs","rust/obs-encoder/src/lib.rs","rust/obs-encoder/tests/encoder/get_name.rs","rust/obs-encoder/tests/encoder/get_name_parity.rs","rust/obs-encoder/tests/encoder/main.rs","rust/obs-graphics/src/active_shader_queries.rs","rust/obs-graphics/src/ffi/active_shader_queries.rs","rust/obs-graphics/src/ffi/mod.rs","rust/obs-graphics/src/lib.rs","rust/obs-graphics/tests/render/active_shader_queries.rs","rust/obs-graphics/tests/render/active_shader_queries_parity.rs","rust/obs-graphics/tests/render/main.rs","rust/obs-output/src/ffi/output_interleave.rs","rust/obs-output/tests/output/interleave_parity.rs","rust/obs-source/src/audio_pause_callbacks.rs","rust/obs-source/src/ffi/mod.rs","rust/obs-source/src/ffi/source_audio_pause_callbacks.rs","rust/obs-source/src/lib.rs","rust/obs-source/tests/source/audio_pause_callbacks.rs","rust/obs-source/tests/source/audio_pause_callbacks_parity.rs","rust/obs-source/tests/source/main.rs","test/cmocka/build/test-graph.json","test/cmocka/encoder-get-name-link-support.c","test/cmocka/output-interleave-name-link-support.c","test/cmocka/test_hotkey_background_state.c","test/cmocka/test_service_find.c","test/cmocka/tests.d/test_hotkey_background_state.cmake","test/cmocka/tests.d/test_service_find.cmake","test/cmocka/tests.d/video_info_query_link_support.cmake"],"head":"923edfbb8903a73d6cf8f3e8b1518958f165e639","tools":{"orchestrator-python":"3.13.15 (main, Aug 14 2026, 15:34:59) [Clang 22.1.3 ]","schema-dependencies":"3.13.15 (main, Aug 14 2026, 15:34:59) [Clang 22.1.3 ]\n{'jsonschema': '4.26.0', 'json_source_map': '1.0.5'}","uv":"uv 0.13.5 (x86_64-unknown-linux-gnu)","xmllint":"xmllint: using libxml version 21504\n   compiled with: Threads Tree Output Push Reader Patterns Writer SAXv1 DTDValid HTML C14N Catalog XPath XPointer XInclude Iconv ISO8859X Regexps Automata RelaxNG Schemas Modules Debug"},"tracked-digest":"366a08cf1473ffd9634bc42147c5b582efafa27c8dada4cd58d22099303402fd","tree":"4e62d28d9d1b107cbd474f98809a290289a2dc90"}}
@zackees zackees added the pool-active Pool worker owns this PR; automated rebases must skip it label Nov 19, 2026
@zackees
zackees enabled auto-merge November 19, 2026 18:59
@zackees zackees removed the pool-active Pool worker owns this PR; automated rebases must skip it label Nov 19, 2026
@zackees
zackees added this pull request to the merge queue Nov 19, 2026
Merged via the queue into master with commit 7d19e18 Nov 19, 2026
43 checks passed
@zackees
zackees deleted the test/5267-find-service branch November 19, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant