Repository navigation
Conversation
#5276) Ci-Attestation: {"at":1795125312,"gate":"general/all/client-lint","host":"linux-x86_64","key":"8e7666cb07218fdf9301d6d101a051e688155f4a66e4d552f0135a143338f0b7","lane":"client-lint","parents":["3d84da0df712942b79de8b511d7dade3310e561e"],"secs":142,"stamp":"0b4c0e0a9f6fa3e4bb8b0d94864c4d41","tree":"02bae8e154303d5ad9fdc96885398095d9e3f8d6","v":1,"via":"run"} Ci-Attestation: {"at":1795125320,"gate":"rust/aarch64-apple-darwin/client-clippy","host":"linux-x86_64","key":"8e7666cb07218fdf9301d6d101a051e688155f4a66e4d552f0135a143338f0b7","lane":"client-lint","parents":["3d84da0df712942b79de8b511d7dade3310e561e"],"secs":142,"stamp":"e1f0e16230147c0bebdc76ae441b325b","tree":"02bae8e154303d5ad9fdc96885398095d9e3f8d6","v":1,"via":"run"} Ci-Attestation: {"at":1795125320,"gate":"rust/aarch64-apple-darwin/client-dylint","host":"linux-x86_64","key":"8e7666cb07218fdf9301d6d101a051e688155f4a66e4d552f0135a143338f0b7","lane":"client-lint","parents":["3d84da0df712942b79de8b511d7dade3310e561e"],"secs":142,"stamp":"40a9bf753953b818b6e978525bb0d83a","tree":"02bae8e154303d5ad9fdc96885398095d9e3f8d6","v":1,"via":"run"} Ci-Attestation: {"at":1795125317,"gate":"rust/aarch64-pc-windows-msvc/client-clippy","host":"linux-x86_64","key":"8e7666cb07218fdf9301d6d101a051e688155f4a66e4d552f0135a143338f0b7","lane":"client-lint","parents":["3d84da0df712942b79de8b511d7dade3310e561e"],"secs":142,"stamp":"686b2a48aaaa84bff3a27cad18f3a2ab","tree":"02bae8e154303d5ad9fdc96885398095d9e3f8d6","v":1,"via":"run"} Ci-Attestation: {"at":1795125317,"gate":"rust/aarch64-pc-windows-msvc/client-dylint","host":"linux-x86_64","key":"8e7666cb07218fdf9301d6d101a051e688155f4a66e4d552f0135a143338f0b7","lane":"client-lint","parents":["3d84da0df712942b79de8b511d7dade3310e561e"],"secs":142,"stamp":"469a000d2653b70770a13dae3169c8b6","tree":"02bae8e154303d5ad9fdc96885398095d9e3f8d6","v":1,"via":"run"} Ci-Attestation: {"at":1795125314,"gate":"rust/aarch64-unknown-linux-gnu/client-clippy","host":"linux-x86_64","key":"8e7666cb07218fdf9301d6d101a051e688155f4a66e4d552f0135a143338f0b7","lane":"client-lint","parents":["3d84da0df712942b79de8b511d7dade3310e561e"],"secs":142,"stamp":"ffa2a3b1cc307ae9e0130edf3f4f8935","tree":"02bae8e154303d5ad9fdc96885398095d9e3f8d6","v":1,"via":"run"} Ci-Attestation: {"at":1795125315,"gate":"rust/aarch64-unknown-linux-gnu/client-dylint","host":"linux-x86_64","key":"8e7666cb07218fdf9301d6d101a051e688155f4a66e4d552f0135a143338f0b7","lane":"client-lint","parents":["3d84da0df712942b79de8b511d7dade3310e561e"],"secs":142,"stamp":"323e64591f3ad7d5111601753a28a2bf","tree":"02bae8e154303d5ad9fdc96885398095d9e3f8d6","v":1,"via":"run"} Ci-Attestation: {"at":1795125318,"gate":"rust/x86_64-apple-darwin/client-clippy","host":"linux-x86_64","key":"8e7666cb07218fdf9301d6d101a051e688155f4a66e4d552f0135a143338f0b7","lane":"client-lint","parents":["3d84da0df712942b79de8b511d7dade3310e561e"],"secs":142,"stamp":"dba3a517d72c6975a1cae5854be1daca","tree":"02bae8e154303d5ad9fdc96885398095d9e3f8d6","v":1,"via":"run"} Ci-Attestation: {"at":1795125319,"gate":"rust/x86_64-apple-darwin/client-dylint","host":"linux-x86_64","key":"8e7666cb07218fdf9301d6d101a051e688155f4a66e4d552f0135a143338f0b7","lane":"client-lint","parents":["3d84da0df712942b79de8b511d7dade3310e561e"],"secs":142,"stamp":"98ca54bbc9a06802d3f0ed931e1186b0","tree":"02bae8e154303d5ad9fdc96885398095d9e3f8d6","v":1,"via":"run"} Ci-Attestation: {"at":1795125315,"gate":"rust/x86_64-pc-windows-msvc/client-clippy","host":"linux-x86_64","key":"8e7666cb07218fdf9301d6d101a051e688155f4a66e4d552f0135a143338f0b7","lane":"client-lint","parents":["3d84da0df712942b79de8b511d7dade3310e561e"],"secs":142,"stamp":"f9eab5c898c9794b8a08ecc660022ec3","tree":"02bae8e154303d5ad9fdc96885398095d9e3f8d6","v":1,"via":"run"} Ci-Attestation: {"at":1795125316,"gate":"rust/x86_64-pc-windows-msvc/client-dylint","host":"linux-x86_64","key":"8e7666cb07218fdf9301d6d101a051e688155f4a66e4d552f0135a143338f0b7","lane":"client-lint","parents":["3d84da0df712942b79de8b511d7dade3310e561e"],"secs":142,"stamp":"de490907dd2b7df109d589c814ae7a68","tree":"02bae8e154303d5ad9fdc96885398095d9e3f8d6","v":1,"via":"run"} Ci-Attestation: {"at":1795125313,"gate":"rust/x86_64-unknown-linux-gnu/client-clippy","host":"linux-x86_64","key":"8e7666cb07218fdf9301d6d101a051e688155f4a66e4d552f0135a143338f0b7","lane":"client-lint","parents":["3d84da0df712942b79de8b511d7dade3310e561e"],"secs":142,"stamp":"ab0fd5c92e98bef7ee41bba77343a7a4","tree":"02bae8e154303d5ad9fdc96885398095d9e3f8d6","v":1,"via":"run"} Ci-Attestation: {"at":1795125314,"gate":"rust/x86_64-unknown-linux-gnu/client-dylint","host":"linux-x86_64","key":"8e7666cb07218fdf9301d6d101a051e688155f4a66e4d552f0135a143338f0b7","lane":"client-lint","parents":["3d84da0df712942b79de8b511d7dade3310e561e"],"secs":142,"stamp":"03cf1add0c268673e0df4663464a7786","tree":"02bae8e154303d5ad9fdc96885398095d9e3f8d6","v":1,"via":"run"}
zackees
enabled auto-merge
November 19, 2026 22:15
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #5276.
Extract only
obs_sceneitem_get_groupintolibobs/obs-scene-item-get-group.c.h. Its body is byte-identical to the original. The shared staticget_sceneitem_parent_groupstays inobs-scene.c.hfor reorder callers, behind the real callableobs_sceneitem_parent_group_lookupseam; the wrapper reuses the existing C full-lock entry points. The sorted unity entry sits with the item helpers so it merges cleanly with the defer-update swap at65de4f86f.The new portable C characterization records rejection before locking and exactly one balanced lock/lookup/unlock, then exercises the actual linked helper for first-match parent-group identity, foreign/absent groups and the exact borrowed pointer without added references. It also pins the existing removed-flag and NULL-context behavior. The tests.d pointer and sorted canonical graph register the fixture on every supported host, using real private layouts and no OBS startup or own threads. Existing C tests, public headers, Rust sources and WebSocket remain untouched.
Original-C characterization commit
8070b0faapassed 25 repetitions per library. RED2bbac6c55failed its compiler replay on the absent extraction include; earlier environment-only attempts are excluded from that evidence. GREEN3d84da0dfsupplies the unchanged body, followed by the mechanical filename/include placement change. The wholenative_build::module passed all 322 tests with no failures or ignored cases. One primary clud-review reviewer found no actionable defects, including the rename delta.Linux Tier 2 built the new target plus EVERY one of the 66 configured
*_rusttargets, with keep-going enabled. The new fixture passed 25 repetitions per library, and unchanged group-empty-bounds, active-ref and transform-clipboard suites passed against each library. Both export sets are identical at 1,769 symbols.ci/windows_link_check.pypassed all eight Windows category links, hybrid libobs and all 57 configured Rust-static fixtures on each of Windows MSVC x86_64 and Darwin arm64. The new C fixture also compiled and linked explicitly on both targets. The single fullSOLDR_PORCELAIN=0 ./lintrun passed in 448.8 seconds, including formatting, validators, inventories and repository self-tests. Unchanged Rust formatting/analysis inputs reused matching soldr passing verdicts where reported.Forced-fetch merge-tree checks covered current overlapping PRs #4124, #5142, #5155, #5246, #5280 and #5286, plus required heads #5272/#5268, the pinned/remote defer-update branch
65de4f86fand current masterfb7d018d5. This change introduces no conflicts; #4124/#5155 retain conflicts already present against the unchanged baseline. All temporary refs were deleted.This is the C-only prerequisite. The subsequent obs-scene Rust swap must add its unit/differential/mutation coverage and connect the unchanged recorder through real adapters in every standalone consumer. Network Tier 4 does not apply. Native Windows/macOS execution and hosted PR/merge-group results are not claimed. There is no user-visible behavior change requiring a features-ledger entry.
The repository push entry point published signed head
4e5dc34be5516f9ea45c274def061fecc8551900with an unchanged validated tree. Six-target client Clippy/Dylint passed in 138.9 seconds. The optional client-checks repetition timed out intest_pr_attestation.pyafter 600 seconds (its timeout handler then raised a TypeError), so complete client admission was not granted; ordinary selected PR CI remains required. The mandatory local full lint and unit-specific validation above passed.