Repository navigation
Conversation
This was referenced Oct 20, 2026
Contributor
Author
|
Final verification for Driver
The diff changes four test files only. Runtime code, queue limits, subprocess timeouts, protocols and dependencies are unchanged. The native skill-discovery test outer budget is explicitly 30 seconds, as in the other native contract tests. Both PRs include their current main base with zero behind commits. No paid model Session, real-provider acceptance run or deployment was added. Land this Driver change first, then repin Host #684 to its landed main commit before merging the Host PR. Host #693 keeps its pricing-only scope and original Driver pin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The below-limit backpressure test can fail after
drainServerMessages()returns because that method drains admitted messages. It does not wait for the child process to finish writing the whole burst.Wait for both the child write callback marker and delivery of the last notification. Read fresh file state after that signal. Keep the blocked-handler assertion, 900-message delivery, 1,024-message queue limit, overflow rejection, and exact protocol-error count.
The backpressure hunk is extracted from #136 onto current
main. Additional fixture failures were reproduced during the complete local checks below. The final diff changes four test files only. It contains no runtime, cancellation, recovery, protocol, dependency, or generated-file changes.The ACP file-report fixture used matching 50 ms timers for the provider response and file-report failure. The report could fail before the response was accepted, while the assertions required the response-accepted path. Wait for the existing permission-ingress closure before releasing the failed report. Keep the terminal fence, exact error, one failed terminal, lifecycle failure, disconnected state, and cleanup checks.
The cancellation/recycle fixture could release its cancellation-event gate after the provider logged
session/cancel, before the provider wrote the late-child PID. Wait for that PID before releasing the gate. The existing assertion still requires the child to be gone before the session resumes.The ACK-unknown terminal-creation fixture also requires a real child PID for its cleanup assertion. Wait for the child to write that PID inside the first created-event callback, before injecting receipt loss. Retain replay identity, process-exit, terminal-capacity, and release-retry assertions.
The native skill-discovery test runs two CLI commands, each with an existing 10-second bound. Set its outer test budget to the same 30 seconds used by the other native contract tests in this file. The previous default five-second test deadline could interrupt the second command and leak a late assertion. Keep the subprocess bounds and discovery/removal assertions unchanged.
Verification