Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the Preview smoke-test credential helper to fill the current Add Key dialog, then ensure the newly created credential is the provider's default.
Why
The helper still searches the provider card for fields and an obsolete checkbox that moved into a dialog. The smoke test times out before reaching Preview. Looking only for any Default badge can also reuse an older credential. Scope the form to its dialog and default selection to the new credential row.
Related to the dialog and console work in #617 and #621. Extracted from #693 following review request 6. Existing issues and PRs were searched; no dedicated open issue was found. No issue is closed by this PR.
Verification
just e2e e2e/cases/ui/preview-credential-dialog.spec.tswith a local external config selecting installed Chrome: 2 passed.just tc-package @mosoo/e2e;just lint;just commit-check: passed.just checkwas attempted on local Linux (Bun 1.4.0): format/docs/lint/type stages passed; unchanged Driver tests had three failures (backpressure plus ACK-unknown terminal creation and committed-file lifecycle timeouts; 2,279 passed / 47 skipped / 3 failed). This initial full-gate failure is retained, not claimed as a pass.Review
configureProviderCompanyKeyand its isolated browser regression cases.Impact
Design
N/A: no product UI changes.