Repository navigation
Conversation
FradSer
marked this pull request as ready for review
October 16, 2026 07:45
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Limit hooks without an explicit stage to
pre-commit. Keep the commit-message validator explicitly oncommit-msg.Why
With both hook types installed, unstaged shared hooks also run at commit-message time. A commit-message validation should not rerun formatting, lint, or staged-file checks. This supplies the missing default stage without changing the explicit validator stage.
Extracted from the unrelated tooling changes removed from #693 at review request 6. Existing issues and PRs were searched; no dedicated open issue was found. No issue is closed by this PR.
Verification
just fmt-check;just commit-check.prek -c config/prek.toml run --stage commit-msg --commit-msg-filename .tmp/COMMIT_EDITMSG: only the commit-message validator runs and passes.prek -c config/prek.toml run --stage pre-commit --files config/prek.toml: applicable hooks pass.commit-msg.just checkwas attempted on local Linux (Bun 1.4.0): format/docs/lint/type stages passed; the unchanged Driver backpressure fixture failed (openai-app-server-client.test.ts:2055; 2,281 passed / 47 skipped / 1 failed). This initial full-gate failure is retained, not claimed as a pass.Review
config/prek.toml.Impact
Design
N/A: no product UI changes.