Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep Host provisioning paths separate from optional ACP session directories for OpenCode (
acp-fallback). Continue creating the cache, home, and working directories on the Host while sending no optional directories to this provider.Why
The API sends Host cache/home/cwd paths as
additionalDirectories. OpenCode does not advertise the optional ACP directory capability, so the Driver rejects the execution spec before starting a session. Rename the internal path helper to describe provisioning and send an empty optional-directory list for OpenCode. The session cwd and native home remain present in their existing fields.Related history: Mosoo #402 and Driver #86 address the same OpenCode capability boundary. Extracted from #693 following review request 6. No dedicated current open issue was found, and no issue is closed here.
Verification
just test-file apps/api/tests/api-driver-boundary.test.ts: 14 passed, including an OpenCode spec with no optional directories and preserved cwd/home.just test-file apps/api/tests/runtime-model-connection.test.ts: 44 passed.just tc-package @mosoo/api;just lint;just commit-check: passed.just checkpassed on this exact head in an isolated local Linux environment (Bun 1.4.0, Node 24.22.0): Driver 2,282 passed / 47 skipped / 0 failed, API 1,174 passed / 1 skipped / 0 failed. Formatting, docs, lint, type checks, GraphQL freshness and Public API compatibility also passed.Review
Impact
Design
N/A: no product UI changes.