Repository navigation
feat(deploy): Run the distroless vroom image in s4s2 - #716
Merged
Merged
Conversation
Deploy the <sha>-distroless tag to s4s2 and keep every other region on the current image, to validate the distroless variant in one region first. Co-Authored-By: Claude <noreply@anthropic.com>
mjq
approved these changes
Oct 7, 2026
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploy
us-central1-docker.pkg.dev/sentryio/vroom/vroom:<sha>-distrolessto s4s2 and keep every other region on the current<sha>image, to validate the distroless variant in one region before rolling it out further. Same approach as snuba (getsentry/snuba#8047).deploy.shis shared by the canary and primary stages, so it computes the tag once and branches only onSENTRY_REGION. The next steps (de, then the remaining regions) are one-line changes to that condition, and reverting this PR puts s4s2 back on the debian image.Important
Stacked on #715 and must merge after it has run on
main: until then the-distrolesstag doesn't exist in Artifact Registry and the s4s2 deploy would fail to pull.A GoCD rollback in s4s2 to a commit from before #715 would also fail to pull, since older commits have no
-distrolesstag. To roll back past #715, revert this PR instead.The Kubernetes side is already shell-free: readiness is
httpGet /health, and the preStop hook isvroom drain. After the s4s2 deploy, check that pods become ready,/healthstays 200, there are noFailedPreStopHookevents, and pods take about 25s to terminate.Refs SEC-1098