Repository navigation
Conversation
Extend the distroless rollout from s4s2 and de to us. Switch the region check to a case statement now that it covers three regions. Co-Authored-By: Claude <noreply@anthropic.com>
oioki
marked this pull request as ready for review
October 13, 2026 15:28
mjq
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploy
vroom:<sha>-distrolessto us as well as s4s2 (#716) and de (#720). The single-tenant regions keep the current<sha>image for now. The region check becomes acasestatement now that it lists three regions.de and s4s2 run the distroless image with no restarts or
FailedPreStopHookevents. The profiling smoke test (profiles ingested, then served by vroom as a single profile and a flamegraph) passed with it on a self-hosted install and on the devserver.us has a canary stage, and
deploy.shserves both stages, so the us canary gets the distroless image first andwait-canary.shgates the primary rollout.A GoCD rollback in us to a commit from before #715 would fail to pull, since older commits have no
-distrolesstag. To go back further, revert this PR instead.