Repository navigation
feat(deploy): Run the distroless vroom image in de - #720
Merged
Merged
Conversation
Extend the distroless rollout from s4s2 to de. Every other region keeps the current image. Co-Authored-By: Claude <noreply@anthropic.com>
mjq
approved these changes
Oct 8, 2026
mjq
left a comment
mjq
left a comment
Member
There was a problem hiding this comment.
Approving for whenever you're ready to merge 👍
oioki
marked this pull request as ready for review
October 13, 2026 12:44
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploy
vroom:<sha>-distrolessto de as well as s4s2 (#716). Every other region keeps the current<sha>image. Same step as getsentry/snuba#8090.The distroless image has run in s4s2 since #716. A profiling smoke test (profiles ingested, then served by vroom as a single profile and a flamegraph) passed with it on a self-hosted install and on the devserver. Kubernetes already needs no shell: readiness is
httpGet /healthand the preStop hook isvroom drain.No change to
check-github.shis needed: GoCD already waits forBuild and push production images, and that job pushes the-distrolesstags too (#715).Important
Planned for next week; keep as draft until then.
A GoCD rollback in de to a commit from before #715 would fail to pull, since older commits have no
-distrolesstag. To go back further, revert this PR instead.After the de deploy, check that pods become ready,
/healthstays 200, there are noFailedPreStopHookevents, and pods take about 25s to terminate.Refs SEC-1098