Repository navigation
feat(mobile): split iOS, Android, and HarmonyOS shells (#334 #335 #336) - #337
Merged
Merged
Conversation
This was referenced Sep 18, 2026
Collaborator
Author
|
已确认本 PR 是有意的 stacked PR: 已同步 #330 的 desktop surface 修复,并补回归测试,避免 @PeterGuy326 @Bindy-lbb 请在本轮 CI 完成后对最终 head 做独立正式 review;#330 合并后再将本 PR 落到 |
4 tasks
waterbro-8
changed the base branch from
feat/329-mobile-native-shell
to
main
September 18, 2026 09:46
waterbro-8
force-pushed
the
feat/334-platform-shells
branch
from
September 18, 2026 09:46
b1ca653 to
6591ecc
Compare
Collaborator
Author
|
#330 已合入 main( 本 PR 已改 base 为 main,并 rebase 成最终提交
请审这个最终 head。非阻塞项(CHANGELOG 三处 Added、WebSocket close 未真重连)未在本提交改。 |
sun-970
approved these changes
Sep 18, 2026
sun-970
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed head 6591ecc after it landed on main.
detectPlatform顺序是 HarmonyOS/OpenHarmony/ArkWeb → iOS → Android;混合 UA(Android+HarmonyOS)走 Harmony。/?surface=desktop时resolvePublicAsset返回 null,不会再吐手机壳;scripts/test/mobile-web.test.mjs覆盖了这条回归,以及三端 UA 各拿自己的 shell。- CI 11/11 全绿。
非阻塞(与 #330 相同,本提交未改):
- CHANGELOG 仍有多处
### Added - WebSocket
close只提示「正在重试」,没有真正重连
Approve。
7 tasks
This was referenced Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #334 #335 #336 on top of #330.
Phone UAs are no longer one generic shell:
iPhone/iPad) → large title + inset grouped listForce with
?platform=ios|android|harmony. Desktop is unchanged.