fix(varlock): land pending type, import, and leak-scan fixes - #17
Merged
Conversation
Rebase still-valid fork fixes onto current main: enum env-string coerce, url allowedDomains/noTrailingSlash, IPv6-mapped, md5 case, port integers, imported @currentEnv (dmno-dev#428), and finish ServerResponse.end on leak (dmno-dev#897).
github-actions
Bot
added
community
core:varlock
core:parser
core:vscode-plugin
core:website
core:ci-env-info
integration:nextjs
integration:vite
integration:astro
plugin:1password
plugin:infisical
core:utils
plugin:aws-secrets
plugin:azure-key-vault
plugin:bitwarden
plugin:google-secret-manager
plugin:pass
labels
|
The changes in this PR will be included in the next version bump.
|
WalksWithASwagger
marked this pull request as ready for review
September 3, 2026 04:21
📦 Bundle size✅ shrinks the bundle by 467.6 KB (−9.5%)
dist/ only; native binaries are versioned separately and not counted here. |
This was referenced Sep 3, 2026
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebases the still-valid WalksWithASwagger expedition fixes onto current
dmno-dev/varlockmain, plus the two upstream bugs those earlier PRs never actually landed.What landed
@type=enum: coerce stringprocess.env/overrideValuesto numeric and boolean members@type=url: treatallowedDomainscomma-strings as host lists (no substring match); allow root/withnoTrailingSlash=true@type=ip: accept IPv4-mapped IPv6 (::ffff:192.168.1.1)@type=md5: accept uppercase hex and normalize to lowercase@type=port: reject non-integers (including unquoted80.5)#428:@currentEnv=$FLAGmay reference a key brought in via@import#897:ServerResponse.endfinishes the response (500 / destroy) when leak detection throwsNot included (already on main or superseded)
prependHttpsskipping an existing protocol (already fixed upstream)@sensitivevalues for leak scanning (superseded by Check that sensitive values can actually be redacted dmno-dev/varlock#1054: numbers are unredactable by design)Test plan
cd packages/varlock && bunx vitest run src/env-graph/test/data-types.test.ts src/env-graph/test/environments.test.ts src/runtime/test/patch-server-response.test.ts(237 passed, 1 skipped)Docs for the changed behavior are updated in the same PR (
data-types,root-decorators,import,secrets).Compare for upstream: https://github.com/dmno-dev/varlock/compare/main...WalksWithASwagger:varlock:cursor/land-pending-fixes-6586?expand=1