fix(varlock): accept IPv4-mapped IPv6 addresses in @type=ip - #12
Closed
WalksWithASwagger wants to merge 1 commit into
Closed
fix(varlock): accept IPv4-mapped IPv6 addresses in @type=ip#12WalksWithASwagger wants to merge 1 commit into
WalksWithASwagger wants to merge 1 commit into
Conversation
IP_V6_ADDRESS_REGEX double-escaped dots in the embedded IPv4 octets (\\.), so addresses like ::ffff:192.168.1.1 never matched. Use \. like the IPv4 regex.
|
The changes in this PR will be included in the next version bump.
|
📦 Bundle size✅ shrinks the bundle by 0.0 KB (−0.0%)
dist/ only; native binaries are versioned separately and not counted here. |
Owner
Author
|
Landed on current main via #17 (rebased onto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@type=ip(version=6)rejected valid IPv4-mapped addresses like::ffff:192.168.1.1because the IPv6 regex used\\.for dotted IPv4 octets inside a regex literal (matches backslash + any char, not.).Changes
\.for embedded IPv4 octets (same as the IPv4 regex)Test plan
bunx vitest run src/env-graph/test/data-types.test.ts -t "ip data type"Open on upstream: https://github.com/dmno-dev/varlock/compare/main...WalksWithASwagger:varlock:cursor/fix-ipv6-mapped-address-21b2?expand=1