fix(varlock): register numeric @sensitive values for leak scanning - #7
Closed
WalksWithASwagger wants to merge 1 commit into
Closed
fix(varlock): register numeric @sensitive values for leak scanning#7WalksWithASwagger wants to merge 1 commit into
WalksWithASwagger wants to merge 1 commit into
Conversation
Finite numbers (and nested numeric elements) are now collected into the redaction/leak map, and sensitive 0 is no longer skipped by a falsy check. Pretty output also redacts numeric sensitive values.
|
The changes in this PR will be included in the next version bump.
|
📦 Bundle size
dist/ only; native binaries are versioned separately and not counted here. |
Owner
Author
|
Superseded by #17, which rebases the still-valid expedition fixes onto current This specific change (registering numeric |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@type=number @sensitivevalues (e.g. PINs) were injected intoprocess.envas strings but never registered in the redaction/leak map, soscanForLeaksand log redaction silently ignored them.Changes
collectSensitiveStrings0via a falsy!item.valuecheck"true"/"false"would false-positive everywhere)Test plan
bunx vitest run src/runtime/test/scan-for-leaks.test.tsTo open against upstream: https://github.com/dmno-dev/varlock/compare/main...WalksWithASwagger:varlock:cursor/fix-sensitive-number-redaction-21b2?expand=1