fix(varlock): accept uppercase hex for @type=md5 - #14
Closed
WalksWithASwagger wants to merge 1 commit into
Closed
Conversation
MD5 hashes from tools are often uppercase; UUID already used a case-insensitive regex. Accept A-F and normalize to lowercase.
|
The changes in this PR will be included in the next version bump.
|
Owner
Author
|
Landed on current main via #17 (rebased onto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@type=md5only accepted lowercase hex. Uppercase hashes (common from tools) failed validation even though UUID already uses a case-insensitive check.Changes
Test plan
bunx vitest run src/env-graph/test/data-types.test.ts -t "md5 data type"Open on upstream (from your laptop as WalksWithASwagger):
https://github.com/dmno-dev/varlock/compare/main...WalksWithASwagger:varlock:cursor/fix-md5-uppercase-21b2?expand=1