Try to recover pending download missions when possible#12550
Try to recover pending download missions when possible#12550TobiGr merged 2 commits intoTeamNewPipe:devfrom
Conversation
|
Steps to follow for rigorously testing the fix under different conditions:
|
Does |
… gets killed Author: InfinityLoop1308 Adapted for NewPipe from a fork's this commit InfinityLoop1308/PipePipeClient@1cf059c
23793e3 to
9282cce
Compare
TobiGr
left a comment
There was a problem hiding this comment.
I tested this multiple times and did not run into new issues. Changes LGTM.
Isira-Seneviratne
left a comment
There was a problem hiding this comment.
The changes look good to me as well.
What is it?
Description of the changes in your PR
This PR changes the app behavior where it considers ERROR_PROGRESS_LOST as invalid storage, however where it is possible to recover the pending download missions, it tries for that.
Fixes the following issue(s)
Fix app can't resume paused downloads in certain following situations:
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence