Download queue deletes when switching to battery save mode

[ManmadeStarch]

Checklist

• I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
• I made sure that there are no existing issues - open or closed - which I could contribute my information to.
• I have read the FAQ and my problem isn't listed.
• I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
• This issue contains only one bug.
• I have read and understood the contribution guidelines.

Affected version

0.25.2

Steps to reproduce the bug

Hello,

I found out that download queue clears itself when switching to power saving mode.

How to reproduce:
Go and download anything (I used tp download ca. 7 MB 360p video).
Since I used mobile data and slow internet (around 10 kB/s) I had to start download manually.

Expected behavior

To at least keep the download queue but pause the download or even to keep downloading.

Actual behavior

At some point my phone switched to power save mode (when falling under 20% battery) and when I opened the app, there were only previous downloads and none from download queue. The file itself was still present but incomplete.

I also noticed that the app tends to throw an error and pauses downloading when with slow speeds, but starting it again solves the issue.

Screenshots/Screen recordings

No response

Logs

No response

Affected Android/Custom ROM version

android 13 / calyxos 4.14.0

Affected device model

Google pixel 4a

Additional information

This is the explained battery saver from settings:
Battery saver turns on dark mode, limits or turns off background activity, certain visual effects, some features and some network connections.

[DemonoidMaster]

They don't care, this won't get fixed ever despite it being easy to change with a bit of effort lol

They need to make shit that is downloading but paused NOT get wiped from the list if the app crashes, is closed or gets forcefully refreshed due to Android being Android

1.2k open issues and they seem to be slacking hard, they may as well just close the project if it's dead, easier to just use youtube revanced at this point

[ABJ4403]

I think its because in power saving mode, NewPipe background process is stopped to save power. When you reopened it again, all previous incomplete download will be cleared instead of saved in a downloads db, idk how its implemented, but maybe save the download stuff to a database, or dont clear any downloads automatically except explicitly told by the user

Temporary workaround would be to disable battery optimization for NewPipe, and not closing the app if there is a download still in progress

[DemonoidMaster]

I think its because in power saving mode, NewPipe background process is stopped to save power. When you reopened it again, all previous incomplete download will be cleared instead of saved in a downloads db, idk how its implemented, but maybe save the download stuff to a database, or dont clear any downloads automatically except explicitly told by the user

Temporary workaround would be to disable battery optimization for NewPipe, and not closing the app if there is a download still in progress

Which is something that's stupidly implemented really, why stick a download manager inside the app if it can't do the basics, like yknow, continue the download later on after being paused? After an app crash, refresh, etc you name it.

If they won't fix it then then let us pick which download manager we want to use instead

[ShareASmile]

At some point my phone switched to power save mode (when falling under 20% battery) and when I opened the app, there were only previous downloads and none from download queue. The file itself was still present but incomplete.

@ManmadeStarch @ABJ4403 please test the APK of #12550 and report whether it fixes the problem for you.

[ABJ4403]

Ayy it works, tried downloading a video and subtitle, paused, force stop the app, reopen, its still there, it also downloads again until its 100% 🥳 (tho idk if it still works if i force stop then wait for so long then start download again), hopefully immediately merged

[ShareASmile]

Thank you for testing it, you can test it more rigorously for longer time by steps
described in this comment and report it in the linked PR.